GNU bug report logs - #9387
[PATCH] new standard keybindings for recentf-dialog

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9387 in the body.
You can then email your comments to 9387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Florian Adamsky <florian <at> adamsky.it>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] new standard keybindings for recentf-dialog
Date: Sat, 27 Aug 2011 21:35:21 +0200

[Message part 1 (text/plain, inline)]

** Description

I added two new keybindings to recentf-dialog for next-line (kbd "n")
and previous-line (kbd "p") in order to make it more consistent with
other major-modes like dired, ibuffer or org-mode.

** ChangeLog

2011-09-27 Florian Adamsky (florian <at> adamsky.it)

       * recentf.el (recentf-dialog-mode-map): Added two keybindings
         for next-line "n" and previous-line "p" in order to make
         recentf more consistent with ibuffer, dired or org-mode.

** The patch itself

index fc9b788..01efecf 100644
--- a/lisp/recentf.el
+++ b/lisp/recentf.el
@@ -1061,6 +1061,8 @@ Go to the beginning of buffer if not found."
   (let ((km (copy-keymap recentf--shortcuts-keymap)))
     (set-keymap-parent km widget-keymap)
     (define-key km "q" 'recentf-cancel-dialog)
+    (define-key km "n" 'next-line)
+    (define-key km "p" 'previous-line)
     (define-key km [follow-link] "\C-m")
     km)
   "Keymap used in recentf dialogs.")

[recentf.el.diff (text/x-patch, attachment)]

Message #10 received at 9387 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Florian Adamsky <florian <at> adamsky.it>
Cc: 9387 <at> debbugs.gnu.org
Subject: Re: [PATCH] new standard keybindings for recentf-dialog
Date: Sun, 11 Sep 2011 04:15:58 +0200

Florian Adamsky <florian <at> adamsky.it> writes:

> 2011-09-27 Florian Adamsky (florian <at> adamsky.it)
>
>        * recentf.el (recentf-dialog-mode-map): Added two keybindings
>          for next-line "n" and previous-line "p" in order to make
>          recentf more consistent with ibuffer, dired or org-mode.

Looks good.  However, Emacs is in a feature freeze.  I've marked the
report as "pending", which means that it'll be applied when Emacs
unfreezes again.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #13 received at 9387 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Florian Adamsky <florian <at> adamsky.it>
Cc: 9387 <at> debbugs.gnu.org
Subject: Re: bug#9387: [PATCH] new standard keybindings for recentf-dialog
Date: Tue, 10 Apr 2012 04:45:41 +0200

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

>>        * recentf.el (recentf-dialog-mode-map): Added two keybindings
>>          for next-line "n" and previous-line "p" in order to make
>>          recentf more consistent with ibuffer, dired or org-mode.
>
> Looks good.  However, Emacs is in a feature freeze.  I've marked the
> report as "pending", which means that it'll be applied when Emacs
> unfreezes again.

I've now applied this patch to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.