GNU bug report logs - #9409
24.0.50; log-view-msg-prev, easy-mmode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9409 in the body.
You can then email your comments to 9409 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eduard Wiebe <usenet <at> pusto.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; log-view-msg-prev, easy-mmode
Date: Tue, 30 Aug 2011 21:31:59 +0200

[Message part 1 (text/plain, inline)]

 Hi all,

it bothers me that in some situation i cannot reach the head information
of the `vc-print-log' via `log-view-msg-prev'.

I fixed the issue by following simple patch.

[easy-mmode.el.patch (text/x-diff, inline)]

=== modified file 'lisp/emacs-lisp/easy-mmode.el'
--- lisp/emacs-lisp/easy-mmode.el	2011-01-25 04:08:28 +0000
+++ lisp/emacs-lisp/easy-mmode.el	2011-08-27 16:50:49 +0000
@@ -578,7 +578,8 @@
 	 (if (< count 0) (,next-sym (- count))
            ,(funcall when-narrowed
              `(unless (re-search-backward ,re nil t count)
-                (error "No previous %s" ,name)))
+                (goto-char (point-min))
+		(error "No previous %s" ,name)))
            ,@body))
        (put ',prev-sym 'definition-name ',base))))
 

Message #8 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eduard Wiebe <usenet <at> pusto.de>
Cc: 9409 <at> debbugs.gnu.org
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Fri, 02 Sep 2011 20:37:08 -0400

Eduard Wiebe wrote:

>               `(unless (re-search-backward ,re nil t count)
> -                (error "No previous %s" ,name)))
> +                (goto-char (point-min))
> +		(error "No previous %s" ,name)))

Or:

-             `(unless (re-search-backward ,re nil t count)
+             `(unless (re-search-backward ,re nil 'move count)

Message #11 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Eduard Wiebe <usenet <at> pusto.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 9409 <at> debbugs.gnu.org
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Sat, 03 Sep 2011 19:41:07 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> Eduard Wiebe wrote:
>
>>               `(unless (re-search-backward ,re nil t count)
>> -                (error "No previous %s" ,name)))
>> +                (goto-char (point-min))
>> +		(error "No previous %s" ,name)))
>
> Or:
>
> -             `(unless (re-search-backward ,re nil t count)
> +             `(unless (re-search-backward ,re nil 'move count)

Yes, much nicer. Thanks.
Can you apply this patch to the trunk.

-- 
Eduard Wiebe

Message #14 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eduard Wiebe <usenet <at> pusto.de>
Cc: 9409 <at> debbugs.gnu.org
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Tue, 06 Sep 2011 20:40:01 -0400

Eduard Wiebe wrote:

> Can you apply this patch to the trunk.

I'm not sure if the change is appropriate, for all users of that macro.
(I don't have much of an opinion about it.)

Message #17 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 9409 <at> debbugs.gnu.org, Eduard Wiebe <usenet <at> pusto.de>
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Wed, 07 Sep 2011 08:39:27 -0400

>> Can you apply this patch to the trunk.
> I'm not sure if the change is appropriate, for all users of that macro.
> (I don't have much of an opinion about it.)

I think the change is a good one.  So if someone could check the various
uses of that macro to make sure it doesn't break anything, we can
install it.


        Stefan

Message #20 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Eduard Wiebe <usenet <at> pusto.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9409 <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Tue, 13 Sep 2011 21:38:40 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> Can you apply this patch to the trunk.
>> I'm not sure if the change is appropriate, for all users of that macro.
>> (I don't have much of an opinion about it.)
>
> I think the change is a good one. 

1+

> So if someone could check the various uses of that macro to make sure
> it doesn't break anything, we can install it.

I found following uses of the macro:

  1889060   84 -rw-r--r--   1 ew       ew          80974 Sep  9 20:59 vc/diff-mode.el
  1892302   24 -rw-r--r--   1 ew       ew          21559 Aug 27 17:25 vc/log-view.el
  1892363   56 -rw-r--r--   1 ew       ew          51035 Aug 27 17:25 vc/smerge-mode.el
  1889741   20 -rw-r--r--   1 ew       ew          17799 Aug 27 17:25 vc/cvs-status.el

I patched `easy-mmode-define-navigation' as above and tested (marked as X) the
most functions without any trouble.

* diff-mode.el
  - [X] diff-hunk-prev
  - [X] diff-hunk-next
  - [X] diff-file-prev
  - [X] diff-file-next

* log-view.el
  - [X] log-view-msg-prev
  - [X] log-view-msg-next
  - [ ] log-view-file-prev
  - [ ] log-view-file-next

* smerge-mode
  - [ ] smerge-next
  - [ ] smerge-prev

* cvs-status
  - [X] cvs-status-next
  - [X] cvs-status-prev

-- 
Eduard Wiebe

Message #23 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Eduard Wiebe <usenet <at> pusto.de>
Cc: 9409 <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Tue, 13 Sep 2011 17:02:09 -0400

> I patched `easy-mmode-define-navigation' as above and tested (marked
> as X) the most functions without any trouble.

> * diff-mode.el
>   - [X] diff-hunk-prev
>   - [X] diff-hunk-next
>   - [X] diff-file-prev
>   - [X] diff-file-next

> * log-view.el
>   - [X] log-view-msg-prev
>   - [X] log-view-msg-next
>   - [ ] log-view-file-prev
>   - [ ] log-view-file-next

> * smerge-mode
>   - [ ] smerge-next
>   - [ ] smerge-prev

> * cvs-status
>   - [X] cvs-status-next
>   - [X] cvs-status-prev

If a problem shows up it's not going to be in the *-prev commands, but
in commands that call those functions internally.  So you need to check
the callers of diff-hunk-prev, diff-file-prev, etc..
It's always good to check with actual testing, but it's also important
to check by looking at the code.  IIUC this will be safe because in the
case where the behavior is changed, the function signals an error, so
only callers which catch this error (with condition-case) might
be affected.


        Stefan

Message #28 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 9409 <at> debbugs.gnu.org, 14531 <at> debbugs.gnu.org
Subject: Re: bug#14531: 24.3.50; `log-view-file-prev' doesn't move to the
 beginning of the log buffer
Date: Fri, 25 Sep 2020 13:01:43 +0200

Xue Fuqiao <xfq.free <at> gmail.com> writes:

> In (info "(emacs) VC Change Log"):
>   `P'
>      Move to the log of the previous file, if showing logs for a
>      multi-file VC fileset.  Otherwise, just move to the beginning of
>      the log.  A numeric prefix argument is a repeat count.
>
> I tried visiting a random Emacs Lisp file (calc.el) in the bzr repo, and
> then execute `vc-print-log'.  It isn't a multi-file fileset, but
> pressing `P' does not move to the beginning of the log buffer.  Instead,
> an error message "No previous file" occurs.

I'm not sure what that command is meant to do, even after reading the
documentation and reading the code (and even reading the code doesn't
help that much, because these are easy-mmode-define-navigation
incantation).

It searches for the prev instance of:

log-view-file-re
"^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):\\)
"

in the *vc-change-log* buffer?  But ... there's nothing like that in a
git buffer?

So `P'/`N' always fails for me.  Is this just code that has bitrotted,
or is the use case just not...  explained well?

This bug was merged with:

Eduard Wiebe <usenet <at> pusto.de> writes:

> it bothers me that in some situation i cannot reach the head information
> of the `vc-print-log' via `log-view-msg-prev'.
>
> I fixed the issue by following simple patch.

[...]

> -                (error "No previous %s" ,name)))
> +                (goto-char (point-min))
> +		(error "No previous %s" ,name)))

I don't understand what's meant by "the head information", but the
`n'/`p' commands in *vc-change-log* buffers seems to work well for me?

Test case:

C-x C-f calc.el
C-x v l
n
p
p

So these seem to be different bugs and the second bug has been fixed in
the intervening years?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #31 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 9409 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 14531 <at> debbugs.gnu.org
Subject: Re: bug#14531: 24.3.50; `log-view-file-prev' doesn't move to the
 beginning of the log buffer
Date: Thu, 05 May 2022 14:28:00 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> In (info "(emacs) VC Change Log"):
>>   `P'
>>      Move to the log of the previous file, if showing logs for a
>>      multi-file VC fileset.  Otherwise, just move to the beginning of
>>      the log.  A numeric prefix argument is a repeat count.
>>
>> I tried visiting a random Emacs Lisp file (calc.el) in the bzr repo, and
>> then execute `vc-print-log'.  It isn't a multi-file fileset, but
>> pressing `P' does not move to the beginning of the log buffer.  Instead,
>> an error message "No previous file" occurs.
>
> I'm not sure what that command is meant to do, even after reading the
> documentation and reading the code (and even reading the code doesn't
> help that much, because these are easy-mmode-define-navigation
> incantation).
>
> It searches for the prev instance of:
>
> log-view-file-re
> "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes to
> \\)\\(?1:.+\\):\\)
> "
>
> in the *vc-change-log* buffer?  But ... there's nothing like that in a
> git buffer?
>
> So `P'/`N' always fails for me.  Is this just code that has bitrotted,
> or is the use case just not...  explained well?

Perhaps these commands are CVS/RCS/SCCS-specific, and shouldn't be
enabled in general?  Because they're pretty confusing as is, and should
(at the very least) explain better what they're attempting to do.

I've added Stefan and Dmitry to the CCs; perhaps they have some insights
here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #36 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Xue Fuqiao <xfq.free <at> gmail.com>, 9409 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>, 14531 <at> debbugs.gnu.org
Subject: Re: bug#14531: 24.3.50; `log-view-file-prev' doesn't move to the
 beginning of the log buffer
Date: Thu, 05 May 2022 15:58:34 -0400

Lars Ingebrigtsen [2022-05-05 14:28:00] wrote:
>>> In (info "(emacs) VC Change Log"):
>>>   `P'
>>>      Move to the log of the previous file, if showing logs for a
>>>      multi-file VC fileset.  Otherwise, just move to the beginning of
>>>      the log.  A numeric prefix argument is a repeat count.
[...]
> Perhaps these commands are CVS/RCS/SCCS-specific,

Indeed, I think this command doesn't make much sense in current VCSs.
It made sense for CVS where `cvs log <dir>` would give the logs of every
file in <dir>, one after the other.


        Stefan

Message #39 received at 9409 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Xue Fuqiao <xfq.free <at> gmail.com>, 9409 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>, 14531 <at> debbugs.gnu.org
Subject: Re: bug#14531: 24.3.50; `log-view-file-prev' doesn't move to the
 beginning of the log buffer
Date: Fri, 06 May 2022 13:45:49 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> Indeed, I think this command doesn't make much sense in current VCSs.
> It made sense for CVS where `cvs log <dir>` would give the logs of every
> file in <dir>, one after the other.

Right.  So I've now made new tiny derived log-view modes for these VCs,
and removed the bindings in the general log-view map in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.