GNU bug report logs - #9414
Use of 'grep-find-ignored-directories' exclude files from search.

Previous Next

Package: emacs;

Reported by: Oleksandr Gavenko <gavenkoa <at> gmail.com>

Date: Wed, 31 Aug 2011 21:48:01 UTC

Severity: normal

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9414 in the body.
You can then email your comments to 9414 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#9414; Package emacs. (Wed, 31 Aug 2011 21:48:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Oleksandr Gavenko <gavenkoa <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 31 Aug 2011 21:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Use of 'grep-find-ignored-directories' exclude files from search.
Date: Thu, 01 Sep 2011 00:44:11 +0300

[Message part 1 (text/plain, inline)]
GNU Emacs 23.3.1 (i386-mingw-nt6.1.7601) of 2011-03-10 on 3249CTO

If set:

  (add-to-list 'grep-find-ignored-directories "build" t)

and try search M-x rgrep in hierarchy:

  build/xxx
  src/yyy
  src/build
  build

  $ mkdir  build src;
  $ touch  build/xxx src/yyy src/build

'find' part of 'rgrep' print only (I simplify expression of 'rgrep'):

  $ find . '(' -path '*/build' -o -path '*/lib' ')' \
     -prune -o  -type f  -print
./src/yyy

Correct one is:

  $ find . '(' -type d -path '*/build' -o -path '*/lib' ')' \
     -prune -o  -type f  -print
./src/build
./src/yyy

So any dir added to 'grep-find-ignored-directories' also affected to
*regular* file names...

I previously file bug to findutils, but I am wrong:

  http://savannah.gnu.org/bugs/?34159

This is Emacs bug.

I suggest fix in patch.

[grep-find-ignored-directories.patch (text/plain, attachment)]
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#9414; Package emacs. (Wed, 31 Aug 2011 22:37:02 GMT) Full text and rfc822 format available.

Message #8 received at 9414 <at> debbugs.gnu.org (full text, mbox):

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: 9414 <at> debbugs.gnu.org
Subject: Fixed patch.
Date: Thu, 01 Sep 2011 01:33:07 +0300

[Message part 1 (text/plain, inline)]
Previous patch is wrong (I miss 'find' options priority).

This one right (more priestly tested and work fine).

[grep-find-ignored-directories_2.patch (text/plain, attachment)]
Reply sent to Juri Linkov <juri <at> jurta.org>:
You have taken responsibility. (Mon, 05 Sep 2011 10:02:02 GMT) Full text and rfc822 format available.
Notification sent to Oleksandr Gavenko <gavenkoa <at> gmail.com>:
bug acknowledged by developer. (Mon, 05 Sep 2011 10:02:02 GMT) Full text and rfc822 format available.

Message #13 received at 9414-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Cc: 9414-done <at> debbugs.gnu.org
Subject: Re: bug#9414: Fixed patch.
Date: Mon, 05 Sep 2011 12:55:32 +0300

> Previous patch is wrong (I miss 'find' options priority).
>
> This one right (more priestly tested and work fine).

Thank you.  This patch is now committed.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 03 Oct 2011 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 216 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.