GNU bug report logs - #9451
GTK3 toolbar style

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9451 in the body.
You can then email your comments to 9451 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Facchini <stefano.facchini <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: GTK3 toolbar style
Date: Tue, 06 Sep 2011 18:11:06 +0200

[Message part 1 (text/plain, inline)]

When compiling with GTK3 the toolbar style should be set to
"primary-toolbar" to match the new theme. However, simply setting the
style in this way makes the toolbar looks bad because of the GtkEventBox
wrapped around every GtkButton.

It seems that the GtkEventBox is only used in connecting signals which
can be connected directly to the GtkButton itself. In the attached patch
the event box is removed and the toolbar style set to "primary-toolbar".

Feedback/comments welcome


-- 
Stefano Facchini <stefano.facchini <at> gmail.com>

[gtk3toolbar.patch (text/x-patch, attachment)]

Message #8 received at 9451 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Stefano Facchini <stefano.facchini <at> gmail.com>
Cc: 9451 <at> debbugs.gnu.org
Subject: Re: bug#9451: GTK3 toolbar style
Date: Tue, 06 Sep 2011 22:12:37 +0200

Stefano Facchini skrev 2011-09-06 18:11:
> When compiling with GTK3 the toolbar style should be set to
> "primary-toolbar" to match the new theme. However, simply setting the
> style in this way makes the toolbar looks bad because of the GtkEventBox
> wrapped around every GtkButton.
>
> It seems that the GtkEventBox is only used in connecting signals which
> can be connected directly to the GtkButton itself. In the attached patch
> the event box is removed and the toolbar style set to "primary-toolbar".
>

The GtkEventBox is there to make tooltips work on disabled buttons.  Any patch 
made must preserve that.

	Jan D.

Message #11 received at 9451 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Facchini <stefano.facchini <at> gmail.com>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 9451 <at> debbugs.gnu.org
Subject: Re: bug#9451: GTK3 toolbar style
Date: Tue, 20 Dec 2011 12:01:51 +0100

[Message part 1 (text/plain, inline)]

Il giorno mar, 06/09/2011 alle 22.12 +0200, Jan Djärv ha scritto:
> 
> Stefano Facchini skrev 2011-09-06 18:11:
> > When compiling with GTK3 the toolbar style should be set to
> > "primary-toolbar" to match the new theme. However, simply setting the
> > style in this way makes the toolbar looks bad because of the GtkEventBox
> > wrapped around every GtkButton.
> >
> > It seems that the GtkEventBox is only used in connecting signals which
> > can be connected directly to the GtkButton itself. In the attached patch
> > the event box is removed and the toolbar style set to "primary-toolbar".
> >
> 
> The GtkEventBox is there to make tooltips work on disabled buttons.  Any patch 
> made must preserve that.
> 
> 	Jan D.
> 

Since Gtk+ 3.3.6 it is possible to make transparent the background of a
widget. This allows to solve the GtkEventBox issue when using a primary
toolbar style. A patch is attached.

[gtk3primarytoolbar.patch (text/x-patch, attachment)]

Message #14 received at 9451 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Stefano Facchini <stefano.facchini <at> gmail.com>
Cc: Jan Djärv <jan.h.d <at> swipnet.se>, 9451 <at> debbugs.gnu.org
Subject: Re: bug#9451: GTK3 toolbar style
Date: Sun, 15 Jul 2012 22:22:04 +0800

Stefano Facchini <stefano.facchini <at> gmail.com> writes:

> Since Gtk+ 3.3.6 it is possible to make transparent the background of a
> widget. This allows to solve the GtkEventBox issue when using a primary
> toolbar style. A patch is attached.

Thanks, committed to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.