GNU bug report logs - #9541
mouse-1 inside scroll-margin causes undesirable region activation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9541 in the body.
You can then email your comments to 9541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Le Wang <l26wang <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: mouse-1 inside scroll-margin causes undesirable region activation
Date: Sun, 18 Sep 2011 17:14:14 +0800

Repro:

1. emacs -Q
2. eval:

  (setq scroll-margin 5)

3. open some multi-page file
4. left-click in bottom margin (bottom 5 lines)

Notice region is selected and active.

This problem is noted here: http://www.emacswiki.org/emacs/SmoothScrolling

A package attempts to solve it here:
http://adamspiers.org/computing/elisp/smooth-scrolling.el

But the bug is in Emacs.

-- 
Le

Message #8 received at 9541 <at> debbugs.gnu.org (full text, mbox):

From: Le Wang <l26wang <at> gmail.com>
To: 9541 <at> debbugs.gnu.org
Subject: Re: bug#9541: Acknowledgement (mouse-1 inside scroll-margin causes
	undesirable region activation)
Date: Sun, 18 Sep 2011 19:31:27 +0800

Here is my work-around.  I don't fully understand the ramifications of
doing this, but so far it seems work.

(defun le::mouse-drag-region (event)
  "mouse-drag-region but clickable in scroll-margin"
  (interactive "e")
  (let ((scroll-margin 0))
    (mouse-drag-region event)))

(global-set-key [(down-mouse-1)] 'le::mouse-drag-region)

-- 
Le

Message #11 received at 9541 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Le Wang <l26wang <at> gmail.com>
Cc: 9541 <at> debbugs.gnu.org
Subject: Re: mouse-1 inside scroll-margin causes undesirable region activation
Date: Mon, 19 Sep 2011 14:34:36 -0400

> Here is my work-around.  I don't fully understand the ramifications of
> doing this, but so far it seems work.

> (defun le::mouse-drag-region (event)
>   "mouse-drag-region but clickable in scroll-margin"
>   (interactive "e")
>   (let ((scroll-margin 0))
>     (mouse-drag-region event)))

But this goes against the definition of scroll-margin which does not
make any exception for mouse events.

An alternative would be to declare that scroll-margin does not apply to
commands when run via mouse events.

This said, the current behavior of scroll-margin is clearly problematic
and even buggy (e.g. it seems that displaying the EOB prevents the
mouse-clicks from causing a scroll, even when that scroll would be
towards the BOB).


        Stefan

Message #14 received at 9541 <at> debbugs.gnu.org (full text, mbox):

From: Johan Bockgård <bojohan <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9541 <at> debbugs.gnu.org, Le Wang <l26wang <at> gmail.com>
Subject: Re: bug#9541: mouse-1 inside scroll-margin causes undesirable region
	activation
Date: Fri, 23 Sep 2011 22:52:45 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> This said, the current behavior of scroll-margin is clearly problematic
> and even buggy (e.g. it seems that displaying the EOB prevents the
> mouse-clicks from causing a scroll, even when that scroll would be
> towards the BOB).

The real bug is that mouse-clicks set the mark (always). (Search for
push-mark in mouse-drag-track.)

Message #17 received at 9541 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9541 <at> debbugs.gnu.org, Le Wang <l26wang <at> gmail.com>
Subject: Re: bug#9541: mouse-1 inside scroll-margin causes undesirable region
	activation
Date: Sat, 24 Sep 2011 14:38:20 -0400

Johan Bockgård <bojohan <at> gnu.org> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>> This said, the current behavior of scroll-margin is clearly problematic
>> and even buggy (e.g. it seems that displaying the EOB prevents the
>> mouse-clicks from causing a scroll, even when that scroll would be
>> towards the BOB).
>
> The real bug is that mouse-clicks set the mark (always). (Search for
> push-mark in mouse-drag-track.)

No, that's intended behavior.  The OP's suggestion of disabling the
scroll margin while tracking a mouse drag is on the right track.  I've
committed a change along those lines.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.