GNU bug report logs - #20766
24.5; disable-theme leaves lingering effects

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Anders Papitto <anderspapitto@HIDDEN>; dated Mon, 8 Jun 2015 01:21:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 20766 <at> debbugs.gnu.org:


Received: (at 20766) by debbugs.gnu.org; 6 Nov 2020 12:26:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 06 07:26:56 2020
Received: from localhost ([127.0.0.1]:55312 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kb0pU-0008Vj-KH
	for submit <at> debbugs.gnu.org; Fri, 06 Nov 2020 07:26:56 -0500
Received: from mail-wr1-f52.google.com ([209.85.221.52]:33302)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maurooaranda@HIDDEN>) id 1kb0pS-0008VU-Mn
 for 20766 <at> debbugs.gnu.org; Fri, 06 Nov 2020 07:26:55 -0500
Received: by mail-wr1-f52.google.com with SMTP id b8so1150989wrn.0
 for <20766 <at> debbugs.gnu.org>; Fri, 06 Nov 2020 04:26:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to:cc;
 bh=JC1/v+PjP9IDBb+/TMtoHYzSv8KLV9RLdvM1P62IY1Q=;
 b=rE9mVRODfW/QpCnsL/UxJfIW+qIfrOM51HOewsgqzwVdT5+F8v82lpSxCwSRx1hrUO
 910tpssNjNbpiWP8/8ZeuZmwPOaaKompCjeuXuloVingxN61oeSEni350m/rCHdHKXai
 1GROkHfMflCMsNr/5lQfeLzsmAf9UAa/Lh1w0y/MCo4hQ0ZUyPLXQkY3u4hPAzDCrod1
 0Ud19VymiLpqZzdQwYfpnZo52Uf2OZ5uQW5OruBwFkkgTXk/8ZrYLJmE3/0Tg/RAxSwr
 ReML2n/C9sPUW/EOgKS7o+Npgp0LB4dvQcVKnCGbNkwlJl+Lv7TbaCe0/F5mrGEmhUya
 Vprg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=JC1/v+PjP9IDBb+/TMtoHYzSv8KLV9RLdvM1P62IY1Q=;
 b=BSeN6uQZ4v90J9tK5zEID5Mwaljn2+7iel5WWafAZK6w26xjZcf6OIHxcPsKb+wdme
 K9A370/kxavCBX1DCsGp4ibzluYczcBF1YQQx5NfiJZmi/KX3DQTEJSVCZKJT9j12+Zo
 PdF0rvsKj8moirp6wQKmGD4QmY2oC1Vbmr7DmlWcMLn9iyrMne02lBJgCkmbwxpm7Knc
 v4EKQlQPjx+Xek8I7YB16QXvLpL7ECnxXTX8htBywo6+6jUrjwJY0TYkSZ0D/3M1kkVY
 vzFvZ2v6pADjm7JMyUuaZuDgE4Qg7AW4+0cTUqY7tVqgmWDeBXqnibnpnN3yFS4U7Ncp
 3zdQ==
X-Gm-Message-State: AOAM531bAWgG3/nhHIhYT6yJ3vwNCvk5Fs1kw5GbVr2l/uXfqBoy9Ele
 rtqyCUTHCfRWdDdpHSoBq4Xr/FFbMx+4Z9B/Ofk=
X-Google-Smtp-Source: ABdhPJylHLXKzbW3Bi6HZ13kQo1PKl9PPkm0Pmm88J/fCsAUf6UF/NU5DK5XL4aImykMkrLKt+ZweTDZTbOqwa9R3Zs=
X-Received: by 2002:a5d:69d1:: with SMTP id s17mr2537937wrw.77.1604665608803; 
 Fri, 06 Nov 2020 04:26:48 -0800 (PST)
MIME-Version: 1.0
From: Mauro Aranda <maurooaranda@HIDDEN>
Date: Fri, 6 Nov 2020 09:26:36 -0300
Message-ID: <CABczVwez6NKOVkKMmVOWbXBGAqvvwmvQARJmf7h0db8Ofy9Bbg@HIDDEN>
Subject: Re: bug#20766: 24.5; disable-theme leaves lingering effects
To: Anders Papitto <anderspapitto@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000009899f905b36f5309"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20766
Cc: 20766 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000009899f905b36f5309
Content-Type: text/plain; charset="UTF-8"

Anders Papitto <anderspapitto@HIDDEN> writes:

> When I run these commands from a fresh Emacs instance
>
> M-x load-theme RET solarized-light RET
> M-x disable-theme RET solarized-light RET
> M-x term RET RET
>
> the text background color in term-mode stays what it was set to by the
> solarized-light theme. A very similar invocation does not have this
> behavior:
>
> M-x term RET RET
> C-c k RET yes RET
> M-x load-theme RET solarized-light RET
> M-x disable-theme RET solarized-light RET
> M-x term RET RET
>
> i.e. If term mode gets to run before loading the theme, no bug.
>

This bug is still present.

It looks like solarized still sets the obsoleted variables
term-default-fg-color and term-default-bg-color, but still, the bug is
in custom.el and it's related to Bug#21355.

Here's a recipe:
Save this theme into test-bug20766-theme.el, and arrange to load it.
(deftheme test-bug20766)

(custom-theme-set-variables
 'test-bug20766
 '(test-option 'foo))

(provide-theme 'test-bug20766)

emacs -Q

M-x load-theme RET test-bug20766
test-option is not yet known, so custom stores the theme setting under
the saved-value property of test-option.

M-x disable-theme RET test-bug20766
The saved-value property should be nil, because the theme setting is no
longer relevant.  However, it's still ('foo).

Then eval the following defcustom:
(defcustom test-option 'bar "..."
:type 'symbol
:group 'emacs)

M-: test-option ==> foo, which is wrong.

In the original recipe, that is how term-default-fg-color and
term-default-bg-color get the solarized theme setting after loading
term.

--0000000000009899f905b36f5309
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Anders Papitto &lt;<a href=3D"mailto:anderspapitto@HIDDEN=
om">anderspapitto@HIDDEN</a>&gt; writes:<br><br>&gt; When I run these co=
mmands from a fresh Emacs instance<br>&gt;<br>&gt; M-x load-theme RET solar=
ized-light RET<br>&gt; M-x disable-theme RET solarized-light RET<br>&gt; M-=
x term RET RET<br>&gt;<br>&gt; the text background color in term-mode stays=
 what it was set to by the<br>&gt; solarized-light theme. A very similar in=
vocation does not have this<br>&gt; behavior:<br>&gt;<br>&gt; M-x term RET =
RET<br>&gt; C-c k RET yes RET<br>&gt; M-x load-theme RET solarized-light RE=
T<br>&gt; M-x disable-theme RET solarized-light RET<br>&gt; M-x term RET RE=
T<br>&gt;<br>&gt; i.e. If term mode gets to run before loading the theme, n=
o bug.<br>&gt;<br><br>This bug is still present.<br><br>It looks like solar=
ized still sets the obsoleted variables<br>term-default-fg-color and term-d=
efault-bg-color, but still, the bug is<br>in custom.el and it&#39;s related=
 to Bug#21355.<br><br>Here&#39;s a recipe:<br>Save this theme into test-bug=
20766-theme.el, and arrange to load it.<br>(deftheme test-bug20766)<br><br>=
(custom-theme-set-variables<br>=C2=A0&#39;test-bug20766<br>=C2=A0&#39;(test=
-option &#39;foo))<br><br>(provide-theme &#39;test-bug20766)<br><br>emacs -=
Q<br><br>M-x load-theme RET test-bug20766<br>test-option is not yet known, =
so custom stores the theme setting under<br>the saved-value property of tes=
t-option.<br><br>M-x disable-theme RET test-bug20766<br>The saved-value pro=
perty should be nil, because the theme setting is no<br>longer relevant.=C2=
=A0 However, it&#39;s still (&#39;foo).<br><br>Then eval the following defc=
ustom:<br>(defcustom test-option &#39;bar &quot;...&quot;<br>	 :type &#39;s=
ymbol<br>	 :group &#39;emacs)<br><br>M-: test-option =3D=3D&gt; foo, which =
is wrong.<br><br>In the original recipe, that is how term-default-fg-color =
and<br>term-default-bg-color get the solarized theme setting after loading<=
br>term.<br></div>

--0000000000009899f905b36f5309--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20766; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Jun 2015 01:20:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 07 21:20:06 2015
Received: from localhost ([127.0.0.1]:44411 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Z1ljN-00075F-Cj
	for submit <at> debbugs.gnu.org; Sun, 07 Jun 2015 21:20:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36393)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYz-0006q5-UN
 for submit <at> debbugs.gnu.org; Sun, 07 Jun 2015 21:09:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYt-000361-8B
 for submit <at> debbugs.gnu.org; Sun, 07 Jun 2015 21:09:12 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:39599)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYt-00035w-5G
 for submit <at> debbugs.gnu.org; Sun, 07 Jun 2015 21:09:11 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49871)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYr-0002CN-Mv
 for bug-gnu-emacs@HIDDEN; Sun, 07 Jun 2015 21:09:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYn-00034Z-Sb
 for bug-gnu-emacs@HIDDEN; Sun, 07 Jun 2015 21:09:09 -0400
Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:36260)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <anderspapitto@HIDDEN>) id 1Z1lYn-00034E-KG
 for bug-gnu-emacs@HIDDEN; Sun, 07 Jun 2015 21:09:05 -0400
Received: by pabqy3 with SMTP id qy3so84539484pab.3
 for <bug-gnu-emacs@HIDDEN>; Sun, 07 Jun 2015 18:09:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:date:message-id:subject:from:to:content-type;
 bh=T0SdkGJbThggZ1ue9ZYWbrebBWixAUCW3QBF3hQb4y0=;
 b=Hzi7VzEpON1SuANCJQQSB6/zaMz4tz7YqeAiLUcjlfxLjUOna5SwEReVZzl2RL+6dl
 Pge6xTULJxWagsWWsP5iD9kqzjtwwHYNcUqFhvnPPdiza4Ugz+pdGPe4/AU2NJh+NCjc
 Bwh642foEqD+fhl2rXczftRpMRcnIxViIAVdhLz/34EhK4BnAAWEw2txjf1z0Y5J1r6l
 OeGXDRaAeRrQQPnW2qYL8c8ke4Tq/B0uqC/6+lGiAbGTyVdGjFfxA7naO/e31dE7mPTI
 FqYhkvua+ynJVR+Elw+TNWoWKJ6+/340xTGymWwklb763a3ZgJ4my4QfNB6SR/4GE/nS
 u6qw==
MIME-Version: 1.0
X-Received: by 10.66.165.8 with SMTP id yu8mr25158718pab.82.1433725744373;
 Sun, 07 Jun 2015 18:09:04 -0700 (PDT)
Received: by 10.70.111.3 with HTTP; Sun, 7 Jun 2015 18:09:04 -0700 (PDT)
Date: Sun, 7 Jun 2015 18:09:04 -0700
Message-ID: <CAD1XNaoXi6YZf2LADD+xOODFDvJHCMGF+HT8z58pnW1xtLH=Rw@HIDDEN>
Subject: 24.5; disable-theme leaves lingering effects
From: Anders Papitto <anderspapitto@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 07 Jun 2015 21:19:58 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

When I run these commands from a fresh Emacs instance

M-x load-theme RET solarized-light RET
M-x disable-theme RET solarized-light RET
M-x term RET RET

the text background color in term-mode stays what it was set to by the
solarized-light theme. A very similar invocation does not have this
behavior:

M-x term RET RET
C-c k RET yes RET
M-x load-theme RET solarized-light RET
M-x disable-theme RET solarized-light RET
M-x term RET RET

i.e. If term mode gets to run before loading the theme, no bug.

the 'solarized-light' theme was installed from melpa via M-x
package-list-packages, and is upstream at
https://github.com/bbatsov/solarized-emacs. I'm not certain whether the
behavior is specific to that theme or not.

What I have observed is that there seems to be an interaction with the
variables term-default-fg-color and term-default-bg-color. They start as
:not-bound. Solarized light sets them to some value when loaded, and
resets them to :not-bound when unloaded. However, term mode also sets
them when started (both to 'nil) and seems to never reset them to
:not-bound.

Note: I don't have Emacs configured to send email, so I copied the
following from the bug-submission utility.


In GNU Emacs 24.5.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.27)
 of 2015-05-13 on localhost
Windowing system distributor `The X.Org Foundation', version 11.0.11604000
Configured using:
 `configure --disable-dependency-tracking
 --prefix=/nix/store/wjlxah8xdid8qw12rsf3cjxvqj3zw69p-emacs-24.5
 --with-x-toolkit=gtk2 --with-xft'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
delete-backward-char: Text is read-only

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 71068 7059)
 (symbols 48 17455 0)
 (miscs 40 39 163)
 (strings 32 9117 4368)
 (string-bytes 1 264156)
 (vectors 16 8912)
 (vector-slots 8 383152 18293)
 (floats 8 63 249)
 (intervals 56 166 16)
 (buffers 960 11)
 (heap 1024 12859 662))




Acknowledgement sent to Anders Papitto <anderspapitto@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#20766; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 6 Nov 2020 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.