GNU bug report logs - #2747
[PATCH] 23.0.91; multi-line tooltips don't work on nextstep

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2747 in the body.
You can then email your comments to 2747 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Nikolaj Schumacher <me <at> nschum.de>
To: emacs-pretest-bug <at> gnu.org
Subject: [PATCH] 23.0.91; multi-line tooltips don't work on nextstep
Date: Sun, 22 Mar 2009 18:46:51 +0100

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-03-22 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--with-x''


Only the first line multi-line tooltips like

  (tooltip-show "foo\nbar")

appear on nextstep.


The following patch seems to be a simple (perhaps too simple?) solution:


diff --git a/src/nsmenu.m b/src/nsmenu.m
index 9a97492..97d29e9 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -1398,10 +1398,7 @@ update_frame_tool_bar (FRAME_PTR f)
   NSColor *col = [NSColor colorWithCalibratedRed: 1.0 green: 1.0
                                             blue: 0.792 alpha: 0.95];
   NSFont *font = [NSFont toolTipsFontOfSize: 0];
-  NSFont *sfont = [font screenFont];
-  int height = [sfont ascender] - [sfont descender];
-/*[font boundingRectForFont].size.height; */
-  NSRect r = NSMakeRect (0, 0, 100, height+6);
+  NSRect r = NSMakeRect (0, 0, 100, 100);
 
   textField = [[NSTextField alloc] initWithFrame: r];
   [textField setFont: font];
@@ -1438,10 +1435,8 @@ update_frame_tool_bar (FRAME_PTR f)
 - (void) setText: (char *)text
 {
   NSString *str = [NSString stringWithUTF8String: text];
-  NSRect r = [textField frame];
-  r.size.width = [[[textField font] screenFont] widthOfString: str] + 8;
-  [textField setFrame: r];
   [textField setStringValue: str];
+  [textField sizeToFit];
 }
 
 - (void) showAtX: (int)x Y: (int)y for: (int)seconds

Message #14 received at 2747 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: Nikolaj Schumacher <me <at> nschum.de>, 2747 <at> debbugs.gnu.org
Subject: Re: bug#2747: [PATCH] 23.0.91;	multi-line tooltips don't work on nextstep
Date: Mon, 23 Mar 2009 10:50:48 +0900

>>>>> On Sun, 22 Mar 2009 18:46:51 +0100, Nikolaj Schumacher <me <at> nschum.de> said:

> In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS
> apple-appkit-949.43) of 2009-03-22 on thursday Windowing system
> distributor `Apple', version 10.3.949 configured using `configure
> '--with-ns' '--with-x''


> Only the first line multi-line tooltips like

>   (tooltip-show "foo\nbar")

> appear on nextstep.


> The following patch seems to be a simple (perhaps too simple?)
> solution:

It might solve this particular problem, but I think the whole tooltip
code should be rewritten so as to use an Emacs frame like in the other
platforms.
(cf. http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00123.html)

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.