GNU bug report logs - #36197
[Patch] gnu: add celestia; celestia-gtk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36197 in the body.
You can then email your comments to 36197 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [Patch] gnu: add celestia; celestia-gtk
Date: Thu, 13 Jun 2019 23:45:05 +0530

[Message part 1 (text/plain, inline)]

Added Celestia; space visualisation and simulator to (gnu packages
astronomy).

Tests are disabled because the project does not include any tests.

[0001-gnu-Add-celestia.patch (text/x-patch, attachment)]

[0002-gnu-Add-celestia-gtk.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Re: [bug#36197] [Patch] gnu: add celestia; celestia-gtk
Date: Tue, 25 Jun 2019 21:25:35 +0200

On 2019-06-13 20:15, Amar Singh wrote:
> 
> Added Celestia; space visualisation and simulator to (gnu packages
> astronomy).
> 
> Tests are disabled because the project does not include any tests.

> +      (license license:gpl2))))

Source code files say 2 or later. Otherwise LGTM.

I'm not going to review the celestia-gtk because of small bandwidth.

Thanks for the patch!

-- 
Cheers Swedebugia

Message #13 received at 36197-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Amar Singh <nly <at> disroot.org>
Cc: 36197-done <at> debbugs.gnu.org
Subject: Re: [bug#36197] [Patch] gnu: add celestia; celestia-gtk
Date: Wed, 26 Jun 2019 14:51:29 +0200

[Message part 1 (text/plain, inline)]

Hi Amar,

Amar Singh <nly <at> disroot.org> skribis:

>>From dba590074e9a0c7cf3dc8440492190de732feaea Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Sun, 19 May 2019 12:39:48 +0530
> Subject: [PATCH 1/2] gnu: Add celestia.
>
> * gnu/packages/astronomy.scm (celestia): New variable.

I fixed the license as swedebugia noted, made the minor cosmetic changes
shown below, and applied.

>>From c8dd3c6871da910761ea8908f6bc9866c7f3c5ac Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Thu, 13 Jun 2019 22:53:22 +0530
> Subject: [PATCH 2/2] gnu: Add celestia-gtk.
>
> * gnu/packages/astronomy.scm (celestia-gtk): New variable.

Applied with the changes below.

Thank you!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 20639bc779..59fa11bfda 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -2,7 +2,7 @@
 ;;; Copyright © 2016 John Darrington <jmd <at> gnu.org>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018, 2019 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2019 by Amar Singh<nly <at> disroot.org>
+;;; Copyright © 2019 by Amar Singh <nly <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -189,20 +189,16 @@ objects.")
   (let ((commit "9dbdf29c4ac3d20afb2d9a80d3dff241ecf81dce"))
     (package
       (name "celestia")
-      (version
-       (git-version "1.6.1" "815" commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri
-          (git-reference
-           (url
-            "https://github.com/celestiaproject/celestia")
-           (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "00xibg87l1arzifakgj7s828x9pszcgx7x7ij88a561ig49ryh78"))))
+      (version (git-version "1.6.1" "815" commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/celestiaproject/celestia")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "00xibg87l1arzifakgj7s828x9pszcgx7x7ij88a561ig49ryh78"))))
       (build-system cmake-build-system)
       (native-inputs
        `(("perl" ,perl)
@@ -227,14 +223,14 @@ objects.")
        `(("lua" ,lua)))
       (arguments
        `(#:configure-flags '("-DENABLE_GLUT=ON" "-DENABLE_QT=OFF")
-         #:tests? #f))
+         #:tests? #f))                            ;no tests
       (home-page "https://celestia.space/")
       (synopsis "Real-time 3D visualization of space")
       (description
-       "The free space simulation that lets you explore our universe in three
+       "This simulation program lets you explore our universe in three
 dimensions.  Celestia simulates many different types of celestial objects.
 From planets and moons to star clusters and galaxies, you can visit every
 object in the expandable database and view it from any point in space and
 time.  The position and movement of solar system objects is calculated
 accurately in real time at any rate desired.")
-      (license license:gpl2))))
+      (license license:gpl2+))))

[Message part 3 (text/x-patch, inline)]

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index df801ef444..81c7481e0b 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -42,7 +42,8 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages maths)
   #:use-module (guix build-system cmake)
-  #:use-module (guix build-system gnu))
+  #:use-module (guix build-system gnu)
+  #:use-module (srfi srfi-1))
 
 (define-public cfitsio
   (package
@@ -238,15 +239,13 @@ accurately in real time at any rate desired.")
       (license license:gpl2+))))
 
 (define-public celestia-gtk
-  (package (inherit celestia)
-           (name "celestia-gtk")
-           (version (package-version celestia))
-           (inputs
-            (append (filter (lambda (x)
-                              (not (equal? (car x) "freeglut")))
-                            (package-inputs celestia))
-                    `(("gtk2" ,gtk+-2)
-                      ("gtkglext" ,gtkglext))))
-           (arguments
-            `(#:configure-flags '("-DENABLE_GTK=ON" "-DENABLE_QT=OFF")
-              #:tests? #f))))
+  (package
+    (inherit celestia)
+    (name "celestia-gtk")
+    (inputs
+     (append (alist-delete "freeglut" (package-inputs celestia))
+             `(("gtk2" ,gtk+-2)
+               ("gtkglext" ,gtkglext))))
+    (arguments
+     `(#:configure-flags '("-DENABLE_GTK=ON" "-DENABLE_QT=OFF")
+       #:tests? #f))))

Message #16 received at 36197 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: 36197 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [Patch] gnu: add celestia; celestia-gtk
Date: Tue, 2 Jul 2019 10:54:49 -0400 (EDT)

Did this patch address the concerns raised in this thread: https://lists.gnu.org/archive/html/guix-devel/2015-07/msg00030.html ?

-- 
`~Eric

Message #23 received at 36197 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 36197 <at> debbugs.gnu.org
Subject: Re: [Patch] gnu: add celestia; celestia-gtk
Date: Thu, 04 Jul 2019 10:02:45 +0200

Hi Eric,

Eric Bavier <ericbavier <at> centurylink.net> skribis:

> Did this patch address the concerns raised in this thread: https://lists.gnu.org/archive/html/guix-devel/2015-07/msg00030.html ?

Good question, I don’t know.  Could you take a look?

I picked it up because there had been no comments for some time, but I
was unaware of the issues you raise.

Thanks for the heads-up,
Ludo’.

Message #28 received at 36197-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 36197-done <at> debbugs.gnu.org
Subject: [Patch] gnu: add celestia; celestia-gtk
Date: Fri, 29 Mar 2024 15:03:32 +0000

[Message part 1 (text/plain, inline)]

Hi!

Celestia is on the latest version and periodically checked for
updates.

Closing this issue as no more relevant.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.