Received: (at unknown) by unknown; unknown X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 401) by emacsbugs.donarmstrong.com; 14 Jun 2008 20:19:24 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EKJLTq010102 for <401 <at> emacsbugs.donarmstrong.com>; Sat, 14 Jun 2008 13:19:22 -0700 Received: from c83-254-145-59.bredband.comhem.se ([83.254.145.59]:63029 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from <lennart.borgman <at> gmail.com>) id 1K7cDY-00032E-7c; Sat, 14 Jun 2008 22:19:20 +0200 Message-ID: <485427C3.4030602 <at> gmail.com> Date: Sat, 14 Jun 2008 22:19:15 +0200 From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 401 <at> debbugs.gnu.org CC: Paul Pogonyshev <pogonyshev <at> gmx.net>, bug-gnu-emacs <at> gnu.org Subject: Re: bug#401: bug in HTML or XML syntax highlighting code References: <200806122320.04557.pogonyshev <at> gmx.net> <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org> In-Reply-To: <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080614-1, 2008-06-14), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.145.59 X-ACL-Warn: Too high rate of unknown addresses received from you X-Scan-Result: No virus found in message 1K7cDY-00032E-7c. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1K7cDY-00032E-7c 1fdfb8740adb2bdd43816cf248a50c77 Stefan Monnier wrote: >> With fairly recent SVN build of Emacs I have the pasted below HTML code >> highlighted wrongly. Namely, "foo" is not highlighted as an attribute >> value, apparently because there are non-corresponding (from Emacs point >> of view) parentheses in <script>. > > Indeed, part of the problem is that we use sgml-mode for this, even > though your file doesn't seem like a properly formed SGML file. We need > to add special support for <script>. Note that we do not properly > support SGML either, e.g. if you use a CDATA[[...]] construct you'll > bump into the same kinds of problems. Does not nxml-mode handle this better? >> It seems that HTML/XML mode uses two different ways to find syntactic >> context for indenting code and for syntax-highlighting it, which I > > Most/all major modes do. The syntax-highlighting is done "globally" > (especially the comment-vs-string-vs-code distinction), so it can get > seriously messed up over the whole buffer in case the buffer's syntax is > incorrect or is using constructs which the major mode doesn't > understand. I believe the cure to this is some multi major mode handling.
"Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>:Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
Full text available.bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:bug#401; Package emacs.
Full text available.Received: (at unknown) by unknown; unknown X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.0 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jun 2008 20:19:30 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EKJRi0010109 for <submit <at> emacsbugs.donarmstrong.com>; Sat, 14 Jun 2008 13:19:28 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7cDe-0000vj-SZ for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 16:19:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7cDc-0000v5-Gk for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 16:19:25 -0400 Received: from [199.232.76.173] (port=51786 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7cDc-0000v2-DB for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 16:19:24 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:44029) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from <lennart.borgman <at> gmail.com>) id 1K7cDc-0007Yy-Av for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 16:19:24 -0400 Received: from c83-254-145-59.bredband.comhem.se ([83.254.145.59]:63029 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from <lennart.borgman <at> gmail.com>) id 1K7cDY-00032E-7c; Sat, 14 Jun 2008 22:19:20 +0200 Message-ID: <485427C3.4030602 <at> gmail.com> Date: Sat, 14 Jun 2008 22:19:15 +0200 From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 401 <at> debbugs.gnu.org CC: Paul Pogonyshev <pogonyshev <at> gmx.net>, bug-gnu-emacs <at> gnu.org Subject: Re: bug#401: bug in HTML or XML syntax highlighting code References: <200806122320.04557.pogonyshev <at> gmx.net> <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org> In-Reply-To: <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080614-1, 2008-06-14), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.145.59 X-ACL-Warn: Too high rate of unknown addresses received from you X-Scan-Result: No virus found in message 1K7cDY-00032E-7c. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1K7cDY-00032E-7c 1fdfb8740adb2bdd43816cf248a50c77 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-CrossAssassin-Score: 2 Stefan Monnier wrote: >> With fairly recent SVN build of Emacs I have the pasted below HTML code >> highlighted wrongly. Namely, "foo" is not highlighted as an attribute >> value, apparently because there are non-corresponding (from Emacs point >> of view) parentheses in <script>. > > Indeed, part of the problem is that we use sgml-mode for this, even > though your file doesn't seem like a properly formed SGML file. We need > to add special support for <script>. Note that we do not properly > support SGML either, e.g. if you use a CDATA[[...]] construct you'll > bump into the same kinds of problems. Does not nxml-mode handle this better? >> It seems that HTML/XML mode uses two different ways to find syntactic >> context for indenting code and for syntax-highlighting it, which I > > Most/all major modes do. The syntax-highlighting is done "globally" > (especially the comment-vs-string-vs-code distinction), so it can get > seriously messed up over the whole buffer in case the buffer's syntax is > incorrect or is using constructs which the major mode doesn't > understand. I believe the cure to this is some multi major mode handling.
"Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>:Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
Full text available.bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:bug#401; Package emacs.
Full text available.
Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rzlab.ucr.edu
X-Spam-Level:
X-Spam-Status: No, score=-4.5 required=4.0 tests=AWL,BAYES_00,FOURLA,
HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 401) by emacsbugs.donarmstrong.com; 14 Jun 2008 19:46:12 +0000
Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182])
by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EJk9ST002235
for <401 <at> emacsbugs.donarmstrong.com>; Sat, 14 Jun 2008 12:46:10 -0700
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AhcFAI68U0jO+KWv/2dsb2JhbACBW6sR
X-IronPort-AV: E=Sophos;i="4.27,645,1204520400";
d="scan'208,217";a="22554626"
Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238])
by ironport2-out.teksavvy.com with ESMTP; 14 Jun 2008 15:46:03 -0400
Received: from pastel.home ([206.248.165.175])
by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id UZI89103;
Sat, 14 Jun 2008 15:46:03 -0400
Received: by pastel.home (Postfix, from userid 20848)
id 9539B8336; Sat, 14 Jun 2008 15:46:03 -0400 (EDT)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Paul Pogonyshev <pogonyshev <at> gmx.net>
Cc: 401 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#401: bug in HTML or XML syntax highlighting code
Message-ID: <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org>
References: <200806122320.04557.pogonyshev <at> gmx.net>
Date: Sat, 14 Jun 2008 15:46:03 -0400
In-Reply-To: <200806122320.04557.pogonyshev <at> gmx.net> (Paul Pogonyshev's
message of "Thu, 12 Jun 2008 23:20:04 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
> With fairly recent SVN build of Emacs I have the pasted below HTML code
> highlighted wrongly. Namely, "foo" is not highlighted as an attribute
> value, apparently because there are non-corresponding (from Emacs point
> of view) parentheses in <script>.
Indeed, part of the problem is that we use sgml-mode for this, even
though your file doesn't seem like a properly formed SGML file. We need
to add special support for <script>. Note that we do not properly
support SGML either, e.g. if you use a CDATA[[...]] construct you'll
bump into the same kinds of problems.
> It seems that HTML/XML mode uses two different ways to find syntactic
> context for indenting code and for syntax-highlighting it, which I
Most/all major modes do. The syntax-highlighting is done "globally"
(especially the comment-vs-string-vs-code distinction), so it can get
seriously messed up over the whole buffer in case the buffer's syntax is
incorrect or is using constructs which the major mode doesn't
understand. The indentation code usually can work much more locally, so
it tends to be more resilient.
Stefan
Stefan Monnier <monnier <at> iro.umontreal.ca>:Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
Full text available.bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:bug#401; Package emacs.
Full text available.
Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rzlab.ucr.edu
X-Spam-Level:
X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,FOURLA,
HAS_BUG_NUMBER,RCVD_IN_DNSWL_LOW autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jun 2008 19:46:17 +0000
Received: from lists.gnu.org (lists.gnu.org [199.232.76.165])
by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EJk7tx002236
for <submit <at> emacsbugs.donarmstrong.com>; Sat, 14 Jun 2008 12:46:08 -0700
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
id 1K7bhO-0004Ss-Sl
for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 15:46:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
id 1K7bhN-0004SC-By
for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 15:46:06 -0400
Received: from [199.232.76.173] (port=55762 helo=monty-python.gnu.org)
by lists.gnu.org with esmtp (Exim 4.43)
id 1K7bhN-0004S6-1H
for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 15:46:05 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:49978)
by monty-python.gnu.org with esmtp (Exim 4.60)
(envelope-from <monnier <at> iro.umontreal.ca>)
id 1K7bhM-0002Zf-Ft
for bug-gnu-emacs <at> gnu.org; Sat, 14 Jun 2008 15:46:05 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AhcFAI68U0jO+KWv/2dsb2JhbACBW6sR
X-IronPort-AV: E=Sophos;i="4.27,645,1204520400";
d="scan'208,217";a="22554626"
Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238])
by ironport2-out.teksavvy.com with ESMTP; 14 Jun 2008 15:46:03 -0400
Received: from pastel.home ([206.248.165.175])
by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id UZI89103;
Sat, 14 Jun 2008 15:46:03 -0400
Received: by pastel.home (Postfix, from userid 20848)
id 9539B8336; Sat, 14 Jun 2008 15:46:03 -0400 (EDT)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Paul Pogonyshev <pogonyshev <at> gmx.net>
Cc: 401 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#401: bug in HTML or XML syntax highlighting code
Message-ID: <jwvwskrajso.fsf-monnier+emacsbugreports <at> gnu.org>
References: <200806122320.04557.pogonyshev <at> gmx.net>
Date: Sat, 14 Jun 2008 15:46:03 -0400
In-Reply-To: <200806122320.04557.pogonyshev <at> gmx.net> (Paul Pogonyshev's
message of "Thu, 12 Jun 2008 23:20:04 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized.
X-CrossAssassin-Score: 2
> With fairly recent SVN build of Emacs I have the pasted below HTML code
> highlighted wrongly. Namely, "foo" is not highlighted as an attribute
> value, apparently because there are non-corresponding (from Emacs point
> of view) parentheses in <script>.
Indeed, part of the problem is that we use sgml-mode for this, even
though your file doesn't seem like a properly formed SGML file. We need
to add special support for <script>. Note that we do not properly
support SGML either, e.g. if you use a CDATA[[...]] construct you'll
bump into the same kinds of problems.
> It seems that HTML/XML mode uses two different ways to find syntactic
> context for indenting code and for syntax-highlighting it, which I
Most/all major modes do. The syntax-highlighting is done "globally"
(especially the comment-vs-string-vs-code distinction), so it can get
seriously messed up over the whole buffer in case the buffer's syntax is
incorrect or is using constructs which the major mode doesn't
understand. The indentation code usually can work much more locally, so
it tends to be more resilient.
Stefan
Stefan Monnier <monnier <at> iro.umontreal.ca>:Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
Full text available.bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:bug#401; Package emacs.
Full text available.
Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rzlab.ucr.edu
X-Spam-Level:
X-Spam-Status: No, score=-1.9 required=4.0 tests=BAYES_00,FOURLA,
RCVD_IN_DNSWL_LOW,RCVD_IN_SBLXBL,RCVD_IN_SBLXBL_CBL autolearn=no
version=3.2.3-bugs.debian.org_2005_01_02
Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jun 2008 20:11:28 +0000
Received: from lists.gnu.org (lists.gnu.org [199.232.76.165])
by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5CKBON1011590
for <submit <at> emacsbugs.donarmstrong.com>; Thu, 12 Jun 2008 13:11:26 -0700
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
id 1K6t8m-00087o-B3
for bug-gnu-emacs <at> gnu.org; Thu, 12 Jun 2008 16:11:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
id 1K6t8k-00087N-Ij
for bug-gnu-emacs <at> gnu.org; Thu, 12 Jun 2008 16:11:23 -0400
Received: from [199.232.76.173] (port=34121 helo=monty-python.gnu.org)
by lists.gnu.org with esmtp (Exim 4.43)
id 1K6t8k-00087K-G2
for bug-gnu-emacs <at> gnu.org; Thu, 12 Jun 2008 16:11:22 -0400
Received: from mail.gmx.net ([213.165.64.20]:52858)
by monty-python.gnu.org with smtp (Exim 4.60)
(envelope-from <pogonyshev <at> gmx.net>)
id 1K6t8j-00022A-Vq
for bug-gnu-emacs <at> gnu.org; Thu, 12 Jun 2008 16:11:22 -0400
Received: (qmail invoked by alias); 12 Jun 2008 20:11:20 -0000
Received: from ns1.lintec.minsk.by (EHLO [10.26.3.202]) [212.98.162.2]
by mail.gmx.net (mp024) with SMTP; 12 Jun 2008 22:11:20 +0200
X-Authenticated: #16844820
X-Provags-ID: V01U2FsdGVkX18QaHMA5xUQkOdSsJg8pNqCHBZZbh5gAOYuSoZKPa
Z+KRXAwCTawWjz
From: Paul Pogonyshev <pogonyshev <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: bug in HTML or XML syntax highlighting code
Date: Thu, 12 Jun 2008 23:20:04 +0300
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806122320.04557.pogonyshev <at> gmx.net>
X-Y-GMX-Trusted: 0
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
Hi,
With fairly recent SVN build of Emacs I have the pasted below HTML code
highlighted wrongly. Namely, "foo" is not highlighted as an attribute
value, apparently because there are non-corresponding (from Emacs point
of view) parentheses in <script>. With an almost a year old build at
home, I don't see this bug, so it is a regression in Emacs.
It seems that HTML/XML mode uses two different ways to find syntactic
context for indenting code and for syntax-highlighting it, which I
find bad. In some larger files I managed to get half a file highlighted
(wrongly!) with `font-lock-string-face', yet code indenting worked
just fine. So, the same piece of code is considered an attribute value
by highlighting code, but normal tag tree by code indenting code.
Also, the bug seems to be heavily dependent on JIT highlighting. E.g.
if you remove and then reinsert some of the characters which Emacs
considers parens, code is then rehighlighted correctly.
[originally posted to emacs-devel <at> gnu.org, with attachment instead of
inlined HTML]
Bug in:
<html>
<head>
<script>
function x () { return 1 > 0; }
</script>
</head>
<body class="foo">
</body>
</html>
Paul
Paul Pogonyshev <pogonyshev <at> gmx.net>:Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
Full text available.bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:bug#401; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.