GNU bug report logs - #45346
[elpa-archive] :ignored-files is processed to early

Previous Next

To reply to this bug, email your comments to 45346 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Subject: [elpa-archive] :ignored-files is processed to early
Date: Sun, 20 Dec 2020 21:41:02 +0100

Currently it is not possible to move some files out of a directory and
then ignore all the remaining files without having to specify each one
of them individually.  Ignoring the directory overrides and `:renames'
that attempt to move some files out of the directory.

A second unfortunate effect is that the directory is added to the
tarball even though it is empty after moving or removing all files it
originally contained.

It appears that `:ignored-files' is processes before `:renames' and
that that should be changed.

Message #8 received at 45346 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 45346 <at> debbugs.gnu.org
Subject: Re: bug#45346: [elpa-archive] :ignored-files is processed to early
Date: Sun, 20 Dec 2020 17:04:29 -0500

> It appears that `:ignored-files' is processes before `:renames' and
> that that should be changed.

Indeed, the renaming is applied last and it's not easy to change that
with the approach I use (the renaming is done by `tar` via
`--transform`).

Maybe I could try and remove the entries after generating the tarball.
Hmm...

Note, FWIW, I tend to consider that it's OK to keep useless files in the
tarball as long as they're not actively harmful (e.g. they triple the
size of the tarball), and more generally I think it's best to use
`:ignore` and `:renames` with moderation.


        Stefan

Message #11 received at 45346 <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 45346 <at> debbugs.gnu.org
Subject: Re: bug#45346: [elpa-archive] :ignored-files is processed to early
Date: Mon, 21 Dec 2020 11:20:34 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> It appears that `:ignored-files' is processes before `:renames' and
>> that that should be changed.
>
> Indeed, the renaming is applied last and it's not easy to change that
> with the approach I use (the renaming is done by `tar` via
> `--transform`).
>
> Maybe I could try and remove the entries after generating the tarball.
> Hmm...

IMO it would be better to just do it in lisp and simplify the call to
`tar'.

> Note, FWIW, I tend to consider that it's OK to keep useless files in the
> tarball as long as they're not actively harmful (e.g. they triple the
> size of the tarball), and more generally I think it's best to use
> `:ignore` and `:renames` with moderation.

I consider useless files to be actively harmful.  Some users will
investigate what those apparently useless files are for and once they
have seen that they are in fact useless some of them still won't be
satisfied and continue to wonder what they have missed because obviously
nobody would include such useless files...  I am like that and would
like to save others (plural) from having to do the same work over and
over again when I can just do it for them once.

     Jonas

Message #14 received at 45346 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 45346 <at> debbugs.gnu.org
Subject: Re: bug#45346: [elpa-archive] :ignored-files is processed to early
Date: Mon, 21 Dec 2020 09:36:11 -0500

>>> It appears that `:ignored-files' is processes before `:renames' and
>>> that that should be changed.
>> Indeed, the renaming is applied last and it's not easy to change that
>> with the approach I use (the renaming is done by `tar` via
>> `--transform`).
>> Maybe I could try and remove the entries after generating the tarball.
>> Hmm...
> IMO it would be better to just do it in lisp and simplify the call to `tar'.

BTW, in the mean time you can work around this by doing the
renames "by hand" in the `:make` rule.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.