GNU bug report logs - #47238
[PATCH] services: mcron: Export procedures for shepherd service

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47238 in the body.
You can then email your comments to 47238 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: mcron: Export procedures for shepherd service
Date: Thu, 18 Mar 2021 16:03:17 +0100

* gnu/services/mcron.scm (job-files): Export procedure.
  (shepherd-schedule-action): Likewise.
---
I am going to write an mcron service for `guix home`[1] so users can run
cron jobs for syncing mail, backups etc.  It would be nice to be able to
use these two procedures to avoid code duplication.

[1]: https://yhetil.org/guix-devel/878s6u2pco.fsf <at> trop.in

 gnu/services/mcron.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index bd4e6e7410..982af08596 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -31,6 +31,9 @@
             mcron-configuration-mcron
             mcron-configuration-jobs
 
+            job-files
+            shepherd-schedule-action
+
             mcron-service-type
             mcron-service))
 

base-commit: 9783645ee8eaf9c33ce952131e692fb2ff47ffc9
-- 
2.31.0

Message #8 received at 47238 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 47238 <at> debbugs.gnu.org
Subject: Re: bug#47238: [PATCH] services: mcron: Export procedures for
 shepherd service
Date: Sun, 28 Mar 2021 22:11:51 +0200

Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> * gnu/services/mcron.scm (job-files): Export procedure.
>   (shepherd-schedule-action): Likewise.
> ---
> I am going to write an mcron service for `guix home`[1] so users can run
> cron jobs for syncing mail, backups etc.  It would be nice to be able to
> use these two procedures to avoid code duplication.
>
> [1]: https://yhetil.org/guix-devel/878s6u2pco.fsf <at> trop.in

I’m often reluctant to exposing more than what’s strictly necessary
because that can then complicate maintenance work—we now have to extra
bindings to maintain.

In this case, it’s definitely not the end of the world, but I wonder if
there are other ways we could achieve what you have in mind.  For
instance, could Guix Home reuse ‘mcron-service-type’ as is?  Or, with an
eye on getting Guix Home into Guix proper, are there some minimal
changes we could make to accommodate that?

(I have yet to play with Guix Home and to look at the implementation…)

Ludo’.

Message #11 received at 47238 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 47238 <at> debbugs.gnu.org
Subject: Re: bug#47238: [PATCH] services: mcron: Export procedures for
 shepherd service
Date: Sun, 28 Mar 2021 23:31:42 +0200

On Sun, Mar 28 2021, Ludovic Courtès wrote:

> I’m often reluctant to exposing more than what’s strictly necessary
> because that can then complicate maintenance work—we now have to extra
> bindings to maintain.

Yeah, that's understandable.

> In this case, it’s definitely not the end of the world, but I wonder if
> there are other ways we could achieve what you have in mind.  For
> instance, could Guix Home reuse ‘mcron-seevice-type’ as is?

Right now all the service names are prefixed 'home-' to avoid name
clashes, though, maybe this could be changed in the future.  For now I
have just copied the definition of the procedures to Guix Home.

> Or, with an eye on getting Guix Home into Guix proper, are there some
> minimal changes we could make to accommodate that?

We are currently mostly focused on implementing some basic services
(e.g. Bash, GnuPG, Git).  After that we will probably invite some
volunteers to test it on their machines to get some more feedback.  Once
the basic services have been implemented and the documentation is
complete I think it would be appropriate to discuss merging Guix
Home to Guix proper, and probably refactor some stuff.

> (I have yet to play with Guix Home and to look at the implementation…)

There is a quickstart guide[1] on getting it up and running and we also
have a mailing list if you want to discuss things[2].  Andrew recently
made a video on the progress so far, and he touched a little on the
plan for the upcomming weeks/months.

Happy to see more people interested in Guix Home!

[1]: https://git.sr.ht/~abcdw/rde/tree/master/item/gnu/README
[2]: https://lists.sr.ht/~abcdw/rde-devel
[3]: https://youtube.com/watch?v=ZaXHtSKKoeg

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.