GNU bug report logs -
#48013
28.0.50; `icomplete-vertical-mode` does not support annotations/affixations
Previous Next
To reply to this bug, email your comments to 48013 AT debbugs.gnu.org.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#48013
; Package
emacs
.
(Sun, 25 Apr 2021 09:37:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Daniel Mendler <mail <at> daniel-mendler.de>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Sun, 25 Apr 2021 09:37:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
The recently introduced `icomplete-vertical-mode` does not yet support
annotations as provided by `annotation/affixation-function`. Thanks to
the vertical UI, there is plenty of space to show annotations. Many
other vertical UIs already offer support, e.g., Ivy, Vertico,
external Icomplete-vertical (by Omar Antolín Camarena), etc. Is support
for annotations planned in `icomplete-vertical-mode`?
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#48013
; Package
emacs
.
(Sun, 25 Apr 2021 09:50:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 48013 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>
> The recently introduced `icomplete-vertical-mode` does not yet support
> annotations as provided by `annotation/affixation-function`. Thanks to
> the vertical UI, there is plenty of space to show annotations. Many
> other vertical UIs already offer support, e.g., Ivy, Vertico, external
> Icomplete-vertical (by Omar Antolín Camarena), etc. Is support for
> annotations planned in `icomplete-vertical-mode`?
>
Thanks for your bug report. Yes, it was planned, although this wasn't a
top priority until your bug report arrived. It has now moved a bit closer
to the top of the stack ;-)
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#48013
; Package
emacs
.
(Sun, 25 Apr 2021 10:10:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 48013 <at> debbugs.gnu.org (full text, mbox):
On 4/25/21 11:49 AM, Gregory Heytings wrote:
> Thanks for your bug report. Yes, it was planned, although this wasn't a
> top priority until your bug report arrived. It has now moved a bit
> closer to the top of the stack ;-)
That's good to hear. You are probably aware of this - it is important to
annotate only the visible candidates, I think Omar's icomplete-vertical
implementation originally called all annotators, which lead to a
significant slowdown.
Thank you for working on this!
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#48013
; Package
emacs
.
(Sun, 23 May 2021 11:11:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 48013 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 5/23/21 11:37 AM, João Távora wrote:
> Can you give a visual example of what it looks like for a given completion
> table, ...
I attached two screenshots:
- M-x
- `describe-symbol` if `completions-detailed` is set
The layout is the same as in the usual *Completions* buffer, when
`completions-format` is set to `one-column`.
> ...along with the changes to the completion table code to take
> advantage of the new interface?
See for example `help--symbol-completion-table-affixation` in
help-fns.el or `read-extended-command--affixation` in simple.el.
There are more `annotation-function`s/`affixation-function`s present in
the Emacs code base if you grep.
See also minibuffer.el for the implementation for the *Completions* buffer.
> It seems that neither affixation or annotation were present in non-vertical
> icomplete.el before your patch. Do you have an idea why? Should they
> be added there, too?
There is not enough space in the vertical display. The only
annotations/affixations which would make sense are single character
annotations, maybe icons. But people who like the compact Ido/Icomplete
horizontal style probably would not want this additional noise.
Furthermore it makes the completions harder to read since you get
prefix-completion-suffix, prefix-completion-suffix, where everything is
mixed up. This is different from the vertical mode, where annotations
and candidates are visually separate and easier to distinguish.
Daniel
[describe-symbol.png (image/png, attachment)]
[Mx.png (image/png, attachment)]
This bug report was last modified 2 years and 346 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.