GNU bug report logs - #516
[PATCH] Minor Enhancement for grep.el: auto-input the symbol into minibuffer command line.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Kazuo YAGI <kyagi <at> miraclelinux.com>; Keywords: patch; dated Wed, 2 Jul 2008 03:55:04 UTC; Maintainer for emacs is bug-gnu-emacs <at> gnu.org.

Message received at 516 <at> emacsbugs.donarmstrong.com:

Received: (at 516) by emacsbugs.donarmstrong.com; 6 Dec 2009 01:27:48 +0000
From juri <at> jurta.org Sat Dec  5 17:27:48 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER,
	MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5])
	by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB61Rk1J030741
	for <516 <at> emacsbugs.donarmstrong.com>; Sat, 5 Dec 2009 17:27:48 -0800
X-Virus-Scanned: by Amavisd-New at mx1.starman.ee
Received: from mail.starman.ee (82.131.97.127.cable.starman.ee [82.131.97.127])
	by mx1.starman.ee (Postfix) with ESMTP id 40C913F4273;
	Sun,  6 Dec 2009 03:27:41 +0200 (EET)
From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: <516 <at> debbugs.gnu.org>
Subject: Re: bug#516: [PATCH] Minor Enhancement for grep.el: auto-input thesymbol into minibuffer command line.
Organization: JURTA
References: <486AFA3E.9050400 <at> miraclelinux.com>
	<87einaqjxu.fsf <at> mail.jurta.org>
	<AF6FC014CDF1491FBE5CCF731EF6BA5B <at> us.oracle.com>
	<87y6lh8bga.fsf <at> mail.jurta.org>
	<B7ACE3CCB87041F1B85EFE27F4D7C571 <at> us.oracle.com>
Date: Sun, 06 Dec 2009 02:35:31 +0200
In-Reply-To: <B7ACE3CCB87041F1B85EFE27F4D7C571 <at> us.oracle.com> (Drew Adams's
	message of "Sat, 5 Dec 2009 12:28:03 -0800")
Message-ID: <87ocmc51x0.fsf <at> mail.jurta.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

>> `grep-tag-default' already provides the active region. But it uses
>> `shell-quote-argument' instead of surrounding by quotes.  I don't know
>> what is better, since it's harder to edit the command when
>> `shell-quote-argument' puts a backslash before every space
>> and some other characters.
>
> Not only that, but:
>
> a. You must use M-n to put it in the minibuffer. Not a big deal, but you must
> know about this, to think to do that.

You can use `C-u grep' instead of `M-n' to put it in the minibuffer as
initial input.  However, `C-u grep' is worse than `M-n' because such use
of C-u is non-standard (unlike `M-n' that is the standard key to put the
default value in the minibuffer).

> b. A default file-name pattern (e.g. "*.el") is also included, as part of what's
> inserted.

That's what rgrep/lgrep do.  They provide a default file-name pattern
depending on the buffer's file name.

> All of that (especially the backslashing instead of quoting), makes it harder to
> edit the text to match and the file names to match.

I don't like backslashing too.

>> Another drawback of `grep-tag-default' is that it provides only
>> one alternative.  This is unlike `read-regexp' that proposes
>> a list of possible default values.  So `grep-tag-default' could be
>> improved to do the same.
>
> FWIW, the code I use inserts the (quoted) region or the symbol name nearest
> point (if no active region), and leaves out a file pattern. (You can still get
> the vanilla default using `M-n'.)

I agree it would be better to provide the active region, and the vanilla
default using `M-n'.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Acknowledgement sent to Juri Linkov <juri <at> jurta.org>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text available.