GNU bug report logs -
#58489
29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions
Previous Next
To reply to this bug, email your comments to 58489 AT debbugs.gnu.org.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Thu, 13 Oct 2022 11:10:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Uwe Brauer <oub <at> mat.ucm.es>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Thu, 13 Oct 2022 11:10:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi
I encountered a problem when I compiled the latest master (Using Ubuntu
16.04 and the corresponding GTK version)
I attach a screenshot
The config options are
auto-apt run ./configure --prefix=/opt/emacs29 --without-pop --with-mailutils
I bisected the problem and found out that the culprit is
commit 74c07733698b95eb455edcafab8634a700a3194f
Author: Po Lu <luangruo <at> yahoo.com>
Date: Thu, 17 Feb 2022 10:28:02 +0800
* src/emacsgtkfixed.c (XSetWMSizeHints): Improve fix for bug#8919.
Regards
Uwe Brauer
[emacs-no-athena.png (image/png, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 02:07:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
> Hi
>
> I encountered a problem when I compiled the latest master (Using Ubuntu
> 16.04 and the corresponding GTK version)
>
>
> I attach a screenshot
> The config options are
> auto-apt run ./configure --prefix=/opt/emacs29 --without-pop --with-mailutils
>
>
>
> I bisected the problem and found out that the culprit is
> commit 74c07733698b95eb455edcafab8634a700a3194f
> Author: Po Lu <luangruo <at> yahoo.com>
> Date: Thu, 17 Feb 2022 10:28:02 +0800
> * src/emacsgtkfixed.c (XSetWMSizeHints): Improve fix for bug#8919.
>
>
> Regards
>
> Uwe Brauer
Thanks. What happens if you set frame-resize-pixelwise to t in
early-init.el?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 05:35:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
> Uwe Brauer <oub <at> mat.ucm.es> writes:
> Thanks. What happens if you set frame-resize-pixelwise to t in
> early-init.el?
I have never used early-init.el
For debugging I always use emacs -Q
So do you want be to have early-init.el in my home directory or in emacs/src?
How should I start emacs then?
--
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 06:16:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
> So do you want be to have early-init.el in my home directory or in emacs/src?
In your home directory.
> How should I start emacs then?
Without "emacs -Q", if the bug can be reproduced that way.
Thanks.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 06:46:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
> Uwe Brauer <oub <at> mat.ucm.es> writes:
>> So do you want be to have early-init.el in my home directory or in emacs/src?
> In your home directory.
>> How should I start emacs then?
> Without "emacs -Q", if the bug can be reproduced that way.
Ok, interesting:
first the screenshots of emacs -Q and emacs -q
[emacs-emacs-q.png (image/png, attachment)]
[emacs-emacs-Q.png (image/png, attachment)]
[Message part 4 (text/plain, inline)]
Then the screenshot with the early-init
It seems to look ok but when it finishes loading all my init files, it
looks like emacs -Q
[emacs-emacs-full.png (image/png, attachment)]
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:06:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
> Then the screenshot with the early-init
>
> It seems to look ok but when it finishes loading all my init files, it
> looks like emacs -Q
Sigh. If you instrument emacsgtkfixed.c as follows:
if (hints->width_inc && data[5] % hints->width_inc)
data[5] += (hints->width_inc - (data[5] % hints->width_inc));
if (hints->height_inc && data[6] % hints->height_inc)
data[6] += (hints->height_inc - (data[6] % hints->height_inc));
(Add instrumentation following this line)
fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
data[5], data[6], hints->width_inc, hints->height_inc)
what is printed when you start Emacs with "-Q", and Kwin shrinks your
window?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:24:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
> Uwe Brauer <oub <at> mat.ucm.es> writes:
>> Then the screenshot with the early-init
>>
>> It seems to look ok but when it finishes loading all my init files, it
>> looks like emacs -Q
> Sigh. If you instrument emacsgtkfixed.c as follows:
> if (hints->width_inc && data[5] % hints->width_inc)
> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
> if (hints->height_inc && data[6] % hints->height_inc)
> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
> (Add instrumentation following this line)
> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
> data[5], data[6], hints->width_inc, hints->height_inc)
> what is printed when you start Emacs with "-Q", and Kwin shrinks your
> window?
I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
Not sure I understand, I apply the patch attached below and run make again:
Then I get an error (so most likely I misunderstood you)
GEN globals.h
CC emacsgtkfixed.o
emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
^
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
}
^
Makefile:414: recipe for target 'emacsgtkfixed.o' failed
make: *** [emacsgtkfixed.o] Error 1
[emacsgtkfixed.patch (text/x-diff, attachment)]
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:29:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
> Uwe Brauer <oub <at> mat.ucm.es> writes:
>> Then the screenshot with the early-init
>>
>> It seems to look ok but when it finishes loading all my init files, it
>> looks like emacs -Q
> Sigh. If you instrument emacsgtkfixed.c as follows:
> if (hints->width_inc && data[5] % hints->width_inc)
> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
> if (hints->height_inc && data[6] % hints->height_inc)
> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
> (Add instrumentation following this line)
> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
> data[5], data[6], hints->width_inc, hints->height_inc)
> what is printed when you start Emacs with "-Q", and Kwin shrinks your
> window?
I compiled it finally a ; was missing.
The message is
./emacs -Q
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
(emacs:833): Gtk-WARNING **: Allocating size to Emacs 0x1d503e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
XSetWMSizeHints: % % width_inc: % height_inc: %
--
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:37:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
>>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
>
>> Uwe Brauer <oub <at> mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>>
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>
>> Sigh. If you instrument emacsgtkfixed.c as follows:
>
>> if (hints->width_inc && data[5] % hints->width_inc)
>> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>> if (hints->height_inc && data[6] % hints->height_inc)
>> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>> (Add instrumentation following this line)
>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>> data[5], data[6], hints->width_inc, hints->height_inc)
>
>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>> window?
>
> I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
>
>
> Not sure I understand, I apply the patch attached below and run make again:
>
> Then I get an error (so most likely I misunderstood you)
>
>
> GEN globals.h
> CC emacsgtkfixed.o
> emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
> ^
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
> emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
> emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
> }
> ^
> Makefile:414: recipe for target 'emacsgtkfixed.o' failed
> make: *** [emacsgtkfixed.o] Error 1
Ah, silly me. Please replace %l with %ld.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:38:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
>>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
>
>> Uwe Brauer <oub <at> mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>>
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>
>> Sigh. If you instrument emacsgtkfixed.c as follows:
>
>> if (hints->width_inc && data[5] % hints->width_inc)
>> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>> if (hints->height_inc && data[6] % hints->height_inc)
>> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>> (Add instrumentation following this line)
>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>> data[5], data[6], hints->width_inc, hints->height_inc)
>
>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>> window?
>
>
> I compiled it finally a ; was missing.
>
> The message is
>
> ./emacs -Q
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
>
> (emacs:833): Gtk-WARNING **: Allocating size to Emacs 0x1d503e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
> XSetWMSizeHints: % % width_inc: % height_inc: %
Yes, sorry, please see my other reply.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:45:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
> Uwe Brauer <oub <at> mat.ucm.es> writes:
>>>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
>>
>>> Uwe Brauer <oub <at> mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>>
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>>
>>> Sigh. If you instrument emacsgtkfixed.c as follows:
>>
>>> if (hints->width_inc && data[5] % hints->width_inc)
>>> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>>> if (hints->height_inc && data[6] % hints->height_inc)
>>> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>>> (Add instrumentation following this line)
>>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>>> data[5], data[6], hints->width_inc, hints->height_inc)
>>
>>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>>> window?
>>
>> I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
>>
>>
>> Not sure I understand, I apply the patch attached below and run make again:
>>
>> Then I get an error (so most likely I misunderstood you)
>>
>>
>> GEN globals.h
>> CC emacsgtkfixed.o
>> emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
>> ^
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
>> emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
>> }
>> ^
>> Makefile:414: recipe for target 'emacsgtkfixed.o' failed
>> make: *** [emacsgtkfixed.o] Error 1
> Ah, silly me. Please replace %l with %ld.
,----
|
| make
| GEN globals.h
| CC emacsgtkfixed.o
| emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int’ [-Wformat=]
| fprintf (stderr, "XSetWMSizeHints: %ld %ld width_inc: %ld height_inc: %ld\n",
| ^
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘int’ [-Wformat=]
| make -C ../admin/charsets all
`----
And
,----
| ./emacs -Q
| XSetWMSizeHints: 297 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
|
| (emacs:2027): Gtk-WARNING **: Allocating size to Emacs 0x2be63e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
`----
[emacsgtkfixed-2.patch (text/x-diff, attachment)]
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:56:01 GMT)
Full text and
rfc822 format available.
Message #38 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
> | XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
That's odd. Unfortunately the previous code resulted in menu bar size
hints set by GTK not being respected, so I'm at odds wrt what to do
here. On one hand, your window manager is clearly buggy, but it used to
work. I guess a user option to enable the previous behavior would be
the most reasonable course of action.
Does anyone else have an opinion here?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 07:59:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 58489 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> "PL" == Po Lu <luangruo <at> yahoo.com> writes:
> Uwe Brauer <oub <at> mat.ucm.es> writes:
>> | XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
>> | XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
> That's odd. Unfortunately the previous code resulted in menu bar size
> hints set by GTK not being respected, so I'm at odds wrt what to do
> here. On one hand, your window manager is clearly buggy, but it used to
> work. I guess a user option to enable the previous behavior would be
> the most reasonable course of action.
> Does anyone else have an opinion here?
Two comments:
1. The compiling error I mentioned is not important?
2. Since I use athena, and this you fixed, for me that fix is not
urgent, besides I have to admit that I should upgrade Ubuntu.
--
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
[smime.p7s (application/pkcs7-signature, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#58489; Package
emacs.
(Fri, 14 Oct 2022 08:02:02 GMT)
Full text and
rfc822 format available.
Message #44 received at 58489 <at> debbugs.gnu.org (full text, mbox):
Uwe Brauer <oub <at> mat.ucm.es> writes:
> 1. The compiling error I mentioned is not important?
No, it's a warning, and the data printed is correct.
This bug report was last modified 1 year and 203 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.