Received: (at 64171) by debbugs.gnu.org; 18 Aug 2023 14:01:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 18 10:01:00 2023 Received: from localhost ([127.0.0.1]:48452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qX028-0001o8-Em for submit <at> debbugs.gnu.org; Fri, 18 Aug 2023 10:01:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1qX026-0001nq-Vi; Fri, 18 Aug 2023 10:00:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1qX01z-0002XM-NR; Fri, 18 Aug 2023 10:00:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=JhtAixlJdVTxmFpSU+3fqCvtJyXg1vCx85TjPRo9cNo=; b=Hoxa4lMOj32y5fwLedhW pSWlv46DHMMv5USI2nGLp0OttPzdLhxxLBjM1w9XUWWDP9OmLtCJr8c5qoSQm3rTBzsK+zLxkirk/ Z2TFhuHXTu2o6Fuk3d6fjTBhg5VGDUFX7nKP9Tp5FuDNn9wEF9rgzgkPTH2TLIP3UiTDX4KJxFPNJ yf7broYM6Di6r2741/kSIQnqvic72k048TayNRx4WEly8o20SLC00tlLMLL4PHpbiuAX+op8JQ8Ql 61EyF1MO4bfJi7kRlKQmdS2JRWO8py0qHRwuzrnDAqUEPBRrrk9SKzexWL0nP/kOBFalXcwyI+Eb7 PIzxU/+hS0ZguQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: [bug#64173] [PATCH 0/1] guix: pack: add --entry-point-argument option References: <cover.1687188729.git.graham@HIDDEN> <53f0c51cabbd317469721fb7f47b47af50d42177.1689149161.git.graham@HIDDEN> <87wmxuxax2.fsf_-_@HIDDEN> <87sf8h51pq.fsf@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 1 Fructidor an 231 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour de la Prune X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 18 Aug 2023 16:00:48 +0200 In-Reply-To: <87sf8h51pq.fsf@HIDDEN> (Simon Tournier's message of "Thu, 17 Aug 2023 13:48:33 +0200") Message-ID: <87zg2oqwkv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64171 Cc: Graham James Addis <graham@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Christopher Baines <mail@HIDDEN>, 64173 <at> debbugs.gnu.org, Mathieu Othacehe <othacehe@HIDDEN>, Graham James Addis <grahamjamesaddis@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, 64171 <at> debbugs.gnu.org, Ricardo Wurmus <rekado@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Simon Tournier <zimon.toutoune@HIDDEN> skribis: > Just to be sure to understand, the command-line could list several > --entry-point-argument options, right? Yes. > Well, since the order of the various command-line arguments might > matter, and since a =E2=80=99reverse=E2=80=99 is suggested, and since all= the Guix > command-lines do not behave the same way =E2=80=93 for instance =E2=80=9C= guix package=E2=80=9D > processes command-line argument from right to left; see #43585 or #50473 > [1,2]; anyway :-) =E2=80=93 I would suggest to add a sentence in the > documentation (manual) that the command-line arguments are parsed from > left to right. No: the =E2=80=98reverse=E2=80=99 puts them back in the right order (because =E2=80=98args-fold*=E2=80=99 traverses the option list from left to right a= nd thus conses the result in reverse order.) HTH! Ludo=E2=80=99.
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.
Received: (at 64171) by debbugs.gnu.org; 17 Aug 2023 14:07:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 17 10:07:16 2023
Received: from localhost ([127.0.0.1]:45253 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qWdee-0007W7-1r
for submit <at> debbugs.gnu.org; Thu, 17 Aug 2023 10:07:16 -0400
Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:40305)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>)
id 1qWdea-0007Vp-Ub; Thu, 17 Aug 2023 10:07:15 -0400
Received: by mail-wm1-x335.google.com with SMTP id
5b1f17b1804b1-3fe8d816a40so12940405e9.1;
Thu, 17 Aug 2023 07:07:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1692281227; x=1692886027;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=ZsoI3nzONheWXBjGPK4RyHGMt1L2bXcPY2xSHnkfI/U=;
b=QkoQHL2kkU9zIJDGO77vIWrrflA+1a47dMhBUtmmX9aEzV6y0lR/i2DYGbWJYvJdj9
PucKllJ6BomCRSQmafvaSamiJDOn5v4tv9Nnh5KRPUgcLoiovKtXUqceEsR7tx0RzgnK
nzalATEJHjeDefdPfx+6unLTLoqEP+BHIPo4AX6BhqHT4W1aFMcqbc8pwgSiw/68t2zf
5wwM+zE+XV21LFg0u939dWCWveio4y31JE+xCeHoMt3Yq4gr5dhEQzIGy3gdruogzHdV
azoBIVyDd9muon2zY6ko0Yq6F7J86mq0ebwp7ZgharbgH0OHkKTtEBFtiy5IiRML3KQz
h4lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1692281227; x=1692886027;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=ZsoI3nzONheWXBjGPK4RyHGMt1L2bXcPY2xSHnkfI/U=;
b=Y5VLoqljc7NBsZHu1COqOCTusK4tW5KsfPcwmOQceCeq7l1bblHwISUSuvIbbxoH9p
v6vn+CPq22TiMktrNoVP/XQpzQzP3rGd+WsvYOTOZqlEQQF7oKcf0g7/N3CoYFMBr75q
+roW1UqQ4X06IE7pJhIItsUnLSAoYDsq34q/Q2L9YxTFBvOzNmUG+Fg4liRWO9+0lJXw
GyJdyhrVwNDCTooMsai58Mfs+QAYm4nab1iQmHw6e6Fb5inSLdRt2OQdVpb7nAX26a3M
y4L6zxIKolbbokjX8urIADon1e+a/EzJe+5PraVxrGYUUK9bdQDLTeEFFVUQPi/QISeM
9xHA==
X-Gm-Message-State: AOJu0YyL/ZYJ7JSxZ0Xp0nNH86LIbuDaI4WV0xDblTHzWGnOWTc2zOgi
z4IoZPWiO0Rtzq68wqVXqsc=
X-Google-Smtp-Source: AGHT+IHsPxZBPIhDy+fMSHSbobm6QRDF4LtKVxU6Vt1sVtKylCmm4KF/duH63b25d9Y11EnRFiFfJg==
X-Received: by 2002:a05:600c:3108:b0:3fc:2d8:b1f2 with SMTP id
g8-20020a05600c310800b003fc02d8b1f2mr4589896wmo.3.1692281226636;
Thu, 17 Aug 2023 07:07:06 -0700 (PDT)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
p11-20020a1c740b000000b003fbb0c01d4bsm3141328wmc.16.2023.08.17.07.07.06
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 17 Aug 2023 07:07:06 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Graham James Addis
<grahamjamesaddis@HIDDEN>
Subject: Re: [bug#64173] [PATCH 0/1] guix: pack: add --entry-point-argument
option
In-Reply-To: <87wmxuxax2.fsf_-_@HIDDEN>
References: <cover.1687188729.git.graham@HIDDEN>
<53f0c51cabbd317469721fb7f47b47af50d42177.1689149161.git.graham@HIDDEN>
<87wmxuxax2.fsf_-_@HIDDEN>
Date: Thu, 17 Aug 2023 13:48:33 +0200
Message-ID: <87sf8h51pq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 64171
Cc: Graham James Addis <graham@HIDDEN>, Josselin Poiret <dev@HIDDEN>,
Christopher Baines <mail@HIDDEN>, 64173 <at> debbugs.gnu.org,
Mathieu Othacehe <othacehe@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
64171 <at> debbugs.gnu.org, Ricardo Wurmus <rekado@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
On Thu, 17 Aug 2023 at 11:42, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
>> +(define (entry-point-argument-spec-option-parser opt name arg result)
>> + "A SRFI-37 opion parser for the --entry-point-argument option. The sp=
ec
>> +takes multiple occurances. The entries are used in the exec form for the
>> +docker entry-point. The values are used as parameters in conjunction wi=
th
>> +the --entry-point option which is used as the first value in the exec f=
orm."
>> + (let ((entry-point-argument (assoc-ref result 'entry-point-argument)))
>> + (alist-cons 'entry-point-argument
>> + (append entry-point-argument (list arg))
>> + (alist-delete 'entry-point-argument result eq?))))
>
> I would just keep a regular option parser that does:
>
> (alist-cons 'entry-point-argument arg result)
>
> Later on, we=E2=80=99d collect all these arguments:
>
> (reverse
> (filter-map (match-lambda
> (('entry-point-argument . arg) arg)
> (_ #f))
> opts))
>
> I think this would be a bit clearer; this is what =E2=80=98guix repl=E2=
=80=99 does, for
> instance.
[...]
> This can be omitted if you take the approach suggested above, with one
> =E2=80=98entry-point-argument=E2=80=99 pair per argument.
[...]
> This would become #:entry-point-arguments (plural), with the
> =E2=80=98filter-map=E2=80=99 trick shown above.
Just to be sure to understand, the command-line could list several
--entry-point-argument options, right?
Well, since the order of the various command-line arguments might
matter, and since a =E2=80=99reverse=E2=80=99 is suggested, and since all t=
he Guix
command-lines do not behave the same way =E2=80=93 for instance =E2=80=9Cgu=
ix package=E2=80=9D
processes command-line argument from right to left; see #43585 or #50473
[1,2]; anyway :-) =E2=80=93 I would suggest to add a sentence in the
documentation (manual) that the command-line arguments are parsed from
left to right.
1: https://issues.guix.gnu.org/issue/43585
2: https://issues.guix.gnu.org/issue/50473
Cheers,
simon
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.
Received: (at 64171) by debbugs.gnu.org; 17 Aug 2023 09:42:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 17 05:42:31 2023
Received: from localhost ([127.0.0.1]:42779 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qWZWR-0000HD-4n
for submit <at> debbugs.gnu.org; Thu, 17 Aug 2023 05:42:31 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57128)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>)
id 1qWZWO-0000Gv-3i; Thu, 17 Aug 2023 05:42:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1qWZWH-000548-Gv; Thu, 17 Aug 2023 05:42:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=9PFGrYCpoXycpLt0tHRB0LM8Phjn29++3lGHcvslrJc=; b=CFSSTTgfAQk9q5U6dg1E
8e7ksQPHhlhhdvGeopsustjY0S7DciBeVIHyfl1D6qDwNieDMalIYtUer7pIJnZuyVT7sqJkKdii9
kY9v7Yl9+vqI7p+JaHpWJAH8xeKAdDDo31+OmKliTWxJ2TTgrTO6bs5wAyI/7zhYzuK6lbgHb3j0K
Z2xem/pOIGTLyJUjVkxONcpQhy+il6Je7eX2Ga7i38kUf/kgBQtjV0jLx/gPLlds5tPZ0nIYEQTLB
pMhGwb/ncGniQRe6WBPxy2toPv8Txx/sKvKVpwZONGtu6eicWfUoXa9V2HK7T0EahV7DtuSN8ur5d
2uMBhZOt0ltAgA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Graham James Addis <grahamjamesaddis@HIDDEN>
Subject: Re: bug#64173: [PATCH 0/1] guix: pack: add --entry-point-argument
option
References: <cover.1687188729.git.graham@HIDDEN>
<53f0c51cabbd317469721fb7f47b47af50d42177.1689149161.git.graham@HIDDEN>
Date: Thu, 17 Aug 2023 11:42:17 +0200
In-Reply-To: <53f0c51cabbd317469721fb7f47b47af50d42177.1689149161.git.graham@HIDDEN>
(Graham James Addis's message of "Wed, 12 Jul 2023 09:17:13 +0100")
Message-ID: <87wmxuxax2.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 64171
Cc: Graham James Addis <graham@HIDDEN>, Josselin Poiret <dev@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>, 64173 <at> debbugs.gnu.org,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Christopher Baines <mail@HIDDEN>, 64171 <at> debbugs.gnu.org,
Ricardo Wurmus <rekado@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi Graham,
Apologies for the delay (holiday time!).
Graham James Addis <grahamjamesaddis@HIDDEN> skribis:
> * guix/scripts/pack.scm: add support for parameters in entry-point
> (entry-point-argument-spec-option-parser): add function to parse --entry-=
point-argument
> (docker-image): Add function (form_entry_point) to handle --entry-point
> vs --entry-point-argument merging
> (docker-image): change call to (build-docker-image) to use (form-entry-po=
int)
> (%default-options): add dafault for --entry-point-argument option
> (%docker-format-options): parser for --entry-point-argument
> (show-docker-format-options): help for --docker-format-options
> (show-docker-format-options/detailed): detailed help for --docker-format-=
options
> (%options): add flag for --help-docker-format and add parser for --docker=
-format-options
> (extra-options): add entry-point-argument option
This is really a minor issue and I don=E2=80=99t mind fixing it for you, but
note that the ChangeLog style just needs to say what has been
changed/added/removed. For example:
(entry-point-argument-spec-option-parser): New procedure.
> (guix.texi): add documentation
And here:
* doc/guix.texi (Inovking guix pack): Document it.
I like this new version. Here are a few things that I think would need
to be changed before we can push:
> +@cindex entry point arguments, for docker images
> +@item --entry-point-argument=3D@var{command}
> +@itemx -A @var{command}
Maybe @var{argument} for consistency and clarity?
> +Use @var{command} as an argument to @dfn{entry point} of the resulting p=
ack.
> +This option is only valid in conjunction with @code{--entry-point} and c=
an
> +appear multiple times on the command line.
Maybe add: =E2=80=9CThe example below shows illustrates that, passing
@option{--help} to the @command{guile} command:=E2=80=9D
> +@example
> +guix pack -f docker --entry-point=3Dbin/guile --entry-point-argument=3D"=
--help" guile
> +@end example
[...]
> +(define (entry-point-argument-spec-option-parser opt name arg result)
> + "A SRFI-37 opion parser for the --entry-point-argument option. The spec
> +takes multiple occurances. The entries are used in the exec form for the
> +docker entry-point. The values are used as parameters in conjunction with
> +the --entry-point option which is used as the first value in the exec fo=
rm."
> + (let ((entry-point-argument (assoc-ref result 'entry-point-argument)))
> + (alist-cons 'entry-point-argument
> + (append entry-point-argument (list arg))
> + (alist-delete 'entry-point-argument result eq?))))
I would just keep a regular option parser that does:
(alist-cons 'entry-point-argument arg result)
Later on, we=E2=80=99d collect all these arguments:
(reverse
(filter-map (match-lambda
(('entry-point-argument . arg) arg)
(_ #f))
opts))
I think this would be a bit clearer; this is what =E2=80=98guix repl=E2=80=
=99 does, for
instance.
> + (define (form-entry-point
> + prefix entry-point
> + entry-point-argument)
> + ;; construct entry-point parameter for build-docker-image
> + ;; the first entry is constructed by prefixing the entry-p=
oint
> + ;; with the supplied index subsequent entries are taken fr=
om
> + ;; the --entry-point-argument options
> + (cond
> + (entry-point
> + (cons*
> + (string-append prefix "/" entry-point)
> + entry-point-argument)
> + )
I=E2=80=99d avoid this extra procedure.
> + ('()))) ;empty list returned if no conditions are met
> +
> + (let-keywords '#$extra-options #f ((entry-point-argument #f))
> + (setenv "PATH" #+(file-append archiver "/bin"))
> +
> + (build-docker-image #$output
> + (map store-info-item
> + (call-with-input-file "profile"
> + read-reference-graph))
> + #$profile
> + #:repository (manifest->friendly-name
> + (profile-manifest #$prof=
ile))
> + #:database #+database
> + #:system (or #$target %host-type)
> + #:environment environment
> + #:entry-point (form-entry-point
> + #$profile
> + #$entry-point
> + entry-point-argument)
How about keeping it similar to what it looks like currently:
#:entry-point
#$(and entry-point
#~(cons (string-append #$profile "/"
#$entry-point)
'#$(or (assoc-ref extra-options
#:entry-point-arguments)
'())))
?
> @@ -1346,6 +1375,7 @@ (define %default-options
> (debug . 0)
> (verbosity . 1)
> (symlinks . ())
> + (entry-point-argument . ())
This can be omitted if you take the approach suggested above, with one
=E2=80=98entry-point-argument=E2=80=99 pair per argument.
> +(define %docker-format-options
> + (list (option '(#\A "entry-point-argument") #t #f
> + entry-point-argument-spec-option-parser)))
> +
> +(define (show-docker-format-options)
> + (display (G_ "
> + --help-docker-format
> + list options specific to the DOCKER format")))
> +
> +(define (show-docker-format-options/detailed)
> + (display (G_ "
> + -A, --entry-point-argument=3DCOMMAND/PARAMETER
> + Value(s) to use for the Docker EntryPoint argum=
ents.
> + Multiple instances are accepted. This is only v=
alid
> + in conjunction with the --entry-point option."))
> + (newline)
> + (exit 0))
> +
> (define %options
> ;; Specifications of the command-line options.
> (cons* (option '(#\h "help") #f #f
> @@ -1508,8 +1557,13 @@ (define %options
> (lambda args
> (show-rpm-format-options/detailed)))
>=20=20
> + (option '("help-docker-format") #f #f
> + (lambda args
> + (show-docker-format-options/detailed)))
> +
> (append %deb-format-options
> %rpm-format-options
> + %docker-format-options
> @@ -1528,6 +1582,7 @@ (define (show-help)
> (newline)
> (show-deb-format-options)
> (show-rpm-format-options)
> + (show-docker-format-options)
Leftover, can be removed.
> @@ -1696,6 +1751,8 @@ (define-command (guix-pack . args)
> (process-file-arg opts 'preun=
-file)
> #:postun-file
> (process-file-arg opts 'postu=
n-file)))
> + ('docker
> + (list #:entry-point-argument (assoc=
-ref opts 'entry-point-argument)))
This would become #:entry-point-arguments (plural), with the
=E2=80=98filter-map=E2=80=99 trick shown above.
Also, it should be possible to make it work for the Singularity backend,
right? We can keep it for a subsequent commit if you prefer, but then
please add a TODO comment.
Could you send an updated patch?
Thanks in advance!
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.
Received: (at 64171) by debbugs.gnu.org; 12 Jul 2023 08:20:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 12 04:20:28 2023
Received: from localhost ([127.0.0.1]:51669 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qJV53-0005LT-Vk
for submit <at> debbugs.gnu.org; Wed, 12 Jul 2023 04:20:28 -0400
Received: from mail-wr1-f52.google.com ([209.85.221.52]:42119)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <grahamjamesaddis@HIDDEN>) id 1qJV4p-0005Ke-BK
for 64171 <at> debbugs.gnu.org; Wed, 12 Jul 2023 04:20:12 -0400
Received: by mail-wr1-f52.google.com with SMTP id
ffacd0b85a97d-31297125334so267593f8f.0
for <64171 <at> debbugs.gnu.org>; Wed, 12 Jul 2023 01:19:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1689149993; x=1691741993;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=6DvfRgU6D1RFgcOYW1czGv18FOcvyTmIi94uKKh8lsk=;
b=ASkIcXDbzkNN/hofLOUl0+4hbKBy1GaW/VIuXHeSTc/H/5O6cQxoztJId06Gs5IUb/
Dd44I/v6AArQKVdMK+fCmovyLW0gFaMpZe9NwUSl52gKr6BmwvHI/f8WDNhiRGXbW7bB
y0pB7lKMjUNYfPrfYmSS7ONOEvb+E1luDzXR7unGi9J3p66RFUSvdsk5VoJcPGEUpeML
rSam7IUZsjjnTjfj+U7PZD9M4EQ2GKu2dJYHKSYsq8dtlrrAU2cArMYGt7mQgTyay2SY
5Z2XUnyawWhZbpiceu7d3E8GrPpJxSorrxgSTnrGBAK8yOFa8eJlwGw6hZcC9tm5FIBh
dpdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1689149993; x=1691741993;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=6DvfRgU6D1RFgcOYW1czGv18FOcvyTmIi94uKKh8lsk=;
b=jZSXW3HFgYOU6eH2yjEhpCMS9/+67KiEV3h+On/bpfu/eJYrln7gHAdNxyhTFdJ6ma
GyU6+ZT5J3ATe91hqROD0+NVQ56wWATYVDWGZWbg8/9PlShTuA4mWDNj+6q+D0namOWf
qx1sLMnRKq7hBhXWwNss62dYgqQj/R11kS8AEn8s197RwNmMWP/004pZ8vSuAAu/gti6
evra036VKe/ugSo38r0wJ8SvX0cV8MEr8LVVIYZkesGJV2BSoiOxEwxp5Jn6cj0sClz0
5e6wJUF3kzjWp1kddcADv3pIoF8auD89UY3Vk4W03bFghEpiEOd2dolX6qJxRlWesbKM
J4SQ==
X-Gm-Message-State: ABy/qLY0EFzPrRaJKr/IFJ1YFAwWggf2nDbBA2dfYHaQKsUtQ1ekZKKY
pWM4sCAWj3+v9u43pJkXj2z7FrMuv9I=
X-Google-Smtp-Source: APBJJlHy096H++8hNajgX2CJPB73t6L+5KhTv4WNGX6f1QdRrzAWDfm+p4vVyz+KePV7zwMiG+X+vA==
X-Received: by 2002:a05:6000:180f:b0:311:b18:9ca4 with SMTP id
m15-20020a056000180f00b003110b189ca4mr1017156wrh.17.1689149992966;
Wed, 12 Jul 2023 01:19:52 -0700 (PDT)
Received: from guix-test.home ([2a00:23c7:59a9:c901:41c8:db68:b8b1:9808])
by smtp.gmail.com with ESMTPSA id
24-20020a05600c22d800b003fbaade072dsm4422283wmg.23.2023.07.12.01.19.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 12 Jul 2023 01:19:52 -0700 (PDT)
From: Graham James Addis <grahamjamesaddis@HIDDEN>
X-Google-Original-From: Graham James Addis <graham@HIDDEN>
To: 64171 <at> debbugs.gnu.org
Subject: [PATCH 0/1 v2] guix: pack: docker add --entry-point-argument options
Date: Wed, 12 Jul 2023 09:17:13 +0100
Message-Id: <53f0c51cabbd317469721fb7f47b47af50d42177.1689149161.git.graham@HIDDEN>
X-Mailer: git-send-email 2.40.1
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <mail@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 64171
Cc: Graham James Addis <graham@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/pack.scm: add support for parameters in entry-point
(entry-point-argument-spec-option-parser): add function to parse --entry-point-argument
(docker-image): Add function (form_entry_point) to handle --entry-point
vs --entry-point-argument merging
(docker-image): change call to (build-docker-image) to use (form-entry-point)
(%default-options): add dafault for --entry-point-argument option
(%docker-format-options): parser for --entry-point-argument
(show-docker-format-options): help for --docker-format-options
(show-docker-format-options/detailed): detailed help for --docker-format-options
(%options): add flag for --help-docker-format and add parser for --docker-format-options
(extra-options): add entry-point-argument option
(guix.texi): add documentation
---
doc/guix.texi | 14 +++++-
guix/scripts/pack.scm | 107 ++++++++++++++++++++++++++++++++----------
2 files changed, 95 insertions(+), 26 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 4e7faf8aea..10d220c7b9 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -116,6 +116,7 @@
Copyright @copyright{} 2023 Karl Hallsby@*
Copyright @copyright{} 2023 Nathaniel Nicandro@*
Copyright @copyright{} 2023 Tanguy Le Carrour@*
+Copyright @copyright{} 2023 Graham James Addis@*
Permission is granted to copy, distribute and/or modify this document
under the terms of the GNU Free Documentation License, Version 1.3 or
@@ -7410,7 +7411,7 @@ Invoking guix pack
@env{GUIX_EXECUTION_ENGINE} environment variable accordingly.
@end quotation
-@cindex entry point, for Docker images
+@cindex entry point, for Docker and Singularity images
@item --entry-point=@var{command}
Use @var{command} as the @dfn{entry point} of the resulting pack, if the pack
format supports it---currently @code{docker} and @code{squashfs} (Singularity)
@@ -7433,6 +7434,17 @@ Invoking guix pack
docker run @var{image-id}
@end example
+@cindex entry point arguments, for docker images
+@item --entry-point-argument=@var{command}
+@itemx -A @var{command}
+Use @var{command} as an argument to @dfn{entry point} of the resulting pack.
+This option is only valid in conjunction with @code{--entry-point} and can
+appear multiple times on the command line.
+
+@example
+guix pack -f docker --entry-point=bin/guile --entry-point-argument="--help" guile
+@end example
+
@item --expression=@var{expr}
@itemx -e @var{expr}
Consider the package @var{expr} evaluates to.
diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index 0dc9979194..c620eb9dc0 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -8,6 +8,7 @@
;;; Copyright © 2020, 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
;;; Copyright © 2020 Eric Bavier <bavier@HIDDEN>
;;; Copyright © 2022 Alex Griffin <a@HIDDEN>
+;;; Copyright © 2023 Graham James Addis <graham@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -193,6 +194,16 @@ (define (symlink-spec-option-parser opt name arg result)
(leave (G_ "~a: invalid symlink specification~%")
arg))))
+(define (entry-point-argument-spec-option-parser opt name arg result)
+ "A SRFI-37 opion parser for the --entry-point-argument option. The spec
+takes multiple occurances. The entries are used in the exec form for the
+docker entry-point. The values are used as parameters in conjunction with
+the --entry-point option which is used as the first value in the exec form."
+ (let ((entry-point-argument (assoc-ref result 'entry-point-argument)))
+ (alist-cons 'entry-point-argument
+ (append entry-point-argument (list arg))
+ (alist-delete 'entry-point-argument result eq?))))
+
(define (set-utf8-locale profile)
"Configure the environment to use the \"en_US.utf8\" locale provided by the
GLIBC-UT8-LOCALES package."
@@ -626,6 +637,7 @@ (define* (docker-image name profile
(guix build utils)
(guix profiles) (guix search-paths)
(srfi srfi-1) (srfi srfi-19)
+ (ice-9 optargs)
(ice-9 match))
#$(procedure-source manifest->friendly-name)
@@ -653,31 +665,48 @@ (define* (docker-image name profile
`((directory "/tmp" ,(getuid) ,(getgid) #o1777)
,@(append-map symlink->directives '#$symlinks)))
- (setenv "PATH" #+(file-append archiver "/bin"))
-
- (build-docker-image #$output
- (map store-info-item
- (call-with-input-file "profile"
- read-reference-graph))
- #$profile
- #:repository (manifest->friendly-name
- (profile-manifest #$profile))
- #:database #+database
- #:system (or #$target %host-type)
- #:environment environment
- #:entry-point
- #$(and entry-point
- #~(list (string-append #$profile "/"
- #$entry-point)))
- #:extra-files directives
- #:compressor #+(compressor-command compressor)
- #:creation-time (make-time time-utc 0 1))))))
-
- (gexp->derivation (string-append name ".tar"
- (compressor-extension compressor))
- build
- #:target target
- #:references-graphs `(("profile" ,profile))))
+ (define (form-entry-point
+ prefix entry-point
+ entry-point-argument)
+ ;; construct entry-point parameter for build-docker-image
+ ;; the first entry is constructed by prefixing the entry-point
+ ;; with the supplied index subsequent entries are taken from
+ ;; the --entry-point-argument options
+ (cond
+ (entry-point
+ (cons*
+ (string-append prefix "/" entry-point)
+ entry-point-argument)
+ )
+ ('()))) ;empty list returned if no conditions are met
+
+ (let-keywords '#$extra-options #f ((entry-point-argument #f))
+
+ (setenv "PATH" #+(file-append archiver "/bin"))
+
+ (build-docker-image #$output
+ (map store-info-item
+ (call-with-input-file "profile"
+ read-reference-graph))
+ #$profile
+ #:repository (manifest->friendly-name
+ (profile-manifest #$profile))
+ #:database #+database
+ #:system (or #$target %host-type)
+ #:environment environment
+ #:entry-point (form-entry-point
+ #$profile
+ #$entry-point
+ entry-point-argument)
+ #:extra-files directives
+ #:compressor #+(compressor-command compressor)
+ #:creation-time (make-time time-utc 0 1)))))))
+
+ (gexp->derivation (string-append name ".tar"
+ (compressor-extension compressor))
+ build
+ #:target target
+ #:references-graphs `(("profile" ,profile))))
;;;
@@ -1346,6 +1375,7 @@ (define %default-options
(debug . 0)
(verbosity . 1)
(symlinks . ())
+ (entry-point-argument . ())
(compressor . ,(first %compressors))))
(define %formats
@@ -1428,6 +1458,25 @@ (define (show-rpm-format-options/detailed)
(newline)
(exit 0))
+
+(define %docker-format-options
+ (list (option '(#\A "entry-point-argument") #t #f
+ entry-point-argument-spec-option-parser)))
+
+(define (show-docker-format-options)
+ (display (G_ "
+ --help-docker-format
+ list options specific to the DOCKER format")))
+
+(define (show-docker-format-options/detailed)
+ (display (G_ "
+ -A, --entry-point-argument=COMMAND/PARAMETER
+ Value(s) to use for the Docker EntryPoint arguments.
+ Multiple instances are accepted. This is only valid
+ in conjunction with the --entry-point option."))
+ (newline)
+ (exit 0))
+
(define %options
;; Specifications of the command-line options.
(cons* (option '(#\h "help") #f #f
@@ -1508,8 +1557,13 @@ (define %options
(lambda args
(show-rpm-format-options/detailed)))
+ (option '("help-docker-format") #f #f
+ (lambda args
+ (show-docker-format-options/detailed)))
+
(append %deb-format-options
%rpm-format-options
+ %docker-format-options
%transformation-options
%standard-build-options
%standard-cross-build-options
@@ -1528,6 +1582,7 @@ (define (show-help)
(newline)
(show-deb-format-options)
(show-rpm-format-options)
+ (show-docker-format-options)
(newline)
(display (G_ "
-f, --format=FORMAT build a pack in the given FORMAT"))
@@ -1696,6 +1751,8 @@ (define-command (guix-pack . args)
(process-file-arg opts 'preun-file)
#:postun-file
(process-file-arg opts 'postun-file)))
+ ('docker
+ (list #:entry-point-argument (assoc-ref opts 'entry-point-argument)))
(_ '())))
(target (assoc-ref opts 'target))
(bootstrap? (assoc-ref opts 'bootstrap?))
base-commit: 2426e51688d479042ea115a634c6be2d8b9f3b99
--
2.39.2
mail@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.Graham Addis <grahamjamesaddis@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 64171) by debbugs.gnu.org; 9 Jul 2023 08:31:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 09 04:31:21 2023 Received: from localhost ([127.0.0.1]:45790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qIPpA-00028o-Sd for submit <at> debbugs.gnu.org; Sun, 09 Jul 2023 04:31:21 -0400 Received: from jpoiret.xyz ([206.189.101.64]:38236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dev@HIDDEN>) id 1qIPp8-00028f-DB for 64171 <at> debbugs.gnu.org; Sun, 09 Jul 2023 04:31:19 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 5546D185300; Sun, 9 Jul 2023 08:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1688891471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d0t78nmTQEe1mPEShvnegjXLmJnutCFTwAyrDwvI3+w=; b=WyX/9GpRYyaiHgJFTN/mCZjpmMxamYHsmhQPZhE1bAkytZfkDOQo09h0Ajd+5ddRBk/LC3 4WzUa01+8cBuSImpuLAv8W3t+GvqDAAXLJJIn5FncLJGtt74JFSo6/EyTnPyejRX/+4vbx ymj6stD2P4GQ4d4pt6wZzWDr1U8xUxhIB7C7VsTbwCJZtKFJlXBI551kGsZ0Unr8DsgGRk AdBOD6nk/3erEG38290t/J3nzXKatJjoilTOQFLYV1fjnkyXtLHAbcXhmcPhK0xVp2IVOz QNzqDmsqxDWngcFxFsTtENhboMUXazNDkUfi2umjrfEIzGCEEXxdt0ZuYw6TEg== From: Josselin Poiret <dev@HIDDEN> To: Graham Addis <grahamjamesaddis@HIDDEN>, Giovanni Biscuolo <g@HIDDEN> Subject: Re: [bug#64171] [PATCH 0/1] guix: pack: docker add docker-entry-point options In-Reply-To: <CAA4DTexMugyaAxWqZPpiALkVDSApWU63KeaauwvUuk8sG+cQCg@HIDDEN> References: <cover.1687188729.git.graham@HIDDEN> <87r0ppqrbx.fsf@HIDDEN> <CAA4DTex_Kg_Jhn-z+RHrw2=WcuG3ZxSiOGZE1MtsYpnhCox4tQ@HIDDEN> <87mt0dkkxp.fsf@HIDDEN> <CAA4DTexMugyaAxWqZPpiALkVDSApWU63KeaauwvUuk8sG+cQCg@HIDDEN> Date: Sun, 09 Jul 2023 10:31:07 +0200 Message-ID: <87y1jp8p10.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@HIDDEN smtp.mailfrom=dev@HIDDEN X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64171 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 64171 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Graham, Graham Addis <grahamjamesaddis@HIDDEN> writes: > One last question, as the proposed changes no longer reflect this bug > description, should I raise a new bug, or just add the replacement > patch to this one? You can retitle bugs on debbugs, have a look at [1]. [1] https://debbugs.gnu.org/server-control.html Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmSqcEsQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5Fhcait2BDACEgy4mLpBl7wQ2/MSZD07MbwGT8h9/K2WD AegmFj22RI2+GAVJnA2t1hNiPFpXGwLc7/58SPflyGhIUfm9kdzLHCmXsoz8p4jL DDAXJBX/r4OsGsE/OxX61/3xLynWzim1qNCT2PuoB/PXj1HjEyAWc+JtwRpwpELw fOZ9QLkBtQpML6HVtQZEc2vm74/Gd/4huxz6C4EAqf5se2ee1kxjpIpupHQU9Ddj bb2cTGjzXwg//Dn6bTrKXQ8BqSDlSmU4b5Ie0HMT4pnaX5wg5HrIshbpgfi3lfbV cylejAmbq6LC+BWit69iQttaE3F5q26/Wgo6eAgaPyKn9jtHy6FSPvnzP9pltli/ nwLg//p7lDLeNF38wvcot3H3iQzJXlI62ktxZ0WiRfg/RllGi5kqtyyNrr9h4mUK tdLhOvJ3/3fwQhuCuHmVJx3+WN70RKmT6w7boZ0FElGu0qQws3F4oo8GURLViKkC BFq6tTgoDeASPDorStVs2zYZuKx91Ec= =1miX -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.Received: (at 64171) by debbugs.gnu.org; 8 Jul 2023 16:08:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 08 12:08:30 2023 Received: from localhost ([127.0.0.1]:45073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qIAU1-0001uL-UG for submit <at> debbugs.gnu.org; Sat, 08 Jul 2023 12:08:30 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:62932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <grahamjamesaddis@HIDDEN>) id 1qIATz-0001u6-Dh for 64171 <at> debbugs.gnu.org; Sat, 08 Jul 2023 12:08:27 -0400 Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2633fe9b6c0so2810485a91.1 for <64171 <at> debbugs.gnu.org>; Sat, 08 Jul 2023 09:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688832501; x=1691424501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4ACDe6d8+qpNHMR+4QPJYvgS6RYLH0JunSRJgsID8OM=; b=a8BhYoscN864EiDlHgCDGkrG3dAD+Q8+xnI0GfzUVm3VLifCRkNT2PKjmGecBvzs1S a/rgUFht6Q5cFrhVrVhL4n+VSB/OTFtLRR+txNsEUWqSENWCCsIDqrYS0ZL1GuCqs7aQ 2Ku7lpTJWFpIeYJGSZJieQdg7Bec2kyBa6BBYA8G8p5Y1BmT7LH9+p1f2ZDs6uf1URsN R71pPEzyjn1i92vdwe6RpGpoYbw9qIxUySwNMlk8ak/T5Ge4vUH3nupVAEzlb9DHqwpN n3Wcj87E7jzsrxyj8vUjYMC6PqyQhlG5Cl1WrzHyIHxYaiVQ/gnU0D+QwzmMwIf/aQTS v4lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688832501; x=1691424501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ACDe6d8+qpNHMR+4QPJYvgS6RYLH0JunSRJgsID8OM=; b=UlafEI+qynRHPnkBUZYq2MNqWcPbjyUtytZexD9F0WlkTsq9Vk4JCBbZmtdXx+OPrU srAqc75Tmjmmu4DeDIaewaj9SgGi2yN1AoxUsCPt9IJfdrGcEO3ZXt5UfM0tKQx8r4zE wD7xM7ncKSmm1oOObdWPJeNuHagC2yUeFK26YJMJ3ScgASQqKb5w4ZKeAWSXWhvZwqNM 0pWDwKk3yhpudoj241OY3FCwMLhQgToSIJRl6ZVv9/WmxfkEuEtxDy+HyoFJw24vT14K LdPhQgaqRh/EzH7mm9MGzCxczkGl+2Qh1Yp7tHQhH9/7A8wqQfLNiuBSWvKG82kxBTRE pkkQ== X-Gm-Message-State: ABy/qLbmQmF4+5VRB9ug6k518FVp9GtFoEUsAeskv5wrlBT+yJcwUSk5 uw2Bk2mgJxEINGrF7QPvUmG0VjmtA9K4glJ2Nuw= X-Google-Smtp-Source: APBJJlHvnWJNFT7S1N9KY4/btjpyAZmwhQo06njJ5gVI+LvInQ/qhVL5urR5TDc68LPfCqi5NMJ0GYTIP+gDjYSnb6I= X-Received: by 2002:a17:90b:607:b0:262:fa59:2908 with SMTP id gb7-20020a17090b060700b00262fa592908mr17163857pjb.1.1688832501468; Sat, 08 Jul 2023 09:08:21 -0700 (PDT) MIME-Version: 1.0 References: <cover.1687188729.git.graham@HIDDEN> <87r0ppqrbx.fsf@HIDDEN> <CAA4DTex_Kg_Jhn-z+RHrw2=WcuG3ZxSiOGZE1MtsYpnhCox4tQ@HIDDEN> <87mt0dkkxp.fsf@HIDDEN> In-Reply-To: <87mt0dkkxp.fsf@HIDDEN> From: Graham Addis <grahamjamesaddis@HIDDEN> Date: Sat, 8 Jul 2023 17:08:09 +0100 Message-ID: <CAA4DTexMugyaAxWqZPpiALkVDSApWU63KeaauwvUuk8sG+cQCg@HIDDEN> Subject: Re: [bug#64171] [PATCH 0/1] guix: pack: docker add docker-entry-point options To: Giovanni Biscuolo <g@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64171 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, 64171 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) One last question, as the proposed changes no longer reflect this bug description, should I raise a new bug, or just add the replacement patch to this one? On Mon, 3 Jul 2023 at 17:40, Giovanni Biscuolo <g@HIDDEN> wrote: > > Graham Addis <grahamjamesaddis@HIDDEN> writes: > > > Hi Ludo, > > > > Happy to rework it either way. I can't think of any showstoppers off > > the top of my head. > > > > Which option would make the most sense? > > [...] > > >> Or, perhaps even better, introduce a new =E2=80=98--entry-point-argume= nt=E2=80=99 (or > >> =E2=80=98-A=E2=80=99) option. > > IMO =E2=80=98--entry-point-argument=E2=80=99 is more semantic, its destin= ation is clearer > > [...] > > Thanks a lot for this patch! > > Happy hacking, Gio' > > -- > Giovanni Biscuolo > > Xelera IT Infrastructures
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.Received: (at 64171) by debbugs.gnu.org; 3 Jul 2023 16:40:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 03 12:40:50 2023 Received: from localhost ([127.0.0.1]:34373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qGMbZ-0006he-VK for submit <at> debbugs.gnu.org; Mon, 03 Jul 2023 12:40:50 -0400 Received: from ns13.heimat.it ([46.4.214.66]:40064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <g@HIDDEN>) id 1qGMbT-0006hI-Rl for 64171 <at> debbugs.gnu.org; Mon, 03 Jul 2023 12:40:48 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id E017630081F; Mon, 3 Jul 2023 16:40:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lhiil2CjGExo; Mon, 3 Jul 2023 16:40:35 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id AC6DE30081A; Mon, 3 Jul 2023 16:40:35 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 2FA142789D4C; Mon, 3 Jul 2023 18:40:35 +0200 (CEST) Received: (nullmailer pid 17863 invoked by uid 1000); Mon, 03 Jul 2023 16:40:34 -0000 From: Giovanni Biscuolo <g@HIDDEN> To: Graham Addis <grahamjamesaddis@HIDDEN>, Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= <ludo@HIDDEN> Subject: Re: [bug#64171] [PATCH 0/1] guix: pack: docker add docker-entry-point options In-Reply-To: <CAA4DTex_Kg_Jhn-z+RHrw2=WcuG3ZxSiOGZE1MtsYpnhCox4tQ@HIDDEN> Organization: Xelera.eu References: <cover.1687188729.git.graham@HIDDEN> <87r0ppqrbx.fsf@HIDDEN> <CAA4DTex_Kg_Jhn-z+RHrw2=WcuG3ZxSiOGZE1MtsYpnhCox4tQ@HIDDEN> Date: Mon, 03 Jul 2023 18:40:34 +0200 Message-ID: <87mt0dkkxp.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64171 Cc: 64171 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Graham Addis <grahamjamesaddis@HIDDEN> writes: > Hi Ludo, > > Happy to rework it either way. I can't think of any showstoppers off > the top of my head. > > Which option would make the most sense? [...] >> Or, perhaps even better, introduce a new =E2=80=98--entry-point-argument= =E2=80=99 (or >> =E2=80=98-A=E2=80=99) option. IMO =E2=80=98--entry-point-argument=E2=80=99 is more semantic, its destinat= ion is clearer [...] Thanks a lot for this patch! Happy hacking, Gio' =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmSi+gIMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSW5EP/0Fq6TMzP7cp/wE+OcR4yh8BmM59sxTLXINNp62U dGbw3zyYdkAxiWr3od0cOYIjEMVl+Vg/0xhOVQGZxrGQu/WScYR5aPXG+YAzYEBv jCaLwnLRL5Ef3KXnIUqj40Hou/JaslMhMtqrsXy0gaqXFnzuJ5OEdkywY7bmXtKY 5w32LqrL5wiypOe81PObf90GVTruuYWO03H/MLzYQ+bupF8PZoeNgozJHoVy+T+Y vWz7AStDf5gIE6hF4YzzUcw+W76IFK2I7heARG0SuGGOTtf5o+HFwrDvsrLtHIP+ bGZnvouc1P2jQqcRouS/GiQzQC0aySXFu82Z/2ZT8R7pWxYWip8QTvwi27IMHnHl r/XdmdAckyxqHApYPJvPSKZ+ArGWMTbN3H73yNiGxEsxbqRDYqaoegwMAfkTjAS/ wAhxxxR96Spo9pUv0wg8ecS1DujKr0UbWhRUzEb8khPkS6GWK8uW48Z5stEJ8zt0 7gqHGHfjZ1WwndECNxxLADF5GQ2NJ3Wwe7LlFMjbbtQGJNpVNxBaK7L8ZXDfVt3R 2ACFKl20WeiHQXnXgMfyDpOkz5pq88hvP45WUxl1ggA33HTgA6bZCNwZZ5E26Mjg ORjldyXdEbJxxxSpaF6zl+1ILoATduxblAA++E7CmkfvC9vq8wSVZgQuRxx7fKwl WACp =tpEc -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.Received: (at 64171) by debbugs.gnu.org; 3 Jul 2023 12:44:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 03 08:44:43 2023 Received: from localhost ([127.0.0.1]:33450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qGIv4-0008Tr-OJ for submit <at> debbugs.gnu.org; Mon, 03 Jul 2023 08:44:43 -0400 Received: from mail-pf1-f172.google.com ([209.85.210.172]:55586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <grahamjamesaddis@HIDDEN>) id 1qGIv2-0008Tc-KR for 64171 <at> debbugs.gnu.org; Mon, 03 Jul 2023 08:44:41 -0400 Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-666ecb21f86so3628988b3a.3 for <64171 <at> debbugs.gnu.org>; Mon, 03 Jul 2023 05:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688388274; x=1690980274; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2hj8Y7tkwdhwptga2QsTg2JYaBcqvRh4twEEyRnZCUI=; b=eoAraTKbAn0xugTWJePnQ81JjT3s1Kb9xm8uAMeF6j82PH+yNcgkGdd2ebEpWA/zn7 yc6c1XqmWzqw17jps9yaRW6fl1ZO6UMi21BkMVRr/ytf2cKKuGnvKdvbV8+L4UHtKSHN 3M0Cnrx0nChMK4bCkySMGKuB+fozfed4EDeOk6AR9S5fiE5Ui6xirUok9diDe1KnP39d yWovehtNMiWiSSX4GgSJgRKErm7qtvpgNigjtLCQfYj7ws1UR/Gyo4Mr4/lKU2jqlwlU tXJ+iQZ1lgcfNkpu5MWTk4M5oioDEwawanqBP8hXHQ8VjJTvrT+8L9qGwn86iaBUWFE3 O1vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688388274; x=1690980274; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2hj8Y7tkwdhwptga2QsTg2JYaBcqvRh4twEEyRnZCUI=; b=fiJXvgtPa4Dbu1HFio82G/t1sUlnmPJuNYuTJPdugZ1IIHalkIN+hEa/t9RXgQcTcx MME20obbGyHaqoN2yBBV3ElUqPJEJ4o4ju1zmtSzS6d6UnsZh06vGZ7SaiZgz8Ls3GBd vaJ7bbhl2Z4pFsbRozECKnupJGjPLoxmnCFHLzCSRVL1vAh8EXIU0jQU8X+8VOERuqns 5Nsz9oN8jNhHReICXw3YUOSMWDx6m2vIsIjr+ZPFqVum0Esc+3RPMznC1mtntxiUNtuA 795tOSIK75gFeLKONpjD7qZfpCEm3H9/ZQOmEdo2vMutz2FjNbQH9yY2mLXAm0oCStgg HpKQ== X-Gm-Message-State: AC+VfDx17rKE3FLHl3dXhQxanqJhnzbOECRX0vWNgjJSqrIN3ZueK89E Q45a9Scb3qYhZUCd1lnVhGZLxlM1DiylwULVk9Q= X-Google-Smtp-Source: ACHHUZ7hcMYtrUQpgCnh3EBIylDlGt78jTJyc9GJ7WmIziIBeXzP/Mk0THAQMAE2EiQV4qNOGbXbVtyzeGuFZhuMYsk= X-Received: by 2002:a05:6a20:4cf:b0:126:b174:631 with SMTP id 15-20020a056a2004cf00b00126b1740631mr9587906pzd.30.1688388274244; Mon, 03 Jul 2023 05:44:34 -0700 (PDT) MIME-Version: 1.0 References: <cover.1687188729.git.graham@HIDDEN> <87r0ppqrbx.fsf@HIDDEN> In-Reply-To: <87r0ppqrbx.fsf@HIDDEN> From: Graham Addis <grahamjamesaddis@HIDDEN> Date: Mon, 3 Jul 2023 13:44:21 +0100 Message-ID: <CAA4DTex_Kg_Jhn-z+RHrw2=WcuG3ZxSiOGZE1MtsYpnhCox4tQ@HIDDEN> Subject: Re: bug#64171: [PATCH 0/1] guix: pack: docker add docker-entry-point options To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64171 Cc: Graham James Addis <graham@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Christopher Baines <mail@HIDDEN>, 64171 <at> debbugs.gnu.org, Ricardo Wurmus <rekado@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Ludo, Happy to rework it either way. I can't think of any showstoppers off the top of my head. Which option would make the most sense? Thanks, Graham On Mon, 3 Jul 2023 at 10:26, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote: > > Hi, > > Graham James Addis <grahamjamesaddis@HIDDEN> skribis: > > > This patch adds an option to guix pack to allow multiple parameters to > > be passed to the guix pack --format=3Ddocker command. > > > > Currently the although the --entry-point option can be entered multiple > > times, only the last entry is used as the docker ENTRYPOINT. > > > > Using the new --docker-entry-point option will take multiple entries > > and use them in the docker ENTRYPOINT exec form. > > How about this alternative route: support multiple =E2=80=98--entry-point= =E2=80=99 > arguments. The first one is passed to the backend as #:entry-point (as > is currently the case) and extra instances are passed as a list as > #:entry-point-arguments. > > That way one could do: > > guix pack -f docker guile \ > --entry-point=3Dbin/guile --entry-point=3D--version > > Or, perhaps even better, introduce a new =E2=80=98--entry-point-argument= =E2=80=99 (or > =E2=80=98-A=E2=80=99) option. > > The advantage compared to =E2=80=98--docker-entry-point=E2=80=99 is that = it could be > supported by all the backends. > > WDYT? > > Thanks, > Ludo=E2=80=99.
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.
Received: (at 64171) by debbugs.gnu.org; 3 Jul 2023 09:26:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 03 05:26:31 2023
Received: from localhost ([127.0.0.1]:33151 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qGFpH-0006Hn-CF
for submit <at> debbugs.gnu.org; Mon, 03 Jul 2023 05:26:31 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38894)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1qGFpD-0006HT-8l
for 64171 <at> debbugs.gnu.org; Mon, 03 Jul 2023 05:26:30 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1qGFp5-0005UD-J8; Mon, 03 Jul 2023 05:26:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=hcVwKgpKuLHU+pqnK/KNIBeuS7O4D1IlYOXI+ZUqLiI=; b=Qw2lzM7QNmETQoMHiLQ3
c0qePhb3zL4aOxJ5mYTF96O4GasnOc14K43COGIjMIXM2K36TZHWEEwGNnv4deq2elSkBDnJQOt0F
VD6O0AvoQaHPSZePGBhYGXQAdPdKfeSd7Tv12L+SQca6zfFLBQnYfo448S7gIS6Eegx9/cFRRa90b
s9C4Hr/UaaIWvQjjTVLo5+mqV60hYtDORjurL9/augK5WaREVDmmlqKj6MHeCMR1XUizNXzQJ4xg0
BLoWVZkTLEARQLEiq32ysTAZ1KwlAbjPS8WQ1WZJpXKVajzQh6YnteCo280vZ1VtA+B+fm8mn24Sz
xF6yahQvLUg3Hg==;
Received: from [89.207.171.77] (helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1qGFp2-0004JN-R0; Mon, 03 Jul 2023 05:26:19 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Graham James Addis <grahamjamesaddis@HIDDEN>
Subject: Re: bug#64171: [PATCH 0/1] guix: pack: docker add
docker-entry-point options
References: <cover.1687188729.git.graham@HIDDEN>
Date: Mon, 03 Jul 2023 11:25:54 +0200
In-Reply-To: <cover.1687188729.git.graham@HIDDEN> (Graham James Addis's
message of "Mon, 19 Jun 2023 16:37:59 +0100")
Message-ID: <87r0ppqrbx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 64171
Cc: Graham James Addis <graham@HIDDEN>, Josselin Poiret <dev@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Christopher Baines <mail@HIDDEN>, 64171 <at> debbugs.gnu.org,
Ricardo Wurmus <rekado@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Graham James Addis <grahamjamesaddis@HIDDEN> skribis:
> This patch adds an option to guix pack to allow multiple parameters to
> be passed to the guix pack --format=3Ddocker command.
>
> Currently the although the --entry-point option can be entered multiple
> times, only the last entry is used as the docker ENTRYPOINT.
>
> Using the new --docker-entry-point option will take multiple entries
> and use them in the docker ENTRYPOINT exec form.
How about this alternative route: support multiple =E2=80=98--entry-point=
=E2=80=99
arguments. The first one is passed to the backend as #:entry-point (as
is currently the case) and extra instances are passed as a list as
#:entry-point-arguments.
That way one could do:
guix pack -f docker guile \
--entry-point=3Dbin/guile --entry-point=3D--version
Or, perhaps even better, introduce a new =E2=80=98--entry-point-argument=E2=
=80=99 (or
=E2=80=98-A=E2=80=99) option.
The advantage compared to =E2=80=98--docker-entry-point=E2=80=99 is that it=
could be
supported by all the backends.
WDYT?
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Jun 2023 15:38:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 19 11:38:27 2023 Received: from localhost ([127.0.0.1]:57033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qBGxX-00031A-GH for submit <at> debbugs.gnu.org; Mon, 19 Jun 2023 11:38:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:52722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <grahamjamesaddis@HIDDEN>) id 1qBGxW-000312-LF for submit <at> debbugs.gnu.org; Mon, 19 Jun 2023 11:38:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <grahamjamesaddis@HIDDEN>) id 1qBGxV-0000FN-03 for guix-patches@HIDDEN; Mon, 19 Jun 2023 11:38:25 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <grahamjamesaddis@HIDDEN>) id 1qBGxQ-0007wy-7m for guix-patches@HIDDEN; Mon, 19 Jun 2023 11:38:23 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f9b4a715d9so4090215e9.0 for <guix-patches@HIDDEN>; Mon, 19 Jun 2023 08:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687189096; x=1689781096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FI+hNte4KQ89X9MLPossu7pYNhz0kIRBjR7VmzayIjA=; b=EK2XuRaOmgwMFh/uVWoXSAirLQ/QqFPo6OPZAOYun5H1kH3ksoOj22XYREpDtChEzg 4bgaSXKMoqKwTVfBgLdEy67+YQK+zYGhdddTbI2nuYUEk5cZeiPZQgBbRoifoUvFhu1r L2kKh1g9NNo+qIWAVVZfTJuaWtJMCV2RWhcZ4MaTPAxxsXCs1wECtCmaj8X4v0dEqA5M euP4Xh5JPlT1kWqkzbyJst4HOQgyeBPnKgsJYkcrFrkXgT1o/ZoEcV1lrgUridgGdBZo y8oVYjJvwoEmx7k5kFYkAsnanijYN+5xBS6SgorUIulkf/tATlA/MV/G/BEXozHO5lWZ laUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687189096; x=1689781096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FI+hNte4KQ89X9MLPossu7pYNhz0kIRBjR7VmzayIjA=; b=X3jxT1/QdrZTinKexhDFQRsdJObIzyZE8Qruwmu5Rp+BdocqFyPMf7fcrxiIlL8aWo aKazM3flUdhbdd6jy5438YI/Mm2vNDCv4KdEacB16qDo68kA1UJ4Rbxd0BKGeQnWP0M3 n4QCvfPKA2+vI70PePaAaiFZGVy6aRC5u6/qIO0/5jjWUHLOdy+1a5tzCd62SPouOehA DIKUHkn8ueIPcgn8jL4sHjnNAJaPcM6IH5Kr5lNlwLlZpDsil01S7xZ9FaapM7Tv4nzM ShQAfjcAXojc2+b89/P/XgTTQWdcCvCA/HRBbAHJ6OrvFdCmlsNvDrE841/CU4vMqVXl IpCA== X-Gm-Message-State: AC+VfDzBuGTbVTUb3eiB3DMxcZ40XDd1LLGG+elE7AN8iiAJR8DSl740 A7wEPMn3UhinydNnINNE0FBz4yioh3M= X-Google-Smtp-Source: ACHHUZ4XfSSe5xHyD92K38tcnpXFujM+FLCTlsvCdg6T+eFNvZQbqZmadDPybYEdBun6h4WwsEDAgA== X-Received: by 2002:a05:600c:2942:b0:3f7:e7a2:25f6 with SMTP id n2-20020a05600c294200b003f7e7a225f6mr7790404wmd.17.1687189096197; Mon, 19 Jun 2023 08:38:16 -0700 (PDT) Received: from guix-test.home ([2a00:23c7:59a9:c901:41c8:db68:b8b1:9808]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003f7f249e7dfsm10306432wma.4.2023.06.19.08.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 08:38:15 -0700 (PDT) From: Graham James Addis <grahamjamesaddis@HIDDEN> X-Google-Original-From: Graham James Addis <graham@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH 0/1] guix: pack: docker add docker-entry-point options Date: Mon, 19 Jun 2023 16:37:59 +0100 Message-Id: <cover.1687188729.git.graham@HIDDEN> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines <mail@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN> Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=grahamjamesaddis@HIDDEN; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Graham James Addis <graham@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This patch adds an option to guix pack to allow multiple parameters to be passed to the guix pack --format=docker command. Currently the although the --entry-point option can be entered multiple times, only the last entry is used as the docker ENTRYPOINT. Using the new --docker-entry-point option will take multiple entries and use them in the docker ENTRYPOINT exec form. Using --docker-entry-point will override any setting of --entry-point. The existing behaviour of --entry-point is retained if --docker-entry-point is not specified. Graham James Addis (1): guix: pack: docker add docker-entry-point options doc/guix.texi | 16 +++++- guix/scripts/pack.scm | 113 ++++++++++++++++++++++++++++++++---------- 2 files changed, 103 insertions(+), 26 deletions(-) base-commit: d884fc9e2efecfba09af4694f5a13ad7fc6f704f -- 2.39.2
Graham James Addis <grahamjamesaddis@HIDDEN>:mail@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN.
Full text available.mail@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#64171; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.