GNU bug report logs - #64552
[PATCH] gnu: Add dhex.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: flabbergasted <flabbergasted@HIDDEN>; Keywords: patch moreinfo; dated Mon, 10 Jul 2023 09:26:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Maxim Cournoyer <maxim.cournoyer@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 64552 <at> debbugs.gnu.org:


Received: (at 64552) by debbugs.gnu.org; 5 Sep 2023 14:59:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 10:59:27 2023
Received: from localhost ([127.0.0.1]:57677 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdXWY-0003Ju-Lk
	for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:59:27 -0400
Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:60905)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1qdXWW-0003Ja-BH
 for 64552 <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:59:25 -0400
Received: by mail-qk1-x736.google.com with SMTP id
 af79cd13be357-76df3d8fb4eso153302985a.1
 for <64552 <at> debbugs.gnu.org>; Tue, 05 Sep 2023 07:59:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1693925958; x=1694530758; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:in-reply-to:date:references
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=uI+LccbHRI4dc9211S7s+BFL68cVofgVHbkGQ3EOJi4=;
 b=VoPc2UwRTrY8aaDFTf+921Uix1QTXV8sOoNYfFgkyOzU6Z8c5kxLnzj5qzYh9eGkPO
 h/CVujSNceRsLn5D9hT8v6paBtuZPiQ/wKrrOvObFwym50Y4p0QfBXn8avF71lB6kPZ+
 kjhFzdYauf+DXdqfx1/AJPb3dz99WGJKzbe9tnZ+J95jJVt2gGoxFb3Igj+EPMOajUkB
 vsXobGkM+6W+RlBCOlP20E22F526tZhY4aoVTKmXDiArNCD35txkdG+we3VR5AGeTIR2
 /euGqjPB3werSnjlUa/Aq5Ia60H8gcmMxypYHEe6zmWkOoE7QkCRzPdk9d3mmxwXT0EK
 5agg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1693925958; x=1694530758;
 h=mime-version:user-agent:message-id:in-reply-to:date:references
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=uI+LccbHRI4dc9211S7s+BFL68cVofgVHbkGQ3EOJi4=;
 b=NxANFYJpRBbfdQjhOzAKuUUez45Mmbhl1VjRzSFmxEqStWHKyU1A/wT3MjK/SimacI
 aeyQWB+/W7uhUo8rU0h0C9LKOxGBDQY3bptON+rPWCqkdaGNDDO9QlyB81A8qvbzxJSh
 FQIOUyhVMANxR4RtAkaptM/SwZc6wjbqUZ1yw6ahSl2fhGN7p8buKyCOITzuoJwKPEs5
 h5a7kWmljg0H3NJLQUgOwZbro+p4/SG5o17i4MEiAE2YFnOIp39r9W7naePaJSm8EJHy
 aPvcD0KpMuHOWB8rn8YvtdFI761kXUiYCwTzacyd0Ub6KXKH7CP9P6iaaT5GimtToBgD
 WcGw==
X-Gm-Message-State: AOJu0YzqyAPYkD/p+6ypnEDy7CtYBr+zyPhseU1uABo8ZC1p1hDiqusa
 XsNYZw8h9TfTHXV+IdWL3eLkrelvxg67pQ==
X-Google-Smtp-Source: AGHT+IFdI8yjoq7L4os86FVh1DykrnFfRI6HHa3OtWSBK/cLo+WQuhgeRbCuMcVfrQvxzm3vJupjKg==
X-Received: by 2002:a05:620a:2412:b0:765:a77c:7219 with SMTP id
 d18-20020a05620a241200b00765a77c7219mr16384068qkn.0.1693925957856; 
 Tue, 05 Sep 2023 07:59:17 -0700 (PDT)
Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125])
 by smtp.gmail.com with ESMTPSA id
 i2-20020a37c202000000b007682af2c8aasm4122841qkm.126.2023.09.05.07.59.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 05 Sep 2023 07:59:17 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: flabbergasted <flabbergasted@HIDDEN>
Subject: Re: bug#64552: [PATCH] gnu: Add dhex.
References: <29a2c5263ac72f950491f627b6055ecb675f0068.1688931860.git.flabbergasted@HIDDEN>
Date: Tue, 05 Sep 2023 10:59:16 -0400
In-Reply-To: <29a2c5263ac72f950491f627b6055ecb675f0068.1688931860.git.flabbergasted@HIDDEN>
 (flabbergasted@HIDDEN's message of "Mon, 10 Jul 2023 10:24:20
 +0100")
Message-ID: <87v8cois3f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 64552
Cc: 64552 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

flabbergasted <flabbergasted@HIDDEN> writes:

> * gnu/packages/hexedit.scm (dhex): New variable.
> ---
>  gnu/packages/hexedit.scm | 46 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>
> diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
> index 79c14a2..002f6d0 100644
> --- a/gnu/packages/hexedit.scm
> +++ b/gnu/packages/hexedit.scm
> @@ -29,6 +29,8 @@ (define-module (gnu packages hexedit)
>    #:use-module (gnu packages ncurses)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
> +  #:use-module (guix gexp)
> +  #:use-module (guix utils)
>    #:use-module (guix build-system gnu))
>  
>  (define-public hexedit
> @@ -69,6 +71,50 @@ (define-public hexedit
>      (home-page "http://rigaux.org/hexedit.html")
>      (license license:gpl2+)))
>  
> +(define-public dhex
> +  (package
> +    (name "dhex")
> +    (version "0.69")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://www.dettus.net/dhex/" name "_"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "06y4lrp29f2fh303ijk1xhspa1d4x4dm6hnyw3dd8szi3k6hnwsj"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list
> +      #:tests? #f ;no tests provided
> +      #:make-flags
> +      #~(list (string-append "CC=" #$(cc-for-target)))
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (delete 'configure) ;no configure script
> +          (replace 'install ;multiple issues with provided 'make install'
> +            (lambda _
> +              (let ((bin (string-append #$output "/bin"))
> +                    (man1 (string-append #$output
> +                                         "/share/man/man1"))
> +                    (man5 (string-append #$output
> +                                         "/share/man/man5")))
> +                (mkdir-p bin)
> +                (install-file "dhex" bin)
> +                (mkdir-p man1)
> +                (install-file "dhex.1" man1)
> +                (mkdir-p man5)
> +                (install-file "dhexrc.5" man5)
> +                (install-file "dhex_markers.5" man5)
> +                (install-file "dhex_searchlog.5" man5)))))))

install-file takes care of calling 'mkdir' for you, so you can simplify
the above.

> +    (inputs (list ncurses))
> +    (home-page "https://www.dettus.net/dhex/")
> +    (synopsis "View, edit, and diff files in hexadecimal")
> +    (description
> +     "Dhex is hex editor which includes a diff mode, which can be used to
> +easily and conveniently compare two binary files.  It is based on ncurses
> +and is themeable.")
> +    (license license:gpl2)))

This should be gpl2+, given the text reads:

--8<---------------cut here---------------start------------->8---
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
--8<---------------cut here---------------end--------------->8---

Could you please send a v2 with the above corrections?

-- 
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#64552; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Jul 2023 09:25:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 10 05:25:10 2023
Received: from localhost ([127.0.0.1]:47752 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qIn8n-0007UW-Lr
	for submit <at> debbugs.gnu.org; Mon, 10 Jul 2023 05:25:10 -0400
Received: from lists.gnu.org ([209.51.188.17]:55834)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <flabbergasted@HIDDEN>) id 1qIn8k-0007UK-Bc
 for submit <at> debbugs.gnu.org; Mon, 10 Jul 2023 05:25:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <flabbergasted@HIDDEN>)
 id 1qIn8a-0007zo-6C
 for guix-patches@HIDDEN; Mon, 10 Jul 2023 05:24:58 -0400
Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <flabbergasted@HIDDEN>)
 id 1qIn8U-0000Tl-6B
 for guix-patches@HIDDEN; Mon, 10 Jul 2023 05:24:55 -0400
Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <flabbergasted@HIDDEN>) id 1qIn8L-009sAM-Ba
 for guix-patches@HIDDEN; Mon, 10 Jul 2023 11:24:41 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nofog.net; 
 s=selector1;
 h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; 
 bh=i1ebY0c/1LJCIdprxucfwtCrYoDmLV49ylYbP2CXe40=; b=Vmsf/Hjku5yG+sKMjJclzdTET
 a4OYf6rSSALjM0JbKLe56WOxC5ZQbT607/dgy34+x/aBFypfjJiHWk0WkuV8xXVBuWXgsEynihKTs
 7jDrjt4v0asingfJ2UIvxMnq3/9AsuSHnpfa6KhJpHfztK2z7Gbkw897OjuHHHXZXvwiiptLTYmp6
 7pt6565L/wWjEWfz8dBpkpQ3LBGdgi7PSdhTqi1c2AF2NodshH3W9Kv1VObm2gy+r9+aptsbqn3gI
 M97wD1tkHKdwaRsZ09V+di6wTOmg3WO5i6W5D5uyY9UxLlZ6KKYit5F9iCLCrhlf5MOG/qKFDTvtL
 PrCca5mWw==;
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit03.runbox with esmtp (Exim 4.86_2)
 (envelope-from <flabbergasted@HIDDEN>) id 1qIn8K-0007uX-Ry
 for guix-patches@HIDDEN; Mon, 10 Jul 2023 11:24:41 +0200
Received: by submission03.runbox with esmtpsa [Authenticated ID (1160150)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1qIn85-000500-GA
 for guix-patches@HIDDEN; Mon, 10 Jul 2023 11:24:25 +0200
Date: Mon, 10 Jul 2023 10:24:20 +0100
From: flabbergasted <flabbergasted@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add dhex.
Message-ID: <29a2c5263ac72f950491f627b6055ecb675f0068.1688931860.git.flabbergasted@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Received-SPF: pass client-ip=2a0c:5a00:149::26;
 envelope-from=flabbergasted@HIDDEN; helo=mailtransmit05.runbox.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01,
 T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/hexedit.scm (dhex): New variable.
---
 gnu/packages/hexedit.scm | 46 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
index 79c14a2..002f6d0 100644
--- a/gnu/packages/hexedit.scm
+++ b/gnu/packages/hexedit.scm
@@ -29,6 +29,8 @@ (define-module (gnu packages hexedit)
   #:use-module (gnu packages ncurses)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix gexp)
+  #:use-module (guix utils)
   #:use-module (guix build-system gnu))
 
 (define-public hexedit
@@ -69,6 +71,50 @@ (define-public hexedit
     (home-page "http://rigaux.org/hexedit.html")
     (license license:gpl2+)))
 
+(define-public dhex
+  (package
+    (name "dhex")
+    (version "0.69")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.dettus.net/dhex/" name "_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "06y4lrp29f2fh303ijk1xhspa1d4x4dm6hnyw3dd8szi3k6hnwsj"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests provided
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure) ;no configure script
+          (replace 'install ;multiple issues with provided 'make install'
+            (lambda _
+              (let ((bin (string-append #$output "/bin"))
+                    (man1 (string-append #$output
+                                         "/share/man/man1"))
+                    (man5 (string-append #$output
+                                         "/share/man/man5")))
+                (mkdir-p bin)
+                (install-file "dhex" bin)
+                (mkdir-p man1)
+                (install-file "dhex.1" man1)
+                (mkdir-p man5)
+                (install-file "dhexrc.5" man5)
+                (install-file "dhex_markers.5" man5)
+                (install-file "dhex_searchlog.5" man5)))))))
+    (inputs (list ncurses))
+    (home-page "https://www.dettus.net/dhex/")
+    (synopsis "View, edit, and diff files in hexadecimal")
+    (description
+     "Dhex is hex editor which includes a diff mode, which can be used to
+easily and conveniently compare two binary files.  It is based on ncurses
+and is themeable.")
+    (license license:gpl2)))
+
 (define-public ht
   (package
     (name "ht")

base-commit: f0ca6346a46c605a590bfd77b84e143a8c759a3b
-- 
2.40.1





Acknowledgement sent to flabbergasted <flabbergasted@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#64552; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 5 Sep 2023 15:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.