GNU bug report logs - #65075
[PATCH 01/13] gnu: Add go-github-com-chyzer-logex

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 5 Aug 2023 09:14:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 05 05:14:05 2023
Received: from localhost ([127.0.0.1]:55539 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qSDML-00083I-4t
	for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:14:05 -0400
Received: from lists.gnu.org ([2001:470:142::17]:39168)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@HIDDEN>) id 1qSDMJ-00082L-Qf
 for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:14:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <paren@HIDDEN>) id 1qSDME-0001IS-9z
 for guix-patches@HIDDEN; Sat, 05 Aug 2023 05:13:58 -0400
Received: from knopi.disroot.org ([178.21.23.139])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <paren@HIDDEN>) id 1qSDMC-0002oM-BT
 for guix-patches@HIDDEN; Sat, 05 Aug 2023 05:13:58 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 3689A40615;
 Sat,  5 Aug 2023 11:13:54 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6GGmhLgqY6f9; Sat,  5 Aug 2023 11:13:53 +0200 (CEST)
References: <cover.1691218710.git.fries1234@HIDDEN>
 <2d85819290ef06485588ac5f4ba8a79c69d5e196.1691218710.git.fries1234@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1691226833; bh=lx++YeMhi748HHzszIwdylrd7VQ8yiCzJ/8Cbp0J6NI=;
 h=References:From:To:Cc:Subject:Date:In-reply-to;
 b=O57105fuFnH4ivjfRggL0SyTK4Txs2WUJDxch12BcPZ/F8KyBgOTdHda9yKtY7Zjt
 GVYlHdZjcLatp47vWlKI5PPh6KLMXCLdoMGmf7I6dudrVPmDSPl1sC3UJZ3wFvB6sN
 3Wmb9EZHzw85/orHmhYHeybdYL+q1nDjx1+eOpxLfd/LA13HFepIr+tQjkYW4agqBc
 1wV2u8ojJsb5tNNdXzHeTL+4ZzFprU+/NZJWxWlCQfR5zmM+o3+HNhr4UrK9T4aypO
 U+CGqHjfS9VStVnZdVXm8ubiPEqJH9Emil/xr37BuaEu757D1em1hM3yXYwC3vgbff
 DjS+SvBGTS1dw==
From: "(" <paren@HIDDEN>
To: Fries <fries1234@HIDDEN>
Subject: Re: [bug#65075] [PATCH 01/13] gnu: Add go-github-com-chyzer-logex
Date: Sat, 05 Aug 2023 10:08:50 +0100
In-reply-to: <2d85819290ef06485588ac5f4ba8a79c69d5e196.1691218710.git.fries1234@HIDDEN>
Message-ID: <87y1iprgvn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@HIDDEN;
 helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: 65075 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Hi!

Fries via Guix-patches via <guix-patches@HIDDEN> writes:
> +    (arguments
> +     '(#:import-path "github.com/chzyer/logex"
> +       #:phases (modify-phases %standard-phases
> +                  ;; Tests are completely broken on this package.
> +                  (delete 'check))))

Generally this should look like this now:

  (arguments
   (list #:import-path "github.com/chzyer/logex"
         #:phases
         #~(modify-phases %standard-phases
             (delete 'check))))

Also, generally, you'd use ``#:tests? #f'' rather than
``(delete 'check)'' to disable tests.

> --- /dev/null
> +++ b/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patch

Doesn't this effectively do nothing, since you disabled tests?

  -- (

Message received at 65075 <at> debbugs.gnu.org:

Received: (at 65075) by debbugs.gnu.org; 5 Aug 2023 09:14:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 05 05:14:01 2023
Received: from localhost ([127.0.0.1]:55535 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qSDMG-00082U-Ra
	for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:14:01 -0400
Received: from knopi.disroot.org ([178.21.23.139]:45240)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@HIDDEN>) id 1qSDME-00082E-GA
 for 65075 <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:13:59 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 3689A40615;
 Sat,  5 Aug 2023 11:13:54 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6GGmhLgqY6f9; Sat,  5 Aug 2023 11:13:53 +0200 (CEST)
References: <cover.1691218710.git.fries1234@HIDDEN>
 <2d85819290ef06485588ac5f4ba8a79c69d5e196.1691218710.git.fries1234@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1691226833; bh=lx++YeMhi748HHzszIwdylrd7VQ8yiCzJ/8Cbp0J6NI=;
 h=References:From:To:Cc:Subject:Date:In-reply-to;
 b=O57105fuFnH4ivjfRggL0SyTK4Txs2WUJDxch12BcPZ/F8KyBgOTdHda9yKtY7Zjt
 GVYlHdZjcLatp47vWlKI5PPh6KLMXCLdoMGmf7I6dudrVPmDSPl1sC3UJZ3wFvB6sN
 3Wmb9EZHzw85/orHmhYHeybdYL+q1nDjx1+eOpxLfd/LA13HFepIr+tQjkYW4agqBc
 1wV2u8ojJsb5tNNdXzHeTL+4ZzFprU+/NZJWxWlCQfR5zmM+o3+HNhr4UrK9T4aypO
 U+CGqHjfS9VStVnZdVXm8ubiPEqJH9Emil/xr37BuaEu757D1em1hM3yXYwC3vgbff
 DjS+SvBGTS1dw==
From: "(" <paren@HIDDEN>
To: Fries <fries1234@HIDDEN>
Subject: Re: [bug#65075] [PATCH 01/13] gnu: Add go-github-com-chyzer-logex
Date: Sat, 05 Aug 2023 10:08:50 +0100
In-reply-to: <2d85819290ef06485588ac5f4ba8a79c69d5e196.1691218710.git.fries1234@HIDDEN>
Message-ID: <87y1iprgvn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 65075
Cc: 65075 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi!

Fries via Guix-patches via <guix-patches@HIDDEN> writes:
> +    (arguments
> +     '(#:import-path "github.com/chzyer/logex"
> +       #:phases (modify-phases %standard-phases
> +                  ;; Tests are completely broken on this package.
> +                  (delete 'check))))

Generally this should look like this now:

  (arguments
   (list #:import-path "github.com/chzyer/logex"
         #:phases
         #~(modify-phases %standard-phases
             (delete 'check))))

Also, generally, you'd use ``#:tests? #f'' rather than
``(delete 'check)'' to disable tests.

> --- /dev/null
> +++ b/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patch

Doesn't this effectively do nothing, since you disabled tests?

  -- (

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 5 Aug 2023 08:52:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 05 04:52:53 2023
Received: from localhost ([127.0.0.1]:55468 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qSD1o-0007Hl-RO
	for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 04:52:53 -0400
Received: from lists.gnu.org ([2001:470:142::17]:59418)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fries1234@HIDDEN>) id 1qSBHB-0001r5-Lg
 for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 03:00:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fries1234@HIDDEN>)
 id 1qSBH5-0006Wl-S8
 for guix-patches@HIDDEN; Sat, 05 Aug 2023 03:00:31 -0400
Received: from mail-4324.protonmail.ch ([185.70.43.24])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fries1234@HIDDEN>)
 id 1qSBH3-0004sF-Tp
 for guix-patches@HIDDEN; Sat, 05 Aug 2023 03:00:31 -0400
Date: Sat, 05 Aug 2023 07:00:06 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1691218827; x=1691478027;
 bh=/2I7OEMM2OaeqJgRP99/a4FTlXcb/r4C4qGCuI7PyOQ=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=MPLBdW0i2GWeM0QK89mk4jOcw5EGI5KHpEKXIlZfqxEvgF3Sbnpe/mMMTXHuwbDd6
 hMBg2pjMKmJ7XLjOlKwHaaN6/rIQWUtp/e3KWa3tsVDhVH1L+e2JifWFNfXQNmMks9
 VVmcpjUe59d2rS0TT49Eo16SCP8DFzHBnk1PKx8x+mehONJQDtwU69iZlVT29vfokU
 tmKKjifaRkuRIq3cjFPbRZqlppWUIs4dYml91Ymz54jHFbhP+kbKXYYiZE/3q54SdJ
 7a4WtxQU2WmellSaV8Y1vLpt4mID3f7x0m5RBd9qE57q0CDFkU81rrC04mtgx5cklL
 5kNu9lc+DcOZA==
To: guix-patches@HIDDEN
From: Fries <fries1234@HIDDEN>
Subject: [PATCH 01/13] gnu: Add go-github-com-chyzer-logex
Message-ID: <2d85819290ef06485588ac5f4ba8a79c69d5e196.1691218710.git.fries1234@HIDDEN>
In-Reply-To: <cover.1691218710.git.fries1234@HIDDEN>
References: <cover.1691218710.git.fries1234@HIDDEN>
Feedback-ID: 42759890:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.24;
 envelope-from=fries1234@HIDDEN; helo=mail-4324.protonmail.ch
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001,
 RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: * gnu/packages/golang.scm (go-github-com-chyzer-logex): New
 variable. * gnu/packages/patches/go-github-com-chyzer-logex-fix-tests.patch:
 New file. --- gnu/packages/golang.scm | 28 +++++++++++++++++++ [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (fries1234[at]protonmail.com)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (fries1234[at]protonmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 05 Aug 2023 04:52:39 -0400
Cc: Fries <fries1234@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

* gnu/packages/golang.scm (go-github-com-chyzer-logex): New variable.
* gnu/packages/patches/go-github-com-chyzer-logex-fix-tests.patch: New file=
.
---
 gnu/packages/golang.scm                       | 28 +++++++++++++++++++
 ...go-github-com-chzyer-logex-fix-tests.patch | 28 +++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 gnu/packages/patches/go-github-com-chzyer-logex-fix-tes=
ts.patch

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index ea6aadbe80..d99f76dc7d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -41,6 +41,7 @@
 ;;; Copyright =C2=A9 2022 Christopher Howard <christopher@HIDDEN>
 ;;; Copyright =C2=A9 2023 Hilton Chain <hako@HIDDEN>
 ;;; Copyright =C2=A9 2023 Timo Wilken <guix@HIDDEN>
+;;; Copyright =C2=A9 2023 Fries <fries1234@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2112,6 +2113,33 @@ (define-public go-github-com-dhowett-go-plist
 types.")
       (license license:giftware))))
=20
+(define-public go-github-com-chzyer-logex
+  (package
+    (name "go-github-com-chzyer-logex")
+    (version "1.2.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/chzyer/logex")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0c9yr3r7dl3lcs22cvmh9iknihi9568wzmdywmc2irkjdrn8bpxw"))
+              (patches (search-patches
+                        "go-github-com-chzyer-logex-fix-tests.patch"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/chzyer/logex"
+       #:phases (modify-phases %standard-phases
+                  ;; Tests are completely broken on this package.
+                  (delete 'check))))
+    (home-page "https://github.com/chzyer/logex")
+    (synopsis "Golang log library")
+    (description "A Golang log library that supports tracing and log level=
s
+that works by wrapping the standard log library.")
+    (license license:expat)))
+
 (define-public go-github-com-blanu-dust
   (package
     (name "go-github-com-blanu-dust")
diff --git a/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patc=
h b/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patch
new file mode 100644
index 0000000000..2a9b7a228b
--- /dev/null
+++ b/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patch
@@ -0,0 +1,28 @@
+From bb4921ff5ab77a047ae46d3da0f35abbe3f01f41 Mon Sep 17 00:00:00 2001
+From: Fries <fries1234@HIDDEN>
+Date: Fri, 4 Aug 2023 20:06:20 -0700
+Subject: [PATCH] fix logex tests
+
+---
+ logex_test.go | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/logex_test.go b/logex_test.go
+index e6027f2..4c07d45 100644
+--- a/logex_test.go
++++ b/logex_test.go
+@@ -46,9 +46,9 @@ func TestLogex(t *testing.T) {
+=20
+ =09except :=3D []string{
+ =09=09".test:logex_test.go:19]aa",
+-=09=09".test:logex_test.go:20][INFO] b",
++=09=09".TestLogex:logex_test.go:42][INFO] b",
+ =09=09".test:logex_test.go:21][INFO] c",
+-=09=09".test:logex_test.go:22][ERROR] ec",
++=09=09".TestLogex:logex_test.go:42][ERROR] ec",
+ =09=09".(*S).hello:logex_test.go:11][WARN] warn in hello",
+ =09}
+=20
+--=20
+2.41.0
+
--=20
2.41.0