GNU logs - #65097, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: cage <cage-dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 05 Aug 2023 13:47:01 +0000
Resent-Message-ID: <handler.65097.B.169124318226473 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 65097 <at> debbugs.gnu.org
Date: Sat, 5 Aug 2023 15:45:53 +0200
From: cage <cage-dev@HIDDEN>
Message-ID: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Received-SPF: none client-ip=62.149.158.132;
 envelope-from=cage-dev@HIDDEN; helo=smtpcmd04132.aruba.it
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi!

Note that this patch suffers for some problems:

- the package will skips the test (it complains "tk" can not be found");

- the manpages will not be installed as make installs exit with an error code because the script 'dtplite' can not be found (seems a TCL script according to README);

- the license seems X11 to me, but i am unsure (see the last paragraph in the file: "license.terms".

Any suggestion to improve the patch is appreciated! :)

Bye!
C.

---
 gnu/packages/tcl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm
index b69dba2254..5bfcc63f96 100644
--- a/gnu/packages/tcl.scm
+++ b/gnu/packages/tcl.scm
@@ -509,3 +509,43 @@ (define-public go-github.com-nsf-gothic
     (description "Gothic contains Go bindings for Tcl/Tk.  The package contains
 only one type and one function that can be used to create a Tk interpreter.")
     (license license:expat))))
+
+
+
+(define-public tk-img
+  (package
+    (name "tk-img")
+    (version "1.4.14")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/tkimg/tkimg/1.4/tkimg%20"
+             version
+             "/Img-" version "-Source.tar.gz"))
+       (file-name (string-append "tkimg-" version ".tar.gz"))
+       (sha256
+        (base32 "08dvb8bfkxr919wp6fq14cfb9lz1v59jx1la4a6j4ks636wb243m"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (invoke "make" "install-libraries"))))
+           #:configure-flags
+           #~(list
+              (string-append "--exec-prefix=" #$output)
+              (string-append "--with-tcl="
+                             (assoc-ref %build-inputs "tcl") "/lib")
+              (string-append "--with-tk="
+                             (assoc-ref %build-inputs "tk") "/lib"))))
+    (native-inputs
+     (list tcl
+           tk))
+    (home-page "https://sourceforge.net/projects/tkimg/")
+    (synopsis "The Img package adds several image formats to Tcl/Tk.")
+    (description
+     "The Img package adds several image formats to Tcl/Tk.")
+    (license license:public-domain)))

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
--
2.34.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: cage <cage-dev@HIDDEN>
Subject: bug#65097: Acknowledgement ([PATCH] gnu: Add tk-img.)
Message-ID: <handler.65097.B.169124318226473.ack <at> debbugs.gnu.org>
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
X-Gnu-PR-Message: ack 65097
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 65097 <at> debbugs.gnu.org
Date: Sat, 05 Aug 2023 13:47:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 65097 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
65097: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65097
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 05 Sep 2023 14:22:01 +0000
Resent-Message-ID: <handler.65097.B65097.16939236998312 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: cage <cage-dev@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
Date: Tue, 05 Sep 2023 10:21:26 -0400
In-Reply-To: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
 (cage's message of "Sat, 5 Aug 2023 15:45:53 +0200")
Message-ID: <87msy0k8ex.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi!

cage <cage-dev@HIDDEN> writes:

> Hi!
>
> Note that this patch suffers for some problems:
>
> - the package will skips the test (it complains "tk" can not be found");

It'd be best to say so in the package, with a XXX comment (meaning
subpar/hackish/dirty) like:

#:tests #f   ;tests fails with "tk" can not be found error

> - the manpages will not be installed as make installs exit with an error code because the script 'dtplite' can not be found (seems a TCL script according to README);
>
> - the license seems X11 to me, but i am unsure (see the last paragraph in the file: "license.terms".
>
> Any suggestion to improve the patch is appreciated! :)
>
> Bye!
> C.
>
> ---
>  gnu/packages/tcl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm
> index b69dba2254..5bfcc63f96 100644
> --- a/gnu/packages/tcl.scm
> +++ b/gnu/packages/tcl.scm
> @@ -509,3 +509,43 @@ (define-public go-github.com-nsf-gothic
>      (description "Gothic contains Go bindings for Tcl/Tk.  The package contains
>  only one type and one function that can be used to create a Tk interpreter.")
>      (license license:expat))))
> +
> +
> +
> +(define-public tk-img
> +  (package
> +    (name "tk-img")
> +    (version "1.4.14")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://sourceforge/tkimg/tkimg/1.4/tkimg%20"
> +             version
> +             "/Img-" version "-Source.tar.gz"))
> +       (file-name (string-append "tkimg-" version ".tar.gz"))
> +       (sha256
> +        (base32 "08dvb8bfkxr919wp6fq14cfb9lz1v59jx1la4a6j4ks636wb243m"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f
> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (replace 'install
> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (invoke "make" "install-libraries"))))
> +           #:configure-flags
> +           #~(list
> +              (string-append "--exec-prefix=" #$output)
> +              (string-append "--with-tcl="
> +                             (assoc-ref %build-inputs "tcl") "/lib")
> +              (string-append "--with-tk="
> +                             (assoc-ref %build-inputs "tk") "/lib"))))
> +    (native-inputs
> +     (list tcl
> +           tk))

I'd format on a single line since there are less than 5 dependencies
(that's what 'guix style' does).

> +    (home-page "https://sourceforge.net/projects/tkimg/")
> +    (synopsis "The Img package adds several image formats to Tcl/Tk.")

Synopsis shouldn't be complete sentence but just a very terse expression
saying what the package *is*, e.g. "Image library for Tcl/Tk".  Debian
uses "Extended image format support for Tcl/Tk".

> +    (description
> +     "The Img package adds several image formats to Tcl/Tk.")

Description should be more generous; here I'd enumerate the specific
image formats it adds.  Debian uses:

--8<---------------cut here---------------start------------->8---
 Img is a package to enhance Tk by providing support for various image
 formats such as XPM, GIF (transparency supported, but not LZW), PNG,
 JPEG, TIFF, and PostScript.
--8<---------------cut here---------------end--------------->8---

It lacks some according to the home page [0]:

BMP, GIF, ICO, JPEG, PCX, PNG, PPM, PS, SGI, SUN, TGA, TIFF, XBM, XPM

[0]  https://sourceforge.net/projects/tkimg/

> +    (license license:public-domain)))

According to Debian's copyright file (which can be found in
http://deb.debian.org/debian/pool/main/libt/libtk-img/libtk-img_1.4.14+dfsg.orig.tar.xz),
the licenses used is a mix of the tcl license and public-domain.  I'd
use (license (list license:tcl/tk
                   license:public-domain))

Reading the last paragraph of license.terms:

--8<---------------cut here---------------start------------->8---
GOVERNMENT USE: If you are acquiring this software on behalf of the
U.S. government, the Government shall have only "Restricted Rights"
in the software and related documentation as defined in the Federal
Acquisition Regulations (FARs) in Clause 52.227.19 (c) (2).  If you
are acquiring the software on behalf of the Department of Defense, the
software shall be classified as "Commercial Computer Software" and the
Government shall have only "Restricted Rights" as defined in Clause
252.227-7013 (b) (3) of DFARs.  Notwithstanding the foregoing, the
authors grant the U.S. Government and others acting in its behalf
permission to use and distribute the software in accordance with the
terms specified in this license.
--8<---------------cut here---------------end--------------->8---

I'm not too sure what that really means, even after reading the clauses
[1, 2].

[1]  https://www.acquisition.gov/far/52.227-19#FAR_52_227_19__d3451e77
[2]  https://www.acquisition.gov/dfars/252.227-7013-rights-technical-data%E2%80%94other-commercial-products-and-commercial-services.

Although, taking it from a high level, it seems like it implies
additional restrictions for the US government, which is incompatible
with the free software and thus, the FSDG, which means we cannot
distribute this package.

I'd be happy to proven wrong, I am not a lawyer.

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 05 Sep 2023 14:23:01 +0000
Resent-Message-ID: <handler.65097.B65097.16939237498414 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: cage <cage-dev@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
Date: Tue, 05 Sep 2023 10:22:18 -0400
In-Reply-To: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
 (cage's message of "Sat, 5 Aug 2023 15:45:53 +0200")
Message-ID: <87il8ok8dh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi again,

cage <cage-dev@HIDDEN> writes:

> Hi!
>
> Note that this patch suffers for some problems:
>
> - the package will skips the test (it complains "tk" can not be found");
>
> - the manpages will not be installed as make installs exit with an error code because the script 'dtplite' can not be found (seems a TCL script according to README);
>
> - the license seems X11 to me, but i am unsure (see the last paragraph in the file: "license.terms".
>
> Any suggestion to improve the patch is appreciated! :)

One last thing, the source of tk-img carries many 'contrib' sources;
they should be removed in a snippet to ensure only Guix-provided system
libraries are used instead.

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 05 Sep 2023 14:44:01 +0000
Resent-Message-ID: <handler.65097.B65097.169392500610656 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65097
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: cage <cage-dev@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org
Received: via spool by 65097-submit <at> debbugs.gnu.org id=B65097.169392500610656
          (code B ref 65097); Tue, 05 Sep 2023 14:44:01 +0000
Received: (at 65097) by debbugs.gnu.org; 5 Sep 2023 14:43:26 +0000
Received: from localhost ([127.0.0.1]:57616 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdXH3-0002ln-Sa
	for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:43:26 -0400
Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:53695)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1qdXH0-0002lV-WF
 for 65097 <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:43:24 -0400
Received: by mail-qk1-x729.google.com with SMTP id
 af79cd13be357-76f2843260bso161153585a.3
 for <65097 <at> debbugs.gnu.org>; Tue, 05 Sep 2023 07:43:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1693924996; x=1694529796; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:in-reply-to:date:references
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=EVAHYk9z5kiQYZmviu/J1l+SES2PYi/m29eZ9Q7a6SU=;
 b=CGEOyO4y/30FE+jRs33lpYUlma5VmxG39xX2MZctbtoC5V2JbiDw/EyNrTwdqye2ct
 PD07V0XowbGxrA0DYnk+UzNhp1KoKbH+4SfARDffzVlos0p0TWozje0FMiajDrxbzhq1
 RL83KuOLCJDj5VMj9C5pg/VbwbgUrwOraaCzJluwzj023NapTkUo6v2NDXVBKkcrVpJW
 x144FwRO0auVhMwMYXTj+eQFZOnVCYxn/Y/7y2rMhdZnB+sQ80SLD/T84KhW+vn6LtK1
 yhMM5hJpSwLbKkTtaCvzzBi+VumiwDKqSDaQwTR+5P40V0YagumXbI+8O0zh+3QpFvpx
 Kvfw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1693924996; x=1694529796;
 h=mime-version:user-agent:message-id:in-reply-to:date:references
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=EVAHYk9z5kiQYZmviu/J1l+SES2PYi/m29eZ9Q7a6SU=;
 b=JjIan3ia7SSeYXCFR/yDwvtP918gw/l1pjJ/O1GKWTfuPSoDEttr+9nQ3Vp6pUYRIS
 mp1p8CdnGmJBf5GyKXbDCTxp0ifH740gYieYdbSjb+pN4bg75rMKdGMY1GwbgC3S31RA
 FFMkJZ7VZ0GyziVcY/0vsyBIvFbaAhit6FEyq2m8DwK+ZR1DtsoXoEGkppDiW8yWMG8e
 T4nrHEJv5A80B77sFTQxkT/23GpdaxgHt+gpfiNpiEaz62dQFw4i7lVSFnivbcTzgyJc
 Meo3mDHrAyAn/4s8AOaaqSefLdPIQNeXhaeNfJGlQbIjxaPpVLBK0V4k4Z34oFxaSxKe
 ZLfw==
X-Gm-Message-State: AOJu0YwRUavnpUO+6mAqyyEkSQqSDJXn1TcTrwm4U0iDCGre5IW3dZp2
 eoiNPFqZi81KmRa3JNEmXE8D0lnMkQ6OxA==
X-Google-Smtp-Source: AGHT+IGAWHOyOTvbkvQj6msCZPK+NOQXNQEe/jGbfLcG7KcgxZosiUG2XdftbVCAvugHG5zhcH/aRg==
X-Received: by 2002:a05:620a:4316:b0:76f:2038:2ae8 with SMTP id
 u22-20020a05620a431600b0076f20382ae8mr15230605qko.55.1693924996415; 
 Tue, 05 Sep 2023 07:43:16 -0700 (PDT)
Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125])
 by smtp.gmail.com with ESMTPSA id
 m12-20020ae9e00c000000b007684220a08csm4118116qkk.70.2023.09.05.07.43.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 05 Sep 2023 07:43:15 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
 <87msy0k8ex.fsf@HIDDEN>
Date: Tue, 05 Sep 2023 10:43:14 -0400
In-Reply-To: <87msy0k8ex.fsf@HIDDEN> (Maxim Cournoyer's message of "Tue, 05
 Sep 2023 10:21:26 -0400")
Message-ID: <877cp4k7el.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

[...]

> Reading the last paragraph of license.terms:
>
> GOVERNMENT USE: If you are acquiring this software on behalf of the
> U.S. government, the Government shall have only "Restricted Rights"
> in the software and related documentation as defined in the Federal
> Acquisition Regulations (FARs) in Clause 52.227.19 (c) (2).  If you
> are acquiring the software on behalf of the Department of Defense, the
> software shall be classified as "Commercial Computer Software" and the
> Government shall have only "Restricted Rights" as defined in Clause
> 252.227-7013 (b) (3) of DFARs.  Notwithstanding the foregoing, the
> authors grant the U.S. Government and others acting in its behalf
> permission to use and distribute the software in accordance with the
> terms specified in this license.
>
> I'm not too sure what that really means, even after reading the clauses
> [1, 2].
>
> [1]  https://www.acquisition.gov/far/52.227-19#FAR_52_227_19__d3451e77
> [2]
> https://www.acquisition.gov/dfars/252.227-7013-rights-technical-data%E2%80%94other-commercial-products-and-commercial-services.

That's probably fine actually, given that's the same license text as the
license.terms found in the tcl/tk project itself.

I'd use just (license license:tcl/tk) then.

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: cage <cage-dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 05 Sep 2023 17:12:02 +0000
Resent-Message-ID: <handler.65097.B65097.169393388815235 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65097
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org, cage <cage-dev@HIDDEN>
Received: via spool by 65097-submit <at> debbugs.gnu.org id=B65097.169393388815235
          (code B ref 65097); Tue, 05 Sep 2023 17:12:02 +0000
Received: (at 65097) by debbugs.gnu.org; 5 Sep 2023 17:11:28 +0000
Received: from localhost ([127.0.0.1]:58808 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdZaK-0003xf-7A
	for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 13:11:28 -0400
Received: from smtpcmd02101.aruba.it ([62.149.158.101]:38785)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cage-dev@HIDDEN>) id 1qdZaH-0003xP-25
 for 65097 <at> debbugs.gnu.org; Tue, 05 Sep 2023 13:11:26 -0400
Received: from shimizu.casa.net ([84.220.229.183])
 by Aruba Outgoing Smtp  with ESMTPSA
 id dZa8q2jsDxg8EdZa8qxXX9; Tue, 05 Sep 2023 19:11:16 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1;
 t=1693933876; bh=vpeNlCB1uVMDUpk6URIJfEwVDXkribr23Pf0r7PMlI0=;
 h=Date:From:To:Subject:MIME-Version:Content-Type;
 b=Z0Uhe6ctrqRq5Jk8lr4lOuJHCLgBS6IOzFYlDFv6z/WVMk7ALV6q9dEdYfGMsxn9W
 9CvtNQFJdbrxGIX4u8fJ6hhDUz9IZ5qEDS0NB2/P3KNVTjbyO/JeiyuhuMdGEQTqiZ
 Clzwl/HKgnOfLimmpSYEzWMcMFrP93JIo7rjLx7ENunBZy8TVHlZY0GtwhV5LqeLgt
 TgxCideh/D6y9D1GmbSFujGbF0Eg/n82y6izErvex+NQEoyzAAsEY3FVtZy9g5TgGy
 1Pe97gfXXvFISPCigjwdLR7HIGhcPwFwTNrwJOcs8JwklHfEa1/Hdy0EfoqCqjiKhn
 ZqakX7Q2H3s3A==
Received: by shimizu.casa.net (Postfix, from userid 1000)
 id 56207DA053A; Tue,  5 Sep 2023 19:11:05 +0200 (CEST)
Date: Tue, 5 Sep 2023 19:11:05 +0200
From: cage <cage-dev@HIDDEN>
Message-ID: <ZPdhKeY/wJgF6/Gi@HIDDEN>
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
 <87msy0k8ex.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87msy0k8ex.fsf@HIDDEN>
X-CMAE-Envelope: MS4xfBNpp9GTRXCTkjxO0nhyMDnQcb5O4UuIUIHN/kjSSktaOcnreknCyVhVxhcre5h/fTwqYeY1KMWoZDrFPBO4t80vKjaYOmrSz5aC/41BFb0NyRae6bwH
 OpkRxiNSru+I22pCd/h3Cf4cxTeQuvbiJJD7jIjGK5ZPaca4J7/FZEEjnEY1SPkOM/gyL4Cc71khlKrQg8A6W6RJlGeZCmlu8JffKVm/HIbr1IGluG9I/KGD
 MnvuAfKSf4Dy1GjTyyT2czovxojYMpKeh0qVAkbcgGo=
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Tue, Sep 05, 2023 at 10:21:26AM -0400, you wrote:
> Hi!

Hi!

[…]

Thank you very much for your accurate review of this patch!

I am going to address the  issues you highlighted in your messages and
updating the patch.

I have just a question:

> > the package will skips the test (it complains "tk" can not be found");

> It'd be best to say so in the package, with a XXX comment (meaning
> subpar/hackish/dirty) like:
>
> #:tests #f   ;tests fails with "tk" can not be found error

I am  OK with this change  but I would  rather prefer to not  skip the
tests, if possible; do you have any suggestions about making the build
environment find the tk executable?

Thanks again for your help!
C.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
In-Reply-To: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@HIDDEN>
Resent-From: cage <cage-dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 06 Sep 2023 14:08:01 +0000
Resent-Message-ID: <handler.65097.B65097.169400924612662 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65097
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 65097 <at> debbugs.gnu.org
Cc: maxim.cournoyer@HIDDEN
Received: via spool by 65097-submit <at> debbugs.gnu.org id=B65097.169400924612662
          (code B ref 65097); Wed, 06 Sep 2023 14:08:01 +0000
Received: (at 65097) by debbugs.gnu.org; 6 Sep 2023 14:07:26 +0000
Received: from localhost ([127.0.0.1]:37061 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdtBm-0003IA-0R
	for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 10:07:26 -0400
Received: from smtpcmd03117.aruba.it ([62.149.158.117]:53317)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cage-dev@HIDDEN>) id 1qdtBi-0003Hm-60
 for 65097 <at> debbugs.gnu.org; Wed, 06 Sep 2023 10:07:24 -0400
Received: from shimizu.casa.net ([94.34.23.103])
 by Aruba Outgoing Smtp  with ESMTPSA
 id dtBZqnp7SqAKqdtBZqZ4u1; Wed, 06 Sep 2023 16:07:14 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1;
 t=1694009234; bh=Q0INMPCJuEXkEsDg55z/AEDYCze0XVHIi0y1j+9tMI8=;
 h=Date:From:To:Subject:MIME-Version:Content-Type;
 b=m/fAKerfSa0ts00lqksVybRoBP4Sb2ZGaS2yX/306BLR8G3X3JYgWWX+csw6jLCoV
 Jtw2XVNaLhIIg2iLItzD+dBgtjicWirskSsre+Byyy15O8K6RYq7Xslp82j1nkPoXy
 E5oDQCc+x+SJza9UsZSwDUcOFcFRhDwq/lhLsmLlrE1E663hYsLwxyEVsYGASxZ15n
 MQbl00or9b4g0CO0pTmRzyZgKJMuzozPM/qBU4j6NFyw+M+ySSwuHV2NcIxCEhr2Gr
 DO9bCcL21MCufqiczxtO1nnFyLq2yAZh+GXcifsFyLCwKBYfUw/lEMkAlRMOCnMJhz
 uLyBiBrPrm06g==
Received: by shimizu.casa.net (Postfix, from userid 1000)
 id 4DF5FDA05C8; Wed,  6 Sep 2023 16:06:59 +0200 (CEST)
Date: Wed, 6 Sep 2023 16:06:59 +0200
From: cage <cage-dev@HIDDEN>
Message-ID: <2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope: MS4xfBmFoFjIv1Mj8z4JIIHf7Gctng7kxjOeNJ5GDXQ70R3XHL8elVRH1ioFI9PfwN2VLdy5EwT0I89CZjQ4yEiw7ZYR2x9vvqofiGIcn136Q7UfpJJ2WI+S
 b1Wmquuzl5Q4qcsBi6Lyu25+AyeXxou3IHeV0+Srz/rwLBCPAYiZHDW6sCgxCbL/7QQJlEtn3pf/Cuw4poNUgc9zQ7uhX3qcQHAmZMRqRpn1n8dk5FKygV3p
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi!

With this patch I tried to address all the issues that was pointed out
(hope they are fine :)) except one:

> One last thing, the source of tk-img carries many 'contrib' sources;
> they should be removed in a snippet to ensure only Guix-provided system
> libraries are used instead.

Because I was not able to find out the contribs sources.

Also, for the record, the problem with  tests is not that the Tk (as I
erroneously thought)  executable can not  be found but that,  for some
reasons, the tcl script seems to fails to resolve Tk as dependency:

$ tclsh

% package require Tk → raise an error

the same line works on my other system (Debian)

Bye!
C.

---
 gnu/packages/tcl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm
index b69dba2254..22602c177a 100644
--- a/gnu/packages/tcl.scm
+++ b/gnu/packages/tcl.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tcl)
   #:use-module (gnu packages)
   #:use-module (gnu packages image)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
@@ -509,3 +510,42 @@ (define-public go-github.com-nsf-gothic
     (description "Gothic contains Go bindings for Tcl/Tk.  The package contains
 only one type and one function that can be used to create a Tk interpreter.")
     (license license:expat))))
+
+(define-public tk-img
+  (package
+    (name "tk-img")
+    (version "1.4.14")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/tkimg/tkimg/1.4/tkimg%20"
+             version
+             "/Img-" version "-Source.tar.gz"))
+       (file-name (string-append "tkimg-" version ".tar.gz"))
+       (sha256
+        (base32 "08dvb8bfkxr919wp6fq14cfb9lz1v59jx1la4a6j4ks636wb243m"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f ; tests fails because the tcl shell can not find Tk ("package require Tk" fails)
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (invoke "make" "install-libraries"))))
+           #:configure-flags
+           #~(list
+              (string-append "--exec-prefix=" #$output)
+              (string-append "--with-tcl="
+                             (assoc-ref %build-inputs "tcl") "/lib")
+              (string-append "--with-tk="
+                             (assoc-ref %build-inputs "tk") "/lib"))))
+    (native-inputs
+     (list tcl tk ghostscript))
+    (home-page "https://sourceforge.net/projects/tkimg/")
+    (synopsis "Increase the number bitmap file formats supported by TK.")
+    (description
+     "The Img package adds supports for several image formats to TCl/TK; notably JPEG, ICO, BMP, TGA and PostScript (using an external PostScript interpreter).")
+    (license (license:non-copyleft
+              "file://license.terms"
+              "See license.terms in the distribution."))))

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
--
2.34.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 06 Sep 2023 16:08:02 +0000
Resent-Message-ID: <handler.65097.B65097.169401642223509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65097
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: cage <cage-dev@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org
Received: via spool by 65097-submit <at> debbugs.gnu.org id=B65097.169401642223509
          (code B ref 65097); Wed, 06 Sep 2023 16:08:02 +0000
Received: (at 65097) by debbugs.gnu.org; 6 Sep 2023 16:07:02 +0000
Received: from localhost ([127.0.0.1]:37209 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdv3V-00066p-Ad
	for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 12:07:02 -0400
Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:60538)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1qdv3P-00066T-UB
 for 65097 <at> debbugs.gnu.org; Wed, 06 Sep 2023 12:07:00 -0400
Received: by mail-qk1-x732.google.com with SMTP id
 af79cd13be357-76dbd877cd9so1063885a.0
 for <65097 <at> debbugs.gnu.org>; Wed, 06 Sep 2023 09:06:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1694016408; x=1694621208; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=bCcI6fswr+6PmG2x1mxZgzza1i37XBD5ZibyWafS624=;
 b=e6OXXkC5/U2iT/UfYe9v3FXivpEgKNC+UF+fccd0a9AN1DWJc/GHDqzp6Jvbl2HNWr
 FAhp3IL1S2yT8kSt/QfiHTumGD/Y/X5jJv3mwc6R0zXCdKjl8dq938JaQ0f14SL5X73G
 1mU+E9sJ+Oow5KvArzuHjwOPDx9BQUps4quoktxIe5/+Sjbxymfact9IRMYpP/4Wa4bb
 9fk74j7bilKdTERZopkkfIoPUxMv6XFltgTLzdRA/bRyF0otMGw9xYSQmBmCjkIZUPCT
 Tg4boB9lnrUZPOeCI3KtMJ5ADI4a1MyptocY4n8FEvEKV6sfP2UwFArl2PFgroYvvsyF
 fEQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1694016408; x=1694621208;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=bCcI6fswr+6PmG2x1mxZgzza1i37XBD5ZibyWafS624=;
 b=Oh9uvAGHvBfBd3dauz+3aK8VQfoV/F3wLrttAILFfdNFVXeSSgmfuo2x/hOetShiAE
 C/93Sh5gMLIoy8sSpptfFnIpEfpsk4Mvldsjx3WvOvZVm7c8hHv7J98FtWuoIXjSOR58
 r4gk+QrsVCgHvU/Bp80LWFStbdf51m87ip4O7THJSQDtNrcdz8+muoBPlSzPezSNXDoU
 U8Ip4IycC77S5387eGUPtB9m4T3xHw3b3Gu7GAGlq3hiIgV4V+NS4AWRVPkWxm6Q3uft
 FyAo1JcFSnvbxuY4837ZAD8S1I7XxH01AWsYchx4fe6CupnOQ0q7/2WIqMnXwk+F7eS7
 lB2A==
X-Gm-Message-State: AOJu0YwztgTJ+tvg7uBaXr2JMj9yOz5zmgiotCJyGDTBB8txrjKrg+Kl
 ou0XsglMFhk0KwMOXKeM2U45NQBNTY4TBA==
X-Google-Smtp-Source: AGHT+IF35Yupm33sF7B7pquvz0OZnhMyQOgSwx9T1/OpkHt4NG3ngWf2+6FblfnG2Rb5HOzkobD0Ww==
X-Received: by 2002:a05:620a:2801:b0:765:ada8:e938 with SMTP id
 f1-20020a05620a280100b00765ada8e938mr20587037qkp.22.1694016408402; 
 Wed, 06 Sep 2023 09:06:48 -0700 (PDT)
Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125])
 by smtp.gmail.com with ESMTPSA id
 j26-20020a05620a001a00b0076d6a08ac98sm5036588qki.76.2023.09.06.09.06.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 06 Sep 2023 09:06:48 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@HIDDEN>
Date: Wed, 06 Sep 2023 12:06:46 -0400
In-Reply-To: <2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@HIDDEN>
 (cage's message of "Wed, 6 Sep 2023 16:06:59 +0200")
Message-ID: <87il8n5lrd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi!

cage <cage-dev@HIDDEN> writes:

> Hi!
>
> With this patch I tried to address all the issues that was pointed out
> (hope they are fine :)) except one:
>
>> One last thing, the source of tk-img carries many 'contrib' sources;
>> they should be removed in a snippet to ensure only Guix-provided system
>> libraries are used instead.
>
> Because I was not able to find out the contribs sources.

(assuming the source is a gzipped tarball)

If you './pre-inst-env guix build --source tk-img', then unpack it to
/tmp with 'tar xf /gnu/store...-cage.tar.gz -C /tmp', you should then be
able to look at what it contains, e.g.

find /tmp/cage-x.y.z/ -name '*contrib*'

> Also, for the record, the problem with  tests is not that the Tk (as I
> erroneously thought)  executable can not  be found but that,  for some
> reasons, the tcl script seems to fails to resolve Tk as dependency:
>
> $ tclsh
>
> % package require Tk =E2=86=92 raise an error

Oh!  So it seems we have a bigger problem to resolve first :-)

Thanks for your investigations.

--=20
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Resent-From: cage <cage-dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 06 Sep 2023 17:43:02 +0000
Resent-Message-ID: <handler.65097.B65097.1694022175650 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65097
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 65097 <at> debbugs.gnu.org, cage <cage-dev@HIDDEN>
Received: via spool by 65097-submit <at> debbugs.gnu.org id=B65097.1694022175650
          (code B ref 65097); Wed, 06 Sep 2023 17:43:02 +0000
Received: (at 65097) by debbugs.gnu.org; 6 Sep 2023 17:42:55 +0000
Received: from localhost ([127.0.0.1]:37540 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdwYI-0000AQ-SE
	for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 13:42:55 -0400
Received: from smtpcmd03117.aruba.it ([62.149.158.117]:45661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cage-dev@HIDDEN>) id 1qdwYF-0000AC-RX
 for 65097 <at> debbugs.gnu.org; Wed, 06 Sep 2023 13:42:52 -0400
Received: from shimizu.casa.net ([94.34.23.103])
 by Aruba Outgoing Smtp  with ESMTPSA
 id dwY7qqUMKqAKqdwY7qao1v; Wed, 06 Sep 2023 19:42:44 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1;
 t=1694022164; bh=3ZrYOgKiH5Shn4MNZhX/KYgrwyR5wkOYfA4EDBQUTo0=;
 h=Date:From:To:Subject:MIME-Version:Content-Type;
 b=YLbic+1AXQQOwwTrWqR3NQIQNleNO6tPXfcq0UoGncClYCyK+thSPljSutQeFwo4T
 uinAxeW+qfp9WoNQ4vjp2ffXtwa5kSCUh8OY4B7kU32hsCrFAec1k9+WU2fj/3YijP
 dlB8dqR0RxkxiM5jIZBUisnaV750Wz2aJqqLlObAjFBQxrdul08b4f1vh7VD3pwyV+
 nnQuD+m3RDUuqLsfEiX04ABLUSxCjj1JevQDp+oIIcTEZZ3Bqn1mkXWVTBRRWQijDO
 G9wWn9iIrh69rWjgyBle3rcYuP1g19PPqvrTJOGeuhfh2KIp5vC3Ca1LeJe4ogTLhu
 gDDFficqcG9+A==
Received: by shimizu.casa.net (Postfix, from userid 1000)
 id 08500DA05C8; Wed,  6 Sep 2023 19:42:33 +0200 (CEST)
Date: Wed, 6 Sep 2023 19:42:33 +0200
From: cage <cage-dev@HIDDEN>
Message-ID: <ZPi6CUwSeQv8LPa2@HIDDEN>
References: <2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@HIDDEN>
 <87il8n5lrd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87il8n5lrd.fsf@HIDDEN>
X-CMAE-Envelope: MS4xfBxT6WtLZiZfi9Pq47qRsA+98cJg5V9MaGVjdyIzIeiMIEq6IpD62x2IN68cy+WA6cEp1l2Tffp002KwM+VS7VF/ghnIYA1WIA3lkuDO7+HBS5O46Klb
 JptWz8j5Z+hs4d+o2QkQytGCQW5VmlNkli22BxTz4oyMT5YwK5IpNmtjYADhfVkC8vajeiWN90FPiaIwjhjBlleIrJ/thsQQ2sWfOzMedPfx6LlaIq7GGnI/
 iTgAtX9f05ZHNAhJRrj0aFsphIHJfVfsFlMEt9BMhd4=
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wed, Sep 06, 2023 at 12:06:46PM -0400, You wrote:
> Hi!

Hi!

[...]

> > Because I was not able to find out the contribs sources.
>
> (assuming the source is a gzipped tarball)
>
> If you './pre-inst-env guix build --source tk-img', then unpack it to
> /tmp with 'tar xf /gnu/store...-cage.tar.gz -C /tmp', you should then be
> able to look at what it contains, e.g.
>
> find /tmp/cage-x.y.z/ -name '*contrib*'

So they were hiding under the "compat" directory! :D

I have learnt a new (to me) guix switch ("--source"), thanks!

> > Also, for the record, the problem with  tests is not that the Tk (as I
> > erroneously thought)  executable can not  be found but that,  for some
> > reasons, the tcl script seems to fails to resolve Tk as dependency:
> >
> > $ tclsh
> >
> > % package require Tk → raise an error
>
> Oh!  So it seems we have a bigger problem to resolve first :-)
>
> Thanks for your investigations.

My pleasure, I am happy if I  can give a contribution to guix, even if can be only
minimal.

Bye!
C.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 14 Sep 2023 21:28:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 14 17:28:53 2023
Received: from localhost ([127.0.0.1]:41333 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qgttM-00089u-Sn
	for submit <at> debbugs.gnu.org; Thu, 14 Sep 2023 17:28:53 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:58232)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1qgttL-00089h-Mm
 for control <at> debbugs.gnu.org; Thu, 14 Sep 2023 17:28:52 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1qgtt9-0000dH-RP
 for control <at> debbugs.gnu.org; Thu, 14 Sep 2023 17:28:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=YytJQQj5PTg9d2mDZgoyhTuXqKfUY7zRDTu7ih+590g=; b=d2oWzK3kCn28BS
 NXoV/3GZ6c6EebQo9DgyRxBEFgsiY30IflgaqKYc4LxOT64yZQyvuOdKJ7EAMMI7+OwnxDOVqwKQI
 S802JDCxDBQBCK1u/tma6a2EECgXjGJHXoXg/owcQVBS9A01Jb6UN571CMDBodCuooiTu3bCDduIr
 YLrQ9Xs2NIuqrdKxHRWmaAx/z5IUO9eQwCySjOklWL5kqS0Z1qa9InlzdqPkJ258i3oT39U0Np41j
 hPv55+SavYcYQLAiSrCTNVR4tljQJJ9B5jk9O5CgEUTvcFIvXXpRcl8uUvrtxY5HktEICSyeHNkf8
 jLzTEokPqXG1BOKh+9pQ==;
Date: Thu, 14 Sep 2023 23:28:20 +0200
Message-Id: <87jzss4f7v.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #65097
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 65097 + moreinfo
quit

Last modified: Thu, 14 Sep 2023 21:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.