X-Loop: help-debbugs@HIDDEN
Subject: bug#65291: 30.0.50; `inhibit-interaction` is too eager
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 14 Aug 2023 15:24:01 +0000
Resent-Message-ID: <handler.65291.B.16920266259923 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 65291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 65291 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.16920266259923
(code B ref -1); Mon, 14 Aug 2023 15:24:01 +0000
Received: (at submit) by debbugs.gnu.org; 14 Aug 2023 15:23:45 +0000
Received: from localhost ([127.0.0.1]:34204 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qVZQ1-0002Zy-Bn
for submit <at> debbugs.gnu.org; Mon, 14 Aug 2023 11:23:45 -0400
Received: from lists.gnu.org ([2001:470:142::17]:34660)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1qVZPz-0002Zm-HX
for submit <at> debbugs.gnu.org; Mon, 14 Aug 2023 11:23:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <monnier@HIDDEN>)
id 1qVZPt-0000X7-GG
for bug-gnu-emacs@HIDDEN; Mon, 14 Aug 2023 11:23:37 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <monnier@HIDDEN>)
id 1qVZPq-0002GT-NN
for bug-gnu-emacs@HIDDEN; Mon, 14 Aug 2023 11:23:36 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 463BA1000EF
for <bug-gnu-emacs@HIDDEN>; Mon, 14 Aug 2023 11:23:33 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1692026607;
bh=HhnpaAerK+/v59G28NcinrvaGprvpUK/NooiHy8WwB8=;
h=From:To:Subject:Date:From;
b=ZZQ69duqGGxgHzp7yuOd8Ooj/fObysMuHLcKKUpGoOW7VWnw+D8C9PAKxPQ+R7+oP
lhT301+rjj2v0hMarIL86wDB/57F96VhmZn8Y3MfA5pED5HWMtksOiwBMxBrPoPnOQ
OhV4lg8DcoI+8Ibz+3WdZB6gR+an0Cw82XinUz2wEHrS8H5Ds6Xhcss/4YR46qaRVj
A7ZVz1iY/3V8lxqvoNeYMb6JEOoeCGQc0qEZyi9UKBu8FRA2wK3Q6YG31JvmZ0N1Pt
n7NAT0q2MlHNyUbxUl6Ko/z2iMeUbhe/1yQdhs6IYdyWZL6JmvrWK2i2WsKT/7ZXf2
u2gjYBAxiCu5g==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C0ABC10006B
for <bug-gnu-emacs@HIDDEN>; Mon, 14 Aug 2023 11:23:27 -0400 (EDT)
Received: from pastel (unknown [45.72.228.154])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A9EA612030F
for <bug-gnu-emacs@HIDDEN>; Mon, 14 Aug 2023 11:23:27 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Date: Mon, 14 Aug 2023 11:23:18 -0400
Message-ID: <jwvpm3psl5l.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.169 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
Received-SPF: pass client-ip=132.204.25.50;
envelope-from=monnier@HIDDEN; helo=mailscanner.iro.umontreal.ca
X-Spam_score_int: -42
X-Spam_score: -4.3
X-Spam_bar: ----
X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Package: Emacs
Version: 30.0.50
When `inhibit-interaction` is non-nil, all calls to
`read-from-minibuffer` or `read-event` will signal an error, even when
those calls are carefully wrapped in such a way that they will return
without needing any user interaction, thanks to timeouts,
`unread-command-events`, or whatnot.
The patch below reduces the number of false positives by delaying the
check to the point where we know "for sure" that we will have to wait,
but is still not quite right because it doesn't handle the timeout case :-(
Stefan
diff --git a/src/keyboard.c b/src/keyboard.c
index 78c88a2859b..ef243bc9b5d 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -2738,6 +2738,11 @@ read_char (int commandflag, Lisp_Object map,
goto exit;
}
+ /* Looks like we really have to wait for interactive user input.
+ FIXME: This still suffers from false positives when `read-event` is
+ called with a time out to wait for things like process output :-( */
+ barf_if_interaction_inhibited ();
+
/* Make a longjmp point for quits to use, but don't alter getcjmp just yet.
We will do that below, temporarily for short sections of code,
when appropriate. local_getcjmp must be in effect
diff --git a/src/lread.c b/src/lread.c
index 251da5670d0..893ff70fc62 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -951,8 +951,6 @@ DEFUN ("read-char", Fread_char, Sread_char, 0, 3, 0,
{
Lisp_Object val;
- barf_if_interaction_inhibited ();
-
if (! NILP (prompt))
{
cancel_echoing ();
@@ -989,8 +987,6 @@ DEFUN ("read-event", Fread_event, Sread_event, 0, 3, 0,
`inhibited-interaction' error. */)
(Lisp_Object prompt, Lisp_Object inherit_input_method, Lisp_Object seconds)
{
- barf_if_interaction_inhibited ();
-
if (! NILP (prompt))
{
cancel_echoing ();
@@ -1028,8 +1024,6 @@ DEFUN ("read-char-exclusive", Fread_char_exclusive, Sread_char_exclusive, 0, 3,
{
Lisp_Object val;
- barf_if_interaction_inhibited ();
-
if (! NILP (prompt))
{
cancel_echoing ();
diff --git a/src/minibuf.c b/src/minibuf.c
index 58adde1bf66..4636ce8f308 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -316,6 +316,8 @@ read_minibuf_noninteractive (Lisp_Object prompt, bool expflag,
struct emacs_tty etty;
bool etty_valid UNINIT;
+ barf_if_interaction_inhibited ();
+
/* Check, whether we need to suppress echoing. */
if (CHARACTERP (Vread_hide_char))
hide_char = XFIXNAT (Vread_hide_char);
@@ -1344,8 +1346,6 @@ DEFUN ("read-from-minibuffer", Fread_from_minibuffer,
{
Lisp_Object histvar, histpos, val;
- barf_if_interaction_inhibited ();
-
CHECK_STRING (prompt);
if (NILP (keymap))
keymap = Vminibuffer_local_map;
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Stefan Monnier <monnier@HIDDEN> Subject: bug#65291: Acknowledgement (30.0.50; `inhibit-interaction` is too eager) Message-ID: <handler.65291.B.16920266259923.ack <at> debbugs.gnu.org> References: <jwvpm3psl5l.fsf@HIDDEN> X-Gnu-PR-Message: ack 65291 X-Gnu-PR-Package: emacs Reply-To: 65291 <at> debbugs.gnu.org Date: Mon, 14 Aug 2023 15:24:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 65291 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 65291: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65291 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 16 Dec 2023 15:52:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 16 10:52:56 2023
Received: from localhost ([127.0.0.1]:55804 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rEWyG-0001O4-EG
for submit <at> debbugs.gnu.org; Sat, 16 Dec 2023 10:52:56 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56927)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>)
id 1rEWyD-0001Nl-KI; Sat, 16 Dec 2023 10:52:54 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8EB45100068;
Sat, 16 Dec 2023 10:52:47 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1702741966;
bh=y3TunpwzOogYXMRijDfv+4WgoZgt6MZMom8n6ftW0I0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=GgxewbU3gaZaRpW1NxSgrqXlXLQxRCxJ3pE5EApiuN1FqBlsSDcys6LYbpw/H8O8t
PN3E9ta5xbk3RY8wDJRwVJFYGUC8aZC9jOZykR/8ze2V3hUVAp/R8daFURDmBulS/v
Z1Qb3xDlSV4LmhN8Myj7yiTCUjLknDTou7UhkKB3Giw0RvSeSc+bjuw0CISfAIExWG
f0DT46qGbDmUuKoMiuy3l7eRgxjYLvaK6N1I5AO3NIw7rmyrE79ID16PkapnG500vN
ZoUBfAGD+XdCYcazwFX0BgBozSezsG+L9Rkc2s7xiB0P1WEXMEfP+OYfU91tPS4dJh
652+cFBGl85yw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A11CA100033;
Sat, 16 Dec 2023 10:52:46 -0500 (EST)
Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 69E4A12023C;
Sat, 16 Dec 2023 10:52:46 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67837: 29.1.90; inhibit-interaction breaks keyboard macros
In-Reply-To: <83h6kjnrzg.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Dec
2023 22:14:11 +0200")
Message-ID: <jwvttoi2mcr.fsf-monnier+emacs@HIDDEN>
References: <ieredfnl8dg.fsf@HIDDEN> <ierbkarl8a2.fsf@HIDDEN>
<83le9vnvnn.fsf@HIDDEN> <ier8r5vl00s.fsf@HIDDEN>
<83jzpfnsle.fsf@HIDDEN> <83h6kjnrzg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Sat, 16 Dec 2023 10:52:45 -0500
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.031 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: sbaugh@HIDDEN, larsi@HIDDEN, control <at> debbugs.gnu.org,
67837 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
merge 67837 65291
thanks
AFAICT this is the same bug as bug#65291 and the suggested patch is similar.
> I'm actually tend to think that this proposal is fundamentally wrong,
> not just problematic implementation-wise. Providing input from a
> keyboard macro is still input, and inhibit-interaction=t means asking
> for input signals an error. So your suggestion subverts this feature,
> and therefore it is simply wrong to install something like that.
I guess it begs the question: what is the purpose of
`inhibit-interaction`?
The way I see it, the purpose is to avoid Emacs waiting for user input
when we know there's no user, and thus signal an error if we ever get to
this point.
Basically, I think since our test suite runs just fine in batch, we
should be able to run it with inhibit-interaction=t as well (which
would fix annoying problems when some test fails and ends up waiting
for user input).
Note that trying to make the whole test suite runs with
`inhibit-interaction` non-nil is not at all straightforward, sadly:
there are several places where we do call things like `read-event`
without providing any keyboard input (i.e. without
`unread-command-event` or keyboard macros) and instead use a timeout
because this `read-event` is just there to force Emacs to wait while
some external process sends us some reply. Should these be considered
"interaction"? If not, then we open up a whole where some code may call
`read-event` with a relatively short timeout within a tight loop where
the purpose *is* to get user input and where the timeout is only present
to keep something else updated while we wait for that user's input.
Stefan
Received: (at control) by debbugs.gnu.org; 16 Dec 2023 15:53:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 16 10:53:11 2023
Received: from localhost ([127.0.0.1]:55813 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rEWyV-0001PQ-6T
for submit <at> debbugs.gnu.org; Sat, 16 Dec 2023 10:53:11 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11905)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>)
id 1rEWyT-0001P8-OV; Sat, 16 Dec 2023 10:53:10 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A70D8441D11;
Sat, 16 Dec 2023 10:53:03 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1702741982;
bh=y3TunpwzOogYXMRijDfv+4WgoZgt6MZMom8n6ftW0I0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=exgUzDmNgCzsKFqDlgRmiZaLuckdBv8G4GcrfB9pOpiye21FbLVpILR3ZiEgaoYwi
7rd0oazbLqjv4WvrUJby4XdqreLJBnPSqr5es9BRRgRYOyJCBLsCa2cj5cjzsyBvN4
SXD4leoWxEYlGqVjVc7B63jbS8LsmE/K2IdFasZO/JDSAW3t5qLqFLZBv0787AVt4F
wIyOMOPsG+UYHEJlCUbCMh66cJ+cyMJ9tMcLw4AX3dsbpg3J2KODFonOBGXUQdqY0v
bfT9x/OOm0iRihFkJTRK+V+No9rQmDuhlmap3lfZSdFboI4h4qgdtubcNvOchR9WCj
e5+S8lKeSvDiA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 23F06441D03;
Sat, 16 Dec 2023 10:53:02 -0500 (EST)
Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E62A0120476;
Sat, 16 Dec 2023 10:53:01 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67837: 29.1.90; inhibit-interaction breaks keyboard macros
In-Reply-To: <83h6kjnrzg.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Dec
2023 22:14:11 +0200")
Message-ID: <jwvttoi2mcr.fsf-monnier+emacs@HIDDEN>
References: <ieredfnl8dg.fsf@HIDDEN> <ierbkarl8a2.fsf@HIDDEN>
<83le9vnvnn.fsf@HIDDEN> <ier8r5vl00s.fsf@HIDDEN>
<83jzpfnsle.fsf@HIDDEN> <83h6kjnrzg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Sat, 16 Dec 2023 10:53:01 -0500
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.680 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DCC_CHECK 1.1 Detected as bulk mail by DCC (dcc-servers.net)
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
FSL_BULK_SIG 2.064 Bulk signature with no Unsubscribe
T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: sbaugh@HIDDEN, larsi@HIDDEN, control <at> debbugs.gnu.org,
67837 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
merge 67837 65291
thanks
AFAICT this is the same bug as bug#65291 and the suggested patch is similar.
> I'm actually tend to think that this proposal is fundamentally wrong,
> not just problematic implementation-wise. Providing input from a
> keyboard macro is still input, and inhibit-interaction=t means asking
> for input signals an error. So your suggestion subverts this feature,
> and therefore it is simply wrong to install something like that.
I guess it begs the question: what is the purpose of
`inhibit-interaction`?
The way I see it, the purpose is to avoid Emacs waiting for user input
when we know there's no user, and thus signal an error if we ever get to
this point.
Basically, I think since our test suite runs just fine in batch, we
should be able to run it with inhibit-interaction=t as well (which
would fix annoying problems when some test fails and ends up waiting
for user input).
Note that trying to make the whole test suite runs with
`inhibit-interaction` non-nil is not at all straightforward, sadly:
there are several places where we do call things like `read-event`
without providing any keyboard input (i.e. without
`unread-command-event` or keyboard macros) and instead use a timeout
because this `read-event` is just there to force Emacs to wait while
some external process sends us some reply. Should these be considered
"interaction"? If not, then we open up a whole where some code may call
`read-event` with a relatively short timeout within a tight loop where
the purpose *is* to get user input and where the timeout is only present
to keep something else updated while we wait for that user's input.
Stefan
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.