GNU bug report logs - #65869
[PATCH] gnu: xxhash: Update to 0.8.2.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Hendursaga <hendursaga@HIDDEN>; Keywords: patch moreinfo; dated Mon, 11 Sep 2023 15:49:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Christopher Baines <mail@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 65869 <at> debbugs.gnu.org:


Received: (at 65869) by debbugs.gnu.org; 5 Oct 2023 15:14:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 05 11:14:22 2023
Received: from localhost ([127.0.0.1]:48222 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qoQ3R-0001Jt-Ry
	for submit <at> debbugs.gnu.org; Thu, 05 Oct 2023 11:14:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52178)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1qoQ3Q-0001Je-Nm
 for 65869 <at> debbugs.gnu.org; Thu, 05 Oct 2023 11:14:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1qoQ32-0000xe-MC; Thu, 05 Oct 2023 11:13:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=7Xzku5nG/Jpze/6Fu+D/4aNvWaG7RfICy2YBUFhQKvw=; b=WHOrykA7RfNogdjU0cxt
 rkKCYjDcq7FIyNUznR2V5GRwHME6ZzdWVFu1T4gnYS1C54ifYOay8bCDBmOpl67T8zualMA2745l0
 7RfSNa6iHIhi839b0IT28sg7Q/62PLIBPBsczwqL6Pf10Slmi2/QqLutudWiLAZGoHVxp4HEMCbbx
 mKWbzUXsd/bEXNKdrN+Wzt5EQ9CA6+fitLEwHgWM19vTDkdH+ot34Z7pQmBOhLGeV4FJI/4lOrVSy
 VT2XLECvgn4bnOGSKlTbNCKAf25xN1QHJcAzEzjGXmfVZVWMJjn33ZHvchYlV9z+gi7DpZTk9BrQs
 APyQFyC1CWF84g==;
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Hendursaga <hendursaga@HIDDEN>
Subject: Re: bug#65869: [PATCH] gnu: xxhash: Update to 0.8.2.
References: <4c5c02439c0e000ad59bbf512d5326fa249b726f.1694447118.git.hendursaga.ref@HIDDEN>
 <4c5c02439c0e000ad59bbf512d5326fa249b726f.1694447118.git.hendursaga@HIDDEN>
Date: Thu, 05 Oct 2023 17:13:53 +0200
In-Reply-To: <4c5c02439c0e000ad59bbf512d5326fa249b726f.1694447118.git.hendursaga@HIDDEN>
 (hendursaga@HIDDEN's message of "Mon, 11 Sep 2023 11:47:06 -0400")
Message-ID: <87r0m9umoe.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 65869
Cc: 65869 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey,

> -           #~(list #$(string-append "CC=" (cc-for-target))
> -                   #$(match (or (%current-target-system)
> -                                (%current-system))
> -                       ;; Detect vector instruction set at run time.
> -                       ((or "i686-linux" "x86_64-linux") "DISPATCH=1")
> -                       (_ "DISPATCH=0"))

Could you conserve the original indentation here, not to introduce
noise?

> -                   "XXH_FORCE_MEMORY_ACCESS=1" ; improved performance with GCC
> -                   (string-append "prefix=" (assoc-ref %outputs "out")))

> +                                (string-append "prefix="
> +                                               (assoc-ref %outputs "out")))

You can use #$output here.

Could you please send an updated version :)?

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#65869; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Sep 2023 15:48:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 11 11:48:19 2023
Received: from localhost ([127.0.0.1]:54502 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qfj98-0005rd-I0
	for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 11:48:19 -0400
Received: from lists.gnu.org ([2001:470:142::17]:36746)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hendursaga@HIDDEN>) id 1qfj96-0005qo-DQ
 for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 11:48:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hendursaga@HIDDEN>)
 id 1qfj8r-0002OS-IN
 for guix-patches@HIDDEN; Mon, 11 Sep 2023 11:48:03 -0400
Received: from sonic317-32.consmr.mail.ne1.yahoo.com ([66.163.184.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <hendursaga@HIDDEN>)
 id 1qfj8n-0005JB-N4
 for guix-patches@HIDDEN; Mon, 11 Sep 2023 11:48:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1694447272; bh=DJKrUyW5jCfQGEwULqzsZtmowuXynimJxk9wOkFoXnA=;
 h=From:To:Subject:Date:References:From:Subject:Reply-To;
 b=Ev5DEvAfvni1LWLQMZV+7Lf/OWJ8tj636loALDgKHsPCqF0sh7CxBHkwj/JToF9vut2ej2M+ObrkrGH+GdBc8CXT9ra1l3Dc1chTRIHzYQEyb75yItL9RrDbsf8NLfN+uHxdrGlqL8EtExdL+YcxRnRcLPbxV2yTPQIN52N236ZmPmet9iDGXHw88MzmxjQz01zbXqHMWjUiF+D6d+dskyLR/KVfzQ2MA6AiYH6UNlbhZQwLWmxpBc4Gi6dTIvo0trLJ1yOW6oEG/IHwRO9EVkuOmtr8BhHZEsE/wgOyIT9St793gL2E3RBmcYy+39Yh8JGzdfc4qvaks25/E/FwTA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1694447272; bh=KA2KdJs4bHa9xNFjVZ613bprsn5QEKigfnxg5KM66KN=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=gD2qECwh01tIxWKPtFSkI9/1GfzsrqiURMO1w4P+Vq5OeMp58YxcqLAHEH/HZ86YuKXER1yl37ApJZ2mAUk9Kie4o+sKfSj8izv60JsO7m9zeRhqVRMgvefHxAEdN51B2X3R3TJQmYlEQJRPzJgIhYLbLjKmaWvEBsB1ldYa3dx9HWYyZK4QH/grDL7RJ44z35CUHeXvlcXySuiQZk0f0NhNUdPeyG5QGxQtoaV8fFV1AXhnImeZKITkhP87cj3zwL2NOnzwixivvhSiDhMCoBWq8hDhVMqxkeg395iCUET+5kJ63Xoxv/yaTI86bH2qFJTUI91tNjFamRUi0hA4Rw==
X-YMail-OSG: 2SM.yQYVM1k94tg5LFpmnvB3.dZDm08fqLfWxvsTzDmt9J27gSkjb5U5qulyteB
 F1xrachc5zrTrtHZaE8yRQNRyM_v3ZHLmrmEDDyDpuplJAUkxuQ9lz_fWfahYqDzEeVdAi1HmQpv
 N0Su6hqADEf9lY5lzCF3yfH_vmukaYT97Vi0ZGxj0ciNeCLcYWOHYYKlxQHrlG23Y1MaBgMFrnpH
 pY_Q0G_cvI73WDQVTVjhNTsg_RjwmlDss0U2VTzUaFZKOPjX5ZfS0gwFq1DlPPnFg16HY0dgEpqD
 YHXNLQ7vsefgmrPnCgykx7c51FZAE.YkC8AYj8KuDFRwjVCZrTJZfYUP4GIuq_sieZtKzxnZcsHZ
 Y.i.l.nD4i70YWNPKxf_G9rJgZKJoWfrFRL6pYUJNSTHfDPg2SOrc7cLQ3Gmzz97JguLIie7SdxT
 5N4Ygk0OYd3BCu2GqgoZzUA6_FIQmd343YSxTVYKvqoAm7iXlZayp_5MC_x16qZ0ig8lG3wFBbNj
 UEi1oJ.OAOzOkD0JbCRmlUcA09j7EK.cT7wDMGB_rBqL.03qM5shiWTOGQlirPoTUq5xw.Y8dOWz
 BgturakAG7OYHUIm91jUeuZmZVc2d7_tt07yfgPWiQCD_U2sdfWXMOmYO.QWMKsk227eDEeMpt2m
 fwvNp63HYRj4fpXSNwqJUgR.GQTih_dBMkyfIrygCUFMhYKJO0oseOTBhltGdcA23e2TJJXpmMTy
 G7BWEYVy.XCO00jgeNj5fvMnDaCXiAZucFO.IrRm8V9awguQmGaNqXq8AofOH2wgyz2Lcw_GFIk9
 pfwEiGTYBUV.JLdUB4ymE84QWDZZqrusbkaUThrqYMNBUN2KXWnbhHDYp154GbsQuFeNJRjnco29
 N.4inTDpvAZT3pOm7KL___qg1.mgozPkSUsmeni5OMyhWxTYTD1GIsauhobrzm2Q_8U8w83Zc9Iv
 7nfgKQlFu_x8_m6BiwbxqYpzJhe6z5DUj45Ken_rTlxcu3hBvHy_.dsjrihDuToMD1Tj5IwgA4Nw
 ycwvOTF5iGer2PvWirNToSY9JeDjz40wiPp3zjlbQ10lfcAJfx.f065cC0APwF1c2n8j61yGq2sY
 Au9mIhx1.wNHBRtD6Wd8ukh72DTMofMBU5_m_V11j7gUruvwn4ZdwGsMd_n_b3qOO3b1hsgD8YKf
 D6mxdNzG2bluX84UYICDQO9RfzkU6q8vKQ_TJu6flLyJI_QlucbUJqD9I.RxmZgBeRb4E3aK3hbs
 Fi4FEdT7cB7akWOz5Uc8DbCdVPzcAt31A3XTIZF9orA6KW7f5avNUU2DzyggqLSAILkrj7b4d7Jb
 nRYgilI3H.6tJHFpeRxFVJhQ.RH75QK9FTMW7bfbTW1st7dT37JZpBA.NusgqQxtHq4xN5mOYgra
 kMyRW4A2lh9EfJ0fkHrfbRHhzkg.PdU2yjZAf2Fi0ELzcK4v0MGPKBk8r_h8NzH1DY3jCBT9Ck36
 aZBHT_0bqYE9GZni2NKn.NqB1pfKJJXskt5UDdIk5n7YzNhL1UU6ztwQHMhWWtXnfZWt8.z2xFaH
 4sDNqa3WiufX8bRSic8Gcbt7PGRi6F2v4kxmBkxP6xaIBHMIr8TQM1EHjbG6ILwye7Na6_GssGbw
 DWA8J26rLiN3g8qT7hPhJ5dGCKN5QQ.5X3I7mCy5i7VLRWorTw4yRm34eCi304MpN9BlJvtl4kW7
 GzAsAlRt12qlaz3y2o0v4RZj3bVcsd5sCbGqJHeUhGxPtKf9nS8oDTd1S30Ky76Eocg41lnaByiC
 O5tzLpqTOK8Tp.JTgs_ixt_AgB4nArljbwIntyo8b5Ly_PsFrfngn8ax2rygc5LgtUspBbCeeg5K
 jZZU1WtYd8SLruU8qMSrTbpU9LqQ02DfVVN3N74lWJyqqDHRGw4VNJuCQ1V0CkSRDYL7WjEKR16O
 sX.1U8dg1A.lOqfDC1IT.Sh35GjbeML2PiPlMpJ6NghfAsGc0QlGhCFspof_NY5GlthxXdszXM6F
 GmTqhEG2KwxWM7rvr_iXJMX2UPC4PFgeI7ccrjwbaxcdCyEmRtKQgtJ3ju0Pah_R7q7w2p1373zy
 PTGQace8sJAof6TS3aPWFr_.HtVvb1ef6taYTtNZqqylhQm_smK4HpWDQsUK8BMQx9uiQThOqzfj
 YBvVwUmA48wwMQE1IruLA9l_tDbM0ak5Xu.VQLFYrD9HVaf_yuGMuLyqx0m0dVGIWKA--
X-Sonic-MF: <hendursaga@HIDDEN>
X-Sonic-ID: a6c793e8-e9fc-425a-b160-d9fcd6d4f2e5
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic317.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Sep 2023 15:47:52 +0000
Received: by hermes--production-ne1-7b767b77cc-fbxjt (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 2f9e18bce83cfa020df019bee8c563e1; 
 Mon, 11 Sep 2023 15:47:51 +0000 (UTC)
From: Hendursaga <hendursaga@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: xxhash: Update to 0.8.2.
Date: Mon, 11 Sep 2023 11:47:06 -0400
Message-Id: <4c5c02439c0e000ad59bbf512d5326fa249b726f.1694447118.git.hendursaga@HIDDEN>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
References: <4c5c02439c0e000ad59bbf512d5326fa249b726f.1694447118.git.hendursaga.ref@HIDDEN>
Content-Length: 4031
Received-SPF: pass client-ip=66.163.184.43; envelope-from=hendursaga@HIDDEN;
 helo=sonic317-32.consmr.mail.ne1.yahoo.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

* gnu/packages/digest.scm (xxhash): Update to 0.8.2.
[arguments]: Use Gexp.
<#:phases>: Remove 'fix-man-page-links phase.
[home-page]: Update URL.
---
 gnu/packages/digest.scm | 58 ++++++++++++++++++-----------------------
 1 file changed, 26 insertions(+), 32 deletions(-)

diff --git a/gnu/packages/digest.scm b/gnu/packages/digest.scm
index 481771804b..9ed3b895a2 100644
--- a/gnu/packages/digest.scm
+++ b/gnu/packages/digest.scm
@@ -69,46 +69,40 @@ (define-public wyhash
 (define-public xxhash
   (package
     (name "xxhash")
-    ;; XXX Remove the 'fix-man-page-links phase when updating.
-    (version "0.8.1")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/Cyan4973/xxHash")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1h6080lvcr5mpbvy4fhb4i7wvhpy72nrixk3djmpai4hxq41hsnr"))))
+    (version "0.8.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/Cyan4973/xxHash")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1ljsmxcxfyxzxzk435qnjiyy441bgrxirn285lymyvv39nrwz1wj"))))
     (build-system gnu-build-system)
     (arguments
-     (list #:make-flags
-           #~(list #$(string-append "CC=" (cc-for-target))
-                   #$(match (or (%current-target-system)
-                                (%current-system))
-                       ;; Detect vector instruction set at run time.
-                       ((or "i686-linux" "x86_64-linux") "DISPATCH=1")
-                       (_ "DISPATCH=0"))
-                   "XXH_FORCE_MEMORY_ACCESS=1" ; improved performance with GCC
-                   (string-append "prefix=" (assoc-ref %outputs "out")))
-           #:phases
-           #~(modify-phases %standard-phases
-               (add-after 'unpack 'fix-man-page-links
-                 ;; https://github.com/Cyan4973/xxHash/issues/647
-                 (lambda _
-                   (substitute* "Makefile"
-                     (("ln -sf \\$\\(MAN\\)")
-                      "ln -sf xxhsum.1"))))
-               (delete 'configure))))         ; no configure script
-    (home-page "https://cyan4973.github.io/xxHash/")
+     (list #:make-flags #~(list #$(string-append "CC="
+                                                 (cc-for-target))
+                                #$(match (or (%current-target-system)
+                                             (%current-system))
+                                    ;; Detect vector instruction set at run time.
+                                    ((or "i686-linux" "x86_64-linux")
+                                     "DISPATCH=1")
+                                    (_ "DISPATCH=0"))
+                                "XXH_FORCE_MEMORY_ACCESS=1" ;improved performance with GCC
+                                (string-append "prefix="
+                                               (assoc-ref %outputs "out")))
+           #:phases #~(modify-phases %standard-phases
+                        (delete 'configure)))) ;no configure script
+    (home-page "https://xxhash.com/")
     (synopsis "Extremely fast hash algorithm")
     (description
      "xxHash is an extremely fast non-cryptographic hash algorithm.  It works
 at speeds close to RAM limits, and comes in both 32- and 64-bit flavours.
 The code is highly portable, and hashes of the same length are identical on all
 platforms (both big and little endian).")
-    (license (list license:bsd-2        ; xxhash library (xxhash.[ch])
-                   license:gpl2+))))    ; xxhsum.c
+    (license (list license:bsd-2 ;xxhash library (xxhash.[ch])
+                   license:gpl2+)))) ;xxhsum.c
 
 (define-public python-xxhash
   (package

base-commit: 2eb6df537c36da8bf8e81ff698421f6fb1bfd1ab
-- 
2.40.1





Acknowledgement sent to Hendursaga <hendursaga@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#65869; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 11 Oct 2023 10:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.