Simon Tournier <zimon.toutoune@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 66586) by debbugs.gnu.org; 31 Oct 2023 21:29:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 17:29:32 2023 Received: from localhost ([127.0.0.1]:49418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxwIm-0008FK-89 for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 17:29:32 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:39140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>) id 1qxwIk-0008F5-1B for 66586 <at> debbugs.gnu.org; Tue, 31 Oct 2023 17:29:31 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32f831087c6so642854f8f.0 for <66586 <at> debbugs.gnu.org>; Tue, 31 Oct 2023 14:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698787730; x=1699392530; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=m/e6cKBJiJjgqwfwIEiewchKtD8+Z3cLbqLcdc4JxRk=; b=NGIrREnXtFtKgofXks3y/oSVFWnj4oPGLURKFE5rBU79gCw5Us5AudwlZBG6/N4PzB 5P4b3lqV+fjh8REzv7HpOEIISjHsQJgnsK7o2z1GIivFIYv65zT71iC9cR3qMbS9pr4u pVWd2WZIPTtDMp4PRsSffDhhbZTY6F4Rky6i8UN/HUQiaic9Z/mWD0TqgDbhkNucYdjN K1rf9VsC+pgwU47ugwm/tCOC7kFeRCN2aYCkv4+b3nYWZHKHpP0bndqTaYOcVCf6XxeT iG+SWJhXPnhQIeWDhxS2+yE3so6rq3SBmyXewg5gRkyjv2VzjNVfw73AvxSfqxhekUtN UiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698787730; x=1699392530; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m/e6cKBJiJjgqwfwIEiewchKtD8+Z3cLbqLcdc4JxRk=; b=iPigzk82lTDqB5OIslhtgOZG98ssY/Vx4t9g2Z5DiKZZKH++cyRK/klHEjpDEskvzW SkElqtIVlmII3hBXhSCTHsBsZqITmUuOm74BNBKRKLXw7ApOi0PGLEn7oLAbiB+RLYV2 5N4k3xfGE1btpqcQ2HozJhZt7o7WvxmjpxAVaDR7pYHeSZ6Ogfl4/Qo/PM69xSJEvi4N BCwKC2OFGnm3D3UdpxT2epypoCoL6TUD0MOz+2yu343Io5+jEqUgrlcFf3QwkhVLxHCy q0Cpt9mzxtU00blUBMN4oDSYYijOoMLCIm+W+PfuxlFkvEzAQb19eKbZ8jxkstFGa8cS YLgg== X-Gm-Message-State: AOJu0Yy+IN6E31em+/7Nv6G5Ojk53Ohf73s/yjW0W43mP5+icGc0OHWM dH/MNnDOtoPuoafE42GlgUMOo44LFNM= X-Google-Smtp-Source: AGHT+IFqRGg6h7NKn7s7NEQrTSzJawvBtFoUNj2RHA7QFXhAN+jdFJs6pwespWxdDiyFkjj7Lr+v0g== X-Received: by 2002:a05:600c:3411:b0:405:4127:f471 with SMTP id y17-20020a05600c341100b004054127f471mr10879807wmp.1.1698787729913; Tue, 31 Oct 2023 14:28:49 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c4e9100b00405c7591b09sm2810332wmq.35.2023.10.31.14.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 14:28:49 -0700 (PDT) From: Simon Tournier <zimon.toutoune@HIDDEN> To: Josselin Poiret <dev@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: [bug#66586] [PATCH v2] gnu: lvm2: Remove systemd rule. In-Reply-To: <87ttq6pnca.fsf@HIDDEN> References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN> <87bkch6ml8.fsf@HIDDEN> <87wmv3yxqw.fsf@HIDDEN> <87ttq6pnca.fsf@HIDDEN> Date: Tue, 31 Oct 2023 22:28:42 +0100 Message-ID: <86zfzy5vn9.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66586 Cc: 66586 <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, On Tue, 31 Oct 2023 at 21:07, Josselin Poiret via Guix-patches via <guix-patches@HIDDEN> wrote: > I get errors immediately in my dmesg when booting with this patch. Reverted 3991d9e4d9867ec499283bfc71b34d7bfebe49b3. Oops, sorry for the annoyance. I screwed up! Could you propose a fix for <https://issues.guix.gnu.org/65177>? Cheers, simon
guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.Received: (at 66586-done) by debbugs.gnu.org; 31 Oct 2023 20:08:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 16:08:36 2023 Received: from localhost ([127.0.0.1]:49244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxv2R-0006nf-RJ for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 16:08:36 -0400 Received: from jpoiret.xyz ([206.189.101.64]:48748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dev@HIDDEN>) id 1qxv2O-0006nV-Tr for 66586-done <at> debbugs.gnu.org; Tue, 31 Oct 2023 16:08:34 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 0957518518E; Tue, 31 Oct 2023 20:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1698782877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FdOR5E/XixoUkcvbozF+nrFc4iO3YzHs/PFY/5tnHHc=; b=l6ePTg3c418x0YOfIiD1Pc+XdGak6bYQjWXDRQvH4B2n7ZaCvWVY8dWCemSqEKzBm8FKVg 2aHsfFozhJXp0KKPVZjP8HcGcr9t7amHonl/I3UgODG98ekOjGmtddRbLOVQgTgrZqQIta QfL2RSbjV2Zz6gCq5g7YzLan/F76yylQl5PEoXca9zitF0k/9jDrZ6n9deoeqNSvfabMcD i4AfBxUcGEq6ebvRV7CJ2G7NPmTjJ0psc2vhQ5AqX3qcHm/t+wjWp31f7E2oRWVc7pGSQc OhuitDVLFKvEc7UMfFJ+dygsOivaVetax4KkIRGJAkPgpJPbKqv2z1JXp7VsPg== From: Josselin Poiret <dev@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN>, Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#66586: [PATCH v2] gnu: lvm2: Remove systemd rule. In-Reply-To: <87wmv3yxqw.fsf@HIDDEN> References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN> <87bkch6ml8.fsf@HIDDEN> <87wmv3yxqw.fsf@HIDDEN> Date: Tue, 31 Oct 2023 21:07:49 +0100 Message-ID: <87ttq6pnca.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Level: * X-Spamd-Bar: + Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@HIDDEN smtp.mailfrom=dev@HIDDEN X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66586-done Cc: 66586-done <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi everyone, The given .patch file is malformed: there are no closing double quotes for each of the strings. Additionally, I don't believe that the reference to systemd has been truly removed with this, as it's referenced in the second line of the patch. I get errors immediately in my dmesg when booting with this patch. Has this been tested? I believe this will affect users relying on LVM volumes. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmVBXpUQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaimzGC/9/LA6r8GzLydPwxGED9C6RpaH9uB3j63sg L9Ws6vc+drOJELyzHlN3+lLecrR0YPhHsZHIpzxH4QvMu9R2M38a79OrWzt+8qvy E0Z9uOzBmyAYaf63C8ZW5gNZV8SvP6UylyKqJKyvYYmiLNpUorw0D+SOEvgcTUS1 E/iR6RHx/vUyHCzmvkRAz5XI73LoOws7BVxwA470GdwXA9cU2uxBXEUjbJntccXN pFETWOg0A6wKTT1+zNw5AfvCDszEbhuJtahVf+bKbm1NjAbz9/OcVgeyrxqHopMj E9wv0AepOUjrSkZcTuKk+kr79DpDVsJk83zW7EQrGZUQ5HgsiRMt5eCEAfVoD6jm jMx8rI+Yses8GMmPEfZoETxDyk6eb17NBeevAd72JsU0vLtrqkfBfDs1YCN6Y1LJ yKwKu2zI6P6nN39v6hTW0aDDYgAEEFxmNpsoAnPvygPkBFcW/2iheXlMnm0dydZC eE8cV+UYzM7CLXbmxqlz35psNzNe50s= =gPr7 -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.Received: (at 66586-done) by debbugs.gnu.org; 31 Oct 2023 10:59:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 06:59:32 2023 Received: from localhost ([127.0.0.1]:47523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxmT6-0005wo-DT for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 06:59:32 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>) id 1qxmT3-0005w7-8K for 66586-done <at> debbugs.gnu.org; Tue, 31 Oct 2023 06:59:30 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32da02fca9aso855136f8f.1 for <66586-done <at> debbugs.gnu.org>; Tue, 31 Oct 2023 03:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698749929; x=1699354729; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ao7hH77H8dGeWEyY/4CoSVMXEgpufS/A3lfwk6yiqsc=; b=FRQsJifIcMvLGJJc3CGDTxYbGAmsKcTw9M8W+GohG0+re1l2D/3n1AYx1/CR/RkF4H Jg9nUiNqztkUbzCX+WidagoFAUXscgkc+e0bgP1iNFWJlmRCou1xAt9oqzPUyBrsQ5DH BAe5iIoyOmQJtAqMtTEF7UpqHR3kw7KHYvVZmqRmHlB5RLJfmyOYWL8tSnmM5K+s6iiI gwbzshhKnq4dqxc2Y4r7G0zn3nBYcs9idAY50VOeGUlP3AANN3YNXqQotdAne4UzDgcU yaL9YqbHdR3qOshC2UuzHtHlIrBHAIv+TPMv9Z1LtZ+pMqNwVcOfTbYTuq/6eqSHfCu4 X3Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698749929; x=1699354729; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ao7hH77H8dGeWEyY/4CoSVMXEgpufS/A3lfwk6yiqsc=; b=jjDw0VCsBS2PDX+jR0is6Y/mPX/o6VVSOm12EsK9iygw9FzPBlrzmPYCHc4jdjsE3M WoZp8AwnrFA1V8uJzzijQddCnZAr6KCeda1Hx/ci/aCj6uuQtFVRuewrbwzWyoUhgCQX I+RYFLWMPZbARhYUEoJ3e7LEtBKxHqJvQkfdUaLjzxalRjO4DmMgVIpR6NBiP4FhM34n 9JYjDHIm8rg/Wxe81qJSPGFctSaiia2TuU/VyHzAyLuKS098Ru5MQFqaoP8mTGGQzIpl xi2gC7epXdXaMDzqi9laZ+3WBNroabpRJbNMv9xHSx03CoeO1SJoHpfITgk4LADhl1sK nKaw== X-Gm-Message-State: AOJu0YzFveXz+A5Tp//VcoaOtX0SKvu/bamF7P6s09T/VUhfQ9ueNOhe N77qcbqd1T8vPwvkEY+1grtV6K37Y3A= X-Google-Smtp-Source: AGHT+IG8j7sy8l3UUS8bpreI7MEefwxurHcFssebrcHhVr4L9+S++6fqKYcu7ulPAhysAZvC/BR80w== X-Received: by 2002:a5d:598f:0:b0:32f:51c6:cd6c with SMTP id n15-20020a5d598f000000b0032f51c6cd6cmr9885742wri.2.1698749929327; Tue, 31 Oct 2023 03:58:49 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id c8-20020a5d63c8000000b0032f7cfac0fesm1240263wrw.51.2023.10.31.03.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 03:58:48 -0700 (PDT) From: Simon Tournier <zimon.toutoune@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: [bug#66586] [PATCH v2] gnu: lvm2: Remove systemd rule. In-Reply-To: <87bkch6ml8.fsf@HIDDEN> References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN> <87bkch6ml8.fsf@HIDDEN> Date: Tue, 31 Oct 2023 09:58:15 +0100 Message-ID: <87wmv3yxqw.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66586-done Cc: 66586-done <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, On lun., 30 oct. 2023 at 00:22, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote: > Simon Tournier <zimon.toutoune@HIDDEN> skribis: > >> From: Yann Dupont <Yann.Dupont@HIDDEN> >> >> Fixes <https://issues.guix.gnu.org/65177>. >> Reported by Adrien 'neox' Bourmault <neox@HIDDEN>. >> >> * gnu/packages/patches/lvm2-no-systemd.patch: New file. >> * gnu/packages/linux.scm (lvm2)[source]: Apply patch. >> * gnu/local.mk: Register new patch. > > LGTM, thanks! Pushed as c0895371c5759c7d9edb330774e90f192cc4cf2c. Cheers, simon
Simon Tournier <zimon.toutoune@HIDDEN>:Simon Tournier <zimon.toutoune@HIDDEN>:Received: (at 66586) by debbugs.gnu.org; 29 Oct 2023 23:23:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 29 19:23:05 2023 Received: from localhost ([127.0.0.1]:44009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxF7Y-0007eG-PK for submit <at> debbugs.gnu.org; Sun, 29 Oct 2023 19:23:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1qxF7X-0007dc-4C for 66586 <at> debbugs.gnu.org; Sun, 29 Oct 2023 19:23:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1qxF6u-0003vE-0E; Sun, 29 Oct 2023 19:22:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=QyNfLt3E4RCQPWlD2p5vvXTiafhND0X+Ecl760jbzQM=; b=XUq+KJR6XzKSIfVaqMtS HjqN/yR/QLw+7Zest5TsEYVHoRubgvLgqaLAVtnblSTPNq1SM5FjKe37up1WZmlLq4OQwL4WMbK5r OovlYicF6GLpduNgpmbR4bFJjNGUlp8kbhxVKSfQIQ0BebzFvC0EqDrk44eEGxgideEHQX4BSgbqn NHjXuX9HiKFPRdOa0TzFW9PX29uKoaNldoAjLGxcCzIgZSHsRtbI3gzN/Q5un7kdAnOZ7ljDcvYsd drHgWqvruSdhrLK45LhDKlg71thap4khPLfOZNblcDj2ehOlOPRYA9cgS30tjz2HHSbe0h++PbiDS O9U23I/wsZdzuA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: [bug#66586] [PATCH v2] gnu: lvm2: Remove systemd rule. In-Reply-To: <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN> (Simon Tournier's message of "Tue, 24 Oct 2023 18:47:14 +0200") References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN> Date: Mon, 30 Oct 2023 00:22:11 +0100 Message-ID: <87bkch6ml8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66586 Cc: 66586 <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Simon Tournier <zimon.toutoune@HIDDEN> skribis: > From: Yann Dupont <Yann.Dupont@HIDDEN> > > Fixes <https://issues.guix.gnu.org/65177>. > Reported by Adrien 'neox' Bourmault <neox@HIDDEN>. > > * gnu/packages/patches/lvm2-no-systemd.patch: New file. > * gnu/packages/linux.scm (lvm2)[source]: Apply patch. > * gnu/local.mk: Register new patch. LGTM, thanks!
guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.Received: (at 66586) by debbugs.gnu.org; 24 Oct 2023 18:14:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 24 14:14:31 2023 Received: from localhost ([127.0.0.1]:56577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qvLvD-0008Gu-CR for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 14:14:31 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:40089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>) id 1qvLut-0008Fu-4R for 66586 <at> debbugs.gnu.org; Tue, 24 Oct 2023 14:14:11 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32d971adc2cso289130f8f.0 for <66586 <at> debbugs.gnu.org>; Tue, 24 Oct 2023 11:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698171215; x=1698776015; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=qObXGvTNfvsIvdXlKLgBRn1GRiOD7vqvL39E3znkw74=; b=l9W9W26xnQ7XrEGYLNuKwrGa1lVD+AdWFzUaitUgbvoPrUc3qcUDwF1mGVIgtHi6ZE WB5Mz1Q4t+9WRShoodnd0/a7KLZGqb1wRSqAnYLe9BMMiFkOqhVxdVhxIe1p1NFBIGEJ eZdW4ShX6nXhWRnSi8HtX2oYITX45toHph6UGEPo1EKG8qY7dJyfdZ8UUNwpuU+P6ZMW BbeQqqtAFbMSSMIY90XiUoabf1gSk9ooZgVFH5Vg+n5PsQPgI3IhiRfrDIgBlVv79q0+ oP6u8azX/u8hXeM8NHt+oilKthChB8K3OgluFuimOnNfELcKEAXARlMKWyuOB6dDQIeA fGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698171215; x=1698776015; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qObXGvTNfvsIvdXlKLgBRn1GRiOD7vqvL39E3znkw74=; b=wIT/PBXbMRKnV4jLroZ0OC4Ej+QngpcuDkBzeEFL9daILsgaalULhvv4hMWXsyXDtq QBBMXGmPxcxuunYetM1hf9wPTrWEBJlhk/B1ORgvbdzwZzgGCtVOnAEBJLMvHwUeTOEX IW3qRb1mowN+vru/mKe1PvUOEiMDnENXJKhS/V4fdWxoPsl95vUaPSxJh464gsufgA5p QhVpwZU8Gh2EEKlZ9cCQ7hpXlJg/elEta/NmEIquoacnk4Bwx66XIhUlRAFxFiryl2N5 U1S+TAqaAn3Zasj/2TIEuRWCuNiIOjWxUR6HlAJtTaxGQD0zodMa/+aD8mm/RmyjUCPE aHdg== X-Gm-Message-State: AOJu0Yw64o2Gf9lX3ozhqibG2bhRk7lSIcq/uvJREms6t7jRhKh7kZHz zXF/VqmzKQJvQYoiyHMGZhI= X-Google-Smtp-Source: AGHT+IFv513S6m5KJvY8Y7DyljYBZQFNu9e3FtfBE3zm9jkEA4XEWR8UJce540maB8yG5nSueXMlJA== X-Received: by 2002:adf:e806:0:b0:32d:e445:ff02 with SMTP id o6-20020adfe806000000b0032de445ff02mr9902859wrm.1.1698171215455; Tue, 24 Oct 2023 11:13:35 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n12-20020adfe78c000000b00326f0ca3566sm10468385wrm.50.2023.10.24.11.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 11:13:34 -0700 (PDT) From: Simon Tournier <zimon.toutoune@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: [bug#66586] [PATCH] gnu: lvm2: Remove systemd rule. In-Reply-To: <87bkcpdn22.fsf@HIDDEN> References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> <87bkcpdn22.fsf@HIDDEN> Date: Tue, 24 Oct 2023 18:48:10 +0200 Message-ID: <87jzrchsqd.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66586 Cc: 66586 <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Leo Famulari <leo@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Ludo, On Mon, 23 Oct 2023 at 23:52, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote: > I propose to change this paragraph so that it is self-contained, like: > > Run =E2=80=98vgchange=E2=80=99 directly instead of attempting to run it= via > =E2=80=98systemd-run=E2=80=99 as the udev rules included in lvm2 >=3D 2= .03.14 do. I copy/pasted these lines in v2. Cheers, simon
guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.
Received: (at 66586) by debbugs.gnu.org; 24 Oct 2023 16:48:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 24 12:48:05 2023
Received: from localhost ([127.0.0.1]:56531 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qvKZZ-0005yf-5x
for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 12:48:05 -0400
Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:38001)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1qvKZS-0005y5-UL
for 66586 <at> debbugs.gnu.org; Tue, 24 Oct 2023 12:48:04 -0400
Received: by mail-wm1-x32b.google.com with SMTP id
5b1f17b1804b1-407acb21f27so5238825e9.0
for <66586 <at> debbugs.gnu.org>; Tue, 24 Oct 2023 09:47:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1698166042; x=1698770842; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=5XvyP+qUGyDMRHeF2iJ4Y0uE5rAHtSldlnqow4sQ73w=;
b=a7zMbteeu9jz1CrbtPjW1SRZXZiISw24f9GzXV1JbiQq2cZ2zVmfUQv+xctqXY3dpL
BJFc3TpstBUFa/S+WP4z+ec3GXaqH5Pjke8NtZwMuLUOX+sL1c+0ZRS7DLx3NPid0jbC
Pd8KY76QmFbD/2HNKuhIJxLdCciJ/Mv2ZGtLj4B47l/Lyg3zNLZ47lx4RqGFmQxANYu5
5LmtxCdXfNtWE6BXCsLw4HdLlKMG7At38hfJ9Qr+Da2+1X4gDragD1OB8G/MbmrKkSg7
jyqAOlUjkShQj3WhkwvXVCuah8GpGiXBFD28SjWj7/AeqQP8sIXvlYtFN10wQ4UcK+vg
XjAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1698166042; x=1698770842;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=5XvyP+qUGyDMRHeF2iJ4Y0uE5rAHtSldlnqow4sQ73w=;
b=C2+kns5o8PjK4R3ZHUh/wCiSvkZIiGIjs1uWyACozvXbuGyp7qMyQi8PIaavKLNt/R
Dlt7dCyS5UoGnqjZ0H+9llxn407fHt1GWAXzN9A6NavYiJdp3Dg6GXM7fUW2fkbCH+4k
kIj+jFsxLV1N9Yd0cb/8wL5I/nau7wcBBXiG9ldHvhq56Sr0Tp3lS0x55MfAJoWJ1M8n
FHKBhxdFF3vPezHy5inPQ000yY1F/VcUGc7DaNBJjiNf00hFEHKtkKxT9PIbhhp4fVU9
Tw4asb/2BCoAmjtU2/3wozYW/HZ/iUjVs9FY7kU8zzj+2VcLYvCiAgM56YV840DtGX/y
arsQ==
X-Gm-Message-State: AOJu0YzFGtZmjVWerxj+dIJJ9tRr7M3Ca6/sa/1dRNIqC+66whRR1dyX
FRPC9j/deludpfIY4Q5qb8Sv6Bc6Pf4=
X-Google-Smtp-Source: AGHT+IF9N2InQ8zL24fPQeAPDa8u1gc19wxOw8bn+x9G1xv5tPPH1k+YF6UyfnXHbwtr+MWN/yO3BQ==
X-Received: by 2002:a05:600c:35cc:b0:401:7d3b:cc84 with SMTP id
r12-20020a05600c35cc00b004017d3bcc84mr9705428wmq.0.1698166042356;
Tue, 24 Oct 2023 09:47:22 -0700 (PDT)
Received: from localhost.localdomain ([193.48.40.241])
by smtp.gmail.com with ESMTPSA id
l23-20020a1c7917000000b004063cced50bsm12256895wme.23.2023.10.24.09.47.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 24 Oct 2023 09:47:21 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 66586 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: lvm2: Remove systemd rule.
Date: Tue, 24 Oct 2023 18:47:14 +0200
Message-Id: <9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
X-Debbugs-CC: ludo@HIDDEN
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66586
Cc: Yann Dupont <Yann.Dupont@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Yann Dupont <Yann.Dupont@HIDDEN>
Fixes <https://issues.guix.gnu.org/65177>.
Reported by Adrien 'neox' Bourmault <neox@HIDDEN>.
* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 20 ++++++++++++++++++++
3 files changed, 22 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 43145caf80..4c8800b274 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1627,6 +1627,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f02577d2d5..c618651553 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4494,6 +4494,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..440559b96d
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,20 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
base-commit: f3714b3d5f51aced4b31447c42d5e89c75e3079f
--
2.38.1
ludo@HIDDEN, guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.Received: (at 66586) by debbugs.gnu.org; 23 Oct 2023 21:52:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 23 17:52:46 2023 Received: from localhost ([127.0.0.1]:52086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qv2qs-0008H1-0f for submit <at> debbugs.gnu.org; Mon, 23 Oct 2023 17:52:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1qv2qq-0008Gm-Bu for 66586 <at> debbugs.gnu.org; Mon, 23 Oct 2023 17:52:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1qv2qG-0006f1-8Q; Mon, 23 Oct 2023 17:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qfEH0stfXAd7MQj0HjwFlBqoR6BQy7PEdolk6+WUCF8=; b=q5sHp6ZeTiZVjZaFLp8n vFHj4Dxxs5d+PtTCMsSRP5QOGqtrqs1OGyEdCh33gE0eHtt/dIbCfIh+vuhPStTP6YGvB/DL9YF3P /4dSG3oQAC3TVrtvgGAkwcqClA8nqygRuM2TdEzyPkXY1jpfOfbfz1KPXLiwBJy0D7fUoADVF45Ik GDOkDi8nSUTnt8EDuop/+UZr1XLzQLIK1aVafFqtxUNaiRojz3/o/ZxzDpz7HeSTRuNTb8XbVtJgn xgxrHT2VBenE93XV5VOLGQ9lIJZGaz/SZjks5bhnvi96j+Xn5ZLY7WiHpd36RF6FszHo6Ct/EZPG7 y0cCLT2Ycye+ww==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: [bug#66586] [PATCH] gnu: lvm2: Remove systemd rule. In-Reply-To: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> (Simon Tournier's message of "Tue, 17 Oct 2023 10:57:36 +0200") References: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN> Date: Mon, 23 Oct 2023 23:52:05 +0200 Message-ID: <87bkcpdn22.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66586 Cc: 66586 <at> debbugs.gnu.org, Yann Dupont <Yann.Dupont@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Leo Famulari <leo@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi! Simon Tournier <zimon.toutoune@HIDDEN> skribis: > From: Yann Dupont <Yann.Dupont@HIDDEN> > > Fixes <https://issues.guix.gnu.org/65177>. > Reported by Adrien 'neox' Bourmault <neox@HIDDEN>. > > * gnu/packages/patches/lvm2-no-systemd.patch: New file. > * gnu/packages/linux.scm (lvm2)[source]: Apply patch. > * gnu/local.mk: Register new patch. One minor nit: > +++ b/gnu/packages/patches/lvm2-no-systemd.patch > @@ -0,0 +1,22 @@ > +Fixes <https://issues.guix.gnu.org/65177>. > + > +Since lvm2 2.03.14, the included udev rules use systemd-run to run vgcha= nge > +and activate the volume group. lvm2 was updated recently from 2.03.11 to > +2.03.21, then 2.03.22, and probably started exhibiting this behavior the= n. It > +removes the indirection through systemd-run and directly run vgchange. I propose to change this paragraph so that it is self-contained, like: Run =E2=80=98vgchange=E2=80=99 directly instead of attempting to run it v= ia =E2=80=98systemd-run=E2=80=99 as the udev rules included in lvm2 >=3D 2.0= 3.14 do. LGTM with a change along these lines! Ludo=E2=80=99.
guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 17 Oct 2023 08:58:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 17 04:58:22 2023
Received: from localhost ([127.0.0.1]:58560 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qsfu9-0006I4-L5
for submit <at> debbugs.gnu.org; Tue, 17 Oct 2023 04:58:22 -0400
Received: from lists.gnu.org ([2001:470:142::17]:36986)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1qsfu5-0006Hm-UX
for submit <at> debbugs.gnu.org; Tue, 17 Oct 2023 04:58:20 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1qsftb-0003N1-77
for guix-patches@HIDDEN; Tue, 17 Oct 2023 04:57:47 -0400
Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1qsftZ-0002fn-0n
for guix-patches@HIDDEN; Tue, 17 Oct 2023 04:57:46 -0400
Received: by mail-lf1-x136.google.com with SMTP id
2adb3069b0e04-5047bc00f1eso1744110e87.1
for <guix-patches@HIDDEN>; Tue, 17 Oct 2023 01:57:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1697533063; x=1698137863; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=bqDNHgpyV/Sf/RvWRaKAVQ4QpfXlAEmR5bATHW425CQ=;
b=APlRr1VnOYjCR/6I+U0loPwytToFMfhtmwGYToIrJoBRVH9Qce5muJWdxsleetQ5av
yDcdPpTTJ73iGXEOOayzgkyBrPZ/Nu+ZiK6gWsTtJohgjphYTS8E1HkoXCjOWVqwoBS2
hYGctNu7Gp0jx1Xg9J9abSz6cxrtVTvu9pzghNowMzG3Pdz0vGGHhxHzW8phD+lzZptM
nv764eayOEsgdM/VU9FHxFioh3F0bVeZ9q3iLSts4DZ23PCVIUH133t5WsODOZU9YOPq
zOBeMYWaGABjznmkZroURKX0T15pm0mXlY/6dfLR3ri2HGVGyLNa5iRKH9a7+cto0zTm
sM+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697533063; x=1698137863;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=bqDNHgpyV/Sf/RvWRaKAVQ4QpfXlAEmR5bATHW425CQ=;
b=c/KNif8q0GpU1ZlI18YJW9GKRBGjYCcZW9Lbgdm77JXBtgNoMtYFajhXOVZmczncbU
o0ZHUXdRQZKomPlqTZzoKgd6M/liK1GZtD6vCjE+mhDATEmpGn7wpZoVpvnVK1AjhKfC
qFVjmCC64Hjejb/7bm9WqSp43Vc0f8k7ZZlPt7GmBfFfdIEe7i18reQzMXgOaJSPo+lB
BsNGwdnYXxmEnwNKZKio1bof389LLIqv4oDJG/F+bwz+A4rI9i/bq5GHVVghjWUqmhb3
eN/Fd933sVFW7TbVtQRATWa7kwAV9WxJN3zeY681Wd177STMcxIAsXBJHN+0YZZve2FL
87Zg==
X-Gm-Message-State: AOJu0YxVqrl41loXnphxJL1VKIFHutzH6P53ZIbzE1LYzC8wUMPpWpuE
u86wnXbgLmzqcv3xKCVEyKe81Qsp6x8=
X-Google-Smtp-Source: AGHT+IFujzP7ogrpZw4i+sA108jLQuEAjRvch7JWstaXLYvZE1FIBLzyLv6tLHKKPb129HwSYwilJg==
X-Received: by 2002:a05:6512:3e04:b0:507:b911:f86a with SMTP id
i4-20020a0565123e0400b00507b911f86amr1253262lfv.2.1697533062492;
Tue, 17 Oct 2023 01:57:42 -0700 (PDT)
Received: from localhost.localdomain ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
by smtp.gmail.com with ESMTPSA id
n35-20020a05600c502300b004064ac107cfsm1307290wmr.39.2023.10.17.01.57.41
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 17 Oct 2023 01:57:41 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: lvm2: Remove systemd rule.
Date: Tue, 17 Oct 2023 10:57:36 +0200
Message-ID: <716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-CC: Yann Dupont <Yann.Dupont@HIDDEN>,
Adrien 'neox' Bourmault <neox@HIDDEN>,
Josselin Poiret via Bug reports for GNU Guix <bug-guix@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>
X-Debbugs-Cc: Leo Famulari <leo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::136;
envelope-from=zimon.toutoune@HIDDEN; helo=mail-lf1-x136.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Yann Dupont <Yann.Dupont@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
From: Yann Dupont <Yann.Dupont@HIDDEN>
Fixes <https://issues.guix.gnu.org/65177>.
Reported by Adrien 'neox' Bourmault <neox@HIDDEN>.
* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 22 ++++++++++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch
Hi,
Here is the patch from Yann sent in patch 65177 [1]. I have just reformatted
it and preprare it for merging if it is correct. I know nothing about udev.
1: https://issues.guix.gnu.org/65177#3
Cheers,
simon
diff --git a/gnu/local.mk b/gnu/local.mk
index daacd786a7..3d74c3e228 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1625,6 +1625,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 6bb6d62182..6882244e92 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4527,6 +4527,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..46b4dcffbb
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,22 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
+and activate the volume group. lvm2 was updated recently from 2.03.11 to
+2.03.21, then 2.03.22, and probably started exhibiting this behavior then. It
+removes the indirection through systemd-run and directly run vgchange.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
base-commit: b437896e87a51cc610388d4c462893652dd773e6
--
2.38.1
Simon Tournier <zimon.toutoune@HIDDEN>:leo@HIDDEN, me@HIDDEN, guix-patches@HIDDEN.
Full text available.leo@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#66586; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.