Simon Tournier <zimon.toutoune@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 66762) by debbugs.gnu.org; 27 Oct 2023 09:45:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 27 05:45:36 2023
Received: from localhost ([127.0.0.1]:35107 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qwJPJ-0000zE-4t
for submit <at> debbugs.gnu.org; Fri, 27 Oct 2023 05:45:36 -0400
Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:39249)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1qwJPC-0000yM-JX
for 66762 <at> debbugs.gnu.org; Fri, 27 Oct 2023 05:45:30 -0400
Received: by mail-wm1-x32c.google.com with SMTP id
5b1f17b1804b1-40837396b1eso1588355e9.1
for <66762 <at> debbugs.gnu.org>; Fri, 27 Oct 2023 02:44:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1698399889; x=1699004689; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:from:to:cc:subject:date:message-id:reply-to;
bh=zFY1OJopo11OnLLRG+K0oUSaLOrpZevFoeEF/vQ/FRY=;
b=Ru1gUcJOu8QudctdRhuzMtyqotd5+YYAq8/BGibFv2UKHAWNcC3vhqyFZlfKTGh/ky
HIM4op3T4TddjBq9pVMk8sDKktknH85M8MueGMha4MvSeJorWR8TzMjcOR/RZqmXE0c2
2qUwUVW6QyNe6+baZOslEOz6GvzifiwIH4AMAJRBET7TjRPg4JiDHWWlzB5ZCAo4ICSN
7PXcHeP0+bTvPyQX/JzzfwOO2CHmISg0WGtuWoYSbqtOMZ4YJs5xz5q2XpUjYt6s2LlA
kKLSxZX2yYyXU0pLh10uVRHPhYJmzCwPxPDv/u2GZPuJaq00yAzJOQE83uT5L0YNqQBJ
QScg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1698399889; x=1699004689;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=zFY1OJopo11OnLLRG+K0oUSaLOrpZevFoeEF/vQ/FRY=;
b=EDlJc0W3RhpFDmW/ZQ31gD9yX4w6aXTmr5mw1+9kl5DF81fD0GrOxAS9VUbHrgiqAN
yTYUeU41XZ79pLmbTHPPACYLtbuMowFQE8K1q4u67AJrnjmPb4C1Yho03VKaOgm8dI38
hg2T6QlYdog+WP68HuO5HL+04j4XztrTDv7uotAKCDwcN8HUWMETTog1h9+hF1QsuKCE
hSuDAaRQN59lB4Uu4SlDGZIMnjGYaNIeJcL99rcYgQTNI9Ob08xbVsT3+tIWbEcCQAkD
ay0Moh8/b2DZtukwQaGCCrlDvjAXauFqGONP40XeJ9stiyB273bUXJlRjv13cQ3P320J
gYKg==
X-Gm-Message-State: AOJu0YywNhiZAFyiUEucLNMICbbhHveLig0j+eCPS4AKWukAAgbNtfnL
osIGco6Q4xaUIcDLOJ+N0RX1orXMuYA=
X-Google-Smtp-Source: AGHT+IFVo3cQD4vRklMLE5ryGzVecdLXslVoTljyuRvT6V8INvV4LUsSnh37kxdjMHwJcFdKBB13Kw==
X-Received: by 2002:a05:600c:418a:b0:3fe:d637:7b25 with SMTP id
p10-20020a05600c418a00b003fed6377b25mr1782940wmh.0.1698399889124;
Fri, 27 Oct 2023 02:44:49 -0700 (PDT)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
by smtp.gmail.com with ESMTPSA id
h9-20020a05600c314900b0040849ce7116sm4667505wmo.43.2023.10.27.02.44.47
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 27 Oct 2023 02:44:47 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Kyle Andrews <kyle@HIDDEN>, 66762 <at> debbugs.gnu.org
Subject: Re: bug#66762: emacs-ess test fails
In-Reply-To: <87r0lhcsbf.fsf@HIDDEN>
References: <87r0lhcsbf.fsf@HIDDEN>
Date: Fri, 27 Oct 2023 11:22:53 +0200
Message-ID: <861qdga07m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66762
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hi,
On Thu, 26 Oct 2023 at 15:17, Kyle Andrews <kyle@HIDDEN> wrote:
> The emacs-ess package no longer install as of guix revision
> 33f5b74. It's dependency emacs-julia-mode fails to build.
>
> $ guix shell --keep-failed --pure emacs emacs-julia-mode
>
> According to the build log, the test julia--test-end-of-defun-nested-2
> fails.
Reported upstream:
https://github.com/JuliaEditorSupport/julia-emacs/issues/199
It comes from a discrepancy introduced by Emacs 29; also reported:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66763
Well, I fixed the build of emacs-julia-mode. See attached.
But emacs-ess is not passing. I have updated ESS to the most recent
revision, added phases for skipping the tests requiring network but it
still fails:
--8<---------------cut here---------------start------------->8---
Ran 187 tests, 176 results as expected, 6 unexpected, 5 skipped
(2023-10-27 01:12:40+0000, 17.661319 sec) 2 expected failures
6 unexpected results:
FAILED ess-eval-line-test FAILED ess-eval-region-test FAILED
ess-mock-remote-process FAILED ess-r-load-ESSR-github-fetch-no FAILED
ess-set-working-directory-test FAILED ess-test-r-startup-directory
--8<---------------cut here---------------end--------------->8---
To be continued=E2=80=A6
Cheers, simon
--=-=-=
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
filename=0001-gnu-emacs-julia-mode-Exclude-failing-test-introduced.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: p1.patch
From 5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7 Mon Sep 17 00:00:00 2001
Message-ID: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.=
toutoune@HIDDEN>
From: Simon Tournier <zimon.toutoune@HIDDEN>
Date: Fri, 27 Oct 2023 01:41:26 +0200
Subject: [PATCH 1/2] gnu: emacs-julia-mode: Exclude failing test introduced=
by
Emacs 29.
* gnu/packages/emacs-xyz.scm (emacs-julia-mode)[arguments]: Add phases befo=
re
check that marks the test as expected failed.
Change-Id: I1da1077a7e7e077392458243b2d3cd44592ebd45
---
gnu/packages/emacs-xyz.scm | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0bf3096216..7511a2de21 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -95,7 +95,7 @@
;;; Copyright =C2=A9 2021 Alexey Abramov <levenson@HIDDEN>
;;; Copyright =C2=A9 2021 Xinglu Chen <public@HIDDEN>
;;; Copyright =C2=A9 2021, 2022 Stefan Reich=C3=B6r <stefan@HIDDEN>
-;;; Copyright =C2=A9 2021, 2022 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright =C2=A9 2021, 2022, 2023 Simon Tournier <zimon.toutoune@gmail=
.com>
;;; Copyright =C2=A9 2021 Eugene Klimov <lipklim@HIDDEN>
;;; Copyright =C2=A9 2021 Zheng Junjie <873216071@HIDDEN>
;;; Copyright =C2=A9 2021 David Dashyan <mail@HIDDEN>
@@ -13550,7 +13550,17 @@ (define-public emacs-julia-mode
`(#:tests? #t
#:test-command '("emacs" "--batch"
"-l" "julia-mode-tests.el"
- "-f" "ert-run-tests-batch-and-exit")))
+ "-f" "ert-run-tests-batch-and-exit")
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'fix-test
+ (lambda _
+ (substitute* "julia-mode-tests.el"
+ ;; The test started failing with Emacs 29; see
+ ;; <https://github.com/JuliaEditorSupport/julia-emacs/iss=
ues/199>
+ ;; and discrepancy reported <https://issues.guix.gnu.org/=
66763>.
+ (("julia--test-end-of-defun-nested-2.*" all)
+ (string-append all " :expected-result :failed\n"))))))))
(home-page "https://github.com/JuliaEditorSupport/julia-emacs")
(synopsis "Major mode for Julia")
(description "This Emacs package provides a mode for the Julia
base-commit: 6d7e181ba18d11c92409a93936025fb46b9c8171
prerequisite-patch-id: b9d5f8d81be6974fb52062c781924fb5387d4602
prerequisite-patch-id: bee3c38a1dbcf56e8c3d58891dc317d8a5901be8
prerequisite-patch-id: 08e88430d6fdc51aa4afa2891fddae9865a64a7c
prerequisite-patch-id: f276d7bebe3fdcda36e27fd027fd75d1c2e6369c
prerequisite-patch-id: ef6db31909314fd83b53b6e610547064a14d9551
prerequisite-patch-id: 4311408226f9b085a893bc9c32cce00611ba8401
--=20
2.41.0
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0002-gnu-emacs-julia-mode-Update-to-0.4-0.7a8c868.patch
Content-Description: p2.patch
From 9b8715d29fc1543b9d624f26e8946c5a919b4946 Mon Sep 17 00:00:00 2001
Message-ID: <9b8715d29fc1543b9d624f26e8946c5a919b4946.1698398428.git.zimon.toutoune@HIDDEN>
In-Reply-To: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.toutoune@HIDDEN>
References: <5bd2f8c9b6a8065890b4ae38ec78657bcb7ef9a7.1698398428.git.zimon.toutoune@HIDDEN>
From: Simon Tournier <zimon.toutoune@HIDDEN>
Date: Fri, 27 Oct 2023 01:51:18 +0200
Subject: [PATCH 2/2] gnu: emacs-julia-mode: Update to 0.4-0.7a8c868.
* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.7a8c868.
[arguments]: Use G-exp.
Change-Id: I3d06dbe824ce989400d801118e8bca496ae4b3e2
---
gnu/packages/emacs-xyz.scm | 40 +++++++++++++++++++++-----------------
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7511a2de21..471d938910 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -13532,40 +13532,44 @@ (define-public emacs-eprime
(license license:gpl3+))))
(define-public emacs-julia-mode
+ ;; Last release was in March 2020.
+ (let ((commit "7a8c868e0d3e51ba4a2c621ee22ca9599e0e4bbb")
+ (revision "0"))
(package
(name "emacs-julia-mode")
- (version "0.4")
+ (version (git-version "0.4" revision commit))
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/JuliaEditorSupport/julia-emacs")
- (commit version)))
+ (commit commit)))
(file-name (git-file-name name version))
(sha256
(base32
- "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99"))))
+ "0xwd4kq69ray6bk8hwjxnqf7myc3mn36chc2l9jn7a0x1f8x6k10"))))
(build-system emacs-build-system)
(arguments
- `(#:tests? #t
- #:test-command '("emacs" "--batch"
- "-l" "julia-mode-tests.el"
- "-f" "ert-run-tests-batch-and-exit")
- #:phases
- (modify-phases %standard-phases
- (add-before 'check 'fix-test
- (lambda _
- (substitute* "julia-mode-tests.el"
- ;; The test started failing with Emacs 29; see
- ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/199>
- ;; and discrepancy reported <https://issues.guix.gnu.org/66763>.
- (("julia--test-end-of-defun-nested-2.*" all)
- (string-append all " :expected-result :failed\n"))))))))
+ (list
+ #:tests? #t
+ #:test-command #~(list "emacs" "--batch"
+ "-l" "julia-mode-tests.el"
+ "-f" "ert-run-tests-batch-and-exit")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-before 'check 'fix-test
+ (lambda _
+ (substitute* "julia-mode-tests.el"
+ ;; The test started failing with Emacs 29; see
+ ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/199>
+ ;; and discrepancy reported <https://issues.guix.gnu.org/66763>.
+ (("julia--test-end-of-defun-nested-2.*" all)
+ (string-append all " :expected-result :failed\n"))))))))
(home-page "https://github.com/JuliaEditorSupport/julia-emacs")
(synopsis "Major mode for Julia")
(description "This Emacs package provides a mode for the Julia
programming language.")
- (license license:expat)))
+ (license license:expat))))
(define-public emacs-julia-repl
(package
--
2.41.0
--=-=-=--
bug-guix@HIDDEN:bug#66762; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 26 Oct 2023 15:33:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 26 11:33:41 2023 Received: from localhost ([127.0.0.1]:34340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qw2Mf-00037B-NY for submit <at> debbugs.gnu.org; Thu, 26 Oct 2023 11:33:41 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kyle@HIDDEN>) id 1qw2Mc-00036r-CM for submit <at> debbugs.gnu.org; Thu, 26 Oct 2023 11:33:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <kyle@HIDDEN>) id 1qw2M2-00048C-3V for bug-guix@HIDDEN; Thu, 26 Oct 2023 11:33:02 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <kyle@HIDDEN>) id 1qw2Lz-0002NN-Rw for bug-guix@HIDDEN; Thu, 26 Oct 2023 11:33:01 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4591E240101 for <bug-guix@HIDDEN>; Thu, 26 Oct 2023 17:32:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698334375; bh=U+riTmoYDxeoo7eXwTHMnqJ3z+U02NZETEWY7A+TuUY=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=MuHvSi7DMAiBbTBAtayQI7yx56z/4if7BFV9mhjr20J2fgXgG3BSB+MVb7KeY7Sp1 rfhVpctSTuZW9RBhlCR/CtMhdpjRhl3YwcEt1ut8Bblvw/OIkUV6L4BtHq3usCp2FW 7WKx3CPwrm0vCBvHmodtFCVFgjguDgVBj7gTj6j5rOf8bbPSnA+R95Z95KG46pNPbt Dk4z7MP6UEUkWnqI5vFKsOpIKnGPN2IHd8HP9vc82QKlf0F7Y26b8pamN5jotTLXE1 3qe1yunY+6dNNIVvNofIrx3FF4l0jRwNKYO5+dh5TsEUoLZ5weOtjVyoWb/5zubcbH 0nxqMVbFYYVZA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SGVDQ2r4Gz9rxL for <bug-guix@HIDDEN>; Thu, 26 Oct 2023 17:32:54 +0200 (CEST) From: Kyle Andrews <kyle@HIDDEN> To: bug-guix@HIDDEN Subject: emacs-julia-mode test fails Date: Thu, 26 Oct 2023 15:17:29 +0000 Message-ID: <87r0lhcsbf.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=kyle@HIDDEN; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) The emacs-ess package no longer install as of guix revision 33f5b74. It's dependency emacs-julia-mode fails to build. $ guix shell --keep-failed --pure emacs emacs-julia-mode According to the build log, the test julia--test-end-of-defun-nested-2 fails.
Kyle Andrews <kyle@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#66762; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.