GNU bug report logs - #66894
[PATCH] gnu: Add rivercarro layout generator for river wayland compositor

Previous Next

To reply to this bug, email your comments to 66894 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alec Barreto <mrh57 <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Alec Barreto <mrh57 <at> posteo.net>
Subject: [PATCH] gnu: Add rivercarro layout generator for river wayland
 compositor
Date: Thu,  2 Nov 2023 06:15:26 +0000

Change-Id: Id9d1d808fae3ac6e0469cbe294a9a3652ce19101
---
 gnu/packages/zig-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
index 200b5c9940..540c96860b 100644
--- a/gnu/packages/zig-xyz.scm
+++ b/gnu/packages/zig-xyz.scm
@@ -70,6 +70,31 @@ (define-public river
 directly from a tty using KMS/DRM.")
     (license license:gpl3)))
 
+(define-public rivercarro
+  (package
+    (name "rivercarro")
+    (version "0.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+	     (url "https://git.sr.ht/~novakane/rivercarro")
+	     (commit (string-append "v" version))
+	     (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+	(base32 "1a852hkakha3f5djnd8jrmkcq0xcdxbcbidr2kkfbqrhni9p33cl"))))
+    (build-system zig-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases (modify-phases %standard-phases (delete 'validate-runpath))))
+    (native-inputs (list pkg-config wayland wayland-protocols))
+    (home-page "https://git.sr.ht/~novakane/rivercarro")
+    (synopsis "A slightly modified version of rivertile layout generator for river")
+    (description
+     "A modified version of rivertile which adds: monocle layout, gaps rather than padding, gap size modification at run time, and smart gaps.")
+    (license license:gpl3)))
+
 (define-public tigerbeetle
   (package
     (name "tigerbeetle")

base-commit: 0647f308b46b7ba7aa136068712f8d82d69d1a35
-- 
This is my first git email patch, so pardon any mistakes.
Rivercarro is a simple package which adds additional ways to generate layouts for the river wayland compositor.
This version, 0.2.1, is not the newest version, it is about 9 months old. The newest version, 0.3.0, requires zig 0.11 to build, but the newest version of zig packaged for guix is 0.10. I would have updated zig mysmelf first, but the move from zig 0.10 -> 0.11 is rather complicated. It's unlikely anyone will update zig for guix in the near future. I was going to package rivercarro before then at least for myself, so I figured I'd do the checks and submit it.
It builds reproducibly and without error on my machine (x86_64). I also use it daily and have encountered no issues.

Message #8 received at 66894 <at> debbugs.gnu.org (full text, mbox):

From: Alec Barreto <mrh57 <at> posteo.net>
To: 66894 <at> debbugs.gnu.org
Cc: Alec Barreto <mrh57 <at> posteo.net>
Subject: [PATCH v2] gnu: Add rivercarro layout generator for river wayland
 compositor
Date: Sat,  4 Nov 2023 19:48:03 +0000

Linting issues should be fixed.

The build is succeeding on x86 but failing on arm.
This seems to be a zig issue which has since been fixed in zig 0.11 - https://github.com/ziglang/zig/issues/16800

However as mentioned guix only has zig 0.10 and probably won't be getting zig 0.11 any time soon.

Change-Id: Id9d1d808fae3ac6e0469cbe294a9a3652ce19101

gnu: fix formatting according to =guix lint=

Change-Id: Id61ff3c16f374e7211df2446ad3c6f09598f8981
---
 gnu/packages/zig-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
index 200b5c9940..48ccbf32d8 100644
--- a/gnu/packages/zig-xyz.scm
+++ b/gnu/packages/zig-xyz.scm
@@ -70,6 +70,35 @@ (define-public river
 directly from a tty using KMS/DRM.")
     (license license:gpl3)))
 
+(define-public rivercarro
+  (package
+    (name "rivercarro")
+    (version "0.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.sr.ht/~novakane/rivercarro")
+             (commit (string-append "v" version))
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1a852hkakha3f5djnd8jrmkcq0xcdxbcbidr2kkfbqrhni9p33cl"))))
+    (build-system zig-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases (modify-phases %standard-phases
+                  (delete 'validate-runpath))))
+    (native-inputs (list pkg-config wayland wayland-protocols))
+    (home-page "https://git.sr.ht/~novakane/rivercarro")
+    (synopsis
+     "Slightly modified version of rivertile layout generator for river")
+    (description
+     "Modified version of rivertile which adds:
+monocle layout, gaps rather than padding,
+gap size modification at run time, and smart gaps.")
+    (license license:gpl3)))
+
 (define-public tigerbeetle
   (package
     (name "tigerbeetle")

base-commit: e3f318f0489322c4c9b5964f03a8b063a7bfbebd
-- 
2.41.0

Message #11 received at 66894 <at> debbugs.gnu.org (full text, mbox):

From: Alec Barreto <mrh57 <at> posteo.net>
To: 66894 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add rivercarro layout generator for river wayland
 compositor
Date: Tue, 07 Nov 2023 02:51:48 +0000

Also note that the package has no tests (hence why set to =#f=), and
also that the removal of the =validate-runpath= check comes from river itself (see
the definition of the river package for more info).

Message #14 received at 66894 <at> debbugs.gnu.org (full text, mbox):

From: Alec Barreto <mrh57 <at> posteo.net>
To: 66894 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add rivercarro layout generator for river wayland
 compositor
Date: Mon, 13 Nov 2023 18:46:08 +0000

Any thoughts on this?

Message #17 received at 66894 <at> debbugs.gnu.org (full text, mbox):

From: Alec Barreto <mrh57 <at> posteo.net>
To: 66894 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add rivercarro layout generator for river wayland
 compositor
Date: Thu, 22 Feb 2024 02:51:36 +0000

friendly ping

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.