GNU logs - #66994, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66994: 30.0.50; Emacs hangs in Todo mode when moving an item to another todo file
Resent-From: Stephen Berman <stephen.berman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 07 Nov 2023 23:15:01 +0000
Resent-Message-ID: <handler.66994.B.169939886912411 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66994 <at> debbugs.gnu.org
From: Stephen Berman <stephen.berman@HIDDEN>
Date: Wed, 08 Nov 2023 00:13:36 +0100
Message-ID: <877cmt17j3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
UI-OutboundReport: notjunk:1;M01:P0:rIhjfrL2yH4=;7VsM1IM8D4VvnCtduqXxO7A0OT5
 +pXi8UBP7UjKA/uKD6Ccv3LuoC2fWAUBSDnWXAEs774os9hX5ZDJWjBST4AyffiSRU/4G4jeq
 yHp5w9vBqq+zSSUuf10wmouBY6n0I38vugNiW7siHIfpo6qbTauBkKaTFmbXFGujzdSLt6K5B
 az5Eiobgwzjx/k21FOoivPLzbdoAPz4TdXEXJ6i2NSCijXWlUMuA9PcdLh/KtUeZvSfIrRg/R
 dWYMKhPOWpoVLGb4T62lzl43UjghSJU9R74631X9IhQMtfzylMTCf8rABLw0uVZIP4Og5kNZI
 E4ml0BIvtKV/I2D1iGRJ8l3KwmNoWJ993RomsXoOTZkLMLuwMmXvJedpmV4j5qke8YQXa4nkf
 jZTlMGSEEPA2TkjU/DzfnkxiMctQ0FJZA490irbkQxfxLzRlDmcY4qvIctCUsh9deYXY7X8Ep
 /gb2Fl41HOlNlecRUlCOFWrNeG0jZf/8jZq2Iinu6HqqCDxh5F2OrNN6cdxjLuvXTb4Ce8MGj
 mzk2V59ps6DKMA8dx2Ya+bjfzsS1xccatBdnggYSZY57RZXqCx7YcO+1klAWP3h330MRcmdiR
 69aq1tbYkEXUmQ/CnYkI+Jjt+bzrCsKEf9KMVUrgC56lb+0EjbG2LWYhl+bg1iJV/+Jpzw1ir
 0N+YCKjJCq8iM7x3PUlP24ohOHrHfgMW6ndlnd01W9IU23AUQoz1JKfW4Tj8iNzNB+xUciQ2f
 d/vsu8qk8RZkpwcLuEs2ec/yAYTF97lbH4psgGoCO8Q7GKzgdO2qgNngl3uZ7y4XRsb+gJP1V
 ZbJbgcvKTj3gAZR3F6Lv8FpxcTc97ns5lUPlcmRFsC/rRx+ye7G6d9LamrCNANqf7n2qsQETp
 SpApaFGIsvGjiZQ9eNSuUkKzU+5/fN7yjaktLXr4mUj5AgSmuAqMG1Rq3j5bFrziAqDPCC2wo
 tozYcZ4PQ+UKHaOnGzvXmzQebKk=
Received-SPF: pass client-ip=212.227.15.18;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-Spam_score_int: -12
X-Spam_score: -1.3
X-Spam_bar: -
X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SORBS_WEB=1.5,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 4.5 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  If you have at least two files created using todo-mode, you
 can move an item from a category in one todo file to a category in another
 todo file by typing `C-u m' with point on the item to be moved. B [...] 
 Content analysis details:   (4.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.5 RCVD_IN_SORBS_WEB      RBL: SORBS: sender is an abusable web server
 [94.134.196.128 listed in dnsbl.sorbs.net]
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (stephen.berman[at]gmx.net)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 2.0 SPOOFED_FREEMAIL       No description available.
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  If you have at least two files created using todo-mode, you
    can move an item from a category in one todo file to a category in another
    todo file by typing `C-u m' with point on the item to be moved. B [...] 
 
 Content analysis details:   (1.5 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  1.5 RCVD_IN_SORBS_WEB      RBL: SORBS: sender is an abusable web server
                             [94.134.196.128 listed in dnsbl.sorbs.net]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (stephen.berman[at]gmx.net)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

--=-=-=
Content-Type: text/plain

If you have at least two files created using todo-mode, you can move an
item from a category in one todo file to a category in another todo file
by typing `C-u m' with point on the item to be moved.  But if the file
the item is to be moved to is not yet visiting a buffer in todo-mode
when the command is invoked, this results in an infinite loop.  The
patch below prevents this and allows the move to succeed.  For those
interested, an analysis of the bug follows.

The call chain leading to the hang is this: todo-move-item ->
todo-set-item-priority -> todo-marked-item-p -> todo-get-overlay ->
todo-item-start.  The latter function tests conditions under which point
is not on an item; if these tests fail, a loop does a search backwards
in the file to find the item start.  But the tests overlook the case at
hand, where a todo file is loaded into a buffer but todo-mode is not yet
set: then point is at the start of the file, whose first line contains
metadata that is hidden in todo-mode.  Since this case is not tested and
the other tests fail, the backwards search begins, but since point is
already at position 1, it is impossible to find an item start, so the
loop is never exited.

Looking through the commit history, it seems this bug has existed since
I first added the code, which was before my rewrite of todo-mode.el was
merged into Emacs.  Evidently I had never tested precisely this use
case.  (One reason for that may be that it is also possible to move an
item between files by typing just `m', when the goal file's name is in
the list `todo-category-completions-files'; but in this case the file is
set to todo-mode before the movement, so the condition triggering the
hang is not met.  I have often used this functionality, but evidently
not the movement with `C-u m'.)  But I now encountered this bug while
testing changes in todo-mode.el to support changing the format of item
date headers, as announced in bug#66395.

Given that it's an old bug that has apparently never been triggered in
normal use of todo-mode, I have no problem committing the fix to master.
But since an infinite loop is always nasty and the fix is
straightforward and AFAICT safe, I think it's suitable for the release
branch.  I'll wait for the maintainers' decision.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2023-11-06 built on strobelfs2
Repository revision: bf81706988f6b1b9d6e8033c8227f0129e04ef03
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Linux From Scratch r12.0-63

Configured using:
 'configure -C --with-xwidgets 'CFLAGS=-Og -g3'
 PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM
XINPUT2 XPM XWIDGETS GTK3 ZLIB


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Content-Description: todo-item-start patch

diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el
index 093ea0e22b6..86bf3afbce7 100644
--- a/lisp/calendar/todo-mode.el
+++ b/lisp/calendar/todo-mode.el
@@ -5277,7 +5277,9 @@ todo-item-start
            ;; Point is on done items separator.
            (save-excursion (beginning-of-line) (looking-at todo-category-done))
 	   ;; Buffer is widened.
-	   (looking-at (regexp-quote todo-category-beg)))
+	   (looking-at (regexp-quote todo-category-beg))
+           ;; With `C-u m' to a file that is then loaded into a buffer.
+	   (= (point) 1))
     (goto-char (line-beginning-position))
     (while (not (looking-at todo-item-start))
       (forward-line -1))

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stephen Berman <stephen.berman@HIDDEN>
Subject: bug#66994: Acknowledgement (30.0.50; Emacs hangs in Todo mode
 when moving an item to another todo file)
Message-ID: <handler.66994.B.169939886912411.ack <at> debbugs.gnu.org>
References: <877cmt17j3.fsf@HIDDEN>
X-Gnu-PR-Message: ack 66994
X-Gnu-PR-Package: emacs
Reply-To: 66994 <at> debbugs.gnu.org
Date: Tue, 07 Nov 2023 23:15:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 66994 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66994: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66994
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66994: 30.0.50; Emacs hangs in Todo mode when moving an item to another todo file
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Nov 2023 12:29:02 +0000
Resent-Message-ID: <handler.66994.B66994.16994465108689 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stephen Berman <stephen.berman@HIDDEN>
Cc: 66994 <at> debbugs.gnu.org
Date: Wed, 08 Nov 2023 14:27:33 +0200
Message-Id: <83r0l01lca.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <877cmt17j3.fsf@HIDDEN> (message from Stephen Berman on Wed, 08
 Nov 2023 00:13:36 +0100)
References: <877cmt17j3.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Stephen Berman <stephen.berman@HIDDEN>
> Date: Wed, 08 Nov 2023 00:13:36 +0100
> 
> Given that it's an old bug that has apparently never been triggered in
> normal use of todo-mode, I have no problem committing the fix to master.
> But since an infinite loop is always nasty and the fix is
> straightforward and AFAICT safe, I think it's suitable for the release
> branch.  I'll wait for the maintainers' decision.

I'm okay with installing this on the emacs-29 branch, but please
improve the comment to the line you added, so that it explains better
why this condition is needed and how it is related to "C-u m":

> -	   (looking-at (regexp-quote todo-category-beg)))
> +	   (looking-at (regexp-quote todo-category-beg))
> +           ;; With `C-u m' to a file that is then loaded into a buffer.
> +	   (= (point) 1))

Also, should this test point-min instead of literally 1?

Thanks.

Last modified: Wed, 8 Nov 2023 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.