GNU bug report logs - #67118
[PATCH] Change "tabulation" to "tabulation character" in linter & manual

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Ian Eure <ian@HIDDEN>; Keywords: patch; dated Sat, 11 Nov 2023 23:56:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 67118 <at> debbugs.gnu.org:


Received: (at 67118) by debbugs.gnu.org; 14 Jan 2024 00:48:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 19:48:43 2024
Received: from localhost ([127.0.0.1]:41371 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOog6-0003oi-PG
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:48:43 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45241)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ian@HIDDEN>) id 1rOog5-0003o4-GN
 for 67118 <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:48:41 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 7747F5C010E;
 Sat, 13 Jan 2024 19:48:37 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sat, 13 Jan 2024 19:48:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:message-id:mime-version:reply-to:subject:subject:to
 :to; s=fm1; t=1705193317; x=1705279717; bh=3cYZPfWp9kplLIGwsL5or
 lIJCkt4rVUebwRjk3Sm7IE=; b=wb9eNn28qh+Dmp9iasXQl17LTsOSoNY0u3Hd3
 LScbYu+9XncCGcBoDlFPVYpPpJitX92pFNexlzhfk983vWysI4x56NhiyItw8aR2
 7Rki2wATzYF5L/zkWFbSLGR6hl5Hs/UANnv1/swMxQREPRid4l3Lyx24AyKrOPnH
 BO2d7dRkS2R2FibsNfCOIDML8NVHKgUyxYDkx90HwsVB/WGjpCI1Jx2ucjaM5/tQ
 oBrbsU51N8cB0Jcl1q3eAsLtcGFXRLXIwF4cLBc9i+hQGVhwd4rivolXpHfs736p
 zmtJxM8LO/lAQBu2TO4OWdbURvEwkAnyfgOtt4BAMVMX5znjg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:message-id:mime-version:reply-to:subject:subject:to
 :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm2; t=1705193317; x=1705279717; bh=3cYZPfWp9kplLIGwsL5orlIJCkt4
 rVUebwRjk3Sm7IE=; b=9jgeev7kjxeFL/HJLmct8BtW/xbYML3yMNLCnkPXM0hv
 nnGwlYGTwer3z0kx6QJDQ229vr3/siBWhQShiLhuQruxLD/JneIp+JYSHYiM69mc
 GIwSFfNpCKG2VgYfzq9o48F1AAOrA9rynXKgJQOSWW5nNyfQbPNTLKtxFWVSICEv
 aDcpiB0vGFR7vPvCar+UUFgRpanrx+9Tcp4oOYPS1VB8HskLIP5pA6XCo3ZjUCst
 d33PjmzTuCWgvSSpbvkvjCr6YtcnX+ryZbXr+w5gOlcp/RuO4UKsBtdqVthk4mu+
 cjuZLaJMb48uQ+997VhM0L2d2NPDos6s56IKdQH3Xw==
X-ME-Sender: <xms:ZS-jZYylHDKFN2rgXX9skfnS2PtHmlvaERh1Aha1BnzAoAgs5rtw-w>
 <xme:ZS-jZcRg9F__O55g5lP9CeLmhMfPNF9i2jyusCwBUAB6v3DeV1tu5GzEqNqm8hQO4
 W9TJGhMl40laxar8A>
X-ME-Received: <xmr:ZS-jZaWjDY40OHnjrB4wqp7oRmL3defRLaK3cSXlB7EzGno46fymqYuifNXcB-nVWOGJ86h7BGixJuzS_TmAIhp1v4XMHmvYdAbzm73EsdzNXiAlaw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeikedgvdejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd
 ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht
 vheqnecuggftrfgrthhtvghrnhephfeiveeliedukeffhefhleeijedtveelleetgefggf
 ehkeeljeehtdeguddvvefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm
 rghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv
X-ME-Proxy: <xmx:ZS-jZWhX1PP0kvYVU31JufCJcgVsZopcPu3qL-KTETdK_d-ZlUNImQ>
 <xmx:ZS-jZaBrFJhceeOPr84S3ThSPocCSKp71exWOEoK3OBnaJ1zRNN6Pg>
 <xmx:ZS-jZXIvypEkW6VF1TDq8-VIHoTaFc_4fjz5Ltjcwvo-T9JOfdJCWw>
 <xmx:ZS-jZVqwixJ5jmwea-4oL1SJ3O5zqOyAAvY6lsi8bZwVd8tRtAK5eg>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 13 Jan 2024 19:48:36 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67118 <at> debbugs.gnu.org
Subject: [PATCH 1/1] Update text to refer to "tabulation character."
Date: Sat, 13 Jan 2024 16:48:33 -0800
Message-ID: <20240114004833.6152-1-ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67118
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Change-Id: I8de95149502e6cb1458e9f4102895395865d7000
---
 doc/guix.texi  | 2 +-
 guix/lint.scm  | 4 ++--
 tests/lint.scm | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index a648a106b3..bf9b1fd5aa 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -15513,7 +15513,7 @@ declare them as in this example:
 
 @item formatting
 Warn about obvious source code formatting issues: trailing white space,
-use of tabulations, etc.
+use of ASCII tabulation characters, etc.
 
 @item input-labels
 Report old-style input labels that do not match the name of the
diff --git a/guix/lint.scm b/guix/lint.scm
index 861e352b93..fbdf1e5b9f 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1774,12 +1774,12 @@ (define (check-haskell-stackage package)
 ;;;
 
 (define (report-tabulations package line line-number)
-  "Warn about tabulations found in LINE."
+  "Warn about ASCII tabulation characters found in LINE."
   (match (string-index line #\tab)
     (#f #f)
     (index
      (make-warning package
-                   (G_ "tabulation on line ~a, column ~a")
+                   (G_ "tabulation character (0x09) on line ~a, column ~a")
                    (list line-number index)
                    #:location
                    (location (package-file package)
diff --git a/tests/lint.scm b/tests/lint.scm
index a52a82237b..75afd3ecdb 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -1307,7 +1307,7 @@ (define (package-with-phase-changes changes)
 
 (test-assert "formatting: tabulation"
   (string-match-or-error
-   "tabulation on line [0-9]+, column [0-9]+"
+   "tabulation character \\(0x09\\) on line [0-9]+, column [0-9]+"
    (single-lint-warning-message
     (check-formatting (dummy-package "leave the tab here:	")))))
 
-- 
2.41.0





Information forwarded to guix-patches@HIDDEN:
bug#67118; Package guix-patches. Full text available.

Message received at 67118 <at> debbugs.gnu.org:


Received: (at 67118) by debbugs.gnu.org; 13 Jan 2024 21:28:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 16:28:21 2024
Received: from localhost ([127.0.0.1]:41243 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOlYD-0002sf-3p
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 16:28:21 -0500
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:34037)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ian@HIDDEN>) id 1rOlYB-0002sQ-8b
 for 67118 <at> debbugs.gnu.org; Sat, 13 Jan 2024 16:28:19 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 34B213200ABA;
 Sat, 13 Jan 2024 16:28:14 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Sat, 13 Jan 2024 16:28:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm1; t=1705181293;
 x=1705267693; bh=mqQE5roD3YnUjl+HETj1W5PV3Fu++OCZsYnrBtLuFIY=; b=
 s/KUG6rJXZSEbS0m0nt1hcaJRJNfVwwfuDmsSISaVBkH0qsT3Swh4aY7psD2z4Bh
 HHLAOFoejq2Xh+02On9GXR2luuelsENkGtD0LBzTussAQcZxv5hpU4BXrSwxGPlc
 cizkj7bUs/LvoknO0x+NJN5uiJ9Sqmq4jTYx5tfMh2cbnnP3erviw8DTRxI0UnFh
 e8UAA7L039hOuabrHw3Vsx1UWxmGqfKJwCThBz6ErGgRExVpeM8GWUvVyhlMhb8A
 D0hTAqq98rRoiMl232XRynQ2oWkHhaxvN/ksk3V4W02n1K+7LkmDwDAefmJXJzS0
 0S1Uzs7livS8DWei+Rnmlg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1705181293; x=
 1705267693; bh=mqQE5roD3YnUjl+HETj1W5PV3Fu++OCZsYnrBtLuFIY=; b=l
 VYsyT2zYRW9aK8eVmb0OO2qfTDydmcjAKfiKjLoqNTY8+7oP9CYjX4bpheMRbhQ6
 UIvYWN61mr9LosbN8V7EivS36tCmIfs7uVnklLdPv3c52eGKO/cJEaeCXVWd4lgG
 ZZ3NOclYkMfBg0yKtp7RCf393PvA5BSxZvUPPAy35CXqti3LvaVwdaWDn2ckvgQb
 D8aaRGHPjc+MTLCcCCV3SIFAnqrHZYK7AtUAQgDMn0RapwnLMuzcdAMLWozKPnSn
 2OkzqVmVXUOvvy5blpoSY64zdEzladH+UNaN1V63ne+kiusSLgQ/4z7fhLVM1nA7
 9sHoEnpxDAV0dTK96WQ/Q==
X-ME-Sender: <xms:bQCjZS6OmeTpdWkVUgyDHZaS9Aq2OObXPcQjXSAvzdgCmdnay6RAhg>
 <xme:bQCjZb75fIkrPoxgLsakJMv0ys899Yl1eJSOu94G7k1qIyIcY9Y-PQEjC4_MKcrlt
 G9M88Qxd3wk3UP1Hg>
X-ME-Received: <xmr:bQCjZRdiH8kpPuDyafr9pf_zknsbTF7FXSVvcNPxA68csN0HUNlUqCCavn65b8JwCZ1UVI_Q_A-1OEqzh9-U6H3KHt4pq_OuidU>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeijedgudeglecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgr
 nhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrh
 hnpefhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfen
 ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse
 hrvghtrhhoshhpvggtrdhtvh
X-ME-Proxy: <xmx:bQCjZfLZlHgQuO1trytXjHBZCvK86iub1ms_5acwI8ELfaNfTPoT-w>
 <xmx:bQCjZWL8ixa_NcNRuFhMNPHHqo0Ac4Dj4plLEzJ8xd8kXbz82Z36aQ>
 <xmx:bQCjZQwemYVf5Y3J7krW_zrbCtkyiDusX0m8cM-MYVbCqLIV5kyhzg>
 <xmx:bQCjZe_aXpZgG6RUN_ri8u3ZD763eqaaBfBYI5dDfMnZJWAFYkdYIw>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 13 Jan 2024 16:28:12 -0500 (EST)
References: <d025ed90d2d10e3504cca292f55e40ef36c6d4a0.1699746871.git.ian@HIDDEN>
 <875xzyzzxf.fsf@HIDDEN>
User-agent: mu4e 1.10.8; emacs 29.1
From: Ian Eure <ian@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [bug#67118] [PATCH] Change "tabulation" to "tabulation
 character" in linter & manual
Date: Sat, 13 Jan 2024 13:25:46 -0800
In-reply-to: <875xzyzzxf.fsf@HIDDEN>
Message-ID: <87ttngq5xw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67118
Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
 Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
 Tobias Geerinckx-Rice <me@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
 67118 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


Simon Tournier <zimon.toutoune@HIDDEN> writes:

> Hi,
>
> On Sat, 11 Nov 2023 at 15:54, Ian Eure <ian@HIDDEN> wrote:
>
>> diff --git a/doc/guix.texi b/doc/guix.texi
>> index 94903fb5e2..6396f129a1 100644
>> --- a/doc/guix.texi
>> +++ b/doc/guix.texi
>> @@ -119,6 +119,7 @@
>>  Copyright @copyright{} 2023 Zheng Junjie@*
>>  Copyright @copyright{} 2023 Brian Cully@*
>>  Copyright @copyright{} 2023 Felix Lechner@*
>> +Copyright @copyright{} 2023 Ian Eure@*
>
> I am not sure that a oneline change implies a Copyright=20
> header. :-)
>

Sure, I can remove that.


> And other change neither, I guess.
>=20=20=20
>> -		     make-flags #:allow-other-keys)
>> +                     make-flags #:allow-other-keys)
>>               (define make-flags/sexp
>>                 (if (gexp? make-flags/sexp)
>>                     (gexp->approximate-sexp make-flags)
>>                     make-flags))
>> -	     ;; Some packages like 'tzdata' are never=20
>> cross-compiled;
>> -	     ;; the compilers are only used to build tools for
>> -	     ;; compiling the rest of the package.
>> -	     (if (eq? target '#false)
>> -		 '()
>> -		 (find-incorrect-compilers make-flags/sexp)))
>> +             ;; Some packages like 'tzdata' are never=20
>> cross-compiled;
>> +             ;; the compilers are only used to build tools for
>> +             ;; compiling the rest of the package.
>> +             (if (eq? target '#false)
>> +                 '()
>> +                 (find-incorrect-compilers make-flags/sexp)))
>>             (package-arguments package))))
>
> There is no change here, right?
>

I believe the whitespace changes were a result of running `guix=20
style' or similar, I definitely didn=E2=80=99t intend for the patch to=20
contain all that.  I=E2=80=99ll back those out and send a new one.




Information forwarded to guix-patches@HIDDEN:
bug#67118; Package guix-patches. Full text available.

Message received at 67118 <at> debbugs.gnu.org:


Received: (at 67118) by debbugs.gnu.org; 12 Jan 2024 12:51:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 07:51:28 2024
Received: from localhost ([127.0.0.1]:35154 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOH0R-0004Bw-TI
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:51:28 -0500
Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:39975)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1rOH0J-0004AA-Gz
 for 67118 <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:51:21 -0500
Received: by mail-wm1-x336.google.com with SMTP id
 5b1f17b1804b1-40e5200c784so5153675e9.0
 for <67118 <at> debbugs.gnu.org>; Fri, 12 Jan 2024 04:51:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1705063876; x=1705668676; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=NFwU/Og5H/v0Cl9w21hWJj7s7DeypWl11la05GnEVgs=;
 b=ETab1gHFehcwHgyhFa7Cuy7DxqB/syf2xUUjf9bJl69vISDS7Wv4nJ4GkgQH3wiF4g
 GT24//YhDivrYi2UTkKrboDUSIqnUJnQLtCWq51QOCHX9XUwoj3L4i07laWeFRMQagJx
 HKbQC1Z+arwGjF46UxvePrii+oeKjQXRhk81AEA0KhiLAYluHOljHMRjoQQm8wcA6X91
 qI9kLzPBV0MQcciPuVwPvR8iqTqfrxyO0JwCOsJnO8G+CwJ0bkBagnpFuOwPT4okr+7t
 KGC8GAYdxgUY2RIFlmlyS23WpPqxQGLFgcTxmCtlOw6cfa3shHeqGa8I0p7EzzRHgRP9
 POyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705063876; x=1705668676;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=NFwU/Og5H/v0Cl9w21hWJj7s7DeypWl11la05GnEVgs=;
 b=cECh7E3IIqlOmh2qxait+TPd6kpclWHJGybIQ/xAL41AsIkm41Jtj1lSwi6dO2uZFH
 SEWJ0TD3q2RaT/uA5c6BVJocG7++w5Isf1vFViP2h/5AViKegdnFA0Vq609ff96ijkpW
 wUdvQCzMri61FQX3OwSb5k0bytjam+bc+3VSuwHAGJLBFLZH/W0vM4yC/XEh/7i7f1/4
 U0TUXPfic+rKvRxtn1GrqpMAid8XGJzfbYpEVmjqjlKDOQLXZt8ArPtHZ9deTohbeM5n
 je/eaH/PkN1DGXUS57pV/DSIotFjGorLxXk8Sshoj3mINP6Lx1rIhyasLdqCmEoqMaxm
 bBOA==
X-Gm-Message-State: AOJu0YwjYG2fXqZTZYjKV1+5rXbxzmxYWFsZrVfliF+FySuMKeTMAmoQ
 S2YNUS70XMfKMOdcsDOFxv0=
X-Google-Smtp-Source: AGHT+IFx7Y66a4b8upakbkYUkelWUE6F5vNao7aj05WTOmh8EC4bs0sPPR4wtWb1NagzUrOSPW76YA==
X-Received: by 2002:a05:600c:3542:b0:40e:4aff:4f9d with SMTP id
 i2-20020a05600c354200b0040e4aff4f9dmr1171712wmq.0.1705063875712; 
 Fri, 12 Jan 2024 04:51:15 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
 l6-20020a7bc346000000b0040d81ca11casm5521217wmj.28.2024.01.12.04.51.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 12 Jan 2024 04:51:15 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Ian Eure <ian@HIDDEN>, 67118 <at> debbugs.gnu.org
Subject: Re: [bug#67118] [PATCH] Change "tabulation" to "tabulation
 character" in linter & manual
In-Reply-To: <d025ed90d2d10e3504cca292f55e40ef36c6d4a0.1699746871.git.ian@HIDDEN>
References: <d025ed90d2d10e3504cca292f55e40ef36c6d4a0.1699746871.git.ian@HIDDEN>
Date: Fri, 12 Jan 2024 10:03:24 +0100
Message-ID: <875xzyzzxf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi, On Sat, 11 Nov 2023 at 15:54,
 Ian Eure wrote: > diff --git
 a/doc/guix.texi b/doc/guix.texi > index 94903fb5e2..6396f129a1 100644 > ---
 a/doc/guix.texi > +++ b/doc/guix.texi > @@ -119, 6 +119,
 7 @@ > Copyright @copyright{} 2023 Zheng Junjie@* > Copy [...] 
 Content analysis details:   (1.1 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 1.1 DATE_IN_PAST_03_06     Date: is 3 to 6 hours before Received: date
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (zimon.toutoune[at]gmail.com)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2a00:1450:4864:20:0:0:0:336 listed in]
 [list.dnswl.org]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 67118
Cc: Josselin Poiret <dev@HIDDEN>, Ian Eure <ian@HIDDEN>,
 Mathieu Othacehe <othacehe@HIDDEN>,
 Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
 Tobias Geerinckx-Rice <me@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
 Christopher Baines <guix@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)

Hi,

On Sat, 11 Nov 2023 at 15:54, Ian Eure <ian@HIDDEN> wrote:

> diff --git a/doc/guix.texi b/doc/guix.texi
> index 94903fb5e2..6396f129a1 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -119,6 +119,7 @@
>  Copyright @copyright{} 2023 Zheng Junjie@*
>  Copyright @copyright{} 2023 Brian Cully@*
>  Copyright @copyright{} 2023 Felix Lechner@*
> +Copyright @copyright{} 2023 Ian Eure@*

I am not sure that a oneline change implies a Copyright header. :-)

And other change neither, I guess.
=20=20
> -		     make-flags #:allow-other-keys)
> +                     make-flags #:allow-other-keys)
>               (define make-flags/sexp
>                 (if (gexp? make-flags/sexp)
>                     (gexp->approximate-sexp make-flags)
>                     make-flags))
> -	     ;; Some packages like 'tzdata' are never cross-compiled;
> -	     ;; the compilers are only used to build tools for
> -	     ;; compiling the rest of the package.
> -	     (if (eq? target '#false)
> -		 '()
> -		 (find-incorrect-compilers make-flags/sexp)))
> +             ;; Some packages like 'tzdata' are never cross-compiled;
> +             ;; the compilers are only used to build tools for
> +             ;; compiling the rest of the package.
> +             (if (eq? target '#false)
> +                 '()
> +                 (find-incorrect-compilers make-flags/sexp)))
>             (package-arguments package))))

There is no change here, right?

> diff --git a/tests/lint.scm b/tests/lint.scm
> index a52a82237b..cec9e3ab21 100644
> --- a/tests/lint.scm
> +++ b/tests/lint.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright =C2=A9 2020 Tobias Geerinckx-Rice <me@HIDDEN>
>  ;;; Copyright =C2=A9 2021 Xinglu Chen <public@HIDDEN>
>  ;;; Copyright =C2=A9 2021, 2023 Maxime Devos <maximedevos@HIDDEN>
> +;;; Copyright =C2=A9 2023 Ian Eure <ian@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -359,18 +360,18 @@ (define (warning-contains? str warnings)
>    '()
>    (check-compiler-for-target
>     (dummy-package "x"
> -		  (arguments
> -		   (list #:make-flags
> -			 #~(list (string-append "CC=3D" (cc-for-target))))))))
> +                  (arguments
> +                   (list #:make-flags
> +                         #~(list (string-append "CC=3D" (cc-for-target))=
))))))

No change here, right?

>  (test-equal "compiler-for-target: CC=3Dgcc is acceptable when target=3D#=
false"
>    '()
>    (check-compiler-for-target
>     ;; This (dummy) package consists purely of architecture-independent d=
ata.
>     (dummy-package "tzdata"
> -		  (arguments
> -		   (list #:target #false
> -			 #:make-flags #~(list "CC=3Dgcc"))))))
> +                  (arguments
> +                   (list #:target #false
> +                         #:make-flags #~(list "CC=3Dgcc"))))))

No change?

>  ;; The emacs-build-system sets #:tests? #f by default.
>  (test-equal "tests-true: #:tests? #t acceptable for emacs packages"
> @@ -1307,16 +1308,16 @@ (define (package-with-phase-changes changes)
>=20=20
>  (test-assert "formatting: tabulation"
>    (string-match-or-error
> -   "tabulation on line [0-9]+, column [0-9]+"
> +   "tabulation character \\(0x09\\) on line [0-9]+, column [0-9]+"
>     (single-lint-warning-message
> -    (check-formatting (dummy-package "leave the tab here:	")))))
> +    (check-formatting (dummy-package "leave the tab here:       ")))))
>=20=20
>  (test-assert "formatting: trailing white space"
>    (string-match-or-error
>     "trailing white space .*"
>     ;; Leave the trailing white space on the next line!
>     (single-lint-warning-message
> -    (check-formatting (dummy-package "x")))))=20=20=20=20=20=20=20=20=20=
=20=20=20
> +    (check-formatting (dummy-package "x")))))

What is the change here?


Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#67118; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Nov 2023 23:55:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 11 18:55:45 2023
Received: from localhost ([127.0.0.1]:54670 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1xpJ-0003e9-8U
	for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 18:55:45 -0500
Received: from lists.gnu.org ([2001:470:142::17]:50126)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ian@HIDDEN>) id 1r1xpG-0003dn-1j
 for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 18:55:43 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ian@HIDDEN>) id 1r1xoV-0006IO-6V
 for guix-patches@HIDDEN; Sat, 11 Nov 2023 18:54:55 -0500
Received: from wout3-smtp.messagingengine.com ([64.147.123.19])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ian@HIDDEN>) id 1r1xoS-0004W6-VR
 for guix-patches@HIDDEN; Sat, 11 Nov 2023 18:54:54 -0500
Received: from compute7.internal (compute7.nyi.internal [10.202.2.48])
 by mailout.west.internal (Postfix) with ESMTP id 723FC32008C3;
 Sat, 11 Nov 2023 18:54:49 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Sat, 11 Nov 2023 18:54:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:message-id:mime-version:reply-to
 :sender:subject:subject:to:to; s=fm2; t=1699746888; x=
 1699833288; bh=TbHOL8mkLzXQjhtNXsiUVFFa+5OwSJhGXVMqHdWS/yg=; b=2
 Ghm+m5LgJ74B6eifpKOeVunfOBLVngY7xInQfnOqx/we6yFSzWtUZdq/h6WjpFMl
 DyJGifHKmKaJZCFDpkL6P9V+pFBiTpZwUHCXrEy3/3jh6hV67gbZMQye6rY5L0+W
 r9EaoepyjhvfWl2T1YxqXDHeCn8KxZNN4Y4HsWNaVLlF849xiBkyT9yheZ80q8SD
 o460tkO4j9eGbrqLSWHdTW4mylgzpzzr3Xp8RGNlaHlkj1uYDRhUusSSXOy/pECD
 AV2XzZAm+Lnko8B95VV5zdL2R5M6LFWfHBJWchxV4ulMfDE0qABXz8BcDjzs7Lyc
 coIkXHQoK/p1qBwKkYOzA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:message-id:mime-version:reply-to:sender
 :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm3; t=1699746888; x=1699833288; bh=T
 bHOL8mkLzXQjhtNXsiUVFFa+5OwSJhGXVMqHdWS/yg=; b=X5Dk+bYmRyotUwR+q
 JFWryy7npZwRoEo9+Uc8D8ZlESoXYXZjOte319ce2HS6m11ZDebiP3wtjCFDRtCO
 aQZwwmA6Ivh4ECauQ7dyCtCrdVdKT+EfTxxCKIi1P4YvYgBsleWjBJ3Qi9i1AXac
 sfzI+IrAAZ5DntMFgc0Uj5JYv70K1C3p9EJXrMUNWYPUtMFxLEhk4ikOw7wc75/0
 iunh7wuL2awgDixdO5FQJajptDO4+mMc4TKcjMkxNLBJJvEocw3KAkrp/r+obIuU
 aJtxowD7ff+AFnr8Np4Q15K8Sdc6EwGr/I42Qjm65tf29AmoMMpTL1CHnTaPpYV9
 TxjaA==
X-ME-Sender: <xms:SBRQZVVhZjXV2W4nJauXVXr3g_bdlveeiG3JnL9bwZKepgmQaeTRMw>
 <xme:SBRQZVnrW3Binw6Ld-AnCSAd3qRO3BvO8Qoj3_eCpfU-Zf3tHVE5iho2aZLLG_DyK
 _R39Kn8aowFNXFpYQ>
X-ME-Received: <xmr:SBRQZRaDAYg4woCjL6tySf7LwAbKK5nQcQuModAejN-nntrbmRMFEED72vdEybmLTubdU_zwrgO4xTc-2GdiHv_Ejz9Eo_lpEKr5Lpj3d7PAjsc>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddviedgudeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdludegmdenucfjughrpefhvf
 evufffkffogggtgfesthekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgr
 nhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpefgueekffejudfgvd
 evteelteeitdeuuddufffhuefhiefhjeetuefhgfettedvteenucevlhhushhtvghrufhi
 iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrd
 htvh
X-ME-Proxy: <xmx:SBRQZYUAlnX1tIxikhkf0PA-OODmkmWVhc5ZWwfv57ymKuYqyZGUfw>
 <xmx:SBRQZfl6NeI7I2ma1P2bGql_Fd71srM8_VgFrb75aTZetCdMVDIizg>
 <xmx:SBRQZVeusynwhTefrd0Plm03zXHnZUapusloJ_jluEgiMmSrxlTQTg>
 <xmx:SBRQZeusFz0RMT0ILDHGfxnmcm0HjuB5HFJrNlG-I89IKPnXVxEHhg>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 11 Nov 2023 18:54:48 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] Change "tabulation" to "tabulation character" in linter &
 manual
Date: Sat, 11 Nov 2023 15:54:32 -0800
Message-ID: <d025ed90d2d10e3504cca292f55e40ef36c6d4a0.1699746871.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=64.147.123.19; envelope-from=ian@HIDDEN;
 helo=wout3-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

While linting my packages for my first contribution to Guix, I found this
linter warning to be unclear.  The linter looks for ASCII horizontal tab
characters, but the message doesn’t make this clear, as it only says
"tabulation."  Tabulation is the aligning of text into tables, and this may be
accomplished without using ASCII 0x09, for example, with spaces.

This patch clarifies the message to specifically indicate the objectionable
character, updates the test, and changes the language in the manual.

Change-Id: I375d1aa0aec7dfab7e8dfaffb8d4ad0e4f330205
---
 doc/guix.texi  |  3 ++-
 guix/lint.scm  | 19 ++++++++++---------
 tests/lint.scm | 19 ++++++++++---------
 3 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 94903fb5e2..6396f129a1 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -119,6 +119,7 @@
 Copyright @copyright{} 2023 Zheng Junjie@*
 Copyright @copyright{} 2023 Brian Cully@*
 Copyright @copyright{} 2023 Felix Lechner@*
+Copyright @copyright{} 2023 Ian Eure@*
 
 Permission is granted to copy, distribute and/or modify this document
 under the terms of the GNU Free Documentation License, Version 1.3 or
@@ -15362,7 +15363,7 @@ Invoking guix lint
 
 @item formatting
 Warn about obvious source code formatting issues: trailing white space,
-use of tabulations, etc.
+use of ASCII tabulation characters, etc.
 
 @item input-labels
 Report old-style input labels that do not match the name of the
diff --git a/guix/lint.scm b/guix/lint.scm
index 861e352b93..f053716abf 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2021 Xinglu Chen <public@HIDDEN>
 ;;; Copyright © 2021-2023 Maxime Devos <maximedevos@HIDDEN>
 ;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
+;;; Copyright © 2023 Ian Eure <ian@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -348,17 +349,17 @@ (define (check-compiler-for-target package)
       (_ '())))
   (parameterize ((%current-target-system "aarch64-linux-gnu"))
     (apply (lambda* (#:key (target 'not-set)
-		     make-flags #:allow-other-keys)
+                     make-flags #:allow-other-keys)
              (define make-flags/sexp
                (if (gexp? make-flags/sexp)
                    (gexp->approximate-sexp make-flags)
                    make-flags))
-	     ;; Some packages like 'tzdata' are never cross-compiled;
-	     ;; the compilers are only used to build tools for
-	     ;; compiling the rest of the package.
-	     (if (eq? target '#false)
-		 '()
-		 (find-incorrect-compilers make-flags/sexp)))
+             ;; Some packages like 'tzdata' are never cross-compiled;
+             ;; the compilers are only used to build tools for
+             ;; compiling the rest of the package.
+             (if (eq? target '#false)
+                 '()
+                 (find-incorrect-compilers make-flags/sexp)))
            (package-arguments package))))
 
 (define (properly-starts-sentence? s)
@@ -1774,12 +1775,12 @@ (define (check-haskell-stackage package)
 ;;;
 
 (define (report-tabulations package line line-number)
-  "Warn about tabulations found in LINE."
+  "Warn about ASCII tabulation characters found in LINE."
   (match (string-index line #\tab)
     (#f #f)
     (index
      (make-warning package
-                   (G_ "tabulation on line ~a, column ~a")
+                   (G_ "tabulation character (0x09) on line ~a, column ~a")
                    (list line-number index)
                    #:location
                    (location (package-file package)
diff --git a/tests/lint.scm b/tests/lint.scm
index a52a82237b..cec9e3ab21 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <me@HIDDEN>
 ;;; Copyright © 2021 Xinglu Chen <public@HIDDEN>
 ;;; Copyright © 2021, 2023 Maxime Devos <maximedevos@HIDDEN>
+;;; Copyright © 2023 Ian Eure <ian@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -359,18 +360,18 @@ (define (warning-contains? str warnings)
   '()
   (check-compiler-for-target
    (dummy-package "x"
-		  (arguments
-		   (list #:make-flags
-			 #~(list (string-append "CC=" (cc-for-target))))))))
+                  (arguments
+                   (list #:make-flags
+                         #~(list (string-append "CC=" (cc-for-target))))))))
 
 (test-equal "compiler-for-target: CC=gcc is acceptable when target=#false"
   '()
   (check-compiler-for-target
    ;; This (dummy) package consists purely of architecture-independent data.
    (dummy-package "tzdata"
-		  (arguments
-		   (list #:target #false
-			 #:make-flags #~(list "CC=gcc"))))))
+                  (arguments
+                   (list #:target #false
+                         #:make-flags #~(list "CC=gcc"))))))
 
 ;; The emacs-build-system sets #:tests? #f by default.
 (test-equal "tests-true: #:tests? #t acceptable for emacs packages"
@@ -1307,16 +1308,16 @@ (define (package-with-phase-changes changes)
 
 (test-assert "formatting: tabulation"
   (string-match-or-error
-   "tabulation on line [0-9]+, column [0-9]+"
+   "tabulation character \\(0x09\\) on line [0-9]+, column [0-9]+"
    (single-lint-warning-message
-    (check-formatting (dummy-package "leave the tab here:	")))))
+    (check-formatting (dummy-package "leave the tab here:       ")))))
 
 (test-assert "formatting: trailing white space"
   (string-match-or-error
    "trailing white space .*"
    ;; Leave the trailing white space on the next line!
    (single-lint-warning-message
-    (check-formatting (dummy-package "x")))))            
+    (check-formatting (dummy-package "x")))))
 
 (test-assert "formatting: long line"
   (string-match-or-error

base-commit: af6105afc67a15a491a0a4fd18a28c9f801a0b94
-- 
2.41.0





Acknowledgement sent to Ian Eure <ian@HIDDEN>:
New bug report received and forwarded. Copy sent to guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:
bug#67118; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.