Received: (at 67512) by debbugs.gnu.org; 17 Jan 2024 15:43:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 17 10:43:47 2024 Received: from localhost ([127.0.0.1]:53066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rQ84x-0007wK-6K for submit <at> debbugs.gnu.org; Wed, 17 Jan 2024 10:43:47 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:54511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <clement@HIDDEN>) id 1rQ84u-0007w6-Rg for 67512 <at> debbugs.gnu.org; Wed, 17 Jan 2024 10:43:45 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 242DC3200A47; Wed, 17 Jan 2024 10:43:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 17 Jan 2024 10:43:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1705506216; x=1705592616; bh=gSWbu/qfENA8B2300JDQqakpuQVSWFZdPig539JPTJw=; b= Q8FX8KybH+qEybhIJuG4Byn9RcRx5PW3xdovXec0vTuLOd6sWyggTg1w1OWpd+Jh 4XSWpzuUQZyrdgT3d93Oza4ADtGNAwLCIN3Qkrs1atZDfMb+CbzoK1gVEIGpmKbn FRvqttjR4El+VrojYQ+j4icczWvgtOaKzjCy2PerOIRlz0OSgZJfidETH97JOocj mcZG4U8iuqqTPD4vevEBAdpGuQitsbMn7xWcQqAMxAh+Y9DbA62DhUSVjRRln4DY DppTc+gekw4mWDsbVK1mavJkST91ALw8ILJJHJREwYEB1rCA8o0L9Hw0v5FNdurK qocBBi9q3cW1D8PyRjrngg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1705506216; x= 1705592616; bh=gSWbu/qfENA8B2300JDQqakpuQVSWFZdPig539JPTJw=; b=A aMrQxNedQ7cF+YDQ419TDOYi13xGZEPnoBdTv2BS7DHY8ymc+033p/eTYZNmzUso G9gGhg6GFFlJnFrwxI/ICX7x7OHXvY5a+iJZhNgVgZh2KtSLyr9VmQLyMKn527kY 8sj64uxYYv1yFCn4p1T+W03ozUIgrVVSMle9w8kr0Mrw4NsLs4RaAr3Lud33jen3 bsec+v5K0JiilDRN8UDb7bX9/aWOSCpSCbvjCTBhd1jNqIUKOCLikr12CxW6G/ng rVvSSDBApcD5EFqZFD3iEbn/+vigds5qyKgvYtIB2XtqKApDWbUNvYIp9Luj1tWI Yi+Wqogyjk3Rup0UE8WSQ== X-ME-Sender: <xms:qPWnZRCJCG6nnjFs-vpw7fFw22TUdPqDxH4mp-UGm1GRuqmvcgmL9g> <xme:qPWnZfjXfAe4Dodk7znzwt1GqigljpDLizlTzI-KEqy0ZgPMh-IuleeZPgttU36W4 RGmQXFhNUpNPE88hrw> X-ME-Received: <xmr:qPWnZckcMXqrKEOehhPnoJ3Km7KcV1L_k0mCf_Uz_5cDV4dzTcwpaw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdejhedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhor mhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh eqnecuggftrfgrthhtvghrnhepheegudfhffegffeuleejteettefhtdegteegleekieev hfehteethffhvdefueejnecuffhomhgrihhnpehlihgsrhgvfiholhhfrdhnvghtnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghn theslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: <xmx:qPWnZbxD9UI_y-Lma2HsKREr8kazIotIQqPUYXmMU-BF4JrO42OTjA> <xmx:qPWnZWSD3JICQ9NdJzd089zbygT9i3BT3rbyxM342u1YP8-ArGygyA> <xmx:qPWnZeZlBv8Pmyy3VbpcfW_bBTWzsaM5VAR_VBldhzFHzYPdXm3mpQ> <xmx:qPWnZZKKMqDXhRhbYgoBe7NWNLYJqzt1p2uSC5xELpvxwaTx8Em9tA> Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Jan 2024 10:43:35 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= <clement@HIDDEN> To: Ian Eure <ian@HIDDEN>, Pierre Langlois <pierre.langlois@HIDDEN> Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: <cover.1701186634.git.ian@HIDDEN> (Ian Eure's message of "Tue, 28 Nov 2023 12:09:56 -0800") References: <cover.1701186634.git.ian@HIDDEN> Date: Wed, 17 Jan 2024 16:43:31 +0100 Message-ID: <87a5p49d98.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Ian and Pierre, Thank you for this! I hope to do a review soon. Meanwhile I have one question for Pierre: is there any reason why your Wasm work was contributed to Nonguix instead of Guix? It looks like it could be used by Icecat. Would you say it is ready to be added to the Guix repo? Thank you, Cl=C3=A9ment On Tue, Nov 28 2023, Ian Eure wrote: > I mentioned in #guix that I was working on a package for LibreWolf, and i= t was requested that I send in patches, so I am. These changes are based o= n the firefox-esr package in nonguix; I've retained the copyright / authors= hip notices from there. > > LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the= telemetry and advertising, and bundles uBlock Origin. It doesn't have the= redistribution issues that Firefox does, its name/logo are under MPL 2.0 a= nd aren't trademarked. > > I'm new to Guix, and not remotely a browser development expert, so I don'= t expect these are ready to be accepted yet, but I believe they're in good = enough shape to have a discussion about. They're working acceptably well f= or me, though I'm not currently daily driving Guix, so there may be issues = I haven't encountered yet. > > Guide to changes in this patchset > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > icu4c has been updated to 73.1, and the previous version kept as icu4c-71= . I encountered consistent failures of the node@HIDDEN test suite with ic= u4c 73.1, so I kept that on 71.1. icu4c is needed by many packages, so thi= s change is the highest-impact in the patchset. > > The (gnu packages wasm) module is unchanged from nonguix, except for the = file header and module declaration. > > The (gnu packages librewolf) module is a simplified/adapted version of (n= ongnu packages firefox). The Firefox Nightly packages have been removed, a= s there's no LibreWolf equivalent. I also didn't bring over the wayland va= riant, but I could, if that's desired. I'm not sure why there are specific= x11/wayland variants, as the packages for other distros don't seem to need= this split. > > The librewolf package has some functions duplicated from (gnu packages gn= uzilla), which probably ought to get factored out and put somewhere, but I'= m not sure if they should be in (gnu packages mozilla) or a different modul= e. Guidance would be appreciated here. > > Ian Eure (5): > gnu: icu4c: Update to 73.1. > gnu: Add icu4c-71. > gnu: node: Switch to icu4c-71. > gnu: Add wasm packages. > gnu: Add librewolf. > > gnu/packages/icu4c.scm | 21 +- > gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ > gnu/packages/node.scm | 4 +- > gnu/packages/wasm.scm | 273 ++++++++++++++++++ > 4 files changed, 854 insertions(+), 4 deletions(-) > create mode 100644 gnu/packages/librewolf.scm > create mode 100644 gnu/packages/wasm.scm > > > base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 13 Jan 2024 17:53:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 12:53:57 2024
Received: from localhost ([127.0.0.1]:41002 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rOiCi-00022U-Ne
for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 12:53:57 -0500
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:59195
helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1rOiCg-00022E-8R
for 67512 <at> debbugs.gnu.org; Sat, 13 Jan 2024 12:53:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1673632595;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type;
bh=MlV4XxTIx0XYJ7F2JQOnlaLPqmXFb/g+b9jKp3lgGvc=;
b=j5J11siTC/EE4rbm/YfKEGb05KFpWr2SpnBSaSUz0z1Zr3LvSxo7Dq0WqBq3ho0bysA19s
uS5ac/w68fqDqfFAn+NLZQkpCDS3na2hRNCRrfFTiIc0SRTm1hMtdv5DifD2LIujY0EoH+
yXoLXnoNCsGDO98lHpcU4TdKGCQx1avMR51nGURVbvSp9wNOr/ZOgIGgvEGNxRuBRAfIUV
WcIVu3Iod4z28LxRgyzfLXo5smyTiDgzk6PZWEWNSA0U7G8ESZ3DVqO1Izu+8QOeX/BgMz
PwAOJ9QgsCVsr6YEbLvy17XNeIe3vhsmzqw+EPsXv+aNdYnmKv5scJG66NhCwg==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id e60bb974
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Fri, 13 Jan 2023 17:56:34 +0000 (UTC)
Date: Sat, 13 Jan 2024 18:53:43 +0100
From: Herman Rimm <herman@HIDDEN>
To: Ian Eure <ian@HIDDEN>
Subject: [bug#67512] [PATCH 5/5] gnu: Add librewolf.
Message-ID: <mt4aodvwlggrmgr5y6gym5z2sqhf4kkzo2azc6r2wknb6jb4q2@dondfdar7aq3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Score: 3.5 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ian,
You can enable --with-system-png flag since libpng-apng
>= 1.6.35. These two icecat flags may be required for addons from
gnuzilla.gnu.org:
;; Do not require addons in the global app or system directories to ;; be
signed by Mozilla. "--with-unsigned-addon-scopes=app,
system" "--allow-addon-sideload"
Content analysis details: (3.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 TVD_RCVD_IP Message was received from an IP address
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 67512
Cc: 67512 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ian, You can enable --with-system-png flag since libpng-apng
>= 1.6.35. These two icecat flags may be required for addons from gnuzilla.gnu.org:
;; Do not require addons in the global app or system directories to ;; be
signed by Mozilla. "--with-unsigned-addon-scopes=app,system" "--allow-addon-sideload"
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Ian,
You can enable --with-system-png flag since libpng-apng >= 1.6.35. These
two icecat flags may be required for addons from gnuzilla.gnu.org:
;; Do not require addons in the global app or system directories to
;; be signed by Mozilla.
"--with-unsigned-addon-scopes=app,system"
"--allow-addon-sideload"
This icecat-minimal flag disables DRM:
;; The --disable-eme option is not available on aarch64.
#$(if (target-aarch64?) "" "--disable-eme")
Librewolf should not link to addons.mozilla.org, using this build phase
from torbrowser:
(add-before 'build 'fix-addons-placeholder
(lambda _
(substitute*
"toolkit/locales/en-US/toolkit/about/aboutAddons.ftl"
(("addons.mozilla.org") "gnuzilla.gnu.org"))))
Cheers,
Herman
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.Received: (at 67512) by debbugs.gnu.org; 14 Dec 2023 18:39:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 14 13:39:50 2023 Received: from localhost ([127.0.0.1]:50913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rDqcg-0000CP-7g for submit <at> debbugs.gnu.org; Thu, 14 Dec 2023 13:39:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1rDqcf-0000CA-38 for 67512 <at> debbugs.gnu.org; Thu, 14 Dec 2023 13:39:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1rDqcZ-0008A9-VR; Thu, 14 Dec 2023 13:39:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cT25ZJq3RZrD8hyIVaAJRSfhC2eHfAaNW2LRzHYyoSQ=; b=Y4kwjfn2r5/iXRGAOSkm wWmiH0jmJnRnmWX8BVNEP7/gFQP87f/PKi6kPeCY0sBN73pwx8YjJhIFM61UisgIxv4QW13T+Da5s QMqpAoi0vMaBPLLHlFk+XncNnOsgWkdRC0XjAqmtiX8adG7bk1wEwLq3xh4rBq8/iGJK9Jl1OBR9p vdFD51c3FZy3WVXHjWJGgnmuDw+uVHUKc9u9NdO1YfRmmaV7AwPDe8Ue7RvZCDBe82lCkyrthx1qY jgvJ/iSJTpz19XNAXqfUh4a69+NdRAH8QNkP1e8Z4eLr/+c4hdetg6eH71jIHUeUmcMamNRaXqptq snI+myt7nGTNQg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Ian Eure <ian@HIDDEN> Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: <87h6kpk7db.fsf@HIDDEN> (Ian Eure's message of "Sun, 10 Dec 2023 14:28:35 -0800") References: <cover.1701186634.git.ian@HIDDEN> <878r613em1.fsf@HIDDEN> <87h6kpk7db.fsf@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 24 Frimaire an 232 de la =?utf-8?Q?R=C3=A9v?= =?utf-8?Q?olution=2C?= jour de l'Oseille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Dec 2023 19:39:40 +0100 Message-ID: <87sf44tyqb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Ian, Ian Eure <ian@HIDDEN> skribis: > Ludovic Court=C3=A8s <ludo@HIDDEN> writes: [...] >> This is much appreciated! People often complain that IceCat is >> based on >> too old a version of Firefox, so if we can have LibreWolf (or even >> Firefox without its problematic bits), that=E2=80=99s great. >> > > IMO, LibreWolf pretty much is Firefox without the problematic bits. > It=E2=80=99s been my default browser for several years, and I=E2=80=99m v= ery satisfied > with it. Perfect, then. >> As the person who made the changes, it would be great if you could >> pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99. What >> phases or flags differ? What phases can be factorized? >> > This work isn=E2=80=99t based on the icecat package, but on the firefox-e= sr > package from nonguix. The duplication I refer to is two small helper > functions, `runpath-of' and `runpaths-of-input', totaling nine lines > of code; they=E2=80=99re flagged with a comment in the patch. As mention= ed in > the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99= t know where > they ought to be placed. They=E2=80=99re defined inside a lambda in a ge= xp, > which sounds like it may be challenging to put somewhere accessible to > both packages. > > Skimming the icecat package, not many of the build steps are shared > with librewolf, and factoring the commonalities out would IMO result > in overly complex, brittle, hard to maintain code that=E2=80=99s worse th= an > the slight duplication between the two packages. If there=E2=80=99s a st= rong > feeling that they must be accounted for, I=E2=80=99ll give it a try, but I > don=E2=80=99t believe that it=E2=80=99s the best option. Yeah, you=E2=80=99re right that factorizing can be a bad idea when misplace= d, so let=E2=80=99s keep it that way. I=E2=80=99ll take a closer look at the patches if nobody beats me at it! Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.Received: (at 67512) by debbugs.gnu.org; 10 Dec 2023 22:42:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 10 17:42:17 2023 Received: from localhost ([127.0.0.1]:51923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rCSV7-0007ku-6e for submit <at> debbugs.gnu.org; Sun, 10 Dec 2023 17:42:17 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ian@HIDDEN>) id 1rCSV3-0007kf-BL for 67512 <at> debbugs.gnu.org; Sun, 10 Dec 2023 17:42:15 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC0B05C00C4; Sun, 10 Dec 2023 17:41:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 10 Dec 2023 17:41:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=S2m7DwhVmEdyqBrnY7zpBmW9Evw18YfhWJzHKMktAX4uAst6UMR peRs4klu8A0By4qzDR9jTe+6PGMYQJDG1YP53Jb5DUl+VoTTqaGPw4ZwjcU6DH0J TF5MidOxXj/fdq/JV9W1q9Lwspc0ZLbcCV7UqlY0WQjQYZrYi738t0lNPGDAda1P dguOjyckMrLGUTvH45iKanR2NqR5Y+oa/sagiZoGjoifdtn90DcEjhwzVO2R9k0j hCFTb2eQOouwtSq6MjVz+5VcLKpBRmN/8GOnco0kPlrH6sBezW1qDNAo+ixdCuM+ yte9OEtdHcGp5ZDajnic/FhnhLY1QH+WdsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=yUVUpoXjBIq74HGkRFbLQKnHrN1vHBRnpVYUB08JEEy9qqgR3vn fXWVF44a5SjcORzD/w1WeJwhGlAh6Y13dUkWc7FGt/dkckNxEXM542qrVImVfxR2 EBYRC0KgqBGUGJp0tnZIwqXY6+2E398DRHmuLYikKtkd9T203k3rjDWAP0ef7Onp FKdOBURLZ3FTqqu1oNTz8uLfFfAmtQJrVJOqvQRyKtq1IcyZOVoOmJanIE3D+x9Q EjqiBlLxnwKRxe0bxOoWNNY3uKUQCCUSoK92X1kwaRAA6UmNuJTHdbv5Ct1vtEtk HyaxsxlqXV7XMQFNxSBoUTLHbmBKG8EUTLg== X-ME-Sender: <xms:sT52ZU1hvj10TgrrAN8Aai0Du9U9AgR7HQpUfl09yhU3d8pve7ydQw> <xme:sT52ZfG3bBaiPgxYFnrSsV7ufqgra0Uxk48D9VM_xHoiL24gTPHQvndd0M3vxLbYe mFs3P_pYc9wLTWhWA> X-ME-Received: <xmr:sT52Zc4vGcGZx2cCEut8yFBF6MvqthWUtKD2Nzet3oxU-H4KSl5U_0lueAgdJwMbKQaXafqKTH6ljSptlTO6kT1Z-VrgmWBmVQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeluddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefkrghn ucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnh epgeduieejieehgeehueejteevgedtuefgieektdelfeekudeilefggfetgedukeeknecu ffhomhgrihhnpehlihgsrhgvfiholhhfrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: <xmx:sT52Zd3ad9NWejcLbMEAUkZpHBevN8gv_5rtupBfLVSbDdpA3YxF3g> <xmx:sT52ZXGCql5nESB-BQJEYhEDvdChP53THklvpwVC_MnoS0k0Yp1VZQ> <xmx:sT52ZW-s3T6G0rx0EAMWPNWdgRyZ3HnKS_te0SpURrwLpDp_np2kxw> <xmx:sT52ZaM4A4zbCXI64ozZmgrT_R0Wa82ZlD9yDQ-gI58uyj6xhM-3OA> Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 17:41:53 -0500 (EST) References: <cover.1701186634.git.ian@HIDDEN> <878r613em1.fsf@HIDDEN> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure <ian@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf Date: Sun, 10 Dec 2023 14:28:35 -0800 In-reply-to: <878r613em1.fsf@HIDDEN> Message-ID: <87h6kpk7db.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi, thank you very much for your comments. Ludovic Court=C3=A8s <ludo@HIDDEN> writes: > Hi! > > Ian Eure <ian@HIDDEN> skribis: > >> I mentioned in #guix that I was working on a package for=20 >> LibreWolf, >> and it was requested that I send in patches, so I am. These=20 >> changes >> are based on the firefox-esr package in nonguix; I've retained=20 >> the >> copyright / authorship notices from there. >> >> LibreWolf (https://librewolf.net/) is a fork of Firefox which >> removes the telemetry and advertising, and bundles uBlock=20 >> Origin. >> It doesn't have the redistribution issues that Firefox does,=20 >> its >> name/logo are under MPL 2.0 and aren't trademarked. >> >> I'm new to Guix, and not remotely a browser development expert,=20 >> so I >> don't expect these are ready to be accepted yet, but I believe >> they're in good enough shape to have a discussion about.=20 >> They're >> working acceptably well for me, though I'm not currently daily >> driving Guix, so there may be issues I haven't encountered yet. > > This is much appreciated! People often complain that IceCat is=20 > based on > too old a version of Firefox, so if we can have LibreWolf (or=20 > even > Firefox without its problematic bits), that=E2=80=99s great. > IMO, LibreWolf pretty much is Firefox without the problematic=20 bits. It=E2=80=99s been my default browser for several years, and I=E2=80=99m ver= y=20 satisfied with it. >> The librewolf package has some functions duplicated from (gnu >> packages gnuzilla), which probably ought to get factored out=20 >> and put >> somewhere, but I'm not sure if they should be in (gnu packages >> mozilla) or a different module. Guidance would be appreciated=20 >> here. > > To me that=E2=80=99s the main issue here: these packages are complex,=20 > and I > wouldn=E2=80=99t want us to end up with two (or more!) copies of these=20 > beasts. > > As the person who made the changes, it would be great if you=20 > could > pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99.=20 > What > phases or flags differ? What phases can be factorized? > This work isn=E2=80=99t based on the icecat package, but on the=20 firefox-esr package from nonguix. The duplication I refer to is two small=20 helper functions, `runpath-of' and `runpaths-of-input', totaling nine=20 lines of code; they=E2=80=99re flagged with a comment in the patch. As=20 mentioned in the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99t = know=20 where they ought to be placed. They=E2=80=99re defined inside a lambda in a=20 gexp, which sounds like it may be challenging to put somewhere=20 accessible to both packages. Skimming the icecat package, not many of the build steps are=20 shared with librewolf, and factoring the commonalities out would IMO=20 result in overly complex, brittle, hard to maintain code that=E2=80=99s worse=20 than the slight duplication between the two packages. If there=E2=80=99s a=20 strong feeling that they must be accounted for, I=E2=80=99ll give it a try, but I don=E2=80=99t believe that it=E2=80=99s the best option. Thanks, =E2=80=94 Ian
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.Received: (at 67512) by debbugs.gnu.org; 10 Dec 2023 21:57:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 10 16:57:50 2023 Received: from localhost ([127.0.0.1]:51899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rCRo6-0006ee-IL for submit <at> debbugs.gnu.org; Sun, 10 Dec 2023 16:57:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1rCRo4-0006eQ-6n for 67512 <at> debbugs.gnu.org; Sun, 10 Dec 2023 16:57:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1rCRnk-00020f-05; Sun, 10 Dec 2023 16:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/dDOo1nXFB95HsNolnQp01ZAZUOPtOHhMcuz/qZhRfY=; b=ZuRbW9WbdPsK/O8ad6eU Ox+R3A7LgP0qYQl+5AQMkY9WahCtWB9Ilj5VVUPbaMDs90iMp6OXcPzOHVlm8cx5HsxoheQHDRbCv yl6HOCNu4Ni6YdCN0eM+uktw+q9sBltPeeMrehgbqVNpsbPQmRhkiNCos3q4pEel9Vz8IUxPYpg2k 9P5a8c7C8c5y2gyMOiZ1KSVQfyoM550zgGgzWh5GTD84icS+X6WvAzO84jmJfJt5Fh2CtI0ZZJEw1 uGkp0JFEs3mXgp3EXGB1mzyN/Wrug3hJMIk0jrn+CXf8IY1y/l6TcUohwXYW+0RNEq82ju79TKgPo hRL62pDPuQbJmA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Ian Eure <ian@HIDDEN> Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: <cover.1701186634.git.ian@HIDDEN> (Ian Eure's message of "Tue, 28 Nov 2023 12:09:56 -0800") References: <cover.1701186634.git.ian@HIDDEN> Date: Sun, 10 Dec 2023 22:57:26 +0100 Message-ID: <878r613em1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi! Ian Eure <ian@HIDDEN> skribis: > I mentioned in #guix that I was working on a package for LibreWolf, and i= t was requested that I send in patches, so I am. These changes are based o= n the firefox-esr package in nonguix; I've retained the copyright / authors= hip notices from there. > > LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the= telemetry and advertising, and bundles uBlock Origin. It doesn't have the= redistribution issues that Firefox does, its name/logo are under MPL 2.0 a= nd aren't trademarked. > > I'm new to Guix, and not remotely a browser development expert, so I don'= t expect these are ready to be accepted yet, but I believe they're in good = enough shape to have a discussion about. They're working acceptably well f= or me, though I'm not currently daily driving Guix, so there may be issues = I haven't encountered yet. This is much appreciated! People often complain that IceCat is based on too old a version of Firefox, so if we can have LibreWolf (or even Firefox without its problematic bits), that=E2=80=99s great. > The librewolf package has some functions duplicated from (gnu packages gn= uzilla), which probably ought to get factored out and put somewhere, but I'= m not sure if they should be in (gnu packages mozilla) or a different modul= e. Guidance would be appreciated here. To me that=E2=80=99s the main issue here: these packages are complex, and I wouldn=E2=80=99t want us to end up with two (or more!) copies of these beas= ts. As the person who made the changes, it would be great if you could pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80=99= . What phases or flags differ? What phases can be factorized? Thanks for your hard work! Ludo=E2=80=99.
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:14:13 2023
Received: from localhost ([127.0.0.1]:47796 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r84T7-0003OP-8L
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:14:13 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35609)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ian@HIDDEN>) id 1r84So-0003ML-Pv
for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 8CC505C021C;
Tue, 28 Nov 2023 15:13:34 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
1701202414; x=1701288814; bh=KBZlLCWoEJhX66/2Huvzkjyb3iA4+CL1lxU
j6gOtgbc=; b=emGztUQKYrU+bxppW8Bu8rXrj8hO5eQRCLnDUzAnvV9w/V8png9
u2wnGlYAZSdaKBsY+6akbb7+2p2+FrExBvzCo8RbuG2b8Nx86hKh+X/Moy82NWQB
aswhVDkLYGeqPMn5Ds+nFJihJwYYapxJdU5ojDqRn2RLZLlFlPt83233dvOtkKM6
cVrmwyjUTKgfiR2bMJDr/JzSs4gRGa1gb2aWHYFjVR0LGEWnb6W/HiGcnjUZ2vww
ix/NpBJ6N4HUh0VCSx4Kkevg0U61t0QZIWZdW/GMN+jcErUWGNAOmzYAv4Bj56FU
RbC3FyvFkZdeFltVUZ5d/J1vDKeX+keXM3w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1701202414; x=1701288814; bh=KBZlLCWoEJhX66/2Huvzkjyb3iA4+CL1lxU
j6gOtgbc=; b=ul/u995HXfxxbVOzg1qeQrY2kaAomgVoqvMAS85/cGb4FFJCJaK
Tzwe2ZF1Qht723CImkzS0dgKDljRQV+BdskzzpKr8cvS94MtxJQLJjlExmxYrQPi
pNheSKVfVzR5wKE03qLUJUi1KOd9VkVzaxrH4XGCommDnVseY4qCea/EBs9BV+8G
cekxl82G7ea7f2HeDh5xcgHw43srE4abSpLtV3dZUBca4JFyDU0KiFBS+6JZev2X
KRCHETPkIMJxO4AHMcloyAEhhVw7lZQqs3UUEX2Q2+LYq7x2LHdXkH6CNTp7r7SL
rY45d63TzFbY6Rc2S09nIF/RFyMzrwWhOrg==
X-ME-Sender: <xms:7klmZQOM7JcyIYETRav6zKMPAesSvtT0UZWaFdSjNCiwnF6L473CSw>
<xme:7klmZW9rPCp10zC65tqkSXHw3HQnkmtP2LZoedUcZGvcy2sXLQDJ_8Nd1cEyECugV
_IyC8Ek7y7dbF72Gg>
X-ME-Received: <xmr:7klmZXTQ84e3KwIaz3Jh_TDtXgYj7JLgSTUmA35juYsCU-5V-QIfwtLUzHTt7h5e31v0-_l-G3S5Iv2k3I7HkZ01KQi09dMuHwLrPNabCRwHeiQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgse
htkeertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhp
vggtrdhtvheqnecuggftrfgrthhtvghrnhepudejffefudeluedvheeuhedtvefgkefgte
evgeeljeelfeejhfdtveehvedtkeefnecuffhomhgrihhnpehgnhhurdhorhhgpdhgihht
hhhusgdrtghomhdpmhhoiihilhhlrgdrohhrghdpfigrshhirdguvghvpdhllhhvmhdroh
hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehi
rghnsehrvghtrhhoshhpvggtrdhtvh
X-ME-Proxy: <xmx:7klmZYtl6_fft7LmFGd9qS8mcUjRVxQ_CGJ2NkDf3ownZPJohhzEnA>
<xmx:7klmZYfi3G4vrGF6cntdp93B9E_-16ljj59C7b7dOhE9s1c0BXxSsQ>
<xmx:7klmZc1Z7A5I7ZPs0uk5KKomHwGydMa5YCMGC_cdx9_kiSRNrNjV8g>
<xmx:7klmZQkI90k9n347JlzZ-pOZ65F6fSi843BqwI3zL717YNyZc8AG1Q>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Nov 2023 15:13:33 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67512 <at> debbugs.gnu.org
Subject: [PATCH 4/5] gnu: Add wasm packages.
Date: Tue, 28 Nov 2023 12:13:08 -0800
Message-ID: <ef85847127588d4cbe687e8d237a8c3e98693848.1701186634.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1701186634.git.ian@HIDDEN>
References: <cover.1701186634.git.ian@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67512
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/wasm.scm (wasi-libc): New variable.
* gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable.
* gnu/packages/wasm.scm (wasm32-wasi-clang): New variable.
* gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable.
* gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable.
Change-Id: I546cb6b7450b760379fb8c3043e48ffc5e714c68
---
gnu/packages/wasm.scm | 273 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 273 insertions(+)
create mode 100644 gnu/packages/wasm.scm
diff --git a/gnu/packages/wasm.scm b/gnu/packages/wasm.scm
new file mode 100644
index 0000000000..05d247f333
--- /dev/null
+++ b/gnu/packages/wasm.scm
@@ -0,0 +1,273 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2022-2023 Pierre Langlois <pierre.langlois@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages wasm)
+ #:use-module (guix base32)
+ #:use-module (guix gexp)
+ #:use-module (guix packages)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix utils)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system cmake)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system trivial)
+ #:use-module (gnu packages bash)
+ #:use-module (gnu packages llvm)
+ #:use-module (gnu packages python))
+
+(define-public wasi-libc
+ (package
+ (name "wasi-libc")
+ (version "sdk-19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/WebAssembly/wasi-libc")
+ (commit (string-append "wasi-" version))
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0bnpz8wk9wiic938296gxp4vz820bvpi1w41jksjzz5552hql169"))))
+ (build-system gnu-build-system)
+ (native-inputs (list clang-15))
+ (arguments
+ (list
+ #:tests? #f ;No test suite
+ ;; Firefox uses wasm2c to compile WebAssembly to C code, and it
+ ;; does not support the memory.copy opcode.
+ ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4
+ #:make-flags ''("BULK_MEMORY_SOURCES=")
+ #:phases #~(modify-phases %standard-phases
+ (delete 'configure)
+ (add-before 'build 'set-sysroot-include
+ (lambda _
+ (setenv "C_INCLUDE_PATH"
+ (string-append (getcwd) "/sysroot/include"))))
+ (add-before 'install 'set-install-dir
+ (lambda _
+ (setenv "INSTALL_DIR"
+ (string-append #$output "/wasm32-wasi")))))))
+ (home-page "https://wasi.dev")
+ (synopsis "WASI libc implementation for WebAssembly")
+ (description
+ "WASI Libc is a libc for WebAssembly programs built on top of WASI
+system calls. It provides a wide array of POSIX-compatible C APIs, including
+support for standard I/O, file I/O, filesystem manipulation, memory
+management, time, string, environment variables, program startup, and many
+other APIs.")
+ (license (list
+ ;; For wasi-libc, with LLVM exceptions
+ license:asl2.0
+ ;; For malloc.c.
+ license:cc0
+ ;; For cloudlibc.
+ license:bsd-2
+ ;; For wasi-libc and musl-libc.
+ license:expat))))
+
+(define-public wasm32-wasi-clang-runtime
+ (package (inherit clang-runtime-15)
+ (native-inputs
+ (list clang-15
+ wasi-libc))
+ (inputs (list llvm-15))
+ (arguments
+ (list
+ #:build-type "Release"
+ #:tests? #f
+ ;; Stripping binaries breaks wasm linking, resulting in the following
+ ;; error: "archive has no index; run ranlib to add one".
+ #:strip-binaries? #f
+ #:configure-flags
+ #~(list "-DCMAKE_C_COMPILER=clang"
+ "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi"
+ (string-append
+ "-DCMAKE_SYSROOT=" #$wasi-libc "/wasm32-wasi")
+ (string-append
+ "-DCMAKE_C_FLAGS=-I " #$wasi-libc "/wasm32-wasi/include")
+
+ "-DCOMPILER_RT_OS_DIR=wasi"
+
+ "-DCOMPILER_RT_BAREMETAL_BUILD=On"
+ "-DCOMPILER_RT_DEFAULT_TARGET_ONLY=On"
+
+ ;; WASM only needs libclang_rt.builtins-wasm32.a from
+ ;; compiler-rt.
+ "../source/compiler-rt/lib/builtins")))))
+
+;; FIXME: Ideally we wouldn't need to build a separate compiler because clang
+;; can support multiple targets at runtime. However Guix patches the default
+;; clang with a specific clang-runtime package. It would be good to improve
+;; upstream Guix's support for cross-compiling with clang.
+
+(define clang-from-llvm (@@ (gnu packages llvm) clang-from-llvm))
+(define llvm-monorepo (@@ (gnu packages llvm) llvm-monorepo))
+
+(define-public wasm32-wasi-clang
+ (let ((base (clang-from-llvm llvm-15 wasm32-wasi-clang-runtime)))
+ (package
+ (inherit base)
+ (name "wasm32-wasi-clang")
+ (inputs (modify-inputs (package-inputs base)
+ (prepend wasi-libc)))
+ (arguments
+ (substitute-keyword-arguments (package-arguments base)
+ ((#:configure-flags flags)
+ #~(list "-DCLANG_INCLUDE_TESTS=True"
+ ;; Use a sane default include directory.
+ (string-append "-DC_INCLUDE_DIRS="
+ #$wasi-libc "/wasm32-wasi/include")))
+ ((#:phases phases)
+ `(modify-phases ,phases
+ (delete 'symlink-cfi_ignorelist))))))))
+
+(define-public wasm32-wasi-libcxx
+ (package
+ (name "wasm32-wasi-libcxx")
+ (version (package-version llvm-15))
+ (source
+ (llvm-monorepo version))
+ (build-system cmake-build-system)
+ (arguments
+ (list
+ #:configure-flags #~(list (string-append "-S ../source/runtimes")
+
+ "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi"
+
+ (string-append "-DCMAKE_SYSROOT="
+ #$wasi-libc "/wasm32-wasi")
+
+ (string-append "-DCMAKE_INCLUDE_PATH="
+ #$wasi-libc
+ "/wasm32-wasi/include")
+
+ (string-append "-DCMAKE_STAGING_PREFIX="
+ #$output "/wasm32-wasi")
+
+ "-DCMAKE_C_COMPILER=clang"
+ "-DCMAKE_C_COMPILER_WORKS=ON"
+ "-DCMAKE_CXX_COMPILER=clang++"
+ "-DCMAKE_CXX_COMPILER_WORKS=ON"
+ "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi"
+ "-DCMAKE_CXX_COMPILER_TARGET=wasm32-wasi"
+
+ "-DLIBCXX_LIBDIR_SUFFIX=/wasm32-wasi"
+
+ "-DLIBCXX_ENABLE_EXCEPTIONS=OFF"
+ "-DLIBCXX_ENABLE_SHARED=OFF"
+ "-DLIBCXX_ENABLE_THREADS=OFF"
+ "-DLIBCXX_ENABLE_FILESYSTEM=OFF"
+
+ "-DLIBCXXABI_LIBDIR_SUFFIX=/wasm32-wasi"
+
+ "-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF"
+ "-DLIBCXXABI_ENABLE_SHARED=OFF"
+ "-DLIBCXXABI_ENABLE_THREADS=OFF"
+ "-DLIBCXXABI_ENABLE_FILESYSTEM=OFF")
+ #:tests? #f
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH
+ (lambda _
+ (setenv "CPLUS_INCLUDE_PATH"
+ (string-append #$wasi-libc
+ "/wasm32-wasi/include:"
+ (getenv "CPLUS_INCLUDE_PATH"))))))))
+ (native-inputs (list lld python wasm32-wasi-clang))
+ (inputs (list wasi-libc))
+ (home-page "https://libcxx.llvm.org")
+ (synopsis "C++ standard library for WebAssembly")
+ (description
+ "This package provides an implementation of the C++ standard library for
+use with Clang, targeting C++11, C++14 and above. This package targets
+WebAssembly with WASI.")
+ (license license:expat)))
+
+(define-public wasm32-wasi-clang-toolchain
+ (package
+ (name "wasm32-wasi-clang-toolchain")
+ (version (package-version wasm32-wasi-clang))
+ (source
+ #f)
+ (build-system trivial-build-system)
+ (arguments
+ (list
+ #:builder (with-imported-modules '((guix build union)
+ (guix build utils))
+ #~(begin
+ (use-modules (guix build union)
+ (guix build utils))
+ (union-build #$output
+ (list #$wasm32-wasi-clang-runtime
+ #$wasi-libc
+ #$wasm32-wasi-libcxx))
+ (mkdir-p (string-append #$output
+ "/bin"))
+
+ ;; We provide clang and clang++ via a wrapped program that sets
+ ;; include paths correctly so that it does not include paths from
+ ;; the host.
+
+ ;; FIXME: Review how we can provide better support for
+ ;; cross-compiling with clang in Guix, maybe adding support for
+ ;; the CROSS_C_INCLUDE_PATH and CROSS_CPLUS_INCLUDE_PATH
+ ;; environment variables like GCC.
+
+ (for-each (lambda (bin)
+ (symlink (string-append #$wasm32-wasi-clang
+ bin)
+ (string-append #$output
+ bin))
+ (wrap-program (string-append #$output
+ bin)
+ #:sh (string-append #$bash-minimal
+ "/bin/bash")
+ `("C_INCLUDE_PATH"
+ ":" =
+ (,(string-append #$output
+ "/wasm32-wasi/include")))
+ `("CPLUS_INCLUDE_PATH"
+ ":" =
+ ;; Make sure inclure/c++/v1 comes first for #include_next
+ ;; to work.
+ (,(string-append #$output
+ "/wasm32-wasi/include/c++/v1") ,
+ (string-append #$output
+ "/wasm32-wasi/include")))))
+ '("/bin/clang"
+ "/bin/clang++"))
+
+ (symlink (string-append #$lld
+ "/bin/wasm-ld")
+ (string-append #$output
+ "/bin/wasm-ld"))))))
+ (inputs (list bash-minimal
+ lld
+ wasi-libc
+ wasm32-wasi-clang
+ wasm32-wasi-clang-runtime
+ wasm32-wasi-libcxx))
+ (license (cons (package-license wasm32-wasi-clang)
+ (package-license wasi-libc)))
+ (home-page "https://clang.llvm.org")
+ (synopsis
+ "Complete Clang toolchain for C/C++ development, for WebAssembly.")
+ (description
+ "This package provides a complete Clang toolchain for C/C++
+development targeting WebAssembly with WASI. This includes Clang, as well as
+libc, libc++ and wasm-ld.")))
--
2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:14:04 2023
Received: from localhost ([127.0.0.1]:47791 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r84T4-0003Nv-4J
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:14:04 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49057)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ian@HIDDEN>) id 1r84Sq-0003MS-5f
for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id C52A75C02B6;
Tue, 28 Nov 2023 15:13:35 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
1701202415; x=1701288815; bh=2dtbkvEb3dYM0vlLhXAiAdusTZqBJTKpGHy
GdWGVYZw=; b=PSQmtvZEXlXRH3iAyxfHKj5FV36WejAbOz+FHrtHbV+K2eDjB7v
Lq5OQuqQjM5G2YUSd9ctMeLE4DBLvAgxzQgVJQDBjkrpWXjjuam8UMwviajbcIkJ
vMopgis0ZW/VLRDM1oD8rVco5EbnvVgZOxnRleFCNblTkQNS+mCOySn9r6Ch8RnW
sr9NLqVAYhcTQ8w4+EQLou7GtD+MBHvvCrQ5i32KrWIY1G/NlbbwN/B8IVvsnOT5
/fvEktNqwgzp7hfXj17yGhORlUfpPzzC4FOv7xoBuEFrP6uO7S3rNlhWP23c9cg7
2wGFlJ2JJ9+rD1Q+lRxLAz9eh0aaoTRZgkQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1701202415; x=1701288815; bh=2dtbkvEb3dYM0vlLhXAiAdusTZqBJTKpGHy
GdWGVYZw=; b=z7jdqvlYHPOPEFSDu8lxhpEUOa0Qqv1+B3w+VEEVw21MWoQhBOq
aj4K8GvY69KtU88D9Xqtoe8DGWfVUP8g4VpeLZPPDwMIkx0bg9iyA/nmtKryruly
pNyqNfysF0VFNlxHRzixum+3GeZieB7bxZzCU13K30KEaqhH1hQbyChfFrkgklbH
zJNorPt+ihMtKiy/Q7PWbSr0+/KRmCLp1iXw11njMB384fWbzZVGfC3S8FxYsLlK
g8ICWgsd5SLNbVSW22HIc1Io2W0PzoZRLbMwBPgiyC6mECOehvK0gGDMqu8KWeys
n7V/TYVhQf13uOak3j4f2ukI1eCwZjQJVwQ==
X-ME-Sender: <xms:70lmZeCLRE4BvXhdM44noUu_YB3KY5kPwaGH_CmC5pvyZmQqpK-LUw>
<xme:70lmZYjqUGO357LY2B1TbgKhfeKKqK1cXxp-Xu_cBfL8iTihFZlxyKaxexlMAjskz
s2jxsfRqR2qN0jYFQ>
X-ME-Received: <xmr:70lmZRlk6hhPbZaX2woS9QDsbCYxyXzRhewilkskbhQRbQqWwrq5ywYYC-CE7qUR3_6DMwXHHti2QdmU3gpH4H5eKf1ADgWm7LGzNtVmCBhNHwI>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgse
htkeertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhp
vggtrdhtvheqnecuggftrfgrthhtvghrnhepteetkeekgfeffeejudekteeigeejffekhf
duheeileeitedvjeeiieeuffdvtdfhnecuffhomhgrihhnpehgnhhurdhorhhgpdhsvggr
rhgthhhfohigrdhorhhgpdhgihhtlhgrsgdrtghomhdptghonhhtvghnthdrrhgvrggupd
hmohiiihhllhgrrdhorhhgpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigv
pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh
X-ME-Proxy: <xmx:70lmZcyAqmvBdniBnkMLCitXLVkvC0JaAE-HKUj4r9npfv6ahcSfcg>
<xmx:70lmZTTjo-erADBdBTe7Ll4BlECtivcaXq_KnsJc_5blsGAfabmQ7Q>
<xmx:70lmZXYRv-tIg6pXANiDyYJHsdF0yXi7EoXljoE_v0ilq2em-2PgcQ>
<xmx:70lmZU6LTPEpI_l8znw2ZhOWCGAjOvsNaQnZ6RCk463YoS5bXqTHkA>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Nov 2023 15:13:34 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67512 <at> debbugs.gnu.org
Subject: [PATCH 5/5] gnu: Add librewolf.
Date: Tue, 28 Nov 2023 12:13:09 -0800
Message-ID: <d4eb9ea6777357aa04a373ed396974a541e4a9d3.1701186634.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1701186634.git.ian@HIDDEN>
References: <cover.1701186634.git.ian@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67512
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/librewolf.scm (librewolf): New variable.
Change-Id: Iea4dcf45bfaff118d1d9d6e871c4a4ff3e68a3b3
---
gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++
1 file changed, 560 insertions(+)
create mode 100644 gnu/packages/librewolf.scm
diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
new file mode 100644
index 0000000000..b1e890e518
--- /dev/null
+++ b/gnu/packages/librewolf.scm
@@ -0,0 +1,560 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2013, 2015 Andreas Enge <andreas@HIDDEN>
+;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver <mhw@HIDDEN>
+;;; Copyright © 2015 Sou Bunnbu <iyzsong@HIDDEN>
+;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner <efraim@HIDDEN>
+;;; Copyright © 2016 Alex Griffin <a@HIDDEN>
+;;; Copyright © 2017 Clément Lassieur <clement@HIDDEN>
+;;; Copyright © 2017, 2018 Nikita <nikita@HIDDEN>
+;;; Copyright © 2017, 2018 ng0 <gillmann@HIDDEN>
+;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus <rekado@HIDDEN>
+;;; Copyright © 2019 Ivan Petkov <ivanppetkov@HIDDEN>
+;;; Copyright © 2020 Oleg Pykhalov <go.wigust@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
+;;; Copyright © 2019, 2020 Adrian Malacoda <malacoda@HIDDEN>
+;;; Copyright © 2020-2023 Jonathan Brielmaier <jonathan.brielmaier@HIDDEN>
+;;; Copyright © 2020 Zhu Zihao <all_but_last@HIDDEN>
+;;; Copyright © 2021 pineapples <guixuser6392@HIDDEN>
+;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
+;;; Copyright © 2021, 2022, 2023 John Kehayias <john.kehayias@HIDDEN>
+;;; Copyright © 2022 Pierre Langlois <pierre.langlois@HIDDEN>
+;;; Copyright © 2023 Tomas Volf <wolf@HIDDEN>
+;;; Copyright © 2023 Ian Eure <ian@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+
+(define-module (gnu packages librewolf)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system cargo)
+ #:use-module (guix build-system trivial)
+ #:use-module (guix download)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix gexp)
+ #:use-module (guix packages)
+ #:use-module (guix utils)
+ #:use-module ((guix build utils) #:select (alist-replace))
+
+ #:use-module (gnu packages)
+ #:use-module (gnu packages assembly)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages bash)
+ #:use-module (gnu packages compression)
+ #:use-module (gnu packages crates-io)
+ #:use-module (gnu packages cups)
+ #:use-module (gnu packages fontutils)
+ #:use-module (gnu packages gl)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gnome)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages hunspell)
+ #:use-module (gnu packages icu4c)
+ #:use-module (gnu packages image)
+ #:use-module (gnu packages jemalloc)
+ #:use-module (gnu packages kerberos)
+ #:use-module (gnu packages libcanberra)
+ #:use-module (gnu packages libevent)
+ #:use-module (gnu packages libffi)
+ #:use-module (gnu packages linux)
+ #:use-module (gnu packages llvm)
+ #:use-module (gnu packages m4)
+ #:use-module (gnu packages node)
+ #:use-module (gnu packages nss)
+ #:use-module (gnu packages perl)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages pulseaudio)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages rust)
+ #:use-module (gnu packages rust-apps)
+ #:use-module (gnu packages speech)
+ #:use-module (gnu packages sqlite)
+ #:use-module (gnu packages video)
+ #:use-module (gnu packages wasm)
+ #:use-module (gnu packages xdisorg)
+ #:use-module (gnu packages xorg))
+
+;; Define the versions of rust needed to build firefox, trying to match
+;; upstream. See the file taskcluster/ci/toolchain/rust.yml at
+;; https://searchfox.org under the particular firefox release, like
+;; mozilla-esr102.
+(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum.
+
+;; Update this id with every firefox update to its release date.
+;; It's used for cache validation and therefore can lead to strange bugs.
+(define %librewolf-build-id "20231120132923")
+
+(define-public librewolf
+ (package
+ (name "librewolf")
+ (version "120.0-2")
+ (source
+ (origin
+ (method url-fetch)
+
+ (uri (string-append
+ "https://gitlab.com/api/v4/projects/32320088/packages/generic/librewolf-source/"
+ version "/librewolf-" version ".source.tar.gz"))
+ (sha256
+ (base32 "17yiw4pql9pf2qgk5a6xjqjjbgplla7fflrw1ldgd07rzsjlvj4n"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:configure-flags #~(let ((clang #$(this-package-native-input "clang"))
+ (wasi-sysroot #$(this-package-native-input
+ "wasm32-wasi-clang-toolchain")))
+ `("--enable-application=browser"
+
+ ;; Configuration
+ "--with-system-jpeg"
+ "--with-system-zlib"
+ ;; "--with-system-png" ;require libpng-apng >= 1.6.35
+ "--with-system-icu"
+ "--enable-system-ffi"
+ "--enable-system-pixman"
+ "--enable-jemalloc"
+
+ ;; see https://bugs.gnu.org/32833
+ "--with-system-nspr"
+ ;; "--with-system-nss"
+
+ ,(string-append "--with-clang-path=" clang
+ "/bin/clang")
+ ,(string-append "--with-libclang-path=" clang
+ "/lib")
+ ,(string-append "--with-wasi-sysroot="
+ wasi-sysroot "/wasm32-wasi")
+
+ ;; Distribution
+ "--with-distribution-id=org.nonguix"
+ "--disable-official-branding"
+ "--with-app-name=librewolf"
+ "--with-app-basename=LibreWolf"
+ "--with-branding=browser/branding/librewolf"
+
+ ;; Features
+ "--disable-tests"
+ "--disable-updater"
+ "--enable-pulseaudio"
+ "--disable-crashreporter"
+ "--allow-addon-sideload"
+ "--with-unsigned-addon-scopes=app,system"
+
+ ;; Build details
+ "--disable-debug"
+ "--enable-rust-simd"
+ "--enable-release"
+ "--enable-optimize"
+ "--enable-strip"
+ "--enable-hardening"
+ "--disable-elf-hack"))
+ #:imported-modules %cargo-utils-modules
+ #:modules `((ice-9 regex)
+ (ice-9 string-fun)
+ (ice-9 ftw)
+ (srfi srfi-1)
+ (srfi srfi-26)
+ (rnrs bytevectors)
+ (rnrs io ports)
+ (guix elf)
+ (guix build gremlin)
+ ,@%gnu-build-system-modules)
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'fix-preferences
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((port (open-file "browser/app/profile/firefox.js"
+ "a")))
+ (define (write-setting key value)
+ (format port "~%pref(\"~a\", ~a);~%" key value)
+ (format #t
+ "fix-preferences: setting value of ~a to ~a~%" key
+ value))
+
+ ;; We should allow Firefox sandbox to read the store directory,
+ ;; because Firefox sandbox have access to /usr on FHS distros.
+ (write-setting
+ "security.sandbox.content.read_path_whitelist"
+ (string-append "\""
+ (%store-directory) "/\""))
+
+ ;; XDG settings should be managed by Guix.
+ (write-setting "browser.shell.checkDefaultBrowser"
+ "false")
+ (close-port port))))
+ (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let* ((ffmpeg (assoc-ref inputs "ffmpeg"))
+ (libavcodec (string-append ffmpeg
+ "/lib/libavcodec.so")))
+ ;; Arrange to load libavcodec.so by its absolute file name.
+ (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp"
+ (("libavcodec\\.so")
+ libavcodec)))))
+ (add-after 'patch-source-shebangs 'patch-cargo-checksums
+ (lambda _
+ (use-modules (guix build cargo-utils))
+ (let ((null-hash
+ ;; This is the SHA256 output of an empty string.
+ "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"))
+ (for-each (lambda (file)
+ (format #t
+ "patch-cargo-checksums: patching checksums in ~a~%"
+ file)
+ (substitute* file
+ (("(checksum = )\".*\"" all name)
+ (string-append name "\"" null-hash
+ "\""))))
+ (find-files "." "Cargo\\.lock$"))
+ (for-each generate-all-checksums
+ '("build" "dom/media"
+ "dom/webauthn"
+ "gfx"
+ "intl"
+ "js"
+ "media"
+ "modules"
+ "mozglue/static/rust"
+ "netwerk"
+ "remote"
+ "security/manager/ssl"
+ "servo"
+ "storage"
+ "third_party/rust"
+ "toolkit"
+ "xpcom/rust"
+ "services")))))
+ (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag
+ (lambda _
+ ;; Remove --frozen flag from cargo invokation, otherwise it'll
+ ;; complain that it's not able to change Cargo.lock.
+ ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373
+ (substitute* "build/RunCbindgen.py"
+ (("\"--frozen\",")
+ ""))))
+ (delete 'bootstrap)
+ (add-before 'configure 'patch-SpeechDispatcherService.cpp
+ (lambda _
+ (let* ((lib "libspeechd.so.2")
+ (file
+ "dom/media/webspeech/synth/speechd/SpeechDispatcherService.cpp")
+ (old-content (call-with-input-file file
+ get-string-all)))
+ (substitute file
+ `((,(format #f "~s" lib) unquote
+ (λ (line _)
+ (string-replace-substring line lib
+ (string-append #$speech-dispatcher
+ "/lib/"
+ lib))))))
+ (if (string=? old-content
+ (call-with-input-file file
+ get-string-all))
+ (error
+ "substitute did nothing, phase requires an update")))))
+ (add-before 'configure 'set-build-id
+ ;; Firefox will write the timestamp to output, which is harmful
+ ;; for reproducibility, so change it to a fixed date. Use a
+ ;; separate phase for easier modification with inherit.
+ (lambda _
+ (setenv "MOZ_BUILD_DATE"
+ #$%librewolf-build-id)))
+ (replace 'configure
+ (lambda* (#:key inputs outputs configure-flags
+ #:allow-other-keys)
+ (setenv "AUTOCONF"
+ (string-append (assoc-ref inputs "autoconf")
+ "/bin/autoconf"))
+ (setenv "SHELL"
+ (which "bash"))
+ (setenv "CONFIG_SHELL"
+ (which "bash"))
+ (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE"
+ "system")
+ ;; This should use the host info probably (does firefox build on
+ ;; non-x86_64 though?)
+ (setenv "GUIX_PYTHONPATH"
+ (string-append (getcwd)
+ "/obj-x86_64-pc-linux-gnu/_virtualenvs/build"))
+
+ ;; Use Clang, Clang is 2x faster than GCC
+ (setenv "AR" "llvm-ar")
+ (setenv "NM" "llvm-nm")
+ (setenv "CC" "clang")
+ (setenv "CXX" "clang++")
+ (setenv "WASM_CC"
+ (string-append (assoc-ref inputs
+ "wasm32-wasi-clang-toolchain")
+ "/bin/clang"))
+ (setenv "WASM_CXX"
+ (string-append (assoc-ref inputs
+ "wasm32-wasi-clang-toolchain")
+ "/bin/clang++"))
+
+ (setenv "MOZ_NOSPAM" "1")
+
+ (setenv "MOZBUILD_STATE_PATH"
+ (getcwd))
+
+ (let* ((mozconfig (string-append (getcwd) "/mozconfig"))
+ (out (assoc-ref outputs "out"))
+ (flags (cons (string-append "--prefix=" out)
+ configure-flags)))
+ (format #t "build directory: ~s~%"
+ (getcwd))
+ (format #t "configure flags: ~s~%" flags)
+
+ (define write-flags
+ (lambda flags
+ (display (string-join (map (cut string-append
+ "ac_add_options " <>)
+ flags) "\n"))
+ (display "\n")))
+ (with-output-to-file mozconfig
+ (lambda ()
+ (apply write-flags flags)
+ ;; The following option unsets Telemetry Reporting. With the Addons Fiasco,
+ ;; Mozilla was found to be collecting user's data, including saved passwords and
+ ;; web form data, without users consent. Mozilla was also found shipping updates
+ ;; to systems without the user's knowledge or permission.
+ ;; As a result of this, use the following command to permanently disable
+ ;; telemetry reporting in Firefox.
+ (display "unset MOZ_TELEMETRY_REPORTING\n")
+ (display "mk_add_options MOZ_CRASHREPORTER=0\n")
+ (display "mk_add_options MOZ_DATA_REPORTING=0\n")
+ (display
+ "mk_add_options MOZ_SERVICES_HEALTHREPORT=0")
+ (display
+ "mk_add_options MOZ_TELEMETRY_REPORTING=0")))
+ (setenv "MOZCONFIG" mozconfig))
+ (invoke "./mach" "configure")))
+ (replace 'build
+ (lambda* (#:key (make-flags '())
+ (parallel-build? #t) #:allow-other-keys)
+ (apply invoke "./mach" "build"
+ ;; mach will use parallel build if possible by default
+ `(,@(if parallel-build?
+ '()
+ '("-j1")) ,@make-flags))))
+ (add-after 'build 'neutralise-store-references
+ (lambda _
+ ;; Mangle the store references to compilers & other build tools in
+ ;; about:buildconfig, reducing Firefox's closure by 1 GiB on x86-64.
+ (let* ((build-dir (car (scandir "."
+ (cut string-prefix?
+ "obj-" <>))))
+ (file (string-append build-dir
+ "/dist/bin/chrome/toolkit/content/global/buildconfig.html")))
+ (substitute* file
+ (((format #f "(~a/)([0-9a-df-np-sv-z]{32})"
+ (regexp-quote (%store-directory)))
+ _ store hash)
+ (string-append store
+ (string-take hash 8)
+ "<!-- Guix: not a runtime dependency -->"
+ (string-drop hash 8)))))))
+ (replace 'install
+ (lambda _
+ (invoke "./mach" "install")))
+ (add-after 'install 'wrap-program
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ ;; The following two functions are from Guix's icecat package in
+ ;; (gnu packages gnuzilla). See commit
+ ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b.
+ (define (runpath-of lib)
+ (call-with-input-file lib
+ (compose elf-dynamic-info-runpath elf-dynamic-info
+ parse-elf get-bytevector-all)))
+ (define (runpaths-of-input label)
+ (let* ((dir (string-append (assoc-ref inputs label)
+ "/lib"))
+ (libs (find-files dir "\\.so$")))
+ (append-map runpath-of libs)))
+ (let* ((out (assoc-ref outputs "out"))
+ (lib (string-append out "/lib"))
+ ;; TODO: make me a loop again
+ (mesa-lib (string-append (assoc-ref inputs
+ "mesa")
+ "/lib"))
+ ;; For the integration of native notifications
+ (libnotify-lib (string-append (assoc-ref inputs
+ "libnotify")
+ "/lib"))
+ ;; For hardware video acceleration via VA-API
+ (libva-lib (string-append (assoc-ref inputs
+ "libva")
+ "/lib"))
+ ;; VA-API is run in the RDD (Remote Data Decoder) sandbox
+ ;; and must be explicitly given access to files it needs.
+ ;; Rather than adding the whole store (as Nix had
+ ;; upstream do, see
+ ;; <https://github.com/NixOS/nixpkgs/pull/165964> and
+ ;; linked upstream patches), we can just follow the
+ ;; runpaths of the needed libraries to add everything to
+ ;; LD_LIBRARY_PATH. These will then be accessible in the
+ ;; RDD sandbox.
+ (rdd-whitelist (map (cut string-append <> "/")
+ (delete-duplicates (append-map
+ runpaths-of-input
+ '("mesa"
+ "ffmpeg")))))
+ (pulseaudio-lib (string-append (assoc-ref inputs
+ "pulseaudio")
+ "/lib"))
+ ;; For U2F and WebAuthn
+ (eudev-lib (string-append (assoc-ref inputs
+ "eudev")
+ "/lib"))
+ (gtk-share (string-append (assoc-ref inputs
+ "gtk+")
+ "/share")))
+ (wrap-program (car (find-files lib "^librewolf$"))
+ `("LD_LIBRARY_PATH" prefix
+ (,mesa-lib ,libnotify-lib
+ ,libva-lib
+ ,pulseaudio-lib
+ ,eudev-lib
+ ,@rdd-whitelist))
+ `("XDG_DATA_DIRS" prefix
+ (,gtk-share))
+ `("MOZ_LEGACY_PROFILES" =
+ ("1"))
+ `("MOZ_ALLOW_DOWNGRADE" =
+ ("1"))))))
+ (add-after 'wrap-program 'install-desktop-entry
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((desktop-file
+ "taskcluster/docker/firefox-snap/firefox.desktop")
+ (applications (string-append #$output
+ "/share/applications")))
+ (substitute* desktop-file
+ (("^Exec=firefox")
+ (string-append "Exec="
+ #$output "/bin/librewolf"))
+ ;; "Firefox" -> "LibreWolf" in all the Name fields
+ (("^(Name.*)(Firefox)(.*)$" prefix _ suffix)
+ (string-append prefix "LibreWolf" suffix))
+ ;; Remove non-Latin translations.
+ (("^Name\\[(ar|bn)\\]")
+ "")
+ ;; Replace "Firefox" in the keywords
+ (("^(Keywords.*)(Firefox)(.*)$" prefix _ suffix)
+ (string-append prefix "LibreWolf" suffix))
+ (("Icon=.*")
+ "Icon=librewolf\n")
+ (("NewWindow")
+ "new-window")
+ (("NewPrivateWindow")
+ "new-private-window")
+ (("StartupNotify=true")
+ "StartupNotify=true
+StartupWMClass=Navigator"))
+ (copy-file desktop-file "librewolf.desktop")
+ (install-file "librewolf.desktop" applications))))
+ (add-after 'install-desktop-entry 'install-icons
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((icon-source-dir (string-append #$output
+ "/lib/librewolf/browser/chrome/icons/default")))
+ (for-each (lambda (size)
+ (let ((dest (string-append #$output
+ "/share/icons/hicolor/"
+ size
+ "x"
+ size
+ "/apps")))
+ (mkdir-p dest)
+ (symlink (string-append icon-source-dir
+ "/default" size ".png")
+ (string-append dest
+ "/librewolf.png"))))
+ '("16" "32" "48" "64" "128"))))))
+
+ ;; Test will significantly increase build time but with little rewards.
+ #:tests? #f
+
+ ;; WARNING: Parallel build will consume lots of memory!
+ ;; If you have encountered OOM issue in build phase, try disable it.
+ #:parallel-build? #t
+
+ ;; Some dynamic lib was determined at runtime, so rpath check may fail.
+ #:validate-runpath? #f))
+ (inputs (list bash-minimal
+ bzip2
+ cairo
+ cups
+ dbus-glib
+ freetype
+ ffmpeg
+ gdk-pixbuf
+ glib
+ gtk+
+ gtk+-2
+ hunspell
+ icu4c
+ jemalloc
+ libcanberra
+ libevent
+ libffi
+ libgnome
+ libjpeg-turbo
+ libnotify
+ ;; libpng-apng
+ libva
+ libvpx
+ libxcomposite
+ libxft
+ libxinerama
+ libxscrnsaver
+ libxt
+ mesa
+ mit-krb5
+ nspr-4.32
+ ;; nss
+ pango
+ pipewire
+ pixman
+ pulseaudio
+ speech-dispatcher
+ sqlite
+ startup-notification
+ eudev
+ unzip
+ zip
+ zlib))
+ (native-inputs (list alsa-lib
+ autoconf-2.13
+ `(,rust-librewolf "cargo")
+ clang
+ llvm
+ wasm32-wasi-clang-toolchain
+ m4
+ nasm
+ node-lts
+ perl
+ pkg-config
+ python
+ rust-librewolf
+ rust-cbindgen-0.26
+ which
+ yasm))
+ (home-page "https://mozilla.org/firefox/")
+ (synopsis "Trademarkless version of Firefox")
+ (description
+ "Full-featured browser client built from Firefox source tree, without
+the official icon and the name \"firefox\". This is the Extended Support
+Release (ESR) version.")
+ (license license:mpl2.0)))
--
2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:14:02 2023
Received: from localhost ([127.0.0.1]:47788 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r84Sw-0003NK-4J
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:14:02 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34257)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ian@HIDDEN>) id 1r84Sn-0003MJ-OC
for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:46 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 78CB55C0245;
Tue, 28 Nov 2023 15:13:33 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm3; t=1701202413; x=
1701288813; bh=9bCeScb0nTG+ahqUiR03jJDlvtqYrHOMchSxHi0S/Ok=; b=N
tbCHnCKbaRJjHqGQJz3VklvF5rQ8Cbt99Mj+1cWVCPQT1bAK4zxXnFW0n5tmd+Af
kLE3T26C2vCVqQMQHJc/biGZtXU6imiMjo1NpcvKoLI4+FFcpezHxtoR5s1r9oqk
PUt4mTT/Nbh3YQE96GN0BG6E2iLO03HuEGHSOP+tHLu76JmV1cVTfs+nmgHqfS3+
joN/nn3Ff5sfnLmMtVrnpoWTqltB1sPK7RLDyYAnc8aKFRitW6fuJMJT368qa3Cp
iHSKOBPmVO+ThekykhwcO1kwqXDrNvrhZgQT4Yzh8CnC14Br+qqeyLN6US+qn6Jx
LgF/z0/gorZzeW7bySwtQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202413; x=
1701288813; bh=9bCeScb0nTG+ahqUiR03jJDlvtqYrHOMchSxHi0S/Ok=; b=t
4uFD50DtElmjwfNo/T6hAvpxdSv38rKzmslX5f1YCPF5KcENSmjBjaa8MdJSX+qI
RCOT4xST+0rHaGdQyVxj8MBKMcuSCtD9iDDUyWkhD/QW8c7x7Zeq0PSbYl6hyU/w
ayyhX+/SkYCQEmmapsIqXGsGMYhY25yk9Gb74tSqDXe6uBkBChlcvxMI00e5mQhC
dkltstxim49VHnIbcfy/Km4/sH4GhMD6RYiIMagIplwgves7UdRxKlzBsS1xg7cP
BwJWsrlmrChk//7No42UzUYPK5z/1W9Ue5Oy7AffvZ2Zw+PLEruy1dWqp3/i7PWb
vdMb7DQi2T+3YkbqedwuQ==
X-ME-Sender: <xms:7UlmZZUF8XlWMsYDmL67889TFsD8Z17G10TXxqV-8uqMM0uM0IuooA>
<xme:7UlmZZla9Rldp6yXr2Ys1uU8zztctAwJc8e1vUUqUsfPefm_hcKObiq3DyOqOtIsL
Ok9HrpYPl_9vsfg0A>
X-ME-Received: <xmr:7UlmZVZhSafe85xwUImB2peYVpDEqEJC0Hjg_pU4l5wcG543VPp0umdYHQlG2FreddVhUeATL7PkMaet2_x8VLy7Au-NqqpBpKJXSJ-81FuMae4>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd
ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv
tgdrthhvqeenucggtffrrghtthgvrhhnpeevveejffduvdetieeutefgueekvdefieeuvd
evleefgefhudelfeetvdfgfeegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
mhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh
X-ME-Proxy: <xmx:7UlmZcUh3btuQvp4lBMLiGEUdcF9NTDke_BPkNbnwoWa4qvnNy-2xg>
<xmx:7UlmZTkjXt1VL6PaUK7Owy-c3_S035cKieo23BIsywQKvktWF6FahA>
<xmx:7UlmZZfRLDz_He4QMPbTacEpY8rKGHD7lGOvuMaMz5y7FSX_dEvp9w>
<xmx:7UlmZSsTpcdSngJNfUjuAO7mNsvBilXLyZu6MlHO9zE78hkAjTNZLA>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Nov 2023 15:13:32 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67512 <at> debbugs.gnu.org
Subject: [PATCH 3/5] gnu: node: Switch to icu4c-71.
Date: Tue, 28 Nov 2023 12:13:07 -0800
Message-ID: <962283668728cbee1d762202f07c4923394a6115.1701186634.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1701186634.git.ian@HIDDEN>
References: <cover.1701186634.git.ian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67512
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/node.scm (node): Switch to icu4c-71.
I encountered consistent test failures with icu4c 73.1.
Change-Id: Iaad9a4f274f9e3b8736486b58f262a82304b0b5d
---
gnu/packages/node.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 6e30ad486a..668847405d 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -290,7 +290,7 @@ (define-public node
;; Runtime dependencies for binaries used as a bootstrap.
(list c-ares
http-parser
- icu4c
+ icu4c-71
libuv-for-node
`(,nghttp2-for-node "lib")
openssl-1.1
@@ -310,7 +310,7 @@ (define-public node
coreutils
c-ares
http-parser
- icu4c
+ icu4c-71
libuv-for-node
`(,nghttp2-for-node "lib")
openssl
--
2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:13:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:13:54 2023
Received: from localhost ([127.0.0.1]:47786 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r84Ss-0003NA-ND
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:54 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59075)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ian@HIDDEN>) id 1r84Sm-0003MH-LX
for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:44 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id 6D3ED5C025E;
Tue, 28 Nov 2023 15:13:32 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Tue, 28 Nov 2023 15:13:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm3; t=1701202412; x=
1701288812; bh=2L9fGLzl+XT0Acil3G2CmJXiHPmMK4e/E0+k7fl+obE=; b=L
+Lr0tLFdU2cjkx0gPpglqwjIa7K9sRjRD1D7x+AIbVELP9cLJ6g3cdKtvErtDRNg
ob5k2bKsxGOEtk8n1MEVDGXfwlvSiudLqOMAtzDeYTHmitpgqJyGU9PwR1J6sg3j
jh4R1+gB1h45sXkA9+rvHD+v4MveqnA9gLZT/KRABAh5GwrJOKRm9wTSVswsqitN
1v5G6ecnl0wqwXNZ6ys7FKsaG0M20j0C1Qo7mQ3dZ1S0KEE+cSz9l0penilbvNah
Fd9GwPidj6fmUbP0lEnoG6IUBwz3Fd9tuYGoscDky8EuFhGB1TYqiSYkq9+thisQ
5J8smGDndcbFtn/+nUJUg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202412; x=
1701288812; bh=2L9fGLzl+XT0Acil3G2CmJXiHPmMK4e/E0+k7fl+obE=; b=G
BR/jTZ3gIspCtvNqUSu4pMCjPV0ufdfRBymMBWAGaO/zx4bjiOkF9DQMiXioaWxI
fktYLX1K8q4aPOksGgRG655nsYbsgzFAMtSjjR4TMh4iiAgfyAgV9ypQ8O4Xn3gb
8oQ+znIPsMgyCwoO2s9GjV80sOOI/qZNwscHouHvgpYRSrINLrdSZN/vMZQWWQ7z
5rsTl1tXZIpdDWZXrsrXeun2Wn0k1/YDeb7V8NKD6fsRyERLBTrn9y13whZuSx/E
wiUxQauXSpAAoXygjp9N/z9wBFZozpB5JO3PWnmi8/+fi4I3VF5y3sbgAy5Gx8ew
4EJb0nJBih5bXz3lG4jLg==
X-ME-Sender: <xms:7ElmZTxX_F0zMD39lCun_VDjNHaVZXAwhlhu9TDZ1wOlgxTNMEJBCg>
<xme:7ElmZbQoF3ZNMKIBkPE4dSBRGBhz2-FJF3apB5hVQv0GO2iGw3SM1BrDnr6k1T66_
Zr4w9JjAny7EJW8CA>
X-ME-Received: <xmr:7ElmZdVkvqudGxFO4MuXAlmYJJBHeUlVT8KLaHoWOagWE3mvsQf9okPLM4z7xR7BTuwwsc7rE-x4A4OVYH1Dm021cKAdYOo1-2s_CHu2JEgKzLE>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd
ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv
tgdrthhvqeenucggtffrrghtthgvrhhnpeejgedukeefleetjeegtdejveelgfektdeige
elvdetheetjeegteeiieekhffgheenucffohhmrghinhepihgtuhdqphhrohhjvggtthdr
ohhrghdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg
hmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv
X-ME-Proxy: <xmx:7ElmZdi45x0PQ25O75vrKL4Q8FE0-2yr8gSg6jfj7UQFTpwEbBrjNQ>
<xmx:7ElmZVCIH9-Ms4FcX6kKZWzIiBw9QI8QVKWkdJlUcXK56_OP_gmUQg>
<xmx:7ElmZWKGi9-7yE5dU2IUd7gyK3T_xZuAQ90GgfBUk6xDqeStqLU7yw>
<xmx:7ElmZYpnQWpHtOCeMGuFJ_1rnmKFeA5Kv2UUsDdpdmeHd2AtElVDCA>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Nov 2023 15:13:31 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67512 <at> debbugs.gnu.org
Subject: [PATCH 2/5] gnu: Add icu4c-71.
Date: Tue, 28 Nov 2023 12:13:06 -0800
Message-ID: <d75b895ec112693dc5c5d907b99407216597bced.1701186634.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1701186634.git.ian@HIDDEN>
References: <cover.1701186634.git.ian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67512
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/icu4c.scm (icu4c-71): New variable.
Change-Id: Iaff0df4d6aaa968cdc43f847bd2ced08d0f3a12e
---
gnu/packages/icu4c.scm | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm
index 64ae109952..376cbac5c6 100644
--- a/gnu/packages/icu4c.scm
+++ b/gnu/packages/icu4c.scm
@@ -110,6 +110,22 @@ (define-public icu4c
(license x11)
(home-page "http://site.icu-project.org/")))
+(define-public icu4c-71
+ (package
+ (inherit icu4c)
+ (name "icu4c")
+ (version "71.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/unicode-org/icu/releases/download/release-"
+ (string-map (lambda (x) (if (char=? x #\.) #\- x)) version)
+ "/icu4c-"
+ (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version)
+ "-src.tgz"))
+ (sha256
+ (base32 "1gqywaqj9jmdwrng9lm6inyqmi5j2cz36db9dcqg3yk13zjyd9v7"))))))
+
(define-public icu4c-70
(package
(inherit icu4c)
--
2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:13:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:13:50 2023
Received: from localhost ([127.0.0.1]:47784 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r84Sq-0003Mu-Ii
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33489)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ian@HIDDEN>) id 1r84Sl-0003MF-HZ
for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:43 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 4CD115C011A;
Tue, 28 Nov 2023 15:13:31 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm3; t=1701202411; x=
1701288811; bh=mWDIOgM1C53qxx17F6v0soa9615bp3pdhpRrq61LvKM=; b=C
klm0IUfwrSrBaYYUB7KuIbIPVwoOZnBQuPLCUwt2XMRbknwYxSgHHpvOmHUAfBIM
RCsuWNu0uNcnSH56RCHVF9RtQM4m08VpFW9IyxTSQHB9WjHIvbNBFHa9nCcHmhRF
1UzPdkEHr+kIw2o+/b/7QifwTUH2ej8iGosGIohMq37DHXhjHBiF0S0hNSNBYlXA
/EvE8lLMv3MycCX7fSmEoO2m+/g2gM6ZgBLEjWrQ9YLdI5nG2BW32pBgkkIfBsUw
48J5K2LuoS+yqdhAFK5Tblyfq5tfp8TFAMOp1KeV987tKqUA2/ZiD8IQMsRGHKB/
+YVkF3eyz92SZWkd9hxHA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202411; x=
1701288811; bh=mWDIOgM1C53qxx17F6v0soa9615bp3pdhpRrq61LvKM=; b=p
ZghzIUpP6BVf3fsg54Cs+pj2ci/wz8Q1k/3ltxhtSFFNMHjxpAPwbTzYrgxYiWfw
ukx5+JnYRkx8vX7746j65IVImlG7M/tJRw12CwIQFiUvfoaXzFaxlflvX00BpiYY
Kx9cyvxXd6yx1M9IlSPNjfdfzY4E6wYhCb98jC1rhM6qIZHkzO+J/4Vv/yjPURnV
8G8Q2uxm85leaBEy6tNbARmxZgm/4hiP8+7PN5n6n0PzJq4L+cf0cmnT8Z/cU0QJ
W8Fr9SEaTo/T0c1UIzXt6tKuMkRrF5TX1MyLt+A6GacGCnWR+1RzWOFYE1uhRGOy
102KIqgkJAYtToTnLwKiA==
X-ME-Sender: <xms:60lmZQ4vNI4EPO6uhzqZRvcM-wY9stBLQNgcfpcRW1OOSYGCQrEEdQ>
<xme:60lmZR65XDvU6kZojyO0R0QsIhOoYjBysj3AU6BBKRKvV2uSOe2tx8KZ194bFjAxh
49sg8KbjXWhnJVKbg>
X-ME-Received: <xmr:60lmZfcd1DfiWqh-CKrrCpuXVb9Ffm1XYiD2sxn6B5HVFPOTkjx9zJz90ih6-sJswYOBKufm5cOredYU9Zqi4YvYUjx5fRitLi9D3DuLUnE3nms>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd
ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv
tgdrthhvqeenucggtffrrghtthgvrhhnpeevveejffduvdetieeutefgueekvdefieeuvd
evleefgefhudelfeetvdfgfeegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
mhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh
X-ME-Proxy: <xmx:60lmZVIY1G6jVNh7LG6ZkM_KZTadR6S2V4hloqxM2Bqqhi3dWlbrtA>
<xmx:60lmZULLA4IEDHymE7XWhQJTXQLmp9tQwaG1PCy26-WZYTokrJlEMw>
<xmx:60lmZWxz-eH3Pav_KrVaw8qFiyTnOe0wORxQihjaadeptN-J2Ujhcw>
<xmx:60lmZexi9NaCbAYc2rqBdw0RM35HoJxKhtlt5lWr3RIaR6y6TEE-Lg>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Nov 2023 15:13:30 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
To: 67512 <at> debbugs.gnu.org
Subject: [PATCH 1/5] gnu: icu4c: Update to 73.1.
Date: Tue, 28 Nov 2023 12:13:05 -0800
Message-ID: <5ebb1528778467e817b168d3c7bdad3829d1451c.1701186634.git.ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1701186634.git.ian@HIDDEN>
References: <cover.1701186634.git.ian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67512
Cc: Ian Eure <ian@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/icu4c.scm (icu4c): Update to 73.1.
Change-Id: I77b8186898494e5b677c2e0c4fb0a234747dbd29
---
gnu/packages/icu4c.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm
index 5aaf3a8361..64ae109952 100644
--- a/gnu/packages/icu4c.scm
+++ b/gnu/packages/icu4c.scm
@@ -45,7 +45,7 @@ (define-module (gnu packages icu4c)
(define-public icu4c
(package
(name "icu4c")
- (version "71.1")
+ (version "73.1")
(source (origin
(method url-fetch)
(uri (string-append
@@ -55,7 +55,8 @@ (define-public icu4c
(string-map (lambda (x) (if (char=? x #\.) #\_ x)) version)
"-src.tgz"))
(sha256
- (base32 "1gqywaqj9jmdwrng9lm6inyqmi5j2cz36db9dcqg3yk13zjyd9v7"))))
+ (base32
+ "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4"))))
(build-system gnu-build-system)
(native-inputs
(append (list python-minimal)
--
2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:13:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:13:44 2023 Received: from localhost ([127.0.0.1]:47770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r84Sm-0003MZ-4d for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:44 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ian@HIDDEN>) id 1r84Sk-0003MD-Bg for 67512 <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:13:43 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2312C5C018E; Tue, 28 Nov 2023 15:13:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 28 Nov 2023 15:13:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1701202410; x=1701288810; bh=hPDZZBFRXH KdJikifM+3wvFl7hfCcdh6GtAAw+qOqBI=; b=e166JkKBrhVYFdMiDBdNvaGwqu 00BLgYcaxN/U8uu8XhXu2tK3x4cj59Lk5s39GXvvDi8v19DmMKSuxsyggXm5r8vh Dwy6shsKtgC/3Ba+Vx9trl1kz3ilS3xWkgfTnihrHI1FKs2uQJLdcByvswVGyBdt dE5CwTimAtzAfY6HhhPoDyzGb/z1XiD5nLscKjneTTgTTD9H1FGKtR0IgE7uuY+r MAVULdcODhOJT5QdRw4TcG0TuEfB88V/OzHjjAJEK313A7QBY/SXkEZ472eOzioS MyoRACg6Rg1vtpRPjc/XinoPeBROqUBx4wu3iVaVNniIqDZ9H+bj8pfRQjXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701202410; x=1701288810; bh=hPDZZBFRXHKdJ ikifM+3wvFl7hfCcdh6GtAAw+qOqBI=; b=CyJgC2S7KcrZ5ZbTmaPeAYpgYkNLw Ya2YotbkDQFkYrgIJ6Cpv9Pbc++8/B/4nAnfWBvJTox+nAMWd/6Fh3zQo9av/sDb KWPdOY+VSHVbffzZJk3TYQpZtZkDgqKljNFNpqrgqW5lpjm3fy0MTeTbY5T69xZ4 ASJNWcMDrNyhjoAqfOZ6psRBgoj6mYr2Ge+EZQsiUGnkGI2FfG1G0CcwMtuhlgO/ sdCckH9ct4d9sn1kutJTz+djvlkuN9n7EhRdWdWn9ET1eV3/VVAnFmJuT5xPRbbL +8a8kfk1zeEYL+4NaIx7BuZwnr/u+Ar+F2y1xoN0+VWSKCLPHerkXQDfw== X-ME-Sender: <xms:6UlmZYkZNfKcgh4TOMb5B0jVp6uMrrHoNbIcLjpxXqu1P__AaK330A> <xme:6UlmZX0Rz3UZuyABUWvqEsxYXOlC3yYRS751-YbjOXuIfd5oBSQavUgJO4ywWjmZp gObvokOFOpGhom_HA> X-ME-Received: <xmr:6UlmZWoYfa98RE8ObLTcgJy1fGbHtfrCxDjfXzQjJspj3wDvOZEP0srj-F26WnjrF64fRMWBYvHrjP7Np_mTTFYqtrJCLVT0x-vi5kZU1x9Sdwo> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekre dtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeegudekvddtvefhieejvdefvedugfejjeduuddvvd ekkefgleehudfhheegkeetgfenucffohhmrghinheplhhisghrvgifohhlfhdrnhgvthen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse hrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: <xmx:6klmZUkNzs6jZhGhBfF89i8eVMiSEfMbsEis_xcqMXTc5gGoJrkBIw> <xmx:6klmZW0CO_czera7HhrQmDbGaghy1cATSYAOXafzkhjYmM8YcqRiyA> <xmx:6klmZbuSsItdiE_q2DxFY_IxhwmvhVTb6GQptCL7rnhy8SQ3OKVGlQ> <xmx:6klmZb8Y6darv2ImDvcjSizF6UxX4QpUkkzlnbetcRRwFXCU86E4Vw> Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:29 -0500 (EST) From: Ian Eure <ian@HIDDEN> To: 67512 <at> debbugs.gnu.org Subject: [PATCH 0/5] Add LibreWolf Date: Tue, 28 Nov 2023 12:13:04 -0800 Message-ID: <cover.1701186634.git.ian@HIDDEN> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) I mentioned in #guix that I was working on a package for LibreWolf, and it was requested that I send in patches, so I am. These changes are based on the firefox-esr package in nonguix; I've retained the copyright / authorship notices from there. LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the telemetry and advertising, and bundles uBlock Origin. It doesn't have the redistribution issues that Firefox does, its name/logo are under MPL 2.0 and aren't trademarked. I'm new to Guix, and not remotely a browser development expert, so I don't expect these are ready to be accepted yet, but I believe they're in good enough shape to have a discussion about. Guide to changes in this patchset ================================= icu4c has been updated to 73.1, and the previous version kept as icu4c-71. I encountered consistent failures of the node@HIDDEN test suite with icu4c 73.1, so I kept that on 71.1. icu4c is needed by many packages, so this change is the highest-impact in the patchset. The (gnu packages wasm) module is unchanged from nonguix, except for the file header and module declaration. The (gnu packages librewolf) module is a simplified/adapted version of (nongnu packages firefox). The Firefox Nightly packages have been removed, as there's no LibreWolf equivalent. I also didn't bring over the wayland variant, but I could, if that's desired. I'm not sure why there are specific x11/wayland variants, as the packages for other distros don't seem to need this split. The librewolf package has some functions duplicated from (gnu packages gnuzilla), which probably ought to get factored out and put somewhere, but I'm not sure if they should be in (gnu packages mozilla) or a different module. Guidance would be appreciated here. Ian Eure (5): gnu: icu4c: Update to 73.1. gnu: Add icu4c-71. gnu: node: Switch to icu4c-71. gnu: Add wasm packages. gnu: Add librewolf. gnu/packages/icu4c.scm | 21 +- gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ gnu/packages/node.scm | 4 +- gnu/packages/wasm.scm | 273 ++++++++++++++++++ 4 files changed, 854 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/librewolf.scm create mode 100644 gnu/packages/wasm.scm base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf -- 2.41.0
guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 28 Nov 2023 20:11:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 15:11:04 2023 Received: from localhost ([127.0.0.1]:47760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r84QA-0003IP-Se for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:11:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ian@HIDDEN>) id 1r84Pu-0003He-Ku for submit <at> debbugs.gnu.org; Tue, 28 Nov 2023 15:11:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ian@HIDDEN>) id 1r84Pf-0007u6-JT for guix-patches@HIDDEN; Tue, 28 Nov 2023 15:10:32 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ian@HIDDEN>) id 1r84Pc-00005j-K3 for guix-patches@HIDDEN; Tue, 28 Nov 2023 15:10:31 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 929FA5C02BE; Tue, 28 Nov 2023 15:10:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 28 Nov 2023 15:10:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1701202224; x=1701288624; bh=BJ/24/wJcL cN7UACcZWZebL3JneQX0YEeqISvoO37MI=; b=Jmh32c3AGGeaFY8NIFfgPVyQkB gnMaqHOGRNLIvEK/mK3fZonXy+bs1rSoIZxWabb0V9wOaD5jN0JN1ke2T9xTTeVE +FtekUXnoZ94CywMCuxXORRUAIeqVM3BvhI9kAZ2K8dDLyUDRoRWBWGtYjokGhbz on0XwqO5svIyrMX/oNj4hqRW2SgZ3uPB7otqOldedOrVHEJeT9dzHM0md6DUhdIZ NGNS4ouk+zPvuqD5vOnQYQ+3gZk0v4vdwRMWWihHJUioR5wVEkhRuc+Z9xm7ieAW Nu1JkucF/KMIS76+jGMqI+8+soOoV/Us71B7qPi8IU/jYByH0PTsxJoeD6jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701202224; x=1701288624; bh=BJ/24/wJcLcN7 UACcZWZebL3JneQX0YEeqISvoO37MI=; b=HbZ2oQwqAA6dZxAvwR7odA/WGIhWr 3WiXEJhJoIyLYmqCc4KF8M/+O4CVoF8cpmLQhWOlLTl8P+42ZsEeOr562MzPMLcA EJrMiRG2AuaVxbOpvdHp2zsQAx+cg1gp+p/xKmT/1kElPhtcqjMJUSpzlKyZJWbj jlNxjihXlSkkNQvuIS/Edd8NNzLUKTwXU2cQ2x5VHjqijoJ3xZMAfLDEIeccM0Kt PKqq4NJE0rb6NmJRrtbATZHjY/Ygajn3Xjr3bmeA3aCBJ4by5oSAr/yZodv+lDy0 x3kpvcEABHisllwVpz1l62O42W1baRn5P0tkR9cmhEvq+G2Or6S1Ihr+A== X-ME-Sender: <xms:MElmZfCyEkGQDp1-URZ4ryLXMZzcpxwVihgZmwSePTGqvpWNYH1aHg> <xme:MElmZVjs794Ne5WWr1AUvo9e26O9uKd7Wx0BKJbuTj6re6tlgwd15QpvIH29tGm1x N0GH0WOdr18_uQ9OQ> X-ME-Received: <xmr:MElmZakJ_6JgSNmvZXL2GUX7lmuoL1-gjQ3Gs6z8ZlVO2tnrvh7pHbZF8BEKXdOMlNDDbzH9dC_kTlhz1IAAhE3kkj7nBW0zIA8CGz42RsxBQwE> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekre dtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeegudekvddtvefhieejvdefvedugfejjeduuddvvd ekkefgleehudfhheegkeetgfenucffohhmrghinheplhhisghrvgifohhlfhdrnhgvthen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse hrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: <xmx:MElmZRxf9ENOFHhFiqezZnPlA0Io6NMZ9MzZYX8QtBWSkqa3zvCTkg> <xmx:MElmZURrk66MckMjoVReg5GWDO5jKnByGWaw4brHAJYG2eQU6GDj3A> <xmx:MElmZUZguiJ9NXQ2phFcbm_lVoJDiYl0OwAUWljQnr14zGfGeSkzfQ> <xmx:MElmZd5Smu7cVAvICaTxW9qSDtLmVFFXPO6lBzLC8Ua5m3GaBI5PtA> Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:10:23 -0500 (EST) From: Ian Eure <ian@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH 0/5] Add LibreWolf Date: Tue, 28 Nov 2023 12:09:56 -0800 Message-ID: <cover.1701186634.git.ian@HIDDEN> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.28; envelope-from=ian@HIDDEN; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.4 (/) I mentioned in #guix that I was working on a package for LibreWolf, and it was requested that I send in patches, so I am. These changes are based on the firefox-esr package in nonguix; I've retained the copyright / authorship notices from there. LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the telemetry and advertising, and bundles uBlock Origin. It doesn't have the redistribution issues that Firefox does, its name/logo are under MPL 2.0 and aren't trademarked. I'm new to Guix, and not remotely a browser development expert, so I don't expect these are ready to be accepted yet, but I believe they're in good enough shape to have a discussion about. They're working acceptably well for me, though I'm not currently daily driving Guix, so there may be issues I haven't encountered yet. Guide to changes in this patchset ================================= icu4c has been updated to 73.1, and the previous version kept as icu4c-71. I encountered consistent failures of the node@HIDDEN test suite with icu4c 73.1, so I kept that on 71.1. icu4c is needed by many packages, so this change is the highest-impact in the patchset. The (gnu packages wasm) module is unchanged from nonguix, except for the file header and module declaration. The (gnu packages librewolf) module is a simplified/adapted version of (nongnu packages firefox). The Firefox Nightly packages have been removed, as there's no LibreWolf equivalent. I also didn't bring over the wayland variant, but I could, if that's desired. I'm not sure why there are specific x11/wayland variants, as the packages for other distros don't seem to need this split. The librewolf package has some functions duplicated from (gnu packages gnuzilla), which probably ought to get factored out and put somewhere, but I'm not sure if they should be in (gnu packages mozilla) or a different module. Guidance would be appreciated here. Ian Eure (5): gnu: icu4c: Update to 73.1. gnu: Add icu4c-71. gnu: node: Switch to icu4c-71. gnu: Add wasm packages. gnu: Add librewolf. gnu/packages/icu4c.scm | 21 +- gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ gnu/packages/node.scm | 4 +- gnu/packages/wasm.scm | 273 ++++++++++++++++++ 4 files changed, 854 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/librewolf.scm create mode 100644 gnu/packages/wasm.scm base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf -- 2.41.0
Ian Eure <ian@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#67512; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.