GNU bug report logs - #67937
30.0.50; auth-source-pass relies on epa-file being enabled

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Arsen Arsenović <arsen@HIDDEN>; dated Wed, 20 Dec 2023 17:02:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 29 Dec 2023 09:38:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 29 04:38:46 2023
Received: from localhost ([127.0.0.1]:40787 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rJ9KI-00086S-3s
	for submit <at> debbugs.gnu.org; Fri, 29 Dec 2023 04:38:46 -0500
Received: from mout.gmx.net ([212.227.15.18]:45569)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rJ9KF-00086C-Hj
 for 67937 <at> debbugs.gnu.org; Fri, 29 Dec 2023 04:38:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703842709; x=1704447509; i=michael.albinus@HIDDEN;
 bh=kgAOvGOdcBBMj1zP25CIrFKQhJOm4eI+BlAAs4GGRks=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=Xdl19x8jsToH0RCU8uZtSQ7FRAqA9IA40WPY8vKahqhupY05KO1osUxzYULtV+xr
 VclEtONDVO4FLf9cx7eWwTm42bmfk/K01slq63FIKDHVTRG1VD/jbmo3qPcUC+QXJ
 t0F1zfBBmgrCVCd7/Wixh3x/1PrlN4WjvTuKfvd2E/AQZP7O5Zr9ZZ/3+S05FjOmR
 2DU0yts6d4uvuFSFOl33UuGeDCYFTvfJigmY2jLB9YOfuzEuM0Ktwf3mpiLqoyLKB
 qBzTMpxRozWgcebf+H2OcdSQdtYQhARI06VnD4kESfE+12wLzNUfewmkQlDjOa+vb
 EW+Z/RF33Vj/EZMWxw==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfNl-1qxusV46Bj-00v46P; Fri, 29
 Dec 2023 10:38:29 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <8734vlflpf.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Fri, 29 Dec 2023 09:27:59 +0100")
References: <8734vwq06i.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
 <86h6k77qco.fsf@HIDDEN> <87v88nk5md.fsf@HIDDEN>
 <86y1dj4l71.fsf@HIDDEN> <87le9jjyu6.fsf@HIDDEN>
 <8734vlflpf.fsf@HIDDEN>
Date: Fri, 29 Dec 2023 10:38:27 +0100
Message-ID: <87bka9ic18.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:hYlWy8AwR7ewgxocNYU5Xd9b70DJhs6MJnlMT9xSvFSzQ0+FQ6M
 oi4TQwuqCAsB+jPpT+gs9Fs28Hq4GNQM8YgGNryDmb8ITjGAuK9DZJy94VmUYLaI74Z0KdX
 e/t7YSLD4gjKXSVaTBwa4IEN9a5N+l8I66bl/syjZdE7i0RpQteuBUVxVgIdPRqbWRyET3m
 Y/JZbFSwz9F/LIz7cnDNg==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:Ex46rRac674=;2hSBFqOu7uCxZRs4L+VsW9MwicJ
 OEDuUQ/mqe6WCAvFOLWqzXg9kEBKNrZENNMUTUNFMYjcfKIYBR3zQGh99lLn3H1bTYlKEkfCE
 8grOUsJy26BwyTida96a1CSf7bKE9MILSzW9Dy7rfsfJFsVpRHfPhPR4btpWcRXKMlAEllyQQ
 tUJdZrnymqWBzL9YQWjMnyBuv3DqK+rGnoFiv66nJGsEDW8elbz1J9T9kxRSOIldJWjfOJ2Lt
 KMUJ73hu7KGUZ3iuVnHJfzlC7+GOChVwJ/lSmv9u8QdQQ3+DirxWITSQyTP0+HslAYHsDPbWq
 kLZL33r4/XvUHc7fribcJ1YaW9S6jhPUejJPA/y3s7zZLnnZlA+h9/ZgvWjAP+aicQ675anLR
 snzDSqbPWJt+Z08TWOPQIJLOIA5sfFdnz6pW8YBgcxHReuIkClqdK7wahgKL7yL/aQU/+EXTr
 GJxRs8mSwak99TEb2SskI9Voa2QL5qwt/4MXTQuxq/G47Vrjo5pteLku8sFPHfpRC0VxKR29B
 FBnL3nXGkiQd4hWAR5Di88MJ7y7kCowBNwibzh5pxo7GlGVAb2X/eyzb0Xwzxmd64l5FvKQ7u
 4vWCFwv41mzVImTBm9vGrQ0QhpjrsROz/SxmycwwjCqCmcaQ5ttqq3MM4uS4h3psDUQTw80k0
 zTbj7SU782wlFoHoQv/WgWDJLfYdeXk9t7UaZUKI11LWmn834nmgHqSHU/w9hZTJSXw9u1fNF
 jAi6ZEEIXI/ef+L0GsC6bpXukgWaZpNb5UFRcxdsfHSzmk9/4D18SgEWMJ5pg+XVYuFGr9q5v
 I+MhIp4mxrtrkB+0LAYKT6r6uq8+DAlicdsBtlSX58YPx2LgWzFfJqke4Wr3GLtKIUAveDLHT
 Wjw42KfjPE5GYHtD5mbJoqUl26OzeDxNWL7EO1BHr+SZJVqRudntDLRvhZRkRLhXesZwtBbLt
 28qMpgDev/4gmNyMz54zhKD+Ijs=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> Hi Michael,

Hi Arsen,

> So I did.  With the diff below, I ran into an issue: the error emitted
> in it is caught.

Could you pls just print a backtrace when epa-fle-handler isn't found?
Something like

--8<---------------cut here---------------start------------->8---
(message "%s" (with-output-to-string (backtrace)))
--8<---------------cut here---------------end--------------->8---

This would give us a backtrace to analyze.

> I believe that the check utilized below is correct for the
> check-and-error solution.
>
> diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el
> index 0f51755a250..4da15a65259 100644
> --- a/lisp/auth-source-pass.el
> +++ b/lisp/auth-source-pass.el
> @@ -195,10 +195,13 @@ auth-source-pass--get-attr
>  (defun auth-source-pass--read-entry (entry)
>    "Return a string with the file content of ENTRY."
>    (with-temp-buffer
> -    (insert-file-contents (expand-file-name
> -                           (format "%s.gpg" entry)
> -                           auth-source-pass-filename))
> -    (buffer-substring-no-properties (point-min) (point-max))))
> +    (let ((fname (format "%s.gpg" entry)))
> +      (if (not (find-file-name-handler fname 'insert-file-contents))
> +          (error "auth-source-pass requires a handler for .gpg files"))
> +      (insert-file-contents (expand-file-name
> +                             fname
> +                             auth-source-pass-filename))
> +      (buffer-substring-no-properties (point-min) (point-max)))))
>
>  (defun auth-source-pass-parse-entry (entry)
>    "Return an alist of the data associated with ENTRY.

Nope. find-file-name-handler shows the next file name handler to be
applied. It could be epa-file-handler, but if it is removed from
file-name-handler-alist, another file name handler could be returned,
like tramp-file-name-handler. So if you want to use
find-file-name-handler, you must check something like

--8<---------------cut here---------------start------------->8---
(eq (find-file-name-handler fname 'insert-file-contents) 'epa-file-handler)
--8<---------------cut here---------------end--------------->8---

> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 29 Dec 2023 08:38:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 29 03:38:02 2023
Received: from localhost ([127.0.0.1]:40738 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rJ8NV-0004TU-Vq
	for submit <at> debbugs.gnu.org; Fri, 29 Dec 2023 03:38:02 -0500
Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:39420)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rJ8NT-0004Su-9s
 for 67937 <at> debbugs.gnu.org; Fri, 29 Dec 2023 03:38:00 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4T1dzz59SGz9sbF;
 Fri, 29 Dec 2023 09:37:51 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703839071;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=wEwHGBsHsOF5mR3s637XgwVdx8f741HwVvkr9x6Xpi4=;
 b=JYs1zt45DYLxZKcT7QK46AUx6zPDyEjkfDZkxSLNKjuzPVuV5fER8HatJ8nplodhxmfAyK
 OWFEvmgxh285GozJiVfKTYAoQlv2pOPRT3LF/NxhHxrQg+cUpwBhsBL7bKixxuJvm4RKfu
 +FOsbMlfe0z9ILBp774t+xuiPys0JUWC3tASaPno/z+6wW8JCcf3JycvgeUS1SX1mOW3cA
 a4xth79PgMbYZPjRizUT2caGNsT/5APookrtASka2maZXR+o1gbS2fzarXOZJ3Y9q+HRIU
 c7xcwq1f80woLvWEZKOeYz8VNc9ywGBu/FKHVtkiU/sgbKerCi3oRhVoiJ3s+w==
References: <8734vwq06i.fsf@HIDDEN> <87sf3vlqj1.fsf@HIDDEN>
 <871qbf4ocp.fsf@HIDDEN> <871qbflg53.fsf@HIDDEN>
 <87h6kbxgzl.fsf@HIDDEN> <87jzp6is0s.fsf@HIDDEN>
 <87ttoas466.fsf@HIDDEN> <878r5mm3el.fsf@HIDDEN>
 <875y0qrmhj.fsf@HIDDEN> <871qbdmagw.fsf@HIDDEN>
 <87bkahlzzp.fsf@HIDDEN> <868r5lszxm.fsf@HIDDEN>
 <87plywlus1.fsf@HIDDEN> <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
 <86h6k77qco.fsf@HIDDEN> <87v88nk5md.fsf@HIDDEN>
 <86y1dj4l71.fsf@HIDDEN> <87le9jjyu6.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Fri, 29 Dec 2023 09:27:59 +0100
In-reply-to: <87le9jjyu6.fsf@HIDDEN>
Message-ID: <8734vlflpf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
>> Hi Michael,
>
>>> No, auth-source-pass should not enable it on its own I believe. It
>>> should fire an error, which hopefully produces a backtrace. This
>>> backtrace would help us to understand, what's up.
>>
>> I doubt that it would produce a useful backtrace, because I doubt a
>> well-behaved let-binding is causing an error (as I said, when I notice
>> this bug, epa-file stops working everywhere, even long after a potential
>> let-binding would've been unbound, implying that it gets unset via some
>> other means).
>
> But we shall try it.

So I did.  With the diff below, I ran into an issue: the error emitted
in it is caught.

I believe that the check utilized below is correct for the
check-and-error solution.

=2D-8<---------------cut here---------------start------------->8---
diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el
index 0f51755a250..4da15a65259 100644
=2D-- a/lisp/auth-source-pass.el
+++ b/lisp/auth-source-pass.el
@@ -195,10 +195,13 @@ auth-source-pass--get-attr
 (defun auth-source-pass--read-entry (entry)
   "Return a string with the file content of ENTRY."
   (with-temp-buffer
=2D    (insert-file-contents (expand-file-name
=2D                           (format "%s.gpg" entry)
=2D                           auth-source-pass-filename))
=2D    (buffer-substring-no-properties (point-min) (point-max))))
+    (let ((fname (format "%s.gpg" entry)))
+      (if (not (find-file-name-handler fname 'insert-file-contents))
+          (error "auth-source-pass requires a handler for .gpg files"))
+      (insert-file-contents (expand-file-name
+                             fname
+                             auth-source-pass-filename))
+      (buffer-substring-no-properties (point-min) (point-max)))))

 (defun auth-source-pass-parse-entry (entry)
   "Return an alist of the data associated with ENTRY.
=2D-8<---------------cut here---------------end--------------->8---

>> Nonetheless, it is worth a shot.  I will inject a check into my
>> currently running Emacs and see what happens.
>>
>> I think erroring is an acceptable solution, though (but I do not think
>> the same of returning nil).
>
> Would be OK for me. Please add a hint to the error, that the user shall
> contact the Emacs department about. In case your patch arrives the reposi=
tory.
>
>> I'm also not sure how complex the heuristic for emitting this error
>> would be.  (memq epa-file-handler file-name-handler-alist) is not
>> adequate as non-EPA handlers for PGP files could be active and/or
>> preferred.
>
> Well, it could be a starter. As you said, you have observed
> file-name-handler-alist being nil, so this test would be good enough for =
now.
>
> We have also (find-file-name-handler FILENAME 'insert-file-contents)
> But the interpretation of the result is a little bit more tricky.
>
>> I'm willing to implement a solution if you know a better heuristic.
>
> Let's start with what we have. Thanks!
>
>> Thanks, have a lovely day.
>>
>> Arsen Arsenovi=C4=87
>
> Best regards, Michael.


=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZY6FXBAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTlq0A/Ag22ZInzWKs/vxWDTkIUZZzekCKqH0niFH7
lCrnw1euAP9aZj+XRc3NAUGLIT6Gsjn5aN9iubScMT14axMOmH3eBw==
=xwjr
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 17:27:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 12:27:24 2023
Received: from localhost ([127.0.0.1]:53477 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHSG4-0007cc-Iq
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 12:27:24 -0500
Received: from mout.gmx.net ([212.227.15.15]:58297)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHSFz-0007cM-UK
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 12:27:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703438818; x=1704043618; i=michael.albinus@HIDDEN;
 bh=rqMgkv81ySkdTnWEeXF1DVn+9oNKvQVJF5di92pVQAk=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=JhlAhQLC52UXR2cY3Sql1b61V0pz6kJHevFewYCfNO4AxzeSjq2WVejRP8Gb52VE
 KoltA5oK5K3jwomC/7vKutLryej8x1TnhqlSswxBr5qsLttvvXGbpbgSJB2z1Ij8o
 brc2XGkRut2XIfu63g2a4hi6prC+E3KWFJNzQdv2+yZQhvOS04/SQQ28OzW9bWK61
 +CxtVYzb+STqht8xxiWYHtkiuqblfpDcpZWWHAxwh58IbrHO9PzHxMA4plHqjeG2y
 ExocRiVJsRqbGK6U68by7db4ENBB59caIucxMSrefo9uteg0z0zveFYxp6JL+Cx4q
 lIZogF0TcWh5aGoBJg==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvbFs-1r1a1k2gLO-00scPg; Sun, 24
 Dec 2023 18:26:58 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <86y1dj4l71.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sun, 24 Dec 2023 17:11:47 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
 <86h6k77qco.fsf@HIDDEN> <87v88nk5md.fsf@HIDDEN>
 <86y1dj4l71.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 18:26:57 +0100
Message-ID: <87le9jjyu6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:WRkUDDYF0KSkUaK1XOWliL3gLU6CXyBglrj44kiMX0lwzOXiaXJ
 Ig5wrRM1wB+J59r9dFWrnXypqnNfLnublyppjwhSyyHNWSBNy//pMbO7j4pkEzO+pS9u7JP
 f5DcNXl3nkwkp52nJEP6Aw+r86LInCM9h9nUlhk4Vj+H/ZB7A6FadvdsLXRARR2hlqCHnkE
 286uZzfCKf3TVz2Mkc7nA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:LwMprIttbDk=;gGeQLzQD2gLHEog0RADUNWugXeX
 8GLNf6nLfNCB6+EDUdNrY3QZ+f2UcTTNrSgexw+flNjhzscH+ZVT74aikaSrQD2LGeGcrH5Ah
 uvih+koSCbM6ymxxd0416KsjXhA84n0c4XMuCFo8ELgwT4vC/hj7Lm5VIr4+1KxHLgabcjs8Y
 nCZXnl0sJZw5aSvZgR4qx2gMajDMZz7n2qK+x469JVv5XaokRgvunVLXOmrC77h50SIDwXQzp
 8HPFkUUJfd6H+e1N2F8JdIZsN0U0RKN9+JPW7mT9v2XE2DHNkcw+aUAu+YESOwvtdVXRuXqN0
 9+HsjXv8a+rBCdQKgvfAFuwT4pysaXG8RRGtULpVE7bQFfRmqFzJuvr7xPK/HRGZY2FYjreMb
 cJpIpsQZz5itckcJRS0anUxfyAQdM+epSVJCw5mVAUCL0sP1ujOLlWg5m8hOBC8xrsBC4zrBi
 MyeHxRQZB7YmCzpJbamcnQuWaZmZINm+28xzNMkvADem/hOzPPlBhgtN8m1pYkwezjaltE5pr
 0nLgBiE9Jpvy+2PvWsiFtxIJWS08xyCR/9SR+E3V2ZpO+rRQBb4QqgGXD5RPs00TG4B7P0SgY
 k1JfFapv0OCqqmNQ8XQJ1tJSZnRPyveurs6itoAoST4wgAzOjtw+8HLQGpIwdYCCOSzAi/Rwn
 A2TXRKuzrSYXk91JePRU1TtLD1BqpKlpd6T5/QIp2Asg+zmLw/cqCRlv4z8weE0thPBFtRGZe
 y041q+ITUSL6j0U2fl2QGxiq0rEVkz13Dh9v/Vnx+KmN/WP7VtGS3OYS5fQ43g7BEOd0SZkTK
 83EnThyPwa9qYL1+xIafKgKeM1z/Yd1qgEgLVgMub4lGDDDZQysof4ZKUx+XXIfiPffSGZGxx
 9I7qJCRWUdIGt5P9fgciq4KOWxZC+6A+kEkH+/3tLR9CqOZFcPNu0McS6QmAvCz9WjeNmE+iG
 MQkxUiX5Yz86v1Jf/5rLZ3YnfEQ=
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, >> No, auth-source-pass
    should not enable it on its own I believe. It >> should fire an error, which
    hopefully produces a backtrace. This >> backtrace would help us to understand,
    what's up. > > I dou [...] 
 
 Content analysis details:   (2.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.15 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.15.15 listed in wl.mailspike.net]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, >> No, auth-source-pass
    should not enable it on its own I believe. It >> should fire an error, which
    hopefully produces a backtrace. This >> backtrace would help us to understand,
    what's up. > > I dou [...] 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.15.15 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.15 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> Hi Michael,

>> No, auth-source-pass should not enable it on its own I believe. It
>> should fire an error, which hopefully produces a backtrace. This
>> backtrace would help us to understand, what's up.
>
> I doubt that it would produce a useful backtrace, because I doubt a
> well-behaved let-binding is causing an error (as I said, when I notice
> this bug, epa-file stops working everywhere, even long after a potential
> let-binding would've been unbound, implying that it gets unset via some
> other means).

But we shall try it.

> Nonetheless, it is worth a shot.  I will inject a check into my
> currently running Emacs and see what happens.
>
> I think erroring is an acceptable solution, though (but I do not think
> the same of returning nil).

Would be OK for me. Please add a hint to the error, that the user shall
contact the Emacs department about. In case your patch arrives the reposito=
ry.

> I'm also not sure how complex the heuristic for emitting this error
> would be.  (memq epa-file-handler file-name-handler-alist) is not
> adequate as non-EPA handlers for PGP files could be active and/or
> preferred.

Well, it could be a starter. As you said, you have observed
file-name-handler-alist being nil, so this test would be good enough for no=
w.

We have also (find-file-name-handler FILENAME 'insert-file-contents)
But the interpretation of the result is a little bit more tricky.

> I'm willing to implement a solution if you know a better heuristic.

Let's start with what we have. Thanks!

> Thanks, have a lovely day.
>
> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 16:32:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 11:32:07 2023
Received: from localhost ([127.0.0.1]:53391 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHROZ-0006lm-6q
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 11:32:07 -0500
Received: from mout-p-101.mailbox.org ([80.241.56.151]:38214)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHROW-0006lA-42
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 11:32:06 -0500
Received: from smtp202.mailbox.org (smtp202.mailbox.org
 [IPv6:2001:67c:2050:b231:465::202])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4SymlB4tDZz9sq5;
 Sun, 24 Dec 2023 17:31:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703435510;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=5SvL3SS9XQ4mPXo0qnfcI4X4JyrwgSSspCpD7u2AWfk=;
 b=YUJW/aM0bBeBvwCZBCWiNRIdhvougyDRDijthveB3Sx0n9HH2/vxbXvm3wDEpGJJfVsux4
 yiR4fmopcNuzfIQHqjHhdqEsBOaKCobjcJaUYFbDKllAXqD4Dujt5TYG9EpHlvfo39IyxQ
 tHMAMfOd9bUUEmhFe5fJqtMmsVcBBQ3Yj9W74in9Dwrml8hVv6NP+u501TGOX1+f7tWGE1
 Ziy0m1Tek1JIwAOe3ZlYM+Kpb2rOHFmEnBOQDRDK8lbnjivCdSigHcgNJW90dJ03/7KZ3s
 eiJqiYw81jhHktOzbMTloW4xv6xVtEeOp3sOPC8GQHKEYigyi714OMC/VSNt8g==
References: <8734vwq06i.fsf@HIDDEN> <87msu4myau.fsf@HIDDEN>
 <83y1dnga7u.fsf@HIDDEN> <87sf3vlqj1.fsf@HIDDEN>
 <871qbf4ocp.fsf@HIDDEN> <871qbflg53.fsf@HIDDEN>
 <87h6kbxgzl.fsf@HIDDEN> <87jzp6is0s.fsf@HIDDEN>
 <87ttoas466.fsf@HIDDEN> <878r5mm3el.fsf@HIDDEN>
 <875y0qrmhj.fsf@HIDDEN> <871qbdmagw.fsf@HIDDEN>
 <87bkahlzzp.fsf@HIDDEN> <868r5lszxm.fsf@HIDDEN>
 <87plywlus1.fsf@HIDDEN> <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <871qbblsie.fsf@HIDDEN>
 <861qbb7q3r.fsf@HIDDEN> <87r0jbk5hc.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 17:31:08 +0100
In-reply-to: <87r0jbk5hc.fsf@HIDDEN>
Message-ID: <86le9j4l57.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4SymlB4tDZz9sq5
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

>> This is effectively equivalent to being reset to nil for library
>> functions such as auth-source-search (which calls
>> auth-source-pass--read-entry eventually), as this is global state that
>> applies for called functions, no matter how deep down the call stack.
>
> Sure, the effect is the same. I just wanted to underline, that setting
> file-name-handler-alist to nil by means of setq or alike would be
> vandalism :-)

Ah, yes, then we agree :-)

>> Arsen Arsenovi=C4=87
>
> Best regards, Michael.

Have a lovely day :-)
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYhc9F8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosST1R4A/ixjntt7nBl3JY7gaY3gk4ne0rWqyV+STlBQ
CMe5NmhZAQD0ya9U48IEN+/fx70/ys86N93YMq+DX8K54NS4PDDeAQ==
=2k2j
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 16:31:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 11:31:12 2023
Received: from localhost ([127.0.0.1]:53387 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHRNc-0006U0-GX
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 11:31:12 -0500
Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:45620)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHRNW-0006AM-1j
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 11:31:06 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Symjz62hSz9sX2;
 Sun, 24 Dec 2023 17:30:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703435447;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=f9gK9ZGp1G4j6pgI6inulvVbB2XvsOeZPD9WL5TpkhM=;
 b=1+LbsDXjn2PPaMCzvEfIDB/VgbzYOEO9mG6w+8PbW2dWCFgyMv2NqjZs4sqmz4OtXMtYPc
 M2MBKVbrtT3LME1wOQrKdlYblUq3HhgrRUBMjij6Ik9pZIyRyZZB1SGr/YQ9qShbfwfiGh
 85bGqevuCIU1ubV/WBcYi4OwXmWLzi4zf5f+C++id1KhgAKjDRYMC0sDJvon1ctxsJnPct
 KhXNdd6PVDImwAq+XN9tYMTXeJ9kGwszV/GCKslupps31WcnSJihCs9xAe+WsQ5dEQPDE9
 nvt1MscfZ7oxmlwyl0vFWLIVuoVOQwMMS9WUOgpjZlZngb2RyACrHepDXlPvgg==
References: <8734vwq06i.fsf@HIDDEN> <87msu4myau.fsf@HIDDEN>
 <83y1dnga7u.fsf@HIDDEN> <87sf3vlqj1.fsf@HIDDEN>
 <871qbf4ocp.fsf@HIDDEN> <871qbflg53.fsf@HIDDEN>
 <87h6kbxgzl.fsf@HIDDEN> <87jzp6is0s.fsf@HIDDEN>
 <87ttoas466.fsf@HIDDEN> <878r5mm3el.fsf@HIDDEN>
 <875y0qrmhj.fsf@HIDDEN> <871qbdmagw.fsf@HIDDEN>
 <87bkahlzzp.fsf@HIDDEN> <868r5lszxm.fsf@HIDDEN>
 <87plywlus1.fsf@HIDDEN> <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
 <86h6k77qco.fsf@HIDDEN> <87v88nk5md.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 17:11:47 +0100
In-reply-to: <87v88nk5md.fsf@HIDDEN>
Message-ID: <86y1dj4l71.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
> Hi Arsen,
>
>>>> I disagree.  I think that involving the f-n-h-a mechanism for handling
>>>> PGP files ultimately introduces implicitly far more complexity, even if
>>>> the code is slightly briefer, precisely because of this dependency.
>>>
>>> I disagree with your disagreement, and agree with Michael here.  I see
>>> no maintainer's complexity in using file-name handlers that could be
>>> avoided by not using them: file-name handlers are, and will always be,
>>> an integral part of Emacs internals, so thinking about them as
>>> "complexity" makes no more sense than, say, thinking about GC as
>>> complexity.
>>
>> In that case, auth-source-pass should ensure it's there.  This is where
>> the complexity I refer to creeps in.  Now auth-source-pass needs to
>> alter and restore file-name-handler-alist as appropriate.  This means
>> that it has to get involved with global state, potentially impacting
>> other functions it calls.
>
> No, auth-source-pass should not enable it on its own I believe. It
> should fire an error, which hopefully produces a backtrace. This
> backtrace would help us to understand, what's up.

I doubt that it would produce a useful backtrace, because I doubt a
well-behaved let-binding is causing an error (as I said, when I notice
this bug, epa-file stops working everywhere, even long after a potential
let-binding would've been unbound, implying that it gets unset via some
other means).

Nonetheless, it is worth a shot.  I will inject a check into my
currently running Emacs and see what happens.

I think erroring is an acceptable solution, though (but I do not think
the same of returning nil).

>> It seems to me more reliable to alter EPA to provide an
>> insert-file-contents functions for direct use.  This is less composable
>> and elegant than file-name handlers, naturally, but it is also exactly
>> what a password-store read requires.
>
> No. There is no reason to implement this.

It would prevent a potential error (the one suggested above) when it is
clear how a file must be read (which is always, as password-store
entries are always exactly PGP-encrypted files).

I'm also not sure how complex the heuristic for emitting this error
would be.  (memq epa-file-handler file-name-handler-alist) is not
adequate as non-EPA handlers for PGP files could be active and/or
preferred.  (assoc (car epa-file-handler) file-name-handler-alist) is
also not quite correct as regexes not exactly equal to (car
epa-file-handler) could still match PGP files.

I'm willing to implement a solution if you know a better heuristic.

Thanks, have a lovely day.
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYhcsl8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTuJsA/jSaqHcmP+km+BRD1bWGLRmWmSoy2pdkPIz1
cZMs0RgYAP4h2sFkHZ8nLrCo1g5Ynj/kCBCQxLntSHP5hCwythLiCA==
=Q0IK
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 15:03:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 10:03:56 2023
Received: from localhost ([127.0.0.1]:53348 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHQ1E-0005Xf-6w
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 10:03:56 -0500
Received: from mout.gmx.net ([212.227.15.19]:47853)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHQ18-0005XN-S2
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 10:03:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703430208; x=1704035008; i=michael.albinus@HIDDEN;
 bh=to216vtZMqHOUngwrIGgRwNTyaYot/QWE2hGRwC2iy8=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=A1XsBw7yShvEyNQqySyb8hYKaEZMkE2Q7k4TrxQtCbq2qmPGECFgq0en1WUl8P3L
 iZv4wCZ2Mu2EYNSZZARfUKOLarbB9N26HxdvOfvr50MEvRC7UOq5iCEZO8I894f6g
 7SIlE2KvYjamfBpmks+FPOpqaqdLljwOdP3BPjQsbi7MJ00rarwtijr+WSpwn3GVl
 PK/TsRSpeBuhX43mNE2AMMpSskBTKrvM/OlU0Jk00GhN3vbVky5lZDY5K2/DjbSml
 UXnrsIrFxiV4DVhihqDi70mtkEKQHm8RguAL8lQAJEmVYi4YxzvxaSF/N9/RDaYXA
 nz+qTuJqc/QuIjs1QA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MbzyP-1qi5CJ1sBL-00dXAr; Sun, 24
 Dec 2023 16:03:28 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <861qbb7q3r.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sun, 24 Dec 2023 13:14:44 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <871qbblsie.fsf@HIDDEN>
 <861qbb7q3r.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 16:03:27 +0100
Message-ID: <87r0jbk5hc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:UutIfrW9dlNVvqrnPwK1W+Hn2ajaLHzqznbsWr9e02ltBaEZIoi
 tsNt15I+V02We8Rk8C1xF/WpHIH1iW4Y76+K6Tbb+6jGEASb3fsIF3DwdkeeNfAIeJRRN3w
 mCiVHAwn7eVj3suG/BFqVJrPwYnp/yVHc3FbjLM6XNIdH/6lBgjtm9niKT5+SyJbaWsLHVh
 4SODOlboaX3w9+Mx4/3gw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:TTF1uFem/Rg=;YE59LgPAzAoTyRM0IfG8BgDAhLZ
 ITcqd7q/A9kpH6YXcFb5Hz25HNOGZMsL8E824R7VK4BgtVFxTJfHbAL5W48yP0XhjjH8Mh0Ps
 BRyFRFU6mUum+AbmLr01wsVxLkvV305ferQjvhCwTeMuNGk6Ij4TwHLkX2P9S0E22rR1EaPas
 R7/nzTIRe6QVVI9gkEtv2fzup+762OzW+TDOFffin0LAfNYS0P7ZJF91KeLdRXVuG63ug+klb
 0s2Zm7hygbI1QFclvngkpWpW6N48EOVNAr4dhbGjbMGVqUO525g/PiwsFpf+etjAzhF28tkdq
 vdufOU93OMJxbctgpJBF/zRjGRPL/iCmEFdawHaALqUuisC2GpkbihJsTn0KZnzTT3nEEosMJ
 WTOWY/uI6F/115Ka65pnaPPXMO92GAgGHX7Crk0LDKesbPrOv1F/l4lpc+sYBYXZDNREmV+K6
 Fw8eI5v3drh6OlKIxGzQk9Ih38JbW85jcdr/cJeO5d+F/2WEgni+s2Q4RrVDV9sfwe5m8+rJb
 DAjItD+JMuiIuNJ+UAqW+C3bnm9Frq0Ar5RXWM0QWiYUa8nM/tC9wULxvg6jT1myox6Kvy5H/
 mw2268eB+aYWa1A495crHRYDL6MGkdRDlprd698/eEGocL2iMEHI7gpitqKsFSjM4uK4n6Toe
 CWfqqIAwAQ9o33Ud7RuwkOasAke+gnL9N0b0O2TYv3opLLIpdzNpEhFaeh6oZpBqQmlS6fyPC
 MEwC32Kw0OeVS224iF20b+oYQoNPxkHJ8b3+nF7x+s/5PX6nrJvLe1OXgECAq9ABI6xI+wBkD
 8kQDlJoOI8un4bAK4La/j0qZvRMUOlFAa0O0Qrn45L+sQSjV0pu2vziKdyS+NRdzgXj2gJnbh
 mDc5WF5JukJB0iCJySRwpyl0VrqY5sxU7a2keXEFBFY+2Nq8KZ1SSWcX9AfZN2UtdKD5GmVIP
 Btj1h5+b/lWzLxLiM2uYAtLwcVU=
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: Hi Arsen, >>> Based on observations
    during the last 24h I've noticed that many Emacs >>> functions do, in fact,
    reset f-n-h-a to nil. I'm yet to spot the >>> combination of calls that leaves
    epa-file not added [...] 
 
 Content analysis details:   (2.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
                             [212.227.15.19 listed in wl.mailspike.net]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.19 listed in list.dnswl.org]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: Hi Arsen, >>> Based on observations
    during the last 24h I've noticed that many Emacs >>> functions do, in fact,
    reset f-n-h-a to nil. I'm yet to spot the >>> combination of calls that leaves
    epa-file not added [...] 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
                             [212.227.15.19 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.19 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

Hi Arsen,

>>> Based on observations during the last 24h I've noticed that many Emacs
>>> functions do, in fact, reset f-n-h-a to nil.  I'm yet to spot the
>>> combination of calls that leaves epa-file not added back in.
>>
>> No package in Emacs should reset file-name-handler-alist to nil. If you
>> find such code anywhere, please report an error.
>>
>> What is possible is to let-bind file-name-handler-alist to nil.
>
> This is effectively equivalent to being reset to nil for library
> functions such as auth-source-search (which calls
> auth-source-pass--read-entry eventually), as this is global state that
> applies for called functions, no matter how deep down the call stack.

Sure, the effect is the same. I just wanted to underline, that setting
file-name-handler-alist to nil by means of setq or alike would be
vandalism :-)

> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 15:00:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 10:00:53 2023
Received: from localhost ([127.0.0.1]:53344 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHPyH-0004pT-Jp
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 10:00:53 -0500
Received: from mout.gmx.net ([212.227.17.20]:35613)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHPyB-0004VR-Ug
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 10:00:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703430026; x=1704034826; i=michael.albinus@HIDDEN;
 bh=LgmefErCprVrN+cTxdbAAukEvOCJ7MZzL5dD/547gUk=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=D1wFRzB7A7RFC5v0gWMVy/mbhPr3r8l3I+/y1U7ljNjfK8y+GeVZ++YX6G70aTd1
 8xQTVs7SU9EEHKPHKXBngE+Z8urinh1e1zV2NGkn+WdQv9ljYjTBvsUCRUQWGNyqb
 G90TPM1yBvi/G3nesXvStk2qZkx0mXOoT6862pPwe7hvwKDTL7tQRLzyGm1gYimU5
 TLUGuJufVp9UOdzYyw+F5bglohLr7vt9heW5SMFQtG/m7e3WHCQaEA4fCoeZJ7rRu
 Iyn0Y9SbOY8sqGaxQo4qcyD2LpBjBjTQJcq22SJ5TcNDEOFjceKV1mdwnx0e5p52N
 jl4orZAG8o6vXY1SFQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5wPb-1rKSu135TP-007SNI; Sun, 24
 Dec 2023 16:00:26 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <86h6k77qco.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sun, 24 Dec 2023 13:00:44 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
 <86h6k77qco.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 16:00:26 +0100
Message-ID: <87v88nk5md.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:VJXOWndkSUZCPp+jWb92nPAGx9nWmnwybNBwerPmJPrZH/1O1WN
 0eMqoUdAcOPDSotlmxo8+99dK0ooJCL4CBmVD1U9kkKl2M9dQpIF2Crcn82VYBWg4MYS3oi
 D4uCQAkcpWkMSNxGFeLTZSJHTkRCgK75ReuU5GlJhCTrOvhjuyfMeKe6O8cqKoKOK8/TFTZ
 u7OrtHxAlh8BaEhe8zafw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:laC0jKnZxcY=;IsTuRF4IXYfXizcR615i95MprZ0
 aufSsxnKo341FUeLT9dQV7AeTX7z3ksQw0x8m2/sCZeF8s3fIkgZ3aK+7TsxyMcjrkSW3OV05
 zLlIiq2c8C3VGsF1opN92NXEelu216rPdoSR7DPTccoKym8v//F4pKqeWMDji29iqG7zaNwcp
 6gsCHw79EgIbMfYr/grpVDHPx/LJx0LjYeG7NOjYepcN6TLe5j8GWx1TJRpnhvjEzkqqp6qRO
 paxuQ7rGmWuQONY/ncpn+/+qaV+8eUAYVRc2rcsLFa6YeIs5tnDfp88V8OfU6cPT0iOgn/sCL
 LfKIwl9RjuCmhA8VIZ25TOBKG7RXxbaD2Tgk0a30vNAo6X5ZcQKZzpbbylIOtvuDtgDwNS12U
 9/tBV8/9s5cot3gFMiJ/GwKAsxarRxEnfz+/lzZk7CoM+TqUleWtf1H1KP1ANQX3dYSAVZb7m
 /G+8N21Qft5D7/tNZOcQwQ2R0uyc9GTleH2rih6F7jmWu1vVwtkmWlS2MgVeiUNUNHsDnZ9ik
 LmKX0Y4KR/wgs4UcQtJPvrsX906daFuY35XSQA32bR5IYJr7eoB7daWlRYPbhALPgfCJTSPdG
 IjpWgNTHppv3dQBgm7ja11dW2NhvqXO29pmhIc92mMSpVqeFJTiJNuUx5cBWDup0RUHW72lwA
 Hi0OxKlVwe49rg7Ou9oKW6SJWdQjOt8sHtQ7Y6+wNf4DMW9TSbtMfiD2AbkQjdepTv7i7dV23
 yh563FtPDk4a/K0ct0jCo9b+Uqk4o8Ydv8okiW86ap22KttYndKWi9pkQSOirdyo/VSNaCx10
 roRARP1i3JwVwWtmDE2f1r9sbQUeMUYmahroeAXc+5Hxx04lPc/WWfNeJLNeWMrROPidF6L0m
 m+xxN386k/qjmZvCnGVooosyaapB+5o/nVDBNsKUXP+/QEXWZR1HE+Uk1WmvnPEW/9oVktoFu
 xXwxAYAm3uhUgaX8CL12SLCkPA0=
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: Hi Arsen, >>> I disagree. I think
    that involving the f-n-h-a mechanism for handling >>> PGP files ultimately
    introduces implicitly far more complexity, even if >>> the code is slightly
    briefer, precisely becaus [...] 
 
 Content analysis details:   (2.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.20 listed in wl.mailspike.net]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.20 listed in list.dnswl.org]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: Hi Arsen, >>> I disagree. I think
    that involving the f-n-h-a mechanism for handling >>> PGP files ultimately
    introduces implicitly far more complexity, even if >>> the code is slightly
    briefer, precisely becaus [...] 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.20 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.20 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

Hi Arsen,

>>> I disagree.  I think that involving the f-n-h-a mechanism for handling
>>> PGP files ultimately introduces implicitly far more complexity, even if
>>> the code is slightly briefer, precisely because of this dependency.
>>
>> I disagree with your disagreement, and agree with Michael here.  I see
>> no maintainer's complexity in using file-name handlers that could be
>> avoided by not using them: file-name handlers are, and will always be,
>> an integral part of Emacs internals, so thinking about them as
>> "complexity" makes no more sense than, say, thinking about GC as
>> complexity.
>
> In that case, auth-source-pass should ensure it's there.  This is where
> the complexity I refer to creeps in.  Now auth-source-pass needs to
> alter and restore file-name-handler-alist as appropriate.  This means
> that it has to get involved with global state, potentially impacting
> other functions it calls.

No, auth-source-pass should not enable it on its own I believe. It
should fire an error, which hopefully produces a backtrace. This
backtrace would help us to understand, what's up.

> It seems to me more reliable to alter EPA to provide an
> insert-file-contents functions for direct use.  This is less composable
> and elegant than file-name handlers, naturally, but it is also exactly
> what a password-store read requires.

No. There is no reason to implement this.

> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 12:16:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 07:16:50 2023
Received: from localhost ([127.0.0.1]:51766 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHNPW-0005ud-EV
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:16:50 -0500
Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:59314)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHNPT-0005uM-Cu
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:16:48 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Syg4d2rRPz9sk8;
 Sun, 24 Dec 2023 13:16:33 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703420193;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=3eafdGg1M2PIEq+CM0pzoaa26KUTV4CoUweA9r66FnY=;
 b=KtpHAuF9DVfL412MlF/KPN90D8Czq+XQe2ilq+IBCjJRJTuoJNUtSZUBvXl6vT9gxkbZPC
 R5Y5xq843e+RfPB4JVAlJNTWgdM5I39n07RwjnVl3BFWeAdR+pw/RPmV+Xc+HFhRJR+YLu
 ZuKkGcR7Q2lGSEJ0kUb031fIILiLgM9f04R/XmVTN9yhSUcn+cMTBxhnl76GWhvz0tbgi6
 LqsRjLPrhldim1JkRjLaauTcytA/ZwjsOToE/jQZl2Si9cc8Qq+xojtd+Yaqdnq3C/2652
 BYUGKn7SqG81jGgm4HQDFdgPynXZL+wQCNQ5MnuDC+NqmfgYpFndxACcB7NbMQ==
References: <8734vwq06i.fsf@HIDDEN> <87jzp8of97.fsf@HIDDEN>
 <83bkakhe8s.fsf@HIDDEN> <87msu4myau.fsf@HIDDEN>
 <83y1dnga7u.fsf@HIDDEN> <87sf3vlqj1.fsf@HIDDEN>
 <871qbf4ocp.fsf@HIDDEN> <871qbflg53.fsf@HIDDEN>
 <87h6kbxgzl.fsf@HIDDEN> <87jzp6is0s.fsf@HIDDEN>
 <87ttoas466.fsf@HIDDEN> <878r5mm3el.fsf@HIDDEN>
 <875y0qrmhj.fsf@HIDDEN> <871qbdmagw.fsf@HIDDEN>
 <87bkahlzzp.fsf@HIDDEN> <868r5lszxm.fsf@HIDDEN>
 <87plywlus1.fsf@HIDDEN> <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <871qbblsie.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 13:14:44 +0100
In-reply-to: <871qbblsie.fsf@HIDDEN>
Message-ID: <861qbb7q3r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Michael Albinus <michael.albinus@HIDDEN> writes:

> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
>> Hi Michael,
>
> Hi Arsen,
>
>> Based on observations during the last 24h I've noticed that many Emacs
>> functions do, in fact, reset f-n-h-a to nil.  I'm yet to spot the
>> combination of calls that leaves epa-file not added back in.
>
> No package in Emacs should reset file-name-handler-alist to nil. If you
> find such code anywhere, please report an error.
>
> What is possible is to let-bind file-name-handler-alist to nil.

This is effectively equivalent to being reset to nil for library
functions such as auth-source-search (which calls
auth-source-pass--read-entry eventually), as this is global state that
applies for called functions, no matter how deep down the call stack.

>> Thanks, have a lovely day!
>>
>> Arsen Arsenovi=C4=87
>
> Best regards, Michael.


=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYghGF8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTqmoA+gJr/ae3rOAabDLAUMEYn0+lVFvi+nTkuw6b
F/BQA/zwAP98g2wj/NOLnrjBdY4XU+LYai53N0UpSkSoNhPL1oCRBg==
=4JsU
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 12:11:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 07:11:25 2023
Received: from localhost ([127.0.0.1]:51762 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHNKG-0003AX-7W
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:11:24 -0500
Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:35258)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHNKD-0003AE-T8
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:11:23 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SyfyL6Bpqz9sfB;
 Sun, 24 Dec 2023 13:11:06 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703419866;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=WOQyQyF3h6TcMONejLTvskVX9nlkJbBabcTnpwsICwY=;
 b=XuySoNenZxI/j51LbbXpBSScTFX2PfrOhgLRN+6ePutsrjTlVNzFYIy3fJsK2ggL3nVRNK
 vTrsV1qllz1RHmRfULnxvSfYe5nqgcXK9funZ0V7WNXsYnPRrykvvzFeaGewb4ALAYCXDp
 PbF6a4daSGgXnavErg0uN2PrPY9AeAYXZt/imHbHgXmFlMC9svd7cLfQnvpJZJUOK0xT8k
 y8B0WXK/2QgYr7pbasEnsmFzo3nqj3Vqr4H8H6zpEqTGRwxESkcTp211kzGdQ2LXmmiMDX
 0PWmN1WzGPPi63sRyar156IfvTAIpOVA8uYDPewUFzEVCSFJ8IWbwiMoHAhtCg==
References: <8734vwq06i.fsf@HIDDEN> <87jzp8of97.fsf@HIDDEN>
 <83bkakhe8s.fsf@HIDDEN> <87msu4myau.fsf@HIDDEN>
 <83y1dnga7u.fsf@HIDDEN> <87sf3vlqj1.fsf@HIDDEN>
 <871qbf4ocp.fsf@HIDDEN> <871qbflg53.fsf@HIDDEN>
 <87h6kbxgzl.fsf@HIDDEN> <87jzp6is0s.fsf@HIDDEN>
 <87ttoas466.fsf@HIDDEN> <878r5mm3el.fsf@HIDDEN>
 <875y0qrmhj.fsf@HIDDEN> <871qbdmagw.fsf@HIDDEN>
 <87bkahlzzp.fsf@HIDDEN> <868r5lszxm.fsf@HIDDEN>
 <87plywlus1.fsf@HIDDEN> <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN> <83a5pzde0a.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 13:00:44 +0100
In-reply-to: <83a5pzde0a.fsf@HIDDEN>
Message-ID: <86h6k77qco.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4SyfyL6Bpqz9sfB
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, 67937 <at> debbugs.gnu.org, michael.albinus@HIDDEN,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Arsen Arsenovi=C4=87 <arsen@HIDDEN>
>> Cc: "J.P." <jp@HIDDEN>, Damien Cassou <damien@HIDDEN>, Eli
>>   Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org
>> Date: Sun, 24 Dec 2023 11:37:55 +0100
>>
>> >> Regardless, what I said initially holds true ultimately: either epa-f=
ile
>> >> should not be relied on, or a-s-p should ensure it is present.  I
>> >> gravitate towards the former, as it reduces the complexity of getting=
 a
>> >> password-store entry.
>> >
>> > I vote for the latter, because it simplifies overall maintainability.
>>
>> I disagree.  I think that involving the f-n-h-a mechanism for handling
>> PGP files ultimately introduces implicitly far more complexity, even if
>> the code is slightly briefer, precisely because of this dependency.
>
> I disagree with your disagreement, and agree with Michael here.  I see
> no maintainer's complexity in using file-name handlers that could be
> avoided by not using them: file-name handlers are, and will always be,
> an integral part of Emacs internals, so thinking about them as
> "complexity" makes no more sense than, say, thinking about GC as
> complexity.

In that case, auth-source-pass should ensure it's there.  This is where
the complexity I refer to creeps in.  Now auth-source-pass needs to
alter and restore file-name-handler-alist as appropriate.  This means
that it has to get involved with global state, potentially impacting
other functions it calls.

It seems to me more reliable to alter EPA to provide an
insert-file-contents functions for direct use.  This is less composable
and elegant than file-name handlers, naturally, but it is also exactly
what a password-store read requires.

Naturally, file-name handlers are integral and highly important (and we
had an example in this thread: Tramp support /just works/ due to them!
A thing of beauty, really), but this is a rare instance in which a
file-name handler is absolutely required for correct operation, rather
than supplementing existing functionality, which is why I see this
instance differently.

> P.S. Would people please not use "shorthands" like "f-n-h-a" and
> "a-s-p", but instead use the full names?  Those "shorthands" make the
> text harder to read, while OTOH typing them in full using M-/ is very
> easy and takes only a couple of keypresses.

Sure.  These became a bad habit of mine due to Emacs handling them
often.  Apologies.
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYgf118UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSThGQBAL28aIj4YvXnngXRraqSIPimY1NowUUCc1gG
Z1RkOQgkAP4vxt7sQOnof8rqEkT7D+gTUFXSLO6KqpvD8XOwzTRfAg==
=xQpp
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 12:01:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 07:01:04 2023
Received: from localhost ([127.0.0.1]:51758 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHNAF-0002X5-UB
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:01:04 -0500
Received: from mout.gmx.net ([212.227.17.21]:52505)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHNAD-0002K7-Dt
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 07:01:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703419242; x=1704024042; i=michael.albinus@HIDDEN;
 bh=s0v6Jp7333HYn3TK5airYL0cBfSTzyRY7e89a9hQYvI=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=K4JV8aMmHRnGeDSlCj4KUINY+o5SRmH7PaXZoTVM1peBj7Q+EIpPJu1a6vPZoWIM
 jvETRnIWn+qTNbkoFcCd15+Ke8UyCNuErQlUj60Bgxq+K5i7PtX/8U8OJsEDBtLiy
 e4s9D6U6ySJGEyweOFRB4x9bj0WSqlq6Gkdx3epd3+RpoTYyCx+os8RoGFBHjTCaK
 L6BRxLdDxGoyU4WcAloP2Zz6+AoGGT/B4EKuqPdG/KzjsNXsbrwDW7e+Cx5iqTA2D
 B1J0gJdbGclOWd8pqi3hHsd10Gkk4NrnCxPV/PJ1u76td1OMC5P6Hepb0fTF7K40z
 lU+JqRyfnRukTTXGSw==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgesG-1qlaBK0zyW-00h57m; Sun, 24
 Dec 2023 13:00:42 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <867cl3kh4p.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sun, 24 Dec 2023 11:37:55 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
 <867cl3kh4p.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 13:00:41 +0100
Message-ID: <871qbblsie.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:kuT0ylp89Wb1Aux9XV8fovwkEVayWLhpAcUTUCdwO3TxG20BUli
 zVX8ew+JDQ51L8Cwuchx9CWqqGaTTuICicxTID2GT59P3h7PXJEKtXSKRKF8Uwit3pI6aDe
 oClgfr5qhL91VuYqbGJBC/27CkipFVkbLSE4MY18DIDlV2bCmqJd2oovlHchqi7OZDVIlu9
 Gtlzm3x3Ug8h4tOwe5+2A==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:6DcNzAimq1c=;+d3+GhTEAiMGV6apb4OBtESjFg1
 ClY1jr4AjMjNfihza/VUHfiW93Xg40gwkGzgC7W+JTXTNDkxE2NnSOthdMn/gYg0MJVCkj14k
 rpOnRFBhzsEwYT4XgFR0GWejhzQX7s2dvKM0rIMv6tx8vXEebbgZw3kItgF3cKyhJbNfevwtb
 neuEKDFQdGBRWKT6e8dw7Lwlau2oWc7CGkf/RVhQQhIRybbi5cnn4Pxa809qeTDP9cEcueFOy
 p8n/VCmt0evGYYZMohdAy4fouJpCf7veHCqwBMN6haE0HCc8CPqiFxj5nBdcW/8ZLCEChJLp4
 hwNkedU4UBZuhLCg5dH21ItR/Lc5/R2Q2mdsCFxzePaxwDqJAGRRupoaaSmwBM9rt24H7ubh9
 IlwEIg2fwS0zXU1JvKshVQrFTHaVboghqV0Y+2/TLFs44ntSWf/dQap3F8JizDD8aRZwhV2E6
 mByfRegWZVxhRHEOv0nvJV68gLYBmKlr2m4sQQ0rjbflFj1uWeCmpg8sn6sl1n8s99bNqm4/j
 f8+wWbVGBny08VLS5LL6EW5u7WqJxj0I/G+sDJhmqh4rkKXFUy2NArU1hnoPJsMpOXvf4npE9
 zTgRyh9NhK16vie3KcqkNLya3YaOykwPyU4ro4HBw9aVK+kT84Wz80RbKefCGfCVgIt5CsAYE
 epJZA9MmKd9cHWN0H8EJV3LMEVRqyyWClq/SitM9NxfwRe9wLG5HvM2nXn5tVjG1tSV6BKNic
 DZEmSQSjqjEMqdgADwQqrHQyaiPgxu5GGfMhu97I3J24D2LE0cmqpjBn5TIpipOkjVcTZa3J7
 YQwmKrYOkg0kEFMFxMKs7gsi/UqunBeqD6ZdHn/pj8YR0lCpddeJoksCSAYHDw/Mut1vLnf9W
 Ttk4Q/Fv4bM1BDtwlthGmRxw0RotjIh1kVRwpPRACwdu0uySVFizGistmOy4crW9yUaEfsGvA
 rpma1iUhENzk1hOoJ0qdufnPiVU=
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, Hi Arsen, 
 
 Content analysis details:   (2.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.21 listed in list.dnswl.org]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.21 listed in wl.mailspike.net]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, Hi Arsen, 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.21 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.21 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> Hi Michael,

Hi Arsen,

> Based on observations during the last 24h I've noticed that many Emacs
> functions do, in fact, reset f-n-h-a to nil.  I'm yet to spot the
> combination of calls that leaves epa-file not added back in.

No package in Emacs should reset file-name-handler-alist to nil. If you
find such code anywhere, please report an error.

What is possible is to let-bind file-name-handler-alist to nil.

> Thanks, have a lovely day!
>
> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 11:55:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 06:55:51 2023
Received: from localhost ([127.0.0.1]:51742 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHN5D-00005k-FP
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 06:55:51 -0500
Received: from mout.gmx.net ([212.227.17.21]:54001)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHN5A-00005Q-01
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 06:55:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703418924; x=1704023724; i=michael.albinus@HIDDEN;
 bh=SBWGbtNbIB/itWHGkDfe8DVMuy9e217FiU2buFVwKEo=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=YlnEQYo0QYnnj11CHAvAFolPit/d7W3t+zIyBFgLUtjvJ994m6xgN7WEd7sCbagP
 l7YZRxjxYAwvHkM1AHHzMhnggdl70Yydxip2AZcrIuXUWF4FP40QgKTTOsN9LB52I
 FMV2FwubJ1bijapY0vAomlzRl9rvyFldtleEgDK9+6NW0xatpqpKiDDdxKnsYVgqn
 dRhJGTcBiwnZ7jlEDc4c2oPxE3iwReTqaQ4QqmC069Cg0+wsJAMOD78+YesH8rn0e
 IfGqllvVVEydfyjHGwN1t/5PpU31T9sMyKtJ2uMb3nxCvqcpjAWIocksHRGNQjf4i
 CHM8uEXEoc7NlUZ6gg==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MN5eX-1raPWr2ndV-00J5PE; Sun, 24
 Dec 2023 12:55:24 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <865y0nnb1i.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sun, 24 Dec 2023 11:25:24 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87sf3sjuq7.fsf@HIDDEN>
 <865y0nnb1i.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 12:55:23 +0100
Message-ID: <875y0nlsr8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:V8y5Uv14SAogO5b+n7BmEMqZdmoBVz0mwgIrsXK5tSqzRi+PdbP
 L6yirNoO0Tyi+6mSBV3pAFSUxYhlDR9Wu9MdeK9Xg7G9yaPk8voaqDsBzKtL1FTF6Ceoaj2
 WDAwiuASRGWVSsoX+VNYzcwhYJNzLKrOpHfl+gFYoaPqGSzi95Q/mZSLV6FkCUz+/Z+BLb+
 Ef5E3TDMxTQ6+hKEAfggQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:FB/Opfc0TE4=;l44hC9nJgT0bhtWrLYX8biezXfP
 pSKKfrEAOBq30+OLSHLKHr0rxJ7LX+cdEUdxzgm/+0+z24t8Wl8K/MKo0IyrFDkXpkMnsmrRO
 BQyP+Zj0190yJR8oOMtSiLXLaR8P81Q7l3sqd4L9IMSy/VNExs7HGzaTNSfclaAKx7B7g2p8l
 kouXHv9WHIzedEmpJIGSMYwzmM6DY/wo44ZXAm/ZhUVMIwoO75YyFuC91xoEW0qYm9SwvKFvR
 V1EtLpsV/OyUzHt56nQ9sYVcTBjZlEo5pRuSJS/i4KfeO99wN+SKkDhTgOUU5sb28IfO6+C7n
 TjlYrMnFWJWZ5bbA8yMOlw/pyZX6voOpNuQYG3oX3+lfaDPD1Otc3ZtTwp1J2p3WTbcmsJ+FE
 CQ0xW1u36K+AcWIdBm4aJiBnqFMv4Pr/3QMfwfbHsPZSROwrMKdFg4SFmxzT6LKNISY/eEYEH
 HWtsbX4VIbiJF4h+EqqsgdNkXuEXCZYfeOhKzMNuPs8HsAHozUGs9ITpSDP1b2IVQkWh2wFf/
 zsQG76Cw5qUb+K2dPIxKqGQw4Xdl4Ko6NGrD4F36RBMOJxL4DjSfz/LFzZ5XxP+bWFLm5ednb
 ZVaRBFwpNa0yCkG5X6po2TrhRbtP56s4pA6zkg/Ekf2mORmOOgZUUEtJ/x2BdeEDtUipTFiJE
 lJaKYTkTNfR6PmhJ0TSZJ81KqFYY3Gjtnv+xb4iDxuWTxIAZpeqZhn0PoNLdH5PfzzHK7IzaH
 8OH4niGp2waHcs+mQH1mloeF/WRneTpRaehaXEAqm4sX7sU4MmsPkdlsULNi9BhsbdCmpHAPl
 J4cbow/M56jxRNOkuIYmXnnAFqiyZ7aaibMI3/3++lMJ+8zS9bMW4Yq/5dU3byif1DDvGMCqZ
 uUe/v9C0abnS2fkOYNl+glVI7ZvdsCdPYAQJBfmPz9bV5YCGS/uyb/M44Xt9yTJ7t2hSA6kR6
 tsPMssems+PyTS46ZJ6e1xXRKMQ=
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi J.P, Hi Arsen, 
 
 Content analysis details:   (2.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.21 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.21 listed in wl.mailspike.net]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi J.P, Hi Arsen, 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.17.21 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.17.21 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> Hi J.P,

Hi Arsen,

>> Perhaps it couldn't hurt to get that somewhat sorted before modifying
>> `auth-source-pass--read-entry'.
>
> I firmly believe that these are two separate bugs, one of which
> triggered the other.  The reason for that is because I can reproduce
> this bug by simply running 'epa-file-disable', without invoking the
> original bug that revealed it to me.

auth-source-pass.el depends on an active epa-file-handler. It should
check this, and report an error if it isn't there. There's nothing else
to do, IMHO.

> Thanks, have a lovely day!
>
> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 11:41:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 06:41:33 2023
Received: from localhost ([127.0.0.1]:51734 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHMrM-0005Mm-TD
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 06:41:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:47376)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rHMrK-0005MY-0H
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 06:41:31 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rHMr7-0006Da-4I; Sun, 24 Dec 2023 06:41:17 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=w3qo199mLOf/AEh9MQ4Ensx8/dh2tTFO0APUpgfNBYM=; b=QNODdFZUI51txoZ67fNq
 md8stjRzqfOHJgkrrVZtCZ67xdksMnCzz5NFnWfdYYsn37asx2eouv+Io+x77tGZKie8d2SD9fZE7
 RQSuMQtSra52bLC/Zo2FpZyAwfjOI9vp9czFG/XGrIiNi6iDjELJSRJGKrbdrvj9rFanYtTVEsq0U
 Z6pJmER/+G14VUfL8jMPxkLhSjioN2yCBw6k3i8cW1GEshoaOoPCOHdpob7shWPxSlPXUludCeO2z
 MgwGvBdSKp62D0H5HrE4jJ9Dzo94xLbesP1IjGpQ6MzouyFXnBMq9VtAnNd7DZOEG5G882OTvaT33
 lEjnQ5yNGBBXxQ==;
Date: Sun, 24 Dec 2023 13:41:09 +0200
Message-Id: <83a5pzde0a.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
In-Reply-To: <867cl3kh4p.fsf@HIDDEN> (message from Arsen =?utf-8?Q?Arse?=
 =?utf-8?Q?novi=C4=87?= on Sun, 24 Dec 2023 11:37:55 +0100)
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN> <867cl3kh4p.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67937
Cc: damien@HIDDEN, 67937 <at> debbugs.gnu.org, michael.albinus@HIDDEN,
 jp@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Arsen Arsenović <arsen@HIDDEN>
> Cc: "J.P." <jp@HIDDEN>, Damien Cassou <damien@HIDDEN>, Eli
>   Zaretskii <eliz@HIDDEN>, 67937 <at> debbugs.gnu.org
> Date: Sun, 24 Dec 2023 11:37:55 +0100
> 
> >> Regardless, what I said initially holds true ultimately: either epa-file
> >> should not be relied on, or a-s-p should ensure it is present.  I
> >> gravitate towards the former, as it reduces the complexity of getting a
> >> password-store entry.
> >
> > I vote for the latter, because it simplifies overall maintainability.
> 
> I disagree.  I think that involving the f-n-h-a mechanism for handling
> PGP files ultimately introduces implicitly far more complexity, even if
> the code is slightly briefer, precisely because of this dependency.

I disagree with your disagreement, and agree with Michael here.  I see
no maintainer's complexity in using file-name handlers that could be
avoided by not using them: file-name handlers are, and will always be,
an integral part of Emacs internals, so thinking about them as
"complexity" makes no more sense than, say, thinking about GC as
complexity.

P.S. Would people please not use "shorthands" like "f-n-h-a" and
"a-s-p", but instead use the full names?  Those "shorthands" make the
text harder to read, while OTOH typing them in full using M-/ is very
easy and takes only a couple of keypresses.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 10:52:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 05:52:19 2023
Received: from localhost ([127.0.0.1]:51727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHM5i-0004Ue-N4
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 05:52:19 -0500
Received: from mout-p-102.mailbox.org ([80.241.56.152]:33780)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHM5g-0004UQ-LF
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 05:52:17 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SydC72574z9sbm;
 Sun, 24 Dec 2023 11:52:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703415123;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=iw7qyPG3Uw4hYup7hgoG9fgvynm99MXU8Iqk70JP20Y=;
 b=163uJxIW87XQNUFRLqV6dwaF5oswNA+Q2Zm5yHemGjZLKMA/VvyCVfrJkR/fOXDzxIpnhM
 s2yheEbQyvFMIwy0oQXDfxXSZ6xnnUrkdnErEhvt64EWgdgG4MtFPylVBY3rz0LdJWbzTu
 Ld6/f7X/+WEJ4DHjXUbUoyKyc2oz6MRcXdc/trROS29jQrY6X1MweQFuoFdQzKSB2Zc6fg
 RjFdR9U05ORcm8x4Ge0G/FnXWk3mjqUdupw9DfQUiKXHo4VKLPHz9wDEUQfF62pw/V7OM7
 tD714LFOljVYCSeBk2+mek1gXHi590Z2GBCt+29DpGAIwzGWpSM1CKFh8pYDSA==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87h6k8kk4l.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 11:37:55 +0100
In-reply-to: <87h6k8kk4l.fsf@HIDDEN>
Message-ID: <867cl3kh4p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4SydC72574z9sbm
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

>> No.
>>
>> This patch/bug report addresses a real problem that exists independently
>> of what triggered it in my case.
>
> The problem happens when epa-file-handler is removed from
> file-name-handler-alist, and no other handler responsible for *.gpg
> files is active. Understood.
>
> However, in normal use cases, nobody removes this handler. If I'm wrong,
> I'd like to iunderstand those use cases.

Based on observations during the last 24h I've noticed that many Emacs
functions do, in fact, reset f-n-h-a to nil.  I'm yet to spot the
combination of calls that leaves epa-file not added back in.

I know that it happens sporadically, though, and that it does not appear
to be via a let-binding, following passwords failing to fetch correctly,
I can't open PGP-encrypted files.  The latter fact is how I initially
figured to inspect auth-source-pass.

> So we must document, that auth-source-pass.el depends on such a
> handler. We could also add a check, that there is such a handler, and
> return either nil if it is missing, or return an error. As a first step,
> we could add a note in the manual, see (info "(auth) The Unix password st=
ore")

An error is preferable.  IIRC, auth-source caches negatives too.

> Just implementing an alternative doesn't sound the right way. This would
> also increase maintainance burden, if something changes how *.gpg files
> shall be handled.

I see where you're coming from.  I propose refactoring EPA to expose a
function to insert encrypted file contents as if via i-f-c, but without
requiring f-n-h-a as a solution to that issue.

That could lead to a more consistent user experience, too.

> As example, remote files won't work when tramp-file-name-handler is
> removed from file-name-handler-alist. It would be a strange approach to
> implement a Tramp alternative in packades depending on Tramp, just in cas=
e.

Correct.

The difference here is that password store entries are by definition
PGP-encrypted files.  They are not by definition possibly remote files
exposed via TRAMP.

The latter working is a nicety of Emacs design.  The former is crucial
to interacting with the password store.

>> Your gut's nearly certainly right here :-)  I am still hunting for the
>> cause of that issue.
>
> Good.
>
>> Regardless, what I said initially holds true ultimately: either epa-file
>> should not be relied on, or a-s-p should ensure it is present.  I
>> gravitate towards the former, as it reduces the complexity of getting a
>> password-store entry.
>
> I vote for the latter, because it simplifies overall maintainability.

I disagree.  I think that involving the f-n-h-a mechanism for handling
PGP files ultimately introduces implicitly far more complexity, even if
the code is slightly briefer, precisely because of this dependency.

In addition, the user can't reasonably customize reading PGP files
substantially without breaking the contract with the password store.
This, to me, means that supporting that scenario isn't very useful,
especially in a program like Emacs, where any component can be changed
on the fly, leaving the user with the option of customizing more
directly.

Thanks, have a lovely day!
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYgNRl8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTfWUA/0DMe0T0WQYXM0U74+TbuXn9BdyJVJz5Ja1B
JHCMhYYIAQDS3BL/ZqBR1HhAbpXcMTznnKXkEsn3PLJl8mo7mfcdBA==
=qrLw
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 10:36:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 05:36:17 2023
Received: from localhost ([127.0.0.1]:51716 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHLqC-0001Q4-9B
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 05:36:16 -0500
Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:45110)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rHLqA-0001Pm-3m
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 05:36:14 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Sycrb09Kbz9sc8;
 Sun, 24 Dec 2023 11:35:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703414159;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=aDhH4nbqcPwXq55pjF80WP8aDfkyluXssJgMcRUzT0A=;
 b=fSLmtqvHEqg7eSTQa9v+Vbj00NfxTAT69Ieq3IDIxIGfe9GKmbm2egocsxZ9eQsl58C5FX
 I7VB0HySadVdxih0JoXhlb2Rj0W7IBmHD6GEFBZGxpQAcPnn4fbWumFfXq7KWkrVyZWfd/
 vAARclTLLUaGUeHa/uhdgBfxecJT8IAdncIriNuIIzWgu6imnUZ8cGDeYRC2qKPcO+r5uS
 YZX12uoaTbocrGyQcEESt5EQoZCI1Z5q4pgmgPWEe1BBAHaJaTql6SDg+1VYmeFBbbK2Hj
 VlQHmo3XIkuGHZXpR/LoSRdMfnTqc9x/utDU1uOz9vT0e5F+//dn1jVkK3cHZw==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN> <87sf3sjuq7.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sun, 24 Dec 2023 11:25:24 +0100
In-reply-to: <87sf3sjuq7.fsf@HIDDEN>
Message-ID: <865y0nnb1i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4Sycrb09Kbz9sc8
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Michael Albinus <michael.albinus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi J.P,

"J.P." <jp@HIDDEN> writes:

> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
>> This patch/bug report addresses a real problem that exists independently
>> of what triggered it in my case.
>>
>>> My gut feeling tells me that this could be the real problem, and we
>>> need to solve this instead of bypassing the problem with another
>>> patch, which could introduce further problems.
>>
>> Your gut's nearly certainly right here :-)  I am still hunting for the
>> cause of that issue.
>
> Perhaps it couldn't hurt to get that somewhat sorted before modifying
> `auth-source-pass--read-entry'.

I firmly believe that these are two separate bugs, one of which
triggered the other.  The reason for that is because I can reproduce
this bug by simply running 'epa-file-disable', without invoking the
original bug that revealed it to me.

>> Regardless, what I said initially holds true ultimately: either epa-file
>> should not be relied on, or a-s-p should ensure it is present.  I
>> gravitate towards the former, as it reduces the complexity of getting a
>> password-store entry.
>>
>>> Hunting for this problem I recommend to use
>>> (debug-on-variable-change 'file-name-handler-alist)
>>
>> That is too verbose.  The following appears to work well, though:
>>
>> (add-variable-watcher
>>  'file-name-handler-alist
>>  (lambda (symbol newval operation where)
>>    (cl-flet ((hefh (val)
>> 	       (seq-some (lambda (x) (equal (cdr x) 'epa-file-handler))
>> 			 val)))
>>      (let ((hb (hefh file-name-handler-alist))
>> 	   (ha (hefh newval)))
>>        (cond
>> 	((and hb (not ha))
>> 	 (debug--implement-debug-watch symbol newval operation where))
>> 	((and (not hb) ha)
>> 	 (message "epa-file added")))))))
>
> I can't imagine
>
>   (rassq 'epa-file-handler val)
>
> differing from
>
>   (car (memq epa-file-handler val)) ; w/o the quote
>
> But if it somehow does, that could provide an insight into the cause as
> well. Just a thought.

Interesting, I didn't realize epa-file-handler is also a variable
besides just being a function.  I also didn't know rassq exists!  Goes
to show how novice I am in elisp :-)

I will clean up that code above.

You're right WRT those possibly different being interesting, I'll try to
catch that, too.

Thanks, have a lovely day!
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYgJWV8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTUucA/iSAvzdCoYln0pyP8HSjYSnykEZRUPIGS/gV
hls+lBvoAPwIyoYBwPu9HfrH6UfxeuruMgN06VP52MSRKg8ThgowDA==
=unQr
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 09:47:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 24 04:47:29 2023
Received: from localhost ([127.0.0.1]:51693 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHL4y-0000ls-Jb
	for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 04:47:28 -0500
Received: from mout.gmx.net ([212.227.15.18]:56301)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rHL4w-0000le-3n
 for 67937 <at> debbugs.gnu.org; Sun, 24 Dec 2023 04:47:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703411227; x=1704016027; i=michael.albinus@HIDDEN;
 bh=xTrAmH4dOxF2DKipcyAxs9fFrpI7RiJQS9gBkQKY0DY=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=Rlr5jLo3S0S031s1tXFvX0/sRF0NMcvXoOoDT3FayjP3tszpo6YNhoX2nK0W1I6C
 iLjvgaKnRd6Z1Q8ISxgZ1o2vW39mrOBT5hv8rBCHyqkBFNDta2PxtOlPeILcdEgrr
 qRdV2QbDRn0GwnvN1TyhdBsGI9ATJ+pmaXhmhd0aAv5xjcHRHVdRvUe5xie1jD7sX
 qFq1gRLl2Lk452AQEwC/i2k/IN8e+ZjRJsxDnBe5q6GXvswRZY7Ny3PrLXbYoD+TR
 19pxAyEreWw87d2aMzlmsSPaqXBDOuP4HM5yS3CWD74NkPvpKmcKRZShhAWHTFPJY
 fUUiUhj/L69X7SSrFg==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsHns-1r1Apd233K-00tgXI; Sun, 24
 Dec 2023 10:47:07 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <86r0jcn100.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sat, 23 Dec 2023 20:44:21 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN>
Date: Sun, 24 Dec 2023 10:47:06 +0100
Message-ID: <87h6k8kk4l.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:7FxoLzx4vdHVTLS3ECXUKy17imz6w8sihSmS03rK4BaX6FZRdMY
 VLaxSd8ONECYRWPjH1Oy61/DpafZLlf5xQ5pxIgAqiMD4Ahg4f8xlKm0I9E/2eZeB4qi0Qb
 xomoQDWYz5P/jCv9ChTSyIHkhuIvYosGpYzlxHI5eyGuP78BJxMdBXs/JnduiwUve53fh49
 TqsbDroqFYlgZ8LkfNviw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:P9BanCbwf9Y=;IawhM538XC/a6iFLe7nyUNIIlh5
 PK/RkfGJZ3ve6hkESdfHZjxm1f3vBClVmTAEYWoviNCkVXHyMtrwUm+3f7qvSWveBGBycgt9o
 ZCIlhNBiAVsbnlq/0Nfh2IVrDutrqTzqg01hBp+uFtCdpRdraDvvPbOH1yHzLOOtwkEfVXMnd
 551vScDKjbNG058Z0AqCQ+1aNEr4tS7V01iMnWqAjLukTD/GUTWZK3aE6ERwFxnKqqwDbDW9o
 3nUZw7Tr2y/XvlSZ0FcBB7NOrxtS5zVgjbWjmGiL+WzMjzGbdK8bF6Zddkz/zmVQaAdyuCjr0
 m0QkM7WbLnDkFLh+uHwVhGL6dsbNUJHxe7fw/Qdfg4Qp8OkGIfYbT9EKUAm7jLsHSdkG0wbvN
 IgYNlt2OkyfVoT4PJBxN15F5BvjEsTgysGqm4Zzw51MzUNGRpQzBBPzG5tm5vNMDHIknSAXtD
 0uDHQKnzAk+FxA90I4BpYDFqxLSNwXUqN5ajvOPydL8XPH/TUWm4W7qSgfR1fZfXHPcHo9GNQ
 GsmmbUstc2biKyUpuRDisu1wOLPCFQl60z4st3rg6r4aIiI90IoOBYn0T0KL+B0dKd6RUbnRP
 bW4cOsynh3NHPvWe/6j7H8JqKbNre0IfWxPMo5LuAdsozkcCfazsuAgpJjSJnVpmn/f7+3vVz
 sC4VePSBbY52VaTsWbJZ6f5+nDvtl8HZGAom00ua6T0wDjd3HsoctS2VrH1OCwFz1CyuDf+DZ
 mRUaPUyaxW2Qlro2UlgFMg1FCK6KD3Ro4cdMhvl+W1EiMU9WndOaJBPcul6whFl0y2/Dy0Uui
 Ytm+0eO5JFlIlhXMUUGVjS5HU1q10c2VExygMVZdc5LM3Rn3OnKk2HRqAQsrdrLHc/POQa9/P
 IwRr5Zi/IaG/Eb7wqx2H1j3FfhUqk6StYJwSnabKHyKYMXGbJ20uitmem9Nt6YLgBZP4vxAHk
 rTAqfyOcfqUhAcnWgVIcdTrO/MGm9sDLpKVBFc5XJO4bf4Us
X-Spam-Score: 2.8 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, Hi Arsen, 
 
 Content analysis details:   (2.8 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.18 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [212.227.15.18 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.8 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Arsen Arsenović writes: > Hi Michael, Hi Arsen, 
 
 Content analysis details:   (1.8 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [212.227.15.18 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.3 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.18 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> Hi Michael,

Hi Arsen,

> Michael Albinus <michael.albinus@HIDDEN> writes:
>
>> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>>
>> Hi,
>>
>>>>> This happens due to the call of `epa-file-disable' mentioned in the
>>>>> initial recipe.
>>>>
>>>> IIUC, the call in question was only included in the recipe to simulate
>>>> the effect of the entry disappearing, and Arsen is still trying to
>>>> pinpoint the actual cause.
>>>
>>> Indeed.  That's a topic for a different bug report, though ;P
>>
>> Do you have a recipe for the problem w/o calling epa-disble-file?
>
> No.
>
> This patch/bug report addresses a real problem that exists independently
> of what triggered it in my case.

The problem happens when epa-file-handler is removed from
file-name-handler-alist, and no other handler responsible for *.gpg
files is active. Understood.

However, in normal use cases, nobody removes this handler. If I'm wrong,
I'd like to iunderstand those use cases.

So we must document, that auth-source-pass.el depends on such a
handler. We could also add a check, that there is such a handler, and
return either nil if it is missing, or return an error. As a first step,
we could add a note in the manual, see (info "(auth) The Unix password stor=
e")

Just implementing an alternative doesn't sound the right way. This would
also increase maintainance burden, if something changes how *.gpg files
shall be handled.

As example, remote files won't work when tramp-file-name-handler is
removed from file-name-handler-alist. It would be a strange approach to
implement a Tramp alternative in packades depending on Tramp, just in case.

> Your gut's nearly certainly right here :-)  I am still hunting for the
> cause of that issue.

Good.

> Regardless, what I said initially holds true ultimately: either epa-file
> should not be relied on, or a-s-p should ensure it is present.  I
> gravitate towards the former, as it reduces the complexity of getting a
> password-store entry.

I vote for the latter, because it simplifies overall maintainability.

> Have a lovely day!
>
> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 24 Dec 2023 00:43:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 19:43:47 2023
Received: from localhost ([127.0.0.1]:51504 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rHCap-00074r-7Q
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 19:43:47 -0500
Received: from mail-108-mta151.mxroute.com ([136.175.108.151]:43719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rHCal-00074h-UI
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 19:43:45 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta151.mxroute.com (ZoneMTA) with ESMTPSA id
 18c9946f1270003727.003 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Sun, 24 Dec 2023 00:43:32 +0000
X-Zone-Loop: 896ea9e88add881c49709e13ade822271723bb6dddba
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=f1godKTIF85wN3+jHK3xrt77pLryReT2nFopltVFMuI=; b=QSes0lYw4xc+cMwcetZXg6sf4t
 w4s+En6DYt1GFHs7zBO59GpV2raE08nm/8T9l4EpmWJC5EiW57j4VWiRq6TnefHluK6goyKuaZlKR
 gKKtCOs4uh1MwdkXTxt8cJolH/aezU/VrnWo4v5Kz9KCO9mt6xWg+tG8KgcpKSuTfc6M0MLuTzFE6
 kmGvNzWKwx37jOEHWDKTHnX5tur+cO3yUnCPlSgSRNXmt+kYFB+aYzX6DPQCH8O953udXHIpR1C0A
 laQopnNHRCFSzLLls4YsrBLsf5ye7mTF6p3sKIv0HnM/MtIO7d2yUK1nacUf2OiB3sIlHRnL5h122
 eW5xryYA==;
From: "J.P." <jp@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <86r0jcn100.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sat, 23 Dec 2023 20:44:21 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
 <86r0jcn100.fsf@HIDDEN>
Date: Sat, 23 Dec 2023 16:43:28 -0800
Message-ID: <87sf3sjuq7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Michael Albinus <michael.albinus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> This patch/bug report addresses a real problem that exists independently
> of what triggered it in my case.
>
>> My gut feeling tells me that this could be the real problem, and we
>> need to solve this instead of bypassing the problem with another
>> patch, which could introduce further problems.
>
> Your gut's nearly certainly right here :-)  I am still hunting for the
> cause of that issue.

Perhaps it couldn't hurt to get that somewhat sorted before modifying
`auth-source-pass--read-entry'.

> Regardless, what I said initially holds true ultimately: either epa-file
> should not be relied on, or a-s-p should ensure it is present.  I
> gravitate towards the former, as it reduces the complexity of getting a
> password-store entry.
>
>> Hunting for this problem I recommend to use
>> (debug-on-variable-change 'file-name-handler-alist)
>
> That is too verbose.  The following appears to work well, though:
>
> (add-variable-watcher
>  'file-name-handler-alist
>  (lambda (symbol newval operation where)
>    (cl-flet ((hefh (val)
> 	       (seq-some (lambda (x) (equal (cdr x) 'epa-file-handler))
> 			 val)))
>      (let ((hb (hefh file-name-handler-alist))
> 	   (ha (hefh newval)))
>        (cond
> 	((and hb (not ha))
> 	 (debug--implement-debug-watch symbol newval operation where))
> 	((and (not hb) ha)
> 	 (message "epa-file added")))))))

I can't imagine

  (rassq 'epa-file-handler val)

differing from

  (car (memq epa-file-handler val)) ; w/o the quote

But if it somehow does, that could provide an insight into the cause as
well. Just a thought.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 20:02:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 15:02:04 2023
Received: from localhost ([127.0.0.1]:51294 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH8CB-0003cZ-Tw
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 15:02:04 -0500
Received: from mout-p-201.mailbox.org ([80.241.56.171]:33030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rH8CA-0003c5-9F
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 15:02:03 -0500
Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SyFRw70f9z9sb5;
 Sat, 23 Dec 2023 21:01:48 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703361709;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=klUueCQmnjgW87/U4fjUOgHTpPKOqGA4KhV6g5EKalw=;
 b=ruYfdygbVAcinbdr9THq8JAIwov7TVM9bESZH9mJZpIFKku1Z1tsZpUvcusmsn54V3etBW
 8ZnIDjc7A1MYaReZlmRg8U1qUjXVk3mNGw6fW7+8JJ8l/y6YHJQjEG7O3A6ij1enSL7r+1
 G8ebVbWdJ3KoorUGeJBH1EobJGS6xtvmx1XkLSc0VYXeanhxessl9jfehGd47DQPFjvdwd
 ntaDYQ9u/IehbPydcLn4QD+pjtDb6H+32IlL65rwu3cdGQMLXfUWugHK9KKCAQVUKB/AhW
 S/gCPpMRSudLHfx/zqvtIoQ+whsY13XtX5ZpzgR7/9QAZkbF86iorpLzgIm9ow==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN> <87plywlus1.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sat, 23 Dec 2023 20:44:21 +0100
In-reply-to: <87plywlus1.fsf@HIDDEN>
Message-ID: <86r0jcn100.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
> Hi,
>
>>>> This happens due to the call of `epa-file-disable' mentioned in the
>>>> initial recipe.
>>>
>>> IIUC, the call in question was only included in the recipe to simulate
>>> the effect of the entry disappearing, and Arsen is still trying to
>>> pinpoint the actual cause.
>>
>> Indeed.  That's a topic for a different bug report, though ;P
>
> Do you have a recipe for the problem w/o calling epa-disble-file?

No.

This patch/bug report addresses a real problem that exists independently
of what triggered it in my case.

> My gut feeling tells me that this could be the real problem, and we
> need to solve this instead of bypassing the problem with another
> patch, which could introduce further problems.

Your gut's nearly certainly right here :-)  I am still hunting for the
cause of that issue.

Regardless, what I said initially holds true ultimately: either epa-file
should not be relied on, or a-s-p should ensure it is present.  I
gravitate towards the former, as it reduces the complexity of getting a
password-store entry.

> Hunting for this problem I recommend to use
> (debug-on-variable-change 'file-name-handler-alist)

That is too verbose.  The following appears to work well, though:

=2D-8<---------------cut here---------------start------------->8---
(add-variable-watcher
 'file-name-handler-alist
 (lambda (symbol newval operation where)
   (cl-flet ((hefh (val)
	       (seq-some (lambda (x) (equal (cdr x) 'epa-file-handler))
			 val)))
     (let ((hb (hefh file-name-handler-alist))
	   (ha (hefh newval)))
       (cond
	((and hb (not ha))
	 (debug--implement-debug-watch symbol newval operation where))
	((and (not hb) ha)
	 (message "epa-file added")))))))
=2D-8<---------------cut here---------------end--------------->8---

Have a lovely day!

> I haven't followed the whole discussion, so forgive me if this has been
> discussed already.
>
>> Arsen Arsenovi=C4=87
>
> Best regards, Michael.


=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYc8ll8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTyw4A+QFz1Ht1XcpSpnMCZANptaeC/Mv8xRn2JASU
UdrIyTXMAQClBmx5d3SlaPLxxHppgbDSqCmpkRHK0SOQp6LzDLffDg==
=CcBr
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 16:59:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 11:59:51 2023
Received: from localhost ([127.0.0.1]:51137 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH5Lq-000738-Qz
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 11:59:51 -0500
Received: from mout.gmx.net ([212.227.17.20]:34069)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rH5Ln-00072u-MM
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 11:59:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703350768; x=1703955568; i=michael.albinus@HIDDEN;
 bh=4lkL7L8uGMNK4dI8lYKUsmuTDLyQdTbTBkttnwr9eLU=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=t8bB4gdub8+P8e5KRjNxvt1JscGWawkrU4sxSKYHxyQS5wHaAHGnXsIo3fw2AkCs
 LVS9dkVud+hL1jOK77QltUr8edHa1EZj578hYwAUCoMd5XjsKCVq078PggxndijfG
 itFk2wHm0E3JWky+FVqIEBhpnrnrcuEKJYOsAUm1sw+MNcr6N1L2noW56wCfRzBqE
 twOePhaGldWXYMRPM+xocAuiWZmlyfi8hyubGXz9DCrl2wbsnj1ePxEyTtGQEr0pK
 npIf5ZmBEPnsYEH8AxU3EXPDSY8oIuqIdn0hZJk2P6MsnA281KChmuc96wrWJXIk7
 yR2PnUKcY4Dgmm7RZQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8ykg-1rJpAf48fe-0065Mv; Sat, 23
 Dec 2023 17:59:28 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <868r5lszxm.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Sat, 23 Dec 2023 16:26:13 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
 <868r5lszxm.fsf@HIDDEN>
Date: Sat, 23 Dec 2023 17:59:26 +0100
Message-ID: <87plywlus1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:AWt6VaIG80+aHzoIiDljjkrzblTVcZe9qgf1tHeB5rW/ZwRwj6S
 PmT4GiX2WfRBX0EEczyQaNhrFATti6qNxxYhqQ9XwPaPKE6Ao+WqYH1hj59/I4i2uP1nVFn
 h1CSB8Mr4TQHqNH+I2ZtflYFgYSh5+CLgEYXe8BI12AWJ3Va4TP2+cSguDyCv4wUF6gdFox
 qf5Rtmlki4qxeX40vIKDg==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:1/XkGTdvEvo=;iRB8VR1z7B6owQJUFiardQKrH7U
 0Jb5u5Twlw8q4hhq4M5yAGe0z94tMRw/9LDaz4fnLt2NCKAWcBzpdclot4+qqFAObV3ne6L4S
 ve5KH9yJN0sDt6PwVyphUGvrLwXgTj1PzvdqdQ4Zoj1HkuPEogJgAbxkUPcMIFR3+b2w55e2t
 fFhOu+gXIS/RuPRc4EmMoWDZvWkILZEh/7bdMP7LIgnN1nhtBJ8ac6+6lV1d9ToHR4XrlWsr4
 LmUw+Cmm6ulL0bh+l0zmHskGAhMYVHQ9gKaZAFDYg3NNWNokk3CaAtp5SxJZq2Fqo37QWzKOM
 Sck/2iUrP5GXBE6gXXq/FMx9E1Kw0nwyzM3G3ZGD+j0kQdHPlJJibHEDL87nzlwd/9ziShPqE
 /9Sju1ykftEukyS/Fe5cdHydFREUteCU2MsgtWb6kQl0Si3U5HAxtT2T/WmGDk4yl88CmvN2X
 qCdLRY8GpIuxgrkGPVpO5Y/DvPQUCGesCe6FJeJ+ng5DsG8B3r0UDoAWLPgMbma5RNtiCUD6c
 03vIGHJ5rTEb/7Ov/OJ6Rz7tCz9l89Lv1/X4svixj6VQjRsLCpngNLfFPzZsoepqx7+3w5h0J
 bNwZ8Q8kIaoXRk2a2vttSuBNzXZwO1ioW67BVkb2g/COd71HEEtceYpjYDJHgTiRZ7eU4kKdX
 3bu+XmbXGai0oZME3LRzWEwJQQbV+gCyZnVMuZCQj/RC27DXqU03CqEYUylfvexTEn9hxWT8W
 alJOTgVFla2cSeuQyD2m7nJS/gkdw00A/B6VK6cbqigPwb4jyPKzC1sbX1nwaddQJbgYNvq40
 aPZ+PKNU3FzrvAxzANJMkdBY2oRE4MXJmb9wNzSAVLgKYYdfRHukyAQAVeAhSZQgubD2cMY8D
 a+sabGVf1QmYkfiRJhKfjqY0FmDxb8SLlipNe0PiSH6t3FW3p4WMUKv1Ysw9N2lSRTxa89hZP
 gA+N0p/ZCWEBy4Ix6c2TmvxKL3I=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

Hi,

>>> This happens due to the call of `epa-file-disable' mentioned in the
>>> initial recipe.
>>
>> IIUC, the call in question was only included in the recipe to simulate
>> the effect of the entry disappearing, and Arsen is still trying to
>> pinpoint the actual cause.
>
> Indeed.  That's a topic for a different bug report, though ;P

Do you have a recipe for the problem w/o calling epa-disble-file? My gut
feeling tells me that this could be the real problem, and we need to
solve this instead of bypassing the problem with another patch, which
could introduce further problems.

Hunting for this problem I recommend to use
(debug-on-variable-change 'file-name-handler-alist)

I haven't followed the whole discussion, so forgive me if this has been
discussed already.

> Arsen Arsenovi=C4=87

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 15:57:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 10:57:18 2023
Received: from localhost ([127.0.0.1]:51103 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH4NK-0003R8-5u
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:57:18 -0500
Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:44626)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rH4NI-0003Qv-3w
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:57:17 -0500
Received: from smtp202.mailbox.org (smtp202.mailbox.org
 [IPv6:2001:67c:2050:b231:465::202])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Sy81W4Qg6z9sqr;
 Sat, 23 Dec 2023 16:57:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703347023;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=MFP+r4/ulx+PhEz8K4N43ozkTpIouZ1mQzViH2Twjlc=;
 b=hgslKvj/54wxFl0raRLSMdQ8bxXcp4hwmaOqlwb6Y9Qr0mcv4xPU3b9uiBz+hS7XYs4pE2
 qYdVQPGUSh7oKLpjVxlS34K+pLEMZUFf5BuVzV2bXHqh5Uglzz3EOU54f/r8kh3k/GNFSs
 aL/FzGZsq8+bEbKL0zbPA7hQEt6JjrNbrafnHkJZpSk4EVNauXUK9Om13JSv0F1jM1x7C/
 cuslO3yUWsmfNLdDsx0bdzPWKuEFNUdFArs27vikVe7bmV/X9CGMIJkooN2zHpynQQdxEq
 mytj9wlLYKZrgtsl5EHq3iEPUgs/zeqp1PtJ3rbRhWwbNku70AzvYuLviPuuPg==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Sat, 23 Dec 2023 16:50:47 +0100
In-reply-to: <878r5mm3el.fsf@HIDDEN>
Message-ID: <86y1dksyia.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4Sy81W4Qg6z9sqr
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, "J.P." <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> "J.P." <jp@HIDDEN> writes:
>
>> Hi Arsen,
>
> Hi,
>
>> Don't kill me, but I have another rather unlikely scenario perhaps
>> worthy of passing consideration (or dismissal):
>>
>>   (setopt auth-source-pass-filename "/ssh:desktop.local:.password-store")
>>
>> If those Tramp addresses don't continue to work after your suggested
>> changes, we should probably ask Michael Albinus whether their working
>> currently is just an accident or something intentional and supported.
>
> I don't remember any special effort making auth-source-pass Tramp-affin,
> but I might misremember. However, I wouldn't call it "accident", but
> "Emacs design".

A happy accident, if you will :-)

> If accessing auth-source-pass-filename uses the well known primitive
> functions (insert-file-contents, expand-file-name alike), there
> shouldn't be a problem of keeping this compatibility with Tramp.

Right.

This v2 patch restores TRAMP support.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=v2-0001-auth-source-pass-don-t-rely-on-epa-file-bug-67937.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: v2 patch

From=202097666b80c1b78462fbf454664b0017773c91d3 Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Arsen=3D20Arsenovi=3DC4=3D87?=3D <arsen@HIDDEN>
Date: Thu, 21 Dec 2023 12:29:55 +0100
Subject: [PATCH v2] auth-source-pass: don't rely on epa-file (bug#67937)

* lisp/auth-source-pass.el (epg): Require epg.
(auth-source-pass--read-entry): Use epg-decrypt-string and
insert-file-contents-literally instead of relying on epa-file
decrypting files read via insert-file-contents.  This avoids
interference from file-name-handler-alist, and avoids breaking
when epa-file-handler is not mong f-n-h-a.
=2D--
 lisp/auth-source-pass.el | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el
index 0f51755a250..abfcf4b710c 100644
=2D-- a/lisp/auth-source-pass.el
+++ b/lisp/auth-source-pass.el
@@ -34,6 +34,7 @@
 (require 'cl-lib)
 (require 'auth-source)
 (require 'url-parse)
+(require 'epg)
 ;; Use `eval-when-compile' after the other `require's to avoid spurious
 ;; "might not be defined at runtime" warnings.
 (eval-when-compile (require 'subr-x))
@@ -194,11 +195,18 @@ auth-source-pass--get-attr
=20
 (defun auth-source-pass--read-entry (entry)
   "Return a string with the file content of ENTRY."
=2D  (with-temp-buffer
=2D    (insert-file-contents (expand-file-name
=2D                           (format "%s.gpg" entry)
=2D                           auth-source-pass-filename))
=2D    (buffer-substring-no-properties (point-min) (point-max))))
+  (let ((context (epg-make-context 'OpenPGP))
+	(file (expand-file-name
+	       (format "%s.gpg" entry)
+	       auth-source-pass-filename)))
+    (with-temp-buffer
+      ;; Avoid file-name-handler-alist interference.  We're reading
+      ;; and decrypting a binary file here.
+      (insert-file-contents-literally file)
+      (epg-decrypt-string
+       context
+       (buffer-substring-no-properties (point-min)
+                                       (point-max))))))
=20
 (defun auth-source-pass-parse-entry (entry)
   "Return an alist of the data associated with ENTRY.
=2D-=20
2.43.0


--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Have a lovely day.
=2D-
Arsen Arsenovi=C4=87

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYcDTV8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSToQoA/jl9XxXZzGu2+btkM7Z9wgfa0vSbUYQKXc14
c0h5wFA0AQCBvo4a0P4OzgxlbHFOg+FyqlOIeSr4qaFdWQEkhvv3Dw==
=4Ba2
-----END PGP SIGNATURE-----
--==-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 15:26:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 10:26:31 2023
Received: from localhost ([127.0.0.1]:51074 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH3tX-0005mo-GQ
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:26:31 -0500
Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:46930)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rH3tV-0005ma-2V
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:26:30 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Sy7Kz5x28z9sqB;
 Sat, 23 Dec 2023 16:26:15 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703345175;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=xjRz3d9TTlpOAdbrQAQUR2pbELepgFdCp3Gu6J2L2dM=;
 b=kGb3mreX0NeOk9l7sPw8DQ/B1Uu+cde7pTYOBMy9WpLs5AUmmsMaceQ0W6rJvJciuQQUUh
 AM9cpLOZRujYatFacy2fz4S26ia3DqCz/1q+28ky9KlQjhYOcGuMfVULEBja6rlliccmu6
 HYofGv6ajiLesP02mr7GXrTKVwjoIugirkTYdtyTMkgf4Ta09ZfVfB6FHQzk4xuldw77/8
 cFRpLtfvJV/7izEos5YiAiK8lGJKZyUjDcpxnSCXUc4U99NR0LeI2WsjGFbRKUUCKYReD7
 5avCDRoAfCQMsQ18ggmE6rEZhxI3iBpm/QJybqEtS3bSxuwg5NhimOxAVMQBOQ==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN> <87bkahlzzp.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-reply-to: <87bkahlzzp.fsf@HIDDEN>
Date: Sat, 23 Dec 2023 16:26:13 +0100
Message-ID: <868r5lszxm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Michael Albinus <michael.albinus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


"J.P." <jp@HIDDEN> writes:

>> This happens due to the call of `epa-file-disable' mentioned in the
>> initial recipe.
>
> IIUC, the call in question was only included in the recipe to simulate
> the effect of the entry disappearing, and Arsen is still trying to
> pinpoint the actual cause.

Indeed.  That's a topic for a different bug report, though ;P
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYb8FV8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTLPAA/1CeXyzDg8YE8EDwDTkukin1CalokbsyIyLY
XRlmmRyRAQDPxYXox197WBhgld26wtR9G9NjIxZpr5/2+eHrG4tRCQ==
=GmPF
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 15:07:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 10:07:06 2023
Received: from localhost ([127.0.0.1]:51058 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH3aj-0002gx-Te
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:07:06 -0500
Received: from mail-108-mta213.mxroute.com ([136.175.108.213]:40383)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rH3ah-0002gp-F3
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 10:07:04 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta213.mxroute.com (ZoneMTA) with ESMTPSA id
 18c973707740003727.003 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Sat, 23 Dec 2023 15:06:55 +0000
X-Zone-Loop: fa7660e0d4c6dac2f22ea60b6b32c5a0a00fc505dd9f
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=OMiYj3ao4ALZ5dORx1dFj3hjCyzKt9tUX8gapkILxxI=; b=RIxptTfmgXXqvae8bgRfDZaKjE
 Zyh3bcnhcRpH7pWz4si3/MYENBQWoAoK+aXgA6aCIW3UhR21tCSox73Icygad+gzidEXbbmgNbvz1
 LYu8FVJS9AnUVjHdv4GFRFZKchWiCSPscCHn76dJ4Bk7W1smCfmpGUNUpQ2/LWh9c7UUMH8ot1jeH
 oVLHNiBLki/xZnbdUzThItPZ4MyB1JGCTrEjZ/0zlE49vnKHszqLAZet6l4niE/jRhKFSYfSDOjIt
 HJ55cXfqsKQ5gyHaV4siR5PxAIzuPrrrp5E3i4OW+RjK+pYHbnmoO8fZa94PDyjLtnhb1tHK3XLWE
 DBNbyRmw==;
From: "J.P." <jp@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <871qbdmagw.fsf@HIDDEN> (Michael Albinus's message of "Sat, 23
 Dec 2023 12:20:31 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
 <871qbdmagw.fsf@HIDDEN>
Date: Sat, 23 Dec 2023 07:06:50 -0800
Message-ID: <87bkahlzzp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> "J.P." <jp@HIDDEN> writes:
>
>> Hi Michael,
>
> Hi,
>
>> The issue in this bug is that a default member of
>> `file-name-handler-alist', namely,
>>
>>   ("\\.gpg\\(~\\|..." . epa-file-handler)
>>
>> which is actually the value of the variable `epa-file-handler' added by
>> the file epa-hook, disappears mysteriously due to "reasons" TBD.
>
> This happens due to the call of `epa-file-disable' mentioned in the
> initial recipe.

IIUC, the call in question was only included in the recipe to simulate
the effect of the entry disappearing, and Arsen is still trying to
pinpoint the actual cause.

J.P.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 23 Dec 2023 11:20:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 23 06:20:58 2023
Received: from localhost ([127.0.0.1]:48715 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rH03t-00079V-Ry
	for submit <at> debbugs.gnu.org; Sat, 23 Dec 2023 06:20:58 -0500
Received: from mout.gmx.net ([212.227.15.15]:43553)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rH03o-00079B-Cx
 for 67937 <at> debbugs.gnu.org; Sat, 23 Dec 2023 06:20:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703330432; x=1703935232; i=michael.albinus@HIDDEN;
 bh=tnonFpyk1eTM8nJMmMz5BR+yi2/DXzo6i7vFg07iZjs=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=SL0E4VNNU+VaYWb1cSHaQw6GdUzZvvxK12MY0NXNF3GEAVacf7EemfclRi09BLHz
 TgK2wq/Us8WzejqpbyTKUCUvBcdFf5EM+bkChxWilMHgwTVq9r+uTzgxLU8007rYJ
 Kp20p876c1hALoDUoz84i5G2yvCyTxiH1dCLPrqh25a3ryqXiIpPAjMVX/ctD3yXt
 wXMKF3OP/VvcHECcyLUyCuYVdZ9qqP38BkhLmmcMPfhxZXoIPAA5Myia4V68vOx4w
 +6Iu7GKQRqEyy9LzWXZyxUX8VDjFh2/g2rrn+0OCzeSXQlBF425WWAAlAfIRH27P5
 DQbONou4WQ9aJO38rw==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MbAh0-1qjsAC0OTY-00beFZ; Sat, 23
 Dec 2023 12:20:32 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <875y0qrmhj.fsf@HIDDEN> (J. P.'s message of "Fri, 22 Dec
 2023 12:49:44 -0800")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN> <875y0qrmhj.fsf@HIDDEN>
Date: Sat, 23 Dec 2023 12:20:31 +0100
Message-ID: <871qbdmagw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:fW+efXxAzsV5JZ7Kn9V05hKWwaE1Nha7Wb7cU1s8XH/nOSO1Beo
 +z1SF4zJ9WBMjnmsYPC9+Mt167tMynhu+2wwmvdR2EhZjSQ+f+sIqtLGDtTgYivzzYKtd6y
 amEWIGJUdxANvxr1/Ee2FlFTWpAXtlwgH4uiNYBcghAGrSrchi4g1b5fVtGgY5j5GXPwBSi
 +iWOa6/ROf1wxm6oW3S0g==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:3z/QelPxdOk=;LysHv4zd7LV5vFlC9MNniv9LcMn
 pVWvuYgb5G4JIgtqeBzFPonz7F+EMSbdSOdY2Mv7TtbWbWBk51LexI9VH1Papk7DqxkNa4AQi
 znAIP00cDqB/4csbSeKdr7eGpqyOyNpo9VhwVWNMgoV9x+ghow4T9XkNjbZ8ihAN5lx6APurm
 hH4qdwKMuYV+nyymEDBBiP10YTIeV22azQTJnbfUotq2oIc2j6PxCAsqPqbx0OI5qw7OxO5RG
 cTrue9RFb6lidksY97b+sklyW9NGiDW/4bwsYK5AuuR1YivPO4vaVZyKpmBVvPhO11yJ0ijeo
 9jx8YkgkTY9Df+DpHZ9+ih9PtieSEFsR6vV6/+4PIvV1VdWXV1AUx9WoX8bFhqlCfX8meQ4PJ
 4+WNYuCDfjz6zsX/YSCWgceTQI9lhERV/BwwzmyyFO8AWPtRbJ3G/vK8P8iVQW9JQwFZ/i+9n
 S/HYZTXNc77CzEyhqX/lFiaJp576I6bPa0CiMrQ6sZ19u2XZ3Zq6T2Ox/asdM75UKslZG55q2
 DZuYDOtfRCRh0rHhCB0p5bh68EWU4HCpCvI33Lhosa2WMfsLRpc5ATjADtiHVAihD1Yb6QdPi
 UZXzhayPtoTEGsn40ZBsjfMOApejFJ84fgPbQKIazOp3TkWTiJ8+iyv/2IHrsGb8m9wQSGP7q
 ggdW6BzmqX1ejs5VopY/geYw87M9CkqDZUrWnq4gTBayuClOjO9PiYQEzChbuhGCrvvQ3Is73
 lM6sq3gh5jh9cwnPeaY3BdwMea+qK+4ybzLg0D2YLz3ash0565W28XudRE4KG07wX9/GcfhWW
 bjC+/V2TFFrXqaO8mILx5PsNMhh63ETiCn7S4m8t3riKxgYObqhv2VWCPpZc/S22zMJhm6I42
 nHN47y+hT1MFWbfkl6bvNUdQ2AZPsjWMDO/XqM7F8yuBw5o3gh9jODcSuRfvvszng/suva/+S
 G8p3Gw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

"J.P." <jp@HIDDEN> writes:

> Hi Michael,

Hi,

> The issue in this bug is that a default member of
> `file-name-handler-alist', namely,
>
>   ("\\.gpg\\(~\\|..." . epa-file-handler)
>
> which is actually the value of the variable `epa-file-handler' added by
> the file epa-hook, disappears mysteriously due to "reasons" TBD.

This happens due to the call of `epa-file-disable' mentioned in the
initial recipe.

> J.P.

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 22 Dec 2023 20:49:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 22 15:49:59 2023
Received: from localhost ([127.0.0.1]:47937 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGmT0-0000J5-RL
	for submit <at> debbugs.gnu.org; Fri, 22 Dec 2023 15:49:59 -0500
Received: from mail-108-mta135.mxroute.com ([136.175.108.135]:45595)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rGmSw-0000Iv-GR
 for 67937 <at> debbugs.gnu.org; Fri, 22 Dec 2023 15:49:57 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta135.mxroute.com (ZoneMTA) with ESMTPSA id
 18c934a98ee0003727.003 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Fri, 22 Dec 2023 20:49:48 +0000
X-Zone-Loop: fbbc99904a2a3d0bf5dfc48ffa2e82c9b2dca9a81815
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=O+cs24a0JnMXAKdfKJ4OuU5woy2hNXjMdjH708Dejc4=; b=LJLo7tWiW8Z3sZkdf//G2uRavE
 h28e5SfMsfSh9LNLTw8irgBu4Wt4kWt06yvqWxF0zzbuvcTFnM9hacRvWIEvqwYE6Zkv1r08/Ihm0
 az6WMiqc6GCt/wfbD3tz1eULdXnzM1D2nSGItV+VHpE9OegiE7EwmpMA1eM7dQvoq8+HIa163FOEP
 NQ5aariH2ZP5BH8k34+k38e8IISuWt2bvMRySKrcsIrMjf+GMrpq/3ul4QHiHaqQ7NzGV4eucl9LP
 P3sSxWnjLjSzT+Ms4oxBU0NDxHaKpJzbynSWr4iZGgcqin1XJyAcP1z1FDCO90SQyMHQbx5HPt1vh
 KcUtKvuA==;
From: "J.P." <jp@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <878r5mm3el.fsf@HIDDEN> (Michael Albinus's message of "Fri, 22
 Dec 2023 20:40:50 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
 <878r5mm3el.fsf@HIDDEN>
Date: Fri, 22 Dec 2023 12:49:44 -0800
Message-ID: <875y0qrmhj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Michael,

Michael Albinus <michael.albinus@HIDDEN> writes:

> "J.P." <jp@HIDDEN> writes:
>
>> If those Tramp addresses don't continue to work after your suggested
>> changes, we should probably ask Michael Albinus whether their working
>> currently is just an accident or something intentional and supported.
>
> I don't remember any special effort making auth-source-pass Tramp-affin,
> but I might misremember. However, I wouldn't call it "accident", but
> "Emacs design". If accessing auth-source-pass-filename uses the well
> known primitive functions (insert-file-contents, expand-file-name
> alike), there shouldn't be a problem of keeping this compatibility with
> Tramp.

Ah, right. So deliberate by proxy (or virtue) of Emacs design, then. The
issue in this bug is that a default member of `file-name-handler-alist',
namely,

  ("\\.gpg\\(~\\|..." . epa-file-handler)

which is actually the value of the variable `epa-file-handler' added by
the file epa-hook, disappears mysteriously due to "reasons" TBD. This
breaks `auth-source-pass' because it relies on `insert-file-contents',
which calls `find-file-name-handler', to decrypt passwords. Arsen
believes this dependency a sign of unnecessary brittleness and therefore
a bug. His proposed solution is to use `insert-file-contents-literally',
which epa-hook doesn't subscribe to, as it only does

  (put 'epa-file-handler 'operations '(write-region insert-file-contents))

while `i-f-c-literally' does

  (let ((inhibit-file-name-operation 'insert-file-contents)) ...)

My initial concern was other (non-Tramp) file handlers possibly missing
out by our routing around `insert-file-contents', but without a concrete
example, perhaps that's unwarranted FUD. Anyway, thanks for weighing in.

J.P.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 22 Dec 2023 19:41:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 22 14:41:15 2023
Received: from localhost ([127.0.0.1]:47915 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGlOV-0002K0-DN
	for submit <at> debbugs.gnu.org; Fri, 22 Dec 2023 14:41:15 -0500
Received: from mout.gmx.net ([212.227.17.20]:56895)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rGlOT-0002Jk-58
 for 67937 <at> debbugs.gnu.org; Fri, 22 Dec 2023 14:41:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1703274051; x=1703878851; i=michael.albinus@HIDDEN;
 bh=Ni0ml0/04IPHo62I4muqdTtUZiSNSdDdLBr8H06PxhE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=kun20GoP5s3/F9AOCK0RZidObXRcaCf8lKJ18VDYmakFij6exmtHDuKX0X4oGN0W
 Tk294lGGbqXwmax/t6UAI5CKPktAPENj2mr67KU9JjBBFGpRybyi31wXFbuE4NsQ4
 hwYD1hrC2MwInJ2F5sQhPkI3I0S21jiTSwRF2reOorGGC0QbGtoQvbAp9MpurzPR3
 eCUmtxaxJ06w3LLxZVEiNlMLpkky5NiyxdsJNpzPreuJlkwKz/HrclRpuwy8rpNaU
 ytnhNUGh/+mI3Q2iPnP5IqrObL/l+azuZ2hna7190g/Ku0nIt23P4lsulyCi00Pnr
 wGb0FxEGmRvcBoIgKA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNbox-1rfC002gBP-00P7KA; Fri, 22
 Dec 2023 20:40:51 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <87ttoas466.fsf@HIDDEN> (J. P.'s message of "Fri, 22 Dec
 2023 06:27:45 -0800")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
Date: Fri, 22 Dec 2023 20:40:50 +0100
Message-ID: <878r5mm3el.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:IanPluOUS8way4V5iv5FjKadyo4j5Fw7M1XRmgiHlQOTh6d4eWB
 PhKuW4NjFtqGh8c6QNoMVP+q7aFzzZexEK3MYMhfVhUk2LwneMJBqw8EwIdpfZaAf8XvGjw
 xcpLnsMmohxG/39z2s4fbH3/Z0tDPx+1TdT+ft7UgzeFFqvZ/mIJ/QxtbuxFq4Wtrfn2NCm
 nt1jLzrGNEn+Am0obE0PQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:5G3S0BJfQ7M=;iopA0/4Cob29WA/lseeivzFZewS
 k9qq8krKepTcm1IExRoudJqLVVxBluR4WyATJNwpWhJ43k+iR+rDSWaLJeCvSSeLhhSDTja78
 7d68hDfXqWt6uzO42i5zsTEFXqnDAzGxW0GNfgdbcFE37pfcGjzw9PiOaWZmnqKDB1yaZSVDj
 a0+IA5PIcT49v6D+2M9FwnuManWyy9rphKKJLpI+/+H4WhLza3fE03W3b7OcNVc/yA2KS6BVS
 Ne0dMbKSciH9/FoC18N6JGbfMxcyJepa7woMabZl/2c/faFovmekU6EYLgpUpU/HT2vX5O1Fc
 npt6DGgiY8W1Ql0tFrrlUm5ClnNxA4ZW6pNklLfSGM1vwsSj//vLK2HV3PgJsd4+yednMhrFI
 X4gQDUU4fUNm6yPrl0WFlCXa5H+lQgXxRCG6vgwTjoBOGUKqEFOyP4Qu1dwJv1Rjdz2nnZ8I9
 wfJXV2V5sC2Of3jY2WVaIp3PduN1OtfoKYtmCxabaUMbEL1oI+PSSVbHcSsbfEVHRR1Vu2+uT
 ASrPDqEOnJgCpPtkwfPD0kueq2+rkM8EiWrbNebxh4PLVKPzGeEH/iO4Ep8+/IUBsn1z03LEv
 KVdG67eHb1SXpRHn2QCoFGAcj7K/+AnR5mvDfEw0Zb5X9wAbIBc0UU7VQayQdzbOQu6H4Eklj
 9zmoILKgtGrZ2WGb8LNjhyb/HxjkYGer7vRh9t+6WmMBG8LO9JmU3E++ezC4EZNtEdIjGgd3L
 MrvMI+YbcxFqxCaSCn9Rr3N+cgyywjiIl9r8GUkHamj8EiF4/XJtun0rcNkWyVK3lQUru8AXu
 SZ9ls1Exp4gRiNRhj8KyYWfWR1jrJalVA128IE26rPtyuqybN2OtRskCIo4vT0JGnVpgq2sUp
 kiE3SoCDKaMnS8DayD+OmXpd4ynnJDnH0W6I6M2tMbB+2D44vZ9FYjW48bmHnQv/vEO0VdV5f
 aR8+qQ==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org, Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

"J.P." <jp@HIDDEN> writes:

> Hi Arsen,

Hi,

> Don't kill me, but I have another rather unlikely scenario perhaps
> worthy of passing consideration (or dismissal):
>
>   (setopt auth-source-pass-filename "/ssh:desktop.local:.password-store")
>
> If those Tramp addresses don't continue to work after your suggested
> changes, we should probably ask Michael Albinus whether their working
> currently is just an accident or something intentional and supported.

I don't remember any special effort making auth-source-pass Tramp-affin,
but I might misremember. However, I wouldn't call it "accident", but
"Emacs design". If accessing auth-source-pass-filename uses the well
known primitive functions (insert-file-contents, expand-file-name
alike), there shouldn't be a problem of keeping this compatibility with
Tramp.

> J.P.

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 22 Dec 2023 15:04:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 22 10:04:38 2023
Received: from localhost ([127.0.0.1]:47597 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGh4n-0006vk-EX
	for submit <at> debbugs.gnu.org; Fri, 22 Dec 2023 10:04:38 -0500
Received: from mout-p-101.mailbox.org ([80.241.56.151]:47128)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rGh4k-0006vT-5V
 for 67937 <at> debbugs.gnu.org; Fri, 22 Dec 2023 10:04:36 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4SxVv90d7Kz9sRX;
 Fri, 22 Dec 2023 16:04:21 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703257461;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=VOOOusRGCAigfMEXTzbmzJRk0wb0+B/qeo1R+/WZfyc=;
 b=FgmHNheVmyENBbKdcd9WFe7Og7EVb+nLs8NF2vpBhk7AyW3R+QKkYBNsEpWE9pxGiLTeiy
 7WmLFPUPGmJIR8tSmt6HWXcsIgP854SB/M7GiUbsNXZ2pFVXI3rYayxXPs38/3X/USPDdR
 a87F1lB5VHKMCifatXPXYIBB5OrGDzREJ5rAlkgcLWLyqOgpMCKxlOY2xLsfsUGAOvmqei
 XCwNeCi3DFk+E9IMks3MI4dg5STdh2HTOOsJPsdEyO6/QrKgGKNmLaB9OTweImD/ey5rAr
 8/QpOtFk9h8x0fQHSKnPrvxsgwqX2tJxO671xVNaTPNWoKJjVXtwRW1g+UjzRw==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN> <87ttoas466.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Fri, 22 Dec 2023 15:53:02 +0100
In-reply-to: <87ttoas466.fsf@HIDDEN>
Message-ID: <875y0qgtxq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4SxVv90d7Kz9sRX
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi J.P,

"J.P." <jp@HIDDEN> writes:

> Hi Arsen,
>
> Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:
>
>> "J.P." <jp@HIDDEN> writes:
>> [...snip...]
>>>
>>> I think what `epa-hook' does beyond `epg' is offer the option of
>>> opting out of the latter by way of the `file-name-handler-alist'
>>> interface. If that's unwise or unnecessary for some reason, we should
>>> probably explain why, if only for posterity.
>>
>> I believe it is, because a pass entry is precisely a single OpenPGP
>> encrypted file.  All other pass-compatible tools and implementations
>> already rely on that.  If we want to allow the user to change that, we
>> should do so by relying on the pass CLI tool, because that way other
>> parts of their pass workflow allow for change.
>>
>> But, I don't think even that is needed, at least for now.
>
> I see. If there's essentially only one way to go about accessing and
> decrypting files in these pass trees, then perhaps this is more of a bug
> fix than a feature?

Yes, I consider this a bug and the patch a bug fix :-)

>>> And in doing so, we should maybe also account for behavior like that
>>> of `epa-file-insert-file-contents', which lies in the default
>>> `f-n-h-a' code path and appears to go out of its way to provide a
>>> different user experience when it comes to error handling.  If such
>>> accommodations are unnecessary, perhaps we ought to be somewhat
>>> explicit as to why.
>>
>> Indeed, stuff like this was what I was referring to.  Thanks for naming
>> the function that implements this, I went ahead and read it.
>>
>> I believe the entire file-exists-p check is unnecessary, as the file
>> being read is "guaranteed" to exist, bar race conditions (which ought to
>> be fixed via a slightly larger refactor, by having a-s-p functions
>> accept either a buffer or an open file or something, then having its
>> user open a file literally).
>
> Hm, I guess `expand-file-name' doesn't actually check to see if the file
> name it returns exists, so I think the subprocess will ultimately be fed
>
>   ... --decrypt -- non-existent-file.gpg
>
> as trailing args. But I suppose that's not a concern so long as the user
> can readily deduce that some kind of easily fixable pilot error has
> occurred.

Yes, but I think that the users of this function enumerate pass entries
before calling it, and so "never" call it with a nonexistent file
(though, that's perhaps not the case for non-a-s-p users.. unsure if
this API is public and considered stable, but I suppose it is at least
public since it's documented and lacks '--'?)

>> That leaves us with just:
>>
>>          (if (setq entry (assoc file epa-file-passphrase-alist))
>>     	 (setcdr entry nil))
>>          ;; If the decryption program can't be found,
>>          ;; signal that as a non-file error
>>          ;; so that find-file-noselect-1 won't handle it.
>>          ;; Borrowed from jka-compr.el.
>>          (if (and (memq 'file-error (get (car error) 'error-conditions))
>>     	      (equal (cadr error) "Searching for program"))
>>     	 (error "Decryption program `%s' not found"
>>     		(nth 3 error)))
>>
>> I believe the passphrase handling is also unnecessary, or at least not
>> very likely to matter, as 'pass' files aren't intended to be
>> symmetrically encrypted.
>
> Makes sense. And I guess pass doesn't sign these files either, so
> there's no risk of a "wrong password" failure from the agent or pinentry
> ending up in that condition-case handler.

It does not, no.

>> That leaves us with handling the lack of a decryption program.  Perhaps
>> we should extract this into some common code (I'm surprised other users
>> of EPG don't need it).  Perhaps the status quo is good enough as it is?
>> I have not tested that yet (need to run - sorry).
>
> Again, I'd say as long as there's some way for these rare pilot errors
> to reach the user, that's probably enough.

They should propagate normally, AFAIK.

>> Overall, I don't think involving the f-n-h-a mechanism is desirable to
>> get one error path that could be obtained via refactoring when it ends
>> up also dragging in all the possible complexity of f-n-h-a where it is
>> not desirable (as pass entries are strictly defined).
>
> Simplicity is a worthy goal, I think we can all agree.
>
>>>> I'm not sure what you mean by 'hard-coding' here.  These files are
>>>> always gpg files (that's how pass works), and they are always OpenPGP
>>>> encrypted.  The usage of epg-decrypt-file is proposed by the help of
>>>> epa-decrypt-region IIRC.
>>>
>>> I meant "hard-coding" in the sense that the original design seems to
>>> allow external code to potentially influence the decryption process,
>>> as mentioned above.
>>
>> I believe this is accidental.  auth-source-pass authors would have to
>> weigh in, though.
>>
>>> But from what you're saying, it sounds like there's no legitimate use
>>> case for doing so. I wasn't privy to the original design discussions,
>>> but it would be nice to know if there was a good reason for going this
>>> route beyond adhering to the age-old best practice of relying on
>>> interfaces rather than implementations.
>>
>> AFAIK, epg-decrypt-file is a public interface.  epa-decrypt-region (not
>> epa-decrypt-file, sorry, I misrecalled in my earlier message) even
>> suggests using it:
>>
>>   Be careful about using this command in Lisp programs!
> [...]
>
> Sorry, by "relying on interfaces", I basically meant adhering to the
> "dependency inversion principle," at least insofar as `epa-hook' and
> `a-s-p' both rely on `f-n-h-a'. But if there's only one way to skin this
> particular cat, then perhaps that's all just unwanted complexity, as you
> say.

Right, that was my perspective.

>>> Perhaps it's worth rifling through the archives for mention of the
>>> authors' original motivations WRT `f-n-h-a', just for good measure?
>>
>> Probably, but my intuition tells me it was accidental.  I'll try to find
>> relevant messages (thankfully, there wasn't too much discussion on this
>> topic, so that shouldn't be too hard to search :-) ).
>>
>>>>> 2. How likely is it that someone actually depends on the perceived
>>>>>    undesirable behavior currently on HEAD? Like, for example, could
>>>>>    someone out there conceivably have a cron-like script that runs
>>>>>    `epa-file-disable' before copying the encrypted secrets from the
>>>>>    result of an `auth-source-search' to Nextcloud or something? If th=
ese
>>>>>    weren't passwords, perhaps we could just shrug off such
>>>>>    hypotheticals, but... (just saying).
>>
>> I missed the latter part of this before, apologies.
>>
>> If such a user exists, and they use any auth-sources value besides
>> '(password-source), their setup will already break, as this hack only
>> works for password-source.  In addition, due to auth-source caching,
>> they'd need to flush the cache twice per such a backup (once to throw
>> out the unencrypted password, and once to recover it).  There are
>> certainly more elegant solutions to getting the contents of those
>> encrypted files.
>
> I guess I was originally envisioning a headless --batch style situation
> rather than an in-session background task, but regardless, what you say
> about the cache makes sense in that more hurdles means more hassle,
> which makes such a scenario all the more unlikely.

Ah, right.  That could make more sense in a batch task, but I still
doubt it for the same reason as before.

>>>>
>>>> I do not know, but this dependency is wrong either way, and can confuse
>>>> users and the auth-source cache.
>>>
>>> So, it seems like we're saying that protecting an unlikely minority here
>>> should not stand in the way of simplicity and consistency. I can't argue
>>> against that, but I think it's important to be clear about the potential
>>> consequences of such a sacrifice.
>>
>> Sure.
>
> Don't kill me, but I have another rather unlikely scenario perhaps
> worthy of passing consideration (or dismissal):
>
>   (setopt auth-source-pass-filename "/ssh:desktop.local:.password-store")
>
> If those Tramp addresses don't continue to work after your suggested
> changes, we should probably ask Michael Albinus whether their working
> currently is just an accident or something intentional and supported.

This is a worthy consideration.  It is something a user could reasonably
think to do.  Suppose:

  (let ((ctx (epg-make-context 'OpenPGP)))
    (epg-decrypt-file ctx "/ssh:..." nil))

... as you suspected, this does not work as gpg gets given the TRAMP
locator.

If the a-s-p authors think this is worthy of supporting, I will write an
alternative patch that supports this via insert-file-literally (somewhat
akin to the current code, but still explicit in decryption).  I
confirmed that insert-file-literally still supports TRAMP, so this is a
viable path forward (but I can only do that in ~hour or so - need to do
something now).

>>>> The only reason I noticed this is because *something* (and I have no
>>>> idea what as of yet) somehow unhooks epa-file.  When I noticed that, I
>>>> figured I could use epa-file-disable to provide a simpler reproducer. =
 I
>>>> didn't actually notice the bug by using epa-file-disable (and I have
>>>> never intentionally ran epa-file-disable).
>>>>
>>>> I'll be tracking that down next, but fixing this first seemed easier.
>>>
>>> Tracking that down would be nice, definitely.
>>
>> I will try to debug-on-variable-change f-h-n-a, but to do that I'll need
>> to figure out a more effective approach than hitting 'c' repeatedly in
>> the debugger (can debugs be conditional?), as that's getting tiring and
>> imprecise.
>
> Yeah, that sounds like a pain. If you haven't tried already, perhaps
> hand rolling your own `add-variable-watcher' is worth a shot?

I figured to try that, but have been absent all day so I have not yet.
I will do that ASAP, though.

Thanks, have a lovely day.
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYWlcRAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTBDUA/04WvlZJbY0nG2GOY5/VK5ezfKFdYTJTLTCR
SEH9zq42AP9pM1c/LTVJeGCnFsedCtXFYKsUb5Xn2zwPVIAUwBUdAw==
=vBLA
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 22 Dec 2023 14:28:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 22 09:28:02 2023
Received: from localhost ([127.0.0.1]:46257 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGgVN-0005zA-4Y
	for submit <at> debbugs.gnu.org; Fri, 22 Dec 2023 09:28:01 -0500
Received: from mail-108-mta165.mxroute.com ([136.175.108.165]:36849)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rGgVK-0005z0-8I
 for 67937 <at> debbugs.gnu.org; Fri, 22 Dec 2023 09:27:59 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta165.mxroute.com (ZoneMTA) with ESMTPSA id
 18c91ecdeb90003b4e.003 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Fri, 22 Dec 2023 14:27:49 +0000
X-Zone-Loop: 3274dcdca409a6e32ee44c571782ec96477da266e0f0
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=aJCClRJRqlEYTfb8hWWOD0ZCvo1AzFzBaQqhNr5FI6E=; b=JvAD03sxgx3CK9hTOlWPtfz4MD
 CqUWanCMiNBmQbylkfEVu9WrpTjpNhrJnkSHlLR9iOy4enXeq2CMTi5VgFeapnXOHr5wapJrDB7Du
 rSNMZZjrecsdXGQIXaD5jgLG7r3loPpuUH0svUPJv6SBOTiSgRLzIrxeHFsn0o7Mdt4Iht9+FGUCV
 mscavh67XNToOK3+Kx1RETVaP8dVb/pocQcHRLooaqQMBTp+QUWdEGIkfUydSAu5RTj/f3Vzb5gRi
 xItlHn/f6J6h3mviCxZJBhuQapvqKM8DuPaGE/AcLzGnLW+XWczfjds+cAtycx0Tgdb9B9joC8tiE
 q70UfdlQ==;
From: "J.P." <jp@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <87jzp6is0s.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Fri, 22 Dec 2023 08:33:48 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
 <87jzp6is0s.fsf@HIDDEN>
Date: Fri, 22 Dec 2023 06:27:45 -0800
Message-ID: <87ttoas466.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arsen,

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> "J.P." <jp@HIDDEN> writes:
> [...snip...]
>>
>> I think what `epa-hook' does beyond `epg' is offer the option of
>> opting out of the latter by way of the `file-name-handler-alist'
>> interface. If that's unwise or unnecessary for some reason, we should
>> probably explain why, if only for posterity.
>
> I believe it is, because a pass entry is precisely a single OpenPGP
> encrypted file.  All other pass-compatible tools and implementations
> already rely on that.  If we want to allow the user to change that, we
> should do so by relying on the pass CLI tool, because that way other
> parts of their pass workflow allow for change.
>
> But, I don't think even that is needed, at least for now.

I see. If there's essentially only one way to go about accessing and
decrypting files in these pass trees, then perhaps this is more of a bug
fix than a feature?

>> And in doing so, we should maybe also account for behavior like that
>> of `epa-file-insert-file-contents', which lies in the default
>> `f-n-h-a' code path and appears to go out of its way to provide a
>> different user experience when it comes to error handling.  If such
>> accommodations are unnecessary, perhaps we ought to be somewhat
>> explicit as to why.
>
> Indeed, stuff like this was what I was referring to.  Thanks for naming
> the function that implements this, I went ahead and read it.
>
> I believe the entire file-exists-p check is unnecessary, as the file
> being read is "guaranteed" to exist, bar race conditions (which ought to
> be fixed via a slightly larger refactor, by having a-s-p functions
> accept either a buffer or an open file or something, then having its
> user open a file literally).

Hm, I guess `expand-file-name' doesn't actually check to see if the file
name it returns exists, so I think the subprocess will ultimately be fed

  ... --decrypt -- non-existent-file.gpg

as trailing args. But I suppose that's not a concern so long as the user
can readily deduce that some kind of easily fixable pilot error has
occurred.

> That leaves us with just:
>
>          (if (setq entry (assoc file epa-file-passphrase-alist))
>     	 (setcdr entry nil))
>          ;; If the decryption program can't be found,
>          ;; signal that as a non-file error
>          ;; so that find-file-noselect-1 won't handle it.
>          ;; Borrowed from jka-compr.el.
>          (if (and (memq 'file-error (get (car error) 'error-conditions))
>     	      (equal (cadr error) "Searching for program"))
>     	 (error "Decryption program `%s' not found"
>     		(nth 3 error)))
>
> I believe the passphrase handling is also unnecessary, or at least not
> very likely to matter, as 'pass' files aren't intended to be
> symmetrically encrypted.

Makes sense. And I guess pass doesn't sign these files either, so
there's no risk of a "wrong password" failure from the agent or pinentry
ending up in that condition-case handler.

> That leaves us with handling the lack of a decryption program.  Perhaps
> we should extract this into some common code (I'm surprised other users
> of EPG don't need it).  Perhaps the status quo is good enough as it is?
> I have not tested that yet (need to run - sorry).

Again, I'd say as long as there's some way for these rare pilot errors
to reach the user, that's probably enough.

> Overall, I don't think involving the f-n-h-a mechanism is desirable to
> get one error path that could be obtained via refactoring when it ends
> up also dragging in all the possible complexity of f-n-h-a where it is
> not desirable (as pass entries are strictly defined).

Simplicity is a worthy goal, I think we can all agree.

>>> I'm not sure what you mean by 'hard-coding' here.  These files are
>>> always gpg files (that's how pass works), and they are always OpenPGP
>>> encrypted.  The usage of epg-decrypt-file is proposed by the help of
>>> epa-decrypt-region IIRC.
>>
>> I meant "hard-coding" in the sense that the original design seems to
>> allow external code to potentially influence the decryption process,
>> as mentioned above.
>
> I believe this is accidental.  auth-source-pass authors would have to
> weigh in, though.
>
>> But from what you're saying, it sounds like there's no legitimate use
>> case for doing so. I wasn't privy to the original design discussions,
>> but it would be nice to know if there was a good reason for going this
>> route beyond adhering to the age-old best practice of relying on
>> interfaces rather than implementations.
>
> AFAIK, epg-decrypt-file is a public interface.  epa-decrypt-region (not
> epa-decrypt-file, sorry, I misrecalled in my earlier message) even
> suggests using it:
>
>   Be careful about using this command in Lisp programs!
[...]

Sorry, by "relying on interfaces", I basically meant adhering to the
"dependency inversion principle," at least insofar as `epa-hook' and
`a-s-p' both rely on `f-n-h-a'. But if there's only one way to skin this
particular cat, then perhaps that's all just unwanted complexity, as you
say.

>> Perhaps it's worth rifling through the archives for mention of the
>> authors' original motivations WRT `f-n-h-a', just for good measure?
>
> Probably, but my intuition tells me it was accidental.  I'll try to find
> relevant messages (thankfully, there wasn't too much discussion on this
> topic, so that shouldn't be too hard to search :-) ).
>
>>>> 2. How likely is it that someone actually depends on the perceived
>>>>    undesirable behavior currently on HEAD? Like, for example, could
>>>>    someone out there conceivably have a cron-like script that runs
>>>>    `epa-file-disable' before copying the encrypted secrets from the
>>>>    result of an `auth-source-search' to Nextcloud or something? If the=
se
>>>>    weren't passwords, perhaps we could just shrug off such
>>>>    hypotheticals, but... (just saying).
>
> I missed the latter part of this before, apologies.
>
> If such a user exists, and they use any auth-sources value besides
> '(password-source), their setup will already break, as this hack only
> works for password-source.  In addition, due to auth-source caching,
> they'd need to flush the cache twice per such a backup (once to throw
> out the unencrypted password, and once to recover it).  There are
> certainly more elegant solutions to getting the contents of those
> encrypted files.

I guess I was originally envisioning a headless --batch style situation
rather than an in-session background task, but regardless, what you say
about the cache makes sense in that more hurdles means more hassle,
which makes such a scenario all the more unlikely.

>>>
>>> I do not know, but this dependency is wrong either way, and can confuse
>>> users and the auth-source cache.
>>
>> So, it seems like we're saying that protecting an unlikely minority here
>> should not stand in the way of simplicity and consistency. I can't argue
>> against that, but I think it's important to be clear about the potential
>> consequences of such a sacrifice.
>
> Sure.

Don't kill me, but I have another rather unlikely scenario perhaps
worthy of passing consideration (or dismissal):

  (setopt auth-source-pass-filename "/ssh:desktop.local:.password-store")

If those Tramp addresses don't continue to work after your suggested
changes, we should probably ask Michael Albinus whether their working
currently is just an accident or something intentional and supported.

>>> The only reason I noticed this is because *something* (and I have no
>>> idea what as of yet) somehow unhooks epa-file.  When I noticed that, I
>>> figured I could use epa-file-disable to provide a simpler reproducer.  I
>>> didn't actually notice the bug by using epa-file-disable (and I have
>>> never intentionally ran epa-file-disable).
>>>
>>> I'll be tracking that down next, but fixing this first seemed easier.
>>
>> Tracking that down would be nice, definitely.
>
> I will try to debug-on-variable-change f-h-n-a, but to do that I'll need
> to figure out a more effective approach than hitting 'c' repeatedly in
> the debugger (can debugs be conditional?), as that's getting tiring and
> imprecise.

Yeah, that sounds like a pain. If you haven't tried already, perhaps
hand rolling your own `add-variable-watcher' is worth a shot?

J.P.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 22 Dec 2023 08:03:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 22 03:03:06 2023
Received: from localhost ([127.0.0.1]:46023 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGaUr-0006eP-TK
	for submit <at> debbugs.gnu.org; Fri, 22 Dec 2023 03:03:06 -0500
Received: from mout-p-201.mailbox.org ([80.241.56.171]:40150)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rGaUp-0006dt-Qr
 for 67937 <at> debbugs.gnu.org; Fri, 22 Dec 2023 03:03:05 -0500
Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SxKXq56kDz9t4F;
 Fri, 22 Dec 2023 09:02:51 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703232171;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=e845N0lhOnsWvOdqSZPMdtgUkb2HB+rX5v/EAp5E5uI=;
 b=PLSFSc3WlcgwGBu2+ZfUoF8UpMET0zIKXabs8qTS5oIPQ+RNTppZX+L7ic1bpAJtOZo4hJ
 eNYdZ/HoENcJvcM/ZbFilqul6UC8MccnG/Svo63Li4/auvfT0mPv+LDrzUcBnMlrkfNAKF
 5mD/v/iHZVgU1IUzIYejNqW/g4O+pZ6ZKj85K7hI/YRi5QaZ7pz8Ge2JpUOZGw3XohfIke
 5Z2IQzve063XiA6v9cO2wssIJDG3Irk4RH9QyJEnWolUd2nK/19yNJxcQcI0VMECR2Pk14
 x/VXiw6I5cAAKKKr3soskvaDIUmVSLYaxm+jcJDAYexHPnE+WAhuRzXwxVzuAQ==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN> <87h6kbxgzl.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Fri, 22 Dec 2023 08:33:48 +0100
In-reply-to: <87h6kbxgzl.fsf@HIDDEN>
Message-ID: <87jzp6is0s.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi J.P,

"J.P." <jp@HIDDEN> writes:
[...snip...]
>> I don't think ensuring the epa-hook is added here is preferable when a
>> solution that doesn't rely on hooks (one using epg, like in the patch I
>> posted) is quite short.  Unless EPA does more than EPG for this (but it
>> does not seem to, to my novice eyes).
>
> I think what `epa-hook' does beyond `epg' is offer the option of
> opting out of the latter by way of the `file-name-handler-alist'
> interface. If that's unwise or unnecessary for some reason, we should
> probably explain why, if only for posterity.

I believe it is, because a pass entry is precisely a single OpenPGP
encrypted file.  All other pass-compatible tools and implementations
already rely on that.  If we want to allow the user to change that, we
should do so by relying on the pass CLI tool, because that way other
parts of their pass workflow allow for change.

But, I don't think even that is needed, at least for now.

> And in doing so, we should maybe also account for behavior like that
> of `epa-file-insert-file-contents', which lies in the default
> `f-n-h-a' code path and appears to go out of its way to provide a
> different user experience when it comes to error handling.  If such
> accommodations are unnecessary, perhaps we ought to be somewhat
> explicit as to why.

Indeed, stuff like this was what I was referring to.  Thanks for naming
the function that implements this, I went ahead and read it.

I believe the entire file-exists-p check is unnecessary, as the file
being read is "guaranteed" to exist, bar race conditions (which ought to
be fixed via a slightly larger refactor, by having a-s-p functions
accept either a buffer or an open file or something, then having its
user open a file literally).

That leaves us with just:

=2D-8<---------------cut here---------------start------------->8---
         (if (setq entry (assoc file epa-file-passphrase-alist))
    	 (setcdr entry nil))
         ;; If the decryption program can't be found,
         ;; signal that as a non-file error
         ;; so that find-file-noselect-1 won't handle it.
         ;; Borrowed from jka-compr.el.
         (if (and (memq 'file-error (get (car error) 'error-conditions))
    	      (equal (cadr error) "Searching for program"))
    	 (error "Decryption program `%s' not found"
    		(nth 3 error)))
=2D-8<---------------cut here---------------end--------------->8---

I believe the passphrase handling is also unnecessary, or at least not
very likely to matter, as 'pass' files aren't intended to be
symmetrically encrypted.

That leaves us with handling the lack of a decryption program.  Perhaps
we should extract this into some common code (I'm surprised other users
of EPG don't need it).  Perhaps the status quo is good enough as it is?
I have not tested that yet (need to run - sorry).

Overall, I don't think involving the f-n-h-a mechanism is desirable to
get one error path that could be obtained via refactoring when it ends
up also dragging in all the possible complexity of f-n-h-a where it is
not desirable (as pass entries are strictly defined).

>> I'm not sure what you mean by 'hard-coding' here.  These files are
>> always gpg files (that's how pass works), and they are always OpenPGP
>> encrypted.  The usage of epg-decrypt-file is proposed by the help of
>> epa-decrypt-region IIRC.
>
> I meant "hard-coding" in the sense that the original design seems to
> allow external code to potentially influence the decryption process,
> as mentioned above.

I believe this is accidental.  auth-source-pass authors would have to
weigh in, though.

> But from what you're saying, it sounds like there's no legitimate use
> case for doing so. I wasn't privy to the original design discussions,
> but it would be nice to know if there was a good reason for going this
> route beyond adhering to the age-old best practice of relying on
> interfaces rather than implementations.

AFAIK, epg-decrypt-file is a public interface.  epa-decrypt-region (not
epa-decrypt-file, sorry, I misrecalled in my earlier message) even
suggests using it:

  Be careful about using this command in Lisp programs!
  Since this function operates on regions, it does some tricks such
  as coding-system detection and unibyte/multibyte conversion.  If
  you are sure how the data in the region should be treated, you
  should consider using the string based counterpart
  =E2=80=98epg-decrypt-string=E2=80=99, or the file based counterpart
  =E2=80=98epg-decrypt-file=E2=80=99 instead.


> Perhaps it's worth rifling through the archives for mention of the
> authors' original motivations WRT `f-n-h-a', just for good measure?

Probably, but my intuition tells me it was accidental.  I'll try to find
relevant messages (thankfully, there wasn't too much discussion on this
topic, so that shouldn't be too hard to search :-) ).

>>> 2. How likely is it that someone actually depends on the perceived
>>>    undesirable behavior currently on HEAD? Like, for example, could
>>>    someone out there conceivably have a cron-like script that runs
>>>    `epa-file-disable' before copying the encrypted secrets from the
>>>    result of an `auth-source-search' to Nextcloud or something? If these
>>>    weren't passwords, perhaps we could just shrug off such
>>>    hypotheticals, but... (just saying).

I missed the latter part of this before, apologies.

If such a user exists, and they use any auth-sources value besides
'(password-source), their setup will already break, as this hack only
works for password-source.  In addition, due to auth-source caching,
they'd need to flush the cache twice per such a backup (once to throw
out the unencrypted password, and once to recover it).  There are
certainly more elegant solutions to getting the contents of those
encrypted files.

>>
>> I do not know, but this dependency is wrong either way, and can confuse
>> users and the auth-source cache.
>
> So, it seems like we're saying that protecting an unlikely minority here
> should not stand in the way of simplicity and consistency. I can't argue
> against that, but I think it's important to be clear about the potential
> consequences of such a sacrifice.

Sure.

>> The only reason I noticed this is because *something* (and I have no
>> idea what as of yet) somehow unhooks epa-file.  When I noticed that, I
>> figured I could use epa-file-disable to provide a simpler reproducer.  I
>> didn't actually notice the bug by using epa-file-disable (and I have
>> never intentionally ran epa-file-disable).
>>
>> I'll be tracking that down next, but fixing this first seemed easier.
>
> Tracking that down would be nice, definitely.

I will try to debug-on-variable-change f-h-n-a, but to do that I'll need
to figure out a more effective approach than hitting 'c' repeatedly in
the debugger (can debugs be conditional?), as that's getting tiring and
imprecise.

Thanks, have a lovely day!
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYVCoxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTA6UA+gIVHl+/TqNZMhJDUox72rqenMnFBoho/SVL
sk0QPg1aAQCDRwdIDUeyNHYP7o10Sk4kQrUcewc8+krAo06a6RjwDQ==
=fyiS
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 21 Dec 2023 23:39:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 21 18:39:57 2023
Received: from localhost ([127.0.0.1]:45701 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGSdx-0005ql-93
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 18:39:57 -0500
Received: from mail-108-mta231.mxroute.com ([136.175.108.231]:43811)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rGSdu-0005qc-Ho
 for 67937 <at> debbugs.gnu.org; Thu, 21 Dec 2023 18:39:55 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta231.mxroute.com (ZoneMTA) with ESMTPSA id
 18c8ebfd8b600065b4.003 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Thu, 21 Dec 2023 23:39:46 +0000
X-Zone-Loop: a802b260c24dfaf17675d1fa2d47b8de76ac740b0a54
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=ujNbiHB3ICxkxwGjJin9M2QAheuGXiKP17c8QNPAGIk=; b=Emqp3wOKf7fIyup9WnnY4azyy5
 AkwLLFQcK0mATsKE0h8lMWKZ2ahdBpcCWSgeQr10OfpJAvTmwrLRUm6LH50z3+Hs+guJ8bAqIwRIn
 d27OhATYQWsBaSl6aZVNy9XBYdP2sw98OVjbfghIBSzeyXmhL1svR+gtYCXn/s7o3NZLyWCTPpvth
 lnMZEYTCXomoaC84EclD7SjgbsLk9+jvEbH2+7V3sUogyKd99a4NtP1WE3xv6WxZJgWb0IERj1GWI
 sdKhmWMapGfhZjA5s9iZdl/GI5NVIIvehcOiIMtbz6+3K9Gk0nHj2uXh71I4GGz5+v3fh5PkJXiWe
 y4A7Vfkg==;
From: "J.P." <jp@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <871qbflg53.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Thu, 21 Dec 2023 16:29:25 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
 <871qbflg53.fsf@HIDDEN>
Date: Thu, 21 Dec 2023 15:39:42 -0800
Message-ID: <87h6kbxgzl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arsen,

Arsen Arsenovi=C4=87 <arsen@HIDDEN> writes:

> "J.P." <jp@HIDDEN> writes:
>
>> 1. Would it be possible to leverage the existing interface from
>>    `epa-hook' for decrypting these files? As a dirty example:
>>
>>    (defun my-ensure-epa-file-name-handler (orig &rest args)
>>      (require 'epa-hook)
>>      (defvar epa-file-handler)
>>      (let ((file-name-handler-alist
>>             (cons epa-file-handler file-name-handler-alist)))
>>        (apply orig args)))
>>
>>    (advice-add 'auth-source-pass--read-entry
>>                :around #'my-ensure-epa-file-name-handler)
>>
>>    And if doing something like that (without the advice, obviously),
>>    could we somehow "weaken" the regexp of our fallback member's key so
>>    that `find-file-name-handlers' favors an existing, user-defined
>>    override? Alternatively, would it be too wasteful to first attempt to
>>    match the target file name against the option's current members
>>    before falling back on binding a modified value (or using your
>>    proposed hard-coded solution)? Or, wasteful or not, what about
>>    instead offering a new auth-source-pass option whose value is an
>>    alist of the same type as `file-name-handler-alist' that we use in
>>    place of or concatenate with the existing value at runtime?
>
> I don't think ensuring the epa-hook is added here is preferable when a
> solution that doesn't rely on hooks (one using epg, like in the patch I
> posted) is quite short.  Unless EPA does more than EPG for this (but it
> does not seem to, to my novice eyes).

I think what `epa-hook' does beyond `epg' is offer the option of opting
out of the latter by way of the `file-name-handler-alist' interface. If
that's unwise or unnecessary for some reason, we should probably explain
why, if only for posterity. And in doing so, we should maybe also
account for behavior like that of `epa-file-insert-file-contents', which
lies in the default `f-n-h-a' code path and appears to go out of its way
to provide a different user experience when it comes to error handling.
If such accommodations are unnecessary, perhaps we ought to be somewhat
explicit as to why.

> I'm not sure what you mean by 'hard-coding' here.  These files are
> always gpg files (that's how pass works), and they are always OpenPGP
> encrypted.  The usage of epg-decrypt-file is proposed by the help of
> epa-decrypt-region IIRC.

I meant "hard-coding" in the sense that the original design seems to
allow external code to potentially influence the decryption process, as
mentioned above. But from what you're saying, it sounds like there's no
legitimate use case for doing so. I wasn't privy to the original design
discussions, but it would be nice to know if there was a good reason for
going this route beyond adhering to the age-old best practice of relying
on interfaces rather than implementations. Perhaps it's worth rifling
through the archives for mention of the authors' original motivations
WRT `f-n-h-a', just for good measure?

>> 2. How likely is it that someone actually depends on the perceived
>>    undesirable behavior currently on HEAD? Like, for example, could
>>    someone out there conceivably have a cron-like script that runs
>>    `epa-file-disable' before copying the encrypted secrets from the
>>    result of an `auth-source-search' to Nextcloud or something? If these
>>    weren't passwords, perhaps we could just shrug off such
>>    hypotheticals, but... (just saying).
>
> I do not know, but this dependency is wrong either way, and can confuse
> users and the auth-source cache.

So, it seems like we're saying that protecting an unlikely minority here
should not stand in the way of simplicity and consistency. I can't argue
against that, but I think it's important to be clear about the potential
consequences of such a sacrifice.

> The only reason I noticed this is because *something* (and I have no
> idea what as of yet) somehow unhooks epa-file.  When I noticed that, I
> figured I could use epa-file-disable to provide a simpler reproducer.  I
> didn't actually notice the bug by using epa-file-disable (and I have
> never intentionally ran epa-file-disable).
>
> I'll be tracking that down next, but fixing this first seemed easier.

Tracking that down would be nice, definitely.

Thanks,
J.P.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 21 Dec 2023 15:39:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 21 10:39:06 2023
Received: from localhost ([127.0.0.1]:45288 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGL8b-0002rC-OX
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 10:39:06 -0500
Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:60734)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rGL8a-0002qf-A4
 for 67937 <at> debbugs.gnu.org; Thu, 21 Dec 2023 10:39:04 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4SwvjR14GFz9sZY;
 Thu, 21 Dec 2023 16:38:51 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703173131;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=pIlNw+mb1AaDcrt1lca7dAsYhjuduGeDNt0JHLU+SPY=;
 b=rtN6AwXLD7pPUZ1nejJGKSyVG5DoLpe0nUvpl2dcup6kKJ+MMe8wIE1NdGLfRDnygk3xx1
 4lpRj/JKI10UPKv7YeWs9yTc8csjS69DEgRorK4bpSA7arcFSrQCnk/o8S9gfg+jyGCWe7
 3EUAgQ0D/9+cyQwSrza3SBknb2C0+uZf3Yy6fSG+ppBaxUJLI+9AaBNHjy+g2xixr/vG5T
 OSE+3aZVEFoO1vXpOdTMGxtACTRJvPH+ymZF0NSLm24r9rm+Q22u5bCONYqvvjuNSIi1Uj
 a1MFo/sCm4CIJ76tbHVTulFl+2kg+1g3/Vw8/k3RxG8tMrbva9DHw1/N/vbIHw==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN> <871qbf4ocp.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: "J.P." <jp@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Thu, 21 Dec 2023 16:29:25 +0100
In-reply-to: <871qbf4ocp.fsf@HIDDEN>
Message-ID: <871qbflg53.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4SwvjR14GFz9sZY
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi J.P,

"J.P." <jp@HIDDEN> writes:

> Hi Arsen,
>
> I too don't use the password store or auth-source-pass, but a couple
> dumb questions anyway (feel free to ignore):
>
> 1. Would it be possible to leverage the existing interface from
>    `epa-hook' for decrypting these files? As a dirty example:
>
>    (defun my-ensure-epa-file-name-handler (orig &rest args)
>      (require 'epa-hook)
>      (defvar epa-file-handler)
>      (let ((file-name-handler-alist
>             (cons epa-file-handler file-name-handler-alist)))
>        (apply orig args)))
>
>    (advice-add 'auth-source-pass--read-entry
>                :around #'my-ensure-epa-file-name-handler)
>
>    And if doing something like that (without the advice, obviously),
>    could we somehow "weaken" the regexp of our fallback member's key so
>    that `find-file-name-handlers' favors an existing, user-defined
>    override? Alternatively, would it be too wasteful to first attempt to
>    match the target file name against the option's current members
>    before falling back on binding a modified value (or using your
>    proposed hard-coded solution)? Or, wasteful or not, what about
>    instead offering a new auth-source-pass option whose value is an
>    alist of the same type as `file-name-handler-alist' that we use in
>    place of or concatenate with the existing value at runtime?

I don't think ensuring the epa-hook is added here is preferable when a
solution that doesn't rely on hooks (one using epg, like in the patch I
posted) is quite short.  Unless EPA does more than EPG for this (but it
does not seem to, to my novice eyes).

I'm not sure what you mean by 'hard-coding' here.  These files are
always gpg files (that's how pass works), and they are always OpenPGP
encrypted.  The usage of epg-decrypt-file is proposed by the help of
epa-decrypt-region IIRC.

> 2. How likely is it that someone actually depends on the perceived
>    undesirable behavior currently on HEAD? Like, for example, could
>    someone out there conceivably have a cron-like script that runs
>    `epa-file-disable' before copying the encrypted secrets from the
>    result of an `auth-source-search' to Nextcloud or something? If these
>    weren't passwords, perhaps we could just shrug off such
>    hypotheticals, but... (just saying).

I do not know, but this dependency is wrong either way, and can confuse
users and the auth-source cache.

The only reason I noticed this is because *something* (and I have no
idea what as of yet) somehow unhooks epa-file.  When I noticed that, I
figured I could use epa-file-disable to provide a simpler reproducer.  I
didn't actually notice the bug by using epa-file-disable (and I have
never intentionally ran epa-file-disable).

I'll be tracking that down next, but fixing this first seemed easier.

> Thanks,
> J.P.

Have a lovely day!
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYRcCBAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosST98UA/jAnIwnDvFjSnLU6POIseW1bBNs5snd1Jy24
STXq9yISAQDaysXIC2M/3O4jfa6/A4Te/NDqeTwtpji+Qk0qemGgCA==
=J1I4
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 21 Dec 2023 14:33:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 21 09:33:40 2023
Received: from localhost ([127.0.0.1]:42717 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGK7H-0006vp-LE
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 09:33:40 -0500
Received: from mail-108-mta38.mxroute.com ([136.175.108.38]:40977)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rGK7E-0006vg-R8
 for 67937 <at> debbugs.gnu.org; Thu, 21 Dec 2023 09:33:37 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta38.mxroute.com (ZoneMTA) with ESMTPSA id 18c8ccbbb1600065b4.003
 for <67937 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Thu, 21 Dec 2023 14:33:31 +0000
X-Zone-Loop: f446f2a0044d0c6f7c7343bcc25a083dc3df89551ab1
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=TQO5uryCmJORgt+e/DQfqCPTQ8SW+9mRsOwN7SVQlUk=; b=TTWyS7gbWGU1diDE6MIZPjU8vE
 p2IJu4N4qJd1DqUiLGzn2HH4O4fXhz3mSyn6UnfBnlNels+cnjBt1Mq1FrlO/DKkIxvOuJV2aQ/zy
 10SeW7vBWOrcY0nPJseTiStDp86CqGKUniAx0IcWyBGffBfSgTgvFSIn82vuGGlvvcpxKUwWps4kO
 2jC7YeA38eqnDlS2fzw7syLxVyLWK4VnMN7UXCItdcZnHiCutiqCjMEAbSZbjSnYDEJ61bErGD1Z8
 8pMUkE+Mxzq0y4MR7+hrNuY2aNm4Vh+hpoeO2vmys5/y90o38wYKfqNsVZ4IvwdxT68GZIDAKsBmm
 I4EgdOOg==;
From: "J.P." <jp@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
In-Reply-To: <87sf3vlqj1.fsf@HIDDEN> ("Arsen =?utf-8?Q?Arsenovi=C4=87?=
 =?utf-8?Q?=22's?= message of "Thu, 21 Dec 2023 11:18:59 +0100")
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
 <87sf3vlqj1.fsf@HIDDEN>
Date: Thu, 21 Dec 2023 06:33:26 -0800
Message-ID: <871qbf4ocp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arsen,

I too don't use the password store or auth-source-pass, but a couple
dumb questions anyway (feel free to ignore):

1. Would it be possible to leverage the existing interface from
   `epa-hook' for decrypting these files? As a dirty example:

   (defun my-ensure-epa-file-name-handler (orig &rest args)
     (require 'epa-hook)
     (defvar epa-file-handler)
     (let ((file-name-handler-alist
            (cons epa-file-handler file-name-handler-alist)))
       (apply orig args)))

   (advice-add 'auth-source-pass--read-entry
               :around #'my-ensure-epa-file-name-handler)

   And if doing something like that (without the advice, obviously),
   could we somehow "weaken" the regexp of our fallback member's key so
   that `find-file-name-handlers' favors an existing, user-defined
   override? Alternatively, would it be too wasteful to first attempt to
   match the target file name against the option's current members
   before falling back on binding a modified value (or using your
   proposed hard-coded solution)? Or, wasteful or not, what about
   instead offering a new auth-source-pass option whose value is an
   alist of the same type as `file-name-handler-alist' that we use in
   place of or concatenate with the existing value at runtime?

2. How likely is it that someone actually depends on the perceived
   undesirable behavior currently on HEAD? Like, for example, could
   someone out there conceivably have a cron-like script that runs
   `epa-file-disable' before copying the encrypted secrets from the
   result of an `auth-source-search' to Nextcloud or something? If these
   weren't passwords, perhaps we could just shrug off such
   hypotheticals, but... (just saying).

Thanks,
J.P.





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 21 Dec 2023 11:54:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 21 06:54:53 2023
Received: from localhost ([127.0.0.1]:42571 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGHdc-0007tE-IN
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 06:54:52 -0500
Received: from mout-p-102.mailbox.org ([80.241.56.152]:39330)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rGHdZ-0007sz-VJ
 for 67937 <at> debbugs.gnu.org; Thu, 21 Dec 2023 06:54:50 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Swpkk63S9z9tRf;
 Thu, 21 Dec 2023 12:54:38 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703159678;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=F4UTdIeJyv11SwlSfL08krxIaD4JUY3VcbBlGu1a/sk=;
 b=bHL0urrC3Yl5v20sUTNBSxCERpwon7rv1DKvJGe8C3T9y65UcMMTobkjoM/8fyHw+QFBq2
 /7mYFEmWBlOioZrM8Nb8MFSXqZDZ0PxB1V8bPjUw+MqQZhpE2uwUgIRgO/gvsIL73Mzruq
 xnj/JYOhJZWoPPZISLgGHa8pMq4X0gZP+uRyDeUuKvj8Xs35yuFHeEYZTXmh4tSFGTIOLq
 klzsYvfcUHHipT5NnWwWf/+GsWMv9gUMMV+ZEB4u8hQ7efk2r75nW2HQiYgc51Zoto/Bh2
 SiN0J2OBUMtlM+3ruSq6Wi/AlJmWglfOixKc3At7F6VCxk9zNUnThZDk0vVByA==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
 <87msu4myau.fsf@HIDDEN> <83y1dnga7u.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Thu, 21 Dec 2023 11:18:59 +0100
In-reply-to: <83y1dnga7u.fsf@HIDDEN>
Message-ID: <87sf3vlqj1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: Damien Cassou <damien@HIDDEN>, 67937 <at> debbugs.gnu.org,
 "F. Jason Park" <jp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain


Eli Zaretskii <eliz@HIDDEN> writes:

> Thanks.  So it sounds like you are asking for a feature that currently
> doesn't exist, AFAIU.

I'm not sure I'd classify it as a new feature.  An existing interface is
broken under some conditions.

> I added a couple of people to this discussion who were involved with
> auth-source-pass, in the hope that they will have suggestions and
> comments.

Thank you.

Now, onto why I don't think this is a new feature:

Here's an example auth-source-search invocation that can demonstrate the
problem (assuming that the user has these a dev.gentoo.org secret on
port imaps with user arsen):

  (auth-info-password (car (auth-source-search :host "dev.gentoo.org"
                                               :port "imaps"
  					       :user "arsen")))

Following M-x epa-file-disable RET M-x auth-source-forget-all-cached RET
the above returns an encrypted string rather than its actual password.

This means that a current feature (auth-source-search) breaks under some
conditions.

I've worked out a fix, tested with the following:

  (require 'auth-source-pass)
  (setq auth-sources '(password-store))
  (auth-info-password (car (auth-source-search :host "dev.gentoo.org"
                                               :port "imaps"
                                               :user "arsen")))

I've attached the patch, though it lacks a regression test.  The reason
for this is that I want to spare the auth-source-pass developers some
triage, and that there's currently no regression tests for --read-entry.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-auth-source-pass-don-t-rely-on-epa-file-bug-67937.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: Remove epa-file reliance in auth-source-pass--read-entry

From=2043e98821aa1f02abbfeea8b0b08ec6f4e31d8e9f Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Arsen=3D20Arsenovi=3DC4=3D87?=3D <arsen@HIDDEN>
Date: Thu, 21 Dec 2023 12:29:55 +0100
Subject: [PATCH] auth-source-pass: don't rely on epa-file (bug#67937)

* lisp/auth-source-pass.el (epg): Require epg.
(auth-source-pass--read-entry): Use epg-decrypt-file instead of relying
on epa-file decrypting files read via insert-file-contents.
=2D--
 lisp/auth-source-pass.el | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el
index 0f51755a250..0322de9f313 100644
=2D-- a/lisp/auth-source-pass.el
+++ b/lisp/auth-source-pass.el
@@ -34,6 +34,7 @@
 (require 'cl-lib)
 (require 'auth-source)
 (require 'url-parse)
+(require 'epg)
 ;; Use `eval-when-compile' after the other `require's to avoid spurious
 ;; "might not be defined at runtime" warnings.
 (eval-when-compile (require 'subr-x))
@@ -194,11 +195,11 @@ auth-source-pass--get-attr
=20
 (defun auth-source-pass--read-entry (entry)
   "Return a string with the file content of ENTRY."
=2D  (with-temp-buffer
=2D    (insert-file-contents (expand-file-name
=2D                           (format "%s.gpg" entry)
=2D                           auth-source-pass-filename))
=2D    (buffer-substring-no-properties (point-min) (point-max))))
+  (let ((context (epg-make-context 'OpenPGP))
+	(file (expand-file-name
+	       (format "%s.gpg" entry)
+	       auth-source-pass-filename)))
+    (epg-decrypt-file context file nil)))
=20
 (defun auth-source-pass-parse-entry (entry)
   "Return an alist of the data associated with ENTRY.
=2D-=20
2.43.0


--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Have a lovely day!
=2D-
Arsen Arsenovi=C4=87

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYQnchAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTk48BAOcEahHu6B4pVsRJljwLJ+JPeEUAd0dNX3EY
6Ug1nZHGAQDUNpmaxBrQ3Q3jop7RS9HF9R45okFfcnskeG/IBHqeBw==
=fZ6o
-----END PGP SIGNATURE-----
--==-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 21 Dec 2023 09:46:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 21 04:46:13 2023
Received: from localhost ([127.0.0.1]:42425 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGFd6-0008KT-VG
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 04:46:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55066)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rGFd1-00087D-4y
 for 67937 <at> debbugs.gnu.org; Thu, 21 Dec 2023 04:46:11 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rGFcq-0001fk-IG; Thu, 21 Dec 2023 04:45:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=m+wOow8a8u+xoiMbpZ+cVGmt+941Uu2ss9reInW3g5M=; b=o3+ns/XiP/WdrWqPYLbZ
 +/72PuFsf1aMeHeskrS/0YLBRLchWq1alCizVKKGB6lSkUAfUCBOyEY3Tfpf9OX0TcSKxyAmlesh5
 wSrJCE7l/n76uJhoI/m4jL46dfXzwSRZad8AfvPqlcxbeodpTxJCyH2ACJ5rQsWOp540/4ywfMBI/
 lCEJbWwUN4addI0Oe4z6WGWQ1lKfk6neIuB65e0KJ2mhg46mEh58K7N+hUMAMuS7h9reqA2ELl2XE
 oA8QClryVU+Lqo2YjoP87ji9owQejNKcwbokaU2N5I9DBUYxOgCgmGqC+FxhUnkyzVtA681U9qKuI
 AQzqZhXAX9iOxA==;
Date: Thu, 21 Dec 2023 11:45:41 +0200
Message-Id: <83y1dnga7u.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>,
 Damien Cassou <damien@HIDDEN>, "F. Jason Park" <jp@HIDDEN>
In-Reply-To: <87msu4myau.fsf@HIDDEN> (message from Arsen =?utf-8?Q?Arse?=
 =?utf-8?Q?novi=C4=87?= on Wed, 20 Dec 2023 20:58:08 +0100)
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN> <87msu4myau.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67937
Cc: 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Arsen Arsenović <arsen@HIDDEN>
> Cc: 67937 <at> debbugs.gnu.org
> Date: Wed, 20 Dec 2023 20:58:08 +0100
> 
> > How can it decrypt the string when you disable decryption?  What is
> > the replacement of epa-file that would decrypt the data string?
> 
> Even with epa-disable, it could use epa-decrypt-region to decrypt the
> password from the file.
> 
> For some context, I'll briefly summarize how password-store (pass)
> works: pass stores credentials as one line representing the secret and
> the rest being aux data (usually usernames and similar) in each file.
> One file represents one set of credentials, encrypted via PGP (an
> example filename is
> ~/.password-store/gentoo/gentoo.org/arsen@HIDDEN).
> 
> To get a given password from a given password store entry,
> auth-source-pass needs to decrypt this file and get the first line of
> the decrypted contents.
> 
> Currently, auth-source-pass relies on epa-file facilities to decrypt the
> password entries, but those do nothing after epa-file-disable.  Instead,
> it should use something like epa-decrypt-region or such (sorry, not too
> familiar with EasyPG).
> 
> AIUI, epa-file-disable disables *automatic* decryption, not all forms of
> decryption.

Thanks.  So it sounds like you are asking for a feature that currently
doesn't exist, AFAIU.  I added a couple of people to this discussion
who were involved with auth-source-pass, in the hope that they will
have suggestions and comments.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 20 Dec 2023 20:09:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 20 15:09:13 2023
Received: from localhost ([127.0.0.1]:41865 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rG2sT-0003uZ-7u
	for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 15:09:13 -0500
Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:54462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rG2sQ-0003uE-Tt
 for 67937 <at> debbugs.gnu.org; Wed, 20 Dec 2023 15:09:12 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4SwPlb2pk4z9spt;
 Wed, 20 Dec 2023 21:08:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703102939;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=0qfHSn2OmYJeajAkr4ophVViivqW32+T56h6IH32WUQ=;
 b=DY/ja8OVP+Ydb0Cw04aomyfYt+oIJWA282A5NdccG8US2HV4fh/bLV1IgVEtd9ESF1aLz2
 e0SB2uKUBGTftaKrjjBfB0CgXgIqAFIDxys09bKmZyNfVedT3CMeShVGsVsI7iQWntXzRB
 tBP3YfWfceDZlUtoOyMCguCtYy2eLeuDdaf90LnXdF9v1paC5HnpWXSANwSlEMCMfRDpRr
 4mYocNzD8/W27akiYRLS9mvRFXDf8gUtkFKh2trZih/+KPVhytZhnfed3qP8iGi9ooVN1R
 Qoc0TM835+FEzGrpxYCu0/c/VEZtocoKueiL5upQYvAhAehoxauyF36lm3bZoQ==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN> <83bkakhe8s.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Wed, 20 Dec 2023 20:58:08 +0100
In-reply-to: <83bkakhe8s.fsf@HIDDEN>
Message-ID: <87msu4myau.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Arsen Arsenovi=C4=87 <arsen@HIDDEN>
>> Cc: 67937 <at> debbugs.gnu.org
>> Date: Wed, 20 Dec 2023 20:11:20 +0100
>>
>> >> - emacs -Q
>> >> - M-x epa-file-disable
>> >> - M-: (auth-source-pass-get 'secret "something")
>> >>
>> >> You will see a GPG-encrypted data string.
>> >>
>> >> epa-file-disable should not break the auth-source.
>> >
>> > Please tell more about what you mean by "break".
>>
>> What I mean by that is 'You will see a GPG-encrypted data string'.  The
>> source returns an encrypted string rather than its contents.
>
> How can it decrypt the string when you disable decryption?  What is
> the replacement of epa-file that would decrypt the data string?

Even with epa-disable, it could use epa-decrypt-region to decrypt the
password from the file.

For some context, I'll briefly summarize how password-store (pass)
works: pass stores credentials as one line representing the secret and
the rest being aux data (usually usernames and similar) in each file.
One file represents one set of credentials, encrypted via PGP (an
example filename is
~/.password-store/gentoo/gentoo.org/arsen@HIDDEN).

To get a given password from a given password store entry,
auth-source-pass needs to decrypt this file and get the first line of
the decrypted contents.

Currently, auth-source-pass relies on epa-file facilities to decrypt the
password entries, but those do nothing after epa-file-disable.  Instead,
it should use something like epa-decrypt-region or such (sorry, not too
familiar with EasyPG).

AIUI, epa-file-disable disables *automatic* decryption, not all forms of
decryption.

To provide some more context, I noticed auth-source-pass preventing
sending emails seemingly at random (by returning encrypted passwords
rather than the actual passwords), then noticed that it seems to start
working again following M-x epa-file-enable RET M-x
auth-source-forget-all-cached RET, and then I managed to reproduce in a
clean Emacs, then I filed this report.

I'm still unsure why epa-file gets disabled on occasion, but whether it
does or does not, auth-source-pass should either ensure its enabled or
not rely on such a facility for reading passwords.

Thanks again, have a lovely night.
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYNJ2RAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTESIBANl1+OSDf6YQo0Iwlo+acWZDGjRNZPucjc3h
8Ycm04mwAP436PLd+KncCI53ZMMY1gclpBO//+/y0Agm/ZkNeNQaBg==
=Y1g8
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 20 Dec 2023 19:21:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 20 14:21:37 2023
Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rG28P-0003GU-DZ
	for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 14:21:37 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50548)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rG28L-0003GD-D9
 for 67937 <at> debbugs.gnu.org; Wed, 20 Dec 2023 14:21:36 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rG28C-0000Nb-Kw; Wed, 20 Dec 2023 14:21:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=b5BPurEJCmbJV8vSMu+11lqJk11/FDOc/pCFLJYpwtg=; b=Y33C8wn8cglsx+y9n4mu
 gX6i1m6kSLPuQTlALYm7LAHnb9S463HWjXpBEifzi+mtesCLyiSdHBIdM99E/Q9RuW3B69cUfBBFC
 zmNGKgvxRi/TJbvXegSmUhHUrfm/12nCMNUchb5/7YyBWK2MVeNyefPsRUUZmTxfw7wubeGooTYhH
 zR8hcw6j5GK0OPQLO0SQh1/E8nhn6E+kl5H36/JllMXaVxsXNJHNAVzilTfQXSSdoD7ccDlIliJeb
 PwiCAbxTzmlRhDARrbJKM0lCQxcjpGLwAlya45voqYf6kb7XEHpbtAur7wxEQwE7msb8O2g9U31AL
 fINNNM6vGy1Sjw==;
Date: Wed, 20 Dec 2023 21:21:07 +0200
Message-Id: <83bkakhe8s.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
In-Reply-To: <87jzp8of97.fsf@HIDDEN> (message from Arsen =?utf-8?Q?Arse?=
 =?utf-8?Q?novi=C4=87?= on Wed, 20 Dec 2023 20:11:20 +0100)
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
 <87jzp8of97.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67937
Cc: 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Arsen Arsenović <arsen@HIDDEN>
> Cc: 67937 <at> debbugs.gnu.org
> Date: Wed, 20 Dec 2023 20:11:20 +0100
> 
> >> - emacs -Q
> >> - M-x epa-file-disable
> >> - M-: (auth-source-pass-get 'secret "something")
> >>
> >> You will see a GPG-encrypted data string.
> >>
> >> epa-file-disable should not break the auth-source.
> >
> > Please tell more about what you mean by "break".
> 
> What I mean by that is 'You will see a GPG-encrypted data string'.  The
> source returns an encrypted string rather than its contents.

How can it decrypt the string when you disable decryption?  What is
the replacement of epa-file that would decrypt the data string?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 20 Dec 2023 19:17:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 20 14:17:45 2023
Received: from localhost ([127.0.0.1]:41804 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rG24e-00039a-SD
	for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 14:17:45 -0500
Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]:43052)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rG24a-00039I-0J
 for 67937 <at> debbugs.gnu.org; Wed, 20 Dec 2023 14:17:43 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4SwNc728dJz9sl4;
 Wed, 20 Dec 2023 20:17:27 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703099847;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=/+syZnutwGkv0ZdRNoS36hEntKVV89aOwS+PJ8cqJnY=;
 b=IEWYsOzbE+E5gTPzyAYQOUOCs5+lciTqMqFgVVWv3mpJgQOKhxGX2CPhVz2X7a/8KOHMrB
 AaymdhZp0JNMrmgfdlHjR5X7VQMLgvl9op5n8GQBxtpr/gVsmYi9yse0WDjUTMI/tfUPxD
 zIHahOaifp/P9t+sD3GTkGyBa6I/ynZrEQwPexCILh7hbkZtOOmW2Hog8GK161Jy+ramy3
 TfrBN5n4+sPqzVfhH2rfvge1JRKnL5lH8VWRpfMtrNAt9gOdZNukMcFNoR/PwMCHd5ETHt
 JApnysJK8HM9fudNjxgllzsGQdAA+r8XKPzPIFR43zzL58RyV+eKvHQdHCw9eQ==
References: <8734vwq06i.fsf@HIDDEN> <83frzwhgre.fsf@HIDDEN>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67937: 30.0.50; auth-source-pass relies on epa-file being
 enabled
Date: Wed, 20 Dec 2023 20:11:20 +0100
In-reply-to: <83frzwhgre.fsf@HIDDEN>
Message-ID: <87jzp8of97.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67937
Cc: 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Evening Eli,

Eli Zaretskii <eliz@HIDDEN> writes:

>> Date: Wed, 20 Dec 2023 17:57:28 +0100
>> From:  Arsen Arsenovi=C4=87 via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> It would seem that auth-source-pass relies on epa-file being enabled to
>> be able to decrypt passwords.
>>
>> Repro steps:
>> - emacs -Q
>> - M-x epa-file-disable
>> - M-: (auth-source-pass-get 'secret "something")
>>
>> You will see a GPG-encrypted data string.
>>
>> epa-file-disable should not break the auth-source.
>
> Please tell more about what you mean by "break".

What I mean by that is 'You will see a GPG-encrypted data string'.  The
source returns an encrypted string rather than its contents.

This isn't auth-source-search (which is what I should be using for the
demo), but the actual search returns the same result (which I noticed
when debugging smtpmail failing to authenticate).

> When I try the above in the latest master, I get nil and nothing else.
> If that is deemed "breakage", I guess I'm missing something, so I'd
> appreciate if you tell more about the problem you see.
>
> Thanks.
>
> P.S. And apologies if what I say makes no sense because I don't use
> auth-source-pass.

Right.  "something" here is a placeholder for an actual password-store
entry (e.g. email/dev.gentoo.org:smtps), and you need a password-store
to reproduce the problem.

Apologies for the lack of clarification, I was writing in a hurry.

Have a good one!
=2D-
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZYM9xBAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTWQAA/RoBgq0exuAP0cstZvV7gThWt+Y5SRR4SEN+
1f1ouFcCAP4nUEM8EQ4ysCXdGMy6/8WVauy+l6by+LTkJyWIUW6DCg==
=SL2J
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at 67937 <at> debbugs.gnu.org:


Received: (at 67937) by debbugs.gnu.org; 20 Dec 2023 18:27:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 20 13:27:14 2023
Received: from localhost ([127.0.0.1]:41764 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rG1Hm-0008JQ-Gz
	for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 13:27:14 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:49882)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rG1Hi-0008JB-RE
 for 67937 <at> debbugs.gnu.org; Wed, 20 Dec 2023 13:27:13 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rG1HZ-00043q-8a; Wed, 20 Dec 2023 13:27:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=HWnPhyBnJmhghoodDU5GW7THyeNFdNiKRBaEOxgV6tI=; b=MYoDmReRxU7aBIdOuWhm
 ygJ+ULcUe34a43RWSh3EGZSxwHQsPBIZ94kIU/l95vRw4WCfhXf+Vq6x+e6XguqslAyV0KFU0xWal
 SJHgYWcOn7opDRD05Ve353D9LM0i5cyoonMePGlaDbX6uz5/xzpe3BpiFQ+2sWslMkbLiEYcE/ZU8
 bEz5EUOBeVbEEFJ3lVBKKBqSSHlq6SEjOtD5D+kfi7Uim3ydk/o+0EmE9cR+uZL3Hay64Z+4NCKpU
 h+0/pQv6S14c42OCqETQBmhWxbGF6L4xVwERAPC/XKib+J/4Ik7Rrh08JpmgyzFGveenvtEIsHZhi
 fIRhzW1XhIcxVA==;
Date: Wed, 20 Dec 2023 20:26:45 +0200
Message-Id: <83frzwhgre.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
In-Reply-To: <8734vwq06i.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#67937: 30.0.50;
 auth-source-pass relies on epa-file being enabled
References: <8734vwq06i.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67937
Cc: 67937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 20 Dec 2023 17:57:28 +0100
> From:  Arsen Arsenović via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> It would seem that auth-source-pass relies on epa-file being enabled to
> be able to decrypt passwords.
> 
> Repro steps:
> - emacs -Q
> - M-x epa-file-disable
> - M-: (auth-source-pass-get 'secret "something")
> 
> You will see a GPG-encrypted data string.
> 
> epa-file-disable should not break the auth-source.

Please tell more about what you mean by "break".  When I try the above
in the latest master, I get nil and nothing else.  If that is deemed
"breakage", I guess I'm missing something, so I'd appreciate if you
tell more about the problem you see.

Thanks.

P.S. And apologies if what I say makes no sense because I don't use
auth-source-pass.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Dec 2023 17:01:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 20 12:01:05 2023
Received: from localhost ([127.0.0.1]:41701 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFzwO-00016w-IJ
	for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 12:01:05 -0500
Received: from lists.gnu.org ([2001:470:142::17]:55502)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arsen@HIDDEN>) id 1rFzwK-0000s9-Aq
 for submit <at> debbugs.gnu.org; Wed, 20 Dec 2023 12:01:03 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <arsen@HIDDEN>) id 1rFzvo-0002Wy-GY
 for bug-gnu-emacs@HIDDEN; Wed, 20 Dec 2023 12:00:43 -0500
Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <arsen@HIDDEN>) id 1rFzvj-0004Uj-4z
 for bug-gnu-emacs@HIDDEN; Wed, 20 Dec 2023 12:00:26 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4SwKYh1L2zz9srM
 for <bug-gnu-emacs@HIDDEN>; Wed, 20 Dec 2023 18:00:08 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; 
 t=1703091608;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=rXMZDTK1t0BMuDWMSEPAqFEU3NH2H708z+iDnVNLWcY=;
 b=AOOjQX6wEVTI7Heg98Z2TG8YuyW340wmRbSMHg9NlgxwiGMPBBNt/mMoYZq+qeG0bTddld
 KXLpdsGvzt/zVIw981YQXO+jOdmY1cRlJ9/HbgKjIipDbfwk9g6CBt3PV803jqvOcQJ8T2
 4QyKJ2uXAs4oMQJkmve33YoRVc8U+e8YVaP3mribG4DTz6YxdSW7ADl3AuNpyWiPzTVxy2
 7fGbWT0syIp7yYJYUF1zGCqc9oEhcoHE/yl+56hUCELhsuDAcWYTZGSWsp+5jy8ODfr1Xp
 SJoUBqaTQ9QEh+WYfH6lOLSeN8Pj1cN+/O3xiZuovcaDIymrMP2hLc/JvSooFA==
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; auth-source-pass relies on epa-file being enabled
Date: Wed, 20 Dec 2023 17:57:28 +0100
X-Debbugs-Cc: 
Message-ID: <8734vwq06i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Queue-Id: 4SwKYh1L2zz9srM
Received-SPF: pass client-ip=2001:67c:2050:0:465::103;
 envelope-from=arsen@HIDDEN; helo=mout-p-103.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

Hi there!

It would seem that auth-source-pass relies on epa-file being enabled to
be able to decrypt passwords.

Repro steps:
- emacs -Q
- M-x epa-file-disable
- M-: (auth-source-pass-get 'secret "something")

You will see a GPG-encrypted data string.

epa-file-disable should not break the auth-source.

TIA, have a lovely day.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2023-12-16 built on localhost
Repository revision: 2a591b228aaa8c66c27cc5b7cb3033aa6625bc0b
Repository branch: master
System Description: Gentoo Linux

Configured using:
 'configure --prefix=3D/usr --build=3Dx86_64-pc-linux-gnu
 --host=3Dx86_64-pc-linux-gnu --mandir=3D/usr/share/man
 --infodir=3D/usr/share/info --datadir=3D/usr/share --sysconfdir=3D/etc
 --localstatedir=3D/var/lib --datarootdir=3D/usr/share
 --disable-silent-rules --docdir=3D/usr/share/doc/emacs-30.0.9999
 --htmldir=3D/usr/share/doc/emacs-30.0.9999/html --libdir=3D/usr/lib64
 --program-suffix=3D-emacs-30-vcs --includedir=3D/usr/include/emacs-30-vcs
 --infodir=3D/usr/share/info/emacs-30-vcs --localstatedir=3D/var
 --enable-locallisppath=3D/etc/emacs:/usr/share/emacs/site-lisp
 --without-compress-install --without-hesiod --without-pop
 --with-file-notification=3Dinotify --with-pdumper --enable-acl
 --enable-xattr --with-dbus --with-modules --with-gameuser=3D:gamestat
 --with-libgmp --with-gpm --with-native-compilation=3Daot --with-json
 --without-kerberos --without-kerberos5 --with-lcms2 --with-xml2
 --with-mailutils --without-selinux --without-small-ja-dic
 --with-sqlite3 --with-gnutls --with-libsystemd --with-threads
 --with-tree-sitter --without-wide-int --with-sound=3Dalsa --with-zlib
 --with-pgtk --without-x --without-ns --with-toolkit-scroll-bars
 --without-gconf --without-gsettings --with-harfbuzz --with-libotf
 --with-m17n-flt --with-xwidgets --with-gif --with-jpeg --with-png
 --with-rsvg --with-tiff --with-webp --without-imagemagick
 --with-dumping=3Dpdumper 'CFLAGS=3D-freport-bug -O3 -ggdb3 -pipe
 -fdiagnostics-color=3Dalways -march=3Dx86-64-v2 -flto' 'LDFLAGS=3D-Wl,-O1
 -Wl,--as-needed -O3 -Wl,-O3 -pipe -fdiagnostics-color=3Dalways
 -Wl,--defsym=3D__gentoo_check_ldflags__=3D0 -Wl,-z,pack-relative-relocs
 -Wl,--build-id -flto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2
LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER
PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XIM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: mu4e:main

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  server-mode: t
  diff-hl-flydiff-mode: t
  global-jinx-mode: t
  savehist-mode: t
  save-place-mode: t
  desktop-save-mode: t
  mu4e-search-minor-mode: t
  global-hl-line-mode: t
  mu4e-update-minor-mode: t
  mu4e-context-minor-mode: t
  mu4e-modeline-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  corfu-popupinfo-mode: t
  global-corfu-mode: t
  corfu-mode: t
  marginalia-mode: t
  vertico-mouse-mode: t
  vertico-mode: t
  which-key-mode: t
  global-display-fill-column-indicator-mode: t
  which-function-mode: t
  electric-pair-mode: t
  global-whitespace-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tab-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  overwrite-mode: overwrite-mode-binary

Load-path shadows:
/usr/share/emacs/site-lisp/desktop-entry-mode hides /usr/share/emacs/site-l=
isp/desktop-file-utils/desktop-entry-mode
/usr/share/emacs/site-lisp/emacs-eat/eat hides /usr/share/emacs/site-lisp/e=
macs-eat/term/eat
/usr/share/emacs/site-lisp/transient/transient hides /usr/share/emacs/30.0.=
50/lisp/transient

Features:
(shadow emacsbug help-fns radix-tree cl-print debug backtrace
network-stream nsm mailalias mm-archive sort smiley gnus-cite mail-extr
textsec uni-scripts idna-mapping ucs-normalize uni-confusable
textsec-check qp org-capture face-remap magit-bookmark git-rebase
magit-extras magit-sparse-checkout magit-gitignore magit-ediff ediff
ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init
ediff-util magit-subtree magit-patch magit-submodule magit-blame
magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch
magit-clone magit-remote magit-commit magit-sequence magit-notes
magit-worktree magit-tag magit-merge magit-branch magit-reset
magit-files magit-refs magit-status magit package url-handlers
magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode
git-commit log-edit magit-core magit-autorevert magit-margin
magit-transient magit-process with-editor comp comp-cstr server
magit-mode transient magit-git magit-base magit-section cursor-sensor
crm consult-register consult misearch multi-isearch vc-hg vc-bzr
cus-edit cus-start tramp-archive tramp-gvfs tramp-cmds tramp-cache
time-stamp eat term ehelp vertico-directory add-log ffap antlr-mode view
texinfo texinfo-loaddefs autoconf-mode make-mode bug-reference epa-file
m4-mode flymake-cc flymake project compile warnings autorevert dired-aux
vc-git diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc
vc-dispatcher diff-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs jinx org-element
org-persist org-id org-refile avl-tree generator oc-basic ol-eww eww
url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect
ol-docview doc-view filenotify jka-compr image-mode exif ol-bibtex
bibtex ol-bbdb ol-w3m ol-doi org-link-doi ebuild-mode skeleton sh-script
smie treesit executable pcase emacs-news-mode display-line-numbers info
savehist saveplace tramp-sh tramp trampver tramp-integration files-x
tramp-message tramp-compat xdg shell tramp-loaddefs desktop frameset
cus-load mu4e mu4e-org mu4e-notification notifications mu4e-main
mu4e-view thingatpt gnus-art mm-uu mml2015 mm-view mml-smime smime
gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus
comp-run comp-common gnus-cloud nnimap nnmail mail-source utf7 nnoo
parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win gnus nnheader
range wid-edit mu4e-headers mu4e-compose mu4e-draft mu4e-actions
smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message
shr pixel-fill kinsoku url-file browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie generate-lisp-file
url-domsuf url-util flow-fill mule-util hl-line mu4e-contacts
mu4e-update mu4e-folders mu4e-context mu4e-query-items mu4e-server
mu4e-modeline mu4e-vars mu4e-helpers mu4e-config mu4e-window bookmark pp
ido message sendmail mailcap yank-media puny dired dired-loaddefs rfc822
mml mml-sec epa derived epg rfc6068 epg-config gnus-util
text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils
gmm-utils mailheader mu4e-obsolete auth-source-pass url-parse url-vars
auth-source eieio eieio-core password-cache ws-butler
modus-vivendi-tinted-theme modus-themes kind-icon svg-lib color svg dom
xml corfu-popupinfo corfu orderless marginalia vertico-mouse vertico
compat flycheck json map dash org ob ob-tangle ob-ref ob-lob ob-table
ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint
ansi-osc ansi-color org-list org-footnote org-faces org-entities
time-date noutline outline ob-emacs-lisp ob-core ob-eval org-cycle
org-table ol rx org-fold org-fold-core org-keys oc org-loaddefs
find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs
format-spec which-key ace-window subr-x avy ring
display-fill-column-indicator disp-table which-func imenu elec-pair
icons whitespace edmacro kmacro byte-opt cl-macs gv cl-extra help-mode
cl-seq use-package use-package-ensure use-package-delight
use-package-diminish use-package-bind-key bind-key easy-mmode
use-package-core cl-loaddefs cl-lib bytecomp byte-compile site-gentoo
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win
term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads xwidget-internal dbusbind inotify dynamic-setting
font-render-setting cairo gtk pgtk lcms2 multi-tty move-toolbar
make-network-process native-compile emacs)

Memory information:
((conses 16 1372904 2758834) (symbols 48 63158 173) (strings 32 238991 6397=
2)
 (string-bytes 1 9351869) (vectors 16 143465) (vector-slots 8 3206303 10386=
17)
 (floats 8 758 12743) (intervals 56 99512 19143) (buffers 992 162))
<#secure method=3Dpgpmime mode=3Dsign>

--
Arsen Arsenovi=C4=87




Acknowledgement sent to Arsen Arsenović <arsen@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#67937; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.