GNU logs - #67972, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67972: Use *command (&)* instead of shell-command-buffer-name(-async)
Resent-From: Nafiz Islam <nafiz.islam1001@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Dec 2023 18:37:02 +0000
Resent-Message-ID: <handler.67972.B.170327019127409 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67972 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Nafiz Islam <nafiz.islam1001@HIDDEN>
Date: Fri, 22 Dec 2023 12:31:24 -0500
Message-ID: <CAKjtFcRRVPCixZbdgYmVkY_tOGQdFxAotD6iFi270Mk=Z2__Nw@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000082ce8b060d1c96c4"
Received-SPF: pass client-ip=2a00:1450:4864:20::631;
 envelope-from=nafiz.islam1001@HIDDEN; helo=mail-ej1-x631.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: The buffer name for the shell-command or async-shell-command
 would be much more useful if they were given the name of the command being
 executed. I started working a bit on a patch for that, but it's just code
 changes right now. Here's a preview of what I mean. 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (nafiz.islam1001[at]gmail.com)
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (nafiz.islam1001[at]gmail.com)
 0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Mailman-Approved-At: Fri, 22 Dec 2023 13:36:28 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

--00000000000082ce8b060d1c96c4
Content-Type: text/plain; charset="UTF-8"

The buffer name for the shell-command or async-shell-command would be much
more useful if they were given the name of the command being executed.

I started working a bit on a patch for that, but it's just code changes
right now. Here's a preview of what I mean.

@@ -4252,12 +4252,6 @@ undo-outer-limit-truncate

 ;;;; Shell commands

-(defconst shell-command-buffer-name "*Shell Command Output*"
-  "Name of the output buffer for shell commands.")
-
-(defconst shell-command-buffer-name-async "*Async Shell Command*"
-  "Name of the output buffer for asynchronous shell commands.")
-
 (defvar shell-command-history nil
   "History list for some commands that read shell commands.

@@ -4671,7 +4660,8 @@ shell-command
  ;; Output goes in a separate buffer.
  (if (string-match "[ \t]*&[ \t]*\\'" command)
     ;; Command ending with ampersand means asynchronous.
-            (let* ((buffer (get-buffer-create
+            (let* ((shell-command-buffer-name-async (concat "*" command
"*"))
+                   (buffer (get-buffer-create
                             (or output-buffer
shell-command-buffer-name-async)))
                    (bname (buffer-name buffer))
                    (proc (get-buffer-process buffer))
@@ -4942,7 +4932,8 @@ shell-command-on-region
        shell-command-default-error-buffer
        t
        (region-noncontiguous-p))))
-  (let ((error-file
+  (let ((shell-command-buffer-name (concat "*" command "*"))
+        (error-file
  (if error-buffer
      (make-temp-file
       (expand-file-name "scor"

--00000000000082ce8b060d1c96c4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>The buffer name for the shell-command or async-shell-=
command would be much more useful if they were given the name of the comman=
d being executed.</div><div><br></div><div>I started working a bit on a pat=
ch for that, but it&#39;s just code changes right now. Here&#39;s a preview=
 of what I mean.</div><div><br>@@ -4252,12 +4252,6 @@ undo-outer-limit-trun=
cate<br>=C2=A0=0C<br>=C2=A0;;;; Shell commands<br>=C2=A0<br>-(defconst shel=
l-command-buffer-name &quot;*Shell Command Output*&quot;<br>- =C2=A0&quot;N=
ame of the output buffer for shell commands.&quot;)<br>-<br>-(defconst shel=
l-command-buffer-name-async &quot;*Async Shell Command*&quot;<br>- =C2=A0&q=
uot;Name of the output buffer for asynchronous shell commands.&quot;)<br>-<=
br>=C2=A0(defvar shell-command-history nil<br>=C2=A0 =C2=A0&quot;History li=
st for some commands that read shell commands.<br><br>@@ -4671,7 +4660,8 @@=
 shell-command<br>=C2=A0	;; Output goes in a separate buffer.<br>=C2=A0	(if=
 (string-match &quot;[ \t]*&amp;[ \t]*\\&#39;&quot; command)<br>=C2=A0	 =C2=
=A0 =C2=A0;; Command ending with ampersand means asynchronous.<br>- =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((buffer (get-buffer-create<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((shell-command-buffer-name-=
async (concat &quot;*&quot; command &quot;*&quot;))<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (buffer (get-buffer-create<br=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(or output-buffer shell-command-buffer-name-=
async)))<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 (bname (buffer-name buffer))<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (proc (get-buffer-process buffer))<br>@@=
 -4942,7 +4932,8 @@ shell-command-on-region<br>=C2=A0		 =C2=A0 =C2=A0 =C2=
=A0 shell-command-default-error-buffer<br>=C2=A0		 =C2=A0 =C2=A0 =C2=A0 t<b=
r>=C2=A0		 =C2=A0 =C2=A0 =C2=A0 (region-noncontiguous-p))))<br>- =C2=A0(let=
 ((error-file<br>+ =C2=A0(let ((shell-command-buffer-name (concat &quot;*&q=
uot; command &quot;*&quot;))<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(error-file<br=
>=C2=A0	 (if error-buffer<br>=C2=A0	 =C2=A0 =C2=A0 (make-temp-file<br>=C2=
=A0	 =C2=A0 =C2=A0 =C2=A0(expand-file-name &quot;scor&quot;<br></div><div><=
br></div></div>

--00000000000082ce8b060d1c96c4--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Nafiz Islam <nafiz.islam1001@HIDDEN>
Subject: bug#67972: Acknowledgement (Use *command (&)* instead of
 shell-command-buffer-name(-async))
Message-ID: <handler.67972.B.170327019127409.ack <at> debbugs.gnu.org>
References: <CAKjtFcRRVPCixZbdgYmVkY_tOGQdFxAotD6iFi270Mk=Z2__Nw@HIDDEN>
X-Gnu-PR-Message: ack 67972
X-Gnu-PR-Package: emacs
Reply-To: 67972 <at> debbugs.gnu.org
Date: Fri, 22 Dec 2023 18:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 67972 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67972: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67972
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67972: Use *command (&)* instead of shell-command-buffer-name(-async)
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Dec 2023 19:20:01 +0000
Resent-Message-ID: <handler.67972.B67972.170327274329271 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Nafiz Islam <nafiz.islam1001@HIDDEN>
Cc: 67972 <at> debbugs.gnu.org
Date: Fri, 22 Dec 2023 21:18:23 +0200
Message-Id: <83a5q2f3ls.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAKjtFcRRVPCixZbdgYmVkY_tOGQdFxAotD6iFi270Mk=Z2__Nw@HIDDEN>
 (message from Nafiz Islam on Fri, 22 Dec 2023 12:31:24 -0500)
References: <CAKjtFcRRVPCixZbdgYmVkY_tOGQdFxAotD6iFi270Mk=Z2__Nw@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Nafiz Islam <nafiz.islam1001@HIDDEN>
> Date: Fri, 22 Dec 2023 12:31:24 -0500
> 
> The buffer name for the shell-command or async-shell-command would be much more useful if they
> were given the name of the command being executed.
> 
> I started working a bit on a patch for that, but it's just code changes right now. Here's a preview of
> what I mean.

Instead of removing the default name, why not add one more possible
value to async-shell-command-buffer, which will do what you want?
Then users who are interested in this behavior could customize
async-shell-command-buffer to that new value.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67972: Use *command (&)* instead of shell-command-buffer-name(-async)
Resent-From: Nafiz Islam <nafiz.islam1001@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 23 Dec 2023 05:43:04 +0000
Resent-Message-ID: <handler.67972.B67972.170331016119868 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 67972 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAKjtFcRRVPCixZbdgYmVkY_tOGQdFxAotD6iFi270Mk=Z2__Nw@HIDDEN>
 <83a5q2f3ls.fsf@HIDDEN>
In-Reply-To: <83a5q2f3ls.fsf@HIDDEN>
From: Nafiz Islam <nafiz.islam1001@HIDDEN>
Date: Fri, 22 Dec 2023 14:39:55 -0500
Message-ID: <CAKjtFcSnSFq8a3MW_XQ2esPtD5NgWg_i7qh8pcEmzHFsmbOSdw@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000202fdb060d1e6251"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--000000000000202fdb060d1e6251
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

That is a good idea. They could take a string or a symbol with a default
string value.
The variables shell-command-buffer-name(-async) could be declared as
defcustom instead of defconst.

On Fri, Dec 22, 2023 at 2:18=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote:

> > From: Nafiz Islam <nafiz.islam1001@HIDDEN>
> > Date: Fri, 22 Dec 2023 12:31:24 -0500
> >
> > The buffer name for the shell-command or async-shell-command would be
> much more useful if they
> > were given the name of the command being executed.
> >
> > I started working a bit on a patch for that, but it's just code changes
> right now. Here's a preview of
> > what I mean.
>
> Instead of removing the default name, why not add one more possible
> value to async-shell-command-buffer, which will do what you want?
> Then users who are interested in this behavior could customize
> async-shell-command-buffer to that new value.
>
> Thanks.
>

--000000000000202fdb060d1e6251
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>That is a good idea. They could take a string or a sy=
mbol with a default string value.</div><div>The variables shell-command-buf=
fer-name(-async) could be declared as defcustom instead of defconst.<br></d=
iv></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_att=
r">On Fri, Dec 22, 2023 at 2:18=E2=80=AFPM Eli Zaretskii &lt;<a href=3D"mai=
lto:eliz@HIDDEN">eliz@HIDDEN</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">&gt; From: Nafiz Islam &lt;<a href=3D"mailto:=
nafiz.islam1001@HIDDEN" target=3D"_blank">nafiz.islam1001@HIDDEN</a>&=
gt;<br>
&gt; Date: Fri, 22 Dec 2023 12:31:24 -0500<br>
&gt; <br>
&gt; The buffer name for the shell-command or async-shell-command would be =
much more useful if they<br>
&gt; were given the name of the command being executed.<br>
&gt; <br>
&gt; I started working a bit on a patch for that, but it&#39;s just code ch=
anges right now. Here&#39;s a preview of<br>
&gt; what I mean.<br>
<br>
Instead of removing the default name, why not add one more possible<br>
value to async-shell-command-buffer, which will do what you want?<br>
Then users who are interested in this behavior could customize<br>
async-shell-command-buffer to that new value.<br>
<br>
Thanks.<br>
</blockquote></div>

--000000000000202fdb060d1e6251--

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.