Received: (at 6806) by debbugs.gnu.org; 28 Sep 2010 18:08:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 28 14:08:14 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1P0eb8-0002TF-6k
for submit <at> debbugs.gnu.org; Tue, 28 Sep 2010 14:08:14 -0400
Received: from pantheon-po24.its.yale.edu ([130.132.50.118])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <cyd <at> stupidchicken.com>) id 1P0eb5-0002T7-Sg
for 6806 <at> debbugs.gnu.org; Tue, 28 Sep 2010 14:08:13 -0400
Received: from furry (dhcp128036014154.central.yale.edu [128.36.14.154])
(authenticated bits=0)
by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id
o8SIB2VO019746
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
Tue, 28 Sep 2010 14:11:02 -0400
Received: by furry (Postfix, from userid 1000)
id 76E6FC018; Tue, 28 Sep 2010 14:11:02 -0400 (EDT)
From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6806: Set comment-multi-line in js-mode
References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com>
<jwvy6cg6mzq.fsf-monnier+emacs <at> gnu.org>
<AANLkTi=dackW-xN=KG2jDqnm=hph7J-6PsodT7uMArSt <at> mail.gmail.com>
<jwvvd6c1j3u.fsf-monnier+emacs <at> gnu.org>
Date: Tue, 28 Sep 2010 14:11:02 -0400
In-Reply-To: <jwvvd6c1j3u.fsf-monnier+emacs <at> gnu.org> (Stefan Monnier's message
of "Sat, 11 Sep 2010 15:54:37 +0200")
Message-ID: <8762xpyc09.fsf <at> stupidchicken.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed)
X-Spam-Score: -2.7 (--)
X-Debbugs-Envelope-To: 6806
Cc: Nathan Weizenbaum <nweiz <at> google.com>, 6806 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.7 (--)
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> My fix doesn't actually fix the "/* */" issue, unfortunately. However, it
>> doesn't break "//" either; note that comment-multi-line is t for e.g.
>> c-mode, and comment-indent-new-line works for "//" there.
>
> Indeed, I misremembered. Feel free to install this patch.
The patch doesn't do the right thing. The reported problem is that if
you enter "/*" in a js-mode buffer and do M-x comment-indent-new-line,
Emacs inserts another "/*".
This problem is not limited to js-mode. It afflicts C++ also. Try
this:
C-x C-f foo.cc RET
/*
M-x comment-indent-new-line RET
Emacs inserts another /*. The reason is this stretch of code in
newcomment.el:1311:
(normalp
(string-match (regexp-quote (comment-string-strip
comment-start t t))
comstart))
(comment-end
(if normalp comment-end
;; The comment starter is not the normal comment-start
;; so we can't just use comment-end.
(save-excursion
(goto-char compos)
(if (not (comment-forward)) comment-end
(comment-string-strip
(buffer-substring
(save-excursion (comment-enter-backward) (point))
(point))
nil t)))))
When the default comment-start is "//" but the current comment begins in
"/*", this code tries to find the appropriate comment-end by doing
comment-forward. But if the comment-end "*/" is not already present in
the buffer, it fails.
Any suggestion?
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.
Received: (at 6806) by debbugs.gnu.org; 11 Sep 2010 13:52:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 11 09:52:46 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OuQVZ-0002Ti-Vt
for submit <at> debbugs.gnu.org; Sat, 11 Sep 2010 09:52:46 -0400
Received: from impaqm3.telefonica.net ([213.4.138.3])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <monnier <at> iro.umontreal.ca>) id 1OuQVX-0002TS-Sz
for 6806 <at> debbugs.gnu.org; Sat, 11 Sep 2010 09:52:44 -0400
Received: from IMPmailhost4.adm.correo ([10.20.102.125])
by IMPaqm3.telefonica.net with bizsmtp
id 5Qel1f0022iL0W23PRufnV; Sat, 11 Sep 2010 15:54:39 +0200
Received: from ceviche.home ([83.61.39.212])
by IMPmailhost4.adm.correo with BIZ IMP
id 5Rud1f0094aeRwb1kRuen5; Sat, 11 Sep 2010 15:54:39 +0200
X-Brightmail-Tracker: AAAAAA==
X-TE-authinfo: authemail="monnier$movistar.es"
|auth_email="monnier <at> movistar.es"
X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01"
Received: by ceviche.home (Postfix, from userid 20848)
id 96D56660D2; Sat, 11 Sep 2010 15:54:37 +0200 (CEST)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Nathan Weizenbaum <nweiz <at> google.com>
Subject: Re: bug#6806: Set comment-multi-line in js-mode
Message-ID: <jwvvd6c1j3u.fsf-monnier+emacs <at> gnu.org>
References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com>
<jwvy6cg6mzq.fsf-monnier+emacs <at> gnu.org>
<AANLkTi=dackW-xN=KG2jDqnm=hph7J-6PsodT7uMArSt <at> mail.gmail.com>
Date: Sat, 11 Sep 2010 15:54:37 +0200
In-Reply-To: <AANLkTi=dackW-xN=KG2jDqnm=hph7J-6PsodT7uMArSt <at> mail.gmail.com>
(Nathan Weizenbaum's message of "Mon, 9 Aug 2010 10:56:56 -0700")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.0 (--)
X-Debbugs-Envelope-To: 6806
Cc: 6806 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.0 (--)
> My fix doesn't actually fix the "/* */" issue, unfortunately. However, it
> doesn't break "//" either; note that comment-multi-line is t for e.g.
> c-mode, and comment-indent-new-line works for "//" there.
Indeed, I misremembered. Feel free to install this patch.
Stefan
> On Mon, Aug 9, 2010 at 4:33 AM, Stefan Monnier <monnier <at> iro.umontreal.ca>wrote:
>> > js-mode doesn't set the comment-multi-line variable. This results in
>> > comment-indent-new-line behaving improperly when used in a multi-line
>> > comment, which also affects auto-fill-mode, according to the
>> documentation
>> > for comment-multi-line.
>>
>> If I understand and remember correctly, this is not the right fix for
>> your problem: setting comment-multi-line to t will fix your problem with
>> "/*..*/" but will introduce another for "//....\n" and vice-versa.
>>
>>
>> Stefan
>>
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.Received: (at 6806) by debbugs.gnu.org; 9 Aug 2010 20:01:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 09 16:01:15 2010 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1OiYX5-0001X8-0O for submit <at> debbugs.gnu.org; Mon, 09 Aug 2010 16:01:15 -0400 Received: from smtp-out.google.com ([74.125.121.35]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <nweiz <at> google.com>) id 1OiWa9-0000WL-Vs for 6806 <at> debbugs.gnu.org; Mon, 09 Aug 2010 13:56:19 -0400 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id o79Huw2J012352 for <6806 <at> debbugs.gnu.org>; Mon, 9 Aug 2010 10:56:59 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1281376619; bh=DDIZ8C2p00Kwn+/ZPONjVJIC+CA=; h=MIME-Version:In-Reply-To:References:Date:Message-ID:Subject:From: To:Cc:Content-Type; b=Eqy2+4nG62liZSB2wf1UjX5GjuO4XwVuQmMO1JBTSV11CtohucbbKAimiztncCQz6 TDxjIlPViLXopHqDFFTTA== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:x-system-of-record; b=evo325Ivda48Gp1NeBgnfEancS6fiw0Jld4cXXCnvRhkDtOgJSccwdRu3nKEqADsK LS6fLvOiNjBwTgLE+Kuyw== Received: from qwc9 (qwc9.prod.google.com [10.241.193.137]) by kpbe12.cbf.corp.google.com with ESMTP id o79HuQfj026503 for <6806 <at> debbugs.gnu.org>; Mon, 9 Aug 2010 10:56:57 -0700 Received: by qwc9 with SMTP id 9so174567qwc.3 for <6806 <at> debbugs.gnu.org>; Mon, 09 Aug 2010 10:56:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.240.4 with SMTP id ky4mr7528917qcb.104.1281376617063; Mon, 09 Aug 2010 10:56:57 -0700 (PDT) Received: by 10.229.13.97 with HTTP; Mon, 9 Aug 2010 10:56:56 -0700 (PDT) In-Reply-To: <jwvy6cg6mzq.fsf-monnier+emacs <at> gnu.org> References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com> <jwvy6cg6mzq.fsf-monnier+emacs <at> gnu.org> Date: Mon, 9 Aug 2010 10:56:56 -0700 Message-ID: <AANLkTi=dackW-xN=KG2jDqnm=hph7J-6PsodT7uMArSt <at> mail.gmail.com> Subject: Re: bug#6806: Set comment-multi-line in js-mode From: Nathan Weizenbaum <nweiz <at> google.com> To: Stefan Monnier <monnier <at> iro.umontreal.ca> Content-Type: multipart/alternative; boundary=0016363b8b6c1565ac048d67be5a X-System-Of-Record: true X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 6806 X-Mailman-Approved-At: Mon, 09 Aug 2010 16:01:09 -0400 Cc: 6806 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -5.5 (-----) --0016363b8b6c1565ac048d67be5a Content-Type: text/plain; charset=ISO-8859-1 My fix doesn't actually fix the "/* */" issue, unfortunately. However, it doesn't break "//" either; note that comment-multi-line is t for e.g. c-mode, and comment-indent-new-line works for "//" there. On Mon, Aug 9, 2010 at 4:33 AM, Stefan Monnier <monnier <at> iro.umontreal.ca>wrote: > > js-mode doesn't set the comment-multi-line variable. This results in > > comment-indent-new-line behaving improperly when used in a multi-line > > comment, which also affects auto-fill-mode, according to the > documentation > > for comment-multi-line. > > If I understand and remember correctly, this is not the right fix for > your problem: setting comment-multi-line to t will fix your problem with > "/*..*/" but will introduce another for "//....\n" and vice-versa. > > > Stefan > --0016363b8b6c1565ac048d67be5a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable My fix doesn't actually fix the "/* */" issue, unfortunately.= However, it doesn't break "//" either; note that comment-mul= ti-line is t for e.g. c-mode, and comment-indent-new-line works for "/= /" there.<br> <br><div class=3D"gmail_quote">On Mon, Aug 9, 2010 at 4:33 AM, Stefan Monni= er <span dir=3D"ltr"><<a href=3D"mailto:monnier <at> iro.umontreal.ca">monnie= r <at> iro.umontreal.ca</a>></span> wrote:<br><blockquote class=3D"gmail_quot= e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"= > <div class=3D"im">> js-mode doesn't set the comment-multi-line varia= ble. This results in<br> > comment-indent-new-line behaving improperly when used in a multi-line<= br> > comment, which also affects auto-fill-mode, according to the documenta= tion<br> > for comment-multi-line.<br> <br> </div>If I understand and remember correctly, this is not the right fix for= <br> your problem: setting comment-multi-line to t will fix your problem with<br= > "/*..*/" but will introduce another for "//....\n" and = vice-versa.<br> <font color=3D"#888888"><br> <br> =A0 =A0 =A0 =A0Stefan<br> </font></blockquote></div><br> --0016363b8b6c1565ac048d67be5a--
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.
Received: (at 6806) by debbugs.gnu.org; 9 Aug 2010 15:29:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 09 11:29:53 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OiUIT-0007r1-EE
for submit <at> debbugs.gnu.org; Mon, 09 Aug 2010 11:29:53 -0400
Received: from impaqm4.telefonica.net ([213.4.138.4])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <monnier <at> iro.umontreal.ca>) id 1OiUIQ-0007qX-MB
for 6806 <at> debbugs.gnu.org; Mon, 09 Aug 2010 11:29:51 -0400
Received: from IMPmailhost2.adm.correo ([10.20.102.39])
by IMPaqm4.telefonica.net with bizsmtp
id sDww1e00F0r0BT63QFWXMp; Mon, 09 Aug 2010 17:30:31 +0200
Received: from ceviche.home ([83.40.4.203])
by IMPmailhost2.adm.correo with BIZ IMP
id sFWX1e0014NokFF1iFWXbx; Mon, 09 Aug 2010 17:30:31 +0200
X-Brightmail-Tracker: AAAAAA==
X-TE-authinfo: authemail="monnier$movistar.es"
|auth_email="monnier <at> movistar.es"
X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01"
Received: by ceviche.home (Postfix, from userid 20848)
id BA50066138; Mon, 9 Aug 2010 17:30:30 +0200 (CEST)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Nathan Weizenbaum <nweiz <at> google.com>
Subject: Re: bug#6806: Set comment-multi-line in js-mode
In-Reply-To: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com>
(Nathan Weizenbaum's message of "Thu, 5 Aug 2010 11:36:41 -0700")
Date: Mon, 09 Aug 2010 13:33:23 +0200
Message-ID: <jwvy6cg6mzq.fsf-monnier+emacs <at> gnu.org>
References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 6806
Cc: 6806 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.8 (-)
> js-mode doesn't set the comment-multi-line variable. This results in
> comment-indent-new-line behaving improperly when used in a multi-line
> comment, which also affects auto-fill-mode, according to the documentation
> for comment-multi-line.
If I understand and remember correctly, this is not the right fix for
your problem: setting comment-multi-line to t will fix your problem with
"/*..*/" but will introduce another for "//....\n" and vice-versa.
Stefan
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.Received: (at 6806) by debbugs.gnu.org; 9 Aug 2010 00:30:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 08 20:30:28 2010 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1OiGG3-00009D-NJ for submit <at> debbugs.gnu.org; Sun, 08 Aug 2010 20:30:28 -0400 Received: from smtp-out.google.com ([74.125.121.35]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <nweiz <at> google.com>) id 1OiFzj-0008ST-9X for 6806 <at> debbugs.gnu.org; Sun, 08 Aug 2010 20:13:36 -0400 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id o790EEho013814 for <6806 <at> debbugs.gnu.org>; Sun, 8 Aug 2010 17:14:14 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1281312854; bh=jTHtM4+DGy2f6M8AmZ2lkfBuQf4=; h=MIME-Version:In-Reply-To:References:Date:Message-ID:Subject:From: To:Cc:Content-Type; b=t217o2FZzCeNeTogtEpdPShKsTPLkEPXe514JSdaTFbPH0pNA2z3wcIsb2bIthhMv pzteHZrIvXbtrwwW5fp6A== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:x-system-of-record; b=sFk9/8/T2s4PXXE5Adrk1vW6+J1J15drTQBSCxgzVdgKGe+lQH215+XwyZve+2I3k 6QwG3uMZV9JvMwjwJDJAg== Received: from qwd6 (qwd6.prod.google.com [10.241.193.198]) by wpaz37.hot.corp.google.com with ESMTP id o790DiEd018732 for <6806 <at> debbugs.gnu.org>; Sun, 8 Aug 2010 17:14:13 -0700 Received: by qwd6 with SMTP id 6so6657284qwd.30 for <6806 <at> debbugs.gnu.org>; Sun, 08 Aug 2010 17:14:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.78.194 with SMTP id m2mr7775856qak.19.1281312852624; Sun, 08 Aug 2010 17:14:12 -0700 (PDT) Received: by 10.229.13.97 with HTTP; Sun, 8 Aug 2010 17:14:12 -0700 (PDT) In-Reply-To: <87ocdcvnx6.fsf <at> stupidchicken.com> References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com> <87ocdcvnx6.fsf <at> stupidchicken.com> Date: Sun, 8 Aug 2010 17:14:12 -0700 Message-ID: <AANLkTik56gY5ur8Q8nrZVYB3u8nw=5p7HDEyPita5mY+@mail.gmail.com> Subject: Re: bug#6806: Set comment-multi-line in js-mode From: Nathan Weizenbaum <nweiz <at> google.com> To: Chong Yidong <cyd <at> stupidchicken.com> Content-Type: multipart/alternative; boundary=00c09f986a126d47fb048d58e52a X-System-Of-Record: true X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 6806 X-Mailman-Approved-At: Sun, 08 Aug 2010 20:30:26 -0400 Cc: 6806 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -4.8 (----) --00c09f986a126d47fb048d58e52a Content-Type: text/plain; charset=ISO-8859-1 Open a new Javascript file. Type "/*". Run M-x comment-indent-new-line. This inserts "\n /*", which is incorrect. Now that I try to reproduce my fix, though, it doesn't seem to work. I'm not sure what the proper solution is. On Sun, Aug 8, 2010 at 1:40 PM, Chong Yidong <cyd <at> stupidchicken.com> wrote: > Nathan Weizenbaum <nweiz <at> google.com> writes: > > > js-mode doesn't set the comment-multi-line variable. This results in > > comment-indent-new-line behaving improperly when used in a multi-line > comment, > > which also affects auto-fill-mode, according to the documentation for > > comment-multi-line. > > > > Attached is a patch that sets the variable. > > Could you provide a precise recipe for the problem? > --00c09f986a126d47fb048d58e52a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Open a new Javascript file. Type "/*". Run M-x comment-indent-new= -line. This inserts "\n =A0/*", which is incorrect.<div><br></div= ><div>Now that I try to reproduce my fix, though, it doesn't seem to wo= rk. I'm not sure what the proper solution is.<br> <br><div class=3D"gmail_quote">On Sun, Aug 8, 2010 at 1:40 PM, Chong Yidong= <span dir=3D"ltr"><<a href=3D"mailto:cyd <at> stupidchicken.com">cyd <at> stupidc= hicken.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style= =3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Nathan Weizenbaum <<a href=3D"mailto:nweiz <at> google.com">nweiz <at> google.com<= /a>> writes:<br> <br> > js-mode doesn't set the comment-multi-line variable. This results = in<br> > comment-indent-new-line behaving improperly when used in a multi-line = comment,<br> > which also affects auto-fill-mode, according to the documentation for<= br> > comment-multi-line.<br> ><br> > Attached is a patch that sets the variable.<br> <br> Could you provide a precise recipe for the problem?<br> </blockquote></div><br></div> --00c09f986a126d47fb048d58e52a--
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.Received: (at 6806) by debbugs.gnu.org; 8 Aug 2010 20:39:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 08 16:39:28 2010 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1OiCeW-0004Og-K3 for submit <at> debbugs.gnu.org; Sun, 08 Aug 2010 16:39:28 -0400 Received: from pantheon-po45.its.yale.edu ([130.132.50.79]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <cyd <at> stupidchicken.com>) id 1OiCeU-0004Oa-BE for 6806 <at> debbugs.gnu.org; Sun, 08 Aug 2010 16:39:26 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po45.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o78Ke57H007610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 8 Aug 2010 16:40:06 -0400 Received: by furry (Postfix, from userid 1000) id B93F0C013; Sun, 8 Aug 2010 16:40:05 -0400 (EDT) From: Chong Yidong <cyd <at> stupidchicken.com> To: Nathan Weizenbaum <nweiz <at> google.com> Subject: Re: bug#6806: Set comment-multi-line in js-mode References: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com> Date: Sun, 08 Aug 2010 16:40:05 -0400 In-Reply-To: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com> (Nathan Weizenbaum's message of "Thu, 5 Aug 2010 11:36:41 -0700") Message-ID: <87ocdcvnx6.fsf <at> stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 6806 Cc: 6806 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.6 (--) Nathan Weizenbaum <nweiz <at> google.com> writes: > js-mode doesn't set the comment-multi-line variable. This results in > comment-indent-new-line behaving improperly when used in a multi-line comment, > which also affects auto-fill-mode, according to the documentation for > comment-multi-line. > > Attached is a patch that sets the variable. Could you provide a precise recipe for the problem?
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 5 Aug 2010 20:08:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 05 16:08:41 2010 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1Oh6k5-0005LA-8H for submit <at> debbugs.gnu.org; Thu, 05 Aug 2010 16:08:41 -0400 Received: from smtp-out.google.com ([74.125.121.35]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <nweiz <at> google.com>) id 1Oh5Ia-0004gG-G8 for submit <at> debbugs.gnu.org; Thu, 05 Aug 2010 14:36:13 -0400 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id o75Iah6Z010173 for <submit <at> debbugs.gnu.org>; Thu, 5 Aug 2010 11:36:43 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1281033403; bh=6LBooVCoSUGmf9zIuqFToMmizMk=; h=MIME-Version:Date:Message-ID:Subject:From:To:Content-Type; b=c1T0fWtOIQB2hhon6hb25qa9ik3sJ3bPMY41WlXtS8FO+SPvINWcK41MekPO7vP1z /ZXdzGmEJ641ckdgQ/XyQ== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:date:message-id:subject:from:to:content-type:x-system-of-record; b=c62epSPod4xycVnlqnpP8G9IFy2XDMnoYUzVIJ9B4hhxv9ew2Ba6K+0ht5ht+cOK5 7XQAw7eYzziW9Z+i2xzPw== Received: from qwk4 (qwk4.prod.google.com [10.241.195.132]) by kpbe12.cbf.corp.google.com with ESMTP id o75Iaf6r021977 for <submit <at> debbugs.gnu.org>; Thu, 5 Aug 2010 11:36:42 -0700 Received: by qwk4 with SMTP id 4so4899133qwk.0 for <submit <at> debbugs.gnu.org>; Thu, 05 Aug 2010 11:36:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.231.11 with SMTP id jo11mr3849721qcb.66.1281033401351; Thu, 05 Aug 2010 11:36:41 -0700 (PDT) Received: by 10.229.13.97 with HTTP; Thu, 5 Aug 2010 11:36:41 -0700 (PDT) Date: Thu, 5 Aug 2010 11:36:41 -0700 Message-ID: <AANLkTikqhGd0Chywz+X=giddjPJkVVK0Ca81xuoakX67 <at> mail.gmail.com> Subject: Set comment-multi-line in js-mode From: Nathan Weizenbaum <nweiz <at> google.com> To: submit <at> debbugs.gnu.org Content-Type: multipart/mixed; boundary=00163630f4bbd54323048d17d41f X-System-Of-Record: true X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 05 Aug 2010 16:08:36 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.3 (-) --00163630f4bbd54323048d17d41f Content-Type: multipart/alternative; boundary=00163630f4bbd54315048d17d41d --00163630f4bbd54315048d17d41d Content-Type: text/plain; charset=ISO-8859-1 Package: emacs Version: 24.0.50.1 js-mode doesn't set the comment-multi-line variable. This results in comment-indent-new-line behaving improperly when used in a multi-line comment, which also affects auto-fill-mode, according to the documentation for comment-multi-line. Attached is a patch that sets the variable. --00163630f4bbd54315048d17d41d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Package: emacs<div>Version: 24.0.50.1</div><div><br></div><div>js-mode does= n't set the comment-multi-line variable. This results in comment-indent= -new-line behaving improperly when used in a multi-line comment, which also= affects auto-fill-mode, according to the documentation for comment-multi-l= ine.</div> <div><br></div><div>Attached is a patch that sets the variable.</div> --00163630f4bbd54315048d17d41d-- --00163630f4bbd54323048d17d41f Content-Type: text/x-patch; charset=US-ASCII; name="0001-Set-comment-multi-line-in-js-mode.patch" Content-Disposition: attachment; filename="0001-Set-comment-multi-line-in-js-mode.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gchy6ni70 RnJvbSAyNzdkOTZjNjJjZGZiOGIxZDg2MjYzMTcyNGY2NzUxODE1MjU4OGYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW4gV2VpemVuYmF1bSA8bmV4MzQyQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAzIEF1ZyAyMDEwIDE3OjQ2OjMzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gU2V0 IGNvbW1lbnQtbXVsdGktbGluZSBpbiBqcy1tb2RlLgoKLS0tCiBsaXNwL3Byb2dtb2Rlcy9qcy5l bCB8ICAgIDEgKwogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvanMuZWwgYi9saXNwL3Byb2dtb2Rlcy9q cy5lbAppbmRleCA2YmQ4ZmJjLi4wMjNkMjUzIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9q cy5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9qcy5lbApAQCAtMzMwMiw2ICszMzAyLDcgQEAgS2V5 IGJpbmRpbmdzOgogICAoc2V0cSBjb21tZW50LWVuZCAiIikKICAgKHNldCAobWFrZS1sb2NhbC12 YXJpYWJsZSAnZmlsbC1wYXJhZ3JhcGgtZnVuY3Rpb24pCiAgICAgICAgJ2pzLWMtZmlsbC1wYXJh Z3JhcGgpCisgIChzZXQgKG1ha2UtbG9jYWwtdmFyaWFibGUgJ2NvbW1lbnQtbXVsdGktbGluZSkg dCkKIAogICA7OyBQYXJzZSBjYWNoZQogICAoYWRkLWhvb2sgJ2JlZm9yZS1jaGFuZ2UtZnVuY3Rp b25zICMnanMtLWZsdXNoLWNhY2hlcyB0IHQpCi0tIAoxLjcuMQoK --00163630f4bbd54323048d17d41f--
Nathan Weizenbaum <nweiz <at> google.com>:bug-gnu-emacs <at> gnu.org.
Full text available.owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#6806; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.