GNU bug report logs - #68439
icewm do not install MO files.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68439 in the body.
You can then email your comments to 68439 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: "guix-bug" <bug-guix <at> gnu.org>
Cc: iyzsong <at> member.fsf.org, atai <at> atai.org
Subject: icewm do not install MO files.
Date: Sun, 14 Jan 2024 11:08:37 +0800

Hello:

At the moment: icewm do not install MO files to
'share/locale/<lang>/LC_MESSAGES', gmo files in tarball are removed, but
do not re-generated, I try to add gettext-minimul to inputs, but can not
re-generate gmo files successfully.

Any reason we should remove gmo files in tarball?

```
               (add-after 'unpack 'remove-gmo-files
                 ;; gmo files are generated from .po files
                 ;; so remove them before build to make sure
                 ;; they are re-generated if needed
                 (lambda _
                   (for-each delete-file
                             (find-files "po" "\\.gmo$"))))
```


-- 

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Feng Shu <tumashu <at> 163.com>
Cc: iyzsong <at> member.fsf.org, guix-bug <bug-guix <at> gnu.org>
Subject: Re: icewm do not install MO files.
Date: Sun, 14 Jan 2024 22:17:26 -0800

I remember that was left over and kept from previous patches. If they
are not rebuilt there is a bug

I will remove these lines in the next update to the next version,
unless there is objection.

On Sat, Jan 13, 2024 at 7:08 PM Feng Shu <tumashu <at> 163.com> wrote:
>
>
> Hello:
>
> At the moment: icewm do not install MO files to
> 'share/locale/<lang>/LC_MESSAGES', gmo files in tarball are removed, but
> do not re-generated, I try to add gettext-minimul to inputs, but can not
> re-generate gmo files successfully.
>
> Any reason we should remove gmo files in tarball?
>
> ```
>                (add-after 'unpack 'remove-gmo-files
>                  ;; gmo files are generated from .po files
>                  ;; so remove them before build to make sure
>                  ;; they are re-generated if needed
>                  (lambda _
>                    (for-each delete-file
>                              (find-files "po" "\\.gmo$"))))
> ```
>
>
> --
>

Message #11 received at 68439 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 68439 <at> debbugs.gnu.org,
	69793 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2] gnu: icewm: Update to 3.4.6
Date: Mon, 25 Mar 2024 06:55:46 -0700

* gnu/packages/wm.scm (icewm): Update to 3.4.6
  [arguments]: Remove the deletion of gmo files as
  they are not regenerated correctly.

Change-Id: Ieff1fc5417cfe164fa7886774e8855fd95248c8f
---
 gnu/packages/wm.scm | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 7d21d04094..65378040e5 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -797,7 +797,7 @@ (define-public i3lock-fancy
 (define-public icewm
   (package
     (name "icewm")
-    (version "3.4.5")
+    (version "3.4.6")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -805,7 +805,7 @@ (define-public icewm
                     version "/icewm-" version ".tar.lz"))
               (sha256
                (base32
-                "1wd5k0whh2b43a72223cy19pwc29fhrhd2dnc61fha2y5ndgw6ld"))))
+                "1j4jd1fim12h8ry7jkx6y298kyn63pabih1m61rljbzvr3lyy1db"))))
     (build-system gnu-build-system)
     (native-inputs (list pkg-config))
     (inputs (list fontconfig
@@ -830,13 +830,6 @@ (define-public icewm
     (arguments
      (list #:phases
            #~(modify-phases %standard-phases
-               (add-after 'unpack 'remove-gmo-files
-                 ;; gmo files are generated from .po files
-                 ;; so remove them before build to make sure
-                 ;; they are re-generated if needed
-                 (lambda _
-                   (for-each delete-file
-                             (find-files "po" "\\.gmo$"))))
                (add-after 'unpack 'skip-failing-test
                  ;; strtest.cc tests failing due to $HOME and /etc setup
                  ;; difference under guix

base-commit: 1415ea78c15043ddc9d3d3dfe9219a4160493bf1
-- 
2.34.1

Message #16 received at 68439-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andy Tai <atai <at> atai.org>
Cc: 68439-done <at> debbugs.gnu.org, guix-patches <at> gnu.org,
 69793-done <at> debbugs.gnu.org
Subject: Re: [bug#69793] [PATCH] gnu: icewm: Update to 3.4.6
Date: Wed, 27 Mar 2024 12:59:24 +0000

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/wm.scm (icewm): Update to 3.4.6
>
> Change-Id: Ieff1fc5417cfe164fa7886774e8855fd95248c8f
> ---
>  gnu/packages/wm.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks both, I've pushed this to master as
8cc450e59a4c83fa39097964f62c2b2c84e0aee3.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.