Received: (at 68469) by debbugs.gnu.org; 16 Jan 2024 07:11:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 16 02:11:39 2024
Received: from localhost ([127.0.0.1]:47573 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPdbm-0000Xy-MW
for submit <at> debbugs.gnu.org; Tue, 16 Jan 2024 02:11:39 -0500
Received: from sendmail.purelymail.com ([34.202.193.197]:51960)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <lilah@HIDDEN>) id 1rPdbi-0000Xj-3X
for 68469 <at> debbugs.gnu.org; Tue, 16 Jan 2024 02:11:37 -0500
DKIM-Signature: a=rsa-sha256;
b=dhc3tpQBXlOCcmuZ6h3Mupeb/X5W8yCWDOtHPdsxcRJ2dpSh3bfQmdx+UjJQ3R9mzgIzLkeEAEZryIAyczW6a9ISzf9Z/fYy+AfL8823e1LP9coaIJ9EYEFxh5JglY3X7TNq/Pmm8TBlidW/knHR4UxR40hDJwTB62Wdi5BaWKQwI78vv+EWxRUA9V/0N6SANYZjkg7zQYIxWO+ULk14/xre8jxEFb0+8NCq6o8CQHGgwDp62AGggjh/7/7Q3RvzLhW7LWC5z+HivCySlfxM94H/U1Nwy0DLNhP7mQ36ZKLO2rezBEUb1z3WkDdBd7s7e9sjk6tKbVzgqjseZLB/gw==;
s=purelymail1; d=lunabee.space; v=1;
bh=wAaxP54Xmp+7692kcjUpA9YYpZaMHgQ0EJafmDT4MCI=; h=Received:Subject:From:To;
DKIM-Signature: a=rsa-sha256;
b=qR4ZSixBVGBDzpx8+ae4RuY7UMqEswWitQJkzBAxXsPCB2yvwdbVMDyjJ/nVF2Rqg4ZQQWEcREoLB8T3u6P2ElnB4rswciCLaxJ1rZ56jehR5d2HIraFwVlFCK+78ZwPoHKV9Iv2JkYYlFvy2yrPEn2kBVIdXKnfNly6wzh49svYHPUXTMQollB7+7kEFdtxlqaqH77SWgo1TNyjw6/anm8KwdJj2y4jnrMJI+49nmohBwSy0S2hS08pW4KITyEmbRrZqfZGze+sgv9xmGfrVQkO+HQIqDOYtVqO598Bojv1zcfujYaJcSolFFik5l/3gtSEayBDcU0buW01kgGukA==;
s=purelymail1; d=purelymail.com; v=1;
bh=wAaxP54Xmp+7692kcjUpA9YYpZaMHgQ0EJafmDT4MCI=;
h=Feedback-ID:Received:Subject:From:To;
Feedback-ID: 8937:2070:null:purelymail
X-Pm-Original-To: 68469 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1859612148
for <68469 <at> debbugs.gnu.org>
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Tue, 16 Jan 2024 07:11:25 +0000 (UTC)
Message-ID: <fbd22fd4047a226f0b96d2218e6e51029f8a116a.camel@HIDDEN>
Subject: Re: [PATCH] gnu: Add melonds.
From: Lilah Tascheter <lilah@HIDDEN>
To: 68469 <at> debbugs.gnu.org
Date: Tue, 16 Jan 2024 01:11:23 -0600
Organization: Dissociation for Heresiographal Computation
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68469
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
hi!
great patch!! :)
there's a few small issues I found:
* the source hash line is too long, style guide says lines shouldn't
exceed 80 cols.
* melonds doesn't actually require curl and gnutls. no clue why their
README says it does. I've verified it compiles without them.
* melonds secretly bundles in pre-compiled DS firmware in
src/FreeBIOS.h. they do, however, provide source, but our buildscript
shouldn't rely on bundled blobs.
I took the liberty of attaching an edited patch. hope that's alright!
- lilah
---
gnu/packages/emulators.scm | 64 ++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index cde3ee052c..0f7962115d 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -21,6 +21,7 @@
;;; Copyright =C2=A9 2023 Yovan Naumovski <yovan@HIDDEN>
;;; Copyright =C2=A9 2023 Hendursaga <hendursaga@HIDDEN>
;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@HIDDEN>
+;;; Copyright =C2=A9 2024 Altadil <altadil@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -81,6 +82,7 @@ (define-module (gnu packages emulators)
#:use-module (gnu packages graphics)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image)
+ #:use-module (gnu packages kde-frameworks)
#:use-module (gnu packages libedit)
#:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
@@ -102,6 +104,7 @@ (define-module (gnu packages emulators)
#:use-module (gnu packages tls)
#:use-module (gnu packages upnp)
#:use-module (gnu packages video)
+ #:use-module (gnu packages vim)
#:use-module (gnu packages vulkan)
#:use-module (gnu packages xdisorg)
#:use-module (gnu packages xiph)
@@ -733,6 +736,67 @@ (define-public mednafen
;; Main license is GPL2+. Some parts are BSD-3.
(license (list license:gpl2+ license:bsd-3))))
=20
+(define-public melonds
+ (package
+ (name "melonds")
+ (version "0.9.5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/melonDS-emu/melonDS")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0c4hhs5mffj43pa2y18k70q6szc09m8yj0gqw2svszpvpz2n91cz"))=
))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f ; No test target available.
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-before 'configure 'compile-bios
+ (lambda* (#:key inputs #:allow-other-keys)
+ (define (as arm arch)
+ (invoke "arm-none-eabi-gcc"
+ "-c" "freebios/bios_common.S"
+ (string-append "-march=3Darmv" arch)
+ (string-append "-DBIOS_ARM" arm)
+ "-o" (string-append "bios_arm" arm ".o"))
+ (invoke "arm-none-eabi-objcopy"
+ "-O" "binary"
+ (string-append "bios_arm" arm ".o")
+ (string-append "bios_arm" arm ".bin")))
+
+ (as "7" "4t")
+ (as "9" "5te")
+ (with-output-to-file "src/FreeBIOS.h"
+ (lambda ()
+ (display "#ifndef FREEBIOS_H\n#define FREEBIOS_H\n=
")
+ (invoke "xxd" "-i" "bios_arm7.bin")
+ (invoke "xxd" "-i" "bios_arm9.bin")
+ (display "#endif\n"))))))))
+ (native-inputs (list (cross-gcc "arm-none-eabi")
+ (cross-binutils "arm-none-eabi")
+ extra-cmake-modules
+ pkg-config
+ xxd))
+ (inputs (list libarchive
+ libpcap
+ libslirp
+ qtbase-5
+ qtmultimedia-5
+ sdl2
+ wayland
+ zstd))
+ (synopsis "DS emulator")
+ (description "melonDS is an emulator of the Nintendo DS. It aims at
+providing fast and accurate emulation. While it is still a work in progre=
ss,
+it has a pretty solid set of features, includind a nearly complete core, a=
JIT
+recompiler for fast emulation, an OpenGL renderer, joystick support and
+savestates.")
+ (home-page "https://melonds.kuribo64.net/")
+ (license license:gpl3+)))
+
(define-public mgba
(package
(name "mgba")
base-commit: 21f5d20d68e0359f8111ccb936905649c70db9c1
--=20
2.41.0
guix-patches@HIDDEN:bug#68469; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 15 Jan 2024 12:48:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 07:48:31 2024
Received: from localhost ([127.0.0.1]:44895 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPMOF-0001pd-An
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 07:48:31 -0500
Received: from lists.gnu.org ([2001:470:142::17]:33998)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <Altadil@HIDDEN>) id 1rPMOD-0001om-6l
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 07:48:30 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Altadil@HIDDEN>)
id 1rPMO3-0000P6-UP
for guix-patches@HIDDEN; Mon, 15 Jan 2024 07:48:23 -0500
Received: from mail-40134.protonmail.ch ([185.70.40.134])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Altadil@HIDDEN>)
id 1rPMO1-0005Gm-7e
for guix-patches@HIDDEN; Mon, 15 Jan 2024 07:48:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1705322886; x=1705582086;
bh=l1RLLMYK2sSln4HfZoqXFGhbZGvcKySJeIySSud76Xs=;
h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;
b=sjyhZQAAX4Hlzv7GQwFmIsvhXFtOFAKLISlg0ivCBcgth7lmmquTrflT3A6c6CPMT
35qvtDcM9BwNed8OVohvTuoIYJeXCuAOBxiIe0EV0viaQ5sSCehTPI3/V1J02cIV0k
/mgkcYlX8bHpdSVt65aF3SjGmoM2FML0hdcdMKhjp/huvcbk4RDJG5OUQLSwmQLBur
H9tpVI/R30JRM7viPLnxwJNhwtgU/wWDk1ADamOc90ItmQYgH0aMltrNGLKhSmN0Db
Dw5M5YNczO6M7CsjIXg1pPsaethVyyPIr5chgC6hfFRtkrj/iDX1F2tFDtAnvJktBg
Ft5sahBovfRDg==
Date: Mon, 15 Jan 2024 12:47:53 +0000
To: guix-patches@HIDDEN
From: altadil <Altadil@HIDDEN>
Subject: [PATCH] gnu: Add melonds.
Message-ID: <30c6be832a2771676f848a79e2ac47ff23af69fe.1705322704.git.altadil@HIDDEN>
Feedback-ID: 3841829:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.134;
envelope-from=Altadil@HIDDEN; helo=mail-40134.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: altadil <altadil@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
* gnu/packages/emulators.scm (melonds): New variable.
Change-Id: I8f7d31686fe5c9860acd86eb5740933218ca2910
---
guix build --no-grafts --check --rounds=3D2 --system=3Dx86_64-linux was
run successfully on a Zen4 CPU.
gnu/packages/emulators.scm | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index cde3ee052c..a0235e572b 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -21,6 +21,7 @@
;;; Copyright =C2=A9 2023 Yovan Naumovski <yovan@HIDDEN>
;;; Copyright =C2=A9 2023 Hendursaga <hendursaga@HIDDEN>
;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@HIDDEN>
+;;; Copyright =C2=A9 2024 Altadil <altadil@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -81,6 +82,7 @@ (define-module (gnu packages emulators)
#:use-module (gnu packages graphics)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image)
+ #:use-module (gnu packages kde-frameworks)
#:use-module (gnu packages libedit)
#:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
@@ -733,6 +735,39 @@ (define-public mednafen
;; Main license is GPL2+. Some parts are BSD-3.
(license (list license:gpl2+ license:bsd-3))))
=20
+(define-public melonds
+ (package
+ (name "melonds")
+ (version "0.9.5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/melonDS-emu/melonDS")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256 (base32 "0c4hhs5mffj43pa2y18k70q6szc09m8yj0gqw2svszp=
vpz2n91cz"))))
+ (build-system cmake-build-system)
+ (arguments (list #:tests? #f)) ; No test target available.
+ (native-inputs (list extra-cmake-modules pkg-config))
+ (inputs (list curl
+ gnutls
+ libarchive
+ libpcap
+ libslirp
+ qtbase-5
+ qtmultimedia-5
+ sdl2
+ wayland
+ zstd))
+ (synopsis "DS emulator")
+ (description "melonDS is an emulator of the Nintendo DS. It aims at
+providing fast and accurate emulation. While it is still a work in progre=
ss,
+it has a pretty solid set of features, includind a nearly complete core, a=
JIT
+recompiler for fast emulation, an OpenGL renderer, joystick support and
+savestates.")
+ (home-page "https://melonds.kuribo64.net/")
+ (license license:gpl3+)))
+
(define-public mgba
(package
(name "mgba")
base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
--=20
2.41.0
altadil <Altadil@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#68469; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.