GNU logs - #68606, boring messages

Message sent to andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#68606] [PATCH 0/2] Update GDAL and build Java bindings.
Resent-From: Roman Scherer <roman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 20 Jan 2024 11:30:02 +0000
Resent-Message-ID: <handler.68606.B.170575020028082 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68606 <at> debbugs.gnu.org
Cc: Roman Scherer <roman@HIDDEN>, Andreas Enge <andreas@HIDDEN>, Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Roman Scherer <roman@HIDDEN>
Date: Sat, 20 Jan 2024 12:29:38 +0100
Message-ID: <cover.1705747715.git.roman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: none client-ip=2a00:1450:4864:20::52e;
 envelope-from=roman@HIDDEN; helo=mail-ed1-x52e.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello Guix,

this patch series updates GDAL to v3.8.3 and builds the Java bindings.

While updating GDL I run into issues with the validate-runpath phase. I could
not get it passing by tweaking the cmake build flags. For some reason the
Pyhton bindings did not pick up the right runtime path and the
validate-runpath phase failed. After looking around a bit I saw this can be
manually fixed with patchelf. I tested the Python and Java bindings by
importing GDAL and registering all drivers.

I also had to remove the deletion of frmts/zlib since the cmake build file
adds a library under that path. Tweaking the build file to remove adding the
library caused the build to fail.

Could you please review the patche series?

Thanks, Roman.

Roman Scherer (2):
  gnu: gdal: Update to 3.8.3.
  gnu: gdal: Build Java bindings.

 gnu/packages/geo.scm | 44 +++++++++++++++++++++++++++++++++++---------
 1 file changed, 35 insertions(+), 9 deletions(-)

base-commit: 0eadd486484fcf9a234758842f74ba28361640db
--
2.34.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Roman Scherer <roman@HIDDEN>
Subject: bug#68606: Acknowledgement ([PATCH 0/2] Update GDAL and build
 Java bindings.)
Message-ID: <handler.68606.B.170575020028082.ack <at> debbugs.gnu.org>
References: <cover.1705747715.git.roman@HIDDEN>
X-Gnu-PR-Message: ack 68606
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 68606 <at> debbugs.gnu.org
Date: Sat, 20 Jan 2024 11:30:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Andreas Enge <andreas@HIDDEN>, Efraim Flashner <efraim@HIDDEN>, =
Eric Bavier <bavier@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 68606 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
68606: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68606
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#68606] [PATCH 1/2] gnu: gdal: Update to 3.8.3.
Resent-From: Roman Scherer <roman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 20 Jan 2024 11:31:02 +0000
Resent-Message-ID: <handler.68606.B68606.1705750242789 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68606 <at> debbugs.gnu.org
Cc: Roman Scherer <roman@HIDDEN>, Andreas Enge <andreas@HIDDEN>, Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Roman Scherer <roman@HIDDEN>
Date: Sat, 20 Jan 2024 12:30:25 +0100
Message-ID: <056f13e780254afc311925b568d747eeba65db27.1705747715.git.roman@HIDDEN>
In-Reply-To: <cover.1705747715.git.roman@HIDDEN>
References: <cover.1705747715.git.roman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/geo.scm (gdal): Update to 3.8.3.

Change-Id: Ib36177e1cb37e3852475cc0c1da3eb8747aac6d5
---
 gnu/packages/geo.scm | 36 ++++++++++++++++++++++++++++--------
 1 file changed, 28 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 14e2d9f16b..3c82f2f3af 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -1172,7 +1172,7 @@ (define-public spatialite-gui
 (define-public gdal
   (package
     (name "gdal")
-    (version "3.6.1")
+    (version "3.8.3")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -1180,7 +1180,7 @@ (define-public gdal
                      version ".tar.gz"))
               (sha256
                (base32
-                "1qckwnygszxkkq40bf87s3m1sab6jj9jyakdvskh0qf7dq8zjarf"))
+                "1sj9l1hjfs5d0mnv71iy8zk2xprn46h8gxq0cai9v7i3m23h78zp"))
               (modules '((guix build utils)))
               (snippet
                 `(begin
@@ -1193,14 +1193,33 @@ (define-public gdal
                        "frmts/jpeg/libjpeg12"
                        "frmts/gtiff/libtiff"
                        "frmts/gtiff/libgeotiff"
-                       "frmts/zlib"
                        "ogr/ogrsf_frmts/geojson/libjson"))))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f
-       #:configure-flags
-       (list "-DGDAL_USE_INTERNAL_LIBS=WHEN_NO_EXTERNAL"
-             "-DGDAL_USE_JPEG12_INTERNAL=OFF")))
+     (list
+      #:tests? #f
+      #:configure-flags
+      #~(list "-DGDAL_USE_INTERNAL_LIBS=WHEN_NO_EXTERNAL"
+              "-DGDAL_USE_JPEG12_INTERNAL=OFF")
+      #:modules '((guix build cmake-build-system)
+                  (guix build utils)
+                  (ice-9 rdelim)
+                  (ice-9 popen))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'fix-rpath
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((libdir (string-append (assoc-ref outputs "out") "/lib")))
+                (for-each
+                 (lambda (file)
+                   (let* ((pipe (open-pipe* OPEN_READ "patchelf"
+                                            "--print-rpath" file))
+                          (line (read-line pipe)))
+                     (and (zero? (close-pipe pipe))
+                          (invoke "patchelf" "--set-rpath"
+                                  (string-append libdir ":" line)
+                                  file))))
+                 (find-files libdir ".*\\.so$"))))))))
     (inputs
      (list curl
            expat
@@ -1227,7 +1246,8 @@ (define-public gdal
            zlib
            zstd))
     (native-inputs
-     (list pkg-config
+     (list patchelf
+           pkg-config
            python))
     (propagated-inputs
      (list python-numpy))
-- 
2.34.1

Message sent to andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#68606] [PATCH 2/2] gnu: gdal: Build Java bindings.
Resent-From: Roman Scherer <roman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 20 Jan 2024 11:31:02 +0000
Resent-Message-ID: <handler.68606.B68606.17057502471118 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68606 <at> debbugs.gnu.org
Cc: Roman Scherer <roman@HIDDEN>, Andreas Enge <andreas@HIDDEN>, Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Roman Scherer <roman@HIDDEN>
Date: Sat, 20 Jan 2024 12:30:26 +0100
Message-ID: <c9fffde5552831398ceb0732d4fa80b49d904860.1705747715.git.roman@HIDDEN>
In-Reply-To: <cover.1705747715.git.roman@HIDDEN>
References: <cover.1705747715.git.roman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/geo.scm (gdal): Build Java bindings.

Change-Id: I6c6a6d4b5f7c6692d443d8ebf288dfe6c4ccad87
---
 gnu/packages/geo.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 3c82f2f3af..d2d78197c3 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -1207,6 +1207,10 @@ (define-public gdal
                   (ice-9 popen))
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'set-JAVA_HOME
+            (lambda* (#:key inputs #:allow-other-keys)
+              (let ((jdk (assoc-ref inputs "jdk")))
+                (setenv "JAVA_HOME" jdk))))
           (add-after 'install 'fix-rpath
             (lambda* (#:key outputs #:allow-other-keys)
               (let ((libdir (string-append (assoc-ref outputs "out") "/lib")))
@@ -1246,9 +1250,11 @@ (define-public gdal
            zlib
            zstd))
     (native-inputs
-     (list patchelf
-           pkg-config
-           python))
+     `(("ant" ,ant)
+       ("jdk" ,openjdk11 "jdk")
+       ("patchelf" ,patchelf)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
     (propagated-inputs
      (list python-numpy))
     (home-page "https://gdal.org/")
-- 
2.34.1

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.