Received: (at 68891) by debbugs.gnu.org; 22 Feb 2024 11:14:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 22 06:14:10 2024 Received: from localhost ([127.0.0.1]:46130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rd71m-0005gj-3u for submit <at> debbugs.gnu.org; Thu, 22 Feb 2024 06:14:10 -0500 Received: from msg-1.mailo.com ([213.182.54.11]:52972 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rd71j-0005fz-L9 for 68891 <at> debbugs.gnu.org; Thu, 22 Feb 2024 06:14:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1708599187; bh=jzVcPL6Ci53FMnxe/pDLRsqFg1Mw719GLMvcykgFpcQ=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=sliEKkZJQ7+1UGDmtoIv8WdYYugeJYS4FdX1HVLiLTjgXqFl/DQ1ECqxXlUanH2zN 2Zt48goKQLOX80xnerFNXR6yLMm9j/fw3K0TNVVD04QYzkCCziF9rzmwWVFifhUQGt UV3zrSvLCQu0ejbXxYi0uVCLPrIbdXm93Z+13Kc4= Received: by b221-2.in.mailobj.net [192.168.90.22] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 22 Feb 2024 11:53:02 +0100 (CET) X-EA-Auth: NY2QvWJUhHG45UH3FVBIzeFKBrIXlLbzjE5o3DvhFitvEpu+vQA7guI6K3nRf1/6PW89FIRkobnZc9hNmHTsLIMwUiwbIElNdsVNwXVwdRI= From: Nicolas Goaziou <mail@HIDDEN> To: Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. In-Reply-To: <87eddgv6i1.fsf@HIDDEN> (Cayetano Santos via Guix-patches via's message of "Tue, 13 Feb 2024 14:18:02 +0100") References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> <87plx0boch.fsf@HIDDEN> <87eddgv6i1.fsf@HIDDEN> Date: Thu, 22 Feb 2024 11:52:46 +0100 Message-ID: <871q94py81.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68891 Cc: Christopher Baines <mail@HIDDEN>, csantosb@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) Hello, Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> writes: > When one installs emacs-org-board, wget2-2.1.0 gets installed along with > it as for emacs-substitute-variables, as you say, and the variable > org-board-wget-program is bound to this hardcoded value. Correct. > Once one decides to upgrade wget2 to something different (say, in a > different profile), this logic breaks. User needs to manually bind > org-board-wget-program to whatever wget2 is after upgrading. At this > point, wget2 becomes a native-input requirement. This is not correct. No action is required from the user. `org-board-wget-program' still points to the wget program defined as an input to emacs-org-board, and will still be used at run time. Of course, the user still can point `org-board-wget-program' to their new and shiny wget binary, but this is not required. I also suggest to keep wget (or wget2) as an input and use `emacs-substitute-variables'. Regards, -- Nicolas Goaziou
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 22 Feb 2024 10:53:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 22 05:53:39 2024 Received: from localhost ([127.0.0.1]:44801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rd6hu-0004lE-QG for submit <at> debbugs.gnu.org; Thu, 22 Feb 2024 05:53:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:60714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rd6hs-0004l2-RU for submit <at> debbugs.gnu.org; Thu, 22 Feb 2024 05:53:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rd6hV-0007wd-MX for guix-patches@HIDDEN; Thu, 22 Feb 2024 05:53:13 -0500 Received: from msg-1.mailo.com ([213.182.54.11] helo=mailo.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rd6hU-0007WE-1G for guix-patches@HIDDEN; Thu, 22 Feb 2024 05:53:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1708599187; bh=jzVcPL6Ci53FMnxe/pDLRsqFg1Mw719GLMvcykgFpcQ=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=sliEKkZJQ7+1UGDmtoIv8WdYYugeJYS4FdX1HVLiLTjgXqFl/DQ1ECqxXlUanH2zN 2Zt48goKQLOX80xnerFNXR6yLMm9j/fw3K0TNVVD04QYzkCCziF9rzmwWVFifhUQGt UV3zrSvLCQu0ejbXxYi0uVCLPrIbdXm93Z+13Kc4= Received: by b221-2.in.mailobj.net [192.168.90.22] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 22 Feb 2024 11:53:02 +0100 (CET) X-EA-Auth: NY2QvWJUhHG45UH3FVBIzeFKBrIXlLbzjE5o3DvhFitvEpu+vQA7guI6K3nRf1/6PW89FIRkobnZc9hNmHTsLIMwUiwbIElNdsVNwXVwdRI= From: Nicolas Goaziou <mail@HIDDEN> To: Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. In-Reply-To: <87eddgv6i1.fsf@HIDDEN> (Cayetano Santos via Guix-patches via's message of "Tue, 13 Feb 2024 14:18:02 +0100") References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> <87plx0boch.fsf@HIDDEN> <87eddgv6i1.fsf@HIDDEN> Date: Thu, 22 Feb 2024 11:52:46 +0100 Message-ID: <871q94py81.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=213.182.54.11; envelope-from=mail@HIDDEN; helo=mailo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: Christopher Baines <mail@HIDDEN>, csantosb@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) Hello, Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> writes: > When one installs emacs-org-board, wget2-2.1.0 gets installed along with > it as for emacs-substitute-variables, as you say, and the variable > org-board-wget-program is bound to this hardcoded value. Correct. > Once one decides to upgrade wget2 to something different (say, in a > different profile), this logic breaks. User needs to manually bind > org-board-wget-program to whatever wget2 is after upgrading. At this > point, wget2 becomes a native-input requirement. This is not correct. No action is required from the user. `org-board-wget-program' still points to the wget program defined as an input to emacs-org-board, and will still be used at run time. Of course, the user still can point `org-board-wget-program' to their new and shiny wget binary, but this is not required. I also suggest to keep wget (or wget2) as an input and use `emacs-substitute-variables'. Regards, -- Nicolas Goaziou
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at 68891) by debbugs.gnu.org; 13 Feb 2024 13:28:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 08:28:20 2024 Received: from localhost ([127.0.0.1]:43119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZspg-000672-1b for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 08:28:20 -0500 Received: from latitanza.investici.org ([82.94.249.234]:39109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>) id 1rZspc-00066r-VR for 68891 <at> debbugs.gnu.org; Tue, 13 Feb 2024 08:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1707830871; bh=s8I0z1zgfz49Z2KW2nytp9tRIoOgiwXIeN5YK4tqWr8=; h=References:From:To:Cc:Subject:Date:Reply-To:In-reply-to:From; b=nl8YwDee/Pf4YZrlEUjtHhTKT997uJM0eZkhdVj03CfaGBiAjl3u2pXzRQewuobpZ nOf/fEq5IlXkyd4vBPPEiqodjB2wivx9kO56Ooz5HWoOFzRZly4ImZacy1xBpZMBOz iutZkvhLfIdYjeNOBBj0cVTYKVs3wUUdJNuvRNw0= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4TZ2FM6VMdzGp4L; Tue, 13 Feb 2024 13:27:51 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix) with ESMTPSA id 4TZ2FM52gdzGp4H; Tue, 13 Feb 2024 13:27:51 +0000 (UTC) References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> <87plx0boch.fsf@HIDDEN> User-agent: mu4e 1.10.8; emacs 29.1 From: Cayetano Santos <csantosb@HIDDEN> To: Christopher Baines <mail@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. Date: Tue, 13 Feb 2024 14:18:02 +0100 In-reply-to: <87plx0boch.fsf@HIDDEN> Message-ID: <87eddgv6i1.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68891 Cc: guix-patches@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: csantosb@HIDDEN Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >mar. 13 f=C3=A9vr. 2024 at 11:21, Christopher Baines <mail@HIDDEN> wr= ote: > Thanks for the patch, these changes around wget/wget2 look confusing to > me though. > > The reason for the emacs-substitute-variables bit is to allow wget to > just be an input rather than a propagated input, but you're making wget2 > a propagated input here. This change and the motivation behind it is > also missing from the commit message. When one installs emacs-org-board, wget2-2.1.0 gets installed along with it as for emacs-substitute-variables, as you say, and the variable org-board-wget-program is bound to this hardcoded value. Once one decides to upgrade wget2 to something different (say, in a different profile), this logic breaks. User needs to manually bind org-board-wget-program to whatever wget2 is after upgrading. At this point, wget2 becomes a native-input requirement. Please, correct me if I=E2=80=99m wrong. Cayetano
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 13:28:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 08:28:26 2024 Received: from localhost ([127.0.0.1]:43123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZspm-00067N-GD for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 08:28:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:35534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>) id 1rZspk-00067E-Sk for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 08:28:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>) id 1rZspR-0008F7-HY for guix-patches@HIDDEN; Tue, 13 Feb 2024 08:28:06 -0500 Received: from latitanza.investici.org ([82.94.249.234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>) id 1rZspP-0002I2-Da for guix-patches@HIDDEN; Tue, 13 Feb 2024 08:28:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1707830871; bh=s8I0z1zgfz49Z2KW2nytp9tRIoOgiwXIeN5YK4tqWr8=; h=References:From:To:Cc:Subject:Date:Reply-To:In-reply-to:From; b=nl8YwDee/Pf4YZrlEUjtHhTKT997uJM0eZkhdVj03CfaGBiAjl3u2pXzRQewuobpZ nOf/fEq5IlXkyd4vBPPEiqodjB2wivx9kO56Ooz5HWoOFzRZly4ImZacy1xBpZMBOz iutZkvhLfIdYjeNOBBj0cVTYKVs3wUUdJNuvRNw0= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4TZ2FM6VMdzGp4L; Tue, 13 Feb 2024 13:27:51 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix) with ESMTPSA id 4TZ2FM52gdzGp4H; Tue, 13 Feb 2024 13:27:51 +0000 (UTC) References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> <87plx0boch.fsf@HIDDEN> User-agent: mu4e 1.10.8; emacs 29.1 From: Cayetano Santos <csantosb@HIDDEN> To: Christopher Baines <mail@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. Date: Tue, 13 Feb 2024 14:18:02 +0100 In-reply-to: <87plx0boch.fsf@HIDDEN> Message-ID: <87eddgv6i1.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=82.94.249.234; envelope-from=csantosb@HIDDEN; helo=latitanza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: csantosb@HIDDEN Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) >mar. 13 f=C3=A9vr. 2024 at 11:21, Christopher Baines <mail@HIDDEN> wr= ote: > Thanks for the patch, these changes around wget/wget2 look confusing to > me though. > > The reason for the emacs-substitute-variables bit is to allow wget to > just be an input rather than a propagated input, but you're making wget2 > a propagated input here. This change and the motivation behind it is > also missing from the commit message. When one installs emacs-org-board, wget2-2.1.0 gets installed along with it as for emacs-substitute-variables, as you say, and the variable org-board-wget-program is bound to this hardcoded value. Once one decides to upgrade wget2 to something different (say, in a different profile), this logic breaks. User needs to manually bind org-board-wget-program to whatever wget2 is after upgrading. At this point, wget2 becomes a native-input requirement. Please, correct me if I=E2=80=99m wrong. Cayetano
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at 68891) by debbugs.gnu.org; 13 Feb 2024 11:23:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 06:23:03 2024 Received: from localhost ([127.0.0.1]:42187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZqsQ-00071p-TH for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:23:03 -0500 Received: from mira.cbaines.net ([212.71.252.8]:43110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rZqsP-00071L-6r for 68891 <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:23:02 -0500 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 6814127BBE2; Tue, 13 Feb 2024 11:22:42 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id fd49351a; Tue, 13 Feb 2024 11:22:41 +0000 (UTC) References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> User-agent: mu4e 1.10.7; emacs 29.1 From: Christopher Baines <mail@HIDDEN> To: Cayetano Santos <csantosb@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. Date: Tue, 13 Feb 2024 11:21:06 +0000 In-reply-to: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> Message-ID: <87plx0boch.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68891 Cc: guix-patches@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> writes: > * gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02. > --- > gnu/packages/emacs-xyz.scm | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index c7e6852194..3e6d09c509 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -27782,8 +27782,8 @@ (define-public emacs-cpreproc-openvdb > (license license:gpl3+))) >=20=20 > (define-public emacs-org-board > - (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224") > - (revision "1")) > + (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f") > + (revision "2")) > (package > (name "emacs-org-board") > (version (git-version "1138" revision commit)) > @@ -27795,7 +27795,7 @@ (define-public emacs-org-board > (file-name (git-file-name name version)) > (sha256 > (base32 > - "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b"= )))) > + "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf"= )))) > (build-system emacs-build-system) > (arguments > (list > @@ -27805,11 +27805,9 @@ (define-public emacs-org-board > (lambda* (#:key inputs #:allow-other-keys) > (emacs-substitute-variables "org-board.el" > ("org-board-wget-program" > - (search-input-file inputs "/bin/wget")))))))) > - (inputs > - (list wget)) > + (search-input-file inputs "/bin/wget2")))))))) > (propagated-inputs > - (list emacs-org emacs-ztree)) > + (list emacs-ztree wget2)) Thanks for the patch, these changes around wget/wget2 look confusing to me though. The reason for the emacs-substitute-variables bit is to allow wget to just be an input rather than a propagated input, but you're making wget2 a propagated input here. This change and the motivation behind it is also missing from the commit message. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXLUP5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcP4RAAuc8E5FnYNJdO4VGtbNEQnYvGqCG8dCFq ORyWji/8onOnbVNaOOr8J4BQjTGmLY94IEEZOtIY6kBkWe2NIUpG6JO10jGZg5iF Tr5nh6Lh5Zwu4OzrQEHdU3qA1wjqHxZLINihJG/a0eDZcRHBHFqhKxkAp49QFK3a goyj55ufBUCjp4BcLNQX3Cvr6QpL1Q2ZckX0PJVT/pe8j5VKWmOV8HgNpjn9mgXN 8kljAYXb4VKLmLw6uGnOalmgjjkopWbu0BNhhA2hAVnVgP5GBi7sz70oSqdKWJeQ 51LfME6uDtXPG5KJWhSQ70jpRKpshvxdBij69kWahS76ufxPo5w8abG6w9PNv7fN DpR7FgP+e6PKO9OzHokC6RUBHzO2g1d7wBpkWpysWpQeWhG2+OnXh0oS/8CT6Lie aB81e7mdpfmxs41BbvRIRqThp5QQKh+QokCZoWImmgpUBstoaCSAt+C5xX+JRwf5 tyX6DpWGtBZIQLmB7hm7dXYN/Q7CIylfbuIEl0JHcmuDf8G60hn3xJQN19OB1oEN ZLn3RU1vOr1M8EyO8VmMoaAHSiSlGM0zWBvInV/tabOGUEFCNVzVu0Qw6WEMAEvX zatI1zvcsDe8xpWT3lw2sWIZUCPVV7u2kS2M3lra5EF/kOcrbzS3gNdp77E96i9t zxpBZv+c3wA= =cqO0 -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 11:23:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 06:23:10 2024 Received: from localhost ([127.0.0.1]:42192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZqsY-00072G-9z for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:23:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:43484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rZqsX-000728-5q for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:23:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rZqsE-0005FP-P6 for guix-patches@HIDDEN; Tue, 13 Feb 2024 06:22:51 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rZqsA-00022K-TY for guix-patches@HIDDEN; Tue, 13 Feb 2024 06:22:50 -0500 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 6814127BBE2; Tue, 13 Feb 2024 11:22:42 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id fd49351a; Tue, 13 Feb 2024 11:22:41 +0000 (UTC) References: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> User-agent: mu4e 1.10.7; emacs 29.1 From: Christopher Baines <mail@HIDDEN> To: Cayetano Santos <csantosb@HIDDEN> Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. Date: Tue, 13 Feb 2024 11:21:06 +0000 In-reply-to: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> Message-ID: <87plx0boch.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@HIDDEN; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@HIDDEN, 68891 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Cayetano Santos via Guix-patches via <guix-patches@HIDDEN> writes: > * gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02. > --- > gnu/packages/emacs-xyz.scm | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index c7e6852194..3e6d09c509 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -27782,8 +27782,8 @@ (define-public emacs-cpreproc-openvdb > (license license:gpl3+))) >=20=20 > (define-public emacs-org-board > - (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224") > - (revision "1")) > + (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f") > + (revision "2")) > (package > (name "emacs-org-board") > (version (git-version "1138" revision commit)) > @@ -27795,7 +27795,7 @@ (define-public emacs-org-board > (file-name (git-file-name name version)) > (sha256 > (base32 > - "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b"= )))) > + "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf"= )))) > (build-system emacs-build-system) > (arguments > (list > @@ -27805,11 +27805,9 @@ (define-public emacs-org-board > (lambda* (#:key inputs #:allow-other-keys) > (emacs-substitute-variables "org-board.el" > ("org-board-wget-program" > - (search-input-file inputs "/bin/wget")))))))) > - (inputs > - (list wget)) > + (search-input-file inputs "/bin/wget2")))))))) > (propagated-inputs > - (list emacs-org emacs-ztree)) > + (list emacs-ztree wget2)) Thanks for the patch, these changes around wget/wget2 look confusing to me though. The reason for the emacs-substitute-variables bit is to allow wget to just be an input rather than a propagated input, but you're making wget2 a propagated input here. This change and the motivation behind it is also missing from the commit message. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXLUP5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcP4RAAuc8E5FnYNJdO4VGtbNEQnYvGqCG8dCFq ORyWji/8onOnbVNaOOr8J4BQjTGmLY94IEEZOtIY6kBkWe2NIUpG6JO10jGZg5iF Tr5nh6Lh5Zwu4OzrQEHdU3qA1wjqHxZLINihJG/a0eDZcRHBHFqhKxkAp49QFK3a goyj55ufBUCjp4BcLNQX3Cvr6QpL1Q2ZckX0PJVT/pe8j5VKWmOV8HgNpjn9mgXN 8kljAYXb4VKLmLw6uGnOalmgjjkopWbu0BNhhA2hAVnVgP5GBi7sz70oSqdKWJeQ 51LfME6uDtXPG5KJWhSQ70jpRKpshvxdBij69kWahS76ufxPo5w8abG6w9PNv7fN DpR7FgP+e6PKO9OzHokC6RUBHzO2g1d7wBpkWpysWpQeWhG2+OnXh0oS/8CT6Lie aB81e7mdpfmxs41BbvRIRqThp5QQKh+QokCZoWImmgpUBstoaCSAt+C5xX+JRwf5 tyX6DpWGtBZIQLmB7hm7dXYN/Q7CIylfbuIEl0JHcmuDf8G60hn3xJQN19OB1oEN ZLn3RU1vOr1M8EyO8VmMoaAHSiSlGM0zWBvInV/tabOGUEFCNVzVu0Qw6WEMAEvX zatI1zvcsDe8xpWT3lw2sWIZUCPVV7u2kS2M3lra5EF/kOcrbzS3gNdp77E96i9t zxpBZv+c3wA= =cqO0 -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 2 Feb 2024 08:46:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 02 03:46:09 2024 Received: from localhost ([127.0.0.1]:43716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rVpBY-0003tK-LX for submit <at> debbugs.gnu.org; Fri, 02 Feb 2024 03:46:08 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>) id 1rVpBT-0003sk-H5 for submit <at> debbugs.gnu.org; Fri, 02 Feb 2024 03:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>) id 1rVpBC-0000Zd-T3 for guix-patches@HIDDEN; Fri, 02 Feb 2024 03:45:46 -0500 Received: from latitanza.investici.org ([2001:888:2000:56::19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>) id 1rVpBA-0001SO-LW for guix-patches@HIDDEN; Fri, 02 Feb 2024 03:45:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1706863537; bh=Gtb8nE6+IkypgTRVZr8vaWCBVSSqMTnIJ+5vZ5MT1lo=; h=From:To:Cc:Subject:Date:From; b=q3ECASlLrCkznKFHLcgwej/xfK+kaqWF7jgZMFrAMRD0PNGuI4OjGmJ3gbHshXFyQ JAu/dkgb6cCZByLNdV7XI3TQdOquq13BoiH/uNmAws0xA6FdWeV/JxcJHxjimWQPk5 UX1CkA0bOn79lrwx1UWWPd6Kx7vJwLSS9IRn8XY0= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4TR8Vn2bKjzGp61; Fri, 2 Feb 2024 08:45:37 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix) with ESMTPSA id 4TR8Vn1WCQzGp5p; Fri, 2 Feb 2024 08:45:37 +0000 (UTC) From: Cayetano Santos <csantosb@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02. Date: Fri, 2 Feb 2024 09:45:16 +0100 Message-ID: <c733335e117a7e826d67f2d11130f34ab5e81ab4.1706863516.git.csantosb@HIDDEN> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:888:2000:56::19; envelope-from=csantosb@HIDDEN; helo=latitanza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos <csantosb@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) * gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02. --- gnu/packages/emacs-xyz.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c7e6852194..3e6d09c509 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -27782,8 +27782,8 @@ (define-public emacs-cpreproc-openvdb (license license:gpl3+))) (define-public emacs-org-board - (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224") - (revision "1")) + (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f") + (revision "2")) (package (name "emacs-org-board") (version (git-version "1138" revision commit)) @@ -27795,7 +27795,7 @@ (define-public emacs-org-board (file-name (git-file-name name version)) (sha256 (base32 - "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b")))) + "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf")))) (build-system emacs-build-system) (arguments (list @@ -27805,11 +27805,9 @@ (define-public emacs-org-board (lambda* (#:key inputs #:allow-other-keys) (emacs-substitute-variables "org-board.el" ("org-board-wget-program" - (search-input-file inputs "/bin/wget")))))))) - (inputs - (list wget)) + (search-input-file inputs "/bin/wget2")))))))) (propagated-inputs - (list emacs-org emacs-ztree)) + (list emacs-ztree wget2)) (home-page "https://github.com/charlesroelli/org-board") (synopsis "Bookmarking and web archival system for Org mode") (description base-commit: c692808a5e1413480162be1406186a63bd92651c -- 2.41.0
Cayetano Santos <csantosb@HIDDEN>
:guix-patches@HIDDEN
.
Full text available.guix-patches@HIDDEN
:bug#68891
; Package guix-patches
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.