GNU bug report logs -
#68987
[PATCH 0/2] update moonfish
Previous Next
Reported by: zamfofex <zamfofex <at> twdb.moe>
Date: Thu, 8 Feb 2024 00:34:02 UTC
Severity: normal
Tags: patch
Done: Christopher Baines <mail <at> cbaines.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68987 in the body.
You can then email your comments to 68987 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Thu, 08 Feb 2024 00:34:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
zamfofex <zamfofex <at> twdb.moe>
:
New bug report received and forwarded. Copy sent to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
.
(Thu, 08 Feb 2024 00:34:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
I made various improvements since I packaged it for Guix, so I decided it was time to update the package.
zamfofex (2):
gnu: moonfish: Update to 0-2.2118580.
gnu: moonfish: Improve description.
gnu/packages/games.scm | 56 +++++++++++++++---------------------------
1 file changed, 20 insertions(+), 36 deletions(-)
base-commit: cce7a6d2d2b18f51d1fcab67b02a38c11d6f4f2d
--
2.41.0
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Thu, 08 Feb 2024 00:36:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Update to 0-2.2118580.
Change-Id: I0c5b0e61f6818d29165a1371da717bb8695db834
---
gnu/packages/games.scm | 50 ++++++++++++++----------------------------
1 file changed, 17 insertions(+), 33 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 06ba868f35..16e2ee828a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10557,46 +10557,30 @@ (define-public stockfish
(license license:gpl3+))))
(define-public moonfish
- (let ((commit "4f8829009e8c26e6a878261e0bc4c7e7617ef6b6")
- (revision "1"))
+ (let ((commit "2118580d6ab454e165c7a84de6a604f96bc73850")
+ (revision "2"))
(package
(name "moonfish")
(version (git-version "0" revision commit))
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://git.sr.ht/~zamfofex/moonfish")
- (commit commit)))
- (sha256
- (base32
- "1ksg42x9cyn3pbfryy9raqb355k47cqcisascpy157c3cgdr2z60"))
- (file-name (git-file-name name version))))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.sr.ht/~zamfofex/moonfish")
+ (commit commit)))
+ (sha256
+ (base32 "1vqnmk2mpqd9nfchrirj5g3v3nqyhj3204d6fn3sihc2iqp4zyrk"))
+ (file-name (git-file-name name version))))
(build-system gnu-build-system)
(arguments
(list
- #:make-flags
- #~(list (string-append "CC=" #$(cc-for-target)))
- #:tests? #f ;no check target
- #:phases
- #~(modify-phases %standard-phases
- (delete 'configure) ;no configure script
- (replace 'install ;no 'install' target
- (lambda _
- (let* ((out-bin (string-append #$output "/bin"))
- (tools-bin (string-append #$output:tools "/bin"))
- (tool (string-append tools-bin "/moonfish-")))
- (mkdir-p out-bin)
- (mkdir-p tools-bin)
- (copy-file "moonfish"
- (string-append out-bin "/moonfish"))
- (copy-file "play"
- (string-append tool "play"))
- (copy-file "lichess"
- (string-append tool "lichess"))
- (copy-file "analyse"
- (string-append tool "analyse"))))))))
+ #:make-flags #~(list (string-append "CC="
+ #$(cc-for-target))
+ (string-append "PREFIX=" %output))
+ #:tests? #f ;no check target
+ #:phases #~(modify-phases %standard-phases
+ (delete 'configure)))) ;no configure script
(inputs (list bearssl cjson))
- (outputs '("out" "tools"))
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
--
2.41.0
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Thu, 08 Feb 2024 00:36:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Reword description.
Change-Id: I1641cedc34f28dc47b021be6bcfc2943b9abcc0d
---
gnu/packages/games.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 16e2ee828a..45851ada0f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10584,9 +10584,9 @@ (define-public moonfish
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
- "moonfish is a toy UCI chess engine made for fun. It is inspired by
-sunfish, but is written in C rather than Python. It also has TUI tools for
-using any UCI engine and also to connect UCI engines to Lichess.")
+ "moonfish is a toy UCI chess engine written in C for fun. It has TUI/CLI
+tools for using any UCI engine and also to connect UCI engines to Lichess, as
+well as for converting engines between UCI and UGI.")
(license license:agpl3+))))
(define-public morris
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Thu, 08 Feb 2024 17:52:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 68987 <at> debbugs.gnu.org (full text, mbox):
Am Mittwoch, dem 07.02.2024 um 21:34 -0300 schrieb zamfofex:
> * gnu/packages/games.scm (moonfish): Update to 0-2.2118580.
>
> Change-Id: I0c5b0e61f6818d29165a1371da717bb8695db834
> ---
> gnu/packages/games.scm | 50 ++++++++++++++--------------------------
> --
> 1 file changed, 17 insertions(+), 33 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 06ba868f35..16e2ee828a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -10557,46 +10557,30 @@ (define-public stockfish
> (license license:gpl3+))))
>
> (define-public moonfish
> - (let ((commit "4f8829009e8c26e6a878261e0bc4c7e7617ef6b6")
> - (revision "1"))
> + (let ((commit "2118580d6ab454e165c7a84de6a604f96bc73850")
> + (revision "2"))
> (package
> (name "moonfish")
> (version (git-version "0" revision commit))
> - (source (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://git.sr.ht/~zamfofex/moonfish")
> - (commit commit)))
> - (sha256
> - (base32
> -
> "1ksg42x9cyn3pbfryy9raqb355k47cqcisascpy157c3cgdr2z60"))
> - (file-name (git-file-name name version))))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~zamfofex/moonfish")
> + (commit commit)))
> + (sha256
> + (base32
> "1vqnmk2mpqd9nfchrirj5g3v3nqyhj3204d6fn3sihc2iqp4zyrk"))
> + (file-name (git-file-name name version))))
Please don't mix in cosmetic changes with semantic ones. IMHO the
indentation is fine as-is.
> (build-system gnu-build-system)
> (arguments
> (list
> - #:make-flags
> - #~(list (string-append "CC=" #$(cc-for-target)))
> - #:tests? #f ;no check target
> - #:phases
> - #~(modify-phases %standard-phases
> - (delete 'configure) ;no configure script
> - (replace 'install ;no 'install' target
> - (lambda _
> - (let* ((out-bin (string-append #$output "/bin"))
> - (tools-bin (string-append #$output:tools
> "/bin"))
> - (tool (string-append tools-bin "/moonfish-
> ")))
> - (mkdir-p out-bin)
> - (mkdir-p tools-bin)
> - (copy-file "moonfish"
> - (string-append out-bin "/moonfish"))
> - (copy-file "play"
> - (string-append tool "play"))
> - (copy-file "lichess"
> - (string-append tool "lichess"))
> - (copy-file "analyse"
> - (string-append tool "analyse"))))))))
> + #:make-flags #~(list (string-append "CC="
> + #$(cc-for-target))
> + (string-append "PREFIX=" %output))
> + #:tests? #f ;no check target
> + #:phases #~(modify-phases %standard-phases
> + (delete 'configure)))) ;no configure script
You forgot to document this change…
> (inputs (list bearssl cjson))
> - (outputs '("out" "tools"))
… as well as this.
> (home-page "https://git.sr.ht/~zamfofex/moonfish")
> (synopsis "Simple chess engine written in C")
> (description
Cheers
Information forwarded
to
guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Thu, 08 Feb 2024 23:36:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 68987 <at> debbugs.gnu.org (full text, mbox):
> Please don't mix in cosmetic changes with semantic ones. IMHO the
> indentation is fine as-is.
Sure. I just ran ‘guix style’ on it before committing, I thought it would have been warranted. I can undo the changes it made, sure.
> […]
> You forgot to document this change…
> […]
> … as well as this.
Sure, I’ll do that and send a new patch soon! Thanks for reviewing.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Wed, 28 Feb 2024 10:31:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 68987 <at> debbugs.gnu.org (full text, mbox):
Ping?
Andreas
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Mon, 25 Mar 2024 16:30:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Reword description.
Change-Id: I1641cedc34f28dc47b021be6bcfc2943b9abcc0d
---
gnu/packages/games.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 783d172bc9..8898b90fe0 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10583,9 +10583,9 @@ (define-public moonfish
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
- "moonfish is a toy UCI chess engine made for fun. It is inspired by
-sunfish, but is written in C rather than Python. It also has TUI tools for
-using any UCI engine and also to connect UCI engines to Lichess.")
+ "moonfish is a toy UCI chess engine written in C for fun. It has TUI/CLI
+tools for using any UCI engine and also to connect UCI engines to Lichess, as
+well as for converting engines between UCI and UGI.")
(license license:agpl3+))))
(define-public morris
--
2.41.0
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Mon, 25 Mar 2024 16:30:03 GMT)
Full text and
rfc822 format available.
Message #26 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Update to 0-2.fd3471d.
[arguments]: Use upstream's makefile for building and installing.
Install tools into the "out" output instead of the "tools" output.
[outputs]: Remove "tools".
Change-Id: I1325550afb05f897006b9f2bd01040f52fee703a
---
gnu/packages/games.scm | 33 ++++++++-------------------------
1 file changed, 8 insertions(+), 25 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 06ba868f35..783d172bc9 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10557,8 +10557,8 @@ (define-public stockfish
(license license:gpl3+))))
(define-public moonfish
- (let ((commit "4f8829009e8c26e6a878261e0bc4c7e7617ef6b6")
- (revision "1"))
+ (let ((commit "fd3471d59daa333b1ee112f2fd9b7a51c50cf25b")
+ (revision "2"))
(package
(name "moonfish")
(version (git-version "0" revision commit))
@@ -10569,34 +10569,17 @@ (define-public moonfish
(commit commit)))
(sha256
(base32
- "1ksg42x9cyn3pbfryy9raqb355k47cqcisascpy157c3cgdr2z60"))
+ "1snjym2crs8c2lwvy8laag25wwqw3q7yml3mqcsqb2jfhanb62qc"))
(file-name (git-file-name name version))))
(build-system gnu-build-system)
(arguments
(list
- #:make-flags
- #~(list (string-append "CC=" #$(cc-for-target)))
- #:tests? #f ;no check target
- #:phases
- #~(modify-phases %standard-phases
- (delete 'configure) ;no configure script
- (replace 'install ;no 'install' target
- (lambda _
- (let* ((out-bin (string-append #$output "/bin"))
- (tools-bin (string-append #$output:tools "/bin"))
- (tool (string-append tools-bin "/moonfish-")))
- (mkdir-p out-bin)
- (mkdir-p tools-bin)
- (copy-file "moonfish"
- (string-append out-bin "/moonfish"))
- (copy-file "play"
- (string-append tool "play"))
- (copy-file "lichess"
- (string-append tool "lichess"))
- (copy-file "analyse"
- (string-append tool "analyse"))))))))
+ #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+ (string-append "PREFIX=" %output))
+ #:tests? #f ;no check target
+ #:phases #~(modify-phases %standard-phases
+ (delete 'configure)))) ;no configure script
(inputs (list bearssl cjson))
- (outputs '("out" "tools"))
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
base-commit: cce7a6d2d2b18f51d1fcab67b02a38c11d6f4f2d
--
2.41.0
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Tue, 26 Mar 2024 20:02:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Update to 0-2.fb2cb4f.
[arguments]: Use upstream's makefile for building and installing.
Install tools into the "out" output instead of the "tools" output.
[outputs]: Remove "tools".
Change-Id: I0f098b02633d397fe1fef67863c3cd5b1db19214
---
gnu/packages/games.scm | 33 ++++++++-------------------------
1 file changed, 8 insertions(+), 25 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 06ba868f35..50ddf53ef5 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10557,8 +10557,8 @@ (define-public stockfish
(license license:gpl3+))))
(define-public moonfish
- (let ((commit "4f8829009e8c26e6a878261e0bc4c7e7617ef6b6")
- (revision "1"))
+ (let ((commit "fb2cb4f53876b1b0c6060464e0dd5a05ab00e502")
+ (revision "2"))
(package
(name "moonfish")
(version (git-version "0" revision commit))
@@ -10569,34 +10569,17 @@ (define-public moonfish
(commit commit)))
(sha256
(base32
- "1ksg42x9cyn3pbfryy9raqb355k47cqcisascpy157c3cgdr2z60"))
+ "1rbhdahp0s2qm1zi7lpr0bb6zq02y76fc9d9nc2k5n03zh2as97i"))
(file-name (git-file-name name version))))
(build-system gnu-build-system)
(arguments
(list
- #:make-flags
- #~(list (string-append "CC=" #$(cc-for-target)))
- #:tests? #f ;no check target
- #:phases
- #~(modify-phases %standard-phases
- (delete 'configure) ;no configure script
- (replace 'install ;no 'install' target
- (lambda _
- (let* ((out-bin (string-append #$output "/bin"))
- (tools-bin (string-append #$output:tools "/bin"))
- (tool (string-append tools-bin "/moonfish-")))
- (mkdir-p out-bin)
- (mkdir-p tools-bin)
- (copy-file "moonfish"
- (string-append out-bin "/moonfish"))
- (copy-file "play"
- (string-append tool "play"))
- (copy-file "lichess"
- (string-append tool "lichess"))
- (copy-file "analyse"
- (string-append tool "analyse"))))))))
+ #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+ (string-append "PREFIX=" %output))
+ #:tests? #f ;no check target
+ #:phases #~(modify-phases %standard-phases
+ (delete 'configure)))) ;no configure script
(inputs (list bearssl cjson))
- (outputs '("out" "tools"))
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
base-commit: cce7a6d2d2b18f51d1fcab67b02a38c11d6f4f2d
--
2.41.0
Information forwarded
to
liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Tue, 26 Mar 2024 20:02:02 GMT)
Full text and
rfc822 format available.
Message #32 received at 68987 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/games.scm (moonfish): Reword description.
Change-Id: I1641cedc34f28dc47b021be6bcfc2943b9abcc0d
---
gnu/packages/games.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 50ddf53ef5..fab5ab5d7d 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10583,9 +10583,9 @@ (define-public moonfish
(home-page "https://git.sr.ht/~zamfofex/moonfish")
(synopsis "Simple chess engine written in C")
(description
- "moonfish is a toy UCI chess engine made for fun. It is inspired by
-sunfish, but is written in C rather than Python. It also has TUI tools for
-using any UCI engine and also to connect UCI engines to Lichess.")
+ "moonfish is a toy UCI chess engine written in C for fun. It has TUI/CLI
+tools for using any UCI engine and also to connect UCI engines to Lichess, as
+well as for converting engines between UCI and UGI.")
(license license:agpl3+))))
(define-public morris
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#68987
; Package
guix-patches
.
(Wed, 27 Mar 2024 12:59:01 GMT)
Full text and
rfc822 format available.
Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Thanks all, I've pushed these patches to master as
560062aaeabb485e7f53f8f5e6449b9a35aa9ca2.
Chris
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Wed, 27 Mar 2024 12:59:03 GMT)
Full text and
rfc822 format available.
Notification sent
to
zamfofex <zamfofex <at> twdb.moe>
:
bug acknowledged by developer.
(Wed, 27 Mar 2024 12:59:03 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 25 Apr 2024 11:25:59 GMT)
Full text and
rfc822 format available.
This bug report was last modified 9 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.