Received: (at 69066) by debbugs.gnu.org; 22 Feb 2024 08:34:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 22 03:34:59 2024 Received: from localhost ([127.0.0.1]:35607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rd4Xj-0001Fg-2t for submit <at> debbugs.gnu.org; Thu, 22 Feb 2024 03:34:59 -0500 Received: from mail-pf1-f171.google.com ([209.85.210.171]:44191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <evgenij.gagauz@HIDDEN>) id 1rd4Xg-0001F7-Fg for 69066 <at> debbugs.gnu.org; Thu, 22 Feb 2024 03:34:57 -0500 Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e4841ce028so1714573b3a.0 for <69066 <at> debbugs.gnu.org>; Thu, 22 Feb 2024 00:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708590807; x=1709195607; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=toz3fv706Xz3tr1t7AlZhCEET5z5Itu/XO5u9nvfaB8=; b=MGi612jb2EV9H2gX8XlVjd53YdQ9C39DXfZMC/H/KAOJuBjMBuDeOulzjeOMhgwOGf Wq1/dS31tIMJ9j2Zdu4I0t2gr/GrgdOCTLo4uESilSUmItmWhF9prStT3VwyqDQE+T6Q O0eZs+osFYuoUFfBUbyXcjCI9XvZ1jUHUpvFG/0h+98n/EAjK6J+z2pHnB9ufer1rPUd yO17a0OZU4tFpvC8urCPc6LrMkv18TOcSioRc+Fp9PSK4PTbeee/RcpOuWOwjdsTLewC paWiFFuExFfpVtUhLTLaOWZOsnudsaNhw/o78+2uMd8AmQhzdbGt33QjduW31TZ7xFwP CuKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708590807; x=1709195607; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=toz3fv706Xz3tr1t7AlZhCEET5z5Itu/XO5u9nvfaB8=; b=sgKLKTXNCFhsOB923HOgvAgkrMxwJcWz4RpbXEQ3KNYjpqlMlPtcmZIH8tn59KyGOq NLpi9d2+E0DhMTHej2Z0L4RwnweCW4LvUZzP9zsLD3FD4xnPGXN7IOb1XlMr5PMQbnZ+ OPOg7appWEBjIPhYndr6if+jMRbZOFetxib/sichWZf7LENzLDg1pFbNVHR9EjYHRd7f 1xIrVl0Nn+k/6KKMwP285oxtRCaNFE6xufbdk6IKRT2ntHYwA9fwvFnBHhiwqnXofCXB KnVQAJ5188XSS95h+ZIlscOSyjQyEq8fC2LoWtvS7fXFXe3g66QmqmoK8FrfXdI+/sWQ BFNw== X-Gm-Message-State: AOJu0YxdgwHrCiEASm1I05AKPkkLApYlOSJxdAguIV3cQX2qdZN3B71Q BcHmC2ua+XoBFrmJON3feAVyBmH6kPq8LWNzGD7BnugZP4SOYAOm13P5knHqngAOsrZNRNYTTjz cAsp7pZApkMzCkEPbjE7Rqrk6BludXQ9Z22g= X-Google-Smtp-Source: AGHT+IEq5uyBsiKVWq/65XUKWxz7uTprwICEq4uE8/jMfQAWNBsq4rec9GsRlRLMjnpncdbqILsn32HUW6d80V1Tpwc= X-Received: by 2002:a05:6a20:c78d:b0:19e:9da6:c73b with SMTP id hk13-20020a056a20c78d00b0019e9da6c73bmr21138683pzb.8.1708590807182; Thu, 22 Feb 2024 00:33:27 -0800 (PST) MIME-Version: 1.0 References: <20240212003041.178-1-evgenij.gagauz@HIDDEN> <CADwFkm=2eov6t1bU2MDDVDu_Rf=yNemPVTVSXNY=tH56mBbNrg@HIDDEN> In-Reply-To: <CADwFkm=2eov6t1bU2MDDVDu_Rf=yNemPVTVSXNY=tH56mBbNrg@HIDDEN> From: Gagauz Evgenij Vladimirovich <evgenij.gagauz@HIDDEN> Date: Thu, 22 Feb 2024 09:33:15 +0100 Message-ID: <CAGM05Zz0r5iF-87HOyoyFy8tgDK1pTt0Ppj=Vv-pZ_U=ZvJbnw@HIDDEN> Subject: Re: bug#69066: [PATCH] Fix compilation filtration if carriage is moved To: 69066 <at> debbugs.gnu.org Content-Type: multipart/alternative; boundary="00000000000020f0af0611f44c7c" X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69066 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) --00000000000020f0af0611f44c7c Content-Type: text/plain; charset="UTF-8" I could reproduce it with the following simple bash script: printf '\r\e[K0' sleep 1 printf '\r\e[K1' sleep 1 printf '\r\e[K2' sleep 1 printf '\r\e[K3' sleep 1 printf '\r\e[K4' The result is: ./test.sh ^[[K4 Compilation finished at Thu Feb 22 01:10:34 Interesting enough that the issue is not reproduced without sleeps. It seems that the stream must be flushed to reproduce the issue. --00000000000020f0af0611f44c7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">I could reproduce it with the following s= imple bash script:<div><br></div><div>printf '\r\e[K0'<br>sleep 1<b= r>printf '\r\e[K1'<br>sleep 1<br>printf '\r\e[K2'<br>sleep = 1<br>printf '\r\e[K3'<br>sleep 1<br>printf '\r\e[K4'<br></d= iv><div><br></div><div>The result is:</div><div>./test.sh<br>^[[K4<br>Compi= lation finished at Thu Feb 22 01:10:34<br></div><div><br></div><div>Interes= ting enough=C2=A0that the issue is not reproduced without sleeps. It seems = that the stream must be flushed to reproduce the issue.</div></div></div> --00000000000020f0af0611f44c7c--
bug-gnu-emacs@HIDDEN:bug#69066; Package emacs.
Full text available.Received: (at 69066) by debbugs.gnu.org; 19 Feb 2024 05:59:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 19 00:59:34 2024 Received: from localhost ([127.0.0.1]:40215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rbwgg-0001JQ-Dz for submit <at> debbugs.gnu.org; Mon, 19 Feb 2024 00:59:34 -0500 Received: from mail-ed1-f52.google.com ([209.85.208.52]:52628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rbwge-0001J8-HL for 69066 <at> debbugs.gnu.org; Mon, 19 Feb 2024 00:59:33 -0500 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5648d92919dso265290a12.1 for <69066 <at> debbugs.gnu.org>; Sun, 18 Feb 2024 21:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708322286; x=1708927086; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=gahMRPEGdiRubCwH8LHqI8lsAZHp7uY7LrHHH+dFXqo=; b=DpWSbPXBdk9zqoNpf5DT5WG2IZBbHV4JVsp779UkrVlvYB3P5vxQNphIkghkPDu8fa O8NUM8I15Uampn+4f2PJom2FIBYGimT2LujctuAlsFAvs6r1f7Q72nctlMT0LAkp/M7t +f4pHQh62t6cEb2Zt6w+/Nv4KF2sjOBjO/SNp+4ZAZhcvAnYxb+w1sILIYkh85QJ44z8 oMpelv9dtdDyJGKwqXeaVMqsuNzkpfMBM/h5KB68+zB2ueCNGKFtgBRZOIDyKFnJj4DN MBVgwplZNRJTOaUSdqA32+exzVzbo+iXylg7TYELRL+Z3P8TrRfMCqMQNHVHVUGR8fWl 2obA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708322286; x=1708927086; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gahMRPEGdiRubCwH8LHqI8lsAZHp7uY7LrHHH+dFXqo=; b=eJqMeGJI2S1Ln4h35PQdcr5osV7M/aTq7rUtYrFXwKCkrh2UpaV20ifJGktSGf+QmI StvIcZs7fKLaHMqfgTjH7jhb5ByLOIUUXVny7eK4bZgf3A5gZbkKhFP9KOSINwJnwTeV Y183Td/KgFbKD02I3QEaIDFWocwqyGhtEyWxNVUMiP6YoBxbh1BkGt0u5O1kZfr8qqcn DJL9fDUmTk+Xrc45C7UkrupJD4wIXeJNBvIvc4HfmEFOmfWAl5Bo/d/C3TiQGwLEKNNz f7UiyHjhlmZUoAP7icpi3P3E5JoBIfkRtpNlg+W6xFhipljZfS90MwwaG8yeXAsujtwu phuw== X-Forwarded-Encrypted: i=1; AJvYcCV8nPe5H2zVpWKRphslINrebjiv8RnLZm1lOVl5SaBT1DvPWvJK58JHg8oyCffj1E+h5QPguo8WhcueHGPNpE8hbKA0DIk= X-Gm-Message-State: AOJu0YyYoRhh55BzRy99Qco3U2x4GtBgMCFOuRfFEbN6X5MlKulG3efU ErlwOHgRfZkkqoJJdRD2Vq497bFFPF+vE5zYPbFZmCqKUlaQX86VNjNQSdnVZtOhmEJ3U5kzJSn d8k4iYAfktGb9b3n2tNEnxRtVZYs= X-Google-Smtp-Source: AGHT+IGJHbJNc12KY96I2/17q4G0e38d0sDvkjpqGiqz5WZH+bEFtTzdTTCQhCHffS4hA/Vz+8PVGbOZO3f+f3Rod7U= X-Received: by 2002:a50:fc0a:0:b0:564:2655:f1b4 with SMTP id i10-20020a50fc0a000000b005642655f1b4mr3093620edr.32.1708322285677; Sun, 18 Feb 2024 21:58:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Feb 2024 00:58:05 -0500 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <20240212003041.178-1-evgenij.gagauz@HIDDEN> References: <20240212003041.178-1-evgenij.gagauz@HIDDEN> MIME-Version: 1.0 Date: Mon, 19 Feb 2024 00:58:05 -0500 Message-ID: <CADwFkm=2eov6t1bU2MDDVDu_Rf=yNemPVTVSXNY=tH56mBbNrg@HIDDEN> Subject: Re: bug#69066: [PATCH] Fix compilation filtration if carriage is moved To: Evgeny Gagauz <evgenij.gagauz@HIDDEN>, 69066 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69066 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) Evgeny Gagauz <evgenij.gagauz@HIDDEN> writes: > * lisp/progmodes/compile.el (compilation-filter): If a process produces > carriage cotrol characters then `compilation-filter-start' could point > to a wrong place after applying `comint-carriage-motion' > function. So its value is recalculated. Thanks for the patch. Could you provide more details about the issue you see? Perhaps even a way to reproduce it? > --- > lisp/progmodes/compile.el | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 11d400e145a..90ff414ad41 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'." > (when compilation-hidden-output > (compilation--hide-output compilation-filter-start)) > (unless comint-inhibit-carriage-motion > - (comint-carriage-motion (process-mark proc) (point))) > + (comint-carriage-motion (process-mark proc) (point)) > + ;; `compilation-filter-start' could be moved after > + ;; interpreting carriage control characters > + (setq compilation-filter-start (marker-position (process-mark proc)))) > (set-marker (process-mark proc) (point)) > ;; Update the number of errors in compilation-mode-line-errors > (compilation--ensure-parse (point)) > -- > 2.39.3 (Apple Git-145)
bug-gnu-emacs@HIDDEN:bug#69066; Package emacs.
Full text available.Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 05:35:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 00:35:07 2024
Received: from localhost ([127.0.0.1]:55928 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZOyB-0001GI-D5
for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 00:35:07 -0500
Received: from lists.gnu.org ([2001:470:142::17]:34342)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gagauzev@HIDDEN>)
id 1rZKVH-0004v2-Ao
for submit <at> debbugs.gnu.org; Sun, 11 Feb 2024 19:48:59 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gagauzev@HIDDEN>)
id 1rZKUv-0002l4-52
for bug-gnu-emacs@HIDDEN; Sun, 11 Feb 2024 19:48:37 -0500
Received: from [2a02:6b8:b081:8032::1:17] (helo=gagauzev-osx2.localdomain)
by eggs.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <gagauzev@HIDDEN>)
id 1rZKUt-000811-NN
for bug-gnu-emacs@HIDDEN; Sun, 11 Feb 2024 19:48:36 -0500
Received: by gagauzev-osx2.localdomain (Postfix, from userid 1458460799)
id 75A8755DC80E; Mon, 12 Feb 2024 01:31:10 +0100 (CET)
From: Evgeny Gagauz <evgenij.gagauz@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Fix compilation filtration if carriage is moved
Date: Mon, 12 Feb 2024 01:30:41 +0100
Message-Id: <20240212003041.178-1-evgenij.gagauz@HIDDEN>
X-Mailer: git-send-email 2.39.3 (Apple Git-145)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:6b8:b081:8032::1:17
(failed)
Received-SPF: none client-ip=2a02:6b8:b081:8032::1:17;
envelope-from=gagauzev@HIDDEN;
helo=gagauzev-osx2.localdomain
X-Spam_score_int: 41
X-Spam_score: 4.1
X-Spam_bar: ++++
X-Spam_report: (4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
NO_DNS_FOR_FROM=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001,
SPOOFED_FREEMAIL=1.998, SPOOFED_FREEMAIL_NO_RDNS=0.001, SPOOF_GMAIL_MID=1.051,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 4.7 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * lisp/progmodes/compile.el (compilation-filter): If a
process
produces carriage cotrol characters then `compilation-filter-start' could
point to a wrong place after applying `comint-carriage-motion' [...]
Content analysis details: (4.7 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records
0.0 SPF_NONE SPF: sender does not publish an SPF Record
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (evgenij.gagauz[at]gmail.com)
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are different
-0.0 T_SCC_BODY_TEXT_LINE No description available.
2.0 SPOOFED_FREEMAIL No description available.
1.1 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be...
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Mon, 12 Feb 2024 00:33:03 -0500
Cc: Evgeny Gagauz <evgenij.gagauz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.6 (/)
* lisp/progmodes/compile.el (compilation-filter): If a process produces
carriage cotrol characters then `compilation-filter-start' could point
to a wrong place after applying `comint-carriage-motion'
function. So its value is recalculated.
---
lisp/progmodes/compile.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 11d400e145a..90ff414ad41 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'."
(when compilation-hidden-output
(compilation--hide-output compilation-filter-start))
(unless comint-inhibit-carriage-motion
- (comint-carriage-motion (process-mark proc) (point)))
+ (comint-carriage-motion (process-mark proc) (point))
+ ;; `compilation-filter-start' could be moved after
+ ;; interpreting carriage control characters
+ (setq compilation-filter-start (marker-position (process-mark proc))))
(set-marker (process-mark proc) (point))
;; Update the number of errors in compilation-mode-line-errors
(compilation--ensure-parse (point))
--
2.39.3 (Apple Git-145)
Evgeny Gagauz <evgenij.gagauz@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#69066; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.