GNU bug report logs - #69096
[PATCH] Set default value for 'vc-default-patch-addressee'

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Tue, 13 Feb 2024 09:55:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 69096 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#69096; Package emacs. (Tue, 13 Feb 2024 09:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Philip Kaludercic <philipk <at> posteo.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 13 Feb 2024 09:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Set default value for 'vc-default-patch-addressee'
Date: Tue, 13 Feb 2024 09:54:16 +0000
[Message part 1 (text/plain, inline)]
Apparently we forgot to set this option back when it was added, but it
makes sense to have it along with 'vc-prepare-patches-separately'.

[0001-dir-locals-el--Set-'vc-default-patch-addresse.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69096; Package emacs. (Fri, 03 May 2024 07:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Fri, 03 May 2024 07:36:34 +0000
Philip Kaludercic <philipk <at> posteo.net> writes:

> Apparently we forgot to set this option back when it was added, but it
> makes sense to have it along with 'vc-prepare-patches-separately'.

ping?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69096; Package emacs. (Sat, 04 May 2024 11:46:01 GMT) Full text and rfc822 format available.

Message #11 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 04 May 2024 14:44:40 +0300
> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Fri, 03 May 2024 07:36:34 +0000
> 
> Philip Kaludercic <philipk <at> posteo.net> writes:
> 
> > Apparently we forgot to set this option back when it was added, but it
> > makes sense to have it along with 'vc-prepare-patches-separately'.
> 
> ping?

Dmitry?

I'm okay with this, FWIW.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69096; Package emacs. (Sat, 04 May 2024 13:36:02 GMT) Full text and rfc822 format available.

Message #14 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 4 May 2024 16:34:47 +0300
Hi Eli,

On 04/05/2024 14:44, Eli Zaretskii wrote:
>> From: Philip Kaludercic<philipk <at> posteo.net>
>> Date: Fri, 03 May 2024 07:36:34 +0000
>>
>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>
>>> Apparently we forgot to set this option back when it was added, but it
>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>> ping?
> Dmitry?
> 
> I'm okay with this, FWIW.

I didn't think this was my area, but the change also LGTM.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69096; Package emacs. (Sat, 04 May 2024 14:17:01 GMT) Full text and rfc822 format available.

Message #17 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 04 May 2024 14:15:39 +0000
Dmitry Gutov <dmitry <at> gutov.dev> writes:

> Hi Eli,
>
> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>> From: Philip Kaludercic<philipk <at> posteo.net>
>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>
>>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>>
>>>> Apparently we forgot to set this option back when it was added, but it
>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>> ping?
>> Dmitry?
>> I'm okay with this, FWIW.
>
> I didn't think this was my area, but the change also LGTM.

Yes, I worked on vc-prepare-patch and related functionality for the most
part, hence the suggestion.

-- 
	Philip Kaludercic on peregrine




This bug report was last modified today.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.