GNU bug report logs - #69540
pre-push hook tries to check only the first ref

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 4 Mar 2024 11:31:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 04 06:31:16 2024
Received: from localhost ([127.0.0.1]:42153 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rh6XM-00084d-HE
	for submit <at> debbugs.gnu.org; Mon, 04 Mar 2024 06:31:16 -0500
Received: from lists.gnu.org ([209.51.188.17]:60270)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1rh6XL-00084W-7Y
 for submit <at> debbugs.gnu.org; Mon, 04 Mar 2024 06:31:15 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rh6Wr-0003re-4d
 for bug-guix@HIDDEN; Mon, 04 Mar 2024 06:30:45 -0500
Received: from wolfsden.cz ([37.205.8.62])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rh6Wm-0004FE-SH
 for bug-guix@HIDDEN; Mon, 04 Mar 2024 06:30:44 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
 id 209D924B8AA; Mon,  4 Mar 2024 11:30:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1709551837; bh=WrzzyNEDrv+hqeGIWIMP7frCqov/joj9AoiE3smsiEw=;
 h=Date:From:To:Subject;
 b=l68NSKjLOg+jGTB573HGPn1MdYmDUKMriozRZ/uNJNArbFkNkfO417Lt8dqTj4Svh
 hbB/BPph2JO6QR0dlyCsg0RjeR0i3SfP617K9LfPeyKT21IC34UIfxEwCGJCmLBwJ5
 HyS8a9ljSIJgFh/pVUilKwHOgz6xsrsOTi30lvzEnEweIr3ZWKXGH2/FBefPa93K8I
 +Rx1Nu36LnqaRtXxktxt6Z1CvQeUN4Y/Ick8wJI7ooactjd8TN3znJ86Rmzi4spRNv
 ZAFivaSFMIk4mCrANfS+rxQ/tzuqOw1tcMLkwdtB8ZbYFQvDfUgN2VM57CnG7ns+/w
 TnS2VTaMiMvOV0U8r7xUXLfon/bIyZg4nwwA9cN/MlivUPFfLhgdJRWTmyy+alynz2
 7OqNwySbzTi/qfvlrXhMpzBoa5sA4CdWVsUEMeWxfUgR5YTUqRvL7v9xrDrLMX6n+L
 Zs6vlS/qhaHHf1AmKQNx9JLAbfbm4aSoIqhOxvh+C/JNS3xjCQJONQ/r4Ljyu4wXqH
 2o6jzsvvu5PkO1sz0uEeViqkJqev22qnyM9Hr4c3tgnhhyH1yPRPZVSsKIOw3hqXNn
 wSwa3AKYXTrmBciufxsM21I5ZX43Y28sThAhvXDt3vJBF5lTEhqUXnv0Cox3KFa36G
 nQmaJwIUFR39f4QeIulPpewU=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE,
 URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [81.17.16.82])
 by wolfsden.cz (Postfix) with ESMTPSA id 212EE24B9AA
 for <bug-guix@HIDDEN>; Mon,  4 Mar 2024 11:30:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1709551836; bh=WrzzyNEDrv+hqeGIWIMP7frCqov/joj9AoiE3smsiEw=;
 h=Date:From:To:Subject;
 b=QFXwfYoAqYoA4JsSw0sjYBmRLKIs/dd/3x1lLP9ViRJ3h21SQocSkGdDFwUj3vS3E
 xsNqY0y6WRSPfActIHyjvo/Ac1EJakYwmWRNyPhlR9TlTQBvke18agmqLbDlljCgzm
 zzJBHWzGQIsfTmjwFlvHz3TZP8fBMS7nr3yrmMHkcJg9hkMzS4epnseJ8SBpU6dT/3
 Uyb/AU4gl+v7BwIMf2ggaQRXisT9HpTkef/azmFQwoI9Rn6pFFQ6EqN6lkFVWSv5Ng
 KOc0+XQMUkJAL4cyj5NTTvcanRx2kAlhBTosL+rNzAxuMi3SDalIcVBEEe9/7LHCB8
 xfoYs+y5VsywUDDX4ztbMkgXYXGl5vragvq1Yzi6BIqPF0nReHc2NGOuuaHnHyCoZX
 vhdwlvGvT8dj0G3Kg6j5vKaHFJFI7Ibm9/sw0esMp6Uu4nomFB72fYLyZZYjGv990w
 R7qCYSibuGYmbiIkSSextzG+mgKNf9ii1toBRXiUtwyTji6njS13krU7+KSSnF7eVW
 hX2dvyC5w1WfBA4LaKZCWmzJEIV3UepUBFLZaAmK1oJlNufBPlCz3ACJdgxkjeNQSV
 3Fq0JQmEB+7Sgo/dPw0fpYhzQSjmlearGpujl9kXJX7ZFHlYBoczsHgsX39ew4zVn0
 2/4B/A+KpyT8VyvIwkKcA+FE=
Date: Mon, 4 Mar 2024 12:30:35 +0100
From: Tomas Volf <~@wolfsden.cz>
To: bug-guix@HIDDEN
Subject: pre-push hook tries to check only the first ref
Message-ID: <ZeWw24icqpolLdAh@ws>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="fsyfwTO9fYzfZCd2"
Content-Disposition: inline
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
 helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


--fsyfwTO9fYzfZCd2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

I have noticed that despite the pre-push hook having a `while' loop to read all
the refs, it calls exec/exit on the very first one.  Effectively that means that
only the first ref is checked, the rest is assumed to be authenticated.  That
seems wrong.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--fsyfwTO9fYzfZCd2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmXlsNsACgkQL7/ufbZ/
wak+Ng/+JbtEk232HXDSsPeyGwHT0y45F4cDRIiRhABpXhleR9URKKw49Q3+bQ/S
ylXl6ppqvtXBbgaRg8qKoLXXuuqo2UesSN0QpOJGKMfdKuN8jgMx7dUFxIUd9jqu
gPzZPoiokfomu5TijPn8opaoosNDazS/E45LuwgSS9f1c8K7F1r4300ZrnAlQ9sR
VGsAP6w5920abGeVPV1F863rYCJhrV2soxQTI1S3AOZqtuTmIFG4KIg9Y9+pRz6P
DowZF7wK7WgRqUK5rneJVA2oMYfEbeFG5s6ZLWuzhQxv/kcFRa13mB4piftqmkyI
x6g7MbdkzL1xRfLGWK02dKn4qvsfIwEG1fZ/bs3d3qSlICD0VQoNFWFijz4v1NyF
CBEBIM4vVzIxiUGhjJqvWViQ+6354x+kwEhHjFqrF+KVwkm/6m4QPU2WitL1WHxR
uXCGYC9mMMgj+JfarJtSBC7ZXbYdGKzodmk6iRmpdZSu5SSRt+K/Mml1qPGeKql+
pV9k0lyJw3yThvD+WDDQgJMRHGMGoc3xy2o6DDsR741+vLjnXxQJZc6X9GdWlnI3
X7sovBM6unOKK3H/+vy7o0Envs4C4tR+6r7penbbbzCBDMGDF5/WOWSD+qHDiZcm
YnbcbTLEu8GoHHMs/7mGqgZmH2PaeiKb2K2ejv7TwjzM4FDLpLk=
=JvtJ
-----END PGP SIGNATURE-----

--fsyfwTO9fYzfZCd2--