GNU bug report logs - #69541
pre-push hook does not check the ref being pushed

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 4 Mar 2024 11:32:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 04 06:32:54 2024
Received: from localhost ([127.0.0.1]:42160 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rh6Yv-00087M-V4
	for submit <at> debbugs.gnu.org; Mon, 04 Mar 2024 06:32:54 -0500
Received: from lists.gnu.org ([209.51.188.17]:38156)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1rh6Yu-00087F-TR
 for submit <at> debbugs.gnu.org; Mon, 04 Mar 2024 06:32:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rh6YQ-00046k-Tu
 for bug-guix@HIDDEN; Mon, 04 Mar 2024 06:32:23 -0500
Received: from wolfsden.cz ([37.205.8.62])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rh6YH-0004lv-I8
 for bug-guix@HIDDEN; Mon, 04 Mar 2024 06:32:22 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
 id 7526F24ABFC; Mon,  4 Mar 2024 11:32:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1709551931; bh=kqEJT2KYRaKssen4KzjoHHJ6FNdqil7gqxiebLkQZNY=;
 h=Date:From:To:Subject;
 b=Soa2OcBpt5OwIHTnaBRtudMw/J481JOMJxsdnUFzR1YHSZeYr3C0iphwEPKq/UkdL
 CKdt6DyZ9P3t9ZyzbWNExYH5PtTmHCV8uT5QTihB7B8yoS/UYcwQBmVJrJCp20p1E4
 jvUthWEfKg5VHlkYGs2kYtIoUvQB2RzahIRAYz5Sz8l9cRF6XCTBfhP0XhPNVDTGrH
 x8qD58gI8v2ubI/Zh8C1jkGpoWl2RzhanAp0NJ2XrdfR91EuLmBYB5oiKGth7/EHYk
 mMx6yw9ZdCTNiADEr3WqVMo7OJmDxClf1b+OKmKui+7Za0Omop+D8N/JKpzNJeRKqU
 zcxKiGSwl5VljIS6kCJ0bVqxcNXnT7nFpImiIH7W0JBaVsodykGlimjLs1wXHYQhe2
 9YlzfmEIE9g6uTxThdcQHaRdJbuFEVQOzeJghEaagpRH+6og/z39wLGPKrPreac20a
 1WCCJHr9Fqbcg3A5DL8BRXGyes34dcD5Qb+7OFT3eDT2OhQbYPUn8r7IQ768kkIHR6
 l/1nHd6ooqkKjllzsm7r+5n/sk1GZYBcoL7k5NRzqF/AFVFxsD/9GlWT+QlWWpuvmO
 7Ra1ZO62Yqw0nYfIOpUt64K77e6dOHLtJseCDL1LqLcg0J2QiQ7cC7PrnGH/mUTY77
 Dv9veyHOCMyNgBPtLC3XXk3o=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE,
 URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [81.17.16.82])
 by wolfsden.cz (Postfix) with ESMTPSA id 2485724CC0E
 for <bug-guix@HIDDEN>; Mon,  4 Mar 2024 11:32:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1709551931; bh=kqEJT2KYRaKssen4KzjoHHJ6FNdqil7gqxiebLkQZNY=;
 h=Date:From:To:Subject;
 b=Soa2OcBpt5OwIHTnaBRtudMw/J481JOMJxsdnUFzR1YHSZeYr3C0iphwEPKq/UkdL
 CKdt6DyZ9P3t9ZyzbWNExYH5PtTmHCV8uT5QTihB7B8yoS/UYcwQBmVJrJCp20p1E4
 jvUthWEfKg5VHlkYGs2kYtIoUvQB2RzahIRAYz5Sz8l9cRF6XCTBfhP0XhPNVDTGrH
 x8qD58gI8v2ubI/Zh8C1jkGpoWl2RzhanAp0NJ2XrdfR91EuLmBYB5oiKGth7/EHYk
 mMx6yw9ZdCTNiADEr3WqVMo7OJmDxClf1b+OKmKui+7Za0Omop+D8N/JKpzNJeRKqU
 zcxKiGSwl5VljIS6kCJ0bVqxcNXnT7nFpImiIH7W0JBaVsodykGlimjLs1wXHYQhe2
 9YlzfmEIE9g6uTxThdcQHaRdJbuFEVQOzeJghEaagpRH+6og/z39wLGPKrPreac20a
 1WCCJHr9Fqbcg3A5DL8BRXGyes34dcD5Qb+7OFT3eDT2OhQbYPUn8r7IQ768kkIHR6
 l/1nHd6ooqkKjllzsm7r+5n/sk1GZYBcoL7k5NRzqF/AFVFxsD/9GlWT+QlWWpuvmO
 7Ra1ZO62Yqw0nYfIOpUt64K77e6dOHLtJseCDL1LqLcg0J2QiQ7cC7PrnGH/mUTY77
 Dv9veyHOCMyNgBPtLC3XXk3o=
Date: Mon, 4 Mar 2024 12:32:10 +0100
From: Tomas Volf <~@wolfsden.cz>
To: bug-guix@HIDDEN
Subject: pre-push hook does not check the ref being pushed
Message-ID: <ZeWxOkp07ZdcHZle@ws>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="ud2CcBPvnKtiiNME"
Content-Disposition: inline
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
 helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01,
 T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


--ud2CcBPvnKtiiNME
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

the pre-push hook just calls `make authenticate check-channel-news' without any
attempt to actually switch to the ref that it should check.  This means it
always authenticates HEAD, not the ref being pushed.  That seems wrong.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--ud2CcBPvnKtiiNME
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmXlsToACgkQL7/ufbZ/
wakcUw//U1VrowluFrBmiT0xK/KY2OToPLoja/9TjLzUO3ifB9JeWEWQH9BsLX2o
ToNogZdYaHF51XNUlPwZgN4m+m7wUJ8rjsoKs3CfgBBBf504q1VE7FfuPXcE4P8i
vds1/QGjFC6ZuLzf8NZy/nc/AATUzkcCh4++6vUupXrtWSdJ5g3VcuYEURNQBdcI
PnBoMrR931oHok+BK5vnMHUet18IBeB5RJHEhVluEbhL2jffLGai6pGS1yM+HWDm
UcJoNKW6ysmwcs0VKfwgmC/NRiGRK2hCJhgjrfrYyBzgtAnQCt8bQ7lov4BYRlMj
Lzgkbb0aI0XD1NFBPpRiR/OvUVTYqWkM9d9FRZ6deUhoFoZxM54yVllD5xuh09Bc
D2cC1+Ge2tBrpjUUiqMFIQn3tQVuVVU0j9NZVswZMNuj0qGqws+8hcEKtTP1xTNd
QiLhz5OS69On5b/XEHbHAdlC3n/MpyG84WQqz3MFdGa3tXi6XoqO+xXFs4eBDcKX
WSLE3+slkFCQY2GRBwVqC127hE/CKfVOzsSe2hcGRSJsB++ck9dcHG6oxNp0TqBI
j5VD0DzVXlYI7h9ftRIslJsc1SKXeTkbBzTXU8bw0QqNdWQmYyTr9vn5EK/Wylhu
sIRFQqtMoMg8bR9+xOvzJsDzXlJC527b7W7gi69ziwNxuY73Kec=
=RGTN
-----END PGP SIGNATURE-----

--ud2CcBPvnKtiiNME--