Received: (at 69920) by debbugs.gnu.org; 22 Apr 2024 12:42:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 22 08:42:37 2024
Received: from localhost ([127.0.0.1]:45918 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ryt0H-00021V-8G
for submit <at> debbugs.gnu.org; Mon, 22 Apr 2024 08:42:37 -0400
Received: from tilde.club ([142.44.150.184]:54128 ident=postfix)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <alcor@HIDDEN>) id 1ryt0E-00021N-Jd
for 69920 <at> debbugs.gnu.org; Mon, 22 Apr 2024 08:42:35 -0400
Received: from topazii.tilde.club (unknown
[IPv6:2001:9e8:7e0:db00:6372:d642:7ea3:be0c])
by tilde.club (Postfix) with ESMTPSA id 95E0D22565566;
Mon, 22 Apr 2024 12:42:16 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 95E0D22565566
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail;
t=1713789737; bh=yl7ht51Hyel9C1Zl3iYcrB0JEMSH/LId5Gtudl/xsaY=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=TMMlpHi0aCN3hQIVxhSZ3vEulSQSC6jFORU6R3TUpGTWChd0rOqH7wWaJ0t35G5Ww
lmQw1XGXWefAhYtaag/Koxa1mi0JoMZd7YrkYogN1ESRl7lmLWWf8iq48z2C7W7ZKu
FuH6jw8ucDrxIgaVWdoiBBAGX9CLNkGgULI3McTs=
From: Alcor <alcor@HIDDEN>
To: Eric Abrahamsen <eric@HIDDEN>
Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment
previews adds superfluous newlines
In-Reply-To: <87sezejeoh.fsf@HIDDEN> (Eric Abrahamsen's message of
"Sun, 21 Apr 2024 19:48:14 -0700")
References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN>
<86sf0hzb5c.fsf@HIDDEN> <874jcxmfzh.fsf@HIDDEN>
<86bk75z1un.fsf@HIDDEN> <864jce50ju.fsf@HIDDEN> <86bk67f3kq.fsf@HIDDEN>
<87sezejeoh.fsf@HIDDEN>
Date: Mon, 22 Apr 2024 14:42:09 +0200
Message-ID: <875xw9y3fi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69920
Cc: 69920 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Eric Abrahamsen <eric@HIDDEN> writes:
> I also prefer #2, mostly because the other `mm-inline-*' functions here
> all ensure that inlined content ends with a newline, and even if there's
> no immediate consequence to not having it, I'd prefer the consistency.
> Alcor, would you be willing to update your patch?
Hello Eric, Eli =E2=80=93
Attached is an updated patch adjusting the `delete-region' call in the
undisplayer to account for the additional newline, as discussed earlier.
I have tested this change on Emacs 29.3 (Linux/GTK) with multiple
image/png attachments and can confirm it works.
Cheers,
-A.
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-Ensure-that-inline-preview-undisplayer-removes-added.patch
From 31578f2c8d538eb4b944c073d4804f355f88f035 Mon Sep 17 00:00:00 2001
From: "F. Moukayed" <smfadi+emacs@HIDDEN>
Date: Mon, 22 Apr 2024 12:33:08 +0000
Subject: [PATCH] Ensure that inline preview undisplayer removes added newline
* lisp/gnus/mm-view.el (mm-inline-image): Remove the regioninterval b..b+2 (aka "x\n") instead of removing b..b+1 ("x") and leaving behind a superfluous newline (bug#69920).
---
lisp/gnus/mm-view.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 109b6c17c2..223da19a16 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -105,7 +105,7 @@ This is only used if `mm-inline-large-images' is set to
(lambda ()
(let ((inhibit-read-only t))
(remove-images b b)
- (delete-region b (1+ b)))))))
+ (delete-region b (+ b 2)))))))
(defvar mm-w3m-setup nil
"Whether gnus-article-mode has been setup to use emacs-w3m.")
--
2.34.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 22 Apr 2024 02:48:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 22:48:42 2024 Received: from localhost ([127.0.0.1]:45313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ryjjV-0003ra-Vd for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 22:48:42 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:41790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eric@HIDDEN>) id 1ryjjS-0003qN-7Y for 69920 <at> debbugs.gnu.org; Sun, 21 Apr 2024 22:48:40 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@HIDDEN) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D26CEFA059; Mon, 22 Apr 2024 02:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1713754096; bh=VIu4XqGlNiwKkrXpCh3D3HkXNBbCEI02N31QKaR8SKA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KPwTKRR2S4hOSOLm+K2NuHekniBUcwgJmhb13Jx2dsidOXfv73NE4EJraWj0MmLWW ARi5VXp3kGtGxw4n2HLp9e5ocaYWBqkXttp0mNDyyh92tEgV7wJasK08kBv5uHAyq5 3plzuNpAwgEWeXMddDPo81HMh6sgUqXcC6YCC89g= From: Eric Abrahamsen <eric@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines In-Reply-To: <86bk67f3kq.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 18 Apr 2024 12:00:21 +0300") References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN> <86sf0hzb5c.fsf@HIDDEN> <874jcxmfzh.fsf@HIDDEN> <86bk75z1un.fsf@HIDDEN> <864jce50ju.fsf@HIDDEN> <86bk67f3kq.fsf@HIDDEN> Date: Sun, 21 Apr 2024 19:48:14 -0700 Message-ID: <87sezejeoh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org, alcor@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 04/18/24 12:00 PM, Eli Zaretskii wrote: > Ping! Ping! Eric, please chime in. Sorry this has taken so long! >> Cc: 69920 <at> debbugs.gnu.org, alcor@HIDDEN >> Date: Sat, 06 Apr 2024 11:59:33 +0300 >> From: Eli Zaretskii <eliz@HIDDEN> >>=20 >> Ping! Eric, can you please chime in? >>=20 >> > Cc: 69920 <at> debbugs.gnu.org >> > Date: Sat, 23 Mar 2024 12:20:16 +0200 >> > From: Eli Zaretskii <eliz@HIDDEN> >> >=20 >> > > From: Alcor <alcor@HIDDEN> >> > > Cc: 69920 <at> debbugs.gnu.org >> > > Date: Sat, 23 Mar 2024 10:53:22 +0100 >> > >=20 >> > > Eli Zaretskii <eliz@HIDDEN> writes: >> > >=20 >> > > > Are you saying that the problem is with the function that >> > > > "un-displays" the inline image, in that it fails to remove the >> > > > inserted newline? (AFAIU, the code before the above commit also h= ad >> > > > the same issue.) That wasn't clear from the description of the >> > > > problem, and the Subject is ambiguous wrt what newlines are deemed >> > > > "superfluous". So please clarify what is the problem you are flag= ging >> > > > here. >> > >=20 >> > > The problem is that the undisplayer does not correctly undo what the >> > > displayer does. >> > >=20 >> > > The undisplayer (as it is right now) just removes the image. That ca= n be >> > > confirmed by stepping through the code with edebug or by inspecting = the >> > > "b" variable. >> > >=20 >> > > I think we can agree that (delete-region b (1+ b)) will always delete >> > > _exactly one_ character, and in that case that would be the properti= zed >> > > "x" with the image. That would leave a dangling newline. >> > >=20 >> > > There are two ways to solve this: >> > >=20 >> > > 1. Do not add the extra newline (this is what the patch does). >> > > 2. Remove the extra newline via (delete-region b (+ b 2)) =E2=80=93 = note that I >> > > have not tried this, but it would make sense to me. >> > >=20 >> > > I happen to prefer option #1 as the extra newline does not seem to h= ave >> > > any meaningful function. But this is just my own preference (Emacs/g= nus >> > > maintainers may wish to retain the extra newline if it serves a vali= d purpose). >> >=20 >> > I prefer #2. Eric, WDYT? I also prefer #2, mostly because the other `mm-inline-*' functions here all ensure that inlined content ends with a newline, and even if there's no immediate consequence to not having it, I'd prefer the consistency. Alcor, would you be willing to update your patch? Thanks, Eric
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 18 Apr 2024 09:00:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 05:00:57 2024 Received: from localhost ([127.0.0.1]:51162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxNdW-00080O-JO for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:00:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rxNdR-0007z6-68 for 69920 <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:00:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rxNd6-0000Kw-FS; Thu, 18 Apr 2024 05:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hZg/LdjXGEjuBj6t+ZM12uasA697sf2ngLNF23sNc9M=; b=ctVfqYRkv3V7iJVZy/z2 CNPa2+oX3OdDZm7r7b+030+bGGBHLIW+jrkjfsqeiMxdB2KnYYqbKyLB9gyVRXa+g6DGueYvf+YeO 4LYx/aF0T2ZPNtPRx+ACeSNv0LKmLczGf9IM2QVXV+iAxJRzVGDudYYbAeW0LlWCjbbWOos3vvkzN 7ews+hqCNPf3XdD8cDbCDns7DEhytFNDvcajn/XqyY6Xyi8LFt+7ABL2koFACZvM/N2PvqFv78v1v eDZDGhp1yJS+oUsGqCD11SbaBXTQlIyWn3jPwlF/lyn4ZgNwi+aJbREMWDZ3WJF8SNKb4+M9feIbw xjwFKKEOXjCx0A==; Date: Thu, 18 Apr 2024 12:00:21 +0300 Message-Id: <86bk67f3kq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: eric@HIDDEN In-Reply-To: <864jce50ju.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 06 Apr 2024 11:59:33 +0300) Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN> <86sf0hzb5c.fsf@HIDDEN> <874jcxmfzh.fsf@HIDDEN> <86bk75z1un.fsf@HIDDEN> <864jce50ju.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org, alcor@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Eric, please chime in. > Cc: 69920 <at> debbugs.gnu.org, alcor@HIDDEN > Date: Sat, 06 Apr 2024 11:59:33 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Eric, can you please chime in? > > > Cc: 69920 <at> debbugs.gnu.org > > Date: Sat, 23 Mar 2024 12:20:16 +0200 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > From: Alcor <alcor@HIDDEN> > > > Cc: 69920 <at> debbugs.gnu.org > > > Date: Sat, 23 Mar 2024 10:53:22 +0100 > > > > > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > > > > Are you saying that the problem is with the function that > > > > "un-displays" the inline image, in that it fails to remove the > > > > inserted newline? (AFAIU, the code before the above commit also had > > > > the same issue.) That wasn't clear from the description of the > > > > problem, and the Subject is ambiguous wrt what newlines are deemed > > > > "superfluous". So please clarify what is the problem you are flagging > > > > here. > > > > > > The problem is that the undisplayer does not correctly undo what the > > > displayer does. > > > > > > The undisplayer (as it is right now) just removes the image. That can be > > > confirmed by stepping through the code with edebug or by inspecting the > > > "b" variable. > > > > > > I think we can agree that (delete-region b (1+ b)) will always delete > > > _exactly one_ character, and in that case that would be the propertized > > > "x" with the image. That would leave a dangling newline. > > > > > > There are two ways to solve this: > > > > > > 1. Do not add the extra newline (this is what the patch does). > > > 2. Remove the extra newline via (delete-region b (+ b 2)) – note that I > > > have not tried this, but it would make sense to me. > > > > > > I happen to prefer option #1 as the extra newline does not seem to have > > > any meaningful function. But this is just my own preference (Emacs/gnus > > > maintainers may wish to retain the extra newline if it serves a valid purpose). > > > > I prefer #2. Eric, WDYT? > > > > > PS: I'm not sure the original code from > > > before 14ff920dc885636a763d6ab7f256cc9981c24781 was correct either. It > > > used to insert "x\n\n" (3 characters) on display (x being the > > > propertized image) and removed via (delete-region b (+ b 2)) exactly 2 > > > characters. The new code after that revision inserted "x\n" (2 > > > characters, x being the propertized image) and removed via > > > (delete-region b (1+ b)) exactly 1 character. So it might be possible > > > that this off-by-one error in `mm-inline-image' has always existed. > > > > Yes, I think so. > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 6 Apr 2024 08:59:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 06 04:59:50 2024 Received: from localhost ([127.0.0.1]:38246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rt1tt-00070i-MS for submit <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:59:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rt1tq-0006zr-V6 for 69920 <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:59:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rt1tf-0007rK-GH; Sat, 06 Apr 2024 04:59:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xYQNK2Y3PJqfbdA/Ci2rOuZSaT87b6+WQgK3uWkPbeQ=; b=evchYJYOKNd+c2Gjf6wd bG/iouJogA+yi7QdNZ4pRrq6lizYCFcq7nK2vr2P/XcoznfShbeSgoZJxkJoP9qhMlIWH7UfIYfud qNIt66tD5LuKnHi4BQiKDooGa7jerPcPsqL2/leyaWm2i5d1cJXy9dx47HQFr7EMZcnT9a6WOcPvO gegyy7xVe5bdHHwz85Sf3TAuY5j4lyQUOpNxAtuJ3axqx54RaDR0xF/Ai5wB3pMnhNb9vGzL5DKrK WjcHNl6yt2GcgfOHwO0SAaagqlr7QbHyWW47KkjOjj1r/K4UXD/9oUNF8dwge9V75xQcKYGr5vp2t 16Q8orO6plMDTQ==; Date: Sat, 06 Apr 2024 11:59:33 +0300 Message-Id: <864jce50ju.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: eric@HIDDEN In-Reply-To: <86bk75z1un.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 23 Mar 2024 12:20:16 +0200) Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN> <86sf0hzb5c.fsf@HIDDEN> <874jcxmfzh.fsf@HIDDEN> <86bk75z1un.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org, alcor@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Eric, can you please chime in? > Cc: 69920 <at> debbugs.gnu.org > Date: Sat, 23 Mar 2024 12:20:16 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Alcor <alcor@HIDDEN> > > Cc: 69920 <at> debbugs.gnu.org > > Date: Sat, 23 Mar 2024 10:53:22 +0100 > > > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > > Are you saying that the problem is with the function that > > > "un-displays" the inline image, in that it fails to remove the > > > inserted newline? (AFAIU, the code before the above commit also had > > > the same issue.) That wasn't clear from the description of the > > > problem, and the Subject is ambiguous wrt what newlines are deemed > > > "superfluous". So please clarify what is the problem you are flagging > > > here. > > > > The problem is that the undisplayer does not correctly undo what the > > displayer does. > > > > The undisplayer (as it is right now) just removes the image. That can be > > confirmed by stepping through the code with edebug or by inspecting the > > "b" variable. > > > > I think we can agree that (delete-region b (1+ b)) will always delete > > _exactly one_ character, and in that case that would be the propertized > > "x" with the image. That would leave a dangling newline. > > > > There are two ways to solve this: > > > > 1. Do not add the extra newline (this is what the patch does). > > 2. Remove the extra newline via (delete-region b (+ b 2)) – note that I > > have not tried this, but it would make sense to me. > > > > I happen to prefer option #1 as the extra newline does not seem to have > > any meaningful function. But this is just my own preference (Emacs/gnus > > maintainers may wish to retain the extra newline if it serves a valid purpose). > > I prefer #2. Eric, WDYT? > > > PS: I'm not sure the original code from > > before 14ff920dc885636a763d6ab7f256cc9981c24781 was correct either. It > > used to insert "x\n\n" (3 characters) on display (x being the > > propertized image) and removed via (delete-region b (+ b 2)) exactly 2 > > characters. The new code after that revision inserted "x\n" (2 > > characters, x being the propertized image) and removed via > > (delete-region b (1+ b)) exactly 1 character. So it might be possible > > that this off-by-one error in `mm-inline-image' has always existed. > > Yes, I think so. > > > >
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 23 Mar 2024 10:37:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 06:37:35 2024 Received: from localhost ([127.0.0.1]:45111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rnyko-0003FU-LH for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 06:37:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rnykm-0003FE-3L for 69920 <at> debbugs.gnu.org; Sat, 23 Mar 2024 06:37:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rnyU9-0005WI-UX; Sat, 23 Mar 2024 06:20:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GEIPIsgdTa2B4NqqPIMOVeWqGZ79Hbbq1vzaOanw8Jo=; b=LYtFRzFG7BRp8NW6Gz+x a9eJvYIbjLqC2ye8/flWU2py5iumXeItT6fl37oCeTz6JgBt/Au60LhsqzsKBmFeOtMWvcqi4jFye ANWVeYeOUBjBlcoUGeNKyFNEMK0pi9WFI+qYQiBU8D+7q9GmwQgRO//SNJhD5siba7iMUdXgtz9/U +MFNZZdqQxd5SR+n9H+JBuHbpHQnB+9zSQjvCIGKQu+dFcRSNQ4o/9Nz+/pJX4VujAXtQ7zgfZp2G K3TbH70M+2t91lBlp99wJ5OPXvULRye+APFggtTcZXI+Z5bAr6i5JKMokBZd1kFig3ZZv+CWeyWbT uV5XahQ2vRpdww==; Date: Sat, 23 Mar 2024 12:20:16 +0200 Message-Id: <86bk75z1un.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alcor <alcor@HIDDEN>, Eric Abrahamsen <eric@HIDDEN> In-Reply-To: <874jcxmfzh.fsf@HIDDEN> (message from Alcor on Sat, 23 Mar 2024 10:53:22 +0100) Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN> <86sf0hzb5c.fsf@HIDDEN> <874jcxmfzh.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Alcor <alcor@HIDDEN> > Cc: 69920 <at> debbugs.gnu.org > Date: Sat, 23 Mar 2024 10:53:22 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Are you saying that the problem is with the function that > > "un-displays" the inline image, in that it fails to remove the > > inserted newline? (AFAIU, the code before the above commit also had > > the same issue.) That wasn't clear from the description of the > > problem, and the Subject is ambiguous wrt what newlines are deemed > > "superfluous". So please clarify what is the problem you are flagging > > here. > > The problem is that the undisplayer does not correctly undo what the > displayer does. > > The undisplayer (as it is right now) just removes the image. That can be > confirmed by stepping through the code with edebug or by inspecting the > "b" variable. > > I think we can agree that (delete-region b (1+ b)) will always delete > _exactly one_ character, and in that case that would be the propertized > "x" with the image. That would leave a dangling newline. > > There are two ways to solve this: > > 1. Do not add the extra newline (this is what the patch does). > 2. Remove the extra newline via (delete-region b (+ b 2)) – note that I > have not tried this, but it would make sense to me. > > I happen to prefer option #1 as the extra newline does not seem to have > any meaningful function. But this is just my own preference (Emacs/gnus > maintainers may wish to retain the extra newline if it serves a valid purpose). I prefer #2. Eric, WDYT? > PS: I'm not sure the original code from > before 14ff920dc885636a763d6ab7f256cc9981c24781 was correct either. It > used to insert "x\n\n" (3 characters) on display (x being the > propertized image) and removed via (delete-region b (+ b 2)) exactly 2 > characters. The new code after that revision inserted "x\n" (2 > characters, x being the propertized image) and removed via > (delete-region b (1+ b)) exactly 1 character. So it might be possible > that this off-by-one error in `mm-inline-image' has always existed. Yes, I think so.
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 23 Mar 2024 09:55:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 05:55:25 2024 Received: from localhost ([127.0.0.1]:42183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rny61-0001BL-2s for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 05:55:25 -0400 Received: from tilde.club ([142.44.150.184]:43224 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alcor@HIDDEN>) id 1rny5P-00019W-Lg for 69920 <at> debbugs.gnu.org; Sat, 23 Mar 2024 05:54:48 -0400 Received: from topazii.tilde.club (unknown [IPv6:2001:9e8:7d5:6500:2748:b86f:523a:558c]) by tilde.club (Postfix) with ESMTPSA id DB034221B617F; Sat, 23 Mar 2024 09:53:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club DB034221B617F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1711187615; bh=Wp1Kscnkemra0HHK4qchg1zEnbYxvsc7ld592YkFRDQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ta5IwnWKLasHWXFrekHpV6Ybgd5AZgFNMZ3Q8kabtFEZpfpCAhY2HtDGJ7l3Uh4tO fK6sr3ohp8FSzZZpBoxsli94CgnRQbKC04cw5AnAdzwGyukg/mBsM5rlOpYGeJuFQI l7Rh2n24O5uYIMMOtg/ZJdox7JMC8icuGtkLnVXQ= From: Alcor <alcor@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines In-Reply-To: <86sf0hzb5c.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 23 Mar 2024 08:59:27 +0200") References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN> <86sf0hzb5c.fsf@HIDDEN> Date: Sat, 23 Mar 2024 10:53:22 +0100 Message-ID: <874jcxmfzh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Are you saying that the problem is with the function that > "un-displays" the inline image, in that it fails to remove the > inserted newline? (AFAIU, the code before the above commit also had > the same issue.) That wasn't clear from the description of the > problem, and the Subject is ambiguous wrt what newlines are deemed > "superfluous". So please clarify what is the problem you are flagging > here. The problem is that the undisplayer does not correctly undo what the displayer does. The undisplayer (as it is right now) just removes the image. That can be confirmed by stepping through the code with edebug or by inspecting the "b" variable. I think we can agree that (delete-region b (1+ b)) will always delete _exactly one_ character, and in that case that would be the propertized "x" with the image. That would leave a dangling newline. There are two ways to solve this: 1. Do not add the extra newline (this is what the patch does). 2. Remove the extra newline via (delete-region b (+ b 2)) =E2=80=93 note th= at I have not tried this, but it would make sense to me. I happen to prefer option #1 as the extra newline does not seem to have any meaningful function. But this is just my own preference (Emacs/gnus maintainers may wish to retain the extra newline if it serves a valid purpo= se). If it helps clarify things, I'm okay with renaming the bug report to something like "MIME inline image preview undisplayer does not clean up displayed image correctly" or something along these lines. When I filed the report, I wasn't sure about the cause so I described the user-facing issue instead of the actual technical problem. Cheers, -A. PS: I'm not sure the original code from before 14ff920dc885636a763d6ab7f256cc9981c24781 was correct either. It used to insert "x\n\n" (3 characters) on display (x being the propertized image) and removed via (delete-region b (+ b 2)) exactly 2 characters. The new code after that revision inserted "x\n" (2 characters, x being the propertized image) and removed via (delete-region b (1+ b)) exactly 1 character. So it might be possible that this off-by-one error in `mm-inline-image' has always existed.
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 23 Mar 2024 07:09:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 03:09:18 2024 Received: from localhost ([127.0.0.1]:58873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rnvVG-0001hr-0O for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 03:09:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rnvVA-0001gh-Lo for 69920 <at> debbugs.gnu.org; Sat, 23 Mar 2024 03:09:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rnvFc-0005s5-Vd; Sat, 23 Mar 2024 02:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fePJQX+xvK+XZ9WBHHFSvw+rJTGAdW9IFI0yV4dnP+w=; b=d5Lr33oKuaUB RR83NX2htvlTET4c0FoVvovY+cqPQnRfs1rMtOXNTKJDePza8RJjU1fySXcd5XLzidN0TbcMridEE n+LStL8L2vSsCFbPhO7fq6VXF9nuR+rTLR9tdCDMa86ZlLBzuB8OF9hDf993RNYUmSBsFefs4YSF5 tfG9ZRDX0+ytNbFzYeGoIeByhkgSJiH61sYQWVjY0e1iqjERmEzGJI6+BHf2E/oazjOrZUH2f7yTE yKG7mkWt13DKcKybPbR6QPbctYEexji8LS1UrBD+mYd+IkhsrMByEdlKQX1TBuOBDhN43DoKa7UcE Pd/pYcRv0jmnx88/imeiAA==; Date: Sat, 23 Mar 2024 08:52:56 +0200 Message-Id: <86ttkxzbg7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alcor <alcor@HIDDEN>, Eric Abrahamsen <eric@HIDDEN> In-Reply-To: <87wmpuouay.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines References: <87bk78pywn.fsf@HIDDEN> <87wmpuouay.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69920 Cc: 69920 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 22 Mar 2024 22:01:09 +0100 > From: Alcor via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > After some investigation, I noticed that `mm-inline-image' adds a > newline via (insert "\n") directly after `insert-image' for unclear > reasons. I'm guessing this is to make sure text following the image starts on a new line, rather than after the image. Why is the current code a problem? IOW, when does the extra newline cause any harm? You talk about "the issue", but I didn't see any explanation what that issue is. Eric, any comments?
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.
Received: (at 69920) by debbugs.gnu.org; 23 Mar 2024 07:09:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 03:09:17 2024
Received: from localhost ([127.0.0.1]:58870 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rnvVF-0001hi-HF
for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 03:09:17 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55116)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rnvV9-0001gh-Nf
for 69920 <at> debbugs.gnu.org; Sat, 23 Mar 2024 03:09:12 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rnvLm-0006jy-UN; Sat, 23 Mar 2024 02:59:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=qJ2GmKxjvRxda/1x6PcPjMnnmSkaYZyBrExiiLfZAqc=; b=QhtePOtv0/MRJCKTsRse
+JvAx2oeL0HcH705Fy16Oj5+12zYywjTNgBIXkQ4FFHGd249jmMhelwXLXcQXw/aniDc+SF3H+9gZ
qOWbH8hXlFTwsOsEsV6Gjd3r4JNbFCH/gqAWdu9xN19NjOTOPCGf9W1YYG9QPB5x5yfay4oWbC2nc
yxsJ6f2OG9ExQbDqZT0b5dvDxJySQBruf+zGfaUzuaBjUKn845kZcuG87Wtxt+YtVFHDhMQzRPr2x
Y0ga62EfoPv7DBDvvSXdb4/Hj+yNdPjCLUZm3z29IW55qWMumrJsShTMVyNjVdoezCSYHO/b8DdYI
Wi/051oxnl4PAQ==;
Date: Sat, 23 Mar 2024 08:59:27 +0200
Message-Id: <86sf0hzb5c.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Alcor <alcor@HIDDEN>
In-Reply-To: <87y1a952gf.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#69920: Proposed fix - Toggling MIME inline attachment previews
adds superfluous newlines
References: <87wmpuouay.fsf@HIDDEN> <87y1a952gf.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69920
Cc: 69920 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Fri, 22 Mar 2024 23:25:20 +0100
> From: Alcor via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> git blame'ing the line in question on yields a decade-old
> commit. Apparently, this used to be (insert "\n\n") … (delete-region b
> (+ b 2)) about ~10 years ago, and the last relevant change turned that
> into (insert "\n") … (delete-region b (1+ b)), but it seems lots of
> other things on that codepath changed in the meantime.
That commit explains the rationale:
commit 14ff920dc885636a763d6ab7f256cc9981c24781
Author: Katsumi Yamaoka <yamaoka@HIDDEN>
AuthorDate: Fri May 2 09:44:34 2014 +0000
Commit: Katsumi Yamaoka <yamaoka@HIDDEN>
CommitDate: Fri May 2 09:44:34 2014 +0000
Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly
> FWIW, (insert-image … "x") (insert "\n") inserts two characters,
> i.e. the image itself "x" and "\n"
The code inserts the character "x" with a 'display' property on it
(which causes the image to be shown instead of "x"), followed by the
newline.
> so it should either be (insert "\n") … (delete-region b (+ 2 b)) or,
> alternatively just (delete-region b (1+ b)) (without any `insert'
> call).
Are you saying that the problem is with the function that
"un-displays" the inline image, in that it fails to remove the
inserted newline? (AFAIU, the code before the above commit also had
the same issue.) That wasn't clear from the description of the
problem, and the Subject is ambiguous wrt what newlines are deemed
"superfluous". So please clarify what is the problem you are flagging
here.
Thanks.
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at 69920) by debbugs.gnu.org; 22 Mar 2024 23:40:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 19:40:20 2024 Received: from localhost ([127.0.0.1]:58190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rnoUl-0005ER-8C for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 19:40:20 -0400 Received: from tilde.club ([142.44.150.184]:50012 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alcor@HIDDEN>) id 1rnnur-0003Gd-Mx for 69920 <at> debbugs.gnu.org; Fri, 22 Mar 2024 19:03:14 -0400 Received: from topazii.tilde.club (unknown [IPv6:2001:9e8:7cd:5200:bbe8:2b24:626f:ac56]) by tilde.club (Postfix) with ESMTPSA id 3D07D2213F7A6 for <69920 <at> debbugs.gnu.org>; Fri, 22 Mar 2024 22:25:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 3D07D2213F7A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1711146335; bh=dkBXo7j14ZmK1gYfT+zCTMBeXK0ppGOQXejSJffctso=; h=From:To:Subject:In-Reply-To:References:Date:From; b=efcg99h4i6hD4OZx0aHy74Z9AvP5/ChvNUU7jMIcIY7V/NF5v3ZgcuwyzInDmBcEU uMCop1uNEYK4Tjc6AEwE+mLg4UKr3YtLjFuWe8V8gWc6h9nbeD5eOb7H0P8zoqCbHh uyY8fzzwLm00qY8H/JeSMbQpLEjM9g0Zn+LHVqEo= From: Alcor <alcor@HIDDEN> To: 69920 <at> debbugs.gnu.org Subject: Re: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines In-Reply-To: <87wmpuouay.fsf@HIDDEN> (alcor@HIDDEN's message of "Fri, 22 Mar 2024 22:01:09 +0100") References: <87wmpuouay.fsf@HIDDEN> Date: Fri, 22 Mar 2024 23:25:20 +0100 Message-ID: <87y1a952gf.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69920 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Tags: patch Add patch available mark to bug (forgot to do that in the previous message). git blame'ing the line in question on yields a decade-old commit. Apparently, this used to be (insert "\n\n") =E2=80=A6 (delete-regio= n b (+ b 2)) about ~10 years ago, and the last relevant change turned that into (insert "\n") =E2=80=A6 (delete-region b (1+ b)), but it seems lots of other things on that codepath changed in the meantime. FWIW, (insert-image =E2=80=A6 "x") (insert "\n") inserts two characters, i.e. the image itself "x" and "\n", so it should either be (insert "\n") =E2=80=A6 (delete-region b (+ 2 b)) or, alternatively just (delete-region b= (1+ b)) (without any `insert' call).
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.
Received: (at 69920) by debbugs.gnu.org; 22 Mar 2024 21:25:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 17:25:20 2024
Received: from localhost ([127.0.0.1]:50355 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rnmO7-0001jx-7h
for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 17:25:20 -0400
Received: from tilde.club ([142.44.150.184]:44514 ident=postfix)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <alcor@HIDDEN>) id 1rnm1g-0000hr-2b
for 69920 <at> debbugs.gnu.org; Fri, 22 Mar 2024 17:02:08 -0400
Received: from topazii.tilde.club (unknown
[IPv6:2001:9e8:7cd:5200:bbe8:2b24:626f:ac56])
by tilde.club (Postfix) with ESMTPSA id DF07E2213F7A6
for <69920 <at> debbugs.gnu.org>; Fri, 22 Mar 2024 21:01:25 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club DF07E2213F7A6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail;
t=1711141286; bh=jFEcWCoi+atxHRzhjmo03aHTNFbiqEXrgwjZOKkVefA=;
h=From:To:Subject:Date:From;
b=hlxDnygvgvvqnT/+05piLjOoP7V1BHnd5mfajvhrbwbBNxSsEu7j757dUqe0qHmI+
scy+t+j8ICH5GrHbm6WoX0I60rGVMxizWcKI72SJmsi4sPAwPyafCY8gLa0zhBwxiJ
VIQZnbKbXTXerv8KnQJL+1LbZfQNfVUdFunHY6/U=
From: Alcor <alcor@HIDDEN>
To: 69920 <at> debbugs.gnu.org
Subject: Proposed fix - Toggling MIME inline attachment previews adds
superfluous newlines
Date: Fri, 22 Mar 2024 22:01:09 +0100
Message-ID: <87wmpuouay.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69920
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Hi Emacs maintainers,
After some investigation, I noticed that `mm-inline-image' adds a
newline via (insert "\n") directly after `insert-image' for unclear
reasons.
Removing the (insert "\n") form seems to resolve the issue (along with
the other issues mentioned under "Additionally, the following can be
observed") in the initial bug report message.
A patch is included illustrating the change made, but I'm unfamiliar
with the gnus codebase. It would be great if somebody more experienced
took a look.
Cheers,
-A.
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-Do-not-add-a-superfluous-newline-after-insert-image.patch
From f04178b25010f1a91094bea6b4a0fcbc590b14b0 Mon Sep 17 00:00:00 2001
From: "F. Moukayed" <smfadi+emacs@HIDDEN>
Date: Fri, 22 Mar 2024 20:46:21 +0000
Subject: [PATCH] Do not add a superfluous newline after `insert-image'.
* lisp/gnus/mm-view.el (mm-inline-image): Remove unnecessary (insert "\n") to resolve issues with toggling inline attachment previews (bug#69920).
---
lisp/gnus/mm-view.el | 1 -
1 file changed, 1 deletion(-)
diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 3a71920..50636de 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -99,7 +99,6 @@ This is only used if `mm-inline-large-images' is set to
(- (nth 3 edges) (nth 1 edges)))))))
image))
"x")
- (insert "\n")
(mm-handle-set-undisplayer
handle
(lambda ()
--
2.34.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Mar 2024 18:10:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 20 14:10:28 2024 Received: from localhost ([127.0.0.1]:54115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rn0OL-0005sV-FL for submit <at> debbugs.gnu.org; Wed, 20 Mar 2024 14:10:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:38998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alcor@HIDDEN>) id 1rn0Mw-0005lE-SF for submit <at> debbugs.gnu.org; Wed, 20 Mar 2024 14:08:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <alcor@HIDDEN>) id 1rn0E5-0002Yl-Gi for bug-gnu-emacs@HIDDEN; Wed, 20 Mar 2024 13:59:45 -0400 Received: from tilde.club ([142.44.150.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <alcor@HIDDEN>) id 1rn0E2-0006u1-W3 for bug-gnu-emacs@HIDDEN; Wed, 20 Mar 2024 13:59:45 -0400 Received: from topazii.tilde.club (unknown [IPv6:2001:9e8:7fc:7100:4aaf:e9fb:50b0:611e]) by tilde.club (Postfix) with ESMTPSA id 6E38F22111981 for <bug-gnu-emacs@HIDDEN>; Wed, 20 Mar 2024 17:59:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 6E38F22111981 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1710957580; bh=XAcDsiVvwr23p+AjPokzP3SUoKs3E4HtUMCoJPghCvQ=; h=From:To:Subject:Date:From; b=i49p87iJUYA2X8e6Emr+Fi5NuipDd+wXkKrYulLG1rRntKsaa05rhIyO2tfiXHF9X UHNZbU6M1vAL8mw9CvO5wn7CYi806/tEmjhWW1IQaRe0FJSM1K1n4SE2LvoTZdkMOs YYGditVzJmVZo1vm/CxhVrjDuUB14zCcJSTo29dU= From: Alcor <alcor@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.2; gnus: article-mode: Toggling MIME inline attachment previews adds superfluous newlines Date: Wed, 20 Mar 2024 18:59:36 +0100 Message-ID: <87bk78pywn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=142.44.150.184; envelope-from=alcor@HIDDEN; helo=tilde.club X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) 1. Receive an E-Mail message with at least two image attachments (I tried with two image/png files, sent via SMTP and read via IMAP). 2. Go into the gnus summary buffer and view the received message/article. 3. In the "Attachments: ..." line, click on the attachment to toggle the inline preview. 4. Click on the attachment button again to hide the inline preview. 5. Repeat steps 3-4 a number of times (e.g. 10-20 times). 6. Observe as newlines keep getting inserted and accumulate under the preview. Additionally, the following can be observed: - Overlays are added to the attachment button, but are never cleaned up (can be checked with `describe-char' with point on the button). - If there is more than 1 inline-previewable attachment, clicking on the button for attachment #1, then #2, then #1, and #2 in that order breaks the preview state (the inline previews can no longer be hidden). This may be unrelated, however (please advise if a separate bug should be opened for this). In GNU Emacs 29.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2024-03-13 built on lcy02-amd64-051 Repository revision: 900dc1b4bf3011e685a1ec7d7ce4dcd0262ec880 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.4 LTS Configured using: 'configure --prefix=/snap/emacs/current/usr --with-x-toolkit=gtk3 --without-xaw3d --with-modules --with-cairo --with-native-compilation=aot --without-pgtk --with-xinput2 --with-tree-sitter --with-json 'CFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem/build/emacs/stage/usr/include -O2' 'CPPFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem/build/emacs/stage/usr/include' 'LDFLAGS=-L/build/emacs/parts/emacs/install/lib -L/build/emacs/parts/emacs/install/usr/lib -L/build/emacs/parts/emacs/install/lib/x86_64-linux-gnu -L/build/emacs/parts/emacs/install/usr/lib/x86_64-linux-gnu -L/build/emacs/stage/usr/lib'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Article Minor modes in effect: shell-dirtrack-mode: t erc-ring-mode: t erc-notifications-mode: t erc-netsplit-mode: t erc-menu-mode: t erc-list-mode: t erc-irccontrols-mode: t erc-keep-place-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t erc-imenu-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-bufbar-mode: t erc-track-mode: t erc-match-mode: t erc-autojoin-mode: t erc-autoaway-mode: t recentf-mode: t pixel-scroll-precision-mode: t minibuffer-depth-indicate-mode: t global-whitespace-mode: t global-goto-address-mode: t goto-address-mode: t global-auto-revert-mode: t fido-vertical-mode: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t erc-networks-mode: t desktop-save-mode: t windmove-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Features: (shadow emacsbug misearch multi-isearch qp descr-text elec-pair mh-buffers mh-loaddefs gnus-registry registry eieio-base rmailsum rmail gnus-salt gnus-topic gnus-uu yenc gnus-vm shortdoc help-fns radix-tree mailalias smtpmail smerge-mode diff diff-mode sort smiley gnus-cite mm-archive mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml nndraft nnmh nnfolder utf-7 rfc2104 network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache display-line-numbers org-element org-persist org-id org-refile avl-tree generator oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs tramp-cache time-stamp tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell parse-time iso8601 disp-table erc-ring erc-desktop-notifications notifications dbus xml erc-nicks color erc-netsplit erc-menu erc-list erc-goodies erc-imenu imenu erc-pcomplete pcomplete comint ansi-osc ansi-color erc-button erc-fill erc-stamp erc-status-sidebar erc-track erc-match erc-join erc-autoaway leuven-dark-theme recentf tree-widget pixel-scroll cua-base ring mb-depth whitespace goto-addr thingatpt autorevert filenotify icomplete erc derived format-spec erc-backend erc-networks easy-mmode erc-common inline erc-compat pcase compat erc-loaddefs desktop frameset sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util text-property-search time-date mail-utils range mm-util mail-prsvr cus-edit pp cus-load wid-edit windmove xdg site-start comp comp-cstr warnings icons rx cl-extra help-mode erc-autoloads info compat-autoloads markdown-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 735396 84127) (symbols 48 46838 24) (strings 32 190158 4181) (string-bytes 1 5259546) (vectors 16 82583) (vector-slots 8 2226749 106897) (floats 8 679 1292) (intervals 56 3126 636) (buffers 984 33))
Alcor <alcor@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#69920; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.