GNU bug report logs - #69926
29.2; dbus.el doesn't invoke wildcard signal handlers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69926 in the body.
You can then email your comments to 69926 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Church <chrchr <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Wed, 20 Mar 2024 18:22:33 -0700

[Message part 1 (text/plain, inline)]

Per the documentation in for dbus-register-signal in dbus.el:

SERVICE, PATH, INTERFACE and SIGNAL can be nil.  This is
interpreted as a wildcard for the respective argument.

I wrote a little test, cribbed from dbus-test05-register-signal in
dbus-test.el. Where dbus-test-wildcards.el is the attached file:

$ emacs -Q -batch -l ert -l ~/dbus-test-wildcards.el -f
ert-run-tests-batch-and-exit
Running 1 tests (2024-03-20 18:11:55-0700, selector ‘t’)
Test dbus-test05b-register-signal-with-nils backtrace:
  ert-fail("`dbus-test05b-register-signal-with-nils' timed out")
  dbus--test-timeout-handler()
  (progn (dbus--test-timeout-handler))
  (if (eq -with-timeout-value- 'timeout) (progn (dbus--test-timeout-ha
  (let ((-with-timeout-value- (catch 'timeout (let* ((-with-timeout-ti
  (let ((member "Member") (handler #'dbus--test-signal-handler) regist
  (unwind-protect (let ((member "Member") (handler #'dbus--test-signal
  (lambda nil (let ((value-0 (gensym "ert-form-evaluation-aborted-")))
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name dbus-test05b-register-signal-with-nil
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "ert" "-l" "/home/rc/dbus-test-wildcards.el" "-
  command-line()
  normal-top-level()
Test dbus-test05b-register-signal-with-nils condition:
    (ert-test-failed "`dbus-test05b-register-signal-with-nils' timed out")
   FAILED  1/1  dbus-test05b-register-signal-with-nils (1.004025 sec) at
../../../home/rc/dbus-test-wildcards.el:32

Ran 1 tests, 0 results as expected, 1 unexpected (2024-03-20 18:11:56-0700,
1.064641 sec)

1 unexpected results:
   FAILED  dbus-test05b-register-signal-with-nils


Build info:

In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41,
 cairo version 1.18.0) of 2024-02-26, modified by Debian built on
 x86-ubc-02
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/libexec
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils
 --with-native-compilation --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/libexec
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils
 --with-native-compilation --with-cairo --with-x=yes
 --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2
 -ffile-prefix-map=/build/reproducible-path/emacs-29.2+1=.
-fstack-protector-strong
 -fstack-clash-protection -Wformat -Werror=format-security
 -fcf-protection -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2'
 LDFLAGS=-Wl,-z,relro'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2
XPM GTK3 ZLIB

[Message part 2 (text/html, inline)]

[dbus-test-wildcards.el (text/x-emacs-lisp, attachment)]

Message #8 received at 69926 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Robert Church <chrchr <at> gmail.com>
Cc: 69926 <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Fri, 22 Mar 2024 09:23:49 +0100

Robert Church <chrchr <at> gmail.com> writes:

Hi Robert,

> 1 unexpected results:
>    FAILED  dbus-test05b-register-signal-with-nils

Thanks for the report. Unfortunately, it will take some days until I'll
be able to work on this.

Perhaps somebody else could check earliee?

Best regards, Michael.

Message #11 received at 69926 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Robert Church <chrchr <at> gmail.com>
Cc: 69926 <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Sun, 31 Mar 2024 20:02:54 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi Robert,

>> 1 unexpected results:
>>    FAILED  dbus-test05b-register-signal-with-nils
>
> Thanks for the report. Unfortunately, it will take some days until I'll
> be able to work on this.

I could reproduce the bug locally. There is an implementation hole,
indeed.

I've fixed this on the master branch in dbusbind.c, your test file
passes now successfully. Do you have a chance to check this?

Thanks for the bug report and the test, and best regards, Michael.

Message #14 received at 69926 <at> debbugs.gnu.org (full text, mbox):

From: Robert Church <chrchr <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 69926 <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Tue, 2 Apr 2024 16:06:05 -0700

[Message part 1 (text/plain, inline)]

Hi Michael. I dropped your dbusfind.c patch into a 29.3 tree and I can
confirm that it makes the test pass. Thank you!

On Sun, Mar 31, 2024 at 11:02 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
> Hi Robert,
>
> >> 1 unexpected results:
> >>    FAILED  dbus-test05b-register-signal-with-nils
> >
> > Thanks for the report. Unfortunately, it will take some days until I'll
> > be able to work on this.
>
> I could reproduce the bug locally. There is an implementation hole,
> indeed.
>
> I've fixed this on the master branch in dbusbind.c, your test file
> passes now successfully. Do you have a chance to check this?
>
> Thanks for the bug report and the test, and best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #19 received at 69926-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Robert Church <chrchr <at> gmail.com>
Cc: 69926-done <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Wed, 03 Apr 2024 10:16:28 +0200

Version: 30.1

Robert Church <chrchr <at> gmail.com> writes:

> Hi Michael.

Hi Robert,

> I dropped your dbusfind.c patch into a 29.3 tree and I can
> confirm that it makes the test pass. Thank you!

Thanks for the feedback, I'm closing the bug.

I'd like to add your test to dbus-tests.el. However, this requires that
you agree to give the copyright for this (and possible future) change(s)
in Emacs to the FSF. Would you like to sign such an agreement?

Best regards, Michael.

Message #22 received at 69926-done <at> debbugs.gnu.org (full text, mbox):

From: Robert Church <chrchr <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 69926-done <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Wed, 3 Apr 2024 09:57:02 -0700

[Message part 1 (text/plain, inline)]

Yes. I would be happy to do so.

On Wed, Apr 3, 2024 at 1:16 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Version: 30.1
>
> Robert Church <chrchr <at> gmail.com> writes:
>
> > Hi Michael.
>
> Hi Robert,
>
> > I dropped your dbusfind.c patch into a 29.3 tree and I can
> > confirm that it makes the test pass. Thank you!
>
> Thanks for the feedback, I'm closing the bug.
>
> I'd like to add your test to dbus-tests.el. However, this requires that
> you agree to give the copyright for this (and possible future) change(s)
> in Emacs to the FSF. Would you like to sign such an agreement?
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #25 received at 69926 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: 69926 <at> debbugs.gnu.org
Subject: Re: bug#69926: 29.2; dbus.el doesn't invoke wildcard signal handlers
Date: Wed, 03 Apr 2024 19:29:59 +0200

Robert Church <chrchr <at> gmail.com> writes:

> Yes. I would be happy to do so.

Instructions sent off-list.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.