GNU bug report logs - #69971
[PATCH] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Abhishek Cherath <abhi@HIDDEN>; Keywords: patch; Done: Abhishek Cherath <abhi@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.
bug closed, send any further explanations to 69971 <at> debbugs.gnu.org and Abhishek Cherath <abhi@HIDDEN> Request was from Abhishek Cherath <abhi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 18 Apr 2024 03:15:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 23:15:18 2024
Received: from localhost ([127.0.0.1]:49672 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxIF3-0006xb-K9
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 23:15:18 -0400
Received: from mta-15-3.privateemail.com ([198.54.122.111]:13462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1rxIF1-0006wY-9l
 for 69971 <at> debbugs.gnu.org; Wed, 17 Apr 2024 23:15:16 -0400
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id 3EFE718000A3
 for <69971 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 23:14:56 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1713410096; bh=dZFCZ0jxmSdJiCfk/TsU9+q1NAC8ZY+Hvo+u7rY3WQ8=;
 h=From:To:Subject:Date:From;
 b=LOYO9i2T+K+YUD3gZTSZ3scdkk2JdBOwmC9GU1wZbid2NCmnQW7XXCbfW65pjm9l4
 orBRNkiMebPArZP3B5dShCscLyPdXFUhFUr8UDYii2eznYJXsoHrTBWgESD80PdCqb
 Mf4EIqMg77kXi+Mt6E3OWJqsupRxELPIvl1g0UkBp1HT5TBwbgnX+CxzRZQws766cH
 jh3+uK5N+TMV5TaXpUxCvLVmnCTv8m7A+NujeLZo1DxCaos+Ii1oZ0dUF6kQYZlk49
 GlP+vk3cNjs8qkv5OJgzjkR9+oR2fOBLitfhKesWq6JWAib7lrZMvAIu6+js3VPoiN
 bcwx92koA8dCQ==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-15.privateemail.com (Postfix) with ESMTPA
 for <69971 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 23:14:55 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 04698e4a
 for <69971 <at> debbugs.gnu.org>; Thu, 18 Apr 2024 03:14:54 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: close 69971
Date: Wed, 17 Apr 2024 23:14:54 -0400
Message-ID: <87cyqnpdjl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 69971




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 18 Apr 2024 03:09:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 23:09:52 2024
Received: from localhost ([127.0.0.1]:49642 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxI9n-0006fb-Gl
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 23:09:51 -0400
Received: from mta-07-3.privateemail.com ([198.54.118.214]:28177)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1rxI9g-0006eB-RT
 for 69971 <at> debbugs.gnu.org; Wed, 17 Apr 2024 23:09:48 -0400
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id 294F218000A3
 for <69971 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 23:09:25 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1713409765; bh=wqGZOVkX/HHMdxe1jOaOWLmllcKwQC/fZWI7nwOXwuY=;
 h=From:To:Subject:Date:From;
 b=eiSPcpYtRMUyuoPBB78w3kI/JdWziYzizzoLscazkT1wbqJyBFNBT9C4+ZVwzflRt
 iPZwHYlso5gxM4hSEF+BNMGbZ3yIKMtIkgt9yyFhVNlM2ptSAjTJy5ofd73jV2YwIV
 2Gv8Tgk3+wfzD5rqhzTNwuIVSX+7L0xmA4gVWqLeW0Cpr/FzQCP4H3wux1UxHnnCTC
 cS207arfqYrtLRCS3+h3T3GjULFfbF0t/G0YYvncUHem63KBAzp4QTjWzT4A7PB0Up
 Y2e1ZfvaiL+62YQvhKOP+u+Z22ZWJedax26FFo3IupG0MyHRnLMuYT7VWXwIQUvbF2
 qBhc6y4Z4GAXg==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-07.privateemail.com (Postfix) with ESMTPA
 for <69971 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 23:09:24 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id ecb76d9d
 for <69971 <at> debbugs.gnu.org>; Thu, 18 Apr 2024 03:09:22 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: Submitted to gnome-team 
Date: Wed, 17 Apr 2024 23:09:22 -0400
Message-ID: <87ttjzpdst.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 69971

Hello,

I've made the changes and submitted as 70446 to gnome-team.





Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 18:28:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 14:28:38 2024
Received: from localhost ([127.0.0.1]:51542 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrMOc-0003ZR-0J
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:28:38 -0400
Received: from mta-15-3.privateemail.com ([198.54.122.111]:1483)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1rrMOa-0003ZC-3k
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:28:36 -0400
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id A37CE18000A2;
 Mon,  1 Apr 2024 14:28:26 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711996106; bh=eNLNU98V3n+1jz27qlGaSglOFKzFlhFuXd1tn/ljltU=;
 h=Date:From:To:CC:Subject:In-Reply-To:References:From;
 b=TAZ7LW/xwYGfUe6cXlKI5lIA4I2oMzlM2spoxdBoEww1DEZyWGGJQqIz9boN2F8m1
 xniG6TQlUJdxcAOR4245jQ8RV3eMMC41wutfKKTRE3gbSUEuOCcaVbmYzjaE0vQjl4
 olRHdNqobcsK61AsXL1KNKnxwtifxGWgd9ilzOURp7hBTaE2zFw2IPiDJMD9HvMDzT
 xH0q5evslyB/Z13xiXF/8C6JFVUF5BOawlWCt+uyFkF0eiHlEZ80et346JNUhNxAwN
 rwIwSzFMgbvsT9PALMZRK8N+cNuWWyuwhuFWqncCdOLH0Wm6gXH84sKEcg8lRswmgi
 dnNmbhtZLtvOw==
Received: from [127.0.0.1] (adm-129-49-100-252.wi-fi.stonybrook.edu
 [129.49.100.252]) by mta-15.privateemail.com (Postfix) with ESMTPA;
 Mon,  1 Apr 2024 14:28:21 -0400 (EDT)
Date: Mon, 01 Apr 2024 14:28:19 -0400
From: Abhishek Cherath <abhi@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
 Jack Hill <jackhill@HIDDEN>
Subject: =?US-ASCII?Q?Re=3A_=5Bbug=2369971=5D_=5BPATCH_v2=5D_gnu=3A_webkitgtk=3A_A?=
 =?US-ASCII?Q?dd_locale_and_dri_access_to_gtk_sandbox_in_o?=
 =?US-ASCII?Q?rder_to_silence_gtk_locale_warnings_and_enab?=
 =?US-ASCII?Q?le_hardware_accelerated_video=2C_respectively=2E?=
User-Agent: K-9 Mail for Android
In-Reply-To: <78efd7c8fd6278098da04f6d674d73a7035bdd1e.camel@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
 <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
 <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
 <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@HIDDEN>
 <09f45d70-dad9-8447-9ad7-fd1224af874e@HIDDEN>
 <78efd7c8fd6278098da04f6d674d73a7035bdd1e.camel@HIDDEN>
Message-ID: <0C56F12C-EFBF-4373-BB56-6D7BC749FF6A@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

So I've no problem with adding the home profile paths and resubmitting to g=
nome-team, but I'll likely only be able to do that this weekend=2E

If anyone else wants to make the changes or merge this one as is for now, =
I have no problem=2E




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 18:20:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 14:20:31 2024
Received: from localhost ([127.0.0.1]:51531 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrMGk-0003NQ-Si
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:20:31 -0400
Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:50219)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1rrMGe-0003N5-MP
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:20:29 -0400
Received: by mail-ed1-x542.google.com with SMTP id
 4fb4d7f45d1cf-56dd16630d8so999847a12.0
 for <69971 <at> debbugs.gnu.org>; Mon, 01 Apr 2024 11:20:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1711995615; x=1712600415; darn=debbugs.gnu.org;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject
 :date:message-id:reply-to;
 bh=VFwDTwtP7TOGOzR7L4NLwDBSpziE6ZmX2WtJuxsnoIE=;
 b=P+eCkm90F60anwVhPVIY/eDp2yCJbEhTOOcCnaZD97E8p1rbgpfrEJ3mHOG7g70zvI
 YuORD6Kvgeg/8LEzR5vqHSJ7n2eKZHvcwy4n0gdNMwkeSh4n/W0sYfVJkvrBo4KgccfB
 l+/HL57I+BVm/LirIK1EFp8eTW1/O3pHir3cFZXa+cETcUZCFmx3/fTDEbMdW708kiD8
 VRkKMTG4Bme6bdNWXhlN2t6PECr4h7pF6/Y6uaPkcNuQQTWq3cjhG9zI3QwefC/fxDQq
 DkDChqAV8fTJVrjVm013KKRDwfPJSFnaNRz7NYYkwUjqrv29fldgLshurWsDZG/uFUeD
 GkdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1711995615; x=1712600415;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=VFwDTwtP7TOGOzR7L4NLwDBSpziE6ZmX2WtJuxsnoIE=;
 b=tAiClmmnkxY8CO/20ouoER4KYOc4OTdGVyhD6KkYboL4T+Xpz2rngtfWR0dsdCow3j
 rIaBHzTmH9ArF4ZbcPQLFD7oGhul+1XxneGkdmoNR+04DXQYZe9GGLTlVdsKeivqu673
 5Ak069nooGHcwOSlWAVCQx0vvGzBdRoef9u/1g4FHIy5A3NiKAN+rLaOPE4DATuqUF1M
 5+uP3S7Dkyl6L5088sDyNcqbcE0/vHK0Og8yAjgC/xcQzK9m9C4aMs8kJSCiITRuZJX2
 prcNfyUu3yZRGKTZm+juSpoPpf7IAZN4ka6TquntPwLWZ3pMj/BwxYU2zqewaS3it6id
 Q34Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCXZfalR2nC6bvxmqNTrcPeg8aM6skqR+utWBLr2DjaN+aEN7w28ZDA8CNEpZXDoHg8Zryfs03YotKh1hrgtfJTAHAV4gCs=
X-Gm-Message-State: AOJu0YwnOG90q8OZ6iSZBZykckEF6dp1QSht9VAQRodjl1pK4PDHugBc
 +Zcff/YuUtQkoa3B4mc17Yd8a1AkHY9cv5SlOFm1Nik6V0z4vL4P
X-Google-Smtp-Source: AGHT+IF7tTQd79Kekolg8WrzyuCsrPZuUjfdk+8wx5kW1dRCpBsXaBGZvd8/hWt/bV90YL4EzSORWA==
X-Received: by 2002:a50:d69a:0:b0:56b:b7f1:80a2 with SMTP id
 r26-20020a50d69a000000b0056bb7f180a2mr4572456edi.40.1711995615279; 
 Mon, 01 Apr 2024 11:20:15 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 p14-20020a05640210ce00b0056c4f8130c3sm5862562edu.82.2024.04.01.11.20.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 01 Apr 2024 11:20:14 -0700 (PDT)
Message-ID: <78efd7c8fd6278098da04f6d674d73a7035bdd1e.camel@HIDDEN>
Subject: Re: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri
 access to gtk sandbox in order to silence gtk locale warnings and enable
 hardware accelerated video, respectively.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Jack Hill <jackhill@HIDDEN>
Date: Mon, 01 Apr 2024 20:20:13 +0200
In-Reply-To: <09f45d70-dad9-8447-9ad7-fd1224af874e@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
 <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
 <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
 <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@HIDDEN>
 <09f45d70-dad9-8447-9ad7-fd1224af874e@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Abhishek Cherath <abhi@HIDDEN>, Raghav Gururajan <rg@HIDDEN>,
 69971 <at> debbugs.gnu.org, Vivien Kraus <vivien@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Montag, dem 01.04.2024 um 14:11 -0400 schrieb Jack Hill:
> On Mon, 1 Apr 2024, Liliana Marie Prikler wrote:
>=20
> > Ahh, sorry, grafts are for security purposes =E2=80=93 changes like the=
se
> > would have to go through the usual channels (i.e. gnome-team).=C2=A0 We
> > will be jumping ahead to 46 at some point in the future, but for
> > now the branch is chill and we still need to catch up on stuff we
> > missed for master.
>=20
> I don't mean to hold up this patch, however, this reminded me to
> check and  It looks like we'll be do for a rebuild anyway for the new
> major version:=20
> https://webkitgtk.org/2024/03/27/webkigit-2.44.html
Yeah, we're in great luck that we are chill on gnome-team atm.  We can
do these big juicy webkit builds there, then do a mini-merge before we
start real work=E2=84=A2 again.

Cheers





Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 18:11:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 14:11:52 2024
Received: from localhost ([127.0.0.1]:51527 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrM8N-00038C-Rh
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:11:52 -0400
Received: from minsky.hcoop.net ([104.248.1.95]:34976)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jackhill@HIDDEN>) id 1rrM8I-00037s-Nv
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 14:11:50 -0400
Received: from 071-069-176-211.res.spectrum.com ([71.69.176.211]
 helo=mimolette.local)
 by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <jackhill@HIDDEN>)
 id 1rrM86-0001cu-Jt; Mon, 01 Apr 2024 14:11:34 -0400
Date: Mon, 1 Apr 2024 14:11:33 -0400 (EDT)
From: Jack Hill <jackhill@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri access
 to gtk sandbox in order to silence gtk locale warnings and enable
 hardware accelerated video, respectively.
In-Reply-To: <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@HIDDEN>
Message-ID: <09f45d70-dad9-8447-9ad7-fd1224af874e@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
 <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
 <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
 <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1337325124-1711995094=:2928"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Abhishek Cherath <abhi@HIDDEN>, Raghav Gururajan <rg@HIDDEN>,
 69971 <at> debbugs.gnu.org, Vivien Kraus <vivien@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1337325124-1711995094=:2928
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Mon, 1 Apr 2024, Liliana Marie Prikler wrote:

> Ahh, sorry, grafts are for security purposes – changes like these would
> have to go through the usual channels (i.e. gnome-team).  We will be
> jumping ahead to 46 at some point in the future, but for now the branch
> is chill and we still need to catch up on stuff we missed for master.

I don't mean to hold up this patch, however, this reminded me to check and 
It looks like we'll be do for a rebuild anyway for the new major version: 
https://webkitgtk.org/2024/03/27/webkigit-2.44.html

Best
Jack
--8323328-1337325124-1711995094=:2928--




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 17:05:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 13:05:16 2024
Received: from localhost ([127.0.0.1]:51486 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrL5v-0001A6-Hx
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 13:05:15 -0400
Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:42329)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1rrL5t-00019k-9z
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 13:05:13 -0400
Received: by mail-ed1-x543.google.com with SMTP id
 4fb4d7f45d1cf-56c583f5381so5441240a12.1
 for <69971 <at> debbugs.gnu.org>; Mon, 01 Apr 2024 10:05:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1711991104; x=1712595904; darn=debbugs.gnu.org;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject
 :date:message-id:reply-to;
 bh=OsvbkIwfCRvMyEPdZKST6JZJv5LnljcavElmx/PEem0=;
 b=ZXMItKvFfX44P9+4BQlGUYN/foy+Ddbdjw6aC58+reyub6OICq5xmEAeRbb/l2PXDJ
 Lv0EgVLbir7L9skx0SfJ8iLIpon8xgz29dmRX/EsGxdpf5JGCQPYjnY9/qfs/+ResdcU
 ASlG4WsKmFGk7nmOs5WRA70ZMdACEbUTcRm2G080PejTpHDIDaIyrXSn0A1LtwaLNdjz
 iGzIsOObkanr5t1Y+u2jXI22HUk1k4D3HLf/q/SV6qlVHDx5ul8T4XnudipIam5TYAXa
 cqM/AacSokWaqaY+WvDQ0NUppRPiGhYScVJYnlDLcTlG/5WPz7s1rq4SMf66uzo0LMOR
 wqKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1711991104; x=1712595904;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=OsvbkIwfCRvMyEPdZKST6JZJv5LnljcavElmx/PEem0=;
 b=BqMJ3rGAJm4SzLrfvmrOL8N4HrEqzBI4huEXOszWWpC9NoOn73uOT+LOw37ijKnBgS
 0j/YJ0FfYjly/6OKWWF5j07rKV5HB6bhv8hZRo0FFzd9I1NwRB80aoBjDqKkSFOvOLoE
 9ba87H8wK6IFRZBGAtbP8SNcOoRmCUg0FqsvPcbTp9krgw3G0pS4uRxpQsMuvBXs7Sai
 smO6976XoHEyeLxliXf8XnxdY4q2oOkXA6b3E9zR2LiMIq9VQadj+Pxf/l02oAj+LIav
 V+KfkipOhH9DOepfSNxCAHdS9RFlkdxHUXX51tDITvdh48n2ILnwnB03yaZSxvlvJ3qO
 XbGA==
X-Gm-Message-State: AOJu0YwXIq0Cf6zUwPBtXBinifHvC4xGi7z7QxRj9M8IwYEZ4Aucc4ec
 qK2nUd7Mc5lJrqC/t+FOKGajtP58xGzrEvl9xY+oCpNVn18N7HtR
X-Google-Smtp-Source: AGHT+IEyqqIfBjBtlkoMVALdZ6xLR5Z4/paxRvWVgpRGpn3AtVdSCunGGg4nhP7aKH91Ee6cXzGOkA==
X-Received: by 2002:a50:bb49:0:b0:568:a5b5:8591 with SMTP id
 y67-20020a50bb49000000b00568a5b58591mr13144758ede.1.1711991103813; 
 Mon, 01 Apr 2024 10:05:03 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 p12-20020a50c94c000000b005689bfe2688sm5642716edh.39.2024.04.01.10.05.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 01 Apr 2024 10:05:03 -0700 (PDT)
Message-ID: <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@HIDDEN>
Subject: Re: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri
 access to gtk sandbox in order to silence gtk locale warnings and enable
 hardware accelerated video, respectively.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Abhishek Cherath <abhi@HIDDEN>, Maxim Cournoyer
 <maxim.cournoyer@HIDDEN>
Date: Mon, 01 Apr 2024 19:05:01 +0200
In-Reply-To: <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
 <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
 <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Montag, dem 01.04.2024 um 06:49 -0400 schrieb Abhishek Cherath:
> > I think dynamic choices should be possible =E2=80=93 IIRC, std::strings=
 are
> > used for arguments, but even if not, we're dealing with C++, so we
> > can allocate "on the stack".
>=20
> =F0=9F=91=8D. I can make that change tomorrow. One QoL thing. How do you =
run a
> program built in /tmp/<<build_folder>> without it complaining about
> store paths and suchlike?
>=20
> I ask because ideally, I'd debug this by interrupting the webkit
> build somewhere while I have --keep-failed, then `guix shell -D
> webkitgtk --pure && . environment-variables`, then running the
> minibrowser. But that doesn't work because it complains about stuff
> not being in the store.
>=20
> Oh, but I suppose I could use LD_LIBRARY_PATH unless it compiles in
> some strings.=C2=A0 Will try.
You should be able to run things from the build folder, but you could
also throw a post-install error if needed.  Just note that webkitgtk in
and of itself doesn't really come with a full browser, so you'd have to
compile one as well=E2=80=A6

I think with webkit in particular the problem is that store paths are
getting hard-coded in places where file existence is required, so you
might want to replace those store paths with /tmp/guix-build/=E2=80=A6

> > rebuilds from 44.10.=C2=A0 I'd prefer if stuff that rebuilds webkitgtk
> > on master were grafted, as it causes more than the prescribed 300
> > rebuilds and is a nasty build itself.
>=20
> =F0=9F=91=8D, so call this webkitgtk-bubblewrap-fixed and have a replacem=
ent
> field in the other package?
Ahh, sorry, grafts are for security purposes =E2=80=93 changes like these w=
ould
have to go through the usual channels (i.e. gnome-team).  We will be
jumping ahead to 46 at some point in the future, but for now the branch
is chill and we still need to catch up on stuff we missed for master.

Cheers




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 10:50:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 06:50:09 2024
Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrFEu-0006BX-S3
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 06:50:09 -0400
Received: from mta-10-4.privateemail.com ([198.54.122.149]:9408)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1rrFEs-0006Ap-1B
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 06:50:08 -0400
Received: from mta-10.privateemail.com (localhost [127.0.0.1])
 by mta-10.privateemail.com (Postfix) with ESMTP id 604A7180009F;
 Mon,  1 Apr 2024 06:49:56 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711968596; bh=HplJF+v4tVx8/AMeQSnopjmiQhVWwSlX3mmY+lks0iY=;
 h=Date:From:To:CC:Subject:In-Reply-To:References:From;
 b=KXPLkeSMZDER0PxuW6DF+HcWbpJ7nuDO9gLSBHxn2RjZqB/GwfueQs0cCSkMW+Iy8
 rmmBZGgZC809fCt+5EJfOsdgtmYc0AWwGxo7Vte7AiNN+g9k8FiJGkwIJA2w4SCsKN
 pv2ckgVHXtTwEGeR+VySa5pJckTND50DB3PxD+f5Lu6DQ5EakFxbpAIrhMWOuVDBDi
 ufDy6I2UM7Fkts5NtFpU5HDKEQx/XwR7tJP/Fn+nlLZVX/enmHYW5Dl3uHKM4RTjE4
 cFmKlyClWPxqZZYtQbI655VY1P5vuSdo2IxagdK8vdPqkceV0rD0EOdkEuplIOt5oB
 wJ5UnfX6b90eQ==
Received: from [127.0.0.1]
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-10.privateemail.com (Postfix) with ESMTPA;
 Mon,  1 Apr 2024 06:49:51 -0400 (EDT)
Date: Mon, 01 Apr 2024 06:49:50 -0400
From: Abhishek Cherath <abhi@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: =?US-ASCII?Q?Re=3A_=5Bbug=2369971=5D_=5BPATCH_v2=5D_gnu=3A_webkitgtk=3A_A?=
 =?US-ASCII?Q?dd_locale_and_dri_access_to_gtk_sandbox_in_o?=
 =?US-ASCII?Q?rder_to_silence_gtk_locale_warnings_and_enab?=
 =?US-ASCII?Q?le_hardware_accelerated_video=2C_respectively=2E?=
User-Agent: K-9 Mail for Android
In-Reply-To: <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
 <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
Message-ID: <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>I think dynamic choices should be possible =E2=80=93 IIRC, std::strings ar=
e
>used for arguments, but even if not, we're dealing with C++, so we can
>allocate "on the stack"=2E

=F0=9F=91=8D=2E I can make that change tomorrow=2E One QoL thing=2E How do=
 you run a program built in /tmp/<<build_folder>> without it complaining ab=
out store paths and suchlike?

I ask because ideally, I'd debug this by interrupting the webkit build som=
ewhere while I have --keep-failed, then `guix shell -D webkitgtk --pure && =
=2E environment-variables`, then running the minibrowser=2E But that doesn'=
t work because it complains about stuff not being in the store=2E

Oh, but I suppose I could use LD_LIBRARY_PATH unless it compiles in some s=
trings=2E  Will try=2E

>rebuilds from 44=2E10=2E  I'd prefer if stuff that rebuilds webkitgtk on
>master were grafted, as it causes more than the prescribed 300 rebuilds
>and is a nasty build itself=2E

=F0=9F=91=8D, so call this webkitgtk-bubblewrap-fixed and have a replaceme=
nt field in the other package?




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 06:32:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 02:32:18 2024
Received: from localhost ([127.0.0.1]:49336 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrBDO-0002XJ-Ct
	for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 02:32:18 -0400
Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:43193)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1rrBDM-0002X3-CL
 for 69971 <at> debbugs.gnu.org; Mon, 01 Apr 2024 02:32:17 -0400
Received: by mail-ed1-x541.google.com with SMTP id
 4fb4d7f45d1cf-56dd35bc880so909682a12.0
 for <69971 <at> debbugs.gnu.org>; Sun, 31 Mar 2024 23:32:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1711953127; x=1712557927; darn=debbugs.gnu.org;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject
 :date:message-id:reply-to;
 bh=K3Z9AP00Rsrj12p1qQvlebTttC6YtYuflQfB2l6DXNA=;
 b=Q9kYaa0MZR0kLstEjPuxMHrzkNEKrCO2uOdfCgzGywpYWgAENlXgQ8eOy/sM1OecnB
 lVVAb8luZxyBvzZGc24euWc8eOKn90qcPqEGkCKAlkQPawiW/nsSp+wfKXv2U25cTqul
 vy5CZs3kjKTldm2WWFxCNdSDTqjdVaMxlFtPl7/uT1D1KzpKw7Ruz9GE8RasW479uVD7
 Djyrmi5l8NmPXDi/I9jsXOzzCBmFYueEcVstp/8bDywVu0XYb5f6kiDyvGM4q2PUq8R4
 y/waiFwjUSmK/y+RzC/lwu8SDfBco7LGHawuLv6+osmx1fmWOP6ReX2zAaIziMshSfB4
 of+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1711953127; x=1712557927;
 h=mime-version:user-agent:content-transfer-encoding:references
 :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=K3Z9AP00Rsrj12p1qQvlebTttC6YtYuflQfB2l6DXNA=;
 b=OyeFR+pHWQSv1pCrrbaAmnTybkpCrc08UcIdVghCvLcesYmzJ3TvyU48F6Yu+KhJRx
 flUonI7DLTxIcrG9M3SL8Xhy028lFXz79RBxyVpY/eIowxiD0sUfLiMHbzpBEZJThU/T
 uYaGxojUT8aWQFCrnb2CFTggL2qcz/BYKLj1l0R6riGyciyhOojb8XfphsUtddCOIO8X
 RhCyN/etORqW/WBj9JlDaZfCijL0dZFlOb9atqUL6JZNecu9pKRQS6wqPZmTH4URPVte
 19UjpuUsgMeazLnoZHn+BM6OU4CcU8RVuFBHN4VwGiep9Mp9TPWb+/3hib9d1sjoEAeF
 /xgQ==
X-Gm-Message-State: AOJu0YxknISxqto6MqA9SL7lDzZvbIuzSn4dIgm2D7pxeer8gq0sbXca
 EiEbZOrYZwiY1xt5keKnJgpbexo3FOnBLyNRhp4fvX815M/eyJF2
X-Google-Smtp-Source: AGHT+IG+RB1nuvbWKZ06E0fGz1cQbFIdkrKy6W2OGFKbe5tava8G1kYNlHzJNev8WUZ6Q+JOrVGSbw==
X-Received: by 2002:a17:906:670e:b0:a4a:3b6e:1fa9 with SMTP id
 a14-20020a170906670e00b00a4a3b6e1fa9mr6880788ejp.15.1711953127107; 
 Sun, 31 Mar 2024 23:32:07 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 q19-20020a170906a09300b00a4e40e48f8dsm3182620ejy.185.2024.03.31.23.32.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Mar 2024 23:32:06 -0700 (PDT)
Message-ID: <9b96d46745090dfb5c1154c74f56ca9d57440908.camel@HIDDEN>
Subject: Re: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri
 access to gtk sandbox in order to silence gtk locale warnings and enable
 hardware accelerated video, respectively.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Abhishek Cherath <abhi@HIDDEN>, Maxim Cournoyer
 <maxim.cournoyer@HIDDEN>
Date: Mon, 01 Apr 2024 08:32:04 +0200
In-Reply-To: <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN> <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Sonntag, dem 31.03.2024 um 22:17 -0400 schrieb Abhishek Cherath:
> It was a conservative choice, but not made for security reasons, I'm
> just not sure where and how this wrapper runs, and I was mildly tired
> of recompiling webkitgtk.
>=20
> I'm not opposed to having it be $HOME, if that works; I don't see
> what security issues there could be.
I think dynamic choices should be possible =E2=80=93 IIRC, std::strings are
used for arguments, but even if not, we're dealing with C++, so we can
allocate "on the stack".

Am Sonntag, dem 31.03.2024 um 21:33 -0400 schrieb Maxim Cournoyer:
> Liliana, I remember you would prefer not having webkitgtk changes
> happen on master; do you have a suggestion of which branch this
> should be committed to?  gnome-team?
We can do this on gnome-team, we still have some leftover world
rebuilds from 44.10.  I'd prefer if stuff that rebuilds webkitgtk on
master were grafted, as it causes more than the prescribed 300 rebuilds
and is a nasty build itself.

Cheers




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 02:18:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 31 22:18:10 2024
Received: from localhost ([127.0.0.1]:49228 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rr7FR-0007qM-Gt
	for submit <at> debbugs.gnu.org; Sun, 31 Mar 2024 22:18:10 -0400
Received: from mta-12-4.privateemail.com ([198.54.127.107]:28495)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1rr7FP-0007pm-5m
 for 69971 <at> debbugs.gnu.org; Sun, 31 Mar 2024 22:18:08 -0400
Received: from mta-12.privateemail.com (localhost [127.0.0.1])
 by mta-12.privateemail.com (Postfix) with ESMTP id 606471800261;
 Sun, 31 Mar 2024 22:17:57 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711937877; bh=JflHZVgqnU+7Z6XETlYNV4zujl6C18eou9e+faPFlnc=;
 h=Date:From:To:CC:Subject:In-Reply-To:References:From;
 b=DcPA7kC2ZOC4ge7wnP4N1XCg093mM8IvNnNOZGR8uqR75RFEilgz78bq5Zoov18Et
 HV26cwlG/JSr14gUG0R+QajdHHQ9eUUFhjTJ2FeL5CO4gAiMiPafSwrZXhk+KbQDN2
 kHgEAXPQGkW3aYuxDdRnG8TOMoTC3KzZWCGgT4RIpraEJOkYJkd2tiozqee4cIGWUS
 SKfQA7g0sA7dE6A3nMUg0prb/X8iupCFRRrHccqUFrQA3kYekbgdG1nBbcWZj5CaXn
 Y+2/de+RekN+FDjAY39Z1xDG314FoSt2hoxbVa4OjOSz+MmNKpPUv+z1HbqN2sXv65
 IsRW38+F6RMPw==
Received: from [127.0.0.1]
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-12.privateemail.com (Postfix) with ESMTPA;
 Sun, 31 Mar 2024 22:17:52 -0400 (EDT)
Date: Sun, 31 Mar 2024 22:17:50 -0400
From: Abhishek Cherath <abhi@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: =?US-ASCII?Q?Re=3A_=5Bbug=2369971=5D_=5BPATCH_v2=5D_gnu=3A_webkitgtk=3A_A?=
 =?US-ASCII?Q?dd_locale_and_dri_access_to_gtk_sandbox_in_o?=
 =?US-ASCII?Q?rder_to_silence_gtk_locale_warnings_and_enab?=
 =?US-ASCII?Q?le_hardware_accelerated_video=2C_respectively=2E?=
User-Agent: K-9 Mail for Android
In-Reply-To: <87bk6tx3wq.fsf@HIDDEN>
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 <87bk6tx3wq.fsf@HIDDEN>
Message-ID: <E983C543-DFB0-4BA6-BCE2-9DEF3955D7EC@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

It was a conservative choice, but not made for security reasons, I'm just n=
ot sure where and how this wrapper runs, and I was mildly tired of recompil=
ing webkitgtk=2E

I'm not opposed to having it be $HOME, if that works; I don't see what sec=
urity issues there could be=2E



On 31 March 2024 9:33:41=E2=80=AFpm GMT-04:00, Maxim Cournoyer <maxim=2Eco=
urnoyer@gmail=2Ecom> wrote:
>Hello!
>
>Abhishek Cherath <abhi@quic=2Eus> writes:
>
>> * gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths=2Epatch:
>> Add @dridir@ and @localedir@ to bubblewrap gtk sandbox
>> * gnu/packages/webkit=2Escm (webkitgtk)[arguments]: In the
>> 'configure-bubblewrap-store-directory' phase, also supply locale
>> and dri directory paths to webkitgtk-adjust-bubblewrap-paths=2Epatch
>> template=2E
>
>This looks reasonable to me, thanks for your contribution!  I suppose
>for security reasons the file names must be static, e=2Eg=2E cannot be
>$HOME/=2Eguix-profile/share/locale or similar?
>
>LGTM; Liliana, I remember you would prefer not having webkitgtk changes
>happen on master; do you have a suggestion of which branch this should
>be committed to?  gnome-team?
>




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 1 Apr 2024 01:33:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 31 21:33:54 2024
Received: from localhost ([127.0.0.1]:49166 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rr6Yc-0002UP-JW
	for submit <at> debbugs.gnu.org; Sun, 31 Mar 2024 21:33:54 -0400
Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:47566)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1rr6YZ-0002UC-Ov
 for 69971 <at> debbugs.gnu.org; Sun, 31 Mar 2024 21:33:53 -0400
Received: by mail-qk1-x729.google.com with SMTP id
 af79cd13be357-789f1b59a28so253014185a.3
 for <69971 <at> debbugs.gnu.org>; Sun, 31 Mar 2024 18:33:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1711935223; x=1712540023; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=4b1OJZNPMqmwt3Xez9RlBviDcXWx4+ph4f2jaDoPaNw=;
 b=iSMD85yHYejtVOxQcdKG7hwouLhSuBE378k+Aiybrpj8nezbAhPWfu3SSUMQAXCW/i
 YHiP7XGd+6GRnO1jOmwi+C8vizRJQw9mXsuCpNaobsH9ZkYQcEUZOG5uO0AamPh4M82Y
 32fFxe+/3g9w79aw7bejF/ucupk1HNJbycL98nh1ny4U7I88Poz+cE/cygXmF7OPa/1J
 UvC5MDhkkIgkYwWctXa3YjT0VGMlcRp0hPPTFwsH+7ARhJ4Q+Re6hJOKNwt+KoW0StsK
 WE/OR4m1Sy30tB/pHzXeoBl+o+ro8jHlG8CePechc5gRqEonDhCOWca/JGJ0ruQtRpPY
 C32g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1711935223; x=1712540023;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=4b1OJZNPMqmwt3Xez9RlBviDcXWx4+ph4f2jaDoPaNw=;
 b=ksa4wA5/Oz4q+SID5hhnaw2X8MiptmCEf8m1DlH3g9ZbF00u9pUoS5PWbtIyYwJWu4
 fdBfcLsMr65gCcTPwHzhmIK0SSotk8P3VZg5lNAquNMVfogzB4UwiCXaZQoTz3u7tJv2
 bQTnaZg3+nt3CCBdkymWMM42hbYhMqOz2rBRSdnKQuRrOqiRCuholZyZZ80Q+EPMOPzK
 o6I6Q1uEaU6KaSb/voYstIwz4um+wf+qaAXUjR3mttM5SsvcVD2O6crsrhkym688c4Be
 D97usBuIxgm/IPqDXH1oYmivp/PUlyJQGWFRdahkm09aI1o/+T99BGUwOzYYuqzwCCui
 BaAA==
X-Gm-Message-State: AOJu0YzIEmjQpb0vBy6SItghVtK5JkGMreZX9FzRRr5ilpwZLj0Xhnl2
 WJkUscS8nUTLBOdZmDApehPoNpLLKeoqTe9RyPUlczMtISwO8DgS
X-Google-Smtp-Source: AGHT+IHjHEXt6/rMsB02+dg5kgrM2c5a49IeSRbQ5k5XrGf3CdJag/hSaSSFqNQmOq42IkacQyPmRA==
X-Received: by 2002:a05:620a:40ce:b0:789:f6cf:27ee with SMTP id
 g14-20020a05620a40ce00b00789f6cf27eemr11332669qko.18.1711935223246; 
 Sun, 31 Mar 2024 18:33:43 -0700 (PDT)
Received: from hurd (dsl-151-182.b2b2c.ca. [66.158.151.182])
 by smtp.gmail.com with ESMTPSA id
 u6-20020a05620a120600b00789e8860ef7sm3055279qkj.121.2024.03.31.18.33.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Mar 2024 18:33:42 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Abhishek Cherath <abhi@HIDDEN>
Subject: Re: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri
 access to gtk sandbox in order to silence gtk locale warnings and enable
 hardware accelerated video, respectively.
In-Reply-To: <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
 (Abhishek Cherath's message of "Sun, 24 Mar 2024 01:54:50 -0400")
References: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
 <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
Date: Sun, 31 Mar 2024 21:33:41 -0400
Message-ID: <87bk6tx3wq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Raghav Gururajan <rg@HIDDEN>, 69971 <at> debbugs.gnu.org,
 Vivien Kraus <vivien@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello!

Abhishek Cherath <abhi@HIDDEN> writes:

> * gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch:
> Add @dridir@ and @localedir@ to bubblewrap gtk sandbox
> * gnu/packages/webkit.scm (webkitgtk)[arguments]: In the
> 'configure-bubblewrap-store-directory' phase, also supply locale
> and dri directory paths to webkitgtk-adjust-bubblewrap-paths.patch
> template.

This looks reasonable to me, thanks for your contribution!  I suppose
for security reasons the file names must be static, e.g. cannot be
$HOME/.guix-profile/share/locale or similar?

LGTM; Liliana, I remember you would prefer not having webkitgtk changes
happen on master; do you have a suggestion of which branch this should
be committed to?  gnome-team?

-- 
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 24 Mar 2024 21:27:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 24 17:27:02 2024
Received: from localhost ([127.0.0.1]:47500 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1roVMr-0006cX-VX
	for submit <at> debbugs.gnu.org; Sun, 24 Mar 2024 17:27:02 -0400
Received: from mta-11-4.privateemail.com ([198.54.127.104]:21723)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1roVMq-0006c7-Pw
 for 69971 <at> debbugs.gnu.org; Sun, 24 Mar 2024 17:27:01 -0400
Received: from mta-11.privateemail.com (localhost [127.0.0.1])
 by mta-11.privateemail.com (Postfix) with ESMTP id D59B018001C7
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 17:26:12 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711315572; bh=Hig9Qe0JyA42WprvdpjTzxGPA45FGvVmOLrL18D5bbE=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=REBNms8K2XZarscETymJysFnCP8YR+myh6rclAelcceinLouQbYy203dLXkO2ollx
 uQmhOf7j89FmJ5+zqHrEYoJW/+o5cVZXaLYRzs0bb1ua/feYIEKuUneUF86qqvfIsv
 Ueti1MJqnLaGqk2FpfPBxitbC7A0KLObV+v2oPT3isQ7O25VLc032vdv8Y9/K9hV52
 lBp+OwIggTKgc0QJvwDuqcysJpj3+b9yMA4Z1ehF+6wQ8OXm4sm8OJ0UsJd/xkDWni
 I9Lp1h7+3dJVVEEYOM9abQ/JF+sUZgF/OEvxmB0X0On5BHqL8Hp66HCM2FD67Re77k
 v/9rlHYbokxNQ==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-11.privateemail.com (Postfix) with ESMTPA
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 17:26:12 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 8c16679a
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 21:26:11 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: Re: Some more information
In-Reply-To: <87le67iaum.fsf@HIDDEN> (Abhishek Cherath's message of "Sun, 24
 Mar 2024 17:22:25 -0400")
References: <87le67iaum.fsf@HIDDEN>
Date: Sun, 24 Mar 2024 17:26:11 -0400
Message-ID: <87frwfiaoc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> This means that any sandboxed program with access to one of those won't
I mean *without* access.




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 24 Mar 2024 21:23:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 24 17:23:21 2024
Received: from localhost ([127.0.0.1]:47494 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1roVJJ-0006WH-9d
	for submit <at> debbugs.gnu.org; Sun, 24 Mar 2024 17:23:21 -0400
Received: from mta-06-4.privateemail.com ([198.54.122.146]:12287)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1roVJE-0006Vw-3W
 for 69971 <at> debbugs.gnu.org; Sun, 24 Mar 2024 17:23:20 -0400
Received: from mta-06.privateemail.com (localhost [127.0.0.1])
 by mta-06.privateemail.com (Postfix) with ESMTP id 070A418000AD
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 17:22:28 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711315348; bh=wYj5zJbhgq0Wy50GSqEkeqYGkJqYpg/M5qEihjTUfQo=;
 h=From:To:Subject:Date:From;
 b=Xjpbb7KWB0bfvxoR7TgclLWN4qylrMN0Y6VK01ha8DVr1b43tCMBfcSHTEmMEIIBI
 N4SwKMZjAQDeQvx0xNBDDgMJK2WyoMrmkjLBi9U0Dlp1iS/36lJDUpuI+dfXtgSV40
 zkn6jkOwUo93Nbp1ja5F1OHocleFACTiEQBirSdy/jWQjtmLvQGhTsEiUvy2Nmmaoj
 z/2g6OOxIh59X3vJ77gdVGCtITif85UPrXLS2iK+m6guBwks5RYZIb8NcXgTN85F8J
 FnkovbpAoACQDSVRRtf906VzL9bemufxnocDygByJr/20odXx0ZdRuhBDjkfCJjGOM
 4r37rcVSRyyiA==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-06.privateemail.com (Postfix) with ESMTPA
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 17:22:27 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id a909a7ff
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 21:22:25 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: Some more information
Date: Sun, 24 Mar 2024 17:22:25 -0400
Message-ID: <87le67iaum.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The reason the driver path stuff is particularly important is that I get
my env vars for LIBVA_DRIVERS_PATH from guix package --search paths as
follows

```bash
eval "$(guix package --search-paths \
-p $HOME/.config/guix/current \
-p $HOME/.guix-profile \
-p $HOME/.guix-extra-profiles/emacs/emacs \
-p $HOME/.guix-home/profile \
-p /run/current-system/profile)"
```

and this gives the following for LIBVA_DRIVERS_PATH:
```bash
export LIBVA_DRIVERS_PATH="/run/current-system/profile/lib/dri:/home/abhishek/.guix-profile/lib/dri"
```

This means that any sandboxed program with access to one of those won't
be able to use hardware acceleration. I only figured this out when I got
curious about why mpv could use hardware accel just fine but nyxt
couldn't. It's also a problem for firefox. Guess I should put in a bug
report there?




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 24 Mar 2024 06:25:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 24 02:25:21 2024
Received: from localhost ([127.0.0.1]:60083 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1roHIG-0004nU-Ti
	for submit <at> debbugs.gnu.org; Sun, 24 Mar 2024 02:25:21 -0400
Received: from mta-11-4.privateemail.com ([198.54.127.104]:14288)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1roHI1-0004mM-Ah
 for 69971 <at> debbugs.gnu.org; Sun, 24 Mar 2024 02:25:18 -0400
Received: from mta-11.privateemail.com (localhost [127.0.0.1])
 by mta-11.privateemail.com (Postfix) with ESMTP id B94F518000B9
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 02:24:17 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711261457; bh=stLHyDW5iaFIh3rPGIYANTMo40n1RR6tv9SmbKDzbk0=;
 h=From:To:Subject:Date:From;
 b=DrzCmb67aKaTiqnfQ5nsvlKs9enp/8vtnE2Lr43UzS6L/pPz3XT7uyT3D7Q/oayAi
 yHw5X+bfwlJ1raollS1HrzVV+UGo5CS1nRJrn9b5aHelMXxy7h203AKJ7n23lvsKVM
 bj7O4dq3BZGM3RGzqkxo8oqcXmlLDgIFn7WMBClgXjOwnMlIGHz2+qoBUTclaTkjp2
 zDChDOgkRuCl1ATkahFEHxrGIhqDSZEutecXq776kygdYyf9rjl/SKBipj+L/2PZZl
 xO3oAzDeGN55QguW16r6ev6ujbRPueq+Jw+Mj/j/BkF1UYsDQtWoEvHSh2JXZk8Odt
 YBnr2yCMc3cNQ==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-11.privateemail.com (Postfix) with ESMTPA
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 02:24:17 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id c6dad940
 for <69971 <at> debbugs.gnu.org>; Sun, 24 Mar 2024 06:24:16 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: Explanation
Date: Sun, 24 Mar 2024 02:24:16 -0400
Message-ID: <87sf0gi1v3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69971
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

So this patch fixes two things. First, it gives the webkit gtk process
access to va-api drivers, which allows hardware acceleration for video
and prevents the errors below:

0:00:00.489161195    21       0xfd4200 INFO               vadisplay gstvadisplay.c:268:_va_info:<vadisplaydrm2> VA info: Trying to open /home/abhishek/.guix-profile/lib/dri/i965_drv_video.so
0:00:00.489224548    21       0xfd4200 INFO               vadisplay gstvadisplay.c:268:_va_info:<vadisplaydrm2> VA info: Trying to open /run/current-system/profile/lib/dri/i965_drv_video.so
0:00:00.489278879    21       0xfd4200 INFO               vadisplay gstvadisplay.c:268:_va_info:<vadisplaydrm2> VA info: va_openDriver() returns -1
0:00:00.489287135    21       0xfd4200 WARN               vadisplay gstvadisplay.c:316:gst_va_display_initialize:<vadisplaydrm2> vaInitialize: unknown libva error
0:00:00.489302829    21       0xfd4200 ERROR            msdkcontext gstmsdkcontext.c:183:gst_msdk_context_use_vaapi: Couldn't create a VA DRM display

Second, it gives access to the locale dir, which silences some warnings
of the sort below:

(process:2): Gtk-WARNING **: 02:21:08.731: Locale not supported by C library.
	Using the fallback 'C' locale.

Yours sincerely,
Abhishek Cherath.




Information forwarded to guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at 69971 <at> debbugs.gnu.org:


Received: (at 69971) by debbugs.gnu.org; 24 Mar 2024 05:59:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 24 01:59:05 2024
Received: from localhost ([127.0.0.1]:58097 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1roGsr-0003ZN-Ap
	for submit <at> debbugs.gnu.org; Sun, 24 Mar 2024 01:59:05 -0400
Received: from mta-15-3.privateemail.com ([198.54.122.111]:21660)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1roGsn-0003Ya-PL
 for 69971 <at> debbugs.gnu.org; Sun, 24 Mar 2024 01:59:04 -0400
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id 1740F18000A3;
 Sun, 24 Mar 2024 01:58:14 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711259894; bh=4M55HkH2HHfebkPwRTAI0Je+qLKlsu9Vk+wQtQDSa1A=;
 h=From:To:Cc:Subject:Date:From;
 b=UpzsqNtlXCjfnZfRRwe9rayXM4ikBLaUGR6evTxR+rPA6TVeXEOWV38fN6yA5Dc4S
 Vlf0wI2raRfTmbLubxbu+OAu1sIGazfeYcwtJZxPd6D9Pq1tCRhM3oxisNgfnZOX8V
 GgU+/x1urur/4CRyvGpqsaloxSj6U9jiUMSvC1VG06H+D9BoxNz6akasQ2HONyobw5
 3kyjXj/oDixwM+2afleSw4h6o+c+wz7ui/vVjZJdUu5BCy8KzaL8PS89RgsC/F4fs9
 FkG+n+jKgcJQ+Z5+S/gx/PSGIreaD+uD6qt4jE+CGiNe/eiBo9LAlJVbj4rOQVFoRN
 fllpPkLRGnskQ==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-15.privateemail.com (Postfix) with ESMTPA;
 Sun, 24 Mar 2024 01:58:12 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 6e1444b1;
 Sun, 24 Mar 2024 05:58:11 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: 69971 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: webkitgtk: Add locale and dri access to gtk sandbox
 in order to silence gtk locale warnings and enable hardware accelerated video,
 respectively.
Date: Sun, 24 Mar 2024 01:54:50 -0400
Message-ID: <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
 Raghav Gururajan <rg@HIDDEN>,
 Vivien Kraus <vivien@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69971
Cc: Abhishek Cherath <abhi@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch:
Add @dridir@ and @localedir@ to bubblewrap gtk sandbox
* gnu/packages/webkit.scm (webkitgtk)[arguments]: In the
'configure-bubblewrap-store-directory' phase, also supply locale
and dri directory paths to webkitgtk-adjust-bubblewrap-paths.patch
template.

Change-Id: Id1ffe23e56a8da4ff3c81a2cde7d9622f024bdea
---
Messed up dri-dir and locale dir
 .../patches/webkitgtk-adjust-bubblewrap-paths.patch   |  8 +++++++-
 gnu/packages/webkit.scm                               | 11 ++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch b/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
index 18ddb645ad..793f6a414b 100644
--- a/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
+++ b/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
@@ -5,7 +5,7 @@ diff --git a/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp b/Sour
 index f0a5e4b05dff..88b11f806968 100644
 --- a/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
 +++ b/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
-@@ -854,27 +854,12 @@ GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const Proces
+@@ -854,27 +854,18 @@ GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const Proces
          "--ro-bind", "/sys/dev", "/sys/dev",
          "--ro-bind", "/sys/devices", "/sys/devices",
  
@@ -33,6 +33,12 @@ index f0a5e4b05dff..88b11f806968 100644
 +
 +        // Bind mount the store inside the WebKitGTK sandbox.
 +        "--ro-bind", "@storedir@", "@storedir@",
++
++	// This is needed for locales in /run/current-system/locales
++	"--ro-bind-try", "@localedir@", "@localedir@",
++
++	// This is needed for video hardware acceleration (va-api) via /lib/dri
++	"--ro-bind-try", "@dridir@", "@dridir@",
      };
  
      if (launchOptions.processType == ProcessLauncher::ProcessType::DBusProxy) {
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index bf24a65e83..a0d04f31d3 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2019 Marius Bakke <mbakke@HIDDEN>
 ;;; Copyright © 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright © 2022, 2023 Efraim Flashner <efraim@HIDDEN>
+;;; Copyright © 2024 Abhishek Cherath <abhi@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -190,7 +191,15 @@ (define-public webkitgtk
               (let ((store-directory (%store-directory)))
                 (substitute*
                     "Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp"
-                  (("@storedir@") store-directory)))))
+                  (("@storedir@") store-directory)
+                  ;; this adds access to drivers for va-api
+                  ;; for hardware accelerated video
+                  (("@dridir@") "/run/current-system/profile/lib/dri")
+                  ;; this silences gtk locale errors
+                  ;; Unfortunately, simply bind mounting /run/current-system
+                  ;; does not work since it leads to weird issues
+                  ;; with symlinks that confuse bubblewrap.
+                  (("@localedir@") "/run/current-system/locale")))))
           (add-after 'unpack 'do-not-disable-new-dtags
             ;; Ensure the linker uses new dynamic tags as this is what Guix
             ;; uses and validates in the validate-runpath phase.

base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
prerequisite-patch-id: 2feff8a49a2bca7cb55d49c21c04736f9828df0e
prerequisite-patch-id: c3460fa91fad7c4f67859f672420ca72e616d89b
-- 
2.41.0





Information forwarded to liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, rg@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 24 Mar 2024 03:26:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 23:26:49 2024
Received: from localhost ([127.0.0.1]:47797 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1roEVU-0003pZ-Gi
	for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 23:26:49 -0400
Received: from lists.gnu.org ([209.51.188.17]:49056)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <abhi@HIDDEN>) id 1roEVO-0003p0-FP
 for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 23:26:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <abhi@HIDDEN>) id 1roE8c-0001b9-4M
 for guix-patches@HIDDEN; Sat, 23 Mar 2024 23:03:10 -0400
Received: from mta-09-4.privateemail.com ([198.54.127.118])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <abhi@HIDDEN>) id 1roE8O-0000d1-Tr
 for guix-patches@HIDDEN; Sat, 23 Mar 2024 23:03:09 -0400
Received: from mta-09.privateemail.com (localhost [127.0.0.1])
 by mta-09.privateemail.com (Postfix) with ESMTP id DF37318000AD;
 Sat, 23 Mar 2024 23:02:48 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quic.us; s=default;
 t=1711249368; bh=iie0M50JsBe1TZwwN83d9RwqXwF2yyboBPoPEScEVs0=;
 h=From:To:Cc:Subject:Date:From;
 b=m3qQ73GieDSjKqyk+EqPuXBdGTaiiz44lKVVmD6l1/OyJGm/dsdrTrSqn0c5v73i7
 7MTIn/fRuMaUErOokx1xQWkdpGKC3hl163yDgIPyEdUPcHuAMW9GKqffVwgP9zNOWB
 J1NEd6GHxOlr5RfyAVxiV4qFovFg/XBP86hrG974al4/OHeBXIdVmr3qdGZtiUs/KV
 EWd8u0CzkEEvMTcL5xGJgL+KEUXeg2alhlYJEUoKTuO67kfeZzB4PUPag+al/WWhOl
 eh95s9u7HP4d5Z3BWq3Bc4+Fe5qCvXNxgX/E8Jd6O3+R8A4cbkCCNdYz00+O05edRf
 YAenpVD2+EMTQ==
Received: from localhost
 (207-237-25-55.s5642.c3-0.wsd-cbr1.qens-wsd.ny.cable.rcncustomer.com
 [207.237.25.55]) by mta-09.privateemail.com (Postfix) with ESMTPA;
 Sat, 23 Mar 2024 23:02:46 -0400 (EDT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 4d90692a;
 Sun, 24 Mar 2024 03:02:44 +0000 (UTC)
From: Abhishek Cherath <abhi@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: webkitgtk: Add locale and dri access to gtk sandbox in
 order to silence gtk locale warnings and enable hardware accelerated video,
 respectively.
Date: Sat, 23 Mar 2024 22:02:13 -0400
Message-ID: <02189bbb2583491df0be62c56568caa4bf245997.1711245733.git.abhi@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
 Raghav Gururajan <rg@HIDDEN>,
 Vivien Kraus <vivien@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
Received-SPF: pass client-ip=198.54.127.118; envelope-from=abhi@HIDDEN;
 helo=MTA-09-4.privateemail.com
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,
 DKIM_SIGNED=0.1, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01,
 UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Abhishek Cherath <abhi@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch:
Add @dridir@ and @localedir@ to bubblewrap gtk sandbox
* gnu/packages/webkit.scm (webkitgtk)[arguments]: In the
'configure-bubblewrap-store-directory' phase, also supply locale
and dri directory paths to webkitgtk-adjust-bubblewrap-paths.patch
template.

Change-Id: Id1ffe23e56a8da4ff3c81a2cde7d9622f024bdea
---
 .../patches/webkitgtk-adjust-bubblewrap-paths.patch   |  8 +++++++-
 gnu/packages/webkit.scm                               | 11 ++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch b/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
index 18ddb645ad..793f6a414b 100644
--- a/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
+++ b/gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch
@@ -5,7 +5,7 @@ diff --git a/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp b/Sour
 index f0a5e4b05dff..88b11f806968 100644
 --- a/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
 +++ b/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
-@@ -854,27 +854,12 @@ GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const Proces
+@@ -854,27 +854,18 @@ GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const Proces
          "--ro-bind", "/sys/dev", "/sys/dev",
          "--ro-bind", "/sys/devices", "/sys/devices",
  
@@ -33,6 +33,12 @@ index f0a5e4b05dff..88b11f806968 100644
 +
 +        // Bind mount the store inside the WebKitGTK sandbox.
 +        "--ro-bind", "@storedir@", "@storedir@",
++
++	// This is needed for locales in /run/current-system/locales
++	"--ro-bind-try", "@localedir@", "@localedir@",
++
++	// This is needed for video hardware acceleration (va-api) via /lib/dri
++	"--ro-bind-try", "@dridir@", "@dridir@",
      };
  
      if (launchOptions.processType == ProcessLauncher::ProcessType::DBusProxy) {
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index bf24a65e83..4777a9b96e 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2019 Marius Bakke <mbakke@HIDDEN>
 ;;; Copyright © 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright © 2022, 2023 Efraim Flashner <efraim@HIDDEN>
+;;; Copyright © 2024 Abhishek Cherath <abhi@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -190,7 +191,15 @@ (define-public webkitgtk
               (let ((store-directory (%store-directory)))
                 (substitute*
                     "Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp"
-                  (("@storedir@") store-directory)))))
+                  (("@storedir@") store-directory)
+                  ;; this adds access to drivers for va-api
+                  ;; for hardware accelerated video
+                  (("@localedir@") "/run/current-system/profile/lib/dri")
+                  ;; this silences gtk locale errors
+                  ;; Unfortunately, simply bind mounting /run/current-system
+                  ;; does not work since it leads to weird issues
+                  ;; with symlinks that confuse bubblewrap.
+                  (("@dridir@") "/run/current-system/locale")))))
           (add-after 'unpack 'do-not-disable-new-dtags
             ;; Ensure the linker uses new dynamic tags as this is what Guix
             ;; uses and validates in the validate-runpath phase.

base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
prerequisite-patch-id: 2feff8a49a2bca7cb55d49c21c04736f9828df0e
prerequisite-patch-id: c3460fa91fad7c4f67859f672420ca72e616d89b
-- 
2.41.0





Acknowledgement sent to Abhishek Cherath <abhi@HIDDEN>:
New bug report received and forwarded. Copy sent to liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, rg@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, rg@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:
bug#69971; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 18 Apr 2024 03:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.