GNU bug report logs - #69980
[PATCH 00/13] Update and cleanup pre-commit & friends.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Sun, 24 Mar 2024 13:41:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 69980 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:41:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vinicius Monego <monego <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 24 Mar 2024 13:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 00/13] Update and cleanup pre-commit & friends.
Date: Sun, 24 Mar 2024 13:38:37 +0000
Vinicius Monego (13):
  gnu: python-loguru: Remove pre-commit from native-inputs.
  gnu: python-jsonargparse: Remove pre-commit from native-inputs.
  gnu: python-traitlets: Remove pre-commit from native-inputs.
  gnu: python-seaborn: Remove pre-commit from native-inputs.
  gnu: python-rich-click: Remove pre-commit from native-inputs.
  gnu: python-lazy-loader: Remove pre-commit from native-inputs.
  gnu: python-jupytext: Remove pre-commit from native-inputs.
  gnu: python-omnipath: Remove pre-commit from native-inputs.
  gnu: python-cfgv: Update to 3.4.0.
  gnu: Add python-ukkonen.
  gnu: python-identify: Update to 2.5.35.
  gnu: python-nodeenv: Update to 1.8.0.
  gnu: pre-commit: Update to 3.6.2.

 gnu/packages/python-web.scm      |   1 -
 gnu/packages/python-xyz.scm      |  81 +++++++++++------------
 gnu/packages/version-control.scm | 106 +++++++++++++------------------
 3 files changed, 85 insertions(+), 103 deletions(-)


base-commit: bf530017f0e847ae895919b32ef37d79fa636a1e
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 05/13] gnu: python-rich-click: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:30 +0000
* gnu/packages/python-xyz.scm (python-rich-click)[native-inputs]: Remove
python-pre-commit.

Change-Id: I7a1de6166e4fe9f255cff8819b4779e76d7a4537
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 898c884fa5..d8056bc127 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -19588,7 +19588,6 @@ (define-public python-rich-click
     (build-system python-build-system)
     (propagated-inputs
      (list python-click python-importlib-metadata python-rich))
-    (native-inputs (list python-pre-commit))
     (home-page "https://github.com/ewels/rich-click")
     (synopsis "Format click help output nicely with rich")
     (description "Click is a \"Python package for creating beautiful command
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:02 GMT) Full text and rfc822 format available.

Message #11 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 07/13] gnu: python-jupytext: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:32 +0000
* gnu/packages/python-xyz.scm (python-jupytext)[native-inputs]: Remove
pre-commit.

Change-Id: I9e43aa760ef11ffabd0d374593e2e1ea77e9b086
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 77c29edb45..23a6490154 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -375,7 +375,6 @@ (define-public python-jupytext
                                                       " and not "))))))))))
     (native-inputs
      (list git-minimal
-           pre-commit
            python-autopep8
            python-black
            python-flake8
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:02 GMT) Full text and rfc822 format available.

Message #14 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 08/13] gnu: python-omnipath: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:33 +0000
* gnu/packages/python-xyz.scm (python-omnipath)[native-inputs]: Remove
python-pre-commit.

Change-Id: Idfdf978df55e2c3cb3c8447aa18456cc9de4c4c2
---
 gnu/packages/python-web.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index fc01fc4b83..bbe4ddd788 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2101,7 +2101,6 @@ (define-public python-omnipath
            python-wrapt))
     (native-inputs
      (list python-bump2version
-           python-pre-commit
            python-pytest
            python-pytest-mock
            python-requests-mock
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:03 GMT) Full text and rfc822 format available.

Message #17 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 09/13] gnu: python-cfgv: Update to 3.4.0.
Date: Sun, 24 Mar 2024 13:40:34 +0000
* gnu/packages/python-xyz.scm (python-cfgv): Update to 3.4.0.
[build-system]: Use pyproject-build-system.
[arguments]: Do not override the check phase.

Change-Id: Id666a57e4d619697ffa272893930f1c94d5c283e
---
 gnu/packages/python-xyz.scm | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 23a6490154..cead8ece1d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26902,7 +26902,7 @@ (define-public python-dns-lexicon
 (define-public python-cfgv
   (package
     (name "python-cfgv")
-    (version "3.3.1")
+    (version "3.4.0")
     (source
      (origin
        ;; There are no tests in the PyPI tarball.
@@ -26912,15 +26912,8 @@ (define-public python-cfgv
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1pci97cmn3v45sfch9s3lshidrl0309ls9byidic0l8drkwnkwcj"))))
-    (build-system python-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (invoke "pytest" "-vv")))))))
+        (base32 "0g7jg6dssyax6k85lk8afs8qdzgq138g6ij0jmmhgdv5fzks6k9z"))))
+    (build-system pyproject-build-system)
     (native-inputs
      (list python-pytest))
     (home-page "https://github.com/asottile/cfgv")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:03 GMT) Full text and rfc822 format available.

Message #20 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 10/13] gnu: Add python-ukkonen.
Date: Sun, 24 Mar 2024 13:40:35 +0000
* gnu/packages/python-xyz.scm (python-ukkonen): New variable.

Change-Id: I826b003f1c22e5bf28829d9f2adc5f467d17ed45
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index cead8ece1d..03fdccba78 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26691,6 +26691,29 @@ (define-public python-requests-file
 library to allow local file system access via @code{file://} URLs.")
     (license license:asl2.0)))
 
+(define-public python-ukkonen
+  (package
+    (name "python-ukkonen")
+    (version "1.0.1")
+    (source
+     (origin
+       ;; There are no tests in the PyPI tarball.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/asottile/ukkonen")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "17gspl2dsykg000275svvyam4k7wz9ypi9xrfrmsgcgryczravlc"))))
+    (build-system pyproject-build-system)
+    (native-inputs (list python-pytest))
+    (propagated-inputs (list python-cffi))
+    (home-page "https://github.com/asottile/ukkonen")
+    (synopsis "Implementation of bounded Levenshtein distance (Ukkonen)")
+    (description "This package is an implementation of of bounded Levenshtein
+distance (Ukkonen).")
+    (license license:expat)))
+
 (define-public python-identify
   (package
     (name "python-identify")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:43:04 GMT) Full text and rfc822 format available.

Message #23 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 12/13] gnu: python-nodeenv: Update to 1.8.0.
Date: Sun, 24 Mar 2024 13:40:37 +0000
* gnu/packages/python-xyz.scm (python-nodeenv): Update to 1.8.0.
[build-system]: Use pyproject-build-system.
[arguments]: Do not override the check phase, skip tests in #:test-flags
instead.

Change-Id: I01ca1948c30327827d6f76697b471a4d90cd6530
---
 gnu/packages/python-xyz.scm | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d7af0646fc..b8abe5fd75 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26813,7 +26813,7 @@ (define-public python-tldr
 (define-public python-nodeenv
   (package
     (name "python-nodeenv")
-    (version "1.4.0")
+    (version "1.8.0")
     (source
      (origin
        ;; There's no tarball in PyPI.
@@ -26823,15 +26823,13 @@ (define-public python-nodeenv
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0y443icx0w7jlzmxmmcm4q8dqfiwgafbb9cp8jpm68mbqxbz40a7"))))
-    (build-system python-build-system)
+        (base32 "0g8zp8zw5nnfc14ml0sil9yh7lnpz3xrdkazdkwg6pf5jqsxlvv9"))))
+    (build-system pyproject-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda _
-             ;; This test fails. It tries to open a network socket.
-             (invoke "pytest" "-vv" "-k" "not test_smoke"))))))
+     (list #:test-flags
+           #~(list "-k" (string-append
+                         "not test_smoke"
+                         " and not test_smoke_n_system_special_chars"))))
     (native-inputs
      (list python-coverage python-mock python-pytest))
     (home-page "https://ekalinin.github.io/nodeenv/")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:50:02 GMT) Full text and rfc822 format available.

Message #26 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 01/13] gnu: python-loguru: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:26 +0000
* gnu/packages/python-xyz.scm (python-loguru)[native-inputs]: Remove
python-pre-commit.

Change-Id: Id14b518c310c47c19d5911f694248cab22f50d8d
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index aad89d251e..7b7e56a538 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31941,7 +31941,6 @@ (define-public python-loguru
     (native-inputs (list python-colorama
                          python-freezegun
                          python-mypy
-                         python-pre-commit
                          python-pytest
                          python-pytest-cov
                          python-pytest-mypy-plugins
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:50:02 GMT) Full text and rfc822 format available.

Message #29 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 11/13] gnu: python-identify: Update to 2.5.35.
Date: Sun, 24 Mar 2024 13:40:36 +0000
* gnu/packages/python-xyz.scm (python-identify): Update to 2.5.35.
[build-system]: Use pyproject-build-system.
[arguments]: Use G-Expressions. Do not override the check phase.
[native-inputs]: Add python-ukkonen.

Change-Id: I970507dc358029b4e2cc0a295d19db4b28202544
---
 gnu/packages/python-xyz.scm | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 03fdccba78..d7af0646fc 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26717,7 +26717,7 @@ (define-public python-ukkonen
 (define-public python-identify
   (package
     (name "python-identify")
-    (version "1.4.25")
+    (version "2.5.35")
     (source
      (origin
        ;; There are no tests in the PyPI tarball.
@@ -26727,19 +26727,15 @@ (define-public python-identify
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1fqgci6skckcq0x5pnxh6k2qjzn1ndsrgha1j6wwv1ld4g9bd3hz"))))
-    (build-system python-build-system)
+        (base32 "0w1wnh4y6xll3980m555k5g4iwwk31pwjx4j0b5x88bdvfml0h4i"))))
+    (build-system pyproject-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         ;; system-error "utime" "~A" ("No such file or directory")
-         (delete 'ensure-no-mtimes-pre-1980)
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (invoke "pytest" "-vv")))))))
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   ;; system-error "utime" "~A" ("No such file or directory")
+                   (delete 'ensure-no-mtimes-pre-1980))))
     (native-inputs
-     (list python-coverage python-pytest))
+     (list python-coverage python-pytest python-ukkonen))
     (propagated-inputs
      (list python-editdistance))
     (home-page "https://github.com/chriskuehl/identify")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:56:02 GMT) Full text and rfc822 format available.

Message #32 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 04/13] gnu: python-seaborn: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:29 +0000
* gnu/packages/python-xyz.scm (python-seaborn)[native-inputs]: Remove
python-pre-commit.

Change-Id: I8b7016f1d8103dd9297626b7ec74a120fa1c848b
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 261dde03a2..898c884fa5 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -13133,7 +13133,6 @@ (define-public python-seaborn
     (native-inputs
      (list python-flake8
            python-flit-core
-           python-pre-commit
            python-pytest
            python-pytest-cov
            python-pytest-xdist))
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 13:56:03 GMT) Full text and rfc822 format available.

Message #35 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 13/13] gnu: pre-commit: Update to 3.6.2.
Date: Sun, 24 Mar 2024 13:40:38 +0000
* gnu/packages/version-control.scm (pre-commit): Update to 3.6.2.
[build-system]: Use pyproject-build-system.
[arguments]: Use G-Expressions. Do not override the check phase, skip the
tests in #:test-flags instead. Don't make source tree writable in the
prepare-check-env phase.
[native-inputs]: Use the new style.

Change-Id: I4a1c56ce0903d6aa185d65d39c03c9566a6cf0d9
---
 gnu/packages/version-control.scm | 106 +++++++++++++------------------
 1 file changed, 43 insertions(+), 63 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 946b1f5aac..1fc3c7274e 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -29,7 +29,7 @@
 ;;; Copyright © 2020, 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 John D. Boy <jboy <at> bius.moe>
 ;;; Copyright © 2020, 2023 Janneke Nieuwenhuizen <janneke <at> gnu.org>
-;;; Copyright © 2020, 2021, 2022, 2023 Vinicius Monego <monego <at> posteo.net>
+;;; Copyright © 2020, 2021, 2022, 2023, 2024 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;; Copyright © 2020, 2021, 2022 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
@@ -1987,7 +1987,7 @@ (define-public gitile
 (define-public pre-commit
   (package
     (name "pre-commit") ;formerly known as python-pre-commit
-    (version "3.3.3")
+    (version "3.6.2")
     (source
      (origin
        (method git-fetch)               ; no tests in PyPI release
@@ -1996,73 +1996,53 @@ (define-public pre-commit
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1spkg3ld3s6l7wz24lcywlf1z2ywp751bcdlxjfdsln76bi9ylp8"))
+        (base32 "01b8mphyvm961n8hsk4ajqqgm5vwkr2kbi837s231bablnhs8ldf"))
        (modules '((guix build utils)))
        (snippet '(substitute* "setup.cfg"
                    (("virtualenv>=20.10.0") ;our virtualenv (20.3.1) is fine
                     "virtualenv>=20.0.8")))))
-    (build-system python-build-system)
+    (build-system pyproject-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'prepare-check-env
-           (lambda _
-             ;; Change from /homeless-shelter to /tmp for write permission.
-             (setenv "HOME" "/tmp")
-             ;; Environment variables used in the tests.
-             (setenv "GIT_AUTHOR_NAME" "Your Name")
-             (setenv "GIT_COMMITTER_NAME" "Your Name")
-             (setenv "GIT_AUTHOR_EMAIL" "you <at> example.com")
-             (setenv "GIT_COMMITTER_EMAIL" "you <at> example.com")
-             ;; Some tests still fail with PermissionError.  Make the source
-             ;; tree writable.
-             (for-each make-file-writable (find-files "."))
-             ;; Some tests will need a working git repository.
-             (invoke "git" "init")
-             (invoke "git" "config" "--global" "user.name" "Your Name")
-             (invoke "git" "config" "--global" "user.email" "you <at> example.com")))
-         (replace 'check
-           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
-             (add-installed-pythonpath inputs outputs)
-             (when tests?
-               ;; The file below contains 30+ tests that fail because they
-               ;; depend on tools from multiple languages (cargo, npm, cpan,
-               ;; Rscript, etc).  Other tests are passing, but it's more
-               ;; convenient to skip the file than list 30 tests to skip.
-               (invoke "pytest" "--ignore=tests/repository_test.py"
-                       ;; Ruby and Node tests require node and gem.
-                       "--ignore=tests/languages/node_test.py"
-                       "--ignore=tests/languages/ruby_test.py"
-                       ;; Skip lang-specific (network) tests added in 3.1.1
-                       "--ignore=tests/languages/conda_test.py"
-                       "--ignore=tests/languages/coursier_test.py"
-                       "--ignore=tests/languages/dart_test.py"
-                       "--ignore=tests/languages/docker_test.py"
-                       "--ignore=tests/languages/docker_image_test.py"
-                       "--ignore=tests/languages/dotnet_test.py"
-                       "--ignore=tests/languages/golang_test.py"
-                       "--ignore=tests/languages/lua_test.py"
-                       "--ignore=tests/languages/perl_test.py"
-                       "--ignore=tests/languages/rust_test.py"
-                       "--ignore=tests/languages/swift_test.py"
-                       "-k"
-                       (string-append
-                        ;; TODO: these tests fail with AssertionError.  It may
-                        ;; be possible to fix them.
-                        "not test_install_existing_hooks_no_overwrite"
-                        " and not test_uninstall_restores_legacy_hooks"
-                        " and not test_installed_from_venv"
-                        " and not test_healthy_venv_creator"
-                        " and not test_r_hook and not test_r_inline"))))))))
+     (list
+      ;; Skip language-specific tests because they depennd on language tools.
+      #:test-flags
+      #~(list "--ignore" "tests/languages"
+              ;; These fail with AssertionError.
+              "-k" (string-append
+                    "not test_additional_dependencies_roll_forward"
+                    " and not test_control_c_control_c_on_install"
+                    " and not test_invalidated_virtualenv"
+                    " and not test_local_python_repo"
+                    " and not test_install_existing_hooks_no_overwrite"
+                    " and not test_uninstall_restores_legacy_hooks"
+                    " and not test_installed_from_venv"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'prepare-check-env
+            (lambda _
+              ;; Change from /homeless-shelter to /tmp for write permission.
+              (setenv "HOME" "/tmp")
+              ;; Environment variables used in the tests.
+              (setenv "GIT_AUTHOR_NAME" "Your Name")
+              (setenv "GIT_COMMITTER_NAME" "Your Name")
+              (setenv "GIT_AUTHOR_EMAIL" "you <at> example.com")
+              (setenv "GIT_COMMITTER_EMAIL" "you <at> example.com")
+              ;; Some tests still fail with PermissionError.  Make the source
+              ;; tree writable.
+              ;; (for-each make-file-writable (find-files "."))
+              ;; Some tests will need a working git repository.
+              (invoke "git" "init")
+              (invoke "git" "config" "--global" "user.name" "Your Name")
+              (invoke "git" "config" "--global" "user.email" "you <at> example.com"))))))
     (native-inputs
-     `(("git" ,git-minimal)
-       ("python-covdefaults" ,python-covdefaults)
-       ("python-coverage" ,python-coverage)
-       ("python-distlib" ,python-distlib)
-       ("python-pytest" ,python-pytest)
-       ("python-pytest-env" ,python-pytest-env)
-       ("python-re-assert" ,python-re-assert)
-       ("which" ,which)))
+     (list git-minimal
+           python-covdefaults
+           python-coverage
+           python-distlib
+           python-pytest
+           python-pytest-env
+           python-re-assert
+           which))
     ;; Propagate because pre-commit is also used as a module.
     (propagated-inputs
      (list python-cfgv
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 14:00:01 GMT) Full text and rfc822 format available.

Message #38 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 02/13] gnu: python-jsonargparse: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:27 +0000
* gnu/packages/python-xyz.scm (python-jsonargparse)[native-inputs]: Remove
python-pre-commit.

Change-Id: Iac844f4521f985cb07ef407b999dfc7f61605bca
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7b7e56a538..2aec657662 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -4241,7 +4241,6 @@ (define-public python-jsonargparse
     (native-inputs
      (list python-attrs
            python-coverage
-           python-pre-commit
            python-pycodestyle
            python-pydantic
            python-pytest
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 14:00:02 GMT) Full text and rfc822 format available.

Message #41 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 03/13] gnu: python-traitlets: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:28 +0000
* gnu/packages/python-xyz.scm (python-traitlets)[native-inputs]: Remove
python-pre-commit.

Change-Id: I3d36f47e8955c648282bc707fafa57ba00cda933
---
 gnu/packages/python-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2aec657662..261dde03a2 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11708,7 +11708,6 @@ (define-public python-traitlets
     (build-system pyproject-build-system)
     (native-inputs
      (list python-hatchling
-           python-pre-commit
            python-pytest
            python-pytest-mock))
     (home-page "https://ipython.org")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Sun, 24 Mar 2024 14:11:01 GMT) Full text and rfc822 format available.

Message #44 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 06/13] gnu: python-lazy-loader: Remove pre-commit from
 native-inputs.
Date: Sun, 24 Mar 2024 13:40:31 +0000
* gnu/packages/python-xyz.scm (python-lazy-loader)[native-inputs]: Remove
python-pre-commit.

Change-Id: Id360c7c6a34457d95084227805fcd0bad1b30e12
---
 gnu/packages/python-xyz.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d8056bc127..77c29edb45 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -20981,8 +20981,7 @@ (define-public python-lazy-loader
                 "0dwghffnsjjf4pi4gwbl43rx04jmap375hdamafs5cpm6j78js1v"))))
     (build-system pyproject-build-system)
     (native-inputs
-     (list python-pre-commit
-           python-pytest
+     (list python-pytest
            python-pytest-cov))
     (propagated-inputs
      (list python-flit-core))
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#69980; Package guix-patches. (Wed, 17 Apr 2024 22:09:02 GMT) Full text and rfc822 format available.

Message #47 received at 69980 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Vinicius Monego <monego <at> posteo.net>, 69980 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re: [bug#69980] [PATCH 11/13] gnu: python-identify: Update to 2.5.35.
Date: Thu, 18 Apr 2024 00:07:41 +0200
lint complains about permanent redirect from
https://github.com/chriskuehl/identify to
https://github.com/pre-commit/identify


On 2024-03-24 13:40, Vinicius Monego wrote:

> * gnu/packages/python-xyz.scm (python-identify): Update to 2.5.35.
> [build-system]: Use pyproject-build-system.
> [arguments]: Use G-Expressions. Do not override the check phase.
> [native-inputs]: Add python-ukkonen.
>
> Change-Id: I970507dc358029b4e2cc0a295d19db4b28202544
> ---
>  gnu/packages/python-xyz.scm | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 03fdccba78..d7af0646fc 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -26717,7 +26717,7 @@ (define-public python-ukkonen
>  (define-public python-identify
>    (package
>      (name "python-identify")
> -    (version "1.4.25")
> +    (version "2.5.35")
>      (source
>       (origin
>         ;; There are no tests in the PyPI tarball.
> @@ -26727,19 +26727,15 @@ (define-public python-identify
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "1fqgci6skckcq0x5pnxh6k2qjzn1ndsrgha1j6wwv1ld4g9bd3hz"))))
> -    (build-system python-build-system)
> +        (base32 "0w1wnh4y6xll3980m555k5g4iwwk31pwjx4j0b5x88bdvfml0h4i"))))
> +    (build-system pyproject-build-system)
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         ;; system-error "utime" "~A" ("No such file or directory")
> -         (delete 'ensure-no-mtimes-pre-1980)
> -         (replace 'check
> -           (lambda* (#:key tests? #:allow-other-keys)
> -             (when tests?
> -               (invoke "pytest" "-vv")))))))
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   ;; system-error "utime" "~A" ("No such file or directory")
> +                   (delete 'ensure-no-mtimes-pre-1980))))
>      (native-inputs
> -     (list python-coverage python-pytest))
> +     (list python-coverage python-pytest python-ukkonen))
>      (propagated-inputs
>       (list python-editdistance))
>      (home-page "https://github.com/chriskuehl/identify")

-- 
Best regards,
Nicolas Graves




This bug report was last modified 16 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.