GNU bug report logs - #70029
[PATCH] gnu: Add emacs-eglot-jl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70029 in the body.
You can then email your comments to 70029 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: Add emacs-eglot-jl.
Date: Wed, 27 Mar 2024 14:58:08 +0100

* gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d4819c62ce..f2af107671 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12313,6 +12313,33 @@ (define-public emacs-eglot-tempel
 library with Eglot instead of Yasnippet.")
       (license license:gpl3+))))
 
+(define-public emacs-eglot-jl
+  (package
+    (name "emacs-eglot-jl")
+    (version "2.3.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/non-Jedi/eglot-jl.git")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-eglot))
+    (arguments
+     '(#:include '("^[^/]+.el$"
+                   "^[^/]+.jl$"
+                   "^[^/]+.toml$")))
+    (home-page "https://github.com/non-Jedi/eglot-jl")
+    (synopsis "Julia support for eglot")
+    (description
+     "This package adds support for @code{emacs-eglot} to the Julia language.")
+    (license:cc-by2.0)))
+
 (define-public emacs-consult-xdg-recent-files
   (let ((commit "593023ffb99a368152ebd4e739488fa560bdfdea")
         (revision "0"))

base-commit: 656baadf83f2812c0ff79f4f2f0b5f1e927ed8a5
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 70029 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#70029] [PATCH] gnu: Add emacs-eglot-jl.
Date: Wed, 27 Mar 2024 16:59:03 +0100

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Thanks.

> +(define-public emacs-eglot-jl
> +  (package
> +    (name "emacs-eglot-jl")
> +    (version "2.3.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/non-Jedi/eglot-jl.git")

Nitpick: I think ".git" suffixes are usually removed.

> +         (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-eglot))
> +    (arguments
> +     '(#:include '("^[^/]+.el$"
> +                   "^[^/]+.jl$"
> +                   "^[^/]+.toml$")))

This is a bit verbose, and ignores %default-include variable. I suggest
(using G-expressions just because we can)

(arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))

> +    (home-page "https://github.com/non-Jedi/eglot-jl")
> +    (synopsis "Julia support for eglot")

Nitpick: Julia support for Eglot

> +    (description
> +     "This package adds support for @code{emacs-eglot} to the Julia language.")

Nitpick: ... support for Eglot to the Julia language.

> +    (license:cc-by2.0)))

I think there is a typo here. You mean

  (license license:cc-by2.0)

However, it seems to licensed under CC0 terms.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 70029 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 70029 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: Add emacs-eglot-jl.
Date: Thu, 28 Mar 2024 09:55:38 +0100

* gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d4819c62ce..683ea08ed4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12313,6 +12313,30 @@ (define-public emacs-eglot-tempel
 library with Eglot instead of Yasnippet.")
       (license license:gpl3+))))
 
+(define-public emacs-eglot-jl
+  (package
+    (name "emacs-eglot-jl")
+    (version "2.3.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/non-Jedi/eglot-jl")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-eglot))
+    (arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))
+    (home-page "https://github.com/non-Jedi/eglot-jl")
+    (synopsis "Julia support for Eglot")
+    (description
+     "This package adds support for Eglot to the Julia language.")
+    (license license:cc0)))
+
 (define-public emacs-consult-xdg-recent-files
   (let ((commit "593023ffb99a368152ebd4e739488fa560bdfdea")
         (revision "0"))

base-commit: 656baadf83f2812c0ff79f4f2f0b5f1e927ed8a5
-- 
2.41.0

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayeptano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 70029-done <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#70029] [PATCH v1] gnu: Add emacs-eglot-jl.
Date: Fri, 29 Mar 2024 13:29:24 +0100

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Applied. Thanks!

> Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>

Note: Signing off is for the committer, not for the provider of the
patch, if they differ.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.