GNU bug report logs - #70057
[PATCH] gnu: Add python-apprise.

Previous Next

Package: guix-patches;

Reported by: Fabio Natali <me <at> fabionatali.com>

Date: Thu, 28 Mar 2024 16:21:01 UTC

Severity: normal

Tags: patch

Done: "jgart" <jgart <at> dismail.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70057 in the body.
You can then email your comments to 70057 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to lars <at> 6xq.net, marius <at> gnu.org, me <at> bonfacemunyoki.com, sharlatanus <at> gmail.com, tanguy <at> bioneland.org, jgart <at> dismail.de, guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Thu, 28 Mar 2024 16:21:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Fabio Natali <me <at> fabionatali.com>:
New bug report received and forwarded. Copy sent to lars <at> 6xq.net, marius <at> gnu.org, me <at> bonfacemunyoki.com, sharlatanus <at> gmail.com, tanguy <at> bioneland.org, jgart <at> dismail.de, guix-patches <at> gnu.org. (Thu, 28 Mar 2024 16:21:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: guix-patches <at> gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: Add python-apprise.
Date: Thu, 28 Mar 2024 16:15:13 +0000
* gnu/packages/python-xyz.scm (python-apprise): New variable.

Change-Id: I55b8c7b558ce34835cff31b9fac6ff3b81ff5fec
---
Hi! 👋

This is to add Apprise, a push notification Python library.

It seems that Apprise is required if we want to upgrade borgmatic from 1.7.12 to 1.8.9.

I hope the patch looks alright but all feedback is welcome.

Thanks, cheers, Fabio.

 gnu/packages/python-xyz.scm | 46 +++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8a6ef23b58..2cdcc5e51c 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -231,6 +231,7 @@ (define-module (gnu packages python-xyz)
   #:use-module (gnu packages man)
   #:use-module (gnu packages markup)
   #:use-module (gnu packages maths)
+  #:use-module (gnu packages messaging)
   #:use-module (gnu packages monitoring)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages ncurses)
@@ -293,6 +294,51 @@ (define-module (gnu packages python-xyz)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26))
 
+(define-public python-apprise
+  (package
+    (name "python-apprise")
+    (version "1.7.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "apprise" version))
+       (sha256
+        (base32 "0wvs1k71fipn617y9wsdcvwcgg2pd0nvriarlwl4438la4086ppg"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-certifi
+                             python-click
+                             python-dataclasses
+                             python-markdown
+                             python-pyyaml
+                             python-requests
+                             python-requests-oauthlib))
+    (native-inputs (list python-babel
+                         python-coverage
+                         python-cryptography
+                         python-flake8
+                         python-paho-mqtt
+                         python-pytest
+                         python-pytest-cov
+                         python-pytest-mock
+                         python-pytest-xdist
+                         python-wheel))
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (replace 'check
+                     (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+                       (when tests?
+                         (delete-file "test/test_plugin_macosx.py")
+                         (invoke "pytest")))))))
+    (home-page "https://github.com/caronc/apprise")
+    (synopsis
+     "Push notification Python library that works with many platforms")
+    (description
+     "Apprise is a Python library that allows sending push notifications to a broad
+range of notification services, such as Telegram, Discord, Slack, Amazon SNS,
+Gotify, etc.")
+    (license license:bsd-2)))
+
 (define-public python-xmldiff
   (package
     (name "python-xmldiff")

base-commit: fb9549164520ad993c2fbbaedc899844d57baabc
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Thu, 28 Mar 2024 19:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 70057 <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: 70057 <at> debbugs.gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: borgmatic: Update to 1.8.9.
Date: Thu, 28 Mar 2024 19:05:04 +0000
* gnu/packages/backup.scm (borgmatic): Update to 1.8.9.

Change-Id: I28330c4f864b7f15c50fc6c80c5d9c40af91b6b9
---
Hi,

This is to update borgmatic to 1.8.9.

I'm sending this as a follow up to another patch, re python-apprise. In fact,
Apprise is now a borgmatic dependency, at least for some of its new
functionality (notifications).

I'm sorry, I should have probably started this as a patch series, with a short
introductory email. I hope it's still clear and easily reviewable.

Thanks, cheers, Fabio.


 gnu/packages/backup.scm | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 253ab74a19..300f2825c6 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -1308,13 +1308,13 @@ (define-public disarchive
 (define-public borgmatic
   (package
     (name "borgmatic")
-    (version "1.7.12")
+    (version "1.8.9")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "borgmatic" version))
        (sha256
-        (base32 "0720wvs3h2w8h28d7mpvjfp0q37dnrwf1y2ik3y4yr9csih7fmgh"))))
+        (base32 "1xmqv0gg2ic7lp5kmygr9f6qkabsr86mma7pigan12vk2bcdbw31"))))
     (build-system python-build-system)
     (arguments
      (list #:phases
@@ -1339,11 +1339,19 @@ (define-public borgmatic
                      (setenv "PATH" (string-append #$output "/bin"
                                                    ":" (getenv "PATH")))
                      (invoke "pytest")))))))
-    (inputs
-     (list borg python-colorama python-jsonschema python-requests
-           python-ruamel.yaml-0.16))
-    (native-inputs
-     (list python-flexmock python-pytest python-pytest-cov))
+    (inputs (list borg
+                  python-apprise
+                  python-colorama
+                  python-jsonschema
+                  python-requests))
+    (native-inputs (list python-flexmock
+                         python-pytest
+                         python-pytest-cov))
+    (propagated-inputs (list python-colorama
+                             python-jsonschema
+                             python-packaging
+                             python-requests
+                             python-ruamel.yaml))
     (home-page "https://torsion.org/borgmatic/")
     (synopsis "Simple, configuration-driven backup software")
     (description

base-commit: fb9549164520ad993c2fbbaedc899844d57baabc
prerequisite-patch-id: d9e77adec47d85410e146267e3373f4d3a110832
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Fri, 29 Mar 2024 17:10:01 GMT) Full text and rfc822 format available.

Message #11 received at 70057 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Fabio Natali" <me <at> fabionatali.com>, 70057 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Fabio Natali <me <at> fabionatali.com>
Subject: Re: [bug#70057] [PATCH] gnu: Add python-apprise.
Date: Fri, 29 Mar 2024 17:09:36 +0000
Hi Fabio,

Thanks for the patch and your contribution to GNU Guix. I reviewed and applied python-apprise.

I'll take a look at your other patch for borgmatic soon.

all the best,

jgart




Reply sent to "jgart" <jgart <at> dismail.de>:
You have taken responsibility. (Sun, 31 Mar 2024 22:52:02 GMT) Full text and rfc822 format available.

Notification sent to Fabio Natali <me <at> fabionatali.com>:
bug acknowledged by developer. (Sun, 31 Mar 2024 22:52:02 GMT) Full text and rfc822 format available.

Message #16 received at 70057-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Fabio Natali" <me <at> fabionatali.com>, 70057-done <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Fabio Natali <me <at> fabionatali.com>
Subject: Re: [bug#70057] [PATCH]
Date: Sun, 31 Mar 2024 22:51:11 +0000
Hi Fabio,

I reviewed and applied borgmatic with some minor changes.

I consolidated the propagated-inputs to be part of the inputs as it was in the previous existing package. 

Since borgmatic is an end user application we do not need to propagate the Python library dependencies.

I also applied guix style to the package which introduced some formatting changes and mentioned the changes in the commit message.

all the best,

jgart




Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Sun, 31 Mar 2024 22:53:02 GMT) Full text and rfc822 format available.

Message #19 received at 70057-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Fabio Natali" <me <at> fabionatali.com>, 70057-done <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Fabio Natali <me <at> fabionatali.com>
Subject: Re: [bug#70057] [PATCH]
Date: Sun, 31 Mar 2024 22:52:38 +0000
Hi Fabio,

I reviewed and applied borgmatic with some minor changes.

I consolidated the propagated-inputs to be part of the inputs as it was in the previous existing package. 
h
Since borgmatic is an end user application we do not need to propagate the Python library dependencies.

I also applied guix style to the package which introduced some formatting changes and mentioned the changes in the commit message.

all the best,

jgart




Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Sun, 31 Mar 2024 23:24:02 GMT) Full text and rfc822 format available.

Message #22 received at 70057-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Fabio Natali" <me <at> fabionatali.com>, 70057-done <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Fabio Natali <me <at> fabionatali.com>
Subject: Re: [bug#70057] [PATCH]
Date: Sun, 31 Mar 2024 23:23:18 +0000
Hi Fabio,

I reviewed and applied borgmatic with some minor changes.

I consolidated the propagated-inputs to be part of the inputs as it was in the previous existing package. 

Since borgmatic is an end user application we do not need to propagate the Python library dependencies.

I also applied guix style to the package which introduced some formatting changes and mentioned the changes in the commit message.

all the best,

jgart




Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Mon, 01 Apr 2024 10:25:01 GMT) Full text and rfc822 format available.

Message #25 received at 70057-done <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: jgart <jgart <at> dismail.de>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, 70057-done <at> debbugs.gnu.org,
 Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#70057] [PATCH]
Date: Mon, 01 Apr 2024 11:24:36 +0100
On 2024-03-31, 23:23 +0000, "jgart" <jgart <at> dismail.de> wrote:
> I reviewed and applied borgmatic with some minor changes.

This is brilliant, thanks for helping with this jgart!

Have a lovely day. Cheers, Fabio.




Information forwarded to guix-patches <at> gnu.org:
bug#70057; Package guix-patches. (Mon, 01 Apr 2024 15:56:02 GMT) Full text and rfc822 format available.

Message #28 received at 70057-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Fabio Natali" <me <at> fabionatali.com>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>, 70057-done <at> debbugs.gnu.org,
 Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#70057] [PATCH]
Date: Mon, 01 Apr 2024 15:55:21 +0000
> This is brilliant, thanks for helping with this jgart!
> 
> Have a lovely day. Cheers, Fabio.

Anytime! Excuse the duplicate emails. My email client was acting up.

all best,

jgart




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 30 Apr 2024 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.