Received: (at 70086) by debbugs.gnu.org; 4 May 2024 04:15:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 00:15:41 2024
Received: from localhost ([127.0.0.1]:50991 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s36oG-000253-Uj
for submit <at> debbugs.gnu.org; Sat, 04 May 2024 00:15:41 -0400
Received: from seagreen.cherry.relay.mailchannels.net ([23.83.223.160]:58429)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <adam@HIDDEN>)
id 1s36o6-00024t-8u; Sat, 04 May 2024 00:15:37 -0400
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 4125F82248;
Sat, 4 May 2024 04:15:05 +0000 (UTC)
Received: from pdx1-sub0-mail-a265.dreamhost.com (unknown [127.0.0.6])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id DEDF182010;
Sat, 4 May 2024 04:15:04 +0000 (UTC)
ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1714796104; a=rsa-sha256;
cv=none;
b=uOmDlMQBm+hsFAyuFdKTiMjGUzLBdB3Mr4QIh9q7fYh9wiqAOU/KkmB7HJdPpsMV46mYky
y9iXMK8B5+qTWT71PT7dFTY58TetGu9z55MZm5R1fsAk5sSUb7AC+avdhV7pHIRQxBJZ1i
2ReM9h1z9eQpVGnA3vjXfLTT0grsbOdKsVfd7FoBj2mVrxiX5s6a7TaX75KSYCH9Tb5lvp
4SR/IyXQsT9LqPNR1r4OvQGB3u4dYn1N/ojx2AC2lZSw5srmvptgHFNed0LKMM1GROBA0s
5LMhDf+rf1kzF72GqfrJTt9OQ/dwSwbzzSnGdw/4o2MpwrWTWNzCoHiFQCiA2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
d=mailchannels.net; s=arc-2022; t=1714796104;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:dkim-signature;
bh=p6IKlLnWo5W+ZGFRD5OO8kf6gDkTVjm2EEw7MEPhLqA=;
b=TuQBzixD8ZIyg4CiS7V5rI3kG57TF76dnmEzeA84HN+bY71MKH0EVleZDl2L23gneBcMzU
ZJ7XbPZHyqEJR6GKUoqoLRsXf0H8p6HukdXGIw6laWOPcXTaO2i+wBaxrvc45bXzlzl339
VnreHpdCsYCXqaUpZ6SmZdx89NPUVNuM6aNro597Frt8LpN9B8g565F11w+G/u6uxXUagu
kdG0nFeZSxyqX5gWsOpglhqLEqu5JyxbjwlEYgn9y9IqCra6qH17xyTqOEi7PMqjIViXOU
XuVbllx0jypqCg+FR4kDi9rdPigOuwMqk/8TGrWFuCmuvYKC/5y58hrZIiSZgw==
ARC-Authentication-Results: i=1; rspamd-5bcfdc8c55-dchvv;
auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@HIDDEN
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|adam@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Arch-Reign: 506c03ec27bc7452_1714796105150_1298216907
X-MC-Loop-Signature: 1714796105150:1937996671
X-MC-Ingress-Time: 1714796105149
Received: from pdx1-sub0-mail-a265.dreamhost.com (pop.dreamhost.com
[64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384)
by 100.124.116.44 (trex/6.9.2); Sat, 04 May 2024 04:15:05 +0000
Received: from [10.28.0.50] (unknown [45.131.192.18])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
(Authenticated sender: adam@HIDDEN)
by pdx1-sub0-mail-a265.dreamhost.com (Postfix) with ESMTPSA id 4VWZ882XPzz5h;
Fri, 3 May 2024 21:15:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net;
s=dreamhost; t=1714796104;
bh=p6IKlLnWo5W+ZGFRD5OO8kf6gDkTVjm2EEw7MEPhLqA=;
h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding;
b=epFxiBiKgt4dnhpzycFY5Lj3VyDOLd2tvZOHRc1o4oLmMx3X/unl5GhVoEPp0rKHM
MU+yyS72LJg4aeIGFp7QKlixKZl9Tb6yoxX4IWupsiLxsKWZZnOcQm0eEYXX6Imfjp
Z6PKYD6vOiVzO6EM/4PZBDJYiQGMuXHEsglLfLCqLB7YUnDzgFvWnQcV9PzZrkkVl+
8HqnXy81v9/wFZ95NgYqrfgZj3B4WdiOljd8A471Vc66SDSJ72XL2oFB3dcSc3IbX1
uqs2Iia3A6MI9LrDqE84o5HxyPE6wWA/gCDcou+NAUf5Q5ljnm7nGSjeD2vKdfCdbB
RIIz0mux7D8xw==
Message-ID: <cd55aa40-1101-4461-9b21-789f4eca732b@HIDDEN>
Date: Fri, 3 May 2024 23:15:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in
keymap properties
To: Juri Linkov <juri@HIDDEN>
References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN>
<86ttknd3kd.fsf@HIDDEN>
<6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN>
<865xwv7oxo.fsf@HIDDEN>
<6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN>
<86cyqxeqa9.fsf@HIDDEN> <86zft85cai.fsf@HIDDEN>
<8b894304-a50d-45b8-94a4-3737bcbfad34@HIDDEN>
<86wmobbev6.fsf@HIDDEN>
Content-Language: en-US
From: Adam Porter <adam@HIDDEN>
In-Reply-To: <86wmobbev6.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 70086
Cc: control <at> debbugs.gnu.org, 70086 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
> Could you please distill this example into a self-contained test case
> like you did the previous time, that helped a lot.
Ok, the following code seems to demonstrate the problem, with your patch
applied to tab-bar.el:
(require 'cl-lib)
(defvar tab-bar-ecm-keymap
(let ((map (make-sparse-keymap)))
(define-key map [tab-bar mouse-1] (lambda (&rest _)
(interactive)
(message "tab-bar-ecm-lighter clicked with mouse-1")))
map))
(defvar tab-bar-ecm-lighter "TAB-BAR-ECM-LIGHTER ")
(define-minor-mode tab-bar-ecm-mode "DOCSTRING"
:global t
(let ((lighter `(tab-bar-ecm-mode
(:propertize tab-bar-ecm-lighter keymap ,tab-bar-ecm-keymap))))
(if tab-bar-ecm-mode
(progn
(cl-pushnew lighter global-mode-string :test #'equal)
(unless (memq 'tab-bar-format-global tab-bar-format)
(cl-callf append tab-bar-format '(tab-bar-format-global))))
(cl-callf2 remove lighter global-mode-string))))
(defvar tab-bar-ecm-keymap2
(let ((map (make-sparse-keymap)))
(define-key map [tab-bar mouse-1] (lambda (&rest _)
(interactive)
(message "tab-bar-ecm-lighter2 clicked with mouse-1")))
map))
(defvar tab-bar-ecm-lighter2 "TAB-BAR-ECM-LIGHTER2 ")
(define-minor-mode tab-bar-ecm-mode2 "DOCSTRING"
:global t
(let ((lighter `(tab-bar-ecm-mode2
(:propertize tab-bar-ecm-lighter2 keymap ,tab-bar-ecm-keymap2))))
(if tab-bar-ecm-mode2
(progn
(cl-pushnew lighter global-mode-string :test #'equal)
(unless (memq 'tab-bar-format-global tab-bar-format)
(cl-callf append tab-bar-format '(tab-bar-format-global))))
(cl-callf2 remove lighter global-mode-string))))
Enable both tab-bar-ecm-mode and tab-bar-ecm-mode2. Then you'll see
that, regardless of which lighter is clicked in the tab-bar, the lighter
for the mode that was activated last catches the mouse clicks for both
lighters.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Received: (at 70086) by debbugs.gnu.org; 3 May 2024 06:25:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 02:25:03 2024 Received: from localhost ([127.0.0.1]:46163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2mLv-00082n-0o for submit <at> debbugs.gnu.org; Fri, 03 May 2024 02:25:03 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:53841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s2mLr-00081j-R8; Fri, 03 May 2024 02:25:02 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 210B140002; Fri, 3 May 2024 06:24:29 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Adam Porter <adam@HIDDEN> Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties In-Reply-To: <8b894304-a50d-45b8-94a4-3737bcbfad34@HIDDEN> (Adam Porter's message of "Fri, 3 May 2024 00:45:31 -0500") Organization: LINKOV.NET References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> <865xwv7oxo.fsf@HIDDEN> <6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN> <86cyqxeqa9.fsf@HIDDEN> <86zft85cai.fsf@HIDDEN> <8b894304-a50d-45b8-94a4-3737bcbfad34@HIDDEN> Date: Fri, 03 May 2024 09:18:25 +0300 Message-ID: <86wmobbev6.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: control <at> debbugs.gnu.org, 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > For example, given this value for global-mode-string: > > ((tab-bar-ecm-mode > (:propertize tab-bar-ecm-lighter keymap > (keymap > (tab-bar keymap > (mouse-1 lambda > (&rest _) > (interactive) > (message "tab-bar-ecm-lighter clicked with mouse-1")))))) > (listen-mode > (:propertize listen-mode-lighter keymap > (keymap > (tab-bar keymap > (down-mouse-3 . listen-pause) > (down-mouse-2 . listen-pause) > (down-mouse-1 . listen-pause) > (mouse-3 . listen-pause) > (mouse-2 . listen-pause) > (mouse-1 . listen-pause)) > (mode-line keymap > (mouse-1 . listen-pause)))))) > > When I click on the text rendered by listen-mode-lighter, the lambda from > the tab-bar-ecm-lighter keymap intercepts the mouse-1 event and prints the > message rather than calling the listen-pause function. Could you please distill this example into a self-contained test case like you did the previous time, that helped a lot.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 70086) by debbugs.gnu.org; 3 May 2024 05:46:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 01:46:01 2024 Received: from localhost ([127.0.0.1]:46133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2lk8-0004XM-Nf for submit <at> debbugs.gnu.org; Fri, 03 May 2024 01:46:01 -0400 Received: from tiger.tulip.relay.mailchannels.net ([23.83.218.248]:31251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <adam@HIDDEN>) id 1s2lk5-0004X9-93; Fri, 03 May 2024 01:45:58 -0400 X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5106390217A; Fri, 3 May 2024 05:45:33 +0000 (UTC) Received: from pdx1-sub0-mail-a240.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2284A9023D6; Fri, 3 May 2024 05:45:33 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Versed-Eyes: 7f32074b12a9b07d_1714715133185_4049247653 X-MC-Loop-Signature: 1714715133185:3598952048 X-MC-Ingress-Time: 1714715133184 Received: from pdx1-sub0-mail-a240.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.111.43.10 (trex/6.9.2); Fri, 03 May 2024 05:45:33 +0000 Received: from [10.44.0.110] (unknown [45.131.192.13]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@HIDDEN) by pdx1-sub0-mail-a240.dreamhost.com (Postfix) with ESMTPSA id 4VW0C04BFvzCY; Thu, 2 May 2024 22:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1714715132; bh=tsRsrUZTha6bDPW9/1sFM3Lio7BnZOizUvOmDwZQG0A=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=p30I/H3AxP/Lsm76nBTFhQxNLjHJhwoF5zz7Ebh1yjN+aJINHD7Y/alpTYh9iNpg4 Br33cTTnVO31olJY2MX2z7jfESHjPaHhA+/tcqsMb9Mmgwzm+GmHz0bJTg6meyZfNG HsVpDprm3ev7TRR/OnHzQcWgEkPfONIAarDLo/QSp8hADlxLs2ouN9K+3AGRCA8kWG wJLmRApjTTwCVHBZl0joIQhtXLaWA8tL1bSzqudr9/xtPdx9gDjlBUyYSUQc5cMfyg gP5XzvOwVAC3p3EwzmrMEDJnr5YqTltB8utEm4FyRZ3WUFYGVTMe+JBnJ4EuxwnjK4 KgsXicy3DY3hA== Message-ID: <8b894304-a50d-45b8-94a4-3737bcbfad34@HIDDEN> Date: Fri, 3 May 2024 00:45:31 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties To: Juri Linkov <juri@HIDDEN> References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> <865xwv7oxo.fsf@HIDDEN> <6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN> <86cyqxeqa9.fsf@HIDDEN> <86zft85cai.fsf@HIDDEN> Content-Language: en-US From: Adam Porter <adam@HIDDEN> In-Reply-To: <86zft85cai.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: control <at> debbugs.gnu.org, 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) reopen 70086 thanks Hi Juri, On 5/2/24 12:55, Juri Linkov wrote: > close 70086 30.0.50 > thanks > >>> Do you think this could be fixed in time for Emacs 30? >> >> Please try out the following patch. At least it works for your test case. > > I guess this patch did the right thing. So pushed now for Emacs 30. Apologies for not replying yet, and thanks for following up. I just tested your patch, and it almost works perfectly. The problem now is that if there are multiple such constructs in the tab-bar, each with their own keymap, it seems that the first one in the global-mode-string catches the clicks that are made on the second one. For example, given this value for global-mode-string: ((tab-bar-ecm-mode (:propertize tab-bar-ecm-lighter keymap (keymap (tab-bar keymap (mouse-1 lambda (&rest _) (interactive) (message "tab-bar-ecm-lighter clicked with mouse-1")))))) (listen-mode (:propertize listen-mode-lighter keymap (keymap (tab-bar keymap (down-mouse-3 . listen-pause) (down-mouse-2 . listen-pause) (down-mouse-1 . listen-pause) (mouse-3 . listen-pause) (mouse-2 . listen-pause) (mouse-1 . listen-pause)) (mode-line keymap (mouse-1 . listen-pause)))))) When I click on the text rendered by listen-mode-lighter, the lambda from the tab-bar-ecm-lighter keymap intercepts the mouse-1 event and prints the message rather than calling the listen-pause function.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 70086) by debbugs.gnu.org; 2 May 2024 17:56:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 02 13:56:47 2024 Received: from localhost ([127.0.0.1]:45066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2afn-0000Fs-Fh for submit <at> debbugs.gnu.org; Thu, 02 May 2024 13:56:47 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:55053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s2afk-0000Fj-A5; Thu, 02 May 2024 13:56:47 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7A200E000A; Thu, 2 May 2024 17:56:14 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Adam Porter <adam@HIDDEN> Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties In-Reply-To: <86cyqxeqa9.fsf@HIDDEN> (Juri Linkov's message of "Wed, 10 Apr 2024 09:42:30 +0300") Organization: LINKOV.NET References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> <865xwv7oxo.fsf@HIDDEN> <6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN> <86cyqxeqa9.fsf@HIDDEN> Date: Thu, 02 May 2024 20:55:17 +0300 Message-ID: <86zft85cai.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 70086 30.0.50 thanks >> Do you think this could be fixed in time for Emacs 30? > > Please try out the following patch. At least it works for your test case. I guess this patch did the right thing. So pushed now for Emacs 30.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.
Received: (at 70086) by debbugs.gnu.org; 10 Apr 2024 06:53:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 10 02:53:22 2024
Received: from localhost ([127.0.0.1]:51932 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ruRpg-0003cY-1Y
for submit <at> debbugs.gnu.org; Wed, 10 Apr 2024 02:53:22 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:52721)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1ruRpc-0003am-B7
for 70086 <at> debbugs.gnu.org; Wed, 10 Apr 2024 02:53:18 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 7A32BC0002;
Wed, 10 Apr 2024 06:53:00 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Adam Porter <adam@HIDDEN>
Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in
keymap properties
In-Reply-To: <6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN> (Adam
Porter's message of "Fri, 5 Apr 2024 13:41:56 -0500")
Organization: LINKOV.NET
References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN>
<86ttknd3kd.fsf@HIDDEN>
<6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN>
<865xwv7oxo.fsf@HIDDEN>
<6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN>
Date: Wed, 10 Apr 2024 09:42:30 +0300
Message-ID: <86cyqxeqa9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70086
Cc: 70086 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
> Do you think this could be fixed in time for Emacs 30?
Please try out the following patch. At least it works for your test case.
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=tab-bar-global.patch
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index cd076664faf..1a80f3d99e7 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -298,9 +298,13 @@ tab-bar--event-to-item
nil otherwise."
(setq tab-bar--dragging-in-progress nil)
(if (posn-window posn)
- (let ((caption (car (posn-string posn))))
- (when caption
- (get-text-property 0 'menu-item caption)))
+ (let* ((caption (car (posn-string posn)))
+ (menu-item (when caption
+ (get-text-property 0 'menu-item caption))))
+ (when (equal menu-item '(global ignore nil))
+ (setf (nth 1 menu-item)
+ (key-binding (vector 'tab-bar last-nonmenu-event) t)))
+ menu-item)
;; Text-mode emulation of switching tabs on the tab bar.
;; This code is used when you click the mouse in the tab bar
;; on a console which has no window system but does have a mouse.
@@ -332,7 +336,7 @@ tab-bar-mouse-down-1
(setq tab-bar--dragging-in-progress t)
;; Don't close the tab when clicked on the close button. Also
;; don't add new tab on down-mouse. Let `tab-bar-mouse-1' do this.
- (unless (or (memq (car item) '(add-tab history-back history-forward))
+ (unless (or (memq (car item) '(add-tab history-back history-forward global))
(nth 2 item))
(if (functionp (nth 1 item))
(call-interactively (nth 1 item))
@@ -347,7 +351,7 @@ tab-bar-mouse-1
(let* ((item (tab-bar--event-to-item (event-start event)))
(tab-number (tab-bar--key-to-number (nth 0 item))))
(cond
- ((and (memq (car item) '(add-tab history-back history-forward))
+ ((and (memq (car item) '(add-tab history-back history-forward global))
(functionp (nth 1 item)))
(call-interactively (nth 1 item)))
((and (nth 2 item) (not (eq tab-number t)))
@@ -468,8 +472,8 @@ tab-bar-touchscreen-begin
(tab-bar-select-tab number))))
;; Cancel the timer.
(cancel-timer timer)))
- ((and (memq (car item) '(add-tab history-back
- history-forward))
+ ((and (memq (car item) '( add-tab history-back
+ history-forward global))
(functionp (cadr item)))
;; This is some kind of button. Wait for the
;; tap to complete and press it.
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Received: (at 70086) by debbugs.gnu.org; 5 Apr 2024 18:42:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 05 14:42:10 2024 Received: from localhost ([127.0.0.1]:37501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rsoVs-0006CJ-SG for submit <at> debbugs.gnu.org; Fri, 05 Apr 2024 14:42:09 -0400 Received: from weasel.tulip.relay.mailchannels.net ([23.83.218.247]:12937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <adam@HIDDEN>) id 1rsoVq-0006C3-T1 for 70086 <at> debbugs.gnu.org; Fri, 05 Apr 2024 14:42:08 -0400 X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C325E541286; Fri, 5 Apr 2024 18:41:59 +0000 (UTC) Received: from pdx1-sub0-mail-a260.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 256325427A0; Fri, 5 Apr 2024 18:41:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1712342518; a=rsa-sha256; cv=none; b=BPKvzr0D6NuJs4r09XUIZZaO2Zy8fGURFCYXhk85/RptdfsvSgpHdW7j950AoD81ccV8Rl EXsUEjmmtj47DEDfGAhPWlUx161Ohy78PjaK73F2cQOisxfaqy44RUYCut5pe5ytMbxZmi asOlILBp+ROVyrqi59f3bEW1YH83SVEsbZjU/fU9XxEr883nRXpsnIhrEarUH+Vod/rjHx UKJUs/UACD2r6vW/kkbvYwDWjYALSLBF8WUAUsvRV24BRO96jDRGYbzclqi1HfpEfapPJS AHJBjL3cetGizoSVCCV75gvTf5qjkgwoKHA7Y4Gmc2/bm4NwbxyId8HyjJ5h4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1712342518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dV5nmnu/qGHHaq2olpv09EnLUeAcP3THv5YpA1/WDfc=; b=fO/R2NEBJD6Ogn3jwEpchyF5SA5yJl6XNKE22wJZV6jerWak0kPe+Dezp8cPpDWih0Fds2 sdKSColdBiCEnxfherQSTyDK4YycnNVUY+9tntVztb3q3n2PIXBYy2A8GO12vnINabByL/ IXECaz92NZ32UkAT5LQtDg2F+HLbvXUNGTX+cQJWnAqHjq6RP1zveuROcbD1zgQZ/x9gPH RmMHQA+8ifWzGUO+eEdx1PgcW14Q4MFZCh9TztzH0l4noniDBViksLhf+YvRQIWYzBwSMW 4fMbo3WJw4uUrHfM5lm540J3IYU9A1nUUJzbgNOt7KG+edJZ9dW59tQR6/Qwhg== ARC-Authentication-Results: i=1; rspamd-687b9dd446-mjlld; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@HIDDEN X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Average-Desert: 6abf45866c31f060_1712342518417_2391632876 X-MC-Loop-Signature: 1712342518417:634899455 X-MC-Ingress-Time: 1712342518417 Received: from pdx1-sub0-mail-a260.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.123.121.28 (trex/6.9.2); Fri, 05 Apr 2024 18:41:58 +0000 Received: from [10.130.8.122] (unknown [45.92.229.138]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@HIDDEN) by pdx1-sub0-mail-a260.dreamhost.com (Postfix) with ESMTPSA id 4VB6ln453hzFH; Fri, 5 Apr 2024 11:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1712342517; bh=dV5nmnu/qGHHaq2olpv09EnLUeAcP3THv5YpA1/WDfc=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=usxGUixVe3SCv6tteV98ntKsAbdWFbmRsrmwSx0r/9OOz5LJ8j6obAdsgKU44KDKV 8uci15GkvEcPPdMPBM6rcjisop9GEssyz1w9VoQ7ogZc/rmwYWdzcP3oaKbyByzwQW pAl6ZxCWPQJiPpEsSEF3apMdHD29GHAIeX/YlQwQl8i9LuxCEpcH3Cc35QEL2FofTZ Hf3rqaLnmFtSEsj8BtkNW8FtfT42eHnsOUxIYjXgxu5dRAy2BhRnNL9ogeN3HEFvpT nEAS+TY+/QrEKZGFbPLA19WeQmsD9+7wn9MZCR1CO8eSn6pZKEPxkeohKImHsUIR8O IROW7kbD68yxg== Message-ID: <6f66d842-7b7c-4a16-bf47-2b3641c3195b@HIDDEN> Date: Fri, 5 Apr 2024 13:41:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties To: Juri Linkov <juri@HIDDEN> References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> <865xwv7oxo.fsf@HIDDEN> Content-Language: en-US From: Adam Porter <adam@HIDDEN> In-Reply-To: <865xwv7oxo.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Hi Juri, On 4/5/24 11:29, Juri Linkov wrote: >> Sure, the following code in a clean Emacs config seems to demonstrate the >> problem: > > Thanks for the test case. And sorry there is no quick fix. > The problem is that the tab-bar uses the architecture completely > different from the mode-line. Understood, that's what I figured. Do you think this could be fixed in time for Emacs 30? Thanks, Adam
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Received: (at 70086) by debbugs.gnu.org; 5 Apr 2024 16:31:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 05 12:31:02 2024 Received: from localhost ([127.0.0.1]:37379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rsmSz-00046D-F7 for submit <at> debbugs.gnu.org; Fri, 05 Apr 2024 12:31:02 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:40923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1rsmSx-0003t1-KB for 70086 <at> debbugs.gnu.org; Fri, 05 Apr 2024 12:31:00 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 61D7E1C0004; Fri, 5 Apr 2024 16:30:45 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Adam Porter <adam@HIDDEN> Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties In-Reply-To: <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> (Adam Porter's message of "Sun, 31 Mar 2024 11:15:06 -0500") Organization: LINKOV.NET References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN> Date: Fri, 05 Apr 2024 19:29:55 +0300 Message-ID: <865xwv7oxo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Sure, the following code in a clean Emacs config seems to demonstrate the > problem: Thanks for the test case. And sorry there is no quick fix. The problem is that the tab-bar uses the architecture completely different from the mode-line.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.
Received: (at 70086) by debbugs.gnu.org; 31 Mar 2024 16:15:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 31 12:15:15 2024
Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rqxpy-0002TG-LH
for submit <at> debbugs.gnu.org; Sun, 31 Mar 2024 12:15:14 -0400
Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]:14787)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <adam@HIDDEN>) id 1rqxpw-0002T4-9G
for 70086 <at> debbugs.gnu.org; Sun, 31 Mar 2024 12:15:13 -0400
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 4529B760411;
Sun, 31 Mar 2024 16:15:08 +0000 (UTC)
Received: from pdx1-sub0-mail-a291.dreamhost.com (unknown [127.0.0.6])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id D0DF57618AB;
Sun, 31 Mar 2024 16:15:07 +0000 (UTC)
ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1711901707; a=rsa-sha256;
cv=none;
b=ZjTEw53YfKhoKv+ACSvjRIJ75xfFAJFpdJgBOR02m2wcnJQSsK+/Ql0+369ELjBw51wP0q
+YoGXv1P1d+jrwwoJEHG8L4lHnh02+vTaeidnYzHj+h3yC99GR1Y3XBMnDwoM/YxaH0gHY
6axUjZJ1LIWoGU1W2f9KWoHjtwIOY4gmcfVgxuv7cuJ+hhZ0d5dd8le5I+hXonza+a8pVr
LA55CFzw9QKBStE0DaP6U54nfOSfnxGv4Jx6QdN4SaRzHlKkWLRZsGFlpNOWl0i2PJIgK8
MIuEN+zJQOBPqX/euZ7KArFUxvHMpvDJ473bMsrdrRTyJRA5S3J/lYxPc6480g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
d=mailchannels.net; s=arc-2022; t=1711901707;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:dkim-signature;
bh=llCWkjqCLpE4uUcPrXtIx0vnc/tabjed1K5OpPOrkyE=;
b=sgiXAxcgrnlorThGe04CcxWtHGBwg1s6dZv6TzPngnfRi0Vxpg8UiclBjjnwCelDcAWFg8
ssHYqCmH0qTwyAkrvoUn8yN7R87znqnSCzI1XuN/gi6ZQGF/+on8WSpDmGlnYATCtIC76/
IV+PHV0VAVIohoCSiZ5ykv8vRWdBumDVnwAJqoN3jiyQdJXV9fFvUJiWMmEAAEQEZ/D95r
mw0kKEP1dLNFZGMybgzsY4rdovTXnLUKkt0Yg6YTYHXHlqHS/0o/SmPsiZO8BIrWf1Lx5h
cJuTqANj1PjWQpClDjbvy0KLRTiO2vQdthvN4FSjEN/7ZLSDfSDV7Rk3OlzHgA==
ARC-Authentication-Results: i=1; rspamd-699949c56f-24fdp;
auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@HIDDEN
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|adam@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Harmony-Spot: 7753475c4739aa42_1711901708081_1654637294
X-MC-Loop-Signature: 1711901708081:2691692904
X-MC-Ingress-Time: 1711901708080
Received: from pdx1-sub0-mail-a291.dreamhost.com (pop.dreamhost.com
[64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384)
by 100.112.72.244 (trex/6.9.2); Sun, 31 Mar 2024 16:15:08 +0000
Received: from [10.43.1.194] (unknown [193.56.116.15])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
(Authenticated sender: adam@HIDDEN)
by pdx1-sub0-mail-a291.dreamhost.com (Postfix) with ESMTPSA id 4V6zkg2rxszJF;
Sun, 31 Mar 2024 09:15:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net;
s=dreamhost; t=1711901707;
bh=llCWkjqCLpE4uUcPrXtIx0vnc/tabjed1K5OpPOrkyE=;
h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding;
b=DvSL4FhoRpbMKSSSZvlZr6S5FHMSWV6Zz++RuCih8gzpOmJFxGJHztg/m6AufWfLJ
01L2hsRqgMYxE4/nWz6TECY1YYu1a+jS9QLMjv8OCFGQq5Zu+pyKnxZsfz+Mi32R4B
Oa+vH5XD6PKuaiIMCxFFUYX9x5s8KinJdzoFekzmvsToAHthr5gV+Sb7Zr/DKK82KF
Ht4YIQ7QUgQfcf6MCqGuGcHUok+ywRlLwcdSH1M8MJ/AdJPttlUOdpHwA9O+dKHPy5
Y8qM90LTv7/erBhgBvY2GLckRgORpNuXdCIVrUb9wCZMHg2vSZBYsQJIrHLk5D0K4y
Abjbn1KXdp93g==
Message-ID: <6393275a-0009-46f0-9eff-c1149c2e0ee4@HIDDEN>
Date: Sun, 31 Mar 2024 11:15:06 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in
keymap properties
To: Juri Linkov <juri@HIDDEN>
References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN>
<86ttknd3kd.fsf@HIDDEN>
Content-Language: en-US
From: Adam Porter <adam@HIDDEN>
In-Reply-To: <86ttknd3kd.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 70086
Cc: 70086 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)
Hi Juri,
On 3/30/24 13:16, Juri Linkov wrote:
>> In my listen.el package on GNU ELPA, I'm trying to make mouse clicks in the
>> `global-mode-string' construct work when `mode-line-misc-info' is shown in
>> the tab-bar by including `tab-bar-format-global' in `tab-bar-format'. I'm
>> including this construct in the `global-mode-string':
>>
>>
>> `(listen-mode (:propertize listen-mode-lighter
>> keymap ,listen-mode-lighter-map))
>
> Thanks for the request. If possible could you send a minimal test case
> to see what exactly do you need.
Sure, the following code in a clean Emacs config seems to demonstrate
the problem:
(require 'cl-lib)
(defvar tab-bar-ecm-keymap
(let ((map (make-sparse-keymap)))
(define-key map [tab-bar mouse-1] (lambda (&rest _)
(interactive)
(message "tab-bar-ecm-lighter
clicked with mouse-1")))
map))
(defvar tab-bar-ecm-lighter "TAB-BAR-ECM-LIGHTER")
(define-minor-mode tab-bar-ecm-mode "DOCSTRING"
:global t
(let ((lighter `(tab-bar-ecm-mode
(:propertize tab-bar-ecm-lighter keymap
,tab-bar-ecm-keymap))))
(if tab-bar-ecm-mode
(progn
(cl-pushnew lighter global-mode-string :test #'equal)
(unless (memq 'tab-bar-format-global tab-bar-format)
(cl-callf append tab-bar-format '(tab-bar-format-global))))
(cl-callf2 remove lighter global-mode-string))))
Evaluate that code and then enable `tab-bar-mode' and
`tab-bar-ecm-mode'. Then you can see that "C-h k" followed by a click
on the "TAB-BAR-ECM-LIGHTER" text in the tab-bar shows that the
anonymous command is bound to that sequence, yet clicking the text
doesn't call it.
> And the same should work on `tab-line-format' as well.
I haven't tried that, but sure, sounds good to me. :)
> Indeed, events on the tab-bar have a different design where
> `tab-bar--event-to-item' should be used to get a bound command.
> You can see an example in `tab-bar-mouse-down-1' that uses
> (if (functionp (nth 1 item)) (call-interactively (nth 1 item))
> to call an arbitrary command.
I see, thanks.
--Adam
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Received: (at 70086) by debbugs.gnu.org; 30 Mar 2024 18:56:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 30 14:56:35 2024 Received: from localhost ([127.0.0.1]:46162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rqdsZ-00086z-3f for submit <at> debbugs.gnu.org; Sat, 30 Mar 2024 14:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rqdsW-00086m-KD for 70086 <at> debbugs.gnu.org; Sat, 30 Mar 2024 14:56:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rqdsO-0006e4-3m; Sat, 30 Mar 2024 14:56:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Yq19VBFd0rPI7YNnfwvLUtZOU2dvS2wHteFL7clFAfU=; b=ZSAe35JH53I1 zRwdU695TqoTcRvGsIwBYRKWWDIWUusWDeUgCVWeVdgt0+AnP+Obq1EtS6iKfjF1Re2cDo/kdNsqp t0R9oKMiyjeRrxNSXPxgbCOlNzSmsnlXXxoRbrqZ7n6taomLVa6bVZTDs/EgLfCJtmu5UnPGsH/3g 4wdFj0ZSX8sZS2YMsmQqYTGGxvmFCHMrLZE3BoB69MjnP2XCTllFQBz+9NYBSBUVwgqR3aJPVt9KO qjfDlIn/Jg3oO94G9IncEXoMmb0eRo6piLCFUPAcWxADq9mpsJzNX2a00c3E2ucn55aRPFxFosXUl 68WAddqYavOA4VLxXr1a5A==; Date: Sat, 30 Mar 2024 21:56:19 +0300 Message-Id: <864jcnczvw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86ttknd3kd.fsf@HIDDEN> (message from Juri Linkov on Sat, 30 Mar 2024 20:16:50 +0200) Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> <86ttknd3kd.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70086 Cc: adam@HIDDEN, 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 70086 <at> debbugs.gnu.org > From: Juri Linkov <juri@HIDDEN> > Date: Sat, 30 Mar 2024 20:16:50 +0200 > > > Looking at tab-bar.el, I see that it does some, I suppose, unusual things > > with keymaps and clicks to make them work. However, if this could be fixed > > to allow these commands to work properly, it would be very useful, as the > > extra space in the tab-bar is a great place to display extra information > > without crowding the mode line. > > Indeed, events on the tab-bar have a different design where > `tab-bar--event-to-item' should be used to get a bound command. > You can see an example in `tab-bar-mouse-down-1' that uses > (if (functionp (nth 1 item)) (call-interactively (nth 1 item)) > to call an arbitrary command. The disparity between what "C-h k" says about mouse clicks on the tab-bar and how to bind commands to such clicks, is IMO a misfeature that we should fix.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.Received: (at 70086) by debbugs.gnu.org; 30 Mar 2024 18:24:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 30 14:24:44 2024 Received: from localhost ([127.0.0.1]:46142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rqdNj-0006S7-PR for submit <at> debbugs.gnu.org; Sat, 30 Mar 2024 14:24:44 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:38109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1rqdNe-0006R5-UM for 70086 <at> debbugs.gnu.org; Sat, 30 Mar 2024 14:24:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 211DAE0004; Sat, 30 Mar 2024 18:24:28 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Adam Porter <adam@HIDDEN> Subject: Re: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties In-Reply-To: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> (Adam Porter's message of "Fri, 29 Mar 2024 21:25:25 -0500") Organization: LINKOV.NET References: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN> Date: Sat, 30 Mar 2024 20:16:50 +0200 Message-ID: <86ttknd3kd.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70086 Cc: 70086 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > In my listen.el package on GNU ELPA, I'm trying to make mouse clicks in the > `global-mode-string' construct work when `mode-line-misc-info' is shown in > the tab-bar by including `tab-bar-format-global' in `tab-bar-format'. I'm > including this construct in the `global-mode-string': > > > `(listen-mode (:propertize listen-mode-lighter > keymap ,listen-mode-lighter-map)) Thanks for the request. If possible could you send a minimal test case to see what exactly do you need. > When that construct is used in `mode-line-format', it works as expected: > clicking with mouse-1 calls the command `listen-pause'. And the same should work on `tab-line-format' as well. > Looking at tab-bar.el, I see that it does some, I suppose, unusual things > with keymaps and clicks to make them work. However, if this could be fixed > to allow these commands to work properly, it would be very useful, as the > extra space in the tab-bar is a great place to display extra information > without crowding the mode line. Indeed, events on the tab-bar have a different design where `tab-bar--event-to-item' should be used to get a bound command. You can see an example in `tab-bar-mouse-down-1' that uses (if (functionp (nth 1 item)) (call-interactively (nth 1 item)) to call an arbitrary command.
bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 30 Mar 2024 02:25:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 29 22:25:43 2024
Received: from localhost ([127.0.0.1]:43677 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rqOPf-0002UW-D6
for submit <at> debbugs.gnu.org; Fri, 29 Mar 2024 22:25:43 -0400
Received: from lists.gnu.org ([2001:470:142::17]:34292)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <adam@HIDDEN>) id 1rqOPd-0002Tq-0S
for submit <at> debbugs.gnu.org; Fri, 29 Mar 2024 22:25:41 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <adam@HIDDEN>)
id 1rqOPT-0002j6-J8
for bug-gnu-emacs@HIDDEN; Fri, 29 Mar 2024 22:25:31 -0400
Received: from cross.elm.relay.mailchannels.net ([23.83.212.46])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <adam@HIDDEN>)
id 1rqOPR-000668-9u
for bug-gnu-emacs@HIDDEN; Fri, 29 Mar 2024 22:25:31 -0400
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 3187C81E9E;
Sat, 30 Mar 2024 02:25:27 +0000 (UTC)
Received: from pdx1-sub0-mail-a205.dreamhost.com (unknown [127.0.0.6])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id C86068279A;
Sat, 30 Mar 2024 02:25:26 +0000 (UTC)
ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1711765526; a=rsa-sha256;
cv=none;
b=3DZ2Cc82NZkwpOBwwkipHHrHokBtegbfTzxqkEAJl0Vo9AUlLSlIO702PYNfx1HgLMOA0I
HKOD56xTgYVtCZXK48GobvtdUCMOzcn58R91mmIJJenYqNHzr79LzdpBUlG3YZbjWtEiZn
wMhFGZZVjRDo9n715p9Rv/UHUnoEb1WKtRhSq5p9jXL9iN17O1AYJqiAjPvBpJ7m3YGhJ7
ywj+BWijCEja9GHSo+bgJhqQoJCWRcT1/FEYwgv0t8LSnpd/SESa4HgowNqX16wOO20kbw
U51sIbXWjdw110bCs68sqdT9StwUYZmzpu9WctKy3R18H2Bn0cQVVE+aD5ul4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
d=mailchannels.net; s=arc-2022; t=1711765526;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:dkim-signature;
bh=6Gi4NZSTrpdSvmXlY8vH2EBZu0PjMFjzsViw5uFerzw=;
b=ti2weksyvzW/Ph3/lLHnfdC4IQwRhk61qiTHuTJzngEiXTP9Mhdk86A4yip1RD4mVfDhAj
CdXGHc9cqVwbu0X5s2OYojMj7SNmWB9QKNpJm4IsWC3QubFffgSptQKu4a0oQOi2caHjPJ
sM4hzBgiF6Cj/72Jx+Fgc32QnWHR1iywN0BHyyP7otg5Y5sMsh1jhCYOFmVYYSWzuhiEnU
UlS3UN+0w8QLhKrz4xG7g7aBLqApzEEdDMggzG79XwItF5CSQgsGroYS4zWDHxhwaD5D6s
EdbIpgF+b/KhXM4fjGWkHfjmrkle2GttBkSZFXOsdHL+5hzlBZ6xhNXsv+GzNA==
ARC-Authentication-Results: i=1; rspamd-7f6944c677-lnjt5;
auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@HIDDEN
X-Sender-Id: dreamhost|x-authsender|adam@HIDDEN
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|adam@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Cure-Befitting: 1b38966a6b5203aa_1711765527059_1356949768
X-MC-Loop-Signature: 1711765527059:1323657055
X-MC-Ingress-Time: 1711765527058
Received: from pdx1-sub0-mail-a205.dreamhost.com (pop.dreamhost.com
[64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384)
by 100.96.203.156 (trex/6.9.2); Sat, 30 Mar 2024 02:25:27 +0000
Received: from [10.28.1.54] (unknown [45.131.192.18])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
(Authenticated sender: adam@HIDDEN)
by pdx1-sub0-mail-a205.dreamhost.com (Postfix) with ESMTPSA id 4V61Mp2hpFz52;
Fri, 29 Mar 2024 19:25:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net;
s=dreamhost; t=1711765526;
bh=6Gi4NZSTrpdSvmXlY8vH2EBZu0PjMFjzsViw5uFerzw=;
h=Date:To:From:Subject:Cc:Content-Type:Content-Transfer-Encoding;
b=HQTtLzgraqE/Wi841gPNc4n91bPmxPDiYEdgOmT1LRRFHFqCbbFoLHwh65+8Af51j
Zxj8rAWPFHe9MPwlcOhgr4ywLZ3jcXsCqV4AWk+HaxxugY6CG+NI89jfwCFclrXjPd
VVUYCmtWdnkk9SWpWt1vf6VTpm9hUEqk2xX3rNCyfNUfYF0ki47F6x4Gn5wQjrWK9P
xBD3ute0IpLmqNv7Dl6aVvMa1Q/pYySAflt8ZY+oGzPnZ3Qa6fep6rhhj6wxk+yXRM
sNHE3lo4v84liAR7ZRYYGRKwA69daN0GOiQ/3NsD4RlBxSMGRLDf+2Ln4FXHK/GeRd
Yt2v/dpwm5jYQ==
Message-ID: <948ee96f-52d5-4cd5-be84-70368cff214f@HIDDEN>
Date: Fri, 29 Mar 2024 21:25:25 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: bug-gnu-emacs@HIDDEN
From: Adam Porter <adam@HIDDEN>
Subject: Mouse clicks in tab-bar don't call commands bound in keymap properties
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: neutral client-ip=23.83.212.46; envelope-from=adam@HIDDEN;
helo=cross.elm.relay.mailchannels.net
X-Spam_score_int: 0
X-Spam_score: 0.0
X-Spam_bar: /
X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.347,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Juri, et al, In my listen.el package on GNU ELPA,
I'm trying
to make mouse clicks in the `global-mode-string' construct work when
`mode-line-misc-info'
is shown in the tab-bar by including `tab-bar-format-global' [...]
Content analysis details: (1.9 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?23.83.212.46>]
0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
X-Debbugs-Envelope-To: submit
Cc: Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.9 (/)
Hi Juri, et al,
In my listen.el package on GNU ELPA, I'm trying to make mouse clicks in
the `global-mode-string' construct work when `mode-line-misc-info' is
shown in the tab-bar by including `tab-bar-format-global' in
`tab-bar-format'. I'm including this construct in the `global-mode-string':
`(listen-mode (:propertize listen-mode-lighter
keymap ,listen-mode-lighter-map))
Using this keymap:
(defvar listen-mode-lighter-map
(let ((map (make-sparse-keymap)))
(define-key map [mode-line mouse-1] #'listen-pause)
(define-key map [tab-bar mouse-1] #'listen-pause)
(define-key map [tab-bar mouse-2] #'listen-pause)
(define-key map [tab-bar mouse-3] #'listen-pause)
(define-key map [tab-bar down-mouse-1] #'listen-pause)
(define-key map [tab-bar down-mouse-2] #'listen-pause)
(define-key map [tab-bar down-mouse-3] #'listen-pause)
map))
When that construct is used in `mode-line-format', it works as expected:
clicking with mouse-1 calls the command `listen-pause'.
But when that same construct is shown in the tab-bar, mouse-1 and
mouse-2 clicks have no effect, and mouse-3 shows the tab-bar context
menu with options for "New tab" and "Reopen closed tab".
Surprisingly, using the sequence "C-h k mouse-1" on the construct in the
tab-bar shows that the binding appears to be read correctly:
There were several key-sequences:
<tab-bar> <down-mouse-1> at that spot runs the command listen-pause
<tab-bar> <mouse-1> at that spot runs the command listen-pause
They're all described below.
<tab-bar> <down-mouse-1> at that spot runs the command listen-pause
(found in listen-mode-lighter-map), which is an interactive
native-compiled Lisp function in ‘listen.el’.
(listen-pause PLAYER)
Pause/unpause PLAYER.
Interactively, uses the default player.
<tab-bar> <mouse-1> at that spot runs the command listen-pause (found
in listen-mode-lighter-map), which is an interactive native-compiled
Lisp function in ‘listen.el’.
(listen-pause PLAYER)
Pause/unpause PLAYER.
Interactively, uses the default player.
But when used without "C-h k", it has no effect.
Looking at tab-bar.el, I see that it does some, I suppose, unusual
things with keymaps and clicks to make them work. However, if this
could be fixed to allow these commands to work properly, it would be
very useful, as the extra space in the tab-bar is a great place to
display extra information without crowding the mode line.
Thanks,
Adam
Adam Porter <adam@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70086; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.