GNU bug report logs - #70121
Magit autoloads missing in Emacs 29.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70121 in the body.
You can then email your comments to 70121 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jake <jforst.mailman <at> gmail.com>
To: bug-guix <at> gnu.org
Cc: liliana.prikler <at> gmail.com
Subject: Magit autoloads missing in Emacs 29.3
Date: Mon, 1 Apr 2024 03:33:27 +0000

[Message part 1 (text/plain, inline)]

Hello

Since upgrading from Emacs 29.1 to 29.3, it seems like magit's autoload
definitions are not loaded.

To reproduce:

guix shell --pure emacs emacs-magit -- emacs -q --eval "(call-interactively
'magit)"

In Emacs 29.3 this gives me: Wrong type argument: commandp, magit

Thanks
Jake

[Message part 2 (text/html, inline)]

Message #8 received at 70121 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 70121 <at> debbugs.gnu.org
Cc: Jake <jforst.mailman <at> gmail.com>
Subject: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
Date: Mon, 1 Apr 2024 17:50:26 +0200

* gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
like the others.

Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
---
 gnu/packages/emacs-xyz.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 975b26813a..f47f5fcb8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1668,6 +1668,10 @@ (define-public emacs-magit
               (lambda args
                 (with-directory-excursion "lisp"
                   (apply (assoc-ref %standard-phases 'expand-load-path) args))))
+            (replace 'make-autoloads
+              (lambda args
+                (with-directory-excursion "lisp"
+                  (apply (assoc-ref %standard-phases 'make-autoloads) args))))
             (replace 'install
               (lambda args
                 (with-directory-excursion "lisp"

base-commit: 4d79a9cd6b5f0d8c5afbab0c6b70ae42740d5470
prerequisite-patch-id: c275e4e44896c8ab96e5cc9557ec5dc522d62fd0
prerequisite-patch-id: 1675bb658c90730025a744f7869a3566fb5cf41a
prerequisite-patch-id: 9c02fe03b70a5312cc982fd4b48e73e889a9afdf
-- 
2.41.0

Message #11 received at 70121 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Jake <jforst.mailman <at> gmail.com>, 70121 <at> debbugs.gnu.org
Subject: Re: bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
Date: Wed, 03 Apr 2024 12:27:13 +0200

On Mon, Apr 01 2024, Liliana Marie Prikler wrote:

> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
> like the others.
>
> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
> ---

Hi,

Tested, looks good to me.

Message #16 received at 70121-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Jake <jforst.mailman <at> gmail.com>, 70121-done <at> debbugs.gnu.org
Subject: Re: bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
Date: Wed, 03 Apr 2024 12:40:20 +0200

On Wed, Apr 03 2024, Clément Lassieur wrote:

> On Mon, Apr 01 2024, Liliana Marie Prikler wrote:
>
>> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
>> like the others.
>>
>> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
>> ---
>
> Hi,
>
> Tested, looks good to me.

Pushed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.