GNU bug report logs - #70138
Do not intercept C-TAB on Haiku OS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70138 in the body.
You can then email your comments to 70138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tor-björn Claesson <tclaesson <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Do not intercept C-TAB on Haiku OS
Date: Tue, 2 Apr 2024 09:33:24 +0300

[Message part 1 (text/plain, inline)]

Hello!

On Haiku, C-TAB switches between application windows. Emacs unfortunately
intercepts this keystroke, breaking window switching.

This patch makes Emacs instead pass C-TAB to Haiku, while introducing the
variable haiku-pass-control-tab-to-system, allowing the current behaviour.

I would be grateful for feedback on this patch, and am willing to work on
it until it is ok. If necessary, I'm happy to assign copyright.

Cheers,
Tor-björn Claesson

[Message part 2 (text/html, inline)]

[0001-Add-haiku-pass-control-tab-to-system.patch (application/x-patch, attachment)]

Message #8 received at 70138 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Tor-björn Claesson <tclaesson <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 70138 <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Tue, 02 Apr 2024 21:00:58 +0800

Tor-björn Claesson <tclaesson <at> gmail.com> writes:

> Hello! 
>
> On Haiku, C-TAB switches between application windows. Emacs
> unfortunately intercepts this keystroke, breaking window switching.
>
> This patch makes Emacs instead pass C-TAB to Haiku, while introducing
> the variable haiku-pass-control-tab-to-system, allowing the current
> behaviour.
>
> I would be grateful for feedback on this patch, and am willing to work
> on it until it is ok. If necessary, I'm happy to assign copyright.

Thanks.  Please insert an entry in etc/NEWS documenting this change, and
format the code consistently with its surroundings, thus:

> +	if (haiku_should_pass_control_tab_to_system() &&
> +	    mods & B_CONTROL_KEY && key == 38) {
> +	  BWindow::DispatchMessage (msg, handler);
> +	  return;
> +	}

  if (haiku_should_pass_control_tab_to_system ()
      && (mods & B_CONTROL_KEY) && key == 38)
    {
      BWindow::DispatchMessage (msg, handler);
      return;
    }

> +bool
> +haiku_should_pass_control_tab_to_system (void) {
> +  return haiku_pass_control_tab_to_system;
> +}

Please position the opening brace of this defun on its own line.


> +  DEFVAR_BOOL ("haiku-pass-control-tab-to-system",
> +	       haiku_pass_control_tab_to_system,
> +	       doc: /* Whether or not to pass C-TAB to the system.
> +		       Settings this variable will cause Emacs to pass C-TAB to the system (allowing window switching on Haiku), rather than intercepting it for use in Emacs."  */);
> +  haiku_pass_control_tab_to_system = true;

Please move the second paragraph of the doc string to column zero and
fill it with M-q.

Last but not least, please write ChangeLog entries for the commit
message as specified in our CONTRIBUTE document.  I'm willing to write
them on your behalf, as a first time contributor, but it would better
acquaint you with our practices to apply yourself to the task.

Thanks.

Eli, will we require copyright assignment for this change?

Message #11 received at 70138 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 70138 <at> debbugs.gnu.org, tclaesson <at> gmail.com
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Tue, 02 Apr 2024 18:07:06 +0300

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: 70138 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Tue, 02 Apr 2024 21:00:58 +0800
> 
> Eli, will we require copyright assignment for this change?

No, it's small enough to not require copyright assignment.

Message #14 received at 70138 <at> debbugs.gnu.org (full text, mbox):

From: Tor-björn Claesson <tclaesson <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 70138 <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Wed, 03 Apr 2024 11:48:55 +0300

[Message part 1 (text/plain, inline)]

Hi!

Thanks for the feedback!

I have updated the patch and commit message, and am happy to fix it
further if needed.

[0001-New-variable-haiku-pass-control-tab-to-system.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Cheers,
Tor-björn Claesson

Message #17 received at 70138 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Tor-björn Claesson <tclaesson <at> gmail.com>
Cc: 70138 <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Wed, 03 Apr 2024 21:47:08 +0800

Tor-björn Claesson <tclaesson <at> gmail.com> writes:

> Hi!
>
> Thanks for the feedback!
>
> I have updated the patch and commit message, and am happy to fix it
> further if needed.

Thanks.  Three minor (or perhaps trifling) issues:

> Allow passing C-TAB on to the Haiku operating system, fixing window
> switching when  an Emacs frame has focus (Bug#70138).
                --

Duplicate whitespace.

> * src/haiku_support.cc (DispatchMessage): conditionally pass message to
> BWindow.
> * src/haiku_support.h:
> * src/haikufns.c (haiku_should_pass_control_tab_to_system):
> Add variable haiku-pass-control-tab-to-system, and c function
> haiku_should_pass_control_tab_to_system.

C should be capitalized, as should the first word in each sentence.
Please also fill the message to 64 columns; in a vc-log buffer, simply
typing M-q should suffice.

> +  DEFVAR_BOOL("haiku-pass-control-tab-to-system",
> +	      haiku_pass_control_tab_to_system,
> +	      doc: /*Whether or not to pass C-TAB to the system.
                     -
> +Setting this variable will cause Emacs to pass C-TAB to the system
> +(allowing window switching on the Haiku operating system), rather than
> +intercepting it.*/);
                  -

Missing whitespace.  Otherwise, you're good to go.

Message #20 received at 70138 <at> debbugs.gnu.org (full text, mbox):

From: Tor-björn Claesson <tclaesson <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 70138 <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Wed, 03 Apr 2024 18:25:44 +0300

[Message part 1 (text/plain, inline)]

Hi!

Thanks, well spotted!

Here is a new version of the patch.

[0001-New-variable-haiku-pass-control-tab-to-system-rev2.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thank you very much for helping me fix this=)

Cheers,
Tor-björn

Po Lu <luangruo <at> yahoo.com> writes:

> Tor-björn Claesson <tclaesson <at> gmail.com> writes:
>
>> Hi!
>>
>> Thanks for the feedback!
>>
>> I have updated the patch and commit message, and am happy to fix it
>> further if needed.
>
> Thanks.  Three minor (or perhaps trifling) issues:
>
>> Allow passing C-TAB on to the Haiku operating system, fixing window
>> switching when  an Emacs frame has focus (Bug#70138).
>                 --
>
> Duplicate whitespace.
>
>> * src/haiku_support.cc (DispatchMessage): conditionally pass message to
>> BWindow.
>> * src/haiku_support.h:
>> * src/haikufns.c (haiku_should_pass_control_tab_to_system):
>> Add variable haiku-pass-control-tab-to-system, and c function
>> haiku_should_pass_control_tab_to_system.
>
> C should be capitalized, as should the first word in each sentence.
> Please also fill the message to 64 columns; in a vc-log buffer, simply
> typing M-q should suffice.
>
>> +  DEFVAR_BOOL("haiku-pass-control-tab-to-system",
>> +	      haiku_pass_control_tab_to_system,
>> +	      doc: /*Whether or not to pass C-TAB to the system.
>                      -
>> +Setting this variable will cause Emacs to pass C-TAB to the system
>> +(allowing window switching on the Haiku operating system), rather than
>> +intercepting it.*/);
>                   -
>
> Missing whitespace.  Otherwise, you're good to go.


-- 
Mvh,
Tor-björn Claesson

Message #25 received at 70138-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Tor-björn Claesson <tclaesson <at> gmail.com>
Cc: 70138-done <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Thu, 04 Apr 2024 08:30:07 +0800

Tor-björn Claesson <tclaesson <at> gmail.com> writes:

> Hi!
>
> Thanks, well spotted!
>
> Here is a new version of the patch.

Installed, and closing.  Thanks.

Message #28 received at 70138-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Tor-björn Claesson <tclaesson <at> gmail.com>
Cc: 70138-done <at> debbugs.gnu.org
Subject: Re: bug#70138: Do not intercept C-TAB on Haiku OS
Date: Thu, 04 Apr 2024 08:30:43 +0800

Tor-björn Claesson <tclaesson <at> gmail.com> writes:

> Hi!
>
> Thanks, well spotted!
>
> Here is a new version of the patch.

Installed, and closing.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.