GNU bug report logs - #70230
30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Lin Sun <sunlin7.mail@HIDDEN>; Keywords: patch; dated Sat, 6 Apr 2024 06:39:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 70230 <at> debbugs.gnu.org:


Received: (at 70230) by debbugs.gnu.org; 6 Apr 2024 08:06:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 06 04:06:19 2024
Received: from localhost ([127.0.0.1]:38131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rt147-0008D0-68
	for submit <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:06:19 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48576)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rt142-0008CY-Rk
 for 70230 <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:06:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rt13r-0001GN-Ei; Sat, 06 Apr 2024 04:06:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=N2K28NBvmH3Trowq1NlAvD3Z2Qvpv2w/6ZDBD/TVmw4=; b=ABExiVnQN9k1
 5afvMBos3cBC/ODBL8ym6NFYeiXmrWuJ2iEYGsaIqnQ7IweJFMOyXTCoIHYewZRjb68dCWq0dIVSI
 M5MpVu68CxPbscOcbolYhpWjZAze5pWLrEduNMZvrteXd+ovI8veJF3gw7uBMwKKK+V3s5FkI4khy
 aG+Fqk70LYGlxGl95kjpsK3V3Dvb40nh3JSy0EaXseTYnTlR18+5WHliuaOh9jwWmbceUPO6zXvrF
 YeeLqmPLwbZgW+HG+I7Ak1nqup8Wbo3ZsWJvjzjenriMaLj3c1LnBi4sfvxsZRbCe6cHGcBzJYBOm
 zl6PiMpEI2EMh+P7EGg3sA==;
Date: Sat, 06 Apr 2024 11:06:00 +0300
Message-Id: <86h6ge5313.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Lin Sun <sunlin7.mail@HIDDEN>
In-Reply-To: <CABCREdq2KCBk5U8BiY+4=ah4+bXfAwQsbsC9DfXvnQih6qU9eQ@HIDDEN>
 (message from Lin Sun on Sat, 6 Apr 2024 00:05:29 +0000)
Subject: Re: bug#70230: 30.0.50;
 [PATCH] * lisp/master.el (master-says): check nil parameter
References: <CABCREdq2KCBk5U8BiY+4=ah4+bXfAwQsbsC9DfXvnQih6qU9eQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70230
Cc: 70230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lin Sun <sunlin7.mail@HIDDEN>
> Date: Sat, 6 Apr 2024 00:05:29 +0000
> 
> The `(master-says)' will trigger an unexpected error message with follow code:
> 
> (require 'master)
> (master-says)
> 
> > Wrong type argument: stringp, nil
> 
> The patch tries checking the nil parameter before calling `get-buffer'
> to avoid the unexpected err message.

Thanks, but "Slave buffer has disappeared" doesn't sound like a good
error message when master-of is nil, does it?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70230; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Apr 2024 06:38:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 06 02:38:50 2024
Received: from localhost ([127.0.0.1]:38019 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rszhQ-00077r-Su
	for submit <at> debbugs.gnu.org; Sat, 06 Apr 2024 02:38:50 -0400
Received: from lists.gnu.org ([2001:470:142::17]:33830)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sunlin7.mail@HIDDEN>) id 1rstZF-0004GA-Q8
 for submit <at> debbugs.gnu.org; Fri, 05 Apr 2024 20:06:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>)
 id 1rstZ4-0003lP-1X
 for bug-gnu-emacs@HIDDEN; Fri, 05 Apr 2024 20:05:46 -0400
Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>)
 id 1rstZ2-00071Q-Ea
 for bug-gnu-emacs@HIDDEN; Fri, 05 Apr 2024 20:05:45 -0400
Received: by mail-lj1-x233.google.com with SMTP id
 38308e7fff4ca-2d109e82bd0so30038981fa.3
 for <bug-gnu-emacs@HIDDEN>; Fri, 05 Apr 2024 17:05:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1712361941; x=1712966741; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=6R8p89/CLcNHQ3e5predhvFqeWe596Zr75imE1Ibz+Q=;
 b=VLlSMo9kb3V8mMNuMvhIMj9pv8OWQmxeF0fu7aM90TWghzq7fzjoZlHNwh5uOIyeYs
 w+HinbrLclA7mjiFglqw2qjMwHfvmBLUE/4AfUvNQfewh/hCBWP6w+Wbk2WYu0YNROVq
 FY8Xr1yebkYPeLO++M9VVMMMMV9ahcHWG2FlW0cEqwKruuTJoMrz76trNW3kCtYQlJcD
 6yZLV9/Qz1uIHMPBlppIn9loCfnT5RvK68Z9inhxFjil7goolo64qFIap3iIQEKpBxY4
 BbqzScnRWk1rK0zqdPMbwaaC9ro3WvppfTol5ooBY34IBVkIcgAlea+0T60Ol7/+0GS4
 0Ixg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1712361941; x=1712966741;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=6R8p89/CLcNHQ3e5predhvFqeWe596Zr75imE1Ibz+Q=;
 b=eR/MTntD/u0V3ST388iMT7JYEgzzE3BYOgZbEF1WBPGKiYCXHR3NYvRhY09tp7TZbs
 9qWVP4JmxJw/KijVTLNmvtYXy8qJ346GaHbXBWOzkMYC1Ld2aHunyyo9sl4aVT6s4wqy
 uc3GZZyiIfwrjgPA5NvngiVrPECGp2X2jKA+cXl/jmzdaGUsrRof1YxL7q95nvtnck2Q
 fxg5pC7JxaR+Q4LlnoTxNwowl4DaZuzNj1CWz33mvbBXdrHWLPV7ZKtbjqlcZ2Ah/nmk
 MPf4qGj1EpuhRdKA2WafYHt0Wj2M7jVB58qChVy6rILc+jZLD5vnr+DIuHQe3fUgTOec
 dXjw==
X-Gm-Message-State: AOJu0YyKj2/REHPK0GMx/GepdEBxIRgj3FI+NyLHZc37YuAfvgahTDIO
 lEtWQjXrSsQPIQhDqu980Lf+72/YTi8uJAmtm4OvbupPhJ+IblQvWczQfgmJZDmV8LRyKi+bsrb
 0TaWR9uJoq9qpnzD/TrI6AQDaXvEgVozRBNI=
X-Google-Smtp-Source: AGHT+IHy34wGKMuTD+kkcgO+MSHdy1bg/fmCQPjOSfoZfFUPqvliO6GK0XQeEKGa0EfTyuiD5cSlaPYpoRPjIO7eK/k=
X-Received: by 2002:ac2:59d0:0:b0:513:30fb:d64 with SMTP id
 x16-20020ac259d0000000b0051330fb0d64mr1928359lfn.44.1712361941214; Fri, 05
 Apr 2024 17:05:41 -0700 (PDT)
MIME-Version: 1.0
From: Lin Sun <sunlin7.mail@HIDDEN>
Date: Sat, 6 Apr 2024 00:05:29 +0000
Message-ID: <CABCREdq2KCBk5U8BiY+4=ah4+bXfAwQsbsC9DfXvnQih6qU9eQ@HIDDEN>
Subject: 30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="0000000000003c654a06156255f9"
Received-SPF: pass client-ip=2a00:1450:4864:20::233;
 envelope-from=sunlin7.mail@HIDDEN; helo=mail-lj1-x233.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 06 Apr 2024 02:38:41 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--0000000000003c654a06156255f9
Content-Type: text/plain; charset="UTF-8"

Hi,

The `(master-says)' will trigger an unexpected error message with follow code:

(require 'master)
(master-says)

> Wrong type argument: stringp, nil

The patch tries checking the nil parameter before calling `get-buffer'
to avoid the unexpected err message.

Please help check it. Thanks.

Best regards
Lin

--0000000000003c654a06156255f9
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-lisp-master.el-master-says-check-nil-parameter.patch"
Content-Disposition: attachment; 
	filename="0001-lisp-master.el-master-says-check-nil-parameter.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lunc2sg20>
X-Attachment-Id: f_lunc2sg20

RnJvbSA3YTBkY2RlNWZlYzJiN2I3ZmRkMWM3NGRiMTQ0MDE4M2MxMWNmY2E2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBG
cmksIDUgQXByIDIwMjQgMDY6NTg6MDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSAqIGxpc3AvbWFz
dGVyLmVsIChtYXN0ZXItc2F5cyk6IGNoZWNrIG5pbCBwYXJhbWV0ZXIKCi0tLQogbGlzcC9tYXN0
ZXIuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv
bigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbWFzdGVyLmVsIGIvbGlzcC9tYXN0ZXIuZWwKaW5kZXgg
MGNhZjRkNzk2My4uNGJkZjY4NjExMSAxMDA2NDQKLS0tIGEvbGlzcC9tYXN0ZXIuZWwKKysrIGIv
bGlzcC9tYXN0ZXIuZWwKQEAgLTEzNiw3ICsxMzYsOCBAQCBtYXN0ZXItc2F5cy1yZWNlbnRlcgog
KGRlZnVuIG1hc3Rlci1zYXlzICgmb3B0aW9uYWwgY29tbWFuZCBhcmcpCiAgICJEaXNwbGF5IHNs
YXZlIGJ1ZmZlciBhbmQgZXhlY3V0ZSBDT01NQU5EIHdpdGggQVJHIGluIGl0cyB3aW5kb3cuIgog
ICAoaW50ZXJhY3RpdmUpCi0gIChpZiAobnVsbCAoYnVmZmVyLWxpdmUtcCAoZ2V0LWJ1ZmZlciBt
YXN0ZXItb2YpKSkKKyAgKGlmIChub3QgKGFuZCBtYXN0ZXItb2YKKyAgICAgICAgICAgICAgICAo
YnVmZmVyLWxpdmUtcCAoZ2V0LWJ1ZmZlciBtYXN0ZXItb2YpKSkpCiAgICAgICAoZXJyb3IgIlNs
YXZlIGJ1ZmZlciBoYXMgZGlzYXBwZWFyZWQiKQogICAgIChsZXQgKCh3aW5kb3cgIChzZWxlY3Rl
ZC13aW5kb3cpKSkKICAgICAgIChpZiAobm90IChlcSAod2luZG93LWJ1ZmZlciB3aW5kb3cpIChn
ZXQtYnVmZmVyIG1hc3Rlci1vZikpKQotLSAKMi4yMC41Cgo=
--0000000000003c654a06156255f9--




Acknowledgement sent to Lin Sun <sunlin7.mail@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#70230; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 6 Apr 2024 08:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.