GNU bug report logs - #70249
[PATCH] gnu: open-ssh-session: Don’t require public key.

Previous Next

To reply to this bug, email your comments to 70249 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: guix-patches <at> gnu.org
Cc: Ian Eure <ian <at> retrospec.tv>
Subject: [PATCH] gnu: open-ssh-session: Don’t require public key.
Date: Sat,  6 Apr 2024 16:17:06 -0700

* guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
Public keys aren’t required for client connections, and this binding is
unused.  The behavior of assuming a ".pub"-suffixed file exists in the same
directory as the secret key is undocumented and surprising.

Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
---
 guix/scripts/offload.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 137e3b5fe3..93e9d3759c 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time)
 When MAX-SILENT-TIME is true, it must be a positive integer denoting the
 number of seconds after which the connection times out."
   (let ((private (private-key-from-file* (build-machine-private-key machine)))
-        (public  (public-key-from-file
-                  (string-append (build-machine-private-key machine)
-                                 ".pub")))
         (session (make-session #:user (build-machine-user machine)
                                #:host (build-machine-name machine)
                                #:port (build-machine-port machine)

base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79
-- 
2.41.0

Message #10 received at 70249-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ian Eure <ian <at> retrospec.tv>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 70249-done <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key.
Date: Sun, 07 Apr 2024 20:32:55 +0100

[Message part 1 (text/plain, inline)]

Ian Eure <ian <at> retrospec.tv> writes:

> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused.  The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
>  guix/scripts/offload.scm | 3 ---
>  1 file changed, 3 deletions(-)

I can't see how this binding is used either, so I've pushed this to
master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.