GNU bug report logs - #70259
[PATCH] gnu: evolution-data-server-3.44: Disable failing test on aarch64.

Previous Next

To reply to this bug, email your comments to 70259 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH] gnu: evolution-data-server-3.44: Disable failing test on
 aarch64.
Date: Sun,  7 Apr 2024 15:03:15 +0200

* gnu/packages/gnome.scm (evolution-data-server-3.44): Disable failing test on aarch64.

Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
---
 gnu/packages/gnome.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4934ade3dd..933ff8179f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8302,7 +8302,17 @@ (define-public evolution-data-server-3.44
     (propagated-inputs
      (modify-inputs (package-propagated-inputs evolution-data-server)
        (delete "gtk")
-       (replace "libsoup" libsoup-minimal-2)))))
+       (replace "libsoup" libsoup-minimal-2)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments evolution-data-server)
+       ((#:phases phases '%standard-phases)
+        #~(modify-phases #$phases
+            #$@(if (target-aarch64?)
+                   #~((add-after 'unpack 'disable-failing-tests
+                        (lambda _
+                          (substitute* "tests/libebook/client/CMakeLists.txt"
+                            (("test-book-client-custom-summary") "")))))
+                   '())))))))
 
 (define-public caribou
   (package

base-commit: 12f02c9bb87b8ea756e5c09806522e6df8b7e1ca
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
prerequisite-patch-id: 6f659e1af6f034cd0f3541f605fa7c0f12845380
-- 
2.41.0

Message #8 received at 70259 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: 70259 <at> debbugs.gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH v2] gnu: evolution-data-server: Disable failing test on
 aarch64.
Date: Sun,  7 Apr 2024 15:23:20 +0200

* gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.

Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
---

Just after I fixed evolution-data-server-3.44, the evolution-data-server
packages also started to fail. This test is flaky on my aarch64 machine.

gnu/packages/gnome.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4934ade3dd..7a58c01e8c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8219,6 +8219,12 @@ (define-public evolution-data-server
                 "-DWITH_PHONENUMBER=ON"))
       #:phases
       #~(modify-phases %standard-phases
+          #$@(if (target-aarch64?)
+                   #~((add-after 'unpack 'disable-failing-aarch64-tests
+                        (lambda _
+                          (substitute* "tests/libebook/client/CMakeLists.txt"
+                            (("test-book-client-custom-summary") "")))))
+                   '())
           (add-after 'unpack 'disable-failing-tests
             (lambda _
               ;; tests/book-migration/test-migration.c:160:test_fetch_contacts:

base-commit: 12f02c9bb87b8ea756e5c09806522e6df8b7e1ca
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
prerequisite-patch-id: 6f659e1af6f034cd0f3541f605fa7c0f12845380
--
2.41.0

Message #11 received at 70259 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 70259 <at> debbugs.gnu.org, Raghav Gururajan <rg <at> raghavgururajan.name>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#70259] [PATCH v2] gnu: evolution-data-server: Disable
 failing test on aarch64.
Date: Mon, 15 Apr 2024 10:05:29 +0100

[Message part 1 (text/plain, inline)]

Roman Scherer <roman <at> burningswell.com> writes:

> * gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.
>
> Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
> ---
>
> Just after I fixed evolution-data-server-3.44, the evolution-data-server
> packages also started to fail. This test is flaky on my aarch64 machine.
>
> gnu/packages/gnome.scm | 6 ++++++
>  1 file changed, 6 insertions(+)

Could you include the bit about the test being flaky in a comment, and
maybe also some information about how it fails (so that others can see
if they get a similar failure)?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 70259 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Roman Scherer <roman <at> burningswell.com>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 70259 <at> debbugs.gnu.org,
 Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#70259] [PATCH v2] gnu: evolution-data-server: Disable
 failing test on aarch64.
Date: Mon, 15 Apr 2024 19:43:23 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

Hi Christopher,

thanks for looking into this. Building evolution-data-server fails on my
Apple M1. I attached a new patch that contains the build error message
in the commit.

Roman

[v3-0001-gnu-evolution-data-server-Disable-failing-test-on.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

> Roman Scherer <roman <at> burningswell.com> writes:
>
>> * gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.
>>
>> Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
>> ---
>>
>> Just after I fixed evolution-data-server-3.44, the evolution-data-server
>> packages also started to fail. This test is flaky on my aarch64 machine.
>>
>> gnu/packages/gnome.scm | 6 ++++++
>>  1 file changed, 6 insertions(+)
>
> Could you include the bit about the test being flaky in a comment, and
> maybe also some information about how it fails (so that others can see
> if they get a similar failure)?
>
> Thanks,
>
> Chris

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 70259-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: Roman Scherer <roman <at> burningswell.com>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 70259-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#70259] [PATCH v2] gnu: evolution-data-server: Disable
 failing test on aarch64.
Date: Wed, 17 Apr 2024 18:11:20 +0100

[Message part 1 (text/plain, inline)]

Roman Scherer <roman.scherer <at> burningswell.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
> Hi Christopher,
>
> thanks for looking into this. Building evolution-data-server fails on my
> Apple M1. I attached a new patch that contains the build error message
> in the commit.

Thanks, I've pushed this to master as
77acd4b4aaecea72a7b5249f602eac8bea67880b.

Chris

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 70259 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: Roman Scherer <roman <at> burningswell.com>,
 Vivien Kraus <vivien <at> planete-kraus.eu>, Christopher Baines <mail <at> cbaines.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 70259 <at> debbugs.gnu.org,
 Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#70259] [PATCH v2] gnu: evolution-data-server: Disable
 failing test on aarch64.
Date: Thu, 18 Apr 2024 21:53:21 -0400

Hi Roman,

Roman Scherer <roman.scherer <at> burningswell.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
> Hi Christopher,
>
> thanks for looking into this. Building evolution-data-server fails on my
> Apple M1. I attached a new patch that contains the build error message
> in the commit.

Also, a nitpick to mind for the future: it'd be even nicer to have a
link to the upstream issue registered for this problem, so that it
eventually gets fixed and can be removed on our side.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.